Adopt Node-native TypeScript for desktop and server - #2098

Merged
juliusmarminge merged 4 commits into
mainfrom
t3code/node-typescript-dev
Apr 17, 2026
Merged

Adopt Node-native TypeScript for desktop and server#2098
juliusmarminge merged 4 commits into
mainfrom
t3code/node-typescript-dev

Conversation

@juliusmarminge

@juliusmarmingejuliusmarminge commented Apr 17, 2026

Copy link
Copy Markdown
Member

Makes dev work on windows

Summary

  • Switch desktop and server entrypoints and scripts to Node-native TypeScript execution.
  • Update local imports to include explicit .ts extensions and tighten type-only imports across the codebase.
  • Adjust TypeScript configs and package scripts for the new module/runtime setup.
  • Add and expand tests for release tooling and runtime helpers affected by the migration.

Testing

  • Not run (PR content prepared from the committed changes).
  • Existing Vitest coverage was updated alongside the TypeScript/runtime migration.
  • New tests were added for scripts such as manifest merging, mock update server behavior, and release package version updates.

Note

Medium Risk
Medium risk because it changes runtime entrypoints/build artifacts (Bun→Node execution, .js.cjs, NodeNext import rules) across desktop and server; misconfigured paths or module resolution could break dev/build/packaging, especially Electron preload/main loading and release tooling.

Overview
Migrates desktop + server execution/build away from Bun-centric assumptions toward Node-native TypeScript (NodeNext), including switching many local relative imports to explicit .ts extensions and tightening import type usage to satisfy verbatimModuleSyntax/erasableSyntaxOnly.

Desktop now builds CommonJS artifacts as .cjs (e.g. main.cjs, preload.cjs) and updates Electron launch/start/dev/smoke-test code and CI verification accordingly; macOS launcher behavior is adjusted to skip the renamed app bundle in dev to avoid helper resource lookup issues.

Server scripts are updated to run under Node (node --watch dev, build:bundle via tsdown), publishing prep resolves catalog: deps into concrete versions, and runtime/version reads switch to importing package.json as an object. Web tsconfig adds overrides to opt out of some NodeNext strictness.

Reviewed by Cursor Bugbot for commit dacc401. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Adopt Node-native TypeScript module resolution for desktop and server packages

  • Switches tsconfig.base.json to NodeNext module/moduleResolution with rewriteRelativeImportExtensions, erasableSyntaxOnly, and verbatimModuleSyntax, requiring explicit .ts extensions on all relative imports across apps/desktop, apps/server, packages/shared, packages/contracts, and packages/client-runtime.
  • Desktop and server dev/start scripts now use node instead of bun; desktop build output switches from .js to .cjs via tsdown.config.ts, and all launchers, smoke tests, and CI steps are updated to reference main.cjs and preload.cjs.
  • Scripts (merge-update-manifests, update-release-package-versions, mock-update-server) are rewritten as Effect-based CLIs with import.meta.main guards so importing them no longer triggers execution.
  • qrCode.ts is refactored from a TypeScript namespace to top-level exports with non-null assertions to satisfy erasableSyntaxOnly.
  • Risk: any tooling or import that previously resolved extensionless .ts paths will break; the apps/web tsconfig explicitly opts out by setting module: Preserve and verbatimModuleSyntax: false.

Macroscope summarized dacc401.

- Switch desktop and server entrypoints to run under Node ESM/TS
- Update imports, type-only imports, and build scripts for .ts resolution
- Refresh config and tests to match the new module/runtime setup
@coderabbitai

coderabbitaiBot commented Apr 17, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: bd35bb6e-7e67-467d-9984-1dc6dea69b31

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch t3code/node-typescript-dev

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XXL 1,000+ changed lines (additions + deletions). labels Apr 17, 2026

@cursorcursorBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix prepared a fix for the issue found in the latest run.

  • ✅ Fixed: Test asserts wrong property name TCODE_HOME
    • Fixed typo on line 66 of dev-runner.test.ts: changed env.TCODE_HOME to env.T3CODE_HOME to match the production code's property name.

Create PR

Or push these changes by commenting:

@cursor push c76b559076
Preview (c76b559076)
diff --git a/scripts/dev-runner.test.ts b/scripts/dev-runner.test.ts--- a/scripts/dev-runner.test.ts+++ b/scripts/dev-runner.test.ts@@ -63,7 +63,7 @@
devUrl: undefined,
});
- assert.equal(env.TCODE_HOME, path.resolve(NodeOS.homedir(), ".t3"));+ assert.equal(env.T3CODE_HOME, path.resolve(NodeOS.homedir(), ".t3"));
}),
);

You can send follow-ups to the cloud agent here.

Reviewed by Cursor Bugbot for commit 91f2896. Configure here.

Comment threadscripts/dev-runner.test.ts Outdated
@macroscopeapp

macroscopeappBot commented Apr 17, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved

Large but mechanical build infrastructure change adopting Node's native TypeScript support. The diff is dominated by import path updates (adding .ts extensions), output file extension changes (.js.cjs), and bunnode script runner switches. The qrCode.ts namespace-to-class refactor is purely syntactic. Runtime impact is limited to consistent file path updates for Electron artifacts.

You can customize Macroscope's approvability policy. Learn more.

- Update expectation to `T3CODE_HOME`
- Reflect the current home-directory env name
- Update desktop build, launch, and smoke-test paths to .cjs
- Align CI and artifact packaging with the new bundle names
- Skip macOS helper bundle patching during dev launches
- Lift qrcodegen namespace into top-level exports
- Add explicit QR code fields and stricter typed access
- Co-authored-by: codex <codex@users.noreply.github.com>
@juliusmarminge
juliusmarminge merged commit 8dba2d6 into mainApr 17, 2026
12 checks passed
@juliusmarminge
juliusmarminge deleted the t3code/node-typescript-dev branch April 17, 2026 05:14
znoraka pushed a commit to znoraka/t3code that referenced this pull request Apr 17, 2026
aaditagrawal added a commit to aaditagrawal/t3code that referenced this pull request Apr 18, 2026
Integrates upstream/main (9df3c64) on top of fork's main (9602c18).
Upstream features adopted:
- Claude Opus 4.5 and 4.7 built-in models (pingdotgg#2072, pingdotgg#2143)
- Node-native TypeScript migration across desktop/server (pingdotgg#2098)
- Configurable project grouping with client-settings overrides (pingdotgg#2055, pingdotgg#2099)
- Thread status in command palette (pingdotgg#2107)
- Responsive composer / plan sidebar on narrow windows (pingdotgg#1198)
- Capture-phase CTRL+J keydown for Windows terminal toggle (pingdotgg#2113/pingdotgg#2142)
- Bypass xterm for global terminal shortcuts (pingdotgg#1580)
- Windows ARM build target (pingdotgg#2080)
- Windows PATH hydration + repair (pingdotgg#1729)
- Gitignore-aware workspace search (pingdotgg#2078)
- Claude process leak fix + stale session monitoring (pingdotgg#2042)
- Preserve provider bindings when stopping sessions (pingdotgg#2084)
- Clean up invalid pending-approval projections (pingdotgg#2106) — new migration
- Extract backend startup readiness coordination
- Drop stale text-gen options on reset (pingdotgg#2076)
- Extend negative repository identity cache TTL (pingdotgg#2083)
- Allow deleting non-empty projects from warning toast (pingdotgg#1264)
- Restore defaults only on General settings (pingdotgg#1710)
- Release workflow modernization (blacksmith runners, GitHub App token guards, v0.0.20 version bump)
Fork features preserved:
- All 8 providers (codex, claudeAgent, copilot, cursor, opencode,
geminiCli, amp, kilo) with their adapters, services, and tests
- Fork's custom OpenCode protocol impl in apps/server/src/opencode/ (kept
over upstream's @opencode-ai/sdk-based provider added in pingdotgg#1758 — fork's
version is tested and integrated; upstream's parallel files deleted)
- Fork's direct-CLI Cursor adapter (kept over upstream's new ACP-based
CursorProvider added in pingdotgg#1355 — upstream's parallel files deleted)
- Fork's ProviderRegistry aggregates only codex + claudeAgent snapshots;
the other 6 providers register via ProviderAdapterRegistry
- PROVIDER_CACHE_IDS stays at [codex, claudeAgent] matching what the
registry actually caches
- Migration IDs preserved (fork 23/24/25/26; upstream's new 025 lands at
ID 27 to avoid re-applying on deployed fork DBs)
- Fork's generic per-provider settings (enabled/binaryPath/configDir/
customModels) kept over upstream's opencode-specific serverUrl/password
- Log directory IPC channels, updateInstallInFlight tracking, icon
composer pipeline all preserved
- Fork's simplified release.yml (no npm CLI publish, no nightly infra)
- composerDraftStore normalizeProviderKind widened to accept all 8 kinds
- Dark mode --background set to #0f0f0f
Test status:
- All 9 package typechecks pass
- Lint clean (0 errors)
- Tests: 1877 passed, 15 skipped (incl. 4 historically-flaky GitManager
cross-repo PR selector tests newly gated with TODO for Node-native-TS
follow-up)
alecramos-sudo added a commit to alecramos-sudo/t3code that referenced this pull request Apr 20, 2026
Brings in upstream changes since d22c6f5:
- Claude Opus 4.5 built-in model (pingdotgg#2143)
- Claude Opus 4.7 built-in model (pingdotgg#2072)
- opencode provider support (pingdotgg#1758)
- Claude process leak fix & session reaper (pingdotgg#2042)
- Configurable project grouping (pingdotgg#2055)
- Node-native TypeScript for desktop/server (pingdotgg#2098)
- Clean up invalid pending approval projections (pingdotgg#2106)
- Thread status in command palette (pingdotgg#2107)
- Backend startup readiness coordination (pingdotgg#2133)
- Preserve provider bindings on session stop (pingdotgg#2125)
- Allow deleting non-empty projects (pingdotgg#1264)
- Various Windows fixes and CI improvements
Conflict resolutions:
- model.ts: kept claudeAgent opus-4-7 default, added opencode entry
- settings.ts: adopted upstream sidebarProjectGroupingMode/Overrides
- ClaudeProvider.ts: adopted upstream Opus 4.7 effort config
- Sidebar.tsx: adopted upstream project grouping approach
- package.json: kept custom desktop-only build filter
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
MuneerAhmed03 pushed a commit to MuneerAhmed03/t3code that referenced this pull request Apr 26, 2026
NeilTheFisher pushed a commit to NeilTheFisher/t3code that referenced this pull request Aug 18, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XXL1,000+ changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@juliusmarminge
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

Adopt Node-native TypeScript for desktop and server - #2098

Merged
juliusmarminge merged 4 commits into
mainfrom
t3code/node-typescript-dev
Apr 17, 2026
Merged

Adopt Node-native TypeScript for desktop and server#2098
juliusmarminge merged 4 commits into
mainfrom
t3code/node-typescript-dev

Conversation

@juliusmarminge

@juliusmarmingejuliusmarminge commented Apr 17, 2026

Copy link
Copy Markdown
Member

Makes dev work on windows

Summary

  • Switch desktop and server entrypoints and scripts to Node-native TypeScript execution.
  • Update local imports to include explicit .ts extensions and tighten type-only imports across the codebase.
  • Adjust TypeScript configs and package scripts for the new module/runtime setup.
  • Add and expand tests for release tooling and runtime helpers affected by the migration.

Testing

  • Not run (PR content prepared from the committed changes).
  • Existing Vitest coverage was updated alongside the TypeScript/runtime migration.
  • New tests were added for scripts such as manifest merging, mock update server behavior, and release package version updates.

Note

Medium Risk
Medium risk because it changes runtime entrypoints/build artifacts (Bun→Node execution, .js.cjs, NodeNext import rules) across desktop and server; misconfigured paths or module resolution could break dev/build/packaging, especially Electron preload/main loading and release tooling.

Overview
Migrates desktop + server execution/build away from Bun-centric assumptions toward Node-native TypeScript (NodeNext), including switching many local relative imports to explicit .ts extensions and tightening import type usage to satisfy verbatimModuleSyntax/erasableSyntaxOnly.

Desktop now builds CommonJS artifacts as .cjs (e.g. main.cjs, preload.cjs) and updates Electron launch/start/dev/smoke-test code and CI verification accordingly; macOS launcher behavior is adjusted to skip the renamed app bundle in dev to avoid helper resource lookup issues.

Server scripts are updated to run under Node (node --watch dev, build:bundle via tsdown), publishing prep resolves catalog: deps into concrete versions, and runtime/version reads switch to importing package.json as an object. Web tsconfig adds overrides to opt out of some NodeNext strictness.

Reviewed by Cursor Bugbot for commit dacc401. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Adopt Node-native TypeScript module resolution for desktop and server packages

  • Switches tsconfig.base.json to NodeNext module/moduleResolution with rewriteRelativeImportExtensions, erasableSyntaxOnly, and verbatimModuleSyntax, requiring explicit .ts extensions on all relative imports across apps/desktop, apps/server, packages/shared, packages/contracts, and packages/client-runtime.
  • Desktop and server dev/start scripts now use node instead of bun; desktop build output switches from .js to .cjs via tsdown.config.ts, and all launchers, smoke tests, and CI steps are updated to reference main.cjs and preload.cjs.
  • Scripts (merge-update-manifests, update-release-package-versions, mock-update-server) are rewritten as Effect-based CLIs with import.meta.main guards so importing them no longer triggers execution.
  • qrCode.ts is refactored from a TypeScript namespace to top-level exports with non-null assertions to satisfy erasableSyntaxOnly.
  • Risk: any tooling or import that previously resolved extensionless .ts paths will break; the apps/web tsconfig explicitly opts out by setting module: Preserve and verbatimModuleSyntax: false.

Macroscope summarized dacc401.

- Switch desktop and server entrypoints to run under Node ESM/TS
- Update imports, type-only imports, and build scripts for .ts resolution
- Refresh config and tests to match the new module/runtime setup
@coderabbitai

coderabbitaiBot commented Apr 17, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: bd35bb6e-7e67-467d-9984-1dc6dea69b31

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch t3code/node-typescript-dev

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XXL 1,000+ changed lines (additions + deletions). labels Apr 17, 2026

@cursorcursorBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix prepared a fix for the issue found in the latest run.

  • ✅ Fixed: Test asserts wrong property name TCODE_HOME
    • Fixed typo on line 66 of dev-runner.test.ts: changed env.TCODE_HOME to env.T3CODE_HOME to match the production code's property name.

Create PR

Or push these changes by commenting:

@cursor push c76b559076
Preview (c76b559076)
diff --git a/scripts/dev-runner.test.ts b/scripts/dev-runner.test.ts--- a/scripts/dev-runner.test.ts+++ b/scripts/dev-runner.test.ts@@ -63,7 +63,7 @@
devUrl: undefined,
});
- assert.equal(env.TCODE_HOME, path.resolve(NodeOS.homedir(), ".t3"));+ assert.equal(env.T3CODE_HOME, path.resolve(NodeOS.homedir(), ".t3"));
}),
);

You can send follow-ups to the cloud agent here.

Reviewed by Cursor Bugbot for commit 91f2896. Configure here.

Comment threadscripts/dev-runner.test.ts Outdated
@macroscopeapp

macroscopeappBot commented Apr 17, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved

Large but mechanical build infrastructure change adopting Node's native TypeScript support. The diff is dominated by import path updates (adding .ts extensions), output file extension changes (.js.cjs), and bunnode script runner switches. The qrCode.ts namespace-to-class refactor is purely syntactic. Runtime impact is limited to consistent file path updates for Electron artifacts.

You can customize Macroscope's approvability policy. Learn more.

- Update expectation to `T3CODE_HOME`
- Reflect the current home-directory env name
- Update desktop build, launch, and smoke-test paths to .cjs
- Align CI and artifact packaging with the new bundle names
- Skip macOS helper bundle patching during dev launches
- Lift qrcodegen namespace into top-level exports
- Add explicit QR code fields and stricter typed access
- Co-authored-by: codex <codex@users.noreply.github.com>
@juliusmarminge
juliusmarminge merged commit 8dba2d6 into mainApr 17, 2026
12 checks passed
@juliusmarminge
juliusmarminge deleted the t3code/node-typescript-dev branch April 17, 2026 05:14
znoraka pushed a commit to znoraka/t3code that referenced this pull request Apr 17, 2026
aaditagrawal added a commit to aaditagrawal/t3code that referenced this pull request Apr 18, 2026
Integrates upstream/main (9df3c64) on top of fork's main (9602c18).
Upstream features adopted:
- Claude Opus 4.5 and 4.7 built-in models (pingdotgg#2072, pingdotgg#2143)
- Node-native TypeScript migration across desktop/server (pingdotgg#2098)
- Configurable project grouping with client-settings overrides (pingdotgg#2055, pingdotgg#2099)
- Thread status in command palette (pingdotgg#2107)
- Responsive composer / plan sidebar on narrow windows (pingdotgg#1198)
- Capture-phase CTRL+J keydown for Windows terminal toggle (pingdotgg#2113/pingdotgg#2142)
- Bypass xterm for global terminal shortcuts (pingdotgg#1580)
- Windows ARM build target (pingdotgg#2080)
- Windows PATH hydration + repair (pingdotgg#1729)
- Gitignore-aware workspace search (pingdotgg#2078)
- Claude process leak fix + stale session monitoring (pingdotgg#2042)
- Preserve provider bindings when stopping sessions (pingdotgg#2084)
- Clean up invalid pending-approval projections (pingdotgg#2106) — new migration
- Extract backend startup readiness coordination
- Drop stale text-gen options on reset (pingdotgg#2076)
- Extend negative repository identity cache TTL (pingdotgg#2083)
- Allow deleting non-empty projects from warning toast (pingdotgg#1264)
- Restore defaults only on General settings (pingdotgg#1710)
- Release workflow modernization (blacksmith runners, GitHub App token guards, v0.0.20 version bump)
Fork features preserved:
- All 8 providers (codex, claudeAgent, copilot, cursor, opencode,
geminiCli, amp, kilo) with their adapters, services, and tests
- Fork's custom OpenCode protocol impl in apps/server/src/opencode/ (kept
over upstream's @opencode-ai/sdk-based provider added in pingdotgg#1758 — fork's
version is tested and integrated; upstream's parallel files deleted)
- Fork's direct-CLI Cursor adapter (kept over upstream's new ACP-based
CursorProvider added in pingdotgg#1355 — upstream's parallel files deleted)
- Fork's ProviderRegistry aggregates only codex + claudeAgent snapshots;
the other 6 providers register via ProviderAdapterRegistry
- PROVIDER_CACHE_IDS stays at [codex, claudeAgent] matching what the
registry actually caches
- Migration IDs preserved (fork 23/24/25/26; upstream's new 025 lands at
ID 27 to avoid re-applying on deployed fork DBs)
- Fork's generic per-provider settings (enabled/binaryPath/configDir/
customModels) kept over upstream's opencode-specific serverUrl/password
- Log directory IPC channels, updateInstallInFlight tracking, icon
composer pipeline all preserved
- Fork's simplified release.yml (no npm CLI publish, no nightly infra)
- composerDraftStore normalizeProviderKind widened to accept all 8 kinds
- Dark mode --background set to #0f0f0f
Test status:
- All 9 package typechecks pass
- Lint clean (0 errors)
- Tests: 1877 passed, 15 skipped (incl. 4 historically-flaky GitManager
cross-repo PR selector tests newly gated with TODO for Node-native-TS
follow-up)
alecramos-sudo added a commit to alecramos-sudo/t3code that referenced this pull request Apr 20, 2026
Brings in upstream changes since d22c6f5:
- Claude Opus 4.5 built-in model (pingdotgg#2143)
- Claude Opus 4.7 built-in model (pingdotgg#2072)
- opencode provider support (pingdotgg#1758)
- Claude process leak fix & session reaper (pingdotgg#2042)
- Configurable project grouping (pingdotgg#2055)
- Node-native TypeScript for desktop/server (pingdotgg#2098)
- Clean up invalid pending approval projections (pingdotgg#2106)
- Thread status in command palette (pingdotgg#2107)
- Backend startup readiness coordination (pingdotgg#2133)
- Preserve provider bindings on session stop (pingdotgg#2125)
- Allow deleting non-empty projects (pingdotgg#1264)
- Various Windows fixes and CI improvements
Conflict resolutions:
- model.ts: kept claudeAgent opus-4-7 default, added opencode entry
- settings.ts: adopted upstream sidebarProjectGroupingMode/Overrides
- ClaudeProvider.ts: adopted upstream Opus 4.7 effort config
- Sidebar.tsx: adopted upstream project grouping approach
- package.json: kept custom desktop-only build filter
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
MuneerAhmed03 pushed a commit to MuneerAhmed03/t3code that referenced this pull request Apr 26, 2026
NeilTheFisher pushed a commit to NeilTheFisher/t3code that referenced this pull request Aug 18, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XXL1,000+ changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@juliusmarminge
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Adopt Node-native TypeScript for desktop and server - #2098

Merged
juliusmarminge merged 4 commits into
mainfrom
t3code/node-typescript-dev
Apr 17, 2026
Merged

Adopt Node-native TypeScript for desktop and server#2098
juliusmarminge merged 4 commits into
mainfrom
t3code/node-typescript-dev

Conversation

@juliusmarminge

@juliusmarmingejuliusmarminge commented Apr 17, 2026

Copy link
Copy Markdown
Member

Makes dev work on windows

Summary

  • Switch desktop and server entrypoints and scripts to Node-native TypeScript execution.
  • Update local imports to include explicit .ts extensions and tighten type-only imports across the codebase.
  • Adjust TypeScript configs and package scripts for the new module/runtime setup.
  • Add and expand tests for release tooling and runtime helpers affected by the migration.

Testing

  • Not run (PR content prepared from the committed changes).
  • Existing Vitest coverage was updated alongside the TypeScript/runtime migration.
  • New tests were added for scripts such as manifest merging, mock update server behavior, and release package version updates.

Note

Medium Risk
Medium risk because it changes runtime entrypoints/build artifacts (Bun→Node execution, .js.cjs, NodeNext import rules) across desktop and server; misconfigured paths or module resolution could break dev/build/packaging, especially Electron preload/main loading and release tooling.

Overview
Migrates desktop + server execution/build away from Bun-centric assumptions toward Node-native TypeScript (NodeNext), including switching many local relative imports to explicit .ts extensions and tightening import type usage to satisfy verbatimModuleSyntax/erasableSyntaxOnly.

Desktop now builds CommonJS artifacts as .cjs (e.g. main.cjs, preload.cjs) and updates Electron launch/start/dev/smoke-test code and CI verification accordingly; macOS launcher behavior is adjusted to skip the renamed app bundle in dev to avoid helper resource lookup issues.

Server scripts are updated to run under Node (node --watch dev, build:bundle via tsdown), publishing prep resolves catalog: deps into concrete versions, and runtime/version reads switch to importing package.json as an object. Web tsconfig adds overrides to opt out of some NodeNext strictness.

Reviewed by Cursor Bugbot for commit dacc401. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Adopt Node-native TypeScript module resolution for desktop and server packages

  • Switches tsconfig.base.json to NodeNext module/moduleResolution with rewriteRelativeImportExtensions, erasableSyntaxOnly, and verbatimModuleSyntax, requiring explicit .ts extensions on all relative imports across apps/desktop, apps/server, packages/shared, packages/contracts, and packages/client-runtime.
  • Desktop and server dev/start scripts now use node instead of bun; desktop build output switches from .js to .cjs via tsdown.config.ts, and all launchers, smoke tests, and CI steps are updated to reference main.cjs and preload.cjs.
  • Scripts (merge-update-manifests, update-release-package-versions, mock-update-server) are rewritten as Effect-based CLIs with import.meta.main guards so importing them no longer triggers execution.
  • qrCode.ts is refactored from a TypeScript namespace to top-level exports with non-null assertions to satisfy erasableSyntaxOnly.
  • Risk: any tooling or import that previously resolved extensionless .ts paths will break; the apps/web tsconfig explicitly opts out by setting module: Preserve and verbatimModuleSyntax: false.

Macroscope summarized dacc401.

- Switch desktop and server entrypoints to run under Node ESM/TS
- Update imports, type-only imports, and build scripts for .ts resolution
- Refresh config and tests to match the new module/runtime setup
@coderabbitai

coderabbitaiBot commented Apr 17, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: bd35bb6e-7e67-467d-9984-1dc6dea69b31

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch t3code/node-typescript-dev

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XXL 1,000+ changed lines (additions + deletions). labels Apr 17, 2026

@cursorcursorBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix prepared a fix for the issue found in the latest run.

  • ✅ Fixed: Test asserts wrong property name TCODE_HOME
    • Fixed typo on line 66 of dev-runner.test.ts: changed env.TCODE_HOME to env.T3CODE_HOME to match the production code's property name.

Create PR

Or push these changes by commenting:

@cursor push c76b559076
Preview (c76b559076)
diff --git a/scripts/dev-runner.test.ts b/scripts/dev-runner.test.ts--- a/scripts/dev-runner.test.ts+++ b/scripts/dev-runner.test.ts@@ -63,7 +63,7 @@
devUrl: undefined,
});
- assert.equal(env.TCODE_HOME, path.resolve(NodeOS.homedir(), ".t3"));+ assert.equal(env.T3CODE_HOME, path.resolve(NodeOS.homedir(), ".t3"));
}),
);

You can send follow-ups to the cloud agent here.

Reviewed by Cursor Bugbot for commit 91f2896. Configure here.

Comment threadscripts/dev-runner.test.ts Outdated
@macroscopeapp

macroscopeappBot commented Apr 17, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved

Large but mechanical build infrastructure change adopting Node's native TypeScript support. The diff is dominated by import path updates (adding .ts extensions), output file extension changes (.js.cjs), and bunnode script runner switches. The qrCode.ts namespace-to-class refactor is purely syntactic. Runtime impact is limited to consistent file path updates for Electron artifacts.

You can customize Macroscope's approvability policy. Learn more.

- Update expectation to `T3CODE_HOME`
- Reflect the current home-directory env name
- Update desktop build, launch, and smoke-test paths to .cjs
- Align CI and artifact packaging with the new bundle names
- Skip macOS helper bundle patching during dev launches
- Lift qrcodegen namespace into top-level exports
- Add explicit QR code fields and stricter typed access
- Co-authored-by: codex <codex@users.noreply.github.com>
@juliusmarminge
juliusmarminge merged commit 8dba2d6 into mainApr 17, 2026
12 checks passed
@juliusmarminge
juliusmarminge deleted the t3code/node-typescript-dev branch April 17, 2026 05:14
znoraka pushed a commit to znoraka/t3code that referenced this pull request Apr 17, 2026
aaditagrawal added a commit to aaditagrawal/t3code that referenced this pull request Apr 18, 2026
Integrates upstream/main (9df3c64) on top of fork's main (9602c18).
Upstream features adopted:
- Claude Opus 4.5 and 4.7 built-in models (pingdotgg#2072, pingdotgg#2143)
- Node-native TypeScript migration across desktop/server (pingdotgg#2098)
- Configurable project grouping with client-settings overrides (pingdotgg#2055, pingdotgg#2099)
- Thread status in command palette (pingdotgg#2107)
- Responsive composer / plan sidebar on narrow windows (pingdotgg#1198)
- Capture-phase CTRL+J keydown for Windows terminal toggle (pingdotgg#2113/pingdotgg#2142)
- Bypass xterm for global terminal shortcuts (pingdotgg#1580)
- Windows ARM build target (pingdotgg#2080)
- Windows PATH hydration + repair (pingdotgg#1729)
- Gitignore-aware workspace search (pingdotgg#2078)
- Claude process leak fix + stale session monitoring (pingdotgg#2042)
- Preserve provider bindings when stopping sessions (pingdotgg#2084)
- Clean up invalid pending-approval projections (pingdotgg#2106) — new migration
- Extract backend startup readiness coordination
- Drop stale text-gen options on reset (pingdotgg#2076)
- Extend negative repository identity cache TTL (pingdotgg#2083)
- Allow deleting non-empty projects from warning toast (pingdotgg#1264)
- Restore defaults only on General settings (pingdotgg#1710)
- Release workflow modernization (blacksmith runners, GitHub App token guards, v0.0.20 version bump)
Fork features preserved:
- All 8 providers (codex, claudeAgent, copilot, cursor, opencode,
geminiCli, amp, kilo) with their adapters, services, and tests
- Fork's custom OpenCode protocol impl in apps/server/src/opencode/ (kept
over upstream's @opencode-ai/sdk-based provider added in pingdotgg#1758 — fork's
version is tested and integrated; upstream's parallel files deleted)
- Fork's direct-CLI Cursor adapter (kept over upstream's new ACP-based
CursorProvider added in pingdotgg#1355 — upstream's parallel files deleted)
- Fork's ProviderRegistry aggregates only codex + claudeAgent snapshots;
the other 6 providers register via ProviderAdapterRegistry
- PROVIDER_CACHE_IDS stays at [codex, claudeAgent] matching what the
registry actually caches
- Migration IDs preserved (fork 23/24/25/26; upstream's new 025 lands at
ID 27 to avoid re-applying on deployed fork DBs)
- Fork's generic per-provider settings (enabled/binaryPath/configDir/
customModels) kept over upstream's opencode-specific serverUrl/password
- Log directory IPC channels, updateInstallInFlight tracking, icon
composer pipeline all preserved
- Fork's simplified release.yml (no npm CLI publish, no nightly infra)
- composerDraftStore normalizeProviderKind widened to accept all 8 kinds
- Dark mode --background set to #0f0f0f
Test status:
- All 9 package typechecks pass
- Lint clean (0 errors)
- Tests: 1877 passed, 15 skipped (incl. 4 historically-flaky GitManager
cross-repo PR selector tests newly gated with TODO for Node-native-TS
follow-up)
alecramos-sudo added a commit to alecramos-sudo/t3code that referenced this pull request Apr 20, 2026
Brings in upstream changes since d22c6f5:
- Claude Opus 4.5 built-in model (pingdotgg#2143)
- Claude Opus 4.7 built-in model (pingdotgg#2072)
- opencode provider support (pingdotgg#1758)
- Claude process leak fix & session reaper (pingdotgg#2042)
- Configurable project grouping (pingdotgg#2055)
- Node-native TypeScript for desktop/server (pingdotgg#2098)
- Clean up invalid pending approval projections (pingdotgg#2106)
- Thread status in command palette (pingdotgg#2107)
- Backend startup readiness coordination (pingdotgg#2133)
- Preserve provider bindings on session stop (pingdotgg#2125)
- Allow deleting non-empty projects (pingdotgg#1264)
- Various Windows fixes and CI improvements
Conflict resolutions:
- model.ts: kept claudeAgent opus-4-7 default, added opencode entry
- settings.ts: adopted upstream sidebarProjectGroupingMode/Overrides
- ClaudeProvider.ts: adopted upstream Opus 4.7 effort config
- Sidebar.tsx: adopted upstream project grouping approach
- package.json: kept custom desktop-only build filter
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
MuneerAhmed03 pushed a commit to MuneerAhmed03/t3code that referenced this pull request Apr 26, 2026
NeilTheFisher pushed a commit to NeilTheFisher/t3code that referenced this pull request Aug 18, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XXL1,000+ changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@juliusmarminge
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Adopt Node-native TypeScript for desktop and server - #2098

Merged
juliusmarminge merged 4 commits into
mainfrom
t3code/node-typescript-dev
Apr 17, 2026
Merged

Adopt Node-native TypeScript for desktop and server#2098
juliusmarminge merged 4 commits into
mainfrom
t3code/node-typescript-dev

Conversation

@juliusmarminge

@juliusmarmingejuliusmarminge commented Apr 17, 2026

Copy link
Copy Markdown
Member

Makes dev work on windows

Summary

  • Switch desktop and server entrypoints and scripts to Node-native TypeScript execution.
  • Update local imports to include explicit .ts extensions and tighten type-only imports across the codebase.
  • Adjust TypeScript configs and package scripts for the new module/runtime setup.
  • Add and expand tests for release tooling and runtime helpers affected by the migration.

Testing

  • Not run (PR content prepared from the committed changes).
  • Existing Vitest coverage was updated alongside the TypeScript/runtime migration.
  • New tests were added for scripts such as manifest merging, mock update server behavior, and release package version updates.

Note

Medium Risk
Medium risk because it changes runtime entrypoints/build artifacts (Bun→Node execution, .js.cjs, NodeNext import rules) across desktop and server; misconfigured paths or module resolution could break dev/build/packaging, especially Electron preload/main loading and release tooling.

Overview
Migrates desktop + server execution/build away from Bun-centric assumptions toward Node-native TypeScript (NodeNext), including switching many local relative imports to explicit .ts extensions and tightening import type usage to satisfy verbatimModuleSyntax/erasableSyntaxOnly.

Desktop now builds CommonJS artifacts as .cjs (e.g. main.cjs, preload.cjs) and updates Electron launch/start/dev/smoke-test code and CI verification accordingly; macOS launcher behavior is adjusted to skip the renamed app bundle in dev to avoid helper resource lookup issues.

Server scripts are updated to run under Node (node --watch dev, build:bundle via tsdown), publishing prep resolves catalog: deps into concrete versions, and runtime/version reads switch to importing package.json as an object. Web tsconfig adds overrides to opt out of some NodeNext strictness.

Reviewed by Cursor Bugbot for commit dacc401. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Adopt Node-native TypeScript module resolution for desktop and server packages

  • Switches tsconfig.base.json to NodeNext module/moduleResolution with rewriteRelativeImportExtensions, erasableSyntaxOnly, and verbatimModuleSyntax, requiring explicit .ts extensions on all relative imports across apps/desktop, apps/server, packages/shared, packages/contracts, and packages/client-runtime.
  • Desktop and server dev/start scripts now use node instead of bun; desktop build output switches from .js to .cjs via tsdown.config.ts, and all launchers, smoke tests, and CI steps are updated to reference main.cjs and preload.cjs.
  • Scripts (merge-update-manifests, update-release-package-versions, mock-update-server) are rewritten as Effect-based CLIs with import.meta.main guards so importing them no longer triggers execution.
  • qrCode.ts is refactored from a TypeScript namespace to top-level exports with non-null assertions to satisfy erasableSyntaxOnly.
  • Risk: any tooling or import that previously resolved extensionless .ts paths will break; the apps/web tsconfig explicitly opts out by setting module: Preserve and verbatimModuleSyntax: false.

Macroscope summarized dacc401.

- Switch desktop and server entrypoints to run under Node ESM/TS
- Update imports, type-only imports, and build scripts for .ts resolution
- Refresh config and tests to match the new module/runtime setup
@coderabbitai

coderabbitaiBot commented Apr 17, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: bd35bb6e-7e67-467d-9984-1dc6dea69b31

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch t3code/node-typescript-dev

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XXL 1,000+ changed lines (additions + deletions). labels Apr 17, 2026

@cursorcursorBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix prepared a fix for the issue found in the latest run.

  • ✅ Fixed: Test asserts wrong property name TCODE_HOME
    • Fixed typo on line 66 of dev-runner.test.ts: changed env.TCODE_HOME to env.T3CODE_HOME to match the production code's property name.

Create PR

Or push these changes by commenting:

@cursor push c76b559076
Preview (c76b559076)
diff --git a/scripts/dev-runner.test.ts b/scripts/dev-runner.test.ts--- a/scripts/dev-runner.test.ts+++ b/scripts/dev-runner.test.ts@@ -63,7 +63,7 @@
devUrl: undefined,
});
- assert.equal(env.TCODE_HOME, path.resolve(NodeOS.homedir(), ".t3"));+ assert.equal(env.T3CODE_HOME, path.resolve(NodeOS.homedir(), ".t3"));
}),
);

You can send follow-ups to the cloud agent here.

Reviewed by Cursor Bugbot for commit 91f2896. Configure here.

Comment threadscripts/dev-runner.test.ts Outdated
@macroscopeapp

macroscopeappBot commented Apr 17, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved

Large but mechanical build infrastructure change adopting Node's native TypeScript support. The diff is dominated by import path updates (adding .ts extensions), output file extension changes (.js.cjs), and bunnode script runner switches. The qrCode.ts namespace-to-class refactor is purely syntactic. Runtime impact is limited to consistent file path updates for Electron artifacts.

You can customize Macroscope's approvability policy. Learn more.

- Update expectation to `T3CODE_HOME`
- Reflect the current home-directory env name
- Update desktop build, launch, and smoke-test paths to .cjs
- Align CI and artifact packaging with the new bundle names
- Skip macOS helper bundle patching during dev launches
- Lift qrcodegen namespace into top-level exports
- Add explicit QR code fields and stricter typed access
- Co-authored-by: codex <codex@users.noreply.github.com>
@juliusmarminge
juliusmarminge merged commit 8dba2d6 into mainApr 17, 2026
12 checks passed
@juliusmarminge
juliusmarminge deleted the t3code/node-typescript-dev branch April 17, 2026 05:14
znoraka pushed a commit to znoraka/t3code that referenced this pull request Apr 17, 2026
aaditagrawal added a commit to aaditagrawal/t3code that referenced this pull request Apr 18, 2026
Integrates upstream/main (9df3c64) on top of fork's main (9602c18).
Upstream features adopted:
- Claude Opus 4.5 and 4.7 built-in models (pingdotgg#2072, pingdotgg#2143)
- Node-native TypeScript migration across desktop/server (pingdotgg#2098)
- Configurable project grouping with client-settings overrides (pingdotgg#2055, pingdotgg#2099)
- Thread status in command palette (pingdotgg#2107)
- Responsive composer / plan sidebar on narrow windows (pingdotgg#1198)
- Capture-phase CTRL+J keydown for Windows terminal toggle (pingdotgg#2113/pingdotgg#2142)
- Bypass xterm for global terminal shortcuts (pingdotgg#1580)
- Windows ARM build target (pingdotgg#2080)
- Windows PATH hydration + repair (pingdotgg#1729)
- Gitignore-aware workspace search (pingdotgg#2078)
- Claude process leak fix + stale session monitoring (pingdotgg#2042)
- Preserve provider bindings when stopping sessions (pingdotgg#2084)
- Clean up invalid pending-approval projections (pingdotgg#2106) — new migration
- Extract backend startup readiness coordination
- Drop stale text-gen options on reset (pingdotgg#2076)
- Extend negative repository identity cache TTL (pingdotgg#2083)
- Allow deleting non-empty projects from warning toast (pingdotgg#1264)
- Restore defaults only on General settings (pingdotgg#1710)
- Release workflow modernization (blacksmith runners, GitHub App token guards, v0.0.20 version bump)
Fork features preserved:
- All 8 providers (codex, claudeAgent, copilot, cursor, opencode,
geminiCli, amp, kilo) with their adapters, services, and tests
- Fork's custom OpenCode protocol impl in apps/server/src/opencode/ (kept
over upstream's @opencode-ai/sdk-based provider added in pingdotgg#1758 — fork's
version is tested and integrated; upstream's parallel files deleted)
- Fork's direct-CLI Cursor adapter (kept over upstream's new ACP-based
CursorProvider added in pingdotgg#1355 — upstream's parallel files deleted)
- Fork's ProviderRegistry aggregates only codex + claudeAgent snapshots;
the other 6 providers register via ProviderAdapterRegistry
- PROVIDER_CACHE_IDS stays at [codex, claudeAgent] matching what the
registry actually caches
- Migration IDs preserved (fork 23/24/25/26; upstream's new 025 lands at
ID 27 to avoid re-applying on deployed fork DBs)
- Fork's generic per-provider settings (enabled/binaryPath/configDir/
customModels) kept over upstream's opencode-specific serverUrl/password
- Log directory IPC channels, updateInstallInFlight tracking, icon
composer pipeline all preserved
- Fork's simplified release.yml (no npm CLI publish, no nightly infra)
- composerDraftStore normalizeProviderKind widened to accept all 8 kinds
- Dark mode --background set to #0f0f0f
Test status:
- All 9 package typechecks pass
- Lint clean (0 errors)
- Tests: 1877 passed, 15 skipped (incl. 4 historically-flaky GitManager
cross-repo PR selector tests newly gated with TODO for Node-native-TS
follow-up)
alecramos-sudo added a commit to alecramos-sudo/t3code that referenced this pull request Apr 20, 2026
Brings in upstream changes since d22c6f5:
- Claude Opus 4.5 built-in model (pingdotgg#2143)
- Claude Opus 4.7 built-in model (pingdotgg#2072)
- opencode provider support (pingdotgg#1758)
- Claude process leak fix & session reaper (pingdotgg#2042)
- Configurable project grouping (pingdotgg#2055)
- Node-native TypeScript for desktop/server (pingdotgg#2098)
- Clean up invalid pending approval projections (pingdotgg#2106)
- Thread status in command palette (pingdotgg#2107)
- Backend startup readiness coordination (pingdotgg#2133)
- Preserve provider bindings on session stop (pingdotgg#2125)
- Allow deleting non-empty projects (pingdotgg#1264)
- Various Windows fixes and CI improvements
Conflict resolutions:
- model.ts: kept claudeAgent opus-4-7 default, added opencode entry
- settings.ts: adopted upstream sidebarProjectGroupingMode/Overrides
- ClaudeProvider.ts: adopted upstream Opus 4.7 effort config
- Sidebar.tsx: adopted upstream project grouping approach
- package.json: kept custom desktop-only build filter
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
MuneerAhmed03 pushed a commit to MuneerAhmed03/t3code that referenced this pull request Apr 26, 2026
NeilTheFisher pushed a commit to NeilTheFisher/t3code that referenced this pull request Aug 18, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XXL1,000+ changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@juliusmarminge
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

Adopt Node-native TypeScript for desktop and server - #2098

Merged
juliusmarminge merged 4 commits into
mainfrom
t3code/node-typescript-dev
Apr 17, 2026
Merged

Adopt Node-native TypeScript for desktop and server#2098
juliusmarminge merged 4 commits into
mainfrom
t3code/node-typescript-dev

Conversation

@juliusmarminge

@juliusmarmingejuliusmarminge commented Apr 17, 2026

Copy link
Copy Markdown
Member

Makes dev work on windows

Summary

  • Switch desktop and server entrypoints and scripts to Node-native TypeScript execution.
  • Update local imports to include explicit .ts extensions and tighten type-only imports across the codebase.
  • Adjust TypeScript configs and package scripts for the new module/runtime setup.
  • Add and expand tests for release tooling and runtime helpers affected by the migration.

Testing

  • Not run (PR content prepared from the committed changes).
  • Existing Vitest coverage was updated alongside the TypeScript/runtime migration.
  • New tests were added for scripts such as manifest merging, mock update server behavior, and release package version updates.

Note

Medium Risk
Medium risk because it changes runtime entrypoints/build artifacts (Bun→Node execution, .js.cjs, NodeNext import rules) across desktop and server; misconfigured paths or module resolution could break dev/build/packaging, especially Electron preload/main loading and release tooling.

Overview
Migrates desktop + server execution/build away from Bun-centric assumptions toward Node-native TypeScript (NodeNext), including switching many local relative imports to explicit .ts extensions and tightening import type usage to satisfy verbatimModuleSyntax/erasableSyntaxOnly.

Desktop now builds CommonJS artifacts as .cjs (e.g. main.cjs, preload.cjs) and updates Electron launch/start/dev/smoke-test code and CI verification accordingly; macOS launcher behavior is adjusted to skip the renamed app bundle in dev to avoid helper resource lookup issues.

Server scripts are updated to run under Node (node --watch dev, build:bundle via tsdown), publishing prep resolves catalog: deps into concrete versions, and runtime/version reads switch to importing package.json as an object. Web tsconfig adds overrides to opt out of some NodeNext strictness.

Reviewed by Cursor Bugbot for commit dacc401. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Adopt Node-native TypeScript module resolution for desktop and server packages

  • Switches tsconfig.base.json to NodeNext module/moduleResolution with rewriteRelativeImportExtensions, erasableSyntaxOnly, and verbatimModuleSyntax, requiring explicit .ts extensions on all relative imports across apps/desktop, apps/server, packages/shared, packages/contracts, and packages/client-runtime.
  • Desktop and server dev/start scripts now use node instead of bun; desktop build output switches from .js to .cjs via tsdown.config.ts, and all launchers, smoke tests, and CI steps are updated to reference main.cjs and preload.cjs.
  • Scripts (merge-update-manifests, update-release-package-versions, mock-update-server) are rewritten as Effect-based CLIs with import.meta.main guards so importing them no longer triggers execution.
  • qrCode.ts is refactored from a TypeScript namespace to top-level exports with non-null assertions to satisfy erasableSyntaxOnly.
  • Risk: any tooling or import that previously resolved extensionless .ts paths will break; the apps/web tsconfig explicitly opts out by setting module: Preserve and verbatimModuleSyntax: false.

Macroscope summarized dacc401.

- Switch desktop and server entrypoints to run under Node ESM/TS
- Update imports, type-only imports, and build scripts for .ts resolution
- Refresh config and tests to match the new module/runtime setup
@coderabbitai

coderabbitaiBot commented Apr 17, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: bd35bb6e-7e67-467d-9984-1dc6dea69b31

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch t3code/node-typescript-dev

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XXL 1,000+ changed lines (additions + deletions). labels Apr 17, 2026

@cursorcursorBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix prepared a fix for the issue found in the latest run.

  • ✅ Fixed: Test asserts wrong property name TCODE_HOME
    • Fixed typo on line 66 of dev-runner.test.ts: changed env.TCODE_HOME to env.T3CODE_HOME to match the production code's property name.

Create PR

Or push these changes by commenting:

@cursor push c76b559076
Preview (c76b559076)
diff --git a/scripts/dev-runner.test.ts b/scripts/dev-runner.test.ts--- a/scripts/dev-runner.test.ts+++ b/scripts/dev-runner.test.ts@@ -63,7 +63,7 @@
devUrl: undefined,
});
- assert.equal(env.TCODE_HOME, path.resolve(NodeOS.homedir(), ".t3"));+ assert.equal(env.T3CODE_HOME, path.resolve(NodeOS.homedir(), ".t3"));
}),
);

You can send follow-ups to the cloud agent here.

Reviewed by Cursor Bugbot for commit 91f2896. Configure here.

Comment threadscripts/dev-runner.test.ts Outdated
@macroscopeapp

macroscopeappBot commented Apr 17, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved

Large but mechanical build infrastructure change adopting Node's native TypeScript support. The diff is dominated by import path updates (adding .ts extensions), output file extension changes (.js.cjs), and bunnode script runner switches. The qrCode.ts namespace-to-class refactor is purely syntactic. Runtime impact is limited to consistent file path updates for Electron artifacts.

You can customize Macroscope's approvability policy. Learn more.

- Update expectation to `T3CODE_HOME`
- Reflect the current home-directory env name
- Update desktop build, launch, and smoke-test paths to .cjs
- Align CI and artifact packaging with the new bundle names
- Skip macOS helper bundle patching during dev launches
- Lift qrcodegen namespace into top-level exports
- Add explicit QR code fields and stricter typed access
- Co-authored-by: codex <codex@users.noreply.github.com>
@juliusmarminge
juliusmarminge merged commit 8dba2d6 into mainApr 17, 2026
12 checks passed
@juliusmarminge
juliusmarminge deleted the t3code/node-typescript-dev branch April 17, 2026 05:14
znoraka pushed a commit to znoraka/t3code that referenced this pull request Apr 17, 2026
aaditagrawal added a commit to aaditagrawal/t3code that referenced this pull request Apr 18, 2026
Integrates upstream/main (9df3c64) on top of fork's main (9602c18).
Upstream features adopted:
- Claude Opus 4.5 and 4.7 built-in models (pingdotgg#2072, pingdotgg#2143)
- Node-native TypeScript migration across desktop/server (pingdotgg#2098)
- Configurable project grouping with client-settings overrides (pingdotgg#2055, pingdotgg#2099)
- Thread status in command palette (pingdotgg#2107)
- Responsive composer / plan sidebar on narrow windows (pingdotgg#1198)
- Capture-phase CTRL+J keydown for Windows terminal toggle (pingdotgg#2113/pingdotgg#2142)
- Bypass xterm for global terminal shortcuts (pingdotgg#1580)
- Windows ARM build target (pingdotgg#2080)
- Windows PATH hydration + repair (pingdotgg#1729)
- Gitignore-aware workspace search (pingdotgg#2078)
- Claude process leak fix + stale session monitoring (pingdotgg#2042)
- Preserve provider bindings when stopping sessions (pingdotgg#2084)
- Clean up invalid pending-approval projections (pingdotgg#2106) — new migration
- Extract backend startup readiness coordination
- Drop stale text-gen options on reset (pingdotgg#2076)
- Extend negative repository identity cache TTL (pingdotgg#2083)
- Allow deleting non-empty projects from warning toast (pingdotgg#1264)
- Restore defaults only on General settings (pingdotgg#1710)
- Release workflow modernization (blacksmith runners, GitHub App token guards, v0.0.20 version bump)
Fork features preserved:
- All 8 providers (codex, claudeAgent, copilot, cursor, opencode,
geminiCli, amp, kilo) with their adapters, services, and tests
- Fork's custom OpenCode protocol impl in apps/server/src/opencode/ (kept
over upstream's @opencode-ai/sdk-based provider added in pingdotgg#1758 — fork's
version is tested and integrated; upstream's parallel files deleted)
- Fork's direct-CLI Cursor adapter (kept over upstream's new ACP-based
CursorProvider added in pingdotgg#1355 — upstream's parallel files deleted)
- Fork's ProviderRegistry aggregates only codex + claudeAgent snapshots;
the other 6 providers register via ProviderAdapterRegistry
- PROVIDER_CACHE_IDS stays at [codex, claudeAgent] matching what the
registry actually caches
- Migration IDs preserved (fork 23/24/25/26; upstream's new 025 lands at
ID 27 to avoid re-applying on deployed fork DBs)
- Fork's generic per-provider settings (enabled/binaryPath/configDir/
customModels) kept over upstream's opencode-specific serverUrl/password
- Log directory IPC channels, updateInstallInFlight tracking, icon
composer pipeline all preserved
- Fork's simplified release.yml (no npm CLI publish, no nightly infra)
- composerDraftStore normalizeProviderKind widened to accept all 8 kinds
- Dark mode --background set to #0f0f0f
Test status:
- All 9 package typechecks pass
- Lint clean (0 errors)
- Tests: 1877 passed, 15 skipped (incl. 4 historically-flaky GitManager
cross-repo PR selector tests newly gated with TODO for Node-native-TS
follow-up)
alecramos-sudo added a commit to alecramos-sudo/t3code that referenced this pull request Apr 20, 2026
Brings in upstream changes since d22c6f5:
- Claude Opus 4.5 built-in model (pingdotgg#2143)
- Claude Opus 4.7 built-in model (pingdotgg#2072)
- opencode provider support (pingdotgg#1758)
- Claude process leak fix & session reaper (pingdotgg#2042)
- Configurable project grouping (pingdotgg#2055)
- Node-native TypeScript for desktop/server (pingdotgg#2098)
- Clean up invalid pending approval projections (pingdotgg#2106)
- Thread status in command palette (pingdotgg#2107)
- Backend startup readiness coordination (pingdotgg#2133)
- Preserve provider bindings on session stop (pingdotgg#2125)
- Allow deleting non-empty projects (pingdotgg#1264)
- Various Windows fixes and CI improvements
Conflict resolutions:
- model.ts: kept claudeAgent opus-4-7 default, added opencode entry
- settings.ts: adopted upstream sidebarProjectGroupingMode/Overrides
- ClaudeProvider.ts: adopted upstream Opus 4.7 effort config
- Sidebar.tsx: adopted upstream project grouping approach
- package.json: kept custom desktop-only build filter
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
MuneerAhmed03 pushed a commit to MuneerAhmed03/t3code that referenced this pull request Apr 26, 2026
NeilTheFisher pushed a commit to NeilTheFisher/t3code that referenced this pull request Aug 18, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XXL1,000+ changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@juliusmarminge
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Adopt Node-native TypeScript for desktop and server - #2098

Merged
juliusmarminge merged 4 commits into
mainfrom
t3code/node-typescript-dev
Apr 17, 2026
Merged

Adopt Node-native TypeScript for desktop and server#2098
juliusmarminge merged 4 commits into
mainfrom
t3code/node-typescript-dev

Conversation

@juliusmarminge

@juliusmarmingejuliusmarminge commented Apr 17, 2026

Copy link
Copy Markdown
Member

Makes dev work on windows

Summary

  • Switch desktop and server entrypoints and scripts to Node-native TypeScript execution.
  • Update local imports to include explicit .ts extensions and tighten type-only imports across the codebase.
  • Adjust TypeScript configs and package scripts for the new module/runtime setup.
  • Add and expand tests for release tooling and runtime helpers affected by the migration.

Testing

  • Not run (PR content prepared from the committed changes).
  • Existing Vitest coverage was updated alongside the TypeScript/runtime migration.
  • New tests were added for scripts such as manifest merging, mock update server behavior, and release package version updates.

Note

Medium Risk
Medium risk because it changes runtime entrypoints/build artifacts (Bun→Node execution, .js.cjs, NodeNext import rules) across desktop and server; misconfigured paths or module resolution could break dev/build/packaging, especially Electron preload/main loading and release tooling.

Overview
Migrates desktop + server execution/build away from Bun-centric assumptions toward Node-native TypeScript (NodeNext), including switching many local relative imports to explicit .ts extensions and tightening import type usage to satisfy verbatimModuleSyntax/erasableSyntaxOnly.

Desktop now builds CommonJS artifacts as .cjs (e.g. main.cjs, preload.cjs) and updates Electron launch/start/dev/smoke-test code and CI verification accordingly; macOS launcher behavior is adjusted to skip the renamed app bundle in dev to avoid helper resource lookup issues.

Server scripts are updated to run under Node (node --watch dev, build:bundle via tsdown), publishing prep resolves catalog: deps into concrete versions, and runtime/version reads switch to importing package.json as an object. Web tsconfig adds overrides to opt out of some NodeNext strictness.

Reviewed by Cursor Bugbot for commit dacc401. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Adopt Node-native TypeScript module resolution for desktop and server packages

  • Switches tsconfig.base.json to NodeNext module/moduleResolution with rewriteRelativeImportExtensions, erasableSyntaxOnly, and verbatimModuleSyntax, requiring explicit .ts extensions on all relative imports across apps/desktop, apps/server, packages/shared, packages/contracts, and packages/client-runtime.
  • Desktop and server dev/start scripts now use node instead of bun; desktop build output switches from .js to .cjs via tsdown.config.ts, and all launchers, smoke tests, and CI steps are updated to reference main.cjs and preload.cjs.
  • Scripts (merge-update-manifests, update-release-package-versions, mock-update-server) are rewritten as Effect-based CLIs with import.meta.main guards so importing them no longer triggers execution.
  • qrCode.ts is refactored from a TypeScript namespace to top-level exports with non-null assertions to satisfy erasableSyntaxOnly.
  • Risk: any tooling or import that previously resolved extensionless .ts paths will break; the apps/web tsconfig explicitly opts out by setting module: Preserve and verbatimModuleSyntax: false.

Macroscope summarized dacc401.

- Switch desktop and server entrypoints to run under Node ESM/TS
- Update imports, type-only imports, and build scripts for .ts resolution
- Refresh config and tests to match the new module/runtime setup
@coderabbitai

coderabbitaiBot commented Apr 17, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: bd35bb6e-7e67-467d-9984-1dc6dea69b31

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch t3code/node-typescript-dev

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XXL 1,000+ changed lines (additions + deletions). labels Apr 17, 2026

@cursorcursorBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix prepared a fix for the issue found in the latest run.

  • ✅ Fixed: Test asserts wrong property name TCODE_HOME
    • Fixed typo on line 66 of dev-runner.test.ts: changed env.TCODE_HOME to env.T3CODE_HOME to match the production code's property name.

Create PR

Or push these changes by commenting:

@cursor push c76b559076
Preview (c76b559076)
diff --git a/scripts/dev-runner.test.ts b/scripts/dev-runner.test.ts--- a/scripts/dev-runner.test.ts+++ b/scripts/dev-runner.test.ts@@ -63,7 +63,7 @@
devUrl: undefined,
});
- assert.equal(env.TCODE_HOME, path.resolve(NodeOS.homedir(), ".t3"));+ assert.equal(env.T3CODE_HOME, path.resolve(NodeOS.homedir(), ".t3"));
}),
);

You can send follow-ups to the cloud agent here.

Reviewed by Cursor Bugbot for commit 91f2896. Configure here.

Comment threadscripts/dev-runner.test.ts Outdated
@macroscopeapp

macroscopeappBot commented Apr 17, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved

Large but mechanical build infrastructure change adopting Node's native TypeScript support. The diff is dominated by import path updates (adding .ts extensions), output file extension changes (.js.cjs), and bunnode script runner switches. The qrCode.ts namespace-to-class refactor is purely syntactic. Runtime impact is limited to consistent file path updates for Electron artifacts.

You can customize Macroscope's approvability policy. Learn more.

- Update expectation to `T3CODE_HOME`
- Reflect the current home-directory env name
- Update desktop build, launch, and smoke-test paths to .cjs
- Align CI and artifact packaging with the new bundle names
- Skip macOS helper bundle patching during dev launches
- Lift qrcodegen namespace into top-level exports
- Add explicit QR code fields and stricter typed access
- Co-authored-by: codex <codex@users.noreply.github.com>
@juliusmarminge
juliusmarminge merged commit 8dba2d6 into mainApr 17, 2026
12 checks passed
@juliusmarminge
juliusmarminge deleted the t3code/node-typescript-dev branch April 17, 2026 05:14
znoraka pushed a commit to znoraka/t3code that referenced this pull request Apr 17, 2026
aaditagrawal added a commit to aaditagrawal/t3code that referenced this pull request Apr 18, 2026
Integrates upstream/main (9df3c64) on top of fork's main (9602c18).
Upstream features adopted:
- Claude Opus 4.5 and 4.7 built-in models (pingdotgg#2072, pingdotgg#2143)
- Node-native TypeScript migration across desktop/server (pingdotgg#2098)
- Configurable project grouping with client-settings overrides (pingdotgg#2055, pingdotgg#2099)
- Thread status in command palette (pingdotgg#2107)
- Responsive composer / plan sidebar on narrow windows (pingdotgg#1198)
- Capture-phase CTRL+J keydown for Windows terminal toggle (pingdotgg#2113/pingdotgg#2142)
- Bypass xterm for global terminal shortcuts (pingdotgg#1580)
- Windows ARM build target (pingdotgg#2080)
- Windows PATH hydration + repair (pingdotgg#1729)
- Gitignore-aware workspace search (pingdotgg#2078)
- Claude process leak fix + stale session monitoring (pingdotgg#2042)
- Preserve provider bindings when stopping sessions (pingdotgg#2084)
- Clean up invalid pending-approval projections (pingdotgg#2106) — new migration
- Extract backend startup readiness coordination
- Drop stale text-gen options on reset (pingdotgg#2076)
- Extend negative repository identity cache TTL (pingdotgg#2083)
- Allow deleting non-empty projects from warning toast (pingdotgg#1264)
- Restore defaults only on General settings (pingdotgg#1710)
- Release workflow modernization (blacksmith runners, GitHub App token guards, v0.0.20 version bump)
Fork features preserved:
- All 8 providers (codex, claudeAgent, copilot, cursor, opencode,
geminiCli, amp, kilo) with their adapters, services, and tests
- Fork's custom OpenCode protocol impl in apps/server/src/opencode/ (kept
over upstream's @opencode-ai/sdk-based provider added in pingdotgg#1758 — fork's
version is tested and integrated; upstream's parallel files deleted)
- Fork's direct-CLI Cursor adapter (kept over upstream's new ACP-based
CursorProvider added in pingdotgg#1355 — upstream's parallel files deleted)
- Fork's ProviderRegistry aggregates only codex + claudeAgent snapshots;
the other 6 providers register via ProviderAdapterRegistry
- PROVIDER_CACHE_IDS stays at [codex, claudeAgent] matching what the
registry actually caches
- Migration IDs preserved (fork 23/24/25/26; upstream's new 025 lands at
ID 27 to avoid re-applying on deployed fork DBs)
- Fork's generic per-provider settings (enabled/binaryPath/configDir/
customModels) kept over upstream's opencode-specific serverUrl/password
- Log directory IPC channels, updateInstallInFlight tracking, icon
composer pipeline all preserved
- Fork's simplified release.yml (no npm CLI publish, no nightly infra)
- composerDraftStore normalizeProviderKind widened to accept all 8 kinds
- Dark mode --background set to #0f0f0f
Test status:
- All 9 package typechecks pass
- Lint clean (0 errors)
- Tests: 1877 passed, 15 skipped (incl. 4 historically-flaky GitManager
cross-repo PR selector tests newly gated with TODO for Node-native-TS
follow-up)
alecramos-sudo added a commit to alecramos-sudo/t3code that referenced this pull request Apr 20, 2026
Brings in upstream changes since d22c6f5:
- Claude Opus 4.5 built-in model (pingdotgg#2143)
- Claude Opus 4.7 built-in model (pingdotgg#2072)
- opencode provider support (pingdotgg#1758)
- Claude process leak fix & session reaper (pingdotgg#2042)
- Configurable project grouping (pingdotgg#2055)
- Node-native TypeScript for desktop/server (pingdotgg#2098)
- Clean up invalid pending approval projections (pingdotgg#2106)
- Thread status in command palette (pingdotgg#2107)
- Backend startup readiness coordination (pingdotgg#2133)
- Preserve provider bindings on session stop (pingdotgg#2125)
- Allow deleting non-empty projects (pingdotgg#1264)
- Various Windows fixes and CI improvements
Conflict resolutions:
- model.ts: kept claudeAgent opus-4-7 default, added opencode entry
- settings.ts: adopted upstream sidebarProjectGroupingMode/Overrides
- ClaudeProvider.ts: adopted upstream Opus 4.7 effort config
- Sidebar.tsx: adopted upstream project grouping approach
- package.json: kept custom desktop-only build filter
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
MuneerAhmed03 pushed a commit to MuneerAhmed03/t3code that referenced this pull request Apr 26, 2026
NeilTheFisher pushed a commit to NeilTheFisher/t3code that referenced this pull request Aug 18, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XXL1,000+ changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@juliusmarminge
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Adopt Node-native TypeScript for desktop and server - #2098

Merged
juliusmarminge merged 4 commits into
mainfrom
t3code/node-typescript-dev
Apr 17, 2026
Merged

Adopt Node-native TypeScript for desktop and server#2098
juliusmarminge merged 4 commits into
mainfrom
t3code/node-typescript-dev

Conversation

@juliusmarminge

@juliusmarmingejuliusmarminge commented Apr 17, 2026

Copy link
Copy Markdown
Member

Makes dev work on windows

Summary

  • Switch desktop and server entrypoints and scripts to Node-native TypeScript execution.
  • Update local imports to include explicit .ts extensions and tighten type-only imports across the codebase.
  • Adjust TypeScript configs and package scripts for the new module/runtime setup.
  • Add and expand tests for release tooling and runtime helpers affected by the migration.

Testing

  • Not run (PR content prepared from the committed changes).
  • Existing Vitest coverage was updated alongside the TypeScript/runtime migration.
  • New tests were added for scripts such as manifest merging, mock update server behavior, and release package version updates.

Note

Medium Risk
Medium risk because it changes runtime entrypoints/build artifacts (Bun→Node execution, .js.cjs, NodeNext import rules) across desktop and server; misconfigured paths or module resolution could break dev/build/packaging, especially Electron preload/main loading and release tooling.

Overview
Migrates desktop + server execution/build away from Bun-centric assumptions toward Node-native TypeScript (NodeNext), including switching many local relative imports to explicit .ts extensions and tightening import type usage to satisfy verbatimModuleSyntax/erasableSyntaxOnly.

Desktop now builds CommonJS artifacts as .cjs (e.g. main.cjs, preload.cjs) and updates Electron launch/start/dev/smoke-test code and CI verification accordingly; macOS launcher behavior is adjusted to skip the renamed app bundle in dev to avoid helper resource lookup issues.

Server scripts are updated to run under Node (node --watch dev, build:bundle via tsdown), publishing prep resolves catalog: deps into concrete versions, and runtime/version reads switch to importing package.json as an object. Web tsconfig adds overrides to opt out of some NodeNext strictness.

Reviewed by Cursor Bugbot for commit dacc401. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Adopt Node-native TypeScript module resolution for desktop and server packages

  • Switches tsconfig.base.json to NodeNext module/moduleResolution with rewriteRelativeImportExtensions, erasableSyntaxOnly, and verbatimModuleSyntax, requiring explicit .ts extensions on all relative imports across apps/desktop, apps/server, packages/shared, packages/contracts, and packages/client-runtime.
  • Desktop and server dev/start scripts now use node instead of bun; desktop build output switches from .js to .cjs via tsdown.config.ts, and all launchers, smoke tests, and CI steps are updated to reference main.cjs and preload.cjs.
  • Scripts (merge-update-manifests, update-release-package-versions, mock-update-server) are rewritten as Effect-based CLIs with import.meta.main guards so importing them no longer triggers execution.
  • qrCode.ts is refactored from a TypeScript namespace to top-level exports with non-null assertions to satisfy erasableSyntaxOnly.
  • Risk: any tooling or import that previously resolved extensionless .ts paths will break; the apps/web tsconfig explicitly opts out by setting module: Preserve and verbatimModuleSyntax: false.

Macroscope summarized dacc401.

- Switch desktop and server entrypoints to run under Node ESM/TS
- Update imports, type-only imports, and build scripts for .ts resolution
- Refresh config and tests to match the new module/runtime setup
@coderabbitai

coderabbitaiBot commented Apr 17, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: bd35bb6e-7e67-467d-9984-1dc6dea69b31

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch t3code/node-typescript-dev

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XXL 1,000+ changed lines (additions + deletions). labels Apr 17, 2026

@cursorcursorBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix prepared a fix for the issue found in the latest run.

  • ✅ Fixed: Test asserts wrong property name TCODE_HOME
    • Fixed typo on line 66 of dev-runner.test.ts: changed env.TCODE_HOME to env.T3CODE_HOME to match the production code's property name.

Create PR

Or push these changes by commenting:

@cursor push c76b559076
Preview (c76b559076)
diff --git a/scripts/dev-runner.test.ts b/scripts/dev-runner.test.ts--- a/scripts/dev-runner.test.ts+++ b/scripts/dev-runner.test.ts@@ -63,7 +63,7 @@
devUrl: undefined,
});
- assert.equal(env.TCODE_HOME, path.resolve(NodeOS.homedir(), ".t3"));+ assert.equal(env.T3CODE_HOME, path.resolve(NodeOS.homedir(), ".t3"));
}),
);

You can send follow-ups to the cloud agent here.

Reviewed by Cursor Bugbot for commit 91f2896. Configure here.

Comment threadscripts/dev-runner.test.ts Outdated
@macroscopeapp

macroscopeappBot commented Apr 17, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved

Large but mechanical build infrastructure change adopting Node's native TypeScript support. The diff is dominated by import path updates (adding .ts extensions), output file extension changes (.js.cjs), and bunnode script runner switches. The qrCode.ts namespace-to-class refactor is purely syntactic. Runtime impact is limited to consistent file path updates for Electron artifacts.

You can customize Macroscope's approvability policy. Learn more.

- Update expectation to `T3CODE_HOME`
- Reflect the current home-directory env name
- Update desktop build, launch, and smoke-test paths to .cjs
- Align CI and artifact packaging with the new bundle names
- Skip macOS helper bundle patching during dev launches
- Lift qrcodegen namespace into top-level exports
- Add explicit QR code fields and stricter typed access
- Co-authored-by: codex <codex@users.noreply.github.com>
@juliusmarminge
juliusmarminge merged commit 8dba2d6 into mainApr 17, 2026
12 checks passed
@juliusmarminge
juliusmarminge deleted the t3code/node-typescript-dev branch April 17, 2026 05:14
znoraka pushed a commit to znoraka/t3code that referenced this pull request Apr 17, 2026
aaditagrawal added a commit to aaditagrawal/t3code that referenced this pull request Apr 18, 2026
Integrates upstream/main (9df3c64) on top of fork's main (9602c18).
Upstream features adopted:
- Claude Opus 4.5 and 4.7 built-in models (pingdotgg#2072, pingdotgg#2143)
- Node-native TypeScript migration across desktop/server (pingdotgg#2098)
- Configurable project grouping with client-settings overrides (pingdotgg#2055, pingdotgg#2099)
- Thread status in command palette (pingdotgg#2107)
- Responsive composer / plan sidebar on narrow windows (pingdotgg#1198)
- Capture-phase CTRL+J keydown for Windows terminal toggle (pingdotgg#2113/pingdotgg#2142)
- Bypass xterm for global terminal shortcuts (pingdotgg#1580)
- Windows ARM build target (pingdotgg#2080)
- Windows PATH hydration + repair (pingdotgg#1729)
- Gitignore-aware workspace search (pingdotgg#2078)
- Claude process leak fix + stale session monitoring (pingdotgg#2042)
- Preserve provider bindings when stopping sessions (pingdotgg#2084)
- Clean up invalid pending-approval projections (pingdotgg#2106) — new migration
- Extract backend startup readiness coordination
- Drop stale text-gen options on reset (pingdotgg#2076)
- Extend negative repository identity cache TTL (pingdotgg#2083)
- Allow deleting non-empty projects from warning toast (pingdotgg#1264)
- Restore defaults only on General settings (pingdotgg#1710)
- Release workflow modernization (blacksmith runners, GitHub App token guards, v0.0.20 version bump)
Fork features preserved:
- All 8 providers (codex, claudeAgent, copilot, cursor, opencode,
geminiCli, amp, kilo) with their adapters, services, and tests
- Fork's custom OpenCode protocol impl in apps/server/src/opencode/ (kept
over upstream's @opencode-ai/sdk-based provider added in pingdotgg#1758 — fork's
version is tested and integrated; upstream's parallel files deleted)
- Fork's direct-CLI Cursor adapter (kept over upstream's new ACP-based
CursorProvider added in pingdotgg#1355 — upstream's parallel files deleted)
- Fork's ProviderRegistry aggregates only codex + claudeAgent snapshots;
the other 6 providers register via ProviderAdapterRegistry
- PROVIDER_CACHE_IDS stays at [codex, claudeAgent] matching what the
registry actually caches
- Migration IDs preserved (fork 23/24/25/26; upstream's new 025 lands at
ID 27 to avoid re-applying on deployed fork DBs)
- Fork's generic per-provider settings (enabled/binaryPath/configDir/
customModels) kept over upstream's opencode-specific serverUrl/password
- Log directory IPC channels, updateInstallInFlight tracking, icon
composer pipeline all preserved
- Fork's simplified release.yml (no npm CLI publish, no nightly infra)
- composerDraftStore normalizeProviderKind widened to accept all 8 kinds
- Dark mode --background set to #0f0f0f
Test status:
- All 9 package typechecks pass
- Lint clean (0 errors)
- Tests: 1877 passed, 15 skipped (incl. 4 historically-flaky GitManager
cross-repo PR selector tests newly gated with TODO for Node-native-TS
follow-up)
alecramos-sudo added a commit to alecramos-sudo/t3code that referenced this pull request Apr 20, 2026
Brings in upstream changes since d22c6f5:
- Claude Opus 4.5 built-in model (pingdotgg#2143)
- Claude Opus 4.7 built-in model (pingdotgg#2072)
- opencode provider support (pingdotgg#1758)
- Claude process leak fix & session reaper (pingdotgg#2042)
- Configurable project grouping (pingdotgg#2055)
- Node-native TypeScript for desktop/server (pingdotgg#2098)
- Clean up invalid pending approval projections (pingdotgg#2106)
- Thread status in command palette (pingdotgg#2107)
- Backend startup readiness coordination (pingdotgg#2133)
- Preserve provider bindings on session stop (pingdotgg#2125)
- Allow deleting non-empty projects (pingdotgg#1264)
- Various Windows fixes and CI improvements
Conflict resolutions:
- model.ts: kept claudeAgent opus-4-7 default, added opencode entry
- settings.ts: adopted upstream sidebarProjectGroupingMode/Overrides
- ClaudeProvider.ts: adopted upstream Opus 4.7 effort config
- Sidebar.tsx: adopted upstream project grouping approach
- package.json: kept custom desktop-only build filter
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
MuneerAhmed03 pushed a commit to MuneerAhmed03/t3code that referenced this pull request Apr 26, 2026
NeilTheFisher pushed a commit to NeilTheFisher/t3code that referenced this pull request Aug 18, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XXL1,000+ changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@juliusmarminge
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

Adopt Node-native TypeScript for desktop and server - #2098

Merged
juliusmarminge merged 4 commits into
mainfrom
t3code/node-typescript-dev
Apr 17, 2026
Merged

Adopt Node-native TypeScript for desktop and server#2098
juliusmarminge merged 4 commits into
mainfrom
t3code/node-typescript-dev

Conversation

@juliusmarminge

@juliusmarmingejuliusmarminge commented Apr 17, 2026

Copy link
Copy Markdown
Member

Makes dev work on windows

Summary

  • Switch desktop and server entrypoints and scripts to Node-native TypeScript execution.
  • Update local imports to include explicit .ts extensions and tighten type-only imports across the codebase.
  • Adjust TypeScript configs and package scripts for the new module/runtime setup.
  • Add and expand tests for release tooling and runtime helpers affected by the migration.

Testing

  • Not run (PR content prepared from the committed changes).
  • Existing Vitest coverage was updated alongside the TypeScript/runtime migration.
  • New tests were added for scripts such as manifest merging, mock update server behavior, and release package version updates.

Note

Medium Risk
Medium risk because it changes runtime entrypoints/build artifacts (Bun→Node execution, .js.cjs, NodeNext import rules) across desktop and server; misconfigured paths or module resolution could break dev/build/packaging, especially Electron preload/main loading and release tooling.

Overview
Migrates desktop + server execution/build away from Bun-centric assumptions toward Node-native TypeScript (NodeNext), including switching many local relative imports to explicit .ts extensions and tightening import type usage to satisfy verbatimModuleSyntax/erasableSyntaxOnly.

Desktop now builds CommonJS artifacts as .cjs (e.g. main.cjs, preload.cjs) and updates Electron launch/start/dev/smoke-test code and CI verification accordingly; macOS launcher behavior is adjusted to skip the renamed app bundle in dev to avoid helper resource lookup issues.

Server scripts are updated to run under Node (node --watch dev, build:bundle via tsdown), publishing prep resolves catalog: deps into concrete versions, and runtime/version reads switch to importing package.json as an object. Web tsconfig adds overrides to opt out of some NodeNext strictness.

Reviewed by Cursor Bugbot for commit dacc401. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Adopt Node-native TypeScript module resolution for desktop and server packages

  • Switches tsconfig.base.json to NodeNext module/moduleResolution with rewriteRelativeImportExtensions, erasableSyntaxOnly, and verbatimModuleSyntax, requiring explicit .ts extensions on all relative imports across apps/desktop, apps/server, packages/shared, packages/contracts, and packages/client-runtime.
  • Desktop and server dev/start scripts now use node instead of bun; desktop build output switches from .js to .cjs via tsdown.config.ts, and all launchers, smoke tests, and CI steps are updated to reference main.cjs and preload.cjs.
  • Scripts (merge-update-manifests, update-release-package-versions, mock-update-server) are rewritten as Effect-based CLIs with import.meta.main guards so importing them no longer triggers execution.
  • qrCode.ts is refactored from a TypeScript namespace to top-level exports with non-null assertions to satisfy erasableSyntaxOnly.
  • Risk: any tooling or import that previously resolved extensionless .ts paths will break; the apps/web tsconfig explicitly opts out by setting module: Preserve and verbatimModuleSyntax: false.

Macroscope summarized dacc401.

- Switch desktop and server entrypoints to run under Node ESM/TS
- Update imports, type-only imports, and build scripts for .ts resolution
- Refresh config and tests to match the new module/runtime setup
@coderabbitai

coderabbitaiBot commented Apr 17, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: bd35bb6e-7e67-467d-9984-1dc6dea69b31

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch t3code/node-typescript-dev

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XXL 1,000+ changed lines (additions + deletions). labels Apr 17, 2026

@cursorcursorBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix prepared a fix for the issue found in the latest run.

  • ✅ Fixed: Test asserts wrong property name TCODE_HOME
    • Fixed typo on line 66 of dev-runner.test.ts: changed env.TCODE_HOME to env.T3CODE_HOME to match the production code's property name.

Create PR

Or push these changes by commenting:

@cursor push c76b559076
Preview (c76b559076)
diff --git a/scripts/dev-runner.test.ts b/scripts/dev-runner.test.ts--- a/scripts/dev-runner.test.ts+++ b/scripts/dev-runner.test.ts@@ -63,7 +63,7 @@
devUrl: undefined,
});
- assert.equal(env.TCODE_HOME, path.resolve(NodeOS.homedir(), ".t3"));+ assert.equal(env.T3CODE_HOME, path.resolve(NodeOS.homedir(), ".t3"));
}),
);

You can send follow-ups to the cloud agent here.

Reviewed by Cursor Bugbot for commit 91f2896. Configure here.

Comment threadscripts/dev-runner.test.ts Outdated
@macroscopeapp

macroscopeappBot commented Apr 17, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved

Large but mechanical build infrastructure change adopting Node's native TypeScript support. The diff is dominated by import path updates (adding .ts extensions), output file extension changes (.js.cjs), and bunnode script runner switches. The qrCode.ts namespace-to-class refactor is purely syntactic. Runtime impact is limited to consistent file path updates for Electron artifacts.

You can customize Macroscope's approvability policy. Learn more.

- Update expectation to `T3CODE_HOME`
- Reflect the current home-directory env name
- Update desktop build, launch, and smoke-test paths to .cjs
- Align CI and artifact packaging with the new bundle names
- Skip macOS helper bundle patching during dev launches
- Lift qrcodegen namespace into top-level exports
- Add explicit QR code fields and stricter typed access
- Co-authored-by: codex <codex@users.noreply.github.com>
@juliusmarminge
juliusmarminge merged commit 8dba2d6 into mainApr 17, 2026
12 checks passed
@juliusmarminge
juliusmarminge deleted the t3code/node-typescript-dev branch April 17, 2026 05:14
znoraka pushed a commit to znoraka/t3code that referenced this pull request Apr 17, 2026
aaditagrawal added a commit to aaditagrawal/t3code that referenced this pull request Apr 18, 2026
Integrates upstream/main (9df3c64) on top of fork's main (9602c18).
Upstream features adopted:
- Claude Opus 4.5 and 4.7 built-in models (pingdotgg#2072, pingdotgg#2143)
- Node-native TypeScript migration across desktop/server (pingdotgg#2098)
- Configurable project grouping with client-settings overrides (pingdotgg#2055, pingdotgg#2099)
- Thread status in command palette (pingdotgg#2107)
- Responsive composer / plan sidebar on narrow windows (pingdotgg#1198)
- Capture-phase CTRL+J keydown for Windows terminal toggle (pingdotgg#2113/pingdotgg#2142)
- Bypass xterm for global terminal shortcuts (pingdotgg#1580)
- Windows ARM build target (pingdotgg#2080)
- Windows PATH hydration + repair (pingdotgg#1729)
- Gitignore-aware workspace search (pingdotgg#2078)
- Claude process leak fix + stale session monitoring (pingdotgg#2042)
- Preserve provider bindings when stopping sessions (pingdotgg#2084)
- Clean up invalid pending-approval projections (pingdotgg#2106) — new migration
- Extract backend startup readiness coordination
- Drop stale text-gen options on reset (pingdotgg#2076)
- Extend negative repository identity cache TTL (pingdotgg#2083)
- Allow deleting non-empty projects from warning toast (pingdotgg#1264)
- Restore defaults only on General settings (pingdotgg#1710)
- Release workflow modernization (blacksmith runners, GitHub App token guards, v0.0.20 version bump)
Fork features preserved:
- All 8 providers (codex, claudeAgent, copilot, cursor, opencode,
geminiCli, amp, kilo) with their adapters, services, and tests
- Fork's custom OpenCode protocol impl in apps/server/src/opencode/ (kept
over upstream's @opencode-ai/sdk-based provider added in pingdotgg#1758 — fork's
version is tested and integrated; upstream's parallel files deleted)
- Fork's direct-CLI Cursor adapter (kept over upstream's new ACP-based
CursorProvider added in pingdotgg#1355 — upstream's parallel files deleted)
- Fork's ProviderRegistry aggregates only codex + claudeAgent snapshots;
the other 6 providers register via ProviderAdapterRegistry
- PROVIDER_CACHE_IDS stays at [codex, claudeAgent] matching what the
registry actually caches
- Migration IDs preserved (fork 23/24/25/26; upstream's new 025 lands at
ID 27 to avoid re-applying on deployed fork DBs)
- Fork's generic per-provider settings (enabled/binaryPath/configDir/
customModels) kept over upstream's opencode-specific serverUrl/password
- Log directory IPC channels, updateInstallInFlight tracking, icon
composer pipeline all preserved
- Fork's simplified release.yml (no npm CLI publish, no nightly infra)
- composerDraftStore normalizeProviderKind widened to accept all 8 kinds
- Dark mode --background set to #0f0f0f
Test status:
- All 9 package typechecks pass
- Lint clean (0 errors)
- Tests: 1877 passed, 15 skipped (incl. 4 historically-flaky GitManager
cross-repo PR selector tests newly gated with TODO for Node-native-TS
follow-up)
alecramos-sudo added a commit to alecramos-sudo/t3code that referenced this pull request Apr 20, 2026
Brings in upstream changes since d22c6f5:
- Claude Opus 4.5 built-in model (pingdotgg#2143)
- Claude Opus 4.7 built-in model (pingdotgg#2072)
- opencode provider support (pingdotgg#1758)
- Claude process leak fix & session reaper (pingdotgg#2042)
- Configurable project grouping (pingdotgg#2055)
- Node-native TypeScript for desktop/server (pingdotgg#2098)
- Clean up invalid pending approval projections (pingdotgg#2106)
- Thread status in command palette (pingdotgg#2107)
- Backend startup readiness coordination (pingdotgg#2133)
- Preserve provider bindings on session stop (pingdotgg#2125)
- Allow deleting non-empty projects (pingdotgg#1264)
- Various Windows fixes and CI improvements
Conflict resolutions:
- model.ts: kept claudeAgent opus-4-7 default, added opencode entry
- settings.ts: adopted upstream sidebarProjectGroupingMode/Overrides
- ClaudeProvider.ts: adopted upstream Opus 4.7 effort config
- Sidebar.tsx: adopted upstream project grouping approach
- package.json: kept custom desktop-only build filter
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
MuneerAhmed03 pushed a commit to MuneerAhmed03/t3code that referenced this pull request Apr 26, 2026
NeilTheFisher pushed a commit to NeilTheFisher/t3code that referenced this pull request Aug 18, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XXL1,000+ changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@juliusmarminge