Optimize MessagesTimeline work row stability

[cursor]

What Changed

• Reuse existing MessagesTimeline work rows when re-derived grouped work entries contain the same entry object references.
• Added a regression test covering equivalent work-log group derivations that create new grouped arrays.

Why

react-doctor flagged MessagesTimeline as a render hot spot, and manual review found work-log rows lost structural sharing because grouped arrays were compared by array identity. A react-scan before/after browser probe showed WorkGroupSection rendered once before this fix during an equivalent timeline re-derivation and no longer rendered after the fix.

UI Changes

No visual UI changes.

Checklist

• This PR is small and focused
• I explained what changed and why
• I included before/after screenshots for any UI changes
• I included a video for animation/interaction changes

Note

Fix isRowUnchanged to use value equality for work row groupedEntries

In MessagesTimeline.logic.ts, the isRowUnchanged function previously used strict reference equality (===) to compare groupedEntries on work rows. This caused rows to be considered changed even when the arrays had identical content but were different instances — a common outcome when timeline derivations recompute grouped arrays.

The fix replaces the reference check with Equal.equals from effect/Equal, so structurally equivalent groupedEntries arrays now correctly mark the row as unchanged and reuse the existing row reference.

^{Macroscope summarized 4646c2a.}

---

Note

Low Risk
Low risk: changes only affect memoization/equality checks for work timeline rows and add a regression test; no data handling or auth logic touched.

Overview
Improves MessagesTimeline row stability by treating work rows as unchanged when their groupedEntries arrays are equivalent, even if re-derived as new array instances (switches comparison to Equal.equals).

Adds a regression test ensuring computeStableMessagesTimelineRows reuses prior work row objects across equivalent derivations to avoid unnecessary re-renders.

^{Reviewed by Cursor Bugbot for commit 4646c2a. Bugbot is set up for automated code reviews on this repo. Configure here.}

[juliusmarminge]

@cursor can we use effet/Equals here? It uses structural equality in v4

[cursor]

Replaced the hand-rolled areWorkGroupsUnchanged helper with Equal.equals from effect/Equal. In Effect v4 (which this project uses at 4.0.0-beta.59), Equal.equals provides structural equality for plain objects and arrays out of the box — so it's a drop-in replacement that removes 9 lines of custom comparison logic.

• What changed: Imported effect/Equal and replaced areWorkGroupsUnchanged(a, b) with Equal.equals(a, b) in the work case of isRowUnchanged. Removed the now-unused areWorkGroupsUnchanged function entirely.
• Validation: bun fmt, bun lint, bun typecheck, and all 18 tests pass (including the regression test for work row stability with new grouped arrays).

[macroscopeapp]

Approvability

Verdict: Approved

Small optimization change that uses deep equality instead of reference equality for comparing grouped entries, improving memoization stability. The change is self-contained with a corresponding test.

^{You can customize Macroscope's approvability policy. Learn more.}

[cursor]

What Changed

• Reuse existing MessagesTimeline work rows when re-derived grouped work entries contain the same entry object references.
• Added a regression test covering equivalent work-log group derivations that create new grouped arrays.

Why

react-doctor flagged MessagesTimeline as a render hot spot, and manual review found work-log rows lost structural sharing because grouped arrays were compared by array identity. A react-scan before/after browser probe showed WorkGroupSection rendered once before this fix during an equivalent timeline re-derivation and no longer rendered after the fix.

UI Changes

No visual UI changes.

Checklist

• This PR is small and focused
• I explained what changed and why
• I included before/after screenshots for any UI changes
• I included a video for animation/interaction changes

Note

Fix isRowUnchanged to use value equality for work row groupedEntries

In MessagesTimeline.logic.ts, the isRowUnchanged function previously used strict reference equality (===) to compare groupedEntries on work rows. This caused rows to be considered changed even when the arrays had identical content but were different instances — a common outcome when timeline derivations recompute grouped arrays.

The fix replaces the reference check with Equal.equals from effect/Equal, so structurally equivalent groupedEntries arrays now correctly mark the row as unchanged and reuse the existing row reference.

^{Macroscope summarized 4646c2a.}

---

Note

Low Risk
Low risk: changes only affect memoization/equality checks for work timeline rows and add a regression test; no data handling or auth logic touched.

Overview
Improves MessagesTimeline row stability by treating work rows as unchanged when their groupedEntries arrays are equivalent, even if re-derived as new array instances (switches comparison to Equal.equals).

Adds a regression test ensuring computeStableMessagesTimelineRows reuses prior work row objects across equivalent derivations to avoid unnecessary re-renders.

^{Reviewed by Cursor Bugbot for commit 4646c2a. Bugbot is set up for automated code reviews on this repo. Configure here.}

[juliusmarminge]

@cursor can we use effet/Equals here? It uses structural equality in v4

[cursor]

Replaced the hand-rolled areWorkGroupsUnchanged helper with Equal.equals from effect/Equal. In Effect v4 (which this project uses at 4.0.0-beta.59), Equal.equals provides structural equality for plain objects and arrays out of the box — so it's a drop-in replacement that removes 9 lines of custom comparison logic.

• What changed: Imported effect/Equal and replaced areWorkGroupsUnchanged(a, b) with Equal.equals(a, b) in the work case of isRowUnchanged. Removed the now-unused areWorkGroupsUnchanged function entirely.
• Validation: bun fmt, bun lint, bun typecheck, and all 18 tests pass (including the regression test for work row stability with new grouped arrays).

[macroscopeapp]

Approvability

Verdict: Approved

Small optimization change that uses deep equality instead of reference equality for comparing grouped entries, improving memoization stability. The change is self-contained with a corresponding test.

^{You can customize Macroscope's approvability policy. Learn more.}

[cursor]

What Changed

• Reuse existing MessagesTimeline work rows when re-derived grouped work entries contain the same entry object references.
• Added a regression test covering equivalent work-log group derivations that create new grouped arrays.

Why

react-doctor flagged MessagesTimeline as a render hot spot, and manual review found work-log rows lost structural sharing because grouped arrays were compared by array identity. A react-scan before/after browser probe showed WorkGroupSection rendered once before this fix during an equivalent timeline re-derivation and no longer rendered after the fix.

UI Changes

No visual UI changes.

Checklist

• This PR is small and focused
• I explained what changed and why
• I included before/after screenshots for any UI changes
• I included a video for animation/interaction changes

Note

Fix isRowUnchanged to use value equality for work row groupedEntries

In MessagesTimeline.logic.ts, the isRowUnchanged function previously used strict reference equality (===) to compare groupedEntries on work rows. This caused rows to be considered changed even when the arrays had identical content but were different instances — a common outcome when timeline derivations recompute grouped arrays.

The fix replaces the reference check with Equal.equals from effect/Equal, so structurally equivalent groupedEntries arrays now correctly mark the row as unchanged and reuse the existing row reference.

^{Macroscope summarized 4646c2a.}

---

Note

Low Risk
Low risk: changes only affect memoization/equality checks for work timeline rows and add a regression test; no data handling or auth logic touched.

Overview
Improves MessagesTimeline row stability by treating work rows as unchanged when their groupedEntries arrays are equivalent, even if re-derived as new array instances (switches comparison to Equal.equals).

Adds a regression test ensuring computeStableMessagesTimelineRows reuses prior work row objects across equivalent derivations to avoid unnecessary re-renders.

^{Reviewed by Cursor Bugbot for commit 4646c2a. Bugbot is set up for automated code reviews on this repo. Configure here.}

[juliusmarminge]

@cursor can we use effet/Equals here? It uses structural equality in v4

[cursor]

Replaced the hand-rolled areWorkGroupsUnchanged helper with Equal.equals from effect/Equal. In Effect v4 (which this project uses at 4.0.0-beta.59), Equal.equals provides structural equality for plain objects and arrays out of the box — so it's a drop-in replacement that removes 9 lines of custom comparison logic.

• What changed: Imported effect/Equal and replaced areWorkGroupsUnchanged(a, b) with Equal.equals(a, b) in the work case of isRowUnchanged. Removed the now-unused areWorkGroupsUnchanged function entirely.
• Validation: bun fmt, bun lint, bun typecheck, and all 18 tests pass (including the regression test for work row stability with new grouped arrays).

[macroscopeapp]

Approvability

Verdict: Approved

Small optimization change that uses deep equality instead of reference equality for comparing grouped entries, improving memoization stability. The change is self-contained with a corresponding test.

^{You can customize Macroscope's approvability policy. Learn more.}

[cursor]

What Changed

• Reuse existing MessagesTimeline work rows when re-derived grouped work entries contain the same entry object references.
• Added a regression test covering equivalent work-log group derivations that create new grouped arrays.

Why

react-doctor flagged MessagesTimeline as a render hot spot, and manual review found work-log rows lost structural sharing because grouped arrays were compared by array identity. A react-scan before/after browser probe showed WorkGroupSection rendered once before this fix during an equivalent timeline re-derivation and no longer rendered after the fix.

UI Changes

No visual UI changes.

Checklist

• This PR is small and focused
• I explained what changed and why
• I included before/after screenshots for any UI changes
• I included a video for animation/interaction changes

Note

Fix isRowUnchanged to use value equality for work row groupedEntries

In MessagesTimeline.logic.ts, the isRowUnchanged function previously used strict reference equality (===) to compare groupedEntries on work rows. This caused rows to be considered changed even when the arrays had identical content but were different instances — a common outcome when timeline derivations recompute grouped arrays.

The fix replaces the reference check with Equal.equals from effect/Equal, so structurally equivalent groupedEntries arrays now correctly mark the row as unchanged and reuse the existing row reference.

^{Macroscope summarized 4646c2a.}

---

Note

Low Risk
Low risk: changes only affect memoization/equality checks for work timeline rows and add a regression test; no data handling or auth logic touched.

Overview
Improves MessagesTimeline row stability by treating work rows as unchanged when their groupedEntries arrays are equivalent, even if re-derived as new array instances (switches comparison to Equal.equals).

Adds a regression test ensuring computeStableMessagesTimelineRows reuses prior work row objects across equivalent derivations to avoid unnecessary re-renders.

^{Reviewed by Cursor Bugbot for commit 4646c2a. Bugbot is set up for automated code reviews on this repo. Configure here.}

[juliusmarminge]

@cursor can we use effet/Equals here? It uses structural equality in v4

[cursor]

Replaced the hand-rolled areWorkGroupsUnchanged helper with Equal.equals from effect/Equal. In Effect v4 (which this project uses at 4.0.0-beta.59), Equal.equals provides structural equality for plain objects and arrays out of the box — so it's a drop-in replacement that removes 9 lines of custom comparison logic.

• What changed: Imported effect/Equal and replaced areWorkGroupsUnchanged(a, b) with Equal.equals(a, b) in the work case of isRowUnchanged. Removed the now-unused areWorkGroupsUnchanged function entirely.
• Validation: bun fmt, bun lint, bun typecheck, and all 18 tests pass (including the regression test for work row stability with new grouped arrays).

[macroscopeapp]

Approvability

Verdict: Approved

Small optimization change that uses deep equality instead of reference equality for comparing grouped entries, improving memoization stability. The change is self-contained with a corresponding test.

^{You can customize Macroscope's approvability policy. Learn more.}

[cursor]

What Changed

• Reuse existing MessagesTimeline work rows when re-derived grouped work entries contain the same entry object references.
• Added a regression test covering equivalent work-log group derivations that create new grouped arrays.

Why

react-doctor flagged MessagesTimeline as a render hot spot, and manual review found work-log rows lost structural sharing because grouped arrays were compared by array identity. A react-scan before/after browser probe showed WorkGroupSection rendered once before this fix during an equivalent timeline re-derivation and no longer rendered after the fix.

UI Changes

No visual UI changes.

Checklist

• This PR is small and focused
• I explained what changed and why
• I included before/after screenshots for any UI changes
• I included a video for animation/interaction changes

Note

Fix isRowUnchanged to use value equality for work row groupedEntries

In MessagesTimeline.logic.ts, the isRowUnchanged function previously used strict reference equality (===) to compare groupedEntries on work rows. This caused rows to be considered changed even when the arrays had identical content but were different instances — a common outcome when timeline derivations recompute grouped arrays.

The fix replaces the reference check with Equal.equals from effect/Equal, so structurally equivalent groupedEntries arrays now correctly mark the row as unchanged and reuse the existing row reference.

^{Macroscope summarized 4646c2a.}

---

Note

Low Risk
Low risk: changes only affect memoization/equality checks for work timeline rows and add a regression test; no data handling or auth logic touched.

Overview
Improves MessagesTimeline row stability by treating work rows as unchanged when their groupedEntries arrays are equivalent, even if re-derived as new array instances (switches comparison to Equal.equals).

Adds a regression test ensuring computeStableMessagesTimelineRows reuses prior work row objects across equivalent derivations to avoid unnecessary re-renders.

^{Reviewed by Cursor Bugbot for commit 4646c2a. Bugbot is set up for automated code reviews on this repo. Configure here.}

[juliusmarminge]

@cursor can we use effet/Equals here? It uses structural equality in v4

[cursor]

Replaced the hand-rolled areWorkGroupsUnchanged helper with Equal.equals from effect/Equal. In Effect v4 (which this project uses at 4.0.0-beta.59), Equal.equals provides structural equality for plain objects and arrays out of the box — so it's a drop-in replacement that removes 9 lines of custom comparison logic.

• What changed: Imported effect/Equal and replaced areWorkGroupsUnchanged(a, b) with Equal.equals(a, b) in the work case of isRowUnchanged. Removed the now-unused areWorkGroupsUnchanged function entirely.
• Validation: bun fmt, bun lint, bun typecheck, and all 18 tests pass (including the regression test for work row stability with new grouped arrays).

[macroscopeapp]

Approvability

Verdict: Approved

Small optimization change that uses deep equality instead of reference equality for comparing grouped entries, improving memoization stability. The change is self-contained with a corresponding test.

^{You can customize Macroscope's approvability policy. Learn more.}

[cursor]

What Changed

• Reuse existing MessagesTimeline work rows when re-derived grouped work entries contain the same entry object references.
• Added a regression test covering equivalent work-log group derivations that create new grouped arrays.

Why

react-doctor flagged MessagesTimeline as a render hot spot, and manual review found work-log rows lost structural sharing because grouped arrays were compared by array identity. A react-scan before/after browser probe showed WorkGroupSection rendered once before this fix during an equivalent timeline re-derivation and no longer rendered after the fix.

UI Changes

No visual UI changes.

Checklist

• This PR is small and focused
• I explained what changed and why
• I included before/after screenshots for any UI changes
• I included a video for animation/interaction changes

Note

Fix isRowUnchanged to use value equality for work row groupedEntries

In MessagesTimeline.logic.ts, the isRowUnchanged function previously used strict reference equality (===) to compare groupedEntries on work rows. This caused rows to be considered changed even when the arrays had identical content but were different instances — a common outcome when timeline derivations recompute grouped arrays.

The fix replaces the reference check with Equal.equals from effect/Equal, so structurally equivalent groupedEntries arrays now correctly mark the row as unchanged and reuse the existing row reference.

^{Macroscope summarized 4646c2a.}

---

Note

Low Risk
Low risk: changes only affect memoization/equality checks for work timeline rows and add a regression test; no data handling or auth logic touched.

Overview
Improves MessagesTimeline row stability by treating work rows as unchanged when their groupedEntries arrays are equivalent, even if re-derived as new array instances (switches comparison to Equal.equals).

Adds a regression test ensuring computeStableMessagesTimelineRows reuses prior work row objects across equivalent derivations to avoid unnecessary re-renders.

^{Reviewed by Cursor Bugbot for commit 4646c2a. Bugbot is set up for automated code reviews on this repo. Configure here.}

[juliusmarminge]

@cursor can we use effet/Equals here? It uses structural equality in v4

[cursor]

Replaced the hand-rolled areWorkGroupsUnchanged helper with Equal.equals from effect/Equal. In Effect v4 (which this project uses at 4.0.0-beta.59), Equal.equals provides structural equality for plain objects and arrays out of the box — so it's a drop-in replacement that removes 9 lines of custom comparison logic.

• What changed: Imported effect/Equal and replaced areWorkGroupsUnchanged(a, b) with Equal.equals(a, b) in the work case of isRowUnchanged. Removed the now-unused areWorkGroupsUnchanged function entirely.
• Validation: bun fmt, bun lint, bun typecheck, and all 18 tests pass (including the regression test for work row stability with new grouped arrays).

[macroscopeapp]

Approvability

Verdict: Approved

Small optimization change that uses deep equality instead of reference equality for comparing grouped entries, improving memoization stability. The change is self-contained with a corresponding test.

^{You can customize Macroscope's approvability policy. Learn more.}

[cursor]

What Changed

• Reuse existing MessagesTimeline work rows when re-derived grouped work entries contain the same entry object references.
• Added a regression test covering equivalent work-log group derivations that create new grouped arrays.

Why

react-doctor flagged MessagesTimeline as a render hot spot, and manual review found work-log rows lost structural sharing because grouped arrays were compared by array identity. A react-scan before/after browser probe showed WorkGroupSection rendered once before this fix during an equivalent timeline re-derivation and no longer rendered after the fix.

UI Changes

No visual UI changes.

Checklist

• This PR is small and focused
• I explained what changed and why
• I included before/after screenshots for any UI changes
• I included a video for animation/interaction changes

Note

Fix isRowUnchanged to use value equality for work row groupedEntries

In MessagesTimeline.logic.ts, the isRowUnchanged function previously used strict reference equality (===) to compare groupedEntries on work rows. This caused rows to be considered changed even when the arrays had identical content but were different instances — a common outcome when timeline derivations recompute grouped arrays.

The fix replaces the reference check with Equal.equals from effect/Equal, so structurally equivalent groupedEntries arrays now correctly mark the row as unchanged and reuse the existing row reference.

^{Macroscope summarized 4646c2a.}

---

Note

Low Risk
Low risk: changes only affect memoization/equality checks for work timeline rows and add a regression test; no data handling or auth logic touched.

Overview
Improves MessagesTimeline row stability by treating work rows as unchanged when their groupedEntries arrays are equivalent, even if re-derived as new array instances (switches comparison to Equal.equals).

Adds a regression test ensuring computeStableMessagesTimelineRows reuses prior work row objects across equivalent derivations to avoid unnecessary re-renders.

^{Reviewed by Cursor Bugbot for commit 4646c2a. Bugbot is set up for automated code reviews on this repo. Configure here.}

[juliusmarminge]

@cursor can we use effet/Equals here? It uses structural equality in v4

[cursor]

Replaced the hand-rolled areWorkGroupsUnchanged helper with Equal.equals from effect/Equal. In Effect v4 (which this project uses at 4.0.0-beta.59), Equal.equals provides structural equality for plain objects and arrays out of the box — so it's a drop-in replacement that removes 9 lines of custom comparison logic.

• What changed: Imported effect/Equal and replaced areWorkGroupsUnchanged(a, b) with Equal.equals(a, b) in the work case of isRowUnchanged. Removed the now-unused areWorkGroupsUnchanged function entirely.
• Validation: bun fmt, bun lint, bun typecheck, and all 18 tests pass (including the regression test for work row stability with new grouped arrays).

[macroscopeapp]

Approvability

Verdict: Approved

Small optimization change that uses deep equality instead of reference equality for comparing grouped entries, improving memoization stability. The change is self-contained with a corresponding test.

^{You can customize Macroscope's approvability policy. Learn more.}

[cursor]

What Changed

• Reuse existing MessagesTimeline work rows when re-derived grouped work entries contain the same entry object references.
• Added a regression test covering equivalent work-log group derivations that create new grouped arrays.

Why

react-doctor flagged MessagesTimeline as a render hot spot, and manual review found work-log rows lost structural sharing because grouped arrays were compared by array identity. A react-scan before/after browser probe showed WorkGroupSection rendered once before this fix during an equivalent timeline re-derivation and no longer rendered after the fix.

UI Changes

No visual UI changes.

Checklist

• This PR is small and focused
• I explained what changed and why
• I included before/after screenshots for any UI changes
• I included a video for animation/interaction changes

Note

Fix isRowUnchanged to use value equality for work row groupedEntries

In MessagesTimeline.logic.ts, the isRowUnchanged function previously used strict reference equality (===) to compare groupedEntries on work rows. This caused rows to be considered changed even when the arrays had identical content but were different instances — a common outcome when timeline derivations recompute grouped arrays.

The fix replaces the reference check with Equal.equals from effect/Equal, so structurally equivalent groupedEntries arrays now correctly mark the row as unchanged and reuse the existing row reference.

^{Macroscope summarized 4646c2a.}

---

Note

Low Risk
Low risk: changes only affect memoization/equality checks for work timeline rows and add a regression test; no data handling or auth logic touched.

Overview
Improves MessagesTimeline row stability by treating work rows as unchanged when their groupedEntries arrays are equivalent, even if re-derived as new array instances (switches comparison to Equal.equals).

Adds a regression test ensuring computeStableMessagesTimelineRows reuses prior work row objects across equivalent derivations to avoid unnecessary re-renders.

^{Reviewed by Cursor Bugbot for commit 4646c2a. Bugbot is set up for automated code reviews on this repo. Configure here.}

[juliusmarminge]

@cursor can we use effet/Equals here? It uses structural equality in v4

[cursor]

Replaced the hand-rolled areWorkGroupsUnchanged helper with Equal.equals from effect/Equal. In Effect v4 (which this project uses at 4.0.0-beta.59), Equal.equals provides structural equality for plain objects and arrays out of the box — so it's a drop-in replacement that removes 9 lines of custom comparison logic.

• What changed: Imported effect/Equal and replaced areWorkGroupsUnchanged(a, b) with Equal.equals(a, b) in the work case of isRowUnchanged. Removed the now-unused areWorkGroupsUnchanged function entirely.
• Validation: bun fmt, bun lint, bun typecheck, and all 18 tests pass (including the regression test for work row stability with new grouped arrays).

[macroscopeapp]

Approvability

Verdict: Approved

Small optimization change that uses deep equality instead of reference equality for comparing grouped entries, improving memoization stability. The change is self-contained with a corresponding test.

^{You can customize Macroscope's approvability policy. Learn more.}