fix(ssh): decode auth timestamps from JSON strings by ardenworks · Pull Request #2694 · pingdotgg/t3code

ardenworks · 2026-05-14T14:34:06Z

What Changed

Use Schema.DateTimeUtcFromString for auth response timestamp fields that are decoded from HTTP JSON responses.

Why

Desktop SSH pairing calls /api/auth/bootstrap/bearer. The remote server returns HTTP 200 with expiresAt serialized as an ISO string, but the desktop contract decoder currently expects a DateTimeUtc value.

That makes pairing fail during desktop:bootstrap-ssh-bearer-session even though the remote API request succeeds.

This fixes the mismatch by using the schema variant that accepts ISO timestamp strings from JSON and decodes them into DateTime.Utc values. The related auth response schemas are updated together because they use the same serialized timestamp shape over HTTP.

UI Changes

None.

Checklist

This PR is small and focused
I explained what changed and why
I included before/after screenshots for any UI changes
I included a video for animation/interaction changes

Note

Low Risk
Contract-only decoder alignment for serialized timestamps; no auth logic or server behavior changes.

Overview
Auth contract schemas in packages/contracts/src/auth.ts now decode HTTP JSON timestamps with Schema.DateTimeUtcFromString instead of Schema.DateTimeUtc, so ISO 8601 strings from the remote auth API (e.g. desktop SSH bearer bootstrap at /api/auth/bootstrap/bearer) parse correctly instead of failing after a successful 200 response.

The same change is applied across all auth response/session shapes that expose expiresAt, plus createdAt, issuedAt, and nullable lastConnectedAt on pairing links and client sessions.

^{Reviewed by Cursor Bugbot for commit 14936bd. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Fix auth timestamp decoding by switching to `DateTimeUtcFromString` in auth contracts

All timestamp fields in auth-related structs in auth.ts now use DateTimeUtcFromString instead of DateTimeUtc to correctly parse ISO 8601 datetime strings returned from the SSH auth API. This affects expiresAt, issuedAt, createdAt, and lastConnectedAt fields across AuthBootstrapResult, AuthBearerBootstrapResult, AuthWebSocketTokenResult, AuthPairingCredentialResult, AuthPairingLink, AuthClientSession, and AuthSessionState.

^{Macroscope summarized 14936bd.}

coderabbitai · 2026-05-14T14:34:15Z

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 61f8cd80-5f6b-4792-8f25-5dad95ba5f82

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

macroscopeapp · 2026-05-14T14:39:31Z

Approvability

Verdict: Approved

Straightforward bug fix that mechanically updates timestamp schema types from DateTimeUtc to DateTimeUtcFromString to properly decode JSON string representations. The change is consistent across all affected auth contracts with clear intent and limited scope.

^{You can customize Macroscope's approvability policy. Learn more.}

Xanacas · 2026-05-16T16:47:10Z

Manually confirmed. I ran into the same issue and was able to fix it by applying the batch from within this PR.

RoyLeviGit · 2026-05-17T11:52:39Z

verified locally, this fixed my issue.

RoyLeviGit

verified locally, fixed issue

bscholar-tt · 2026-05-21T00:02:25Z

Can confirm this fix works for me as well.
Hoping this can be merged in so I don't have to use a fork anymore.

randomUser00 · 2026-05-25T15:30:28Z

verified locally

gthay · 2026-06-01T01:48:36Z

@juliusmarminge please check this PR out.

ardenworks · 2026-06-03T18:11:30Z

Closing this since #2858 replaced the old SSH auth bootstrap path and issue #2665 is now closed.

Thanks to everyone who confirmed the fix here.

ardenworks · 2026-05-14T14:34:06Z

What Changed

Use Schema.DateTimeUtcFromString for auth response timestamp fields that are decoded from HTTP JSON responses.

Why

Fixes#2665.

Desktop SSH pairing calls /api/auth/bootstrap/bearer. The remote server returns HTTP 200 with expiresAt serialized as an ISO string, but the desktop contract decoder currently expects a DateTimeUtc value.

That makes pairing fail during desktop:bootstrap-ssh-bearer-session even though the remote API request succeeds.

This fixes the mismatch by using the schema variant that accepts ISO timestamp strings from JSON and decodes them into DateTime.Utc values. The related auth response schemas are updated together because they use the same serialized timestamp shape over HTTP.

UI Changes

None.

Checklist

This PR is small and focused
I explained what changed and why
I included before/after screenshots for any UI changes
I included a video for animation/interaction changes

Note

Low Risk
Contract-only decoder alignment for serialized timestamps; no auth logic or server behavior changes.

Overview
Auth contract schemas in packages/contracts/src/auth.ts now decode HTTP JSON timestamps with Schema.DateTimeUtcFromString instead of Schema.DateTimeUtc, so ISO 8601 strings from the remote auth API (e.g. desktop SSH bearer bootstrap at /api/auth/bootstrap/bearer) parse correctly instead of failing after a successful 200 response.

The same change is applied across all auth response/session shapes that expose expiresAt, plus createdAt, issuedAt, and nullable lastConnectedAt on pairing links and client sessions.

^{Reviewed by Cursor Bugbot for commit 14936bd. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Fix auth timestamp decoding by switching to `DateTimeUtcFromString` in auth contracts

All timestamp fields in auth-related structs in auth.ts now use DateTimeUtcFromString instead of DateTimeUtc to correctly parse ISO 8601 datetime strings returned from the SSH auth API. This affects expiresAt, issuedAt, createdAt, and lastConnectedAt fields across AuthBootstrapResult, AuthBearerBootstrapResult, AuthWebSocketTokenResult, AuthPairingCredentialResult, AuthPairingLink, AuthClientSession, and AuthSessionState.

^{Macroscope summarized 14936bd.}

coderabbitai · 2026-05-14T14:34:15Z

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 61f8cd80-5f6b-4792-8f25-5dad95ba5f82

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

macroscopeapp · 2026-05-14T14:39:31Z

Approvability

Verdict: Approved

Straightforward bug fix that mechanically updates timestamp schema types from DateTimeUtc to DateTimeUtcFromString to properly decode JSON string representations. The change is consistent across all affected auth contracts with clear intent and limited scope.

^{You can customize Macroscope's approvability policy. Learn more.}

Xanacas · 2026-05-16T16:47:10Z

Manually confirmed. I ran into the same issue and was able to fix it by applying the batch from within this PR.

RoyLeviGit · 2026-05-17T11:52:39Z

verified locally, this fixed my issue.

RoyLeviGit

verified locally, fixed issue

bscholar-tt · 2026-05-21T00:02:25Z

Can confirm this fix works for me as well.
Hoping this can be merged in so I don't have to use a fork anymore.

randomUser00 · 2026-05-25T15:30:28Z

verified locally

gthay · 2026-06-01T01:48:36Z

@juliusmarminge please check this PR out.

ardenworks · 2026-06-03T18:11:30Z

Closing this since #2858 replaced the old SSH auth bootstrap path and issue #2665 is now closed.

Thanks to everyone who confirmed the fix here.

ardenworks · 2026-05-14T14:34:06Z

What Changed

Use Schema.DateTimeUtcFromString for auth response timestamp fields that are decoded from HTTP JSON responses.

Why

Fixes#2665.

Desktop SSH pairing calls /api/auth/bootstrap/bearer. The remote server returns HTTP 200 with expiresAt serialized as an ISO string, but the desktop contract decoder currently expects a DateTimeUtc value.

That makes pairing fail during desktop:bootstrap-ssh-bearer-session even though the remote API request succeeds.

This fixes the mismatch by using the schema variant that accepts ISO timestamp strings from JSON and decodes them into DateTime.Utc values. The related auth response schemas are updated together because they use the same serialized timestamp shape over HTTP.

UI Changes

None.

Checklist

This PR is small and focused
I explained what changed and why
I included before/after screenshots for any UI changes
I included a video for animation/interaction changes

Note

Low Risk
Contract-only decoder alignment for serialized timestamps; no auth logic or server behavior changes.

Overview
Auth contract schemas in packages/contracts/src/auth.ts now decode HTTP JSON timestamps with Schema.DateTimeUtcFromString instead of Schema.DateTimeUtc, so ISO 8601 strings from the remote auth API (e.g. desktop SSH bearer bootstrap at /api/auth/bootstrap/bearer) parse correctly instead of failing after a successful 200 response.

The same change is applied across all auth response/session shapes that expose expiresAt, plus createdAt, issuedAt, and nullable lastConnectedAt on pairing links and client sessions.

^{Reviewed by Cursor Bugbot for commit 14936bd. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Fix auth timestamp decoding by switching to `DateTimeUtcFromString` in auth contracts

All timestamp fields in auth-related structs in auth.ts now use DateTimeUtcFromString instead of DateTimeUtc to correctly parse ISO 8601 datetime strings returned from the SSH auth API. This affects expiresAt, issuedAt, createdAt, and lastConnectedAt fields across AuthBootstrapResult, AuthBearerBootstrapResult, AuthWebSocketTokenResult, AuthPairingCredentialResult, AuthPairingLink, AuthClientSession, and AuthSessionState.

^{Macroscope summarized 14936bd.}

coderabbitai · 2026-05-14T14:34:15Z

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 61f8cd80-5f6b-4792-8f25-5dad95ba5f82

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

macroscopeapp · 2026-05-14T14:39:31Z

Approvability

Verdict: Approved

Straightforward bug fix that mechanically updates timestamp schema types from DateTimeUtc to DateTimeUtcFromString to properly decode JSON string representations. The change is consistent across all affected auth contracts with clear intent and limited scope.

^{You can customize Macroscope's approvability policy. Learn more.}

Xanacas · 2026-05-16T16:47:10Z

Manually confirmed. I ran into the same issue and was able to fix it by applying the batch from within this PR.

RoyLeviGit · 2026-05-17T11:52:39Z

verified locally, this fixed my issue.

RoyLeviGit

verified locally, fixed issue

bscholar-tt · 2026-05-21T00:02:25Z

Can confirm this fix works for me as well.
Hoping this can be merged in so I don't have to use a fork anymore.

randomUser00 · 2026-05-25T15:30:28Z

verified locally

gthay · 2026-06-01T01:48:36Z

@juliusmarminge please check this PR out.

ardenworks · 2026-06-03T18:11:30Z

Closing this since #2858 replaced the old SSH auth bootstrap path and issue #2665 is now closed.

Thanks to everyone who confirmed the fix here.

ardenworks · 2026-05-14T14:34:06Z

What Changed

Use Schema.DateTimeUtcFromString for auth response timestamp fields that are decoded from HTTP JSON responses.

Why

Fixes#2665.

Desktop SSH pairing calls /api/auth/bootstrap/bearer. The remote server returns HTTP 200 with expiresAt serialized as an ISO string, but the desktop contract decoder currently expects a DateTimeUtc value.

That makes pairing fail during desktop:bootstrap-ssh-bearer-session even though the remote API request succeeds.

This fixes the mismatch by using the schema variant that accepts ISO timestamp strings from JSON and decodes them into DateTime.Utc values. The related auth response schemas are updated together because they use the same serialized timestamp shape over HTTP.

UI Changes

None.

Checklist

This PR is small and focused
I explained what changed and why
I included before/after screenshots for any UI changes
I included a video for animation/interaction changes

Note

Low Risk
Contract-only decoder alignment for serialized timestamps; no auth logic or server behavior changes.

Overview
Auth contract schemas in packages/contracts/src/auth.ts now decode HTTP JSON timestamps with Schema.DateTimeUtcFromString instead of Schema.DateTimeUtc, so ISO 8601 strings from the remote auth API (e.g. desktop SSH bearer bootstrap at /api/auth/bootstrap/bearer) parse correctly instead of failing after a successful 200 response.

The same change is applied across all auth response/session shapes that expose expiresAt, plus createdAt, issuedAt, and nullable lastConnectedAt on pairing links and client sessions.

^{Reviewed by Cursor Bugbot for commit 14936bd. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Fix auth timestamp decoding by switching to `DateTimeUtcFromString` in auth contracts

All timestamp fields in auth-related structs in auth.ts now use DateTimeUtcFromString instead of DateTimeUtc to correctly parse ISO 8601 datetime strings returned from the SSH auth API. This affects expiresAt, issuedAt, createdAt, and lastConnectedAt fields across AuthBootstrapResult, AuthBearerBootstrapResult, AuthWebSocketTokenResult, AuthPairingCredentialResult, AuthPairingLink, AuthClientSession, and AuthSessionState.

^{Macroscope summarized 14936bd.}

coderabbitai · 2026-05-14T14:34:15Z

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 61f8cd80-5f6b-4792-8f25-5dad95ba5f82

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

macroscopeapp · 2026-05-14T14:39:31Z

Approvability

Verdict: Approved

Straightforward bug fix that mechanically updates timestamp schema types from DateTimeUtc to DateTimeUtcFromString to properly decode JSON string representations. The change is consistent across all affected auth contracts with clear intent and limited scope.

^{You can customize Macroscope's approvability policy. Learn more.}

Xanacas · 2026-05-16T16:47:10Z

Manually confirmed. I ran into the same issue and was able to fix it by applying the batch from within this PR.

RoyLeviGit · 2026-05-17T11:52:39Z

verified locally, this fixed my issue.

RoyLeviGit

verified locally, fixed issue

bscholar-tt · 2026-05-21T00:02:25Z

Can confirm this fix works for me as well.
Hoping this can be merged in so I don't have to use a fork anymore.

randomUser00 · 2026-05-25T15:30:28Z

verified locally

gthay · 2026-06-01T01:48:36Z

@juliusmarminge please check this PR out.

ardenworks · 2026-06-03T18:11:30Z

Closing this since #2858 replaced the old SSH auth bootstrap path and issue #2665 is now closed.

Thanks to everyone who confirmed the fix here.

ardenworks · 2026-05-14T14:34:06Z

What Changed

Use Schema.DateTimeUtcFromString for auth response timestamp fields that are decoded from HTTP JSON responses.

Why

Fixes#2665.

Desktop SSH pairing calls /api/auth/bootstrap/bearer. The remote server returns HTTP 200 with expiresAt serialized as an ISO string, but the desktop contract decoder currently expects a DateTimeUtc value.

That makes pairing fail during desktop:bootstrap-ssh-bearer-session even though the remote API request succeeds.

This fixes the mismatch by using the schema variant that accepts ISO timestamp strings from JSON and decodes them into DateTime.Utc values. The related auth response schemas are updated together because they use the same serialized timestamp shape over HTTP.

UI Changes

None.

Checklist

This PR is small and focused
I explained what changed and why
I included before/after screenshots for any UI changes
I included a video for animation/interaction changes

Note

Low Risk
Contract-only decoder alignment for serialized timestamps; no auth logic or server behavior changes.

Overview
Auth contract schemas in packages/contracts/src/auth.ts now decode HTTP JSON timestamps with Schema.DateTimeUtcFromString instead of Schema.DateTimeUtc, so ISO 8601 strings from the remote auth API (e.g. desktop SSH bearer bootstrap at /api/auth/bootstrap/bearer) parse correctly instead of failing after a successful 200 response.

The same change is applied across all auth response/session shapes that expose expiresAt, plus createdAt, issuedAt, and nullable lastConnectedAt on pairing links and client sessions.

^{Reviewed by Cursor Bugbot for commit 14936bd. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Fix auth timestamp decoding by switching to `DateTimeUtcFromString` in auth contracts

All timestamp fields in auth-related structs in auth.ts now use DateTimeUtcFromString instead of DateTimeUtc to correctly parse ISO 8601 datetime strings returned from the SSH auth API. This affects expiresAt, issuedAt, createdAt, and lastConnectedAt fields across AuthBootstrapResult, AuthBearerBootstrapResult, AuthWebSocketTokenResult, AuthPairingCredentialResult, AuthPairingLink, AuthClientSession, and AuthSessionState.

^{Macroscope summarized 14936bd.}

coderabbitai · 2026-05-14T14:34:15Z

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 61f8cd80-5f6b-4792-8f25-5dad95ba5f82

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

macroscopeapp · 2026-05-14T14:39:31Z

Approvability

Verdict: Approved

Straightforward bug fix that mechanically updates timestamp schema types from DateTimeUtc to DateTimeUtcFromString to properly decode JSON string representations. The change is consistent across all affected auth contracts with clear intent and limited scope.

^{You can customize Macroscope's approvability policy. Learn more.}

Xanacas · 2026-05-16T16:47:10Z

Manually confirmed. I ran into the same issue and was able to fix it by applying the batch from within this PR.

RoyLeviGit · 2026-05-17T11:52:39Z

verified locally, this fixed my issue.

RoyLeviGit

verified locally, fixed issue

bscholar-tt · 2026-05-21T00:02:25Z

Can confirm this fix works for me as well.
Hoping this can be merged in so I don't have to use a fork anymore.

randomUser00 · 2026-05-25T15:30:28Z

verified locally

gthay · 2026-06-01T01:48:36Z

@juliusmarminge please check this PR out.

ardenworks · 2026-06-03T18:11:30Z

Closing this since #2858 replaced the old SSH auth bootstrap path and issue #2665 is now closed.

Thanks to everyone who confirmed the fix here.

ardenworks · 2026-05-14T14:34:06Z

What Changed

Use Schema.DateTimeUtcFromString for auth response timestamp fields that are decoded from HTTP JSON responses.

Why

Fixes#2665.

Desktop SSH pairing calls /api/auth/bootstrap/bearer. The remote server returns HTTP 200 with expiresAt serialized as an ISO string, but the desktop contract decoder currently expects a DateTimeUtc value.

That makes pairing fail during desktop:bootstrap-ssh-bearer-session even though the remote API request succeeds.

This fixes the mismatch by using the schema variant that accepts ISO timestamp strings from JSON and decodes them into DateTime.Utc values. The related auth response schemas are updated together because they use the same serialized timestamp shape over HTTP.

UI Changes

None.

Checklist

This PR is small and focused
I explained what changed and why
I included before/after screenshots for any UI changes
I included a video for animation/interaction changes

Note

Low Risk
Contract-only decoder alignment for serialized timestamps; no auth logic or server behavior changes.

Overview
Auth contract schemas in packages/contracts/src/auth.ts now decode HTTP JSON timestamps with Schema.DateTimeUtcFromString instead of Schema.DateTimeUtc, so ISO 8601 strings from the remote auth API (e.g. desktop SSH bearer bootstrap at /api/auth/bootstrap/bearer) parse correctly instead of failing after a successful 200 response.

The same change is applied across all auth response/session shapes that expose expiresAt, plus createdAt, issuedAt, and nullable lastConnectedAt on pairing links and client sessions.

^{Reviewed by Cursor Bugbot for commit 14936bd. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Fix auth timestamp decoding by switching to `DateTimeUtcFromString` in auth contracts

All timestamp fields in auth-related structs in auth.ts now use DateTimeUtcFromString instead of DateTimeUtc to correctly parse ISO 8601 datetime strings returned from the SSH auth API. This affects expiresAt, issuedAt, createdAt, and lastConnectedAt fields across AuthBootstrapResult, AuthBearerBootstrapResult, AuthWebSocketTokenResult, AuthPairingCredentialResult, AuthPairingLink, AuthClientSession, and AuthSessionState.

^{Macroscope summarized 14936bd.}

coderabbitai · 2026-05-14T14:34:15Z

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 61f8cd80-5f6b-4792-8f25-5dad95ba5f82

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

macroscopeapp · 2026-05-14T14:39:31Z

Approvability

Verdict: Approved

Straightforward bug fix that mechanically updates timestamp schema types from DateTimeUtc to DateTimeUtcFromString to properly decode JSON string representations. The change is consistent across all affected auth contracts with clear intent and limited scope.

^{You can customize Macroscope's approvability policy. Learn more.}

Xanacas · 2026-05-16T16:47:10Z

Manually confirmed. I ran into the same issue and was able to fix it by applying the batch from within this PR.

RoyLeviGit · 2026-05-17T11:52:39Z

verified locally, this fixed my issue.

RoyLeviGit

verified locally, fixed issue

bscholar-tt · 2026-05-21T00:02:25Z

Can confirm this fix works for me as well.
Hoping this can be merged in so I don't have to use a fork anymore.

randomUser00 · 2026-05-25T15:30:28Z

verified locally

gthay · 2026-06-01T01:48:36Z

@juliusmarminge please check this PR out.

ardenworks · 2026-06-03T18:11:30Z

Closing this since #2858 replaced the old SSH auth bootstrap path and issue #2665 is now closed.

Thanks to everyone who confirmed the fix here.

ardenworks · 2026-05-14T14:34:06Z

What Changed

Use Schema.DateTimeUtcFromString for auth response timestamp fields that are decoded from HTTP JSON responses.

Why

Fixes#2665.

Desktop SSH pairing calls /api/auth/bootstrap/bearer. The remote server returns HTTP 200 with expiresAt serialized as an ISO string, but the desktop contract decoder currently expects a DateTimeUtc value.

That makes pairing fail during desktop:bootstrap-ssh-bearer-session even though the remote API request succeeds.

This fixes the mismatch by using the schema variant that accepts ISO timestamp strings from JSON and decodes them into DateTime.Utc values. The related auth response schemas are updated together because they use the same serialized timestamp shape over HTTP.

UI Changes

None.

Checklist

This PR is small and focused
I explained what changed and why
I included before/after screenshots for any UI changes
I included a video for animation/interaction changes

Note

Low Risk
Contract-only decoder alignment for serialized timestamps; no auth logic or server behavior changes.

Overview
Auth contract schemas in packages/contracts/src/auth.ts now decode HTTP JSON timestamps with Schema.DateTimeUtcFromString instead of Schema.DateTimeUtc, so ISO 8601 strings from the remote auth API (e.g. desktop SSH bearer bootstrap at /api/auth/bootstrap/bearer) parse correctly instead of failing after a successful 200 response.

The same change is applied across all auth response/session shapes that expose expiresAt, plus createdAt, issuedAt, and nullable lastConnectedAt on pairing links and client sessions.

^{Reviewed by Cursor Bugbot for commit 14936bd. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Fix auth timestamp decoding by switching to `DateTimeUtcFromString` in auth contracts

All timestamp fields in auth-related structs in auth.ts now use DateTimeUtcFromString instead of DateTimeUtc to correctly parse ISO 8601 datetime strings returned from the SSH auth API. This affects expiresAt, issuedAt, createdAt, and lastConnectedAt fields across AuthBootstrapResult, AuthBearerBootstrapResult, AuthWebSocketTokenResult, AuthPairingCredentialResult, AuthPairingLink, AuthClientSession, and AuthSessionState.

^{Macroscope summarized 14936bd.}

coderabbitai · 2026-05-14T14:34:15Z

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 61f8cd80-5f6b-4792-8f25-5dad95ba5f82

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

macroscopeapp · 2026-05-14T14:39:31Z

Approvability

Verdict: Approved

Straightforward bug fix that mechanically updates timestamp schema types from DateTimeUtc to DateTimeUtcFromString to properly decode JSON string representations. The change is consistent across all affected auth contracts with clear intent and limited scope.

^{You can customize Macroscope's approvability policy. Learn more.}

Xanacas · 2026-05-16T16:47:10Z

Manually confirmed. I ran into the same issue and was able to fix it by applying the batch from within this PR.

RoyLeviGit · 2026-05-17T11:52:39Z

verified locally, this fixed my issue.

RoyLeviGit

verified locally, fixed issue

bscholar-tt · 2026-05-21T00:02:25Z

Can confirm this fix works for me as well.
Hoping this can be merged in so I don't have to use a fork anymore.

randomUser00 · 2026-05-25T15:30:28Z

verified locally

gthay · 2026-06-01T01:48:36Z

@juliusmarminge please check this PR out.

ardenworks · 2026-06-03T18:11:30Z

Closing this since #2858 replaced the old SSH auth bootstrap path and issue #2665 is now closed.

Thanks to everyone who confirmed the fix here.

ardenworks · 2026-05-14T14:34:06Z

What Changed

Use Schema.DateTimeUtcFromString for auth response timestamp fields that are decoded from HTTP JSON responses.

Why

Fixes#2665.

Desktop SSH pairing calls /api/auth/bootstrap/bearer. The remote server returns HTTP 200 with expiresAt serialized as an ISO string, but the desktop contract decoder currently expects a DateTimeUtc value.

That makes pairing fail during desktop:bootstrap-ssh-bearer-session even though the remote API request succeeds.

This fixes the mismatch by using the schema variant that accepts ISO timestamp strings from JSON and decodes them into DateTime.Utc values. The related auth response schemas are updated together because they use the same serialized timestamp shape over HTTP.

UI Changes

None.

Checklist

This PR is small and focused
I explained what changed and why
I included before/after screenshots for any UI changes
I included a video for animation/interaction changes

Note

Low Risk
Contract-only decoder alignment for serialized timestamps; no auth logic or server behavior changes.

Overview
Auth contract schemas in packages/contracts/src/auth.ts now decode HTTP JSON timestamps with Schema.DateTimeUtcFromString instead of Schema.DateTimeUtc, so ISO 8601 strings from the remote auth API (e.g. desktop SSH bearer bootstrap at /api/auth/bootstrap/bearer) parse correctly instead of failing after a successful 200 response.

The same change is applied across all auth response/session shapes that expose expiresAt, plus createdAt, issuedAt, and nullable lastConnectedAt on pairing links and client sessions.

^{Reviewed by Cursor Bugbot for commit 14936bd. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Fix auth timestamp decoding by switching to `DateTimeUtcFromString` in auth contracts

All timestamp fields in auth-related structs in auth.ts now use DateTimeUtcFromString instead of DateTimeUtc to correctly parse ISO 8601 datetime strings returned from the SSH auth API. This affects expiresAt, issuedAt, createdAt, and lastConnectedAt fields across AuthBootstrapResult, AuthBearerBootstrapResult, AuthWebSocketTokenResult, AuthPairingCredentialResult, AuthPairingLink, AuthClientSession, and AuthSessionState.

^{Macroscope summarized 14936bd.}

coderabbitai · 2026-05-14T14:34:15Z

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 61f8cd80-5f6b-4792-8f25-5dad95ba5f82

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

macroscopeapp · 2026-05-14T14:39:31Z

Approvability

Verdict: Approved

Straightforward bug fix that mechanically updates timestamp schema types from DateTimeUtc to DateTimeUtcFromString to properly decode JSON string representations. The change is consistent across all affected auth contracts with clear intent and limited scope.

^{You can customize Macroscope's approvability policy. Learn more.}

Xanacas · 2026-05-16T16:47:10Z

Manually confirmed. I ran into the same issue and was able to fix it by applying the batch from within this PR.

RoyLeviGit · 2026-05-17T11:52:39Z

verified locally, this fixed my issue.

RoyLeviGit

verified locally, fixed issue

bscholar-tt · 2026-05-21T00:02:25Z

Can confirm this fix works for me as well.
Hoping this can be merged in so I don't have to use a fork anymore.

randomUser00 · 2026-05-25T15:30:28Z

verified locally

gthay · 2026-06-01T01:48:36Z

@juliusmarminge please check this PR out.

ardenworks · 2026-06-03T18:11:30Z

Closing this since #2858 replaced the old SSH auth bootstrap path and issue #2665 is now closed.

Thanks to everyone who confirmed the fix here.

fix(ssh): decode auth timestamps from JSON strings
c7d54ef

github-actionsBot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:S 10-29 changed lines (additions + deletions). labels May 14, 2026

ardenworks mentioned this pull request May 14, 2026
T3 Code Desktop 0.0.23 fails SSH environment pairing due to DateTime schema mismatch #2665
Closed

macroscopeappBot approved these changes May 14, 2026
View reviewed changes

RoyLeviGit approved these changes May 17, 2026
View reviewed changes

Merge branch 'main' into fix-ssh-auth-timestamps
978492b

Merge branch 'main' into fix-ssh-auth-timestamps
1565694

Pearcekieser mentioned this pull request May 28, 2026
[Bug]: SSH BUG WINDOWS #2786
Closed
2 tasks

ardenworks added 2 commits May 28, 2026 21:07

Merge branch 'main' into fix-ssh-auth-timestamps
0163fd9

Merge branch 'main' into fix-ssh-auth-timestamps
14936bd

Callanplays mentioned this pull request Jun 1, 2026
Fix auth JSON datetime decoding #2871
Closed

ardenworks closed this Jun 3, 2026

ardenworks deleted the fix-ssh-auth-timestamps branch June 3, 2026 18:04