Clear stale provider update toast CTA by jeremy0dell · Pull Request #2755 · pingdotgg/t3code

jeremy0dell · 2026-05-19T04:58:03Z

Summary

Clear stale toast action props when provider update progress toasts move into loading or success states.
Keep failed provider update toasts actionable via Settings.
Add regression coverage for Base UI shallow-merge behavior.

Root Cause

Base UI shallow-merges toast updates. The initial provider update prompt sets the primary CTA to Update, and the running toast update previously omitted actionProps, so the old CTA remained visible on the Updating providers toast.

Validation

bun run test
bun fmt
bun lint
bun typecheck

Note

Clear stale action buttons from provider update toast on progress and success

Adds buildProviderUpdateToastUpdate in ProviderUpdateLaunchNotification.logic.ts to centralize toast update construction for provider update views.
For loading/success views, sets actionProps: undefined explicitly to clear any action buttons (e.g. 'Update') left over from a previously shown prompt toast, working around shallow merge behavior in the toast manager.
For other views (e.g. rejected), attaches a 'Settings' action button with outline styling.
Refactors updateProviderUpdateToast in ProviderUpdateLaunchNotification.tsx to call the new helper instead of duplicating inline logic.

^{Macroscope summarized 6de68fc.}

Note

Low Risk
Low risk UI logic change that only affects how provider-update toasts are updated, plus targeted regression tests for the toast manager’s shallow-merge behavior.

Overview
Fixes provider update toasts so progress/success states no longer inherit stale CTA buttons from the initial prompt due to Base UI’s shallow-merge updates.

This introduces buildProviderUpdateToastUpdate to centralize toast update payloads, explicitly clearing actionProps for loading/success views while keeping failed/unchanged views actionable via a Settings button, and refactors ProviderUpdateLaunchNotification.tsx to use the helper. Adds regression tests that simulate merging a prompt toast with subsequent updates to ensure actions/secondary actions are cleared or preserved appropriately.

^{Reviewed by Cursor Bugbot for commit 6de68fc. Bugbot is set up for automated code reviews on this repo. Configure here.}

- Factor toast update construction into shared logic - Remove prompt actions from loading and success update states - Keep rejected update states actionable via Settings

coderabbitai · 2026-05-19T04:58:10Z

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: bf7ed644-56ff-4bb4-8f90-bf05326a5a58

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

juliusmarminge · 2026-07-20T09:12:43Z

Closing as the older conflicting duplicate of #3563, which is the maintained version of the provider-update toast behavior.

jeremy0dell · 2026-05-19T04:58:03Z

Summary

Clear stale toast action props when provider update progress toasts move into loading or success states.
Keep failed provider update toasts actionable via Settings.
Add regression coverage for Base UI shallow-merge behavior.

Root Cause

Base UI shallow-merges toast updates. The initial provider update prompt sets the primary CTA to Update, and the running toast update previously omitted actionProps, so the old CTA remained visible on the Updating providers toast.

Validation

bun run test
bun fmt
bun lint
bun typecheck

Note

Clear stale action buttons from provider update toast on progress and success

Adds buildProviderUpdateToastUpdate in ProviderUpdateLaunchNotification.logic.ts to centralize toast update construction for provider update views.
For loading/success views, sets actionProps: undefined explicitly to clear any action buttons (e.g. 'Update') left over from a previously shown prompt toast, working around shallow merge behavior in the toast manager.
For other views (e.g. rejected), attaches a 'Settings' action button with outline styling.
Refactors updateProviderUpdateToast in ProviderUpdateLaunchNotification.tsx to call the new helper instead of duplicating inline logic.

^{Macroscope summarized 6de68fc.}

Note

Low Risk
Low risk UI logic change that only affects how provider-update toasts are updated, plus targeted regression tests for the toast manager’s shallow-merge behavior.

Overview
Fixes provider update toasts so progress/success states no longer inherit stale CTA buttons from the initial prompt due to Base UI’s shallow-merge updates.

This introduces buildProviderUpdateToastUpdate to centralize toast update payloads, explicitly clearing actionProps for loading/success views while keeping failed/unchanged views actionable via a Settings button, and refactors ProviderUpdateLaunchNotification.tsx to use the helper. Adds regression tests that simulate merging a prompt toast with subsequent updates to ensure actions/secondary actions are cleared or preserved appropriately.

^{Reviewed by Cursor Bugbot for commit 6de68fc. Bugbot is set up for automated code reviews on this repo. Configure here.}

- Factor toast update construction into shared logic - Remove prompt actions from loading and success update states - Keep rejected update states actionable via Settings

coderabbitai · 2026-05-19T04:58:10Z

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: bf7ed644-56ff-4bb4-8f90-bf05326a5a58

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

juliusmarminge · 2026-07-20T09:12:43Z

Closing as the older conflicting duplicate of #3563, which is the maintained version of the provider-update toast behavior.

jeremy0dell · 2026-05-19T04:58:03Z

Summary

Clear stale toast action props when provider update progress toasts move into loading or success states.
Keep failed provider update toasts actionable via Settings.
Add regression coverage for Base UI shallow-merge behavior.

Root Cause

Base UI shallow-merges toast updates. The initial provider update prompt sets the primary CTA to Update, and the running toast update previously omitted actionProps, so the old CTA remained visible on the Updating providers toast.

Validation

bun run test
bun fmt
bun lint
bun typecheck

Note

Clear stale action buttons from provider update toast on progress and success

Adds buildProviderUpdateToastUpdate in ProviderUpdateLaunchNotification.logic.ts to centralize toast update construction for provider update views.
For loading/success views, sets actionProps: undefined explicitly to clear any action buttons (e.g. 'Update') left over from a previously shown prompt toast, working around shallow merge behavior in the toast manager.
For other views (e.g. rejected), attaches a 'Settings' action button with outline styling.
Refactors updateProviderUpdateToast in ProviderUpdateLaunchNotification.tsx to call the new helper instead of duplicating inline logic.

^{Macroscope summarized 6de68fc.}

Note

Low Risk
Low risk UI logic change that only affects how provider-update toasts are updated, plus targeted regression tests for the toast manager’s shallow-merge behavior.

Overview
Fixes provider update toasts so progress/success states no longer inherit stale CTA buttons from the initial prompt due to Base UI’s shallow-merge updates.

This introduces buildProviderUpdateToastUpdate to centralize toast update payloads, explicitly clearing actionProps for loading/success views while keeping failed/unchanged views actionable via a Settings button, and refactors ProviderUpdateLaunchNotification.tsx to use the helper. Adds regression tests that simulate merging a prompt toast with subsequent updates to ensure actions/secondary actions are cleared or preserved appropriately.

^{Reviewed by Cursor Bugbot for commit 6de68fc. Bugbot is set up for automated code reviews on this repo. Configure here.}

- Factor toast update construction into shared logic - Remove prompt actions from loading and success update states - Keep rejected update states actionable via Settings

coderabbitai · 2026-05-19T04:58:10Z

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: bf7ed644-56ff-4bb4-8f90-bf05326a5a58

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

juliusmarminge · 2026-07-20T09:12:43Z

Closing as the older conflicting duplicate of #3563, which is the maintained version of the provider-update toast behavior.

jeremy0dell · 2026-05-19T04:58:03Z

Summary

Clear stale toast action props when provider update progress toasts move into loading or success states.
Keep failed provider update toasts actionable via Settings.
Add regression coverage for Base UI shallow-merge behavior.

Root Cause

Base UI shallow-merges toast updates. The initial provider update prompt sets the primary CTA to Update, and the running toast update previously omitted actionProps, so the old CTA remained visible on the Updating providers toast.

Validation

bun run test
bun fmt
bun lint
bun typecheck

Note

Clear stale action buttons from provider update toast on progress and success

Adds buildProviderUpdateToastUpdate in ProviderUpdateLaunchNotification.logic.ts to centralize toast update construction for provider update views.
For loading/success views, sets actionProps: undefined explicitly to clear any action buttons (e.g. 'Update') left over from a previously shown prompt toast, working around shallow merge behavior in the toast manager.
For other views (e.g. rejected), attaches a 'Settings' action button with outline styling.
Refactors updateProviderUpdateToast in ProviderUpdateLaunchNotification.tsx to call the new helper instead of duplicating inline logic.

^{Macroscope summarized 6de68fc.}

Note

Low Risk
Low risk UI logic change that only affects how provider-update toasts are updated, plus targeted regression tests for the toast manager’s shallow-merge behavior.

Overview
Fixes provider update toasts so progress/success states no longer inherit stale CTA buttons from the initial prompt due to Base UI’s shallow-merge updates.

This introduces buildProviderUpdateToastUpdate to centralize toast update payloads, explicitly clearing actionProps for loading/success views while keeping failed/unchanged views actionable via a Settings button, and refactors ProviderUpdateLaunchNotification.tsx to use the helper. Adds regression tests that simulate merging a prompt toast with subsequent updates to ensure actions/secondary actions are cleared or preserved appropriately.

^{Reviewed by Cursor Bugbot for commit 6de68fc. Bugbot is set up for automated code reviews on this repo. Configure here.}

- Factor toast update construction into shared logic - Remove prompt actions from loading and success update states - Keep rejected update states actionable via Settings

coderabbitai · 2026-05-19T04:58:10Z

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: bf7ed644-56ff-4bb4-8f90-bf05326a5a58

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

juliusmarminge · 2026-07-20T09:12:43Z

Closing as the older conflicting duplicate of #3563, which is the maintained version of the provider-update toast behavior.

jeremy0dell · 2026-05-19T04:58:03Z

Summary

Clear stale toast action props when provider update progress toasts move into loading or success states.
Keep failed provider update toasts actionable via Settings.
Add regression coverage for Base UI shallow-merge behavior.

Root Cause

Base UI shallow-merges toast updates. The initial provider update prompt sets the primary CTA to Update, and the running toast update previously omitted actionProps, so the old CTA remained visible on the Updating providers toast.

Validation

bun run test
bun fmt
bun lint
bun typecheck

Note

Clear stale action buttons from provider update toast on progress and success

Adds buildProviderUpdateToastUpdate in ProviderUpdateLaunchNotification.logic.ts to centralize toast update construction for provider update views.
For loading/success views, sets actionProps: undefined explicitly to clear any action buttons (e.g. 'Update') left over from a previously shown prompt toast, working around shallow merge behavior in the toast manager.
For other views (e.g. rejected), attaches a 'Settings' action button with outline styling.
Refactors updateProviderUpdateToast in ProviderUpdateLaunchNotification.tsx to call the new helper instead of duplicating inline logic.

^{Macroscope summarized 6de68fc.}

Note

Low Risk
Low risk UI logic change that only affects how provider-update toasts are updated, plus targeted regression tests for the toast manager’s shallow-merge behavior.

Overview
Fixes provider update toasts so progress/success states no longer inherit stale CTA buttons from the initial prompt due to Base UI’s shallow-merge updates.

This introduces buildProviderUpdateToastUpdate to centralize toast update payloads, explicitly clearing actionProps for loading/success views while keeping failed/unchanged views actionable via a Settings button, and refactors ProviderUpdateLaunchNotification.tsx to use the helper. Adds regression tests that simulate merging a prompt toast with subsequent updates to ensure actions/secondary actions are cleared or preserved appropriately.

^{Reviewed by Cursor Bugbot for commit 6de68fc. Bugbot is set up for automated code reviews on this repo. Configure here.}

- Factor toast update construction into shared logic - Remove prompt actions from loading and success update states - Keep rejected update states actionable via Settings

coderabbitai · 2026-05-19T04:58:10Z

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: bf7ed644-56ff-4bb4-8f90-bf05326a5a58

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

juliusmarminge · 2026-07-20T09:12:43Z

Closing as the older conflicting duplicate of #3563, which is the maintained version of the provider-update toast behavior.

jeremy0dell · 2026-05-19T04:58:03Z

Summary

Clear stale toast action props when provider update progress toasts move into loading or success states.
Keep failed provider update toasts actionable via Settings.
Add regression coverage for Base UI shallow-merge behavior.

Root Cause

Base UI shallow-merges toast updates. The initial provider update prompt sets the primary CTA to Update, and the running toast update previously omitted actionProps, so the old CTA remained visible on the Updating providers toast.

Validation

bun run test
bun fmt
bun lint
bun typecheck

Note

Clear stale action buttons from provider update toast on progress and success

Adds buildProviderUpdateToastUpdate in ProviderUpdateLaunchNotification.logic.ts to centralize toast update construction for provider update views.
For loading/success views, sets actionProps: undefined explicitly to clear any action buttons (e.g. 'Update') left over from a previously shown prompt toast, working around shallow merge behavior in the toast manager.
For other views (e.g. rejected), attaches a 'Settings' action button with outline styling.
Refactors updateProviderUpdateToast in ProviderUpdateLaunchNotification.tsx to call the new helper instead of duplicating inline logic.

^{Macroscope summarized 6de68fc.}

Note

Low Risk
Low risk UI logic change that only affects how provider-update toasts are updated, plus targeted regression tests for the toast manager’s shallow-merge behavior.

Overview
Fixes provider update toasts so progress/success states no longer inherit stale CTA buttons from the initial prompt due to Base UI’s shallow-merge updates.

This introduces buildProviderUpdateToastUpdate to centralize toast update payloads, explicitly clearing actionProps for loading/success views while keeping failed/unchanged views actionable via a Settings button, and refactors ProviderUpdateLaunchNotification.tsx to use the helper. Adds regression tests that simulate merging a prompt toast with subsequent updates to ensure actions/secondary actions are cleared or preserved appropriately.

^{Reviewed by Cursor Bugbot for commit 6de68fc. Bugbot is set up for automated code reviews on this repo. Configure here.}

- Factor toast update construction into shared logic - Remove prompt actions from loading and success update states - Keep rejected update states actionable via Settings

coderabbitai · 2026-05-19T04:58:10Z

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: bf7ed644-56ff-4bb4-8f90-bf05326a5a58

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

juliusmarminge · 2026-07-20T09:12:43Z

Closing as the older conflicting duplicate of #3563, which is the maintained version of the provider-update toast behavior.

jeremy0dell · 2026-05-19T04:58:03Z

Summary

Clear stale toast action props when provider update progress toasts move into loading or success states.
Keep failed provider update toasts actionable via Settings.
Add regression coverage for Base UI shallow-merge behavior.

Root Cause

Base UI shallow-merges toast updates. The initial provider update prompt sets the primary CTA to Update, and the running toast update previously omitted actionProps, so the old CTA remained visible on the Updating providers toast.

Validation

bun run test
bun fmt
bun lint
bun typecheck

Note

Clear stale action buttons from provider update toast on progress and success

Adds buildProviderUpdateToastUpdate in ProviderUpdateLaunchNotification.logic.ts to centralize toast update construction for provider update views.
For loading/success views, sets actionProps: undefined explicitly to clear any action buttons (e.g. 'Update') left over from a previously shown prompt toast, working around shallow merge behavior in the toast manager.
For other views (e.g. rejected), attaches a 'Settings' action button with outline styling.
Refactors updateProviderUpdateToast in ProviderUpdateLaunchNotification.tsx to call the new helper instead of duplicating inline logic.

^{Macroscope summarized 6de68fc.}

Note

Low Risk
Low risk UI logic change that only affects how provider-update toasts are updated, plus targeted regression tests for the toast manager’s shallow-merge behavior.

Overview
Fixes provider update toasts so progress/success states no longer inherit stale CTA buttons from the initial prompt due to Base UI’s shallow-merge updates.

This introduces buildProviderUpdateToastUpdate to centralize toast update payloads, explicitly clearing actionProps for loading/success views while keeping failed/unchanged views actionable via a Settings button, and refactors ProviderUpdateLaunchNotification.tsx to use the helper. Adds regression tests that simulate merging a prompt toast with subsequent updates to ensure actions/secondary actions are cleared or preserved appropriately.

^{Reviewed by Cursor Bugbot for commit 6de68fc. Bugbot is set up for automated code reviews on this repo. Configure here.}

- Factor toast update construction into shared logic - Remove prompt actions from loading and success update states - Keep rejected update states actionable via Settings

coderabbitai · 2026-05-19T04:58:10Z

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: bf7ed644-56ff-4bb4-8f90-bf05326a5a58

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

juliusmarminge · 2026-07-20T09:12:43Z

Closing as the older conflicting duplicate of #3563, which is the maintained version of the provider-update toast behavior.

jeremy0dell · 2026-05-19T04:58:03Z

Summary

Clear stale toast action props when provider update progress toasts move into loading or success states.
Keep failed provider update toasts actionable via Settings.
Add regression coverage for Base UI shallow-merge behavior.

Root Cause

Base UI shallow-merges toast updates. The initial provider update prompt sets the primary CTA to Update, and the running toast update previously omitted actionProps, so the old CTA remained visible on the Updating providers toast.

Validation

bun run test
bun fmt
bun lint
bun typecheck

Note

Clear stale action buttons from provider update toast on progress and success

Adds buildProviderUpdateToastUpdate in ProviderUpdateLaunchNotification.logic.ts to centralize toast update construction for provider update views.
For loading/success views, sets actionProps: undefined explicitly to clear any action buttons (e.g. 'Update') left over from a previously shown prompt toast, working around shallow merge behavior in the toast manager.
For other views (e.g. rejected), attaches a 'Settings' action button with outline styling.
Refactors updateProviderUpdateToast in ProviderUpdateLaunchNotification.tsx to call the new helper instead of duplicating inline logic.

^{Macroscope summarized 6de68fc.}

Note

Low Risk
Low risk UI logic change that only affects how provider-update toasts are updated, plus targeted regression tests for the toast manager’s shallow-merge behavior.

Overview
Fixes provider update toasts so progress/success states no longer inherit stale CTA buttons from the initial prompt due to Base UI’s shallow-merge updates.

This introduces buildProviderUpdateToastUpdate to centralize toast update payloads, explicitly clearing actionProps for loading/success views while keeping failed/unchanged views actionable via a Settings button, and refactors ProviderUpdateLaunchNotification.tsx to use the helper. Adds regression tests that simulate merging a prompt toast with subsequent updates to ensure actions/secondary actions are cleared or preserved appropriately.

^{Reviewed by Cursor Bugbot for commit 6de68fc. Bugbot is set up for automated code reviews on this repo. Configure here.}

- Factor toast update construction into shared logic - Remove prompt actions from loading and success update states - Keep rejected update states actionable via Settings

coderabbitai · 2026-05-19T04:58:10Z

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: bf7ed644-56ff-4bb4-8f90-bf05326a5a58

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

juliusmarminge · 2026-07-20T09:12:43Z

Closing as the older conflicting duplicate of #3563, which is the maintained version of the provider-update toast behavior.