Uh oh!
There was an error while loading. Please reload this page.
Fix desktop context menu rendering - #280
Conversation
@krishkalaria12 is attempting to deploy a commit to the Ping Labs Team on Vercel. A member of the Team first needs to authorize it. |
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip CodeRabbit can generate a title for your PR based on the changes.Add |
Uh oh!
There was an error while loading. Please reload this page.
The latest updates on your projects. Learn more about Vercel for GitHub.
|
t3dotgg
commented
Mar 7, 2026
Not sure what happened to the diff but github is now convinced you edited a bunch of stuff you didn't. Rebase on main I guess |
krishkalaria12
commented
Mar 7, 2026
Cleaned it up and dropped the unrelated desktop dev-script change. It was already on top of |
maria-rcks
commented
Mar 12, 2026
@krishkalaria12 pls resolve conflicts / rebase |
917efbc to
424397eComparekrishkalaria12
commented
Mar 12, 2026
I have resolved the conflicts,, can you check once ? |
juliusmarminge
commented
Mar 12, 2026
maria-rcks
commented
Mar 12, 2026
it looks mostly out of place on linux window managers, and keeping the styling of the app on the menu would be nice 121859.mp4 |
juliusmarminge
commented
Mar 12, 2026
maybe it's just that I'm a sucker for keeping things native but the built in macos picker looks a lot better than the current web one imo. if we're going web only we should use the base-ui one: https://base-ui.com/react/components/context-menu |
krishkalaria12
commented
Mar 13, 2026
Maybe if you want, the changes can be done only for linux and keep the other os as it is ? |


Deletecontextmenupropagation on sidebar rows and fix the desktop dev script sobun run dev:desktopreliably starts both the bundle watcher and ElectronNote
Replace native Electron context menus with in-app context menus in the desktop sidebar
desktop:context-menuIPC channel, theshowContextMenubridge method, andcontextMenu.showfromNativeApi, replacing all native/Electron menu rendering with a React-based implementation.context-menu.tsxcomponent backed by@base-ui/react/context-menu, used directly inSidebar.tsx.contextMenuFallback.tspreviously used in non-Electron environments.window.desktopBridge.showContextMenuandnativeApi.contextMenu.showno longer exist; any external callers will getundefined.Macroscope summarized dbe4965.