Uh oh!
There was an error while loading. Please reload this page.
feat: integrate Grok Build CLI ACP provider with custom branding icons - #2909
feat: integrate Grok Build CLI ACP provider with custom branding icons#2909MalinoizXD wants to merge 1 commit into
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 7dca963. Configure here.
| }, | ||
| "dependencies": { | ||
| "@t3tools/monorepo": "." | ||
| }, |
There was a problem hiding this comment.
Root package.json has accidental self-referencing dependency
Medium Severity
The root workspace package.json adds "@t3tools/monorepo": "." as a dependency of itself. Since the package is already named @t3tools/monorepo, this creates a circular self-reference that serves no purpose and pollutes the dependency graph and bun.lock. This was almost certainly introduced unintentionally by tooling or an AI assistant.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 7dca963. Configure here.
| }), | ||
| ).pipe(Effect.asVoid); | ||
| } | ||
| }), |
There was a problem hiding this comment.
setModel fallback changes behavior for all ACP providers
Medium Severity
The setModel fallback path changed from calling setConfigOption("model", model) to calling acp.agent.setSessionModel(...) when started.modelConfigId is undefined. This change is in AcpSessionRuntime, which is shared infrastructure used by all ACP-based providers (Cursor, Grok Build, etc.), not just Grok Build. If any existing provider relies on the old setConfigOption("model", ...) fallback and doesn't implement session/set_model, model switching will break for that provider.
Reviewed by Cursor Bugbot for commit 7dca963. Configure here.
| @@ -543,8 +543,23 @@ const makeAcpSessionRuntime = ( | |||
| setConfigOption, | |||
| setModel: (model) => | |||
There was a problem hiding this comment.
🟡 Mediumacp/AcpSessionRuntime.ts:544
In setModel, when started.modelConfigId is defined, the setConfigOption call lacks .pipe(Effect.asVoid), so the function returns SetSessionConfigOptionResponse instead of void. This violates the interface contract at line 107 which specifies Effect.Effect<void, EffectAcpErrors.AcpError>. Consider adding .pipe(Effect.asVoid) to the branch to match the return type.
🤖 Copy this AI Prompt to have your agent fix this:
In file apps/server/src/provider/acp/AcpSessionRuntime.ts around line 544:
In `setModel`, when `started.modelConfigId` is defined, the `setConfigOption` call lacks `.pipe(Effect.asVoid)`, so the function returns `SetSessionConfigOptionResponse` instead of `void`. This violates the interface contract at line 107 which specifies `Effect.Effect<void, EffectAcpErrors.AcpError>`. Consider adding `.pipe(Effect.asVoid)` to the branch to match the return type.
Evidence trail:
apps/server/src/provider/acp/AcpSessionRuntime.ts line 107: interface declares `setModel: (model: string) => Effect.Effect<void, EffectAcpErrors.AcpError>`
apps/server/src/provider/acp/AcpSessionRuntime.ts lines 544-563: `setModel` implementation - line 548 returns `setConfigOption(started.modelConfigId, model)` (returns `Effect<SetSessionConfigOptionResponse>`), while line 560 correctly uses `.pipe(Effect.asVoid)`
apps/server/src/provider/acp/AcpSessionRuntime.ts lines 103-106: `setConfigOption` returns `Effect.Effect<EffectAcpSchema.SetSessionConfigOptionResponse, EffectAcpErrors.AcpError>`
packages/effect-acp/src/_generated/schema.gen.ts lines 9773-9776: `SetSessionConfigOptionResponse` is a struct with `_meta` and `configOptions` fields (not void)
| fill="currentColor" | ||
| d="M63.83 56.843c27.469-27.48 67.635-34.865 101.712-21.87l2.314.917c7.645 2.844 14.309 6.89 19.507 10.651l-28.857 13.342c-26.869-11.286-57.649-3.609-76.435 15.2c-25.405 25.414-30.539 69.484-.764 97.96L0 245.764c4.296-5.923 9.457-11.573 14.75-17.178l5.815-6.13l2.608-2.774c15.53-16.655 28.81-33.77 20.496-56.709l-.766-1.98c-14.592-35.497-6.094-77.096 20.928-104.15m156.956-21.587L256 0l-10.128 14.069c-21.094 29.716-30.456 48.424-21.11 88.659l-.065-.065c7.23 30.728-.503 64.803-25.472 89.802c-31.478 31.538-81.852 38.558-123.336 10.17l28.923-13.407c26.476 10.41 55.442 5.839 76.26-15.003c20.818-20.844 25.493-51.2 15.03-76.462c-1.989-4.79-7.952-5.992-12.125-2.909L98.87 157.755L220.786 35.147z" |
There was a problem hiding this comment.
🟢 Lowcomponents/Icons.tsx:688
The <path> element sets fill="currentColor", which overrides the fill-black dark:fill-white classes on the parent <svg>. This causes the icon to use the inherited text color property instead of the explicit black/white fill intended by the classes, unlike other icons in this file.
| fill="currentColor" | |
| d="M63.83 56.843c27.469-27.48 67.635-34.865 101.712-21.87l2.314.917c7.645 2.844 14.309 6.89 19.507 10.651l-28.857 13.342c-26.869-11.286-57.649-3.609-76.435 15.2c-25.405 25.414-30.539 69.484-.764 97.96L0 245.764c4.296-5.923 9.457-11.573 14.75-17.178l5.815-6.13l2.608-2.774c15.53-16.655 28.81-33.77 20.496-56.709l-.766-1.98c-14.592-35.497-6.094-77.096 20.928-104.15m156.956-21.587L256 0l-10.128 14.069c-21.094 29.716-30.456 48.424-21.11 88.659l-.065-.065c7.23 30.728-.503 64.803-25.472 89.802c-31.478 31.538-81.852 38.558-123.336 10.17l28.923-13.407c26.476 10.41 55.442 5.839 76.26-15.003c20.818-20.844 25.493-51.2 15.03-76.462c-1.989-4.79-7.952-5.992-12.125-2.909L98.87 157.755L220.786 35.147z" | |
| <path | |
| d="M63.83 56.843c27.469-27.48 67.635-34.865 101.712-21.87l2.314.917c7.645 2.844 14.309 6.89 19.507 10.651l-28.857 13.342c-26.869-11.286-57.649-3.609-76.435 15.2c-25.405 25.414-30.539 69.484-.764 97.96L0 245.764c4.296-5.923 9.457-11.573 14.75-17.178l5.815-6.13l2.608-2.774c15.53-16.655 28.81-33.77 20.496-56.709l-.766-1.98c-14.592-35.497-6.094-77.096 20.928-104.15m156.956-21.587L256 0l-10.128 14.069c-21.094 29.716-30.456 48.424-21.11 88.659l-.065-.065c7.23 30.728-.503 64.803-25.472 89.802c-31.478 31.538-81.852 38.558-123.336 10.17l28.923-13.407c26.476 10.41 55.442 5.839 76.26-15.003c20.818-20.844 25.493-51.2 15.03-76.462c-1.989-4.79-7.952-5.992-12.125-2.909L98.87 157.755L220.786 35.147z" |
🤖 Copy this AI Prompt to have your agent fix this:
In file apps/web/src/components/Icons.tsx around lines 688-689:
The `<path>` element sets `fill="currentColor"`, which overrides the `fill-black dark:fill-white` classes on the parent `<svg>`. This causes the icon to use the inherited text `color` property instead of the explicit black/white fill intended by the classes, unlike other icons in this file.
Evidence trail:
apps/web/src/components/Icons.tsx lines 685-692 (GrokIcon with fill-black dark:fill-white on svg and fill="currentColor" on path), lines 676-683 (XaiIcon same pattern), lines 474-479 (OpenAI icon with fill-black dark:fill-white on svg but NO fill on path), lines 656-662 (Discord icon same pattern as OpenAI), lines 667-673 (Arc icon same pattern as OpenAI)
ApprovabilityVerdict: Needs human review 1 blocking correctness issue found. This PR introduces a new Grok Build provider integration with ~1200 lines of new code and modifies shared AcpSessionRuntime infrastructure that affects all ACP providers. Unresolved review comments identify a potential breaking change to existing provider behavior and an accidental self-referencing dependency. You can customize Macroscope's approvability policy. Learn more. |
juliusmarminge
commented
Jul 20, 2026
Closing as superseded: Grok ACP provider support was already merged in #2809. This competing implementation is conflicting and retains actionable review findings. |
Summary
This PR integrates the new Grok Build CLI provider (xAI's coding assistant) as a first-class local agent session provider using the stdio-based Agent Communication Protocol (ACP). It also introduces custom branding SVG icons for xAI and Grok Build, replacing generic terminal icons and placeholder text.
Key Changes
1. Contracts & Configuration (
packages/contracts)model.ts:grok-buildprovider definition withGROK_BUILD_DRIVER_KIND.grok-buildandcomposer-2.5) with default display metadata.settings.ts:GrokBuildSettings,GrokBuildSettingsPatch).2. Server Implementation (
apps/server)GrokBuildDriver.ts,GrokBuildProvider.ts):AcpSessionRuntime.ts):model_pickerconfig options.session/set_modelfallback method so model swaps work correctly out of the box.GrokBuildAdapter.ts):cached_token).3. Web & Branding Improvements (
apps/web)Icons.tsx):XaiIcon(xAI company) andGrokIcon(Grok looping X symbol).providerDriverMeta.ts,providerIconUtils.ts):GrokIconas the primary logo forgrok-buildinstead of fallbackTerminalor initial placeholders ("GB").Verification
The following verification steps have been executed and verified on a Windows machine:
bun run typecheckpasses 100% cleanly across all 14 workspace packages.bun lintandbun run fmtran with zero lint errors and correct code formatting.Note
Cursor Bugbot is generating a summary for commit 7dca963. Configure here.
Note
Add Grok Build CLI ACP provider with custom branding icons
grok-buildprovider driver (GrokBuildDriver.ts) that spawns the Grok CLI as an ACP subprocess, manages session lifecycle, and streams runtime events.composer-2.5→grok-composer-2.5-fast).grokCLI via--versionat startup to set provider status; shows install instructions if missing (GrokBuildProvider.ts).GrokIconandXaiIconSVG components and wiresgrok-buildinto the provider icon map and settings UI.GrokBuildSettingsschema (command, args, envJson, customModels) to contracts and registers the driver in the built-in driver registry.📊 Macroscope summarized 7dca963. 14 files reviewed, 0 issues evaluated, 0 issues filtered, 0 comments posted
🗂️ Filtered Issues
No issues evaluated.