Uh oh!
There was an error while loading. Please reload this page.
feat(composer): clickable PR pill next to branch selector - #3065
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ApprovabilityVerdict: Approved Small UI feature adding a clickable PR indicator pill next to the branch selector. Changes are self-contained: extracts existing link-opening logic into a shared hook (refactor) and adds conditional UI rendering using existing utilities. No security, schema, or significant runtime behavior changes. You can customize Macroscope's approvability policy. Learn more. |
| const branchPr = resolveThreadPr(resolvedActiveBranch, branchStatusQuery.data ?? null); | ||
| const branchPrStatus = prStatusIndicator( | ||
| branchPr, | ||
| branchStatusQuery.data?.sourceControlProvider, | ||
| ); | ||
| // Action-oriented tooltip (the pill opens the PR), distinct from the sidebar's | ||
| // state-description tooltip. | ||
| const branchPrTooltip = branchPr | ||
| ? `Open ${sourceControlPresentation.terminology.singular} #${branchPr.number} (${branchPr.state}) in browser` | ||
| : ""; | ||
| const openPrLink = useCallback((event: MouseEvent<HTMLElement>, prUrl: string) => { | ||
| event.preventDefault(); | ||
| event.stopPropagation(); | ||
| const api = readLocalApi(); | ||
| if (!api) { | ||
| toastManager.add({ | ||
| type: "error", | ||
| title: "Link opening is unavailable.", | ||
| }); | ||
| return; | ||
| } | ||
| void api.shell.openExternal(prUrl).catch((error) => { | ||
| toastManager.add( | ||
| stackedThreadToast({ | ||
| type: "error", | ||
| title: "Unable to open pull request link", | ||
| description: error instanceof Error ? error.message : "An error occurred.", | ||
| }), | ||
| ); | ||
| }); |
There was a problem hiding this comment.
this is all duplicated from sidebar? should be extracted to some shared hook/module
There was a problem hiding this comment.
Good catch. Extracted into a shared useOpenPrLink hook (apps/web/src/lib/openPullRequestLink.ts) and updated both the sidebar and the composer branch selector to use it. Pushed in 91f6d6a7e.
Dismissing prior approval to re-evaluate 91f6d6a
81cf5c8 to
7c713b9Compare7c713b9 to
182c759CompareRender a small PR pill (icon + #number) to the left of the branch
selector in the bottom composer bar when the active branch has a pull
request. The pill is colored by PR state (open=emerald, merged=violet,
closed=zinc) via the shared prStatusIndicator, and clicking it opens the
PR in the system browser without opening the branch dropdown.
The tooltip is action-oriented ("Open pull request #N (state) in
browser") and uses the provider's terminology, distinct from the
sidebar's state-description tooltip.
Co-authored-by: codex <codex@users.noreply.github.com>Address review feedback: the openPrLink handler was duplicated verbatim between Sidebar and the composer branch selector. Extract it into a shared lib/openPullRequestLink hook and use it from both call sites. Co-authored-by: codex <codex@users.noreply.github.com>
182c759 to
7a8a619CompareDismissing prior approval to re-evaluate 7a8a619
Uh oh!
There was an error while loading. Please reload this page.
…3065) Co-authored-by: codex <codex@users.noreply.github.com>
…3065) Co-authored-by: codex <codex@users.noreply.github.com>
What
Adds a small clickable PR pill next to the branch selector in the bottom composer bar. When the active branch has a pull request, the pill shows the PR icon +
#<number>, colored by state:Clicking the pill opens the PR in the system browser. It sits to the left of the branch selector and does not open the branch dropdown (click is stopped/prevented).
Details
prStatusIndicator/ChangeRequestStatusIcon/resolveThreadPrfromThreadStatusIndicators.tsx, and thereadLocalApi()?.shell.openExternalpattern for opening links.useVcsStatus({ environmentId, cwd: branchCwd })query already inBranchToolbarBranchSelector.tsx— no backend changes.ComboboxTriggerinside a flex row; the toolbar layout classes were moved onto that wrapper so the branch group stays right-aligned.TheIcarusWings, basepingdotgg/t3code) via the existingGitManager.findLatestPrdetection.Test
Switch the bottom-bar branch to one with an open PR and confirm the pill appears with the right color and opens the correct GitHub URL.
Note
Low Risk
UI-only composer/sidebar change that reuses existing VCS status and external-link behavior; no auth, data, or backend impact.
Overview
Adds a clickable PR pill to the left of the composer branch selector when the active branch has an associated change request. The pill shows the status icon and
#number, uses existing state-based coloring fromprStatusIndicator, and opens the PR in the system browser via a new shared hook.useOpenPrLinkcentralizes opening external PR URLs: it stops click propagation/default (so the pill does not open the branch dropdown) and shows toasts when the local API is missing oropenExternalfails. Sidebar thread-row PR clicks now use this hook instead of a duplicated inline handler.Branch toolbar layout wraps the pill and
ComboboxTriggerin a flex row; toolbarclassNamemoves to that wrapper. PR data still comes from the existingvcsEnvironment.statusquery—no API changes.Reviewed by Cursor Bugbot for commit 7a8a619. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Add clickable PR status pill next to branch selector in toolbar
classNameprop onBranchToolbarBranchSelectornow applies to a new wrapperdivrather than directly toComboboxTrigger, which may affect styling if callers rely on that specificity.Macroscope summarized 7a8a619.