Uh oh!
There was an error while loading. Please reload this page.
[codex] Refactor review and text generation services - #3196
Merged
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Contributor
🚀 Expo continuous deployment is ready!
|
juliusmarminge
marked this pull request as ready for review
June 20, 2026 02:06
Contributor
ApprovabilityVerdict: Approved This PR contains mechanical refactoring changes - converting named imports to namespace imports and reorganizing type definitions. No runtime behavior is modified; the actual function implementations remain identical. You can customize Macroscope's approvability policy. Learn more. |
juliusmarmingeforce-pushed
the
codex/effect-service-server-review-text
branch
from
June 20, 2026 02:34
349a8f2 to
3d81b95ComparemacroscopeappBot
dismissed
their stale reviewJune 20, 2026 02:34
Dismissing prior approval to re-evaluate 3d81b95
juliusmarmingeforce-pushed
the
codex/effect-service-server-review-text
branch
from
June 20, 2026 03:10
3d81b95 to
874c228ComparemacroscopeappBot
dismissed
their stale reviewJune 20, 2026 03:10
Dismissing prior approval to re-evaluate 874c228
Co-authored-by: codex <codex@users.noreply.github.com>
juliusmarmingeforce-pushed
the
codex/effect-service-server-review-text
branch
from
June 20, 2026 03:17
874c228 to
7fe6a2eComparemacroscopeappBot
dismissed
their stale reviewJune 20, 2026 03:18
Dismissing prior approval to re-evaluate 7fe6a2e
Uh oh!
There was an error while loading. Please reload this page.
slan48 pushed a commit
to slan48/t3code
that referenced
this pull request
Jun 24, 2026
Fork customization triage: - Item 2 (AGENTS.md), Item 3 (.gitignore): untouched upstream, kept. - Item 4 (Cmd+B sidebar.toggle): SUPERSEDED by upstream pingdotgg#3497 'Add main sidebar toggle'. Adopted upstream's SidebarControl handler + UI wholesale; dropped our capture-phase SidebarShortcutHandler and orphaned isSidebarToggleShortcut helper. Pending manual smoke test (composer/terminal focus). - Item 5 (sidecar prompt-injection hardening): KEPT. Upstream pingdotgg#3196/pingdotgg#3292 refactored the invocation (resolveSpawnCommand) and reverted to --dangerously-skip-permissions; auto-merge preserved our --permission-mode default --allowed-tools StructuredOutput swap + tests. - Item 6(a) (live token usage in working row): KEPT, re-integrated activeContextWindow threading onto upstream's reworked MessagesTimeline (made the prop optional). - Item 6(b) (in-flight tool-call rows): DROPPED as superseded by upstream pingdotgg#3022 work-log rework (toolLifecycleStatus + WorkEntryIconSvg). Removed status field usage, took upstream's session-logic.{ts,test.ts} wholesale.
NeilTheFisher pushed a commit
to NeilTheFisher/t3code
that referenced
this pull request
Aug 18, 2026
Co-authored-by: codex <codex@users.noreply.github.com>
darjss pushed a commit
to darjss/t3code
that referenced
this pull request
Aug 26, 2026
Co-authored-by: codex <codex@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ReviewServiceandTextGenerationservice contracts inline on theirContext.Servicetags.makeandlayerexports without syntheticEffect.succeedwrappers.Service["Service"]types.TextGenerationServiceprovider contract.TextGenerationShapealias only for the excluded orchestration compatibility harness; this PR does not modify orchestration modules.Behavior
Provider-instance routing, review diff generation, and text-generation behavior are unchanged. This is a service-module organization and typing refactor.
Validation
vp check— passed; 20 pre-existing unrelated warningsvp run typecheck— passedNote
Low Risk
Import and typing refactors only; provider-instance routing and service behavior are unchanged, with broad test coverage noted in the PR.
Overview
This PR mechanically aligns the review and text-generation domains with the repo’s target Effect
Context.Servicepattern without changing routing or generation behavior.TextGenerationnow defines its API on the service tag itself (replacing a separateTextGenerationShapeinterface), builds registry-backed implementations viaTextGeneration.of, and exposes amakeeffect plus alayerwired asLayer.effect(TextGeneration, make). A deprecatedTextGenerationShapealias remains for legacy consumers.ReviewServicefollows the same move: the standalone shape type is removed,makeis a plainEffect.gen, and the layer references that effect directly.All provider implementations (Claude, Codex, Cursor, Grok, OpenCode) and
ProviderDrivernow satisfyTextGeneration.TextGeneration["Service"]instead of the old shape type. Tests and harnesses (GitManager,ProviderAdapterRegistry, text-generation tests, etc.) switch to namespace imports (* as Module) for services, config, GitHub CLI, and related helpers so tokens and errors are referenced in a consistent, module-qualified way.Reviewed by Cursor Bugbot for commit 7fe6a2e. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Refactor text generation and review services to use namespace imports
ClaudeTextGeneration,CodexTextGeneration,CursorTextGeneration,GrokTextGeneration,OpenCodeTextGeneration) and theReviewService, aligning import style with Effect.js conventions.TextGenerationShapeinterface with an inlineContext.Service-basedTextGenerationclass; exportsTextGenerationShapeas a deprecated type alias for backward compatibility.makeeffect toTextGeneration.tsand simplifies the layer toLayer.effect(TextGeneration, make).ReviewServiceto inline its service shape viaContext.Servicegeneric and changesmakefrom a function returning an Effect to a plain Effect.GitManager.test.tsandProviderAdapterRegistry.test.tsto use namespaced service tokens (e.g.ServerConfig.ServerConfig.layerTest).Macroscope summarized 7fe6a2e.