[codex] Structure managed relay state errors

[juliusmarminge]

Summary

• split managed relay session failures into distinct schema errors with account context
• preserve the original token-provider cause while avoiding invented causes for unavailable state
• attach expected and actual values to relay status validation failures
• migrate the touched stream test to the Effect test runtime

Verification

• vp test packages/client-runtime/src/relay/managedRelayState.test.ts
• vp check
• vp run typecheck

---

Note

Low Risk
Scoped to client-runtime relay error modeling and tests; behavior is clearer failures and safer diagnostics, not new relay or auth flows.

Overview
Replaces the single generic managed relay session and snapshot errors with Effect Schema tagged error unions so callers can branch on failure kind and get structured context (account IDs, expected vs actual environment IDs).

Session path: token read failures become ManagedRelayTokenReadError with the original provider cause; null tokens vs missing/wrong-account sessions are split into ManagedRelayTokenUnavailableError and ManagedRelaySessionUnavailableError (with requestedAccountId).

Status validation: environment, endpoint, and descriptor mismatches each get their own error type with expected/actual IDs. Endpoint mismatches are built via ManagedRelayStatusEndpointMismatchError.fromEndpoints, which uses getUrlDiagnostics so logs expose protocol, hostname, and URL length—not credentials, paths, query tokens, or fragments.

Tests assert the new types, redaction behavior, and clearer mismatch messages; one stream test moves to it.effect with fibers.

^{Reviewed by Cursor Bugbot for commit 5944bad. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Structure managed relay state errors into typed, secret-redacted error classes

• Replaces generic ManagedRelaySessionError and ManagedRelaySnapshotError with discriminated unions of specific Schema.TaggedErrorClass types, each carrying structured context (account IDs, environment IDs, URL diagnostics).
• Adds ManagedRelayTokenReadError, ManagedRelayTokenUnavailableError, and ManagedRelaySessionUnavailableError to distinguish token read failures, absent tokens, and missing/mismatched sessions.
• Adds ManagedRelayStatusEnvironmentMismatchError, ManagedRelayStatusEndpointMismatchError, and ManagedRelayStatusDescriptorEnvironmentMismatchError for snapshot validation; endpoint mismatches redact URL secrets, exposing only protocol, hostname, and input lengths.
• Updates tests in managedRelayState.test.ts to assert on the new error types and redaction behavior, and migrates one test to Effect-style using Effect.forkChild/Fiber.join.

^{Macroscope summarized 5944bad.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 432dad8f-8a0a-455c-bdf2-9de83e4be5bd

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/audit-managed-relay-state-errors

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[macroscopeapp]

Approvability

Verdict: Approved

This PR refactors error classes in the managed relay module to be more structured and informative, adding contextual fields like accountId and environmentId. The changes improve error diagnostics without altering runtime control flow, and include proper URL redaction to avoid exposing secrets.

No code changes detected at 5944bad. Prior analysis still applies.

^{You can customize Macroscope's approvability policy. Learn more.}

Dismissing prior approval to re-evaluate 1d14eef

Dismissing prior approval to re-evaluate 713e11b

Dismissing prior approval to re-evaluate ad2be2d

[juliusmarminge]

Summary

• split managed relay session failures into distinct schema errors with account context
• preserve the original token-provider cause while avoiding invented causes for unavailable state
• attach expected and actual values to relay status validation failures
• migrate the touched stream test to the Effect test runtime

Verification

• vp test packages/client-runtime/src/relay/managedRelayState.test.ts
• vp check
• vp run typecheck

---

Note

Low Risk
Scoped to client-runtime relay error modeling and tests; behavior is clearer failures and safer diagnostics, not new relay or auth flows.

Overview
Replaces the single generic managed relay session and snapshot errors with Effect Schema tagged error unions so callers can branch on failure kind and get structured context (account IDs, expected vs actual environment IDs).

Session path: token read failures become ManagedRelayTokenReadError with the original provider cause; null tokens vs missing/wrong-account sessions are split into ManagedRelayTokenUnavailableError and ManagedRelaySessionUnavailableError (with requestedAccountId).

Status validation: environment, endpoint, and descriptor mismatches each get their own error type with expected/actual IDs. Endpoint mismatches are built via ManagedRelayStatusEndpointMismatchError.fromEndpoints, which uses getUrlDiagnostics so logs expose protocol, hostname, and URL length—not credentials, paths, query tokens, or fragments.

Tests assert the new types, redaction behavior, and clearer mismatch messages; one stream test moves to it.effect with fibers.

^{Reviewed by Cursor Bugbot for commit 5944bad. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Structure managed relay state errors into typed, secret-redacted error classes

• Replaces generic ManagedRelaySessionError and ManagedRelaySnapshotError with discriminated unions of specific Schema.TaggedErrorClass types, each carrying structured context (account IDs, environment IDs, URL diagnostics).
• Adds ManagedRelayTokenReadError, ManagedRelayTokenUnavailableError, and ManagedRelaySessionUnavailableError to distinguish token read failures, absent tokens, and missing/mismatched sessions.
• Adds ManagedRelayStatusEnvironmentMismatchError, ManagedRelayStatusEndpointMismatchError, and ManagedRelayStatusDescriptorEnvironmentMismatchError for snapshot validation; endpoint mismatches redact URL secrets, exposing only protocol, hostname, and input lengths.
• Updates tests in managedRelayState.test.ts to assert on the new error types and redaction behavior, and migrates one test to Effect-style using Effect.forkChild/Fiber.join.

^{Macroscope summarized 5944bad.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 432dad8f-8a0a-455c-bdf2-9de83e4be5bd

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/audit-managed-relay-state-errors

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[macroscopeapp]

Approvability

Verdict: Approved

This PR refactors error classes in the managed relay module to be more structured and informative, adding contextual fields like accountId and environmentId. The changes improve error diagnostics without altering runtime control flow, and include proper URL redaction to avoid exposing secrets.

No code changes detected at 5944bad. Prior analysis still applies.

^{You can customize Macroscope's approvability policy. Learn more.}

Dismissing prior approval to re-evaluate 1d14eef

Dismissing prior approval to re-evaluate 713e11b

Dismissing prior approval to re-evaluate ad2be2d

[juliusmarminge]

Summary

• split managed relay session failures into distinct schema errors with account context
• preserve the original token-provider cause while avoiding invented causes for unavailable state
• attach expected and actual values to relay status validation failures
• migrate the touched stream test to the Effect test runtime

Verification

• vp test packages/client-runtime/src/relay/managedRelayState.test.ts
• vp check
• vp run typecheck

---

Note

Low Risk
Scoped to client-runtime relay error modeling and tests; behavior is clearer failures and safer diagnostics, not new relay or auth flows.

Overview
Replaces the single generic managed relay session and snapshot errors with Effect Schema tagged error unions so callers can branch on failure kind and get structured context (account IDs, expected vs actual environment IDs).

Session path: token read failures become ManagedRelayTokenReadError with the original provider cause; null tokens vs missing/wrong-account sessions are split into ManagedRelayTokenUnavailableError and ManagedRelaySessionUnavailableError (with requestedAccountId).

Status validation: environment, endpoint, and descriptor mismatches each get their own error type with expected/actual IDs. Endpoint mismatches are built via ManagedRelayStatusEndpointMismatchError.fromEndpoints, which uses getUrlDiagnostics so logs expose protocol, hostname, and URL length—not credentials, paths, query tokens, or fragments.

Tests assert the new types, redaction behavior, and clearer mismatch messages; one stream test moves to it.effect with fibers.

^{Reviewed by Cursor Bugbot for commit 5944bad. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Structure managed relay state errors into typed, secret-redacted error classes

• Replaces generic ManagedRelaySessionError and ManagedRelaySnapshotError with discriminated unions of specific Schema.TaggedErrorClass types, each carrying structured context (account IDs, environment IDs, URL diagnostics).
• Adds ManagedRelayTokenReadError, ManagedRelayTokenUnavailableError, and ManagedRelaySessionUnavailableError to distinguish token read failures, absent tokens, and missing/mismatched sessions.
• Adds ManagedRelayStatusEnvironmentMismatchError, ManagedRelayStatusEndpointMismatchError, and ManagedRelayStatusDescriptorEnvironmentMismatchError for snapshot validation; endpoint mismatches redact URL secrets, exposing only protocol, hostname, and input lengths.
• Updates tests in managedRelayState.test.ts to assert on the new error types and redaction behavior, and migrates one test to Effect-style using Effect.forkChild/Fiber.join.

^{Macroscope summarized 5944bad.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 432dad8f-8a0a-455c-bdf2-9de83e4be5bd

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/audit-managed-relay-state-errors

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[macroscopeapp]

Approvability

Verdict: Approved

This PR refactors error classes in the managed relay module to be more structured and informative, adding contextual fields like accountId and environmentId. The changes improve error diagnostics without altering runtime control flow, and include proper URL redaction to avoid exposing secrets.

No code changes detected at 5944bad. Prior analysis still applies.

^{You can customize Macroscope's approvability policy. Learn more.}

Dismissing prior approval to re-evaluate 1d14eef

Dismissing prior approval to re-evaluate 713e11b

Dismissing prior approval to re-evaluate ad2be2d

[juliusmarminge]

Summary

• split managed relay session failures into distinct schema errors with account context
• preserve the original token-provider cause while avoiding invented causes for unavailable state
• attach expected and actual values to relay status validation failures
• migrate the touched stream test to the Effect test runtime

Verification

• vp test packages/client-runtime/src/relay/managedRelayState.test.ts
• vp check
• vp run typecheck

---

Note

Low Risk
Scoped to client-runtime relay error modeling and tests; behavior is clearer failures and safer diagnostics, not new relay or auth flows.

Overview
Replaces the single generic managed relay session and snapshot errors with Effect Schema tagged error unions so callers can branch on failure kind and get structured context (account IDs, expected vs actual environment IDs).

Session path: token read failures become ManagedRelayTokenReadError with the original provider cause; null tokens vs missing/wrong-account sessions are split into ManagedRelayTokenUnavailableError and ManagedRelaySessionUnavailableError (with requestedAccountId).

Status validation: environment, endpoint, and descriptor mismatches each get their own error type with expected/actual IDs. Endpoint mismatches are built via ManagedRelayStatusEndpointMismatchError.fromEndpoints, which uses getUrlDiagnostics so logs expose protocol, hostname, and URL length—not credentials, paths, query tokens, or fragments.

Tests assert the new types, redaction behavior, and clearer mismatch messages; one stream test moves to it.effect with fibers.

^{Reviewed by Cursor Bugbot for commit 5944bad. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Structure managed relay state errors into typed, secret-redacted error classes

• Replaces generic ManagedRelaySessionError and ManagedRelaySnapshotError with discriminated unions of specific Schema.TaggedErrorClass types, each carrying structured context (account IDs, environment IDs, URL diagnostics).
• Adds ManagedRelayTokenReadError, ManagedRelayTokenUnavailableError, and ManagedRelaySessionUnavailableError to distinguish token read failures, absent tokens, and missing/mismatched sessions.
• Adds ManagedRelayStatusEnvironmentMismatchError, ManagedRelayStatusEndpointMismatchError, and ManagedRelayStatusDescriptorEnvironmentMismatchError for snapshot validation; endpoint mismatches redact URL secrets, exposing only protocol, hostname, and input lengths.
• Updates tests in managedRelayState.test.ts to assert on the new error types and redaction behavior, and migrates one test to Effect-style using Effect.forkChild/Fiber.join.

^{Macroscope summarized 5944bad.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 432dad8f-8a0a-455c-bdf2-9de83e4be5bd

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/audit-managed-relay-state-errors

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[macroscopeapp]

Approvability

Verdict: Approved

This PR refactors error classes in the managed relay module to be more structured and informative, adding contextual fields like accountId and environmentId. The changes improve error diagnostics without altering runtime control flow, and include proper URL redaction to avoid exposing secrets.

No code changes detected at 5944bad. Prior analysis still applies.

^{You can customize Macroscope's approvability policy. Learn more.}

Dismissing prior approval to re-evaluate 1d14eef

Dismissing prior approval to re-evaluate 713e11b

Dismissing prior approval to re-evaluate ad2be2d

[juliusmarminge]

Summary

• split managed relay session failures into distinct schema errors with account context
• preserve the original token-provider cause while avoiding invented causes for unavailable state
• attach expected and actual values to relay status validation failures
• migrate the touched stream test to the Effect test runtime

Verification

• vp test packages/client-runtime/src/relay/managedRelayState.test.ts
• vp check
• vp run typecheck

---

Note

Low Risk
Scoped to client-runtime relay error modeling and tests; behavior is clearer failures and safer diagnostics, not new relay or auth flows.

Overview
Replaces the single generic managed relay session and snapshot errors with Effect Schema tagged error unions so callers can branch on failure kind and get structured context (account IDs, expected vs actual environment IDs).

Session path: token read failures become ManagedRelayTokenReadError with the original provider cause; null tokens vs missing/wrong-account sessions are split into ManagedRelayTokenUnavailableError and ManagedRelaySessionUnavailableError (with requestedAccountId).

Status validation: environment, endpoint, and descriptor mismatches each get their own error type with expected/actual IDs. Endpoint mismatches are built via ManagedRelayStatusEndpointMismatchError.fromEndpoints, which uses getUrlDiagnostics so logs expose protocol, hostname, and URL length—not credentials, paths, query tokens, or fragments.

Tests assert the new types, redaction behavior, and clearer mismatch messages; one stream test moves to it.effect with fibers.

^{Reviewed by Cursor Bugbot for commit 5944bad. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Structure managed relay state errors into typed, secret-redacted error classes

• Replaces generic ManagedRelaySessionError and ManagedRelaySnapshotError with discriminated unions of specific Schema.TaggedErrorClass types, each carrying structured context (account IDs, environment IDs, URL diagnostics).
• Adds ManagedRelayTokenReadError, ManagedRelayTokenUnavailableError, and ManagedRelaySessionUnavailableError to distinguish token read failures, absent tokens, and missing/mismatched sessions.
• Adds ManagedRelayStatusEnvironmentMismatchError, ManagedRelayStatusEndpointMismatchError, and ManagedRelayStatusDescriptorEnvironmentMismatchError for snapshot validation; endpoint mismatches redact URL secrets, exposing only protocol, hostname, and input lengths.
• Updates tests in managedRelayState.test.ts to assert on the new error types and redaction behavior, and migrates one test to Effect-style using Effect.forkChild/Fiber.join.

^{Macroscope summarized 5944bad.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 432dad8f-8a0a-455c-bdf2-9de83e4be5bd

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/audit-managed-relay-state-errors

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[macroscopeapp]

Approvability

Verdict: Approved

This PR refactors error classes in the managed relay module to be more structured and informative, adding contextual fields like accountId and environmentId. The changes improve error diagnostics without altering runtime control flow, and include proper URL redaction to avoid exposing secrets.

No code changes detected at 5944bad. Prior analysis still applies.

^{You can customize Macroscope's approvability policy. Learn more.}

Dismissing prior approval to re-evaluate 1d14eef

Dismissing prior approval to re-evaluate 713e11b

Dismissing prior approval to re-evaluate ad2be2d

[juliusmarminge]

Summary

• split managed relay session failures into distinct schema errors with account context
• preserve the original token-provider cause while avoiding invented causes for unavailable state
• attach expected and actual values to relay status validation failures
• migrate the touched stream test to the Effect test runtime

Verification

• vp test packages/client-runtime/src/relay/managedRelayState.test.ts
• vp check
• vp run typecheck

---

Note

Low Risk
Scoped to client-runtime relay error modeling and tests; behavior is clearer failures and safer diagnostics, not new relay or auth flows.

Overview
Replaces the single generic managed relay session and snapshot errors with Effect Schema tagged error unions so callers can branch on failure kind and get structured context (account IDs, expected vs actual environment IDs).

Session path: token read failures become ManagedRelayTokenReadError with the original provider cause; null tokens vs missing/wrong-account sessions are split into ManagedRelayTokenUnavailableError and ManagedRelaySessionUnavailableError (with requestedAccountId).

Status validation: environment, endpoint, and descriptor mismatches each get their own error type with expected/actual IDs. Endpoint mismatches are built via ManagedRelayStatusEndpointMismatchError.fromEndpoints, which uses getUrlDiagnostics so logs expose protocol, hostname, and URL length—not credentials, paths, query tokens, or fragments.

Tests assert the new types, redaction behavior, and clearer mismatch messages; one stream test moves to it.effect with fibers.

^{Reviewed by Cursor Bugbot for commit 5944bad. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Structure managed relay state errors into typed, secret-redacted error classes

• Replaces generic ManagedRelaySessionError and ManagedRelaySnapshotError with discriminated unions of specific Schema.TaggedErrorClass types, each carrying structured context (account IDs, environment IDs, URL diagnostics).
• Adds ManagedRelayTokenReadError, ManagedRelayTokenUnavailableError, and ManagedRelaySessionUnavailableError to distinguish token read failures, absent tokens, and missing/mismatched sessions.
• Adds ManagedRelayStatusEnvironmentMismatchError, ManagedRelayStatusEndpointMismatchError, and ManagedRelayStatusDescriptorEnvironmentMismatchError for snapshot validation; endpoint mismatches redact URL secrets, exposing only protocol, hostname, and input lengths.
• Updates tests in managedRelayState.test.ts to assert on the new error types and redaction behavior, and migrates one test to Effect-style using Effect.forkChild/Fiber.join.

^{Macroscope summarized 5944bad.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 432dad8f-8a0a-455c-bdf2-9de83e4be5bd

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/audit-managed-relay-state-errors

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[macroscopeapp]

Approvability

Verdict: Approved

This PR refactors error classes in the managed relay module to be more structured and informative, adding contextual fields like accountId and environmentId. The changes improve error diagnostics without altering runtime control flow, and include proper URL redaction to avoid exposing secrets.

No code changes detected at 5944bad. Prior analysis still applies.

^{You can customize Macroscope's approvability policy. Learn more.}

Dismissing prior approval to re-evaluate 1d14eef

Dismissing prior approval to re-evaluate 713e11b

Dismissing prior approval to re-evaluate ad2be2d

[juliusmarminge]

Summary

• split managed relay session failures into distinct schema errors with account context
• preserve the original token-provider cause while avoiding invented causes for unavailable state
• attach expected and actual values to relay status validation failures
• migrate the touched stream test to the Effect test runtime

Verification

• vp test packages/client-runtime/src/relay/managedRelayState.test.ts
• vp check
• vp run typecheck

---

Note

Low Risk
Scoped to client-runtime relay error modeling and tests; behavior is clearer failures and safer diagnostics, not new relay or auth flows.

Overview
Replaces the single generic managed relay session and snapshot errors with Effect Schema tagged error unions so callers can branch on failure kind and get structured context (account IDs, expected vs actual environment IDs).

Session path: token read failures become ManagedRelayTokenReadError with the original provider cause; null tokens vs missing/wrong-account sessions are split into ManagedRelayTokenUnavailableError and ManagedRelaySessionUnavailableError (with requestedAccountId).

Status validation: environment, endpoint, and descriptor mismatches each get their own error type with expected/actual IDs. Endpoint mismatches are built via ManagedRelayStatusEndpointMismatchError.fromEndpoints, which uses getUrlDiagnostics so logs expose protocol, hostname, and URL length—not credentials, paths, query tokens, or fragments.

Tests assert the new types, redaction behavior, and clearer mismatch messages; one stream test moves to it.effect with fibers.

^{Reviewed by Cursor Bugbot for commit 5944bad. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Structure managed relay state errors into typed, secret-redacted error classes

• Replaces generic ManagedRelaySessionError and ManagedRelaySnapshotError with discriminated unions of specific Schema.TaggedErrorClass types, each carrying structured context (account IDs, environment IDs, URL diagnostics).
• Adds ManagedRelayTokenReadError, ManagedRelayTokenUnavailableError, and ManagedRelaySessionUnavailableError to distinguish token read failures, absent tokens, and missing/mismatched sessions.
• Adds ManagedRelayStatusEnvironmentMismatchError, ManagedRelayStatusEndpointMismatchError, and ManagedRelayStatusDescriptorEnvironmentMismatchError for snapshot validation; endpoint mismatches redact URL secrets, exposing only protocol, hostname, and input lengths.
• Updates tests in managedRelayState.test.ts to assert on the new error types and redaction behavior, and migrates one test to Effect-style using Effect.forkChild/Fiber.join.

^{Macroscope summarized 5944bad.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 432dad8f-8a0a-455c-bdf2-9de83e4be5bd

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/audit-managed-relay-state-errors

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[macroscopeapp]

Approvability

Verdict: Approved

This PR refactors error classes in the managed relay module to be more structured and informative, adding contextual fields like accountId and environmentId. The changes improve error diagnostics without altering runtime control flow, and include proper URL redaction to avoid exposing secrets.

No code changes detected at 5944bad. Prior analysis still applies.

^{You can customize Macroscope's approvability policy. Learn more.}

Dismissing prior approval to re-evaluate 1d14eef

Dismissing prior approval to re-evaluate 713e11b

Dismissing prior approval to re-evaluate ad2be2d

[juliusmarminge]

Summary

• split managed relay session failures into distinct schema errors with account context
• preserve the original token-provider cause while avoiding invented causes for unavailable state
• attach expected and actual values to relay status validation failures
• migrate the touched stream test to the Effect test runtime

Verification

• vp test packages/client-runtime/src/relay/managedRelayState.test.ts
• vp check
• vp run typecheck

---

Note

Low Risk
Scoped to client-runtime relay error modeling and tests; behavior is clearer failures and safer diagnostics, not new relay or auth flows.

Overview
Replaces the single generic managed relay session and snapshot errors with Effect Schema tagged error unions so callers can branch on failure kind and get structured context (account IDs, expected vs actual environment IDs).

Session path: token read failures become ManagedRelayTokenReadError with the original provider cause; null tokens vs missing/wrong-account sessions are split into ManagedRelayTokenUnavailableError and ManagedRelaySessionUnavailableError (with requestedAccountId).

Status validation: environment, endpoint, and descriptor mismatches each get their own error type with expected/actual IDs. Endpoint mismatches are built via ManagedRelayStatusEndpointMismatchError.fromEndpoints, which uses getUrlDiagnostics so logs expose protocol, hostname, and URL length—not credentials, paths, query tokens, or fragments.

Tests assert the new types, redaction behavior, and clearer mismatch messages; one stream test moves to it.effect with fibers.

^{Reviewed by Cursor Bugbot for commit 5944bad. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Structure managed relay state errors into typed, secret-redacted error classes

• Replaces generic ManagedRelaySessionError and ManagedRelaySnapshotError with discriminated unions of specific Schema.TaggedErrorClass types, each carrying structured context (account IDs, environment IDs, URL diagnostics).
• Adds ManagedRelayTokenReadError, ManagedRelayTokenUnavailableError, and ManagedRelaySessionUnavailableError to distinguish token read failures, absent tokens, and missing/mismatched sessions.
• Adds ManagedRelayStatusEnvironmentMismatchError, ManagedRelayStatusEndpointMismatchError, and ManagedRelayStatusDescriptorEnvironmentMismatchError for snapshot validation; endpoint mismatches redact URL secrets, exposing only protocol, hostname, and input lengths.
• Updates tests in managedRelayState.test.ts to assert on the new error types and redaction behavior, and migrates one test to Effect-style using Effect.forkChild/Fiber.join.

^{Macroscope summarized 5944bad.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 432dad8f-8a0a-455c-bdf2-9de83e4be5bd

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/audit-managed-relay-state-errors

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[macroscopeapp]

Approvability

Verdict: Approved

This PR refactors error classes in the managed relay module to be more structured and informative, adding contextual fields like accountId and environmentId. The changes improve error diagnostics without altering runtime control flow, and include proper URL redaction to avoid exposing secrets.

No code changes detected at 5944bad. Prior analysis still applies.

^{You can customize Macroscope's approvability policy. Learn more.}

Dismissing prior approval to re-evaluate 1d14eef

Dismissing prior approval to re-evaluate 713e11b

Dismissing prior approval to re-evaluate ad2be2d