[codex] Structure analytics batch delivery failures

[juliusmarminge]

Summary

• wrap telemetry request encoding, transport, and status failures in a structured batch-delivery error
• attach destination, endpoint, operation, and event count while retaining the exact HTTP client cause
• use tagged recovery to requeue failed batches and emit structured failure logs
• keep the best-effort public service contract unchanged

Tests

• extended the existing real HTTP-server test to return a 503, verify the batch is retried intact, and inspect the retained HttpClientError chain
• vp test apps/server/src/telemetry/AnalyticsService.test.ts
• vp check (passes with 20 pre-existing warnings)
• vp run typecheck

---

Note

Medium Risk
Changes telemetry delivery and logging on failure paths; the redaction work reduces leak risk but flush/retry behavior must stay correct so events are not silently dropped.

Overview
PostHog batch delivery failures in AnalyticsService are now wrapped in a tagged AnalyticsBatchDeliveryError instead of generic flush logging. sendBatch maps HTTP failures into that type; the flush loop catches it by tag, re-queues the failed batch, and emits logs with sanitized fields (input length, optional protocol/hostname, event count, nested cause)—not the raw configured endpoint URL.

Shared getUrlDiagnostics (exported as @t3tools/shared/urlDiagnostics) powers fromEndpoint so credentials, paths, query, and fragments never appear on the error object or log annotations. redactDpopRequestTarget is added alongside for safe DPoP URL display (scheme/host/port/path only).

Tests now simulate a 503, assert identical retry payloads, inspect structured logs and the retained HttpClientError chain, and verify secrets stay out of error messages.

^{Reviewed by Cursor Bugbot for commit 3d9edf0. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Structure analytics batch delivery failures into a typed, redacted error class

• Adds AnalyticsBatchDeliveryError, a Schema.TaggedError in AnalyticsService.ts that stores safe diagnostics (endpoint input length, protocol, hostname) instead of the raw PostHog endpoint URL.
• sendBatch now maps transport failures into AnalyticsBatchDeliveryError via a fromEndpoint factory that strips credentials, query params, and hash fragments before constructing the error.
• flush uses catchTags to requeue only AnalyticsBatchDeliveryError batches and log a redacted message with structured annotations; other error types propagate uncaught.
• Risk: errors not tagged as AnalyticsBatchDeliveryError are no longer swallowed by flush and will now propagate to callers.

^{Macroscope summarized 3d9edf0.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 4ac9d8df-efbc-4e59-b930-04428b36e83c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/structure-analytics-delivery-errors

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[macroscopeapp]

Effect service review: one convention issue on the new AnalyticsBatchDeliveryError. See inline comment.

^{Posted via Macroscope — Effect Service Conventions}

[macroscopeapp]

Approvability

Verdict: Approved

This PR improves analytics error logging by introducing structured errors that safely redact endpoint secrets. The core analytics delivery behavior is unchanged; only the error structure and logging are enhanced. Comprehensive tests verify the secret redaction and retry behavior.

^{You can customize Macroscope's approvability policy. Learn more.}

Dismissing prior approval to re-evaluate 4a87a98

Dismissing prior approval to re-evaluate 3d9edf0

[juliusmarminge]

Summary

• wrap telemetry request encoding, transport, and status failures in a structured batch-delivery error
• attach destination, endpoint, operation, and event count while retaining the exact HTTP client cause
• use tagged recovery to requeue failed batches and emit structured failure logs
• keep the best-effort public service contract unchanged

Tests

• extended the existing real HTTP-server test to return a 503, verify the batch is retried intact, and inspect the retained HttpClientError chain
• vp test apps/server/src/telemetry/AnalyticsService.test.ts
• vp check (passes with 20 pre-existing warnings)
• vp run typecheck

---

Note

Medium Risk
Changes telemetry delivery and logging on failure paths; the redaction work reduces leak risk but flush/retry behavior must stay correct so events are not silently dropped.

Overview
PostHog batch delivery failures in AnalyticsService are now wrapped in a tagged AnalyticsBatchDeliveryError instead of generic flush logging. sendBatch maps HTTP failures into that type; the flush loop catches it by tag, re-queues the failed batch, and emits logs with sanitized fields (input length, optional protocol/hostname, event count, nested cause)—not the raw configured endpoint URL.

Shared getUrlDiagnostics (exported as @t3tools/shared/urlDiagnostics) powers fromEndpoint so credentials, paths, query, and fragments never appear on the error object or log annotations. redactDpopRequestTarget is added alongside for safe DPoP URL display (scheme/host/port/path only).

Tests now simulate a 503, assert identical retry payloads, inspect structured logs and the retained HttpClientError chain, and verify secrets stay out of error messages.

^{Reviewed by Cursor Bugbot for commit 3d9edf0. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Structure analytics batch delivery failures into a typed, redacted error class

• Adds AnalyticsBatchDeliveryError, a Schema.TaggedError in AnalyticsService.ts that stores safe diagnostics (endpoint input length, protocol, hostname) instead of the raw PostHog endpoint URL.
• sendBatch now maps transport failures into AnalyticsBatchDeliveryError via a fromEndpoint factory that strips credentials, query params, and hash fragments before constructing the error.
• flush uses catchTags to requeue only AnalyticsBatchDeliveryError batches and log a redacted message with structured annotations; other error types propagate uncaught.
• Risk: errors not tagged as AnalyticsBatchDeliveryError are no longer swallowed by flush and will now propagate to callers.

^{Macroscope summarized 3d9edf0.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 4ac9d8df-efbc-4e59-b930-04428b36e83c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/structure-analytics-delivery-errors

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[macroscopeapp]

Effect service review: one convention issue on the new AnalyticsBatchDeliveryError. See inline comment.

^{Posted via Macroscope — Effect Service Conventions}

[macroscopeapp]

Approvability

Verdict: Approved

This PR improves analytics error logging by introducing structured errors that safely redact endpoint secrets. The core analytics delivery behavior is unchanged; only the error structure and logging are enhanced. Comprehensive tests verify the secret redaction and retry behavior.

^{You can customize Macroscope's approvability policy. Learn more.}

Dismissing prior approval to re-evaluate 4a87a98

Dismissing prior approval to re-evaluate 3d9edf0

[juliusmarminge]

Summary

• wrap telemetry request encoding, transport, and status failures in a structured batch-delivery error
• attach destination, endpoint, operation, and event count while retaining the exact HTTP client cause
• use tagged recovery to requeue failed batches and emit structured failure logs
• keep the best-effort public service contract unchanged

Tests

• extended the existing real HTTP-server test to return a 503, verify the batch is retried intact, and inspect the retained HttpClientError chain
• vp test apps/server/src/telemetry/AnalyticsService.test.ts
• vp check (passes with 20 pre-existing warnings)
• vp run typecheck

---

Note

Medium Risk
Changes telemetry delivery and logging on failure paths; the redaction work reduces leak risk but flush/retry behavior must stay correct so events are not silently dropped.

Overview
PostHog batch delivery failures in AnalyticsService are now wrapped in a tagged AnalyticsBatchDeliveryError instead of generic flush logging. sendBatch maps HTTP failures into that type; the flush loop catches it by tag, re-queues the failed batch, and emits logs with sanitized fields (input length, optional protocol/hostname, event count, nested cause)—not the raw configured endpoint URL.

Shared getUrlDiagnostics (exported as @t3tools/shared/urlDiagnostics) powers fromEndpoint so credentials, paths, query, and fragments never appear on the error object or log annotations. redactDpopRequestTarget is added alongside for safe DPoP URL display (scheme/host/port/path only).

Tests now simulate a 503, assert identical retry payloads, inspect structured logs and the retained HttpClientError chain, and verify secrets stay out of error messages.

^{Reviewed by Cursor Bugbot for commit 3d9edf0. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Structure analytics batch delivery failures into a typed, redacted error class

• Adds AnalyticsBatchDeliveryError, a Schema.TaggedError in AnalyticsService.ts that stores safe diagnostics (endpoint input length, protocol, hostname) instead of the raw PostHog endpoint URL.
• sendBatch now maps transport failures into AnalyticsBatchDeliveryError via a fromEndpoint factory that strips credentials, query params, and hash fragments before constructing the error.
• flush uses catchTags to requeue only AnalyticsBatchDeliveryError batches and log a redacted message with structured annotations; other error types propagate uncaught.
• Risk: errors not tagged as AnalyticsBatchDeliveryError are no longer swallowed by flush and will now propagate to callers.

^{Macroscope summarized 3d9edf0.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 4ac9d8df-efbc-4e59-b930-04428b36e83c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/structure-analytics-delivery-errors

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[macroscopeapp]

Effect service review: one convention issue on the new AnalyticsBatchDeliveryError. See inline comment.

^{Posted via Macroscope — Effect Service Conventions}

[macroscopeapp]

Approvability

Verdict: Approved

This PR improves analytics error logging by introducing structured errors that safely redact endpoint secrets. The core analytics delivery behavior is unchanged; only the error structure and logging are enhanced. Comprehensive tests verify the secret redaction and retry behavior.

^{You can customize Macroscope's approvability policy. Learn more.}

Dismissing prior approval to re-evaluate 4a87a98

Dismissing prior approval to re-evaluate 3d9edf0

[juliusmarminge]

Summary

• wrap telemetry request encoding, transport, and status failures in a structured batch-delivery error
• attach destination, endpoint, operation, and event count while retaining the exact HTTP client cause
• use tagged recovery to requeue failed batches and emit structured failure logs
• keep the best-effort public service contract unchanged

Tests

• extended the existing real HTTP-server test to return a 503, verify the batch is retried intact, and inspect the retained HttpClientError chain
• vp test apps/server/src/telemetry/AnalyticsService.test.ts
• vp check (passes with 20 pre-existing warnings)
• vp run typecheck

---

Note

Medium Risk
Changes telemetry delivery and logging on failure paths; the redaction work reduces leak risk but flush/retry behavior must stay correct so events are not silently dropped.

Overview
PostHog batch delivery failures in AnalyticsService are now wrapped in a tagged AnalyticsBatchDeliveryError instead of generic flush logging. sendBatch maps HTTP failures into that type; the flush loop catches it by tag, re-queues the failed batch, and emits logs with sanitized fields (input length, optional protocol/hostname, event count, nested cause)—not the raw configured endpoint URL.

Shared getUrlDiagnostics (exported as @t3tools/shared/urlDiagnostics) powers fromEndpoint so credentials, paths, query, and fragments never appear on the error object or log annotations. redactDpopRequestTarget is added alongside for safe DPoP URL display (scheme/host/port/path only).

Tests now simulate a 503, assert identical retry payloads, inspect structured logs and the retained HttpClientError chain, and verify secrets stay out of error messages.

^{Reviewed by Cursor Bugbot for commit 3d9edf0. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Structure analytics batch delivery failures into a typed, redacted error class

• Adds AnalyticsBatchDeliveryError, a Schema.TaggedError in AnalyticsService.ts that stores safe diagnostics (endpoint input length, protocol, hostname) instead of the raw PostHog endpoint URL.
• sendBatch now maps transport failures into AnalyticsBatchDeliveryError via a fromEndpoint factory that strips credentials, query params, and hash fragments before constructing the error.
• flush uses catchTags to requeue only AnalyticsBatchDeliveryError batches and log a redacted message with structured annotations; other error types propagate uncaught.
• Risk: errors not tagged as AnalyticsBatchDeliveryError are no longer swallowed by flush and will now propagate to callers.

^{Macroscope summarized 3d9edf0.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 4ac9d8df-efbc-4e59-b930-04428b36e83c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/structure-analytics-delivery-errors

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[macroscopeapp]

Effect service review: one convention issue on the new AnalyticsBatchDeliveryError. See inline comment.

^{Posted via Macroscope — Effect Service Conventions}

[macroscopeapp]

Approvability

Verdict: Approved

This PR improves analytics error logging by introducing structured errors that safely redact endpoint secrets. The core analytics delivery behavior is unchanged; only the error structure and logging are enhanced. Comprehensive tests verify the secret redaction and retry behavior.

^{You can customize Macroscope's approvability policy. Learn more.}

Dismissing prior approval to re-evaluate 4a87a98

Dismissing prior approval to re-evaluate 3d9edf0

[juliusmarminge]

Summary

• wrap telemetry request encoding, transport, and status failures in a structured batch-delivery error
• attach destination, endpoint, operation, and event count while retaining the exact HTTP client cause
• use tagged recovery to requeue failed batches and emit structured failure logs
• keep the best-effort public service contract unchanged

Tests

• extended the existing real HTTP-server test to return a 503, verify the batch is retried intact, and inspect the retained HttpClientError chain
• vp test apps/server/src/telemetry/AnalyticsService.test.ts
• vp check (passes with 20 pre-existing warnings)
• vp run typecheck

---

Note

Medium Risk
Changes telemetry delivery and logging on failure paths; the redaction work reduces leak risk but flush/retry behavior must stay correct so events are not silently dropped.

Overview
PostHog batch delivery failures in AnalyticsService are now wrapped in a tagged AnalyticsBatchDeliveryError instead of generic flush logging. sendBatch maps HTTP failures into that type; the flush loop catches it by tag, re-queues the failed batch, and emits logs with sanitized fields (input length, optional protocol/hostname, event count, nested cause)—not the raw configured endpoint URL.

Shared getUrlDiagnostics (exported as @t3tools/shared/urlDiagnostics) powers fromEndpoint so credentials, paths, query, and fragments never appear on the error object or log annotations. redactDpopRequestTarget is added alongside for safe DPoP URL display (scheme/host/port/path only).

Tests now simulate a 503, assert identical retry payloads, inspect structured logs and the retained HttpClientError chain, and verify secrets stay out of error messages.

^{Reviewed by Cursor Bugbot for commit 3d9edf0. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Structure analytics batch delivery failures into a typed, redacted error class

• Adds AnalyticsBatchDeliveryError, a Schema.TaggedError in AnalyticsService.ts that stores safe diagnostics (endpoint input length, protocol, hostname) instead of the raw PostHog endpoint URL.
• sendBatch now maps transport failures into AnalyticsBatchDeliveryError via a fromEndpoint factory that strips credentials, query params, and hash fragments before constructing the error.
• flush uses catchTags to requeue only AnalyticsBatchDeliveryError batches and log a redacted message with structured annotations; other error types propagate uncaught.
• Risk: errors not tagged as AnalyticsBatchDeliveryError are no longer swallowed by flush and will now propagate to callers.

^{Macroscope summarized 3d9edf0.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 4ac9d8df-efbc-4e59-b930-04428b36e83c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/structure-analytics-delivery-errors

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[macroscopeapp]

Effect service review: one convention issue on the new AnalyticsBatchDeliveryError. See inline comment.

^{Posted via Macroscope — Effect Service Conventions}

[macroscopeapp]

Approvability

Verdict: Approved

This PR improves analytics error logging by introducing structured errors that safely redact endpoint secrets. The core analytics delivery behavior is unchanged; only the error structure and logging are enhanced. Comprehensive tests verify the secret redaction and retry behavior.

^{You can customize Macroscope's approvability policy. Learn more.}

Dismissing prior approval to re-evaluate 4a87a98

Dismissing prior approval to re-evaluate 3d9edf0

[juliusmarminge]

Summary

• wrap telemetry request encoding, transport, and status failures in a structured batch-delivery error
• attach destination, endpoint, operation, and event count while retaining the exact HTTP client cause
• use tagged recovery to requeue failed batches and emit structured failure logs
• keep the best-effort public service contract unchanged

Tests

• extended the existing real HTTP-server test to return a 503, verify the batch is retried intact, and inspect the retained HttpClientError chain
• vp test apps/server/src/telemetry/AnalyticsService.test.ts
• vp check (passes with 20 pre-existing warnings)
• vp run typecheck

---

Note

Medium Risk
Changes telemetry delivery and logging on failure paths; the redaction work reduces leak risk but flush/retry behavior must stay correct so events are not silently dropped.

Overview
PostHog batch delivery failures in AnalyticsService are now wrapped in a tagged AnalyticsBatchDeliveryError instead of generic flush logging. sendBatch maps HTTP failures into that type; the flush loop catches it by tag, re-queues the failed batch, and emits logs with sanitized fields (input length, optional protocol/hostname, event count, nested cause)—not the raw configured endpoint URL.

Shared getUrlDiagnostics (exported as @t3tools/shared/urlDiagnostics) powers fromEndpoint so credentials, paths, query, and fragments never appear on the error object or log annotations. redactDpopRequestTarget is added alongside for safe DPoP URL display (scheme/host/port/path only).

Tests now simulate a 503, assert identical retry payloads, inspect structured logs and the retained HttpClientError chain, and verify secrets stay out of error messages.

^{Reviewed by Cursor Bugbot for commit 3d9edf0. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Structure analytics batch delivery failures into a typed, redacted error class

• Adds AnalyticsBatchDeliveryError, a Schema.TaggedError in AnalyticsService.ts that stores safe diagnostics (endpoint input length, protocol, hostname) instead of the raw PostHog endpoint URL.
• sendBatch now maps transport failures into AnalyticsBatchDeliveryError via a fromEndpoint factory that strips credentials, query params, and hash fragments before constructing the error.
• flush uses catchTags to requeue only AnalyticsBatchDeliveryError batches and log a redacted message with structured annotations; other error types propagate uncaught.
• Risk: errors not tagged as AnalyticsBatchDeliveryError are no longer swallowed by flush and will now propagate to callers.

^{Macroscope summarized 3d9edf0.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 4ac9d8df-efbc-4e59-b930-04428b36e83c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/structure-analytics-delivery-errors

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[macroscopeapp]

Effect service review: one convention issue on the new AnalyticsBatchDeliveryError. See inline comment.

^{Posted via Macroscope — Effect Service Conventions}

[macroscopeapp]

Approvability

Verdict: Approved

This PR improves analytics error logging by introducing structured errors that safely redact endpoint secrets. The core analytics delivery behavior is unchanged; only the error structure and logging are enhanced. Comprehensive tests verify the secret redaction and retry behavior.

^{You can customize Macroscope's approvability policy. Learn more.}

Dismissing prior approval to re-evaluate 4a87a98

Dismissing prior approval to re-evaluate 3d9edf0

[juliusmarminge]

Summary

• wrap telemetry request encoding, transport, and status failures in a structured batch-delivery error
• attach destination, endpoint, operation, and event count while retaining the exact HTTP client cause
• use tagged recovery to requeue failed batches and emit structured failure logs
• keep the best-effort public service contract unchanged

Tests

• extended the existing real HTTP-server test to return a 503, verify the batch is retried intact, and inspect the retained HttpClientError chain
• vp test apps/server/src/telemetry/AnalyticsService.test.ts
• vp check (passes with 20 pre-existing warnings)
• vp run typecheck

---

Note

Medium Risk
Changes telemetry delivery and logging on failure paths; the redaction work reduces leak risk but flush/retry behavior must stay correct so events are not silently dropped.

Overview
PostHog batch delivery failures in AnalyticsService are now wrapped in a tagged AnalyticsBatchDeliveryError instead of generic flush logging. sendBatch maps HTTP failures into that type; the flush loop catches it by tag, re-queues the failed batch, and emits logs with sanitized fields (input length, optional protocol/hostname, event count, nested cause)—not the raw configured endpoint URL.

Shared getUrlDiagnostics (exported as @t3tools/shared/urlDiagnostics) powers fromEndpoint so credentials, paths, query, and fragments never appear on the error object or log annotations. redactDpopRequestTarget is added alongside for safe DPoP URL display (scheme/host/port/path only).

Tests now simulate a 503, assert identical retry payloads, inspect structured logs and the retained HttpClientError chain, and verify secrets stay out of error messages.

^{Reviewed by Cursor Bugbot for commit 3d9edf0. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Structure analytics batch delivery failures into a typed, redacted error class

• Adds AnalyticsBatchDeliveryError, a Schema.TaggedError in AnalyticsService.ts that stores safe diagnostics (endpoint input length, protocol, hostname) instead of the raw PostHog endpoint URL.
• sendBatch now maps transport failures into AnalyticsBatchDeliveryError via a fromEndpoint factory that strips credentials, query params, and hash fragments before constructing the error.
• flush uses catchTags to requeue only AnalyticsBatchDeliveryError batches and log a redacted message with structured annotations; other error types propagate uncaught.
• Risk: errors not tagged as AnalyticsBatchDeliveryError are no longer swallowed by flush and will now propagate to callers.

^{Macroscope summarized 3d9edf0.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 4ac9d8df-efbc-4e59-b930-04428b36e83c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/structure-analytics-delivery-errors

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[macroscopeapp]

Effect service review: one convention issue on the new AnalyticsBatchDeliveryError. See inline comment.

^{Posted via Macroscope — Effect Service Conventions}

[macroscopeapp]

Approvability

Verdict: Approved

This PR improves analytics error logging by introducing structured errors that safely redact endpoint secrets. The core analytics delivery behavior is unchanged; only the error structure and logging are enhanced. Comprehensive tests verify the secret redaction and retry behavior.

^{You can customize Macroscope's approvability policy. Learn more.}

Dismissing prior approval to re-evaluate 4a87a98

Dismissing prior approval to re-evaluate 3d9edf0

[juliusmarminge]

Summary

• wrap telemetry request encoding, transport, and status failures in a structured batch-delivery error
• attach destination, endpoint, operation, and event count while retaining the exact HTTP client cause
• use tagged recovery to requeue failed batches and emit structured failure logs
• keep the best-effort public service contract unchanged

Tests

• extended the existing real HTTP-server test to return a 503, verify the batch is retried intact, and inspect the retained HttpClientError chain
• vp test apps/server/src/telemetry/AnalyticsService.test.ts
• vp check (passes with 20 pre-existing warnings)
• vp run typecheck

---

Note

Medium Risk
Changes telemetry delivery and logging on failure paths; the redaction work reduces leak risk but flush/retry behavior must stay correct so events are not silently dropped.

Overview
PostHog batch delivery failures in AnalyticsService are now wrapped in a tagged AnalyticsBatchDeliveryError instead of generic flush logging. sendBatch maps HTTP failures into that type; the flush loop catches it by tag, re-queues the failed batch, and emits logs with sanitized fields (input length, optional protocol/hostname, event count, nested cause)—not the raw configured endpoint URL.

Shared getUrlDiagnostics (exported as @t3tools/shared/urlDiagnostics) powers fromEndpoint so credentials, paths, query, and fragments never appear on the error object or log annotations. redactDpopRequestTarget is added alongside for safe DPoP URL display (scheme/host/port/path only).

Tests now simulate a 503, assert identical retry payloads, inspect structured logs and the retained HttpClientError chain, and verify secrets stay out of error messages.

^{Reviewed by Cursor Bugbot for commit 3d9edf0. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Structure analytics batch delivery failures into a typed, redacted error class

• Adds AnalyticsBatchDeliveryError, a Schema.TaggedError in AnalyticsService.ts that stores safe diagnostics (endpoint input length, protocol, hostname) instead of the raw PostHog endpoint URL.
• sendBatch now maps transport failures into AnalyticsBatchDeliveryError via a fromEndpoint factory that strips credentials, query params, and hash fragments before constructing the error.
• flush uses catchTags to requeue only AnalyticsBatchDeliveryError batches and log a redacted message with structured annotations; other error types propagate uncaught.
• Risk: errors not tagged as AnalyticsBatchDeliveryError are no longer swallowed by flush and will now propagate to callers.

^{Macroscope summarized 3d9edf0.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 4ac9d8df-efbc-4e59-b930-04428b36e83c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/structure-analytics-delivery-errors

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[macroscopeapp]

Effect service review: one convention issue on the new AnalyticsBatchDeliveryError. See inline comment.

^{Posted via Macroscope — Effect Service Conventions}

[macroscopeapp]

Approvability

Verdict: Approved

This PR improves analytics error logging by introducing structured errors that safely redact endpoint secrets. The core analytics delivery behavior is unchanged; only the error structure and logging are enhanced. Comprehensive tests verify the secret redaction and retry behavior.

^{You can customize Macroscope's approvability policy. Learn more.}

Dismissing prior approval to re-evaluate 4a87a98

Dismissing prior approval to re-evaluate 3d9edf0