[codex] Structure mobile cloud-link failures

[juliusmarminge]

Summary

• replace the generic mobile cloud-link error bucket and constructor factories with structured Schema errors
• promote decoded relay errors, environment API failures, and trace IDs through a value-adding static mapper while retaining each exact cause chain
• represent environment ID, endpoint, and provider mismatches with typed expected/actual attributes
• type synchronous URL/client initialization failures instead of letting them escape as defects
• remove cause-derived development messages and the adjacent relay-error switch

Validation

• vp test run apps/mobile/src/features/cloud/linkEnvironment.test.ts (21 tests)
• vp run lint:mobile
• vp check (passes with 20 pre-existing warnings)
• vp run typecheck

Overlap

• broad feature PR feat(relay): enforce resource limits #2925 touches these files, but it is unrelated to this audit and does not implement this error model

---

Note

Medium Risk
Error _tag values and user-visible messages change across link/list/connect/status flows; UI or logging that matched old URL-embedded strings or a single CloudEnvironmentLinkError tag needs updating.

Overview
Replaces the single CloudEnvironmentLinkError bucket in mobile cloud linking with a Schema.Union of tagged errors and removes URL-heavy, dev-only, and relay-string message builders.

CloudEnvironmentLinkOperationError now records an action, optional environmentId, redacted URL diagnostics via getUrlDiagnostics (length/protocol/hostname only), nested relayError / environmentError, and traceId, with stable user-facing messages like Could not {action} for environment "{id}". Mismatch cases use dedicated types (CloudEnvironmentIdMismatchError, CloudEnvironmentEndpointMismatchError, CloudEnvironmentEndpointProviderMismatchError, CloudEnvironmentLocalBearerRequiredError, CloudRelayUrlNotConfiguredError) with expected/actual fields instead of generic strings.

Synchronous throws for URL parsing and HTTP client setup are routed through Effect.try into operation errors. Per-environment statusError strings now come from these typed message getters. Tests assert secret redaction in serialization and updated _tag / field shapes; isCloudEnvironmentLinkError narrows the union.

^{Reviewed by Cursor Bugbot for commit d0671a3. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Replace generic cloud link errors with structured, action-specific error types in mobile

• Introduces several new tagged error classes in linkEnvironment.ts: CloudEnvironmentLinkOperationError, CloudRelayUrlNotConfiguredError, CloudEnvironmentLocalBearerRequiredError, CloudEnvironmentIdMismatchError, CloudEnvironmentEndpointMismatchError, and CloudEnvironmentEndpointProviderMismatchError.
• All error types carry structured diagnostics (action label, redacted URL fields like protocol/hostname/input-length, traceId, relay/environment error bodies) instead of raw error strings.
• Exports a CloudEnvironmentLinkError union type and isCloudEnvironmentLinkError guard so callers can reliably discriminate all link-related failures.
• Behavioral Change: Every failure path in linkEnvironmentToCloud, connectRelayManagedEnvironment, listCloudEnvironments, and getCloudEnvironmentStatus now emits a different _tag and message format than before; callers matching on previous error shapes will need updating.

^{Macroscope summarized d0671a3.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: c198374f-00a5-4982-b0a7-6e8cff91c2e1

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/mobile-cloud-link-errors

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[macroscopeapp]

Approvability

Verdict: Approved

This PR refactors error handling to use structured error types and redacts URL secrets from error diagnostics - a security improvement. The core cloud-linking business logic is unchanged; only error construction and formatting changes.

^{You can customize Macroscope's approvability policy. Learn more.}

Dismissing prior approval to re-evaluate fb67183

Dismissing prior approval to re-evaluate 21bfa07

Dismissing prior approval to re-evaluate 9a2733c

Dismissing prior approval to re-evaluate e9c868a

Dismissing prior approval to re-evaluate 6c8a6b1

[juliusmarminge]

Summary

• replace the generic mobile cloud-link error bucket and constructor factories with structured Schema errors
• promote decoded relay errors, environment API failures, and trace IDs through a value-adding static mapper while retaining each exact cause chain
• represent environment ID, endpoint, and provider mismatches with typed expected/actual attributes
• type synchronous URL/client initialization failures instead of letting them escape as defects
• remove cause-derived development messages and the adjacent relay-error switch

Validation

• vp test run apps/mobile/src/features/cloud/linkEnvironment.test.ts (21 tests)
• vp run lint:mobile
• vp check (passes with 20 pre-existing warnings)
• vp run typecheck

Overlap

• broad feature PR feat(relay): enforce resource limits #2925 touches these files, but it is unrelated to this audit and does not implement this error model

---

Note

Medium Risk
Error _tag values and user-visible messages change across link/list/connect/status flows; UI or logging that matched old URL-embedded strings or a single CloudEnvironmentLinkError tag needs updating.

Overview
Replaces the single CloudEnvironmentLinkError bucket in mobile cloud linking with a Schema.Union of tagged errors and removes URL-heavy, dev-only, and relay-string message builders.

CloudEnvironmentLinkOperationError now records an action, optional environmentId, redacted URL diagnostics via getUrlDiagnostics (length/protocol/hostname only), nested relayError / environmentError, and traceId, with stable user-facing messages like Could not {action} for environment "{id}". Mismatch cases use dedicated types (CloudEnvironmentIdMismatchError, CloudEnvironmentEndpointMismatchError, CloudEnvironmentEndpointProviderMismatchError, CloudEnvironmentLocalBearerRequiredError, CloudRelayUrlNotConfiguredError) with expected/actual fields instead of generic strings.

Synchronous throws for URL parsing and HTTP client setup are routed through Effect.try into operation errors. Per-environment statusError strings now come from these typed message getters. Tests assert secret redaction in serialization and updated _tag / field shapes; isCloudEnvironmentLinkError narrows the union.

^{Reviewed by Cursor Bugbot for commit d0671a3. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Replace generic cloud link errors with structured, action-specific error types in mobile

• Introduces several new tagged error classes in linkEnvironment.ts: CloudEnvironmentLinkOperationError, CloudRelayUrlNotConfiguredError, CloudEnvironmentLocalBearerRequiredError, CloudEnvironmentIdMismatchError, CloudEnvironmentEndpointMismatchError, and CloudEnvironmentEndpointProviderMismatchError.
• All error types carry structured diagnostics (action label, redacted URL fields like protocol/hostname/input-length, traceId, relay/environment error bodies) instead of raw error strings.
• Exports a CloudEnvironmentLinkError union type and isCloudEnvironmentLinkError guard so callers can reliably discriminate all link-related failures.
• Behavioral Change: Every failure path in linkEnvironmentToCloud, connectRelayManagedEnvironment, listCloudEnvironments, and getCloudEnvironmentStatus now emits a different _tag and message format than before; callers matching on previous error shapes will need updating.

^{Macroscope summarized d0671a3.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: c198374f-00a5-4982-b0a7-6e8cff91c2e1

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/mobile-cloud-link-errors

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[macroscopeapp]

Approvability

Verdict: Approved

This PR refactors error handling to use structured error types and redacts URL secrets from error diagnostics - a security improvement. The core cloud-linking business logic is unchanged; only error construction and formatting changes.

^{You can customize Macroscope's approvability policy. Learn more.}

Dismissing prior approval to re-evaluate fb67183

Dismissing prior approval to re-evaluate 21bfa07

Dismissing prior approval to re-evaluate 9a2733c

Dismissing prior approval to re-evaluate e9c868a

Dismissing prior approval to re-evaluate 6c8a6b1

[juliusmarminge]

Summary

• replace the generic mobile cloud-link error bucket and constructor factories with structured Schema errors
• promote decoded relay errors, environment API failures, and trace IDs through a value-adding static mapper while retaining each exact cause chain
• represent environment ID, endpoint, and provider mismatches with typed expected/actual attributes
• type synchronous URL/client initialization failures instead of letting them escape as defects
• remove cause-derived development messages and the adjacent relay-error switch

Validation

• vp test run apps/mobile/src/features/cloud/linkEnvironment.test.ts (21 tests)
• vp run lint:mobile
• vp check (passes with 20 pre-existing warnings)
• vp run typecheck

Overlap

• broad feature PR feat(relay): enforce resource limits #2925 touches these files, but it is unrelated to this audit and does not implement this error model

---

Note

Medium Risk
Error _tag values and user-visible messages change across link/list/connect/status flows; UI or logging that matched old URL-embedded strings or a single CloudEnvironmentLinkError tag needs updating.

Overview
Replaces the single CloudEnvironmentLinkError bucket in mobile cloud linking with a Schema.Union of tagged errors and removes URL-heavy, dev-only, and relay-string message builders.

CloudEnvironmentLinkOperationError now records an action, optional environmentId, redacted URL diagnostics via getUrlDiagnostics (length/protocol/hostname only), nested relayError / environmentError, and traceId, with stable user-facing messages like Could not {action} for environment "{id}". Mismatch cases use dedicated types (CloudEnvironmentIdMismatchError, CloudEnvironmentEndpointMismatchError, CloudEnvironmentEndpointProviderMismatchError, CloudEnvironmentLocalBearerRequiredError, CloudRelayUrlNotConfiguredError) with expected/actual fields instead of generic strings.

Synchronous throws for URL parsing and HTTP client setup are routed through Effect.try into operation errors. Per-environment statusError strings now come from these typed message getters. Tests assert secret redaction in serialization and updated _tag / field shapes; isCloudEnvironmentLinkError narrows the union.

^{Reviewed by Cursor Bugbot for commit d0671a3. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Replace generic cloud link errors with structured, action-specific error types in mobile

• Introduces several new tagged error classes in linkEnvironment.ts: CloudEnvironmentLinkOperationError, CloudRelayUrlNotConfiguredError, CloudEnvironmentLocalBearerRequiredError, CloudEnvironmentIdMismatchError, CloudEnvironmentEndpointMismatchError, and CloudEnvironmentEndpointProviderMismatchError.
• All error types carry structured diagnostics (action label, redacted URL fields like protocol/hostname/input-length, traceId, relay/environment error bodies) instead of raw error strings.
• Exports a CloudEnvironmentLinkError union type and isCloudEnvironmentLinkError guard so callers can reliably discriminate all link-related failures.
• Behavioral Change: Every failure path in linkEnvironmentToCloud, connectRelayManagedEnvironment, listCloudEnvironments, and getCloudEnvironmentStatus now emits a different _tag and message format than before; callers matching on previous error shapes will need updating.

^{Macroscope summarized d0671a3.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: c198374f-00a5-4982-b0a7-6e8cff91c2e1

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/mobile-cloud-link-errors

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[macroscopeapp]

Approvability

Verdict: Approved

This PR refactors error handling to use structured error types and redacts URL secrets from error diagnostics - a security improvement. The core cloud-linking business logic is unchanged; only error construction and formatting changes.

^{You can customize Macroscope's approvability policy. Learn more.}

Dismissing prior approval to re-evaluate fb67183

Dismissing prior approval to re-evaluate 21bfa07

Dismissing prior approval to re-evaluate 9a2733c

Dismissing prior approval to re-evaluate e9c868a

Dismissing prior approval to re-evaluate 6c8a6b1

[juliusmarminge]

Summary

• replace the generic mobile cloud-link error bucket and constructor factories with structured Schema errors
• promote decoded relay errors, environment API failures, and trace IDs through a value-adding static mapper while retaining each exact cause chain
• represent environment ID, endpoint, and provider mismatches with typed expected/actual attributes
• type synchronous URL/client initialization failures instead of letting them escape as defects
• remove cause-derived development messages and the adjacent relay-error switch

Validation

• vp test run apps/mobile/src/features/cloud/linkEnvironment.test.ts (21 tests)
• vp run lint:mobile
• vp check (passes with 20 pre-existing warnings)
• vp run typecheck

Overlap

• broad feature PR feat(relay): enforce resource limits #2925 touches these files, but it is unrelated to this audit and does not implement this error model

---

Note

Medium Risk
Error _tag values and user-visible messages change across link/list/connect/status flows; UI or logging that matched old URL-embedded strings or a single CloudEnvironmentLinkError tag needs updating.

Overview
Replaces the single CloudEnvironmentLinkError bucket in mobile cloud linking with a Schema.Union of tagged errors and removes URL-heavy, dev-only, and relay-string message builders.

CloudEnvironmentLinkOperationError now records an action, optional environmentId, redacted URL diagnostics via getUrlDiagnostics (length/protocol/hostname only), nested relayError / environmentError, and traceId, with stable user-facing messages like Could not {action} for environment "{id}". Mismatch cases use dedicated types (CloudEnvironmentIdMismatchError, CloudEnvironmentEndpointMismatchError, CloudEnvironmentEndpointProviderMismatchError, CloudEnvironmentLocalBearerRequiredError, CloudRelayUrlNotConfiguredError) with expected/actual fields instead of generic strings.

Synchronous throws for URL parsing and HTTP client setup are routed through Effect.try into operation errors. Per-environment statusError strings now come from these typed message getters. Tests assert secret redaction in serialization and updated _tag / field shapes; isCloudEnvironmentLinkError narrows the union.

^{Reviewed by Cursor Bugbot for commit d0671a3. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Replace generic cloud link errors with structured, action-specific error types in mobile

• Introduces several new tagged error classes in linkEnvironment.ts: CloudEnvironmentLinkOperationError, CloudRelayUrlNotConfiguredError, CloudEnvironmentLocalBearerRequiredError, CloudEnvironmentIdMismatchError, CloudEnvironmentEndpointMismatchError, and CloudEnvironmentEndpointProviderMismatchError.
• All error types carry structured diagnostics (action label, redacted URL fields like protocol/hostname/input-length, traceId, relay/environment error bodies) instead of raw error strings.
• Exports a CloudEnvironmentLinkError union type and isCloudEnvironmentLinkError guard so callers can reliably discriminate all link-related failures.
• Behavioral Change: Every failure path in linkEnvironmentToCloud, connectRelayManagedEnvironment, listCloudEnvironments, and getCloudEnvironmentStatus now emits a different _tag and message format than before; callers matching on previous error shapes will need updating.

^{Macroscope summarized d0671a3.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: c198374f-00a5-4982-b0a7-6e8cff91c2e1

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/mobile-cloud-link-errors

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[macroscopeapp]

Approvability

Verdict: Approved

This PR refactors error handling to use structured error types and redacts URL secrets from error diagnostics - a security improvement. The core cloud-linking business logic is unchanged; only error construction and formatting changes.

^{You can customize Macroscope's approvability policy. Learn more.}

Dismissing prior approval to re-evaluate fb67183

Dismissing prior approval to re-evaluate 21bfa07

Dismissing prior approval to re-evaluate 9a2733c

Dismissing prior approval to re-evaluate e9c868a

Dismissing prior approval to re-evaluate 6c8a6b1

[juliusmarminge]

Summary

• replace the generic mobile cloud-link error bucket and constructor factories with structured Schema errors
• promote decoded relay errors, environment API failures, and trace IDs through a value-adding static mapper while retaining each exact cause chain
• represent environment ID, endpoint, and provider mismatches with typed expected/actual attributes
• type synchronous URL/client initialization failures instead of letting them escape as defects
• remove cause-derived development messages and the adjacent relay-error switch

Validation

• vp test run apps/mobile/src/features/cloud/linkEnvironment.test.ts (21 tests)
• vp run lint:mobile
• vp check (passes with 20 pre-existing warnings)
• vp run typecheck

Overlap

• broad feature PR feat(relay): enforce resource limits #2925 touches these files, but it is unrelated to this audit and does not implement this error model

---

Note

Medium Risk
Error _tag values and user-visible messages change across link/list/connect/status flows; UI or logging that matched old URL-embedded strings or a single CloudEnvironmentLinkError tag needs updating.

Overview
Replaces the single CloudEnvironmentLinkError bucket in mobile cloud linking with a Schema.Union of tagged errors and removes URL-heavy, dev-only, and relay-string message builders.

CloudEnvironmentLinkOperationError now records an action, optional environmentId, redacted URL diagnostics via getUrlDiagnostics (length/protocol/hostname only), nested relayError / environmentError, and traceId, with stable user-facing messages like Could not {action} for environment "{id}". Mismatch cases use dedicated types (CloudEnvironmentIdMismatchError, CloudEnvironmentEndpointMismatchError, CloudEnvironmentEndpointProviderMismatchError, CloudEnvironmentLocalBearerRequiredError, CloudRelayUrlNotConfiguredError) with expected/actual fields instead of generic strings.

Synchronous throws for URL parsing and HTTP client setup are routed through Effect.try into operation errors. Per-environment statusError strings now come from these typed message getters. Tests assert secret redaction in serialization and updated _tag / field shapes; isCloudEnvironmentLinkError narrows the union.

^{Reviewed by Cursor Bugbot for commit d0671a3. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Replace generic cloud link errors with structured, action-specific error types in mobile

• Introduces several new tagged error classes in linkEnvironment.ts: CloudEnvironmentLinkOperationError, CloudRelayUrlNotConfiguredError, CloudEnvironmentLocalBearerRequiredError, CloudEnvironmentIdMismatchError, CloudEnvironmentEndpointMismatchError, and CloudEnvironmentEndpointProviderMismatchError.
• All error types carry structured diagnostics (action label, redacted URL fields like protocol/hostname/input-length, traceId, relay/environment error bodies) instead of raw error strings.
• Exports a CloudEnvironmentLinkError union type and isCloudEnvironmentLinkError guard so callers can reliably discriminate all link-related failures.
• Behavioral Change: Every failure path in linkEnvironmentToCloud, connectRelayManagedEnvironment, listCloudEnvironments, and getCloudEnvironmentStatus now emits a different _tag and message format than before; callers matching on previous error shapes will need updating.

^{Macroscope summarized d0671a3.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: c198374f-00a5-4982-b0a7-6e8cff91c2e1

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/mobile-cloud-link-errors

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[macroscopeapp]

Approvability

Verdict: Approved

This PR refactors error handling to use structured error types and redacts URL secrets from error diagnostics - a security improvement. The core cloud-linking business logic is unchanged; only error construction and formatting changes.

^{You can customize Macroscope's approvability policy. Learn more.}

Dismissing prior approval to re-evaluate fb67183

Dismissing prior approval to re-evaluate 21bfa07

Dismissing prior approval to re-evaluate 9a2733c

Dismissing prior approval to re-evaluate e9c868a

Dismissing prior approval to re-evaluate 6c8a6b1

[juliusmarminge]

Summary

• replace the generic mobile cloud-link error bucket and constructor factories with structured Schema errors
• promote decoded relay errors, environment API failures, and trace IDs through a value-adding static mapper while retaining each exact cause chain
• represent environment ID, endpoint, and provider mismatches with typed expected/actual attributes
• type synchronous URL/client initialization failures instead of letting them escape as defects
• remove cause-derived development messages and the adjacent relay-error switch

Validation

• vp test run apps/mobile/src/features/cloud/linkEnvironment.test.ts (21 tests)
• vp run lint:mobile
• vp check (passes with 20 pre-existing warnings)
• vp run typecheck

Overlap

• broad feature PR feat(relay): enforce resource limits #2925 touches these files, but it is unrelated to this audit and does not implement this error model

---

Note

Medium Risk
Error _tag values and user-visible messages change across link/list/connect/status flows; UI or logging that matched old URL-embedded strings or a single CloudEnvironmentLinkError tag needs updating.

Overview
Replaces the single CloudEnvironmentLinkError bucket in mobile cloud linking with a Schema.Union of tagged errors and removes URL-heavy, dev-only, and relay-string message builders.

CloudEnvironmentLinkOperationError now records an action, optional environmentId, redacted URL diagnostics via getUrlDiagnostics (length/protocol/hostname only), nested relayError / environmentError, and traceId, with stable user-facing messages like Could not {action} for environment "{id}". Mismatch cases use dedicated types (CloudEnvironmentIdMismatchError, CloudEnvironmentEndpointMismatchError, CloudEnvironmentEndpointProviderMismatchError, CloudEnvironmentLocalBearerRequiredError, CloudRelayUrlNotConfiguredError) with expected/actual fields instead of generic strings.

Synchronous throws for URL parsing and HTTP client setup are routed through Effect.try into operation errors. Per-environment statusError strings now come from these typed message getters. Tests assert secret redaction in serialization and updated _tag / field shapes; isCloudEnvironmentLinkError narrows the union.

^{Reviewed by Cursor Bugbot for commit d0671a3. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Replace generic cloud link errors with structured, action-specific error types in mobile

• Introduces several new tagged error classes in linkEnvironment.ts: CloudEnvironmentLinkOperationError, CloudRelayUrlNotConfiguredError, CloudEnvironmentLocalBearerRequiredError, CloudEnvironmentIdMismatchError, CloudEnvironmentEndpointMismatchError, and CloudEnvironmentEndpointProviderMismatchError.
• All error types carry structured diagnostics (action label, redacted URL fields like protocol/hostname/input-length, traceId, relay/environment error bodies) instead of raw error strings.
• Exports a CloudEnvironmentLinkError union type and isCloudEnvironmentLinkError guard so callers can reliably discriminate all link-related failures.
• Behavioral Change: Every failure path in linkEnvironmentToCloud, connectRelayManagedEnvironment, listCloudEnvironments, and getCloudEnvironmentStatus now emits a different _tag and message format than before; callers matching on previous error shapes will need updating.

^{Macroscope summarized d0671a3.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: c198374f-00a5-4982-b0a7-6e8cff91c2e1

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/mobile-cloud-link-errors

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[macroscopeapp]

Approvability

Verdict: Approved

This PR refactors error handling to use structured error types and redacts URL secrets from error diagnostics - a security improvement. The core cloud-linking business logic is unchanged; only error construction and formatting changes.

^{You can customize Macroscope's approvability policy. Learn more.}

Dismissing prior approval to re-evaluate fb67183

Dismissing prior approval to re-evaluate 21bfa07

Dismissing prior approval to re-evaluate 9a2733c

Dismissing prior approval to re-evaluate e9c868a

Dismissing prior approval to re-evaluate 6c8a6b1

[juliusmarminge]

Summary

• replace the generic mobile cloud-link error bucket and constructor factories with structured Schema errors
• promote decoded relay errors, environment API failures, and trace IDs through a value-adding static mapper while retaining each exact cause chain
• represent environment ID, endpoint, and provider mismatches with typed expected/actual attributes
• type synchronous URL/client initialization failures instead of letting them escape as defects
• remove cause-derived development messages and the adjacent relay-error switch

Validation

• vp test run apps/mobile/src/features/cloud/linkEnvironment.test.ts (21 tests)
• vp run lint:mobile
• vp check (passes with 20 pre-existing warnings)
• vp run typecheck

Overlap

• broad feature PR feat(relay): enforce resource limits #2925 touches these files, but it is unrelated to this audit and does not implement this error model

---

Note

Medium Risk
Error _tag values and user-visible messages change across link/list/connect/status flows; UI or logging that matched old URL-embedded strings or a single CloudEnvironmentLinkError tag needs updating.

Overview
Replaces the single CloudEnvironmentLinkError bucket in mobile cloud linking with a Schema.Union of tagged errors and removes URL-heavy, dev-only, and relay-string message builders.

CloudEnvironmentLinkOperationError now records an action, optional environmentId, redacted URL diagnostics via getUrlDiagnostics (length/protocol/hostname only), nested relayError / environmentError, and traceId, with stable user-facing messages like Could not {action} for environment "{id}". Mismatch cases use dedicated types (CloudEnvironmentIdMismatchError, CloudEnvironmentEndpointMismatchError, CloudEnvironmentEndpointProviderMismatchError, CloudEnvironmentLocalBearerRequiredError, CloudRelayUrlNotConfiguredError) with expected/actual fields instead of generic strings.

Synchronous throws for URL parsing and HTTP client setup are routed through Effect.try into operation errors. Per-environment statusError strings now come from these typed message getters. Tests assert secret redaction in serialization and updated _tag / field shapes; isCloudEnvironmentLinkError narrows the union.

^{Reviewed by Cursor Bugbot for commit d0671a3. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Replace generic cloud link errors with structured, action-specific error types in mobile

• Introduces several new tagged error classes in linkEnvironment.ts: CloudEnvironmentLinkOperationError, CloudRelayUrlNotConfiguredError, CloudEnvironmentLocalBearerRequiredError, CloudEnvironmentIdMismatchError, CloudEnvironmentEndpointMismatchError, and CloudEnvironmentEndpointProviderMismatchError.
• All error types carry structured diagnostics (action label, redacted URL fields like protocol/hostname/input-length, traceId, relay/environment error bodies) instead of raw error strings.
• Exports a CloudEnvironmentLinkError union type and isCloudEnvironmentLinkError guard so callers can reliably discriminate all link-related failures.
• Behavioral Change: Every failure path in linkEnvironmentToCloud, connectRelayManagedEnvironment, listCloudEnvironments, and getCloudEnvironmentStatus now emits a different _tag and message format than before; callers matching on previous error shapes will need updating.

^{Macroscope summarized d0671a3.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: c198374f-00a5-4982-b0a7-6e8cff91c2e1

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/mobile-cloud-link-errors

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[macroscopeapp]

Approvability

Verdict: Approved

This PR refactors error handling to use structured error types and redacts URL secrets from error diagnostics - a security improvement. The core cloud-linking business logic is unchanged; only error construction and formatting changes.

^{You can customize Macroscope's approvability policy. Learn more.}

Dismissing prior approval to re-evaluate fb67183

Dismissing prior approval to re-evaluate 21bfa07

Dismissing prior approval to re-evaluate 9a2733c

Dismissing prior approval to re-evaluate e9c868a

Dismissing prior approval to re-evaluate 6c8a6b1

[juliusmarminge]

Summary

• replace the generic mobile cloud-link error bucket and constructor factories with structured Schema errors
• promote decoded relay errors, environment API failures, and trace IDs through a value-adding static mapper while retaining each exact cause chain
• represent environment ID, endpoint, and provider mismatches with typed expected/actual attributes
• type synchronous URL/client initialization failures instead of letting them escape as defects
• remove cause-derived development messages and the adjacent relay-error switch

Validation

• vp test run apps/mobile/src/features/cloud/linkEnvironment.test.ts (21 tests)
• vp run lint:mobile
• vp check (passes with 20 pre-existing warnings)
• vp run typecheck

Overlap

• broad feature PR feat(relay): enforce resource limits #2925 touches these files, but it is unrelated to this audit and does not implement this error model

---

Note

Medium Risk
Error _tag values and user-visible messages change across link/list/connect/status flows; UI or logging that matched old URL-embedded strings or a single CloudEnvironmentLinkError tag needs updating.

Overview
Replaces the single CloudEnvironmentLinkError bucket in mobile cloud linking with a Schema.Union of tagged errors and removes URL-heavy, dev-only, and relay-string message builders.

CloudEnvironmentLinkOperationError now records an action, optional environmentId, redacted URL diagnostics via getUrlDiagnostics (length/protocol/hostname only), nested relayError / environmentError, and traceId, with stable user-facing messages like Could not {action} for environment "{id}". Mismatch cases use dedicated types (CloudEnvironmentIdMismatchError, CloudEnvironmentEndpointMismatchError, CloudEnvironmentEndpointProviderMismatchError, CloudEnvironmentLocalBearerRequiredError, CloudRelayUrlNotConfiguredError) with expected/actual fields instead of generic strings.

Synchronous throws for URL parsing and HTTP client setup are routed through Effect.try into operation errors. Per-environment statusError strings now come from these typed message getters. Tests assert secret redaction in serialization and updated _tag / field shapes; isCloudEnvironmentLinkError narrows the union.

^{Reviewed by Cursor Bugbot for commit d0671a3. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Replace generic cloud link errors with structured, action-specific error types in mobile

• Introduces several new tagged error classes in linkEnvironment.ts: CloudEnvironmentLinkOperationError, CloudRelayUrlNotConfiguredError, CloudEnvironmentLocalBearerRequiredError, CloudEnvironmentIdMismatchError, CloudEnvironmentEndpointMismatchError, and CloudEnvironmentEndpointProviderMismatchError.
• All error types carry structured diagnostics (action label, redacted URL fields like protocol/hostname/input-length, traceId, relay/environment error bodies) instead of raw error strings.
• Exports a CloudEnvironmentLinkError union type and isCloudEnvironmentLinkError guard so callers can reliably discriminate all link-related failures.
• Behavioral Change: Every failure path in linkEnvironmentToCloud, connectRelayManagedEnvironment, listCloudEnvironments, and getCloudEnvironmentStatus now emits a different _tag and message format than before; callers matching on previous error shapes will need updating.

^{Macroscope summarized d0671a3.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: c198374f-00a5-4982-b0a7-6e8cff91c2e1

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/mobile-cloud-link-errors

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[macroscopeapp]

Approvability

Verdict: Approved

This PR refactors error handling to use structured error types and redacts URL secrets from error diagnostics - a security improvement. The core cloud-linking business logic is unchanged; only error construction and formatting changes.

^{You can customize Macroscope's approvability policy. Learn more.}

Dismissing prior approval to re-evaluate fb67183

Dismissing prior approval to re-evaluate 21bfa07

Dismissing prior approval to re-evaluate 9a2733c

Dismissing prior approval to re-evaluate e9c868a

Dismissing prior approval to re-evaluate 6c8a6b1