[codex] Structure agent awareness registration errors

[juliusmarminge]

Summary

• wrap native, storage, auth-provider, and Live Activity registration failures in a Schema-tagged operation error
• attach stable operation fields while preserving every exact underlying cause
• make background registration logs correlate failures without deriving messages from cause text
• keep notification permission and preference-setting errors isolated in [codex] Structure mobile notification setting failures #3391

Validation

• pnpm vp test apps/mobile/src/features/agent-awareness/remoteRegistration.test.ts (14 tests)
• pnpm vp check (passes with existing repository warnings)
• pnpm vp run typecheck
• pnpm vp run lint:mobile

---

Note

Low Risk
Error-shape and observability changes only; registration success/skip behavior and background coalescing are largely unchanged.

Overview
Agent awareness remote registration now wraps native, storage, relay-auth, and Live Activity failures in a Schema-taggedAgentAwarenessOperationError instead of passing through raw thrown values.

Each failure gets a stable operation label (for example read-live-activity-push-token, load-device-registration-identifier, read-device-registration-relay-token) and keeps the original defect in cause, with a fixed message shape for logging and correlation. Relay token lookup is split so device registration and live activity registration record distinct operation names on auth failures.

A test asserts that a rejected getPushToken() surfaces as AgentAwarenessOperationError with the expected operation and preserved cause. Existing “soft” paths (e.g. native APNs lookup falling back to null, active activity listing returning []) are unchanged aside from the wrapped error type where errors are logged or propagated.

^{Reviewed by Cursor Bugbot for commit eee9112. Bugbot is set up for automated code reviews on this repo. Configure here.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 7d390181-c13d-4d7c-81df-2bf4dda2a6f6

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/mobile-agent-awareness-errors

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[macroscopeapp]

Approvability

Verdict: Approved

This PR adds structured error typing to existing error handling without changing control flow. All catch handlers already existed; they now wrap errors in a tagged AgentAwarenessOperationError class for better observability. A corresponding test was added.

No code changes detected at eee9112. Prior analysis still applies.

^{You can customize Macroscope's approvability policy. Learn more.}

Dismissing prior approval to re-evaluate e44a51c

[juliusmarminge]

Summary

• wrap native, storage, auth-provider, and Live Activity registration failures in a Schema-tagged operation error
• attach stable operation fields while preserving every exact underlying cause
• make background registration logs correlate failures without deriving messages from cause text
• keep notification permission and preference-setting errors isolated in [codex] Structure mobile notification setting failures #3391

Validation

• pnpm vp test apps/mobile/src/features/agent-awareness/remoteRegistration.test.ts (14 tests)
• pnpm vp check (passes with existing repository warnings)
• pnpm vp run typecheck
• pnpm vp run lint:mobile

---

Note

Low Risk
Error-shape and observability changes only; registration success/skip behavior and background coalescing are largely unchanged.

Overview
Agent awareness remote registration now wraps native, storage, relay-auth, and Live Activity failures in a Schema-taggedAgentAwarenessOperationError instead of passing through raw thrown values.

Each failure gets a stable operation label (for example read-live-activity-push-token, load-device-registration-identifier, read-device-registration-relay-token) and keeps the original defect in cause, with a fixed message shape for logging and correlation. Relay token lookup is split so device registration and live activity registration record distinct operation names on auth failures.

A test asserts that a rejected getPushToken() surfaces as AgentAwarenessOperationError with the expected operation and preserved cause. Existing “soft” paths (e.g. native APNs lookup falling back to null, active activity listing returning []) are unchanged aside from the wrapped error type where errors are logged or propagated.

^{Reviewed by Cursor Bugbot for commit eee9112. Bugbot is set up for automated code reviews on this repo. Configure here.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 7d390181-c13d-4d7c-81df-2bf4dda2a6f6

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/mobile-agent-awareness-errors

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[macroscopeapp]

Approvability

Verdict: Approved

This PR adds structured error typing to existing error handling without changing control flow. All catch handlers already existed; they now wrap errors in a tagged AgentAwarenessOperationError class for better observability. A corresponding test was added.

No code changes detected at eee9112. Prior analysis still applies.

^{You can customize Macroscope's approvability policy. Learn more.}

Dismissing prior approval to re-evaluate e44a51c

[juliusmarminge]

Summary

• wrap native, storage, auth-provider, and Live Activity registration failures in a Schema-tagged operation error
• attach stable operation fields while preserving every exact underlying cause
• make background registration logs correlate failures without deriving messages from cause text
• keep notification permission and preference-setting errors isolated in [codex] Structure mobile notification setting failures #3391

Validation

• pnpm vp test apps/mobile/src/features/agent-awareness/remoteRegistration.test.ts (14 tests)
• pnpm vp check (passes with existing repository warnings)
• pnpm vp run typecheck
• pnpm vp run lint:mobile

---

Note

Low Risk
Error-shape and observability changes only; registration success/skip behavior and background coalescing are largely unchanged.

Overview
Agent awareness remote registration now wraps native, storage, relay-auth, and Live Activity failures in a Schema-taggedAgentAwarenessOperationError instead of passing through raw thrown values.

Each failure gets a stable operation label (for example read-live-activity-push-token, load-device-registration-identifier, read-device-registration-relay-token) and keeps the original defect in cause, with a fixed message shape for logging and correlation. Relay token lookup is split so device registration and live activity registration record distinct operation names on auth failures.

A test asserts that a rejected getPushToken() surfaces as AgentAwarenessOperationError with the expected operation and preserved cause. Existing “soft” paths (e.g. native APNs lookup falling back to null, active activity listing returning []) are unchanged aside from the wrapped error type where errors are logged or propagated.

^{Reviewed by Cursor Bugbot for commit eee9112. Bugbot is set up for automated code reviews on this repo. Configure here.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 7d390181-c13d-4d7c-81df-2bf4dda2a6f6

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/mobile-agent-awareness-errors

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[macroscopeapp]

Approvability

Verdict: Approved

This PR adds structured error typing to existing error handling without changing control flow. All catch handlers already existed; they now wrap errors in a tagged AgentAwarenessOperationError class for better observability. A corresponding test was added.

No code changes detected at eee9112. Prior analysis still applies.

^{You can customize Macroscope's approvability policy. Learn more.}

Dismissing prior approval to re-evaluate e44a51c

[juliusmarminge]

Summary

• wrap native, storage, auth-provider, and Live Activity registration failures in a Schema-tagged operation error
• attach stable operation fields while preserving every exact underlying cause
• make background registration logs correlate failures without deriving messages from cause text
• keep notification permission and preference-setting errors isolated in [codex] Structure mobile notification setting failures #3391

Validation

• pnpm vp test apps/mobile/src/features/agent-awareness/remoteRegistration.test.ts (14 tests)
• pnpm vp check (passes with existing repository warnings)
• pnpm vp run typecheck
• pnpm vp run lint:mobile

---

Note

Low Risk
Error-shape and observability changes only; registration success/skip behavior and background coalescing are largely unchanged.

Overview
Agent awareness remote registration now wraps native, storage, relay-auth, and Live Activity failures in a Schema-taggedAgentAwarenessOperationError instead of passing through raw thrown values.

Each failure gets a stable operation label (for example read-live-activity-push-token, load-device-registration-identifier, read-device-registration-relay-token) and keeps the original defect in cause, with a fixed message shape for logging and correlation. Relay token lookup is split so device registration and live activity registration record distinct operation names on auth failures.

A test asserts that a rejected getPushToken() surfaces as AgentAwarenessOperationError with the expected operation and preserved cause. Existing “soft” paths (e.g. native APNs lookup falling back to null, active activity listing returning []) are unchanged aside from the wrapped error type where errors are logged or propagated.

^{Reviewed by Cursor Bugbot for commit eee9112. Bugbot is set up for automated code reviews on this repo. Configure here.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 7d390181-c13d-4d7c-81df-2bf4dda2a6f6

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/mobile-agent-awareness-errors

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[macroscopeapp]

Approvability

Verdict: Approved

This PR adds structured error typing to existing error handling without changing control flow. All catch handlers already existed; they now wrap errors in a tagged AgentAwarenessOperationError class for better observability. A corresponding test was added.

No code changes detected at eee9112. Prior analysis still applies.

^{You can customize Macroscope's approvability policy. Learn more.}

Dismissing prior approval to re-evaluate e44a51c

[juliusmarminge]

Summary

• wrap native, storage, auth-provider, and Live Activity registration failures in a Schema-tagged operation error
• attach stable operation fields while preserving every exact underlying cause
• make background registration logs correlate failures without deriving messages from cause text
• keep notification permission and preference-setting errors isolated in [codex] Structure mobile notification setting failures #3391

Validation

• pnpm vp test apps/mobile/src/features/agent-awareness/remoteRegistration.test.ts (14 tests)
• pnpm vp check (passes with existing repository warnings)
• pnpm vp run typecheck
• pnpm vp run lint:mobile

---

Note

Low Risk
Error-shape and observability changes only; registration success/skip behavior and background coalescing are largely unchanged.

Overview
Agent awareness remote registration now wraps native, storage, relay-auth, and Live Activity failures in a Schema-taggedAgentAwarenessOperationError instead of passing through raw thrown values.

Each failure gets a stable operation label (for example read-live-activity-push-token, load-device-registration-identifier, read-device-registration-relay-token) and keeps the original defect in cause, with a fixed message shape for logging and correlation. Relay token lookup is split so device registration and live activity registration record distinct operation names on auth failures.

A test asserts that a rejected getPushToken() surfaces as AgentAwarenessOperationError with the expected operation and preserved cause. Existing “soft” paths (e.g. native APNs lookup falling back to null, active activity listing returning []) are unchanged aside from the wrapped error type where errors are logged or propagated.

^{Reviewed by Cursor Bugbot for commit eee9112. Bugbot is set up for automated code reviews on this repo. Configure here.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 7d390181-c13d-4d7c-81df-2bf4dda2a6f6

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/mobile-agent-awareness-errors

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[macroscopeapp]

Approvability

Verdict: Approved

This PR adds structured error typing to existing error handling without changing control flow. All catch handlers already existed; they now wrap errors in a tagged AgentAwarenessOperationError class for better observability. A corresponding test was added.

No code changes detected at eee9112. Prior analysis still applies.

^{You can customize Macroscope's approvability policy. Learn more.}

Dismissing prior approval to re-evaluate e44a51c

[juliusmarminge]

Summary

• wrap native, storage, auth-provider, and Live Activity registration failures in a Schema-tagged operation error
• attach stable operation fields while preserving every exact underlying cause
• make background registration logs correlate failures without deriving messages from cause text
• keep notification permission and preference-setting errors isolated in [codex] Structure mobile notification setting failures #3391

Validation

• pnpm vp test apps/mobile/src/features/agent-awareness/remoteRegistration.test.ts (14 tests)
• pnpm vp check (passes with existing repository warnings)
• pnpm vp run typecheck
• pnpm vp run lint:mobile

---

Note

Low Risk
Error-shape and observability changes only; registration success/skip behavior and background coalescing are largely unchanged.

Overview
Agent awareness remote registration now wraps native, storage, relay-auth, and Live Activity failures in a Schema-taggedAgentAwarenessOperationError instead of passing through raw thrown values.

Each failure gets a stable operation label (for example read-live-activity-push-token, load-device-registration-identifier, read-device-registration-relay-token) and keeps the original defect in cause, with a fixed message shape for logging and correlation. Relay token lookup is split so device registration and live activity registration record distinct operation names on auth failures.

A test asserts that a rejected getPushToken() surfaces as AgentAwarenessOperationError with the expected operation and preserved cause. Existing “soft” paths (e.g. native APNs lookup falling back to null, active activity listing returning []) are unchanged aside from the wrapped error type where errors are logged or propagated.

^{Reviewed by Cursor Bugbot for commit eee9112. Bugbot is set up for automated code reviews on this repo. Configure here.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 7d390181-c13d-4d7c-81df-2bf4dda2a6f6

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/mobile-agent-awareness-errors

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[macroscopeapp]

Approvability

Verdict: Approved

This PR adds structured error typing to existing error handling without changing control flow. All catch handlers already existed; they now wrap errors in a tagged AgentAwarenessOperationError class for better observability. A corresponding test was added.

No code changes detected at eee9112. Prior analysis still applies.

^{You can customize Macroscope's approvability policy. Learn more.}

Dismissing prior approval to re-evaluate e44a51c

[juliusmarminge]

Summary

• wrap native, storage, auth-provider, and Live Activity registration failures in a Schema-tagged operation error
• attach stable operation fields while preserving every exact underlying cause
• make background registration logs correlate failures without deriving messages from cause text
• keep notification permission and preference-setting errors isolated in [codex] Structure mobile notification setting failures #3391

Validation

• pnpm vp test apps/mobile/src/features/agent-awareness/remoteRegistration.test.ts (14 tests)
• pnpm vp check (passes with existing repository warnings)
• pnpm vp run typecheck
• pnpm vp run lint:mobile

---

Note

Low Risk
Error-shape and observability changes only; registration success/skip behavior and background coalescing are largely unchanged.

Overview
Agent awareness remote registration now wraps native, storage, relay-auth, and Live Activity failures in a Schema-taggedAgentAwarenessOperationError instead of passing through raw thrown values.

Each failure gets a stable operation label (for example read-live-activity-push-token, load-device-registration-identifier, read-device-registration-relay-token) and keeps the original defect in cause, with a fixed message shape for logging and correlation. Relay token lookup is split so device registration and live activity registration record distinct operation names on auth failures.

A test asserts that a rejected getPushToken() surfaces as AgentAwarenessOperationError with the expected operation and preserved cause. Existing “soft” paths (e.g. native APNs lookup falling back to null, active activity listing returning []) are unchanged aside from the wrapped error type where errors are logged or propagated.

^{Reviewed by Cursor Bugbot for commit eee9112. Bugbot is set up for automated code reviews on this repo. Configure here.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 7d390181-c13d-4d7c-81df-2bf4dda2a6f6

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/mobile-agent-awareness-errors

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[macroscopeapp]

Approvability

Verdict: Approved

This PR adds structured error typing to existing error handling without changing control flow. All catch handlers already existed; they now wrap errors in a tagged AgentAwarenessOperationError class for better observability. A corresponding test was added.

No code changes detected at eee9112. Prior analysis still applies.

^{You can customize Macroscope's approvability policy. Learn more.}

Dismissing prior approval to re-evaluate e44a51c

[juliusmarminge]

Summary

• wrap native, storage, auth-provider, and Live Activity registration failures in a Schema-tagged operation error
• attach stable operation fields while preserving every exact underlying cause
• make background registration logs correlate failures without deriving messages from cause text
• keep notification permission and preference-setting errors isolated in [codex] Structure mobile notification setting failures #3391

Validation

• pnpm vp test apps/mobile/src/features/agent-awareness/remoteRegistration.test.ts (14 tests)
• pnpm vp check (passes with existing repository warnings)
• pnpm vp run typecheck
• pnpm vp run lint:mobile

---

Note

Low Risk
Error-shape and observability changes only; registration success/skip behavior and background coalescing are largely unchanged.

Overview
Agent awareness remote registration now wraps native, storage, relay-auth, and Live Activity failures in a Schema-taggedAgentAwarenessOperationError instead of passing through raw thrown values.

Each failure gets a stable operation label (for example read-live-activity-push-token, load-device-registration-identifier, read-device-registration-relay-token) and keeps the original defect in cause, with a fixed message shape for logging and correlation. Relay token lookup is split so device registration and live activity registration record distinct operation names on auth failures.

A test asserts that a rejected getPushToken() surfaces as AgentAwarenessOperationError with the expected operation and preserved cause. Existing “soft” paths (e.g. native APNs lookup falling back to null, active activity listing returning []) are unchanged aside from the wrapped error type where errors are logged or propagated.

^{Reviewed by Cursor Bugbot for commit eee9112. Bugbot is set up for automated code reviews on this repo. Configure here.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 7d390181-c13d-4d7c-81df-2bf4dda2a6f6

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/mobile-agent-awareness-errors

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[macroscopeapp]

Approvability

Verdict: Approved

This PR adds structured error typing to existing error handling without changing control flow. All catch handlers already existed; they now wrap errors in a tagged AgentAwarenessOperationError class for better observability. A corresponding test was added.

No code changes detected at eee9112. Prior analysis still applies.

^{You can customize Macroscope's approvability policy. Learn more.}

Dismissing prior approval to re-evaluate e44a51c