[codex] Structure relay deploy output errors

[juliusmarminge]

Summary

• replace the message-only deploy error with a Schema error carrying source, stage, output path, and missing fields
• report exact missing Alchemy output fields for state reads and applies
• reuse the parsed deploy output so validation and public config construction cannot drift

Validation

• vp test infra/relay/scripts/deploy.test.ts --no-cache
• vp check
• vp run typecheck
• vpr typecheck

Overlap audit

• no active service/error-refactor PR overlaps these files; feat(relay): enforce resource limits #2925 is an unrelated broad feature branch

---

Note

Low Risk
Changes are limited to the relay deploy script’s error types and output validation; behavior on success is unchanged aside from stricter rejection of empty config values.

Overview
Relay deploy failures now surface structured errors instead of generic message strings, so CI and operators can see where output broke (Alchemy state vs apply), the stage, and which public config fields are missing.

RelayDeployError moves from Data.TaggedError to Effect Schema tagged errors with source, stage, and missingFields, plus a derived message listing missing fields. A separate RelayDeployPublicConfigUnavailableError covers cases like dry-run or cancel when --github-env-file is set but no public config exists (includes result, stage, outputPath).

Public config parsing is centralized: missingRelayPublicConfigFields, shared value extraction, and publicConfigFromOutput now treat empty strings as incomplete and reuse the same path for state reads and apply output—replacing duplicated inline field checks after deploy.

^{Reviewed by Cursor Bugbot for commit 0897348. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Structure relay deploy output errors with typed fields and distinct error classes

• Replaces Data.TaggedError-based RelayDeployError with a Schema.TaggedErrorClass carrying structured source, stage, and missingFields properties, with a deterministic message listing missing public config fields.
• Adds RelayDeployPublicConfigUnavailableError, a new error class thrown by writeGithubEnvFile when public config is absent, including result, stage, and outputPath context.
• Adds missingRelayPublicConfigFields and hasCompleteRelayPublicConfigValues helpers to validate required deploy output fields; publicConfigFromOutput now rejects empty strings and handles Redacted values consistently.
• Propagates stage through writeGithubEnvFile and runRelayDeploy so all error paths include stage context.

^{Macroscope summarized 0897348.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 83912001-ac1d-44e7-8e0d-4cae6302386d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/relay-deploy-errors

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[cursor]

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Bugbot Autofix prepared a fix for the issue found in the latest run.

• ✅ Fixed: Misleading fields when config absent
  • Replaced the misleading RelayDeployError (with hardcoded missingFields and 'deploy_outcome' source) with a descriptive Console.log warning that includes the deploy result, and an early return instead of failing.

Or push these changes by commenting:

@cursor push 3ca08d9395

Preview (3ca08d9395)

diff --git a/infra/relay/scripts/deploy.ts b/infra/relay/scripts/deploy.ts--- a/infra/relay/scripts/deploy.ts+++ b/infra/relay/scripts/deploy.ts@@ -223,15 +223,13 @@
const writeGithubEnvFile = Effect.fn("relay.deploy.writeGithubEnvFile")(function* (
outcome: RelayDeployOutcome,
outputPath: string,
- stage: string,+ _stage: string,
) {
if (Option.isNone(outcome.publicConfig)) {
- return yield* new RelayDeployError({- source: "deploy_outcome",- stage,- outputPath,- missingFields: ["clientTracingUrl", "clientTracingDataset", "clientTracingToken"],- });+ yield* Console.log(+ `Skipping github env file: relay public client config is unavailable (deploy result: ${outcome.result})`,+ );+ return;
}
const fs = yield* FileSystem.FileSystem;
yield* Console.log(`::add-mask::${outcome.publicConfig.value.clientTracingToken}`);

_{You can send follow-ups to the cloud agent here.}

^{Reviewed by Cursor Bugbot for commit 5ad2cf8. Configure here.}

[macroscopeapp]

Approvability

Verdict: Approved

This PR refactors error handling in relay deploy scripts to provide more structured error messages with explicit source, stage, and missing field information. Changes are limited to deployment infrastructure tooling with good test coverage.

No code changes detected at 0897348. Prior analysis still applies.

^{You can customize Macroscope's approvability policy. Learn more.}

Dismissing prior approval to re-evaluate 72a5a9d

[juliusmarminge]

Summary

• replace the message-only deploy error with a Schema error carrying source, stage, output path, and missing fields
• report exact missing Alchemy output fields for state reads and applies
• reuse the parsed deploy output so validation and public config construction cannot drift

Validation

• vp test infra/relay/scripts/deploy.test.ts --no-cache
• vp check
• vp run typecheck
• vpr typecheck

Overlap audit

• no active service/error-refactor PR overlaps these files; feat(relay): enforce resource limits #2925 is an unrelated broad feature branch

---

Note

Low Risk
Changes are limited to the relay deploy script’s error types and output validation; behavior on success is unchanged aside from stricter rejection of empty config values.

Overview
Relay deploy failures now surface structured errors instead of generic message strings, so CI and operators can see where output broke (Alchemy state vs apply), the stage, and which public config fields are missing.

RelayDeployError moves from Data.TaggedError to Effect Schema tagged errors with source, stage, and missingFields, plus a derived message listing missing fields. A separate RelayDeployPublicConfigUnavailableError covers cases like dry-run or cancel when --github-env-file is set but no public config exists (includes result, stage, outputPath).

Public config parsing is centralized: missingRelayPublicConfigFields, shared value extraction, and publicConfigFromOutput now treat empty strings as incomplete and reuse the same path for state reads and apply output—replacing duplicated inline field checks after deploy.

^{Reviewed by Cursor Bugbot for commit 0897348. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Structure relay deploy output errors with typed fields and distinct error classes

• Replaces Data.TaggedError-based RelayDeployError with a Schema.TaggedErrorClass carrying structured source, stage, and missingFields properties, with a deterministic message listing missing public config fields.
• Adds RelayDeployPublicConfigUnavailableError, a new error class thrown by writeGithubEnvFile when public config is absent, including result, stage, and outputPath context.
• Adds missingRelayPublicConfigFields and hasCompleteRelayPublicConfigValues helpers to validate required deploy output fields; publicConfigFromOutput now rejects empty strings and handles Redacted values consistently.
• Propagates stage through writeGithubEnvFile and runRelayDeploy so all error paths include stage context.

^{Macroscope summarized 0897348.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 83912001-ac1d-44e7-8e0d-4cae6302386d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/relay-deploy-errors

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[cursor]

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Bugbot Autofix prepared a fix for the issue found in the latest run.

• ✅ Fixed: Misleading fields when config absent
  • Replaced the misleading RelayDeployError (with hardcoded missingFields and 'deploy_outcome' source) with a descriptive Console.log warning that includes the deploy result, and an early return instead of failing.

Or push these changes by commenting:

@cursor push 3ca08d9395

Preview (3ca08d9395)

diff --git a/infra/relay/scripts/deploy.ts b/infra/relay/scripts/deploy.ts--- a/infra/relay/scripts/deploy.ts+++ b/infra/relay/scripts/deploy.ts@@ -223,15 +223,13 @@
const writeGithubEnvFile = Effect.fn("relay.deploy.writeGithubEnvFile")(function* (
outcome: RelayDeployOutcome,
outputPath: string,
- stage: string,+ _stage: string,
) {
if (Option.isNone(outcome.publicConfig)) {
- return yield* new RelayDeployError({- source: "deploy_outcome",- stage,- outputPath,- missingFields: ["clientTracingUrl", "clientTracingDataset", "clientTracingToken"],- });+ yield* Console.log(+ `Skipping github env file: relay public client config is unavailable (deploy result: ${outcome.result})`,+ );+ return;
}
const fs = yield* FileSystem.FileSystem;
yield* Console.log(`::add-mask::${outcome.publicConfig.value.clientTracingToken}`);

_{You can send follow-ups to the cloud agent here.}

^{Reviewed by Cursor Bugbot for commit 5ad2cf8. Configure here.}

[macroscopeapp]

Approvability

Verdict: Approved

This PR refactors error handling in relay deploy scripts to provide more structured error messages with explicit source, stage, and missing field information. Changes are limited to deployment infrastructure tooling with good test coverage.

No code changes detected at 0897348. Prior analysis still applies.

^{You can customize Macroscope's approvability policy. Learn more.}

Dismissing prior approval to re-evaluate 72a5a9d

[juliusmarminge]

Summary

• replace the message-only deploy error with a Schema error carrying source, stage, output path, and missing fields
• report exact missing Alchemy output fields for state reads and applies
• reuse the parsed deploy output so validation and public config construction cannot drift

Validation

• vp test infra/relay/scripts/deploy.test.ts --no-cache
• vp check
• vp run typecheck
• vpr typecheck

Overlap audit

• no active service/error-refactor PR overlaps these files; feat(relay): enforce resource limits #2925 is an unrelated broad feature branch

---

Note

Low Risk
Changes are limited to the relay deploy script’s error types and output validation; behavior on success is unchanged aside from stricter rejection of empty config values.

Overview
Relay deploy failures now surface structured errors instead of generic message strings, so CI and operators can see where output broke (Alchemy state vs apply), the stage, and which public config fields are missing.

RelayDeployError moves from Data.TaggedError to Effect Schema tagged errors with source, stage, and missingFields, plus a derived message listing missing fields. A separate RelayDeployPublicConfigUnavailableError covers cases like dry-run or cancel when --github-env-file is set but no public config exists (includes result, stage, outputPath).

Public config parsing is centralized: missingRelayPublicConfigFields, shared value extraction, and publicConfigFromOutput now treat empty strings as incomplete and reuse the same path for state reads and apply output—replacing duplicated inline field checks after deploy.

^{Reviewed by Cursor Bugbot for commit 0897348. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Structure relay deploy output errors with typed fields and distinct error classes

• Replaces Data.TaggedError-based RelayDeployError with a Schema.TaggedErrorClass carrying structured source, stage, and missingFields properties, with a deterministic message listing missing public config fields.
• Adds RelayDeployPublicConfigUnavailableError, a new error class thrown by writeGithubEnvFile when public config is absent, including result, stage, and outputPath context.
• Adds missingRelayPublicConfigFields and hasCompleteRelayPublicConfigValues helpers to validate required deploy output fields; publicConfigFromOutput now rejects empty strings and handles Redacted values consistently.
• Propagates stage through writeGithubEnvFile and runRelayDeploy so all error paths include stage context.

^{Macroscope summarized 0897348.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 83912001-ac1d-44e7-8e0d-4cae6302386d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/relay-deploy-errors

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[cursor]

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Bugbot Autofix prepared a fix for the issue found in the latest run.

• ✅ Fixed: Misleading fields when config absent
  • Replaced the misleading RelayDeployError (with hardcoded missingFields and 'deploy_outcome' source) with a descriptive Console.log warning that includes the deploy result, and an early return instead of failing.

Or push these changes by commenting:

@cursor push 3ca08d9395

Preview (3ca08d9395)

diff --git a/infra/relay/scripts/deploy.ts b/infra/relay/scripts/deploy.ts--- a/infra/relay/scripts/deploy.ts+++ b/infra/relay/scripts/deploy.ts@@ -223,15 +223,13 @@
const writeGithubEnvFile = Effect.fn("relay.deploy.writeGithubEnvFile")(function* (
outcome: RelayDeployOutcome,
outputPath: string,
- stage: string,+ _stage: string,
) {
if (Option.isNone(outcome.publicConfig)) {
- return yield* new RelayDeployError({- source: "deploy_outcome",- stage,- outputPath,- missingFields: ["clientTracingUrl", "clientTracingDataset", "clientTracingToken"],- });+ yield* Console.log(+ `Skipping github env file: relay public client config is unavailable (deploy result: ${outcome.result})`,+ );+ return;
}
const fs = yield* FileSystem.FileSystem;
yield* Console.log(`::add-mask::${outcome.publicConfig.value.clientTracingToken}`);

_{You can send follow-ups to the cloud agent here.}

^{Reviewed by Cursor Bugbot for commit 5ad2cf8. Configure here.}

[macroscopeapp]

Approvability

Verdict: Approved

This PR refactors error handling in relay deploy scripts to provide more structured error messages with explicit source, stage, and missing field information. Changes are limited to deployment infrastructure tooling with good test coverage.

No code changes detected at 0897348. Prior analysis still applies.

^{You can customize Macroscope's approvability policy. Learn more.}

Dismissing prior approval to re-evaluate 72a5a9d

[juliusmarminge]

Summary

• replace the message-only deploy error with a Schema error carrying source, stage, output path, and missing fields
• report exact missing Alchemy output fields for state reads and applies
• reuse the parsed deploy output so validation and public config construction cannot drift

Validation

• vp test infra/relay/scripts/deploy.test.ts --no-cache
• vp check
• vp run typecheck
• vpr typecheck

Overlap audit

• no active service/error-refactor PR overlaps these files; feat(relay): enforce resource limits #2925 is an unrelated broad feature branch

---

Note

Low Risk
Changes are limited to the relay deploy script’s error types and output validation; behavior on success is unchanged aside from stricter rejection of empty config values.

Overview
Relay deploy failures now surface structured errors instead of generic message strings, so CI and operators can see where output broke (Alchemy state vs apply), the stage, and which public config fields are missing.

RelayDeployError moves from Data.TaggedError to Effect Schema tagged errors with source, stage, and missingFields, plus a derived message listing missing fields. A separate RelayDeployPublicConfigUnavailableError covers cases like dry-run or cancel when --github-env-file is set but no public config exists (includes result, stage, outputPath).

Public config parsing is centralized: missingRelayPublicConfigFields, shared value extraction, and publicConfigFromOutput now treat empty strings as incomplete and reuse the same path for state reads and apply output—replacing duplicated inline field checks after deploy.

^{Reviewed by Cursor Bugbot for commit 0897348. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Structure relay deploy output errors with typed fields and distinct error classes

• Replaces Data.TaggedError-based RelayDeployError with a Schema.TaggedErrorClass carrying structured source, stage, and missingFields properties, with a deterministic message listing missing public config fields.
• Adds RelayDeployPublicConfigUnavailableError, a new error class thrown by writeGithubEnvFile when public config is absent, including result, stage, and outputPath context.
• Adds missingRelayPublicConfigFields and hasCompleteRelayPublicConfigValues helpers to validate required deploy output fields; publicConfigFromOutput now rejects empty strings and handles Redacted values consistently.
• Propagates stage through writeGithubEnvFile and runRelayDeploy so all error paths include stage context.

^{Macroscope summarized 0897348.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 83912001-ac1d-44e7-8e0d-4cae6302386d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/relay-deploy-errors

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[cursor]

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Bugbot Autofix prepared a fix for the issue found in the latest run.

• ✅ Fixed: Misleading fields when config absent
  • Replaced the misleading RelayDeployError (with hardcoded missingFields and 'deploy_outcome' source) with a descriptive Console.log warning that includes the deploy result, and an early return instead of failing.

Or push these changes by commenting:

@cursor push 3ca08d9395

Preview (3ca08d9395)

diff --git a/infra/relay/scripts/deploy.ts b/infra/relay/scripts/deploy.ts--- a/infra/relay/scripts/deploy.ts+++ b/infra/relay/scripts/deploy.ts@@ -223,15 +223,13 @@
const writeGithubEnvFile = Effect.fn("relay.deploy.writeGithubEnvFile")(function* (
outcome: RelayDeployOutcome,
outputPath: string,
- stage: string,+ _stage: string,
) {
if (Option.isNone(outcome.publicConfig)) {
- return yield* new RelayDeployError({- source: "deploy_outcome",- stage,- outputPath,- missingFields: ["clientTracingUrl", "clientTracingDataset", "clientTracingToken"],- });+ yield* Console.log(+ `Skipping github env file: relay public client config is unavailable (deploy result: ${outcome.result})`,+ );+ return;
}
const fs = yield* FileSystem.FileSystem;
yield* Console.log(`::add-mask::${outcome.publicConfig.value.clientTracingToken}`);

_{You can send follow-ups to the cloud agent here.}

^{Reviewed by Cursor Bugbot for commit 5ad2cf8. Configure here.}

[macroscopeapp]

Approvability

Verdict: Approved

This PR refactors error handling in relay deploy scripts to provide more structured error messages with explicit source, stage, and missing field information. Changes are limited to deployment infrastructure tooling with good test coverage.

No code changes detected at 0897348. Prior analysis still applies.

^{You can customize Macroscope's approvability policy. Learn more.}

Dismissing prior approval to re-evaluate 72a5a9d

[juliusmarminge]

Summary

• replace the message-only deploy error with a Schema error carrying source, stage, output path, and missing fields
• report exact missing Alchemy output fields for state reads and applies
• reuse the parsed deploy output so validation and public config construction cannot drift

Validation

• vp test infra/relay/scripts/deploy.test.ts --no-cache
• vp check
• vp run typecheck
• vpr typecheck

Overlap audit

• no active service/error-refactor PR overlaps these files; feat(relay): enforce resource limits #2925 is an unrelated broad feature branch

---

Note

Low Risk
Changes are limited to the relay deploy script’s error types and output validation; behavior on success is unchanged aside from stricter rejection of empty config values.

Overview
Relay deploy failures now surface structured errors instead of generic message strings, so CI and operators can see where output broke (Alchemy state vs apply), the stage, and which public config fields are missing.

RelayDeployError moves from Data.TaggedError to Effect Schema tagged errors with source, stage, and missingFields, plus a derived message listing missing fields. A separate RelayDeployPublicConfigUnavailableError covers cases like dry-run or cancel when --github-env-file is set but no public config exists (includes result, stage, outputPath).

Public config parsing is centralized: missingRelayPublicConfigFields, shared value extraction, and publicConfigFromOutput now treat empty strings as incomplete and reuse the same path for state reads and apply output—replacing duplicated inline field checks after deploy.

^{Reviewed by Cursor Bugbot for commit 0897348. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Structure relay deploy output errors with typed fields and distinct error classes

• Replaces Data.TaggedError-based RelayDeployError with a Schema.TaggedErrorClass carrying structured source, stage, and missingFields properties, with a deterministic message listing missing public config fields.
• Adds RelayDeployPublicConfigUnavailableError, a new error class thrown by writeGithubEnvFile when public config is absent, including result, stage, and outputPath context.
• Adds missingRelayPublicConfigFields and hasCompleteRelayPublicConfigValues helpers to validate required deploy output fields; publicConfigFromOutput now rejects empty strings and handles Redacted values consistently.
• Propagates stage through writeGithubEnvFile and runRelayDeploy so all error paths include stage context.

^{Macroscope summarized 0897348.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 83912001-ac1d-44e7-8e0d-4cae6302386d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/relay-deploy-errors

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[cursor]

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Bugbot Autofix prepared a fix for the issue found in the latest run.

• ✅ Fixed: Misleading fields when config absent
  • Replaced the misleading RelayDeployError (with hardcoded missingFields and 'deploy_outcome' source) with a descriptive Console.log warning that includes the deploy result, and an early return instead of failing.

Or push these changes by commenting:

@cursor push 3ca08d9395

Preview (3ca08d9395)

diff --git a/infra/relay/scripts/deploy.ts b/infra/relay/scripts/deploy.ts--- a/infra/relay/scripts/deploy.ts+++ b/infra/relay/scripts/deploy.ts@@ -223,15 +223,13 @@
const writeGithubEnvFile = Effect.fn("relay.deploy.writeGithubEnvFile")(function* (
outcome: RelayDeployOutcome,
outputPath: string,
- stage: string,+ _stage: string,
) {
if (Option.isNone(outcome.publicConfig)) {
- return yield* new RelayDeployError({- source: "deploy_outcome",- stage,- outputPath,- missingFields: ["clientTracingUrl", "clientTracingDataset", "clientTracingToken"],- });+ yield* Console.log(+ `Skipping github env file: relay public client config is unavailable (deploy result: ${outcome.result})`,+ );+ return;
}
const fs = yield* FileSystem.FileSystem;
yield* Console.log(`::add-mask::${outcome.publicConfig.value.clientTracingToken}`);

_{You can send follow-ups to the cloud agent here.}

^{Reviewed by Cursor Bugbot for commit 5ad2cf8. Configure here.}

[macroscopeapp]

Approvability

Verdict: Approved

This PR refactors error handling in relay deploy scripts to provide more structured error messages with explicit source, stage, and missing field information. Changes are limited to deployment infrastructure tooling with good test coverage.

No code changes detected at 0897348. Prior analysis still applies.

^{You can customize Macroscope's approvability policy. Learn more.}

Dismissing prior approval to re-evaluate 72a5a9d

[juliusmarminge]

Summary

• replace the message-only deploy error with a Schema error carrying source, stage, output path, and missing fields
• report exact missing Alchemy output fields for state reads and applies
• reuse the parsed deploy output so validation and public config construction cannot drift

Validation

• vp test infra/relay/scripts/deploy.test.ts --no-cache
• vp check
• vp run typecheck
• vpr typecheck

Overlap audit

• no active service/error-refactor PR overlaps these files; feat(relay): enforce resource limits #2925 is an unrelated broad feature branch

---

Note

Low Risk
Changes are limited to the relay deploy script’s error types and output validation; behavior on success is unchanged aside from stricter rejection of empty config values.

Overview
Relay deploy failures now surface structured errors instead of generic message strings, so CI and operators can see where output broke (Alchemy state vs apply), the stage, and which public config fields are missing.

RelayDeployError moves from Data.TaggedError to Effect Schema tagged errors with source, stage, and missingFields, plus a derived message listing missing fields. A separate RelayDeployPublicConfigUnavailableError covers cases like dry-run or cancel when --github-env-file is set but no public config exists (includes result, stage, outputPath).

Public config parsing is centralized: missingRelayPublicConfigFields, shared value extraction, and publicConfigFromOutput now treat empty strings as incomplete and reuse the same path for state reads and apply output—replacing duplicated inline field checks after deploy.

^{Reviewed by Cursor Bugbot for commit 0897348. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Structure relay deploy output errors with typed fields and distinct error classes

• Replaces Data.TaggedError-based RelayDeployError with a Schema.TaggedErrorClass carrying structured source, stage, and missingFields properties, with a deterministic message listing missing public config fields.
• Adds RelayDeployPublicConfigUnavailableError, a new error class thrown by writeGithubEnvFile when public config is absent, including result, stage, and outputPath context.
• Adds missingRelayPublicConfigFields and hasCompleteRelayPublicConfigValues helpers to validate required deploy output fields; publicConfigFromOutput now rejects empty strings and handles Redacted values consistently.
• Propagates stage through writeGithubEnvFile and runRelayDeploy so all error paths include stage context.

^{Macroscope summarized 0897348.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 83912001-ac1d-44e7-8e0d-4cae6302386d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/relay-deploy-errors

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[cursor]

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Bugbot Autofix prepared a fix for the issue found in the latest run.

• ✅ Fixed: Misleading fields when config absent
  • Replaced the misleading RelayDeployError (with hardcoded missingFields and 'deploy_outcome' source) with a descriptive Console.log warning that includes the deploy result, and an early return instead of failing.

Or push these changes by commenting:

@cursor push 3ca08d9395

Preview (3ca08d9395)

diff --git a/infra/relay/scripts/deploy.ts b/infra/relay/scripts/deploy.ts--- a/infra/relay/scripts/deploy.ts+++ b/infra/relay/scripts/deploy.ts@@ -223,15 +223,13 @@
const writeGithubEnvFile = Effect.fn("relay.deploy.writeGithubEnvFile")(function* (
outcome: RelayDeployOutcome,
outputPath: string,
- stage: string,+ _stage: string,
) {
if (Option.isNone(outcome.publicConfig)) {
- return yield* new RelayDeployError({- source: "deploy_outcome",- stage,- outputPath,- missingFields: ["clientTracingUrl", "clientTracingDataset", "clientTracingToken"],- });+ yield* Console.log(+ `Skipping github env file: relay public client config is unavailable (deploy result: ${outcome.result})`,+ );+ return;
}
const fs = yield* FileSystem.FileSystem;
yield* Console.log(`::add-mask::${outcome.publicConfig.value.clientTracingToken}`);

_{You can send follow-ups to the cloud agent here.}

^{Reviewed by Cursor Bugbot for commit 5ad2cf8. Configure here.}

[macroscopeapp]

Approvability

Verdict: Approved

This PR refactors error handling in relay deploy scripts to provide more structured error messages with explicit source, stage, and missing field information. Changes are limited to deployment infrastructure tooling with good test coverage.

No code changes detected at 0897348. Prior analysis still applies.

^{You can customize Macroscope's approvability policy. Learn more.}

Dismissing prior approval to re-evaluate 72a5a9d

[juliusmarminge]

Summary

• replace the message-only deploy error with a Schema error carrying source, stage, output path, and missing fields
• report exact missing Alchemy output fields for state reads and applies
• reuse the parsed deploy output so validation and public config construction cannot drift

Validation

• vp test infra/relay/scripts/deploy.test.ts --no-cache
• vp check
• vp run typecheck
• vpr typecheck

Overlap audit

• no active service/error-refactor PR overlaps these files; feat(relay): enforce resource limits #2925 is an unrelated broad feature branch

---

Note

Low Risk
Changes are limited to the relay deploy script’s error types and output validation; behavior on success is unchanged aside from stricter rejection of empty config values.

Overview
Relay deploy failures now surface structured errors instead of generic message strings, so CI and operators can see where output broke (Alchemy state vs apply), the stage, and which public config fields are missing.

RelayDeployError moves from Data.TaggedError to Effect Schema tagged errors with source, stage, and missingFields, plus a derived message listing missing fields. A separate RelayDeployPublicConfigUnavailableError covers cases like dry-run or cancel when --github-env-file is set but no public config exists (includes result, stage, outputPath).

Public config parsing is centralized: missingRelayPublicConfigFields, shared value extraction, and publicConfigFromOutput now treat empty strings as incomplete and reuse the same path for state reads and apply output—replacing duplicated inline field checks after deploy.

^{Reviewed by Cursor Bugbot for commit 0897348. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Structure relay deploy output errors with typed fields and distinct error classes

• Replaces Data.TaggedError-based RelayDeployError with a Schema.TaggedErrorClass carrying structured source, stage, and missingFields properties, with a deterministic message listing missing public config fields.
• Adds RelayDeployPublicConfigUnavailableError, a new error class thrown by writeGithubEnvFile when public config is absent, including result, stage, and outputPath context.
• Adds missingRelayPublicConfigFields and hasCompleteRelayPublicConfigValues helpers to validate required deploy output fields; publicConfigFromOutput now rejects empty strings and handles Redacted values consistently.
• Propagates stage through writeGithubEnvFile and runRelayDeploy so all error paths include stage context.

^{Macroscope summarized 0897348.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 83912001-ac1d-44e7-8e0d-4cae6302386d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/relay-deploy-errors

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[cursor]

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Bugbot Autofix prepared a fix for the issue found in the latest run.

• ✅ Fixed: Misleading fields when config absent
  • Replaced the misleading RelayDeployError (with hardcoded missingFields and 'deploy_outcome' source) with a descriptive Console.log warning that includes the deploy result, and an early return instead of failing.

Or push these changes by commenting:

@cursor push 3ca08d9395

Preview (3ca08d9395)

diff --git a/infra/relay/scripts/deploy.ts b/infra/relay/scripts/deploy.ts--- a/infra/relay/scripts/deploy.ts+++ b/infra/relay/scripts/deploy.ts@@ -223,15 +223,13 @@
const writeGithubEnvFile = Effect.fn("relay.deploy.writeGithubEnvFile")(function* (
outcome: RelayDeployOutcome,
outputPath: string,
- stage: string,+ _stage: string,
) {
if (Option.isNone(outcome.publicConfig)) {
- return yield* new RelayDeployError({- source: "deploy_outcome",- stage,- outputPath,- missingFields: ["clientTracingUrl", "clientTracingDataset", "clientTracingToken"],- });+ yield* Console.log(+ `Skipping github env file: relay public client config is unavailable (deploy result: ${outcome.result})`,+ );+ return;
}
const fs = yield* FileSystem.FileSystem;
yield* Console.log(`::add-mask::${outcome.publicConfig.value.clientTracingToken}`);

_{You can send follow-ups to the cloud agent here.}

^{Reviewed by Cursor Bugbot for commit 5ad2cf8. Configure here.}

[macroscopeapp]

Approvability

Verdict: Approved

This PR refactors error handling in relay deploy scripts to provide more structured error messages with explicit source, stage, and missing field information. Changes are limited to deployment infrastructure tooling with good test coverage.

No code changes detected at 0897348. Prior analysis still applies.

^{You can customize Macroscope's approvability policy. Learn more.}

Dismissing prior approval to re-evaluate 72a5a9d

[juliusmarminge]

Summary

• replace the message-only deploy error with a Schema error carrying source, stage, output path, and missing fields
• report exact missing Alchemy output fields for state reads and applies
• reuse the parsed deploy output so validation and public config construction cannot drift

Validation

• vp test infra/relay/scripts/deploy.test.ts --no-cache
• vp check
• vp run typecheck
• vpr typecheck

Overlap audit

• no active service/error-refactor PR overlaps these files; feat(relay): enforce resource limits #2925 is an unrelated broad feature branch

---

Note

Low Risk
Changes are limited to the relay deploy script’s error types and output validation; behavior on success is unchanged aside from stricter rejection of empty config values.

Overview
Relay deploy failures now surface structured errors instead of generic message strings, so CI and operators can see where output broke (Alchemy state vs apply), the stage, and which public config fields are missing.

RelayDeployError moves from Data.TaggedError to Effect Schema tagged errors with source, stage, and missingFields, plus a derived message listing missing fields. A separate RelayDeployPublicConfigUnavailableError covers cases like dry-run or cancel when --github-env-file is set but no public config exists (includes result, stage, outputPath).

Public config parsing is centralized: missingRelayPublicConfigFields, shared value extraction, and publicConfigFromOutput now treat empty strings as incomplete and reuse the same path for state reads and apply output—replacing duplicated inline field checks after deploy.

^{Reviewed by Cursor Bugbot for commit 0897348. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Structure relay deploy output errors with typed fields and distinct error classes

• Replaces Data.TaggedError-based RelayDeployError with a Schema.TaggedErrorClass carrying structured source, stage, and missingFields properties, with a deterministic message listing missing public config fields.
• Adds RelayDeployPublicConfigUnavailableError, a new error class thrown by writeGithubEnvFile when public config is absent, including result, stage, and outputPath context.
• Adds missingRelayPublicConfigFields and hasCompleteRelayPublicConfigValues helpers to validate required deploy output fields; publicConfigFromOutput now rejects empty strings and handles Redacted values consistently.
• Propagates stage through writeGithubEnvFile and runRelayDeploy so all error paths include stage context.

^{Macroscope summarized 0897348.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 83912001-ac1d-44e7-8e0d-4cae6302386d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/relay-deploy-errors

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[cursor]

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Bugbot Autofix prepared a fix for the issue found in the latest run.

• ✅ Fixed: Misleading fields when config absent
  • Replaced the misleading RelayDeployError (with hardcoded missingFields and 'deploy_outcome' source) with a descriptive Console.log warning that includes the deploy result, and an early return instead of failing.

Or push these changes by commenting:

@cursor push 3ca08d9395

Preview (3ca08d9395)

diff --git a/infra/relay/scripts/deploy.ts b/infra/relay/scripts/deploy.ts--- a/infra/relay/scripts/deploy.ts+++ b/infra/relay/scripts/deploy.ts@@ -223,15 +223,13 @@
const writeGithubEnvFile = Effect.fn("relay.deploy.writeGithubEnvFile")(function* (
outcome: RelayDeployOutcome,
outputPath: string,
- stage: string,+ _stage: string,
) {
if (Option.isNone(outcome.publicConfig)) {
- return yield* new RelayDeployError({- source: "deploy_outcome",- stage,- outputPath,- missingFields: ["clientTracingUrl", "clientTracingDataset", "clientTracingToken"],- });+ yield* Console.log(+ `Skipping github env file: relay public client config is unavailable (deploy result: ${outcome.result})`,+ );+ return;
}
const fs = yield* FileSystem.FileSystem;
yield* Console.log(`::add-mask::${outcome.publicConfig.value.clientTracingToken}`);

_{You can send follow-ups to the cloud agent here.}

^{Reviewed by Cursor Bugbot for commit 5ad2cf8. Configure here.}

[macroscopeapp]

Approvability

Verdict: Approved

This PR refactors error handling in relay deploy scripts to provide more structured error messages with explicit source, stage, and missing field information. Changes are limited to deployment infrastructure tooling with good test coverage.

No code changes detected at 0897348. Prior analysis still applies.

^{You can customize Macroscope's approvability policy. Learn more.}

Dismissing prior approval to re-evaluate 72a5a9d