[codex] Preserve mobile composer input failures

[juliusmarminge]

Summary

• replace image-picker, clipboard, and pasted-file failures with a structured operation error
• preserve the exact upstream cause while retaining only URI protocol and input length for pasted-image diagnostics
• keep existing friendly fallback messages, per-file recovery, and temporary-file cleanup behavior
• cover file-path and query-token redaction in structured warning payloads

Stack dependency

• Based on [codex] Share safe URL diagnostics #3403 for @t3tools/shared/urlDiagnostics.

Validation

• vp test run apps/mobile/src/lib/composerImages.test.ts (4 tests)
• vp check (passes with 20 pre-existing warnings)
• vp run typecheck
• vp run lint:mobile

---

Note

Low Risk
Observability and error-shaping only; user-visible success/fallback behavior is largely unchanged aside from fixed messages on picker/clipboard load failure instead of upstream error.message.

Overview
Mobile composer image flows now use a ComposerImageOperationError tagged error (operation, optional URI length/protocol, preserved cause) instead of generic errors or logging raw pasted-image URIs.

Image picker, clipboard, and pasted-file paths wrap dynamic imports and async steps in this error type; load failures still return the same user-facing fallback strings but console.warn with structured payloads. Pasted-image diagnostics use getUrlDiagnostics (new @t3tools/shared/urlDiagnostics export) so logs keep protocol and length only—paths and query tokens stay out of warnings.

Shared also adds redactDpopRequestTarget for safe DPoP URL logging (scheme/host/port/path, no credentials/query/fragment), with tests; it is not wired into composer code in this PR.

A new test asserts read failures emit structured warnings without sensitive URI fragments in the error object or string form.

^{Reviewed by Cursor Bugbot for commit 3f2c845. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Preserve structured error context for mobile composer image input failures

• Adds ComposerImageOperationError, a tagged error class in composerImages.ts with fields for operation name, URI length, and URI protocol — without exposing the raw URI.
• Replaces generic Error throws and raw URI logging in pickComposerImages, pasteComposerClipboard, and convertPastedImagesToAttachments with structured ComposerImageOperationError instances.
• Adds a describeComposerImageUri helper to extract safe URI diagnostics (length and protocol) for use in error construction.
• Adds a test verifying that pasted image read failures log a structured error and do not leak sensitive URI tokens.
• Behavioral Change: import failures for the image picker and clipboard now log a warning and return a generic user-facing error string instead of propagating the raw error message.

^{Macroscope summarized 3f2c845.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 4c6a5e49-4871-4422-9480-889678927878

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/mobile-composer-image-errors

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[macroscopeapp]

Approvability

Verdict: Approved

This PR improves error handling observability by adding structured error types with sanitized diagnostics. User-facing behavior is unchanged - error messages remain the same generic strings. Test coverage verifies sensitive URI content (tokens) is not exposed in error context.

^{You can customize Macroscope's approvability policy. Learn more.}

Dismissing prior approval to re-evaluate 405993e

[juliusmarminge]

Summary

• replace image-picker, clipboard, and pasted-file failures with a structured operation error
• preserve the exact upstream cause while retaining only URI protocol and input length for pasted-image diagnostics
• keep existing friendly fallback messages, per-file recovery, and temporary-file cleanup behavior
• cover file-path and query-token redaction in structured warning payloads

Stack dependency

• Based on [codex] Share safe URL diagnostics #3403 for @t3tools/shared/urlDiagnostics.

Validation

• vp test run apps/mobile/src/lib/composerImages.test.ts (4 tests)
• vp check (passes with 20 pre-existing warnings)
• vp run typecheck
• vp run lint:mobile

---

Note

Low Risk
Observability and error-shaping only; user-visible success/fallback behavior is largely unchanged aside from fixed messages on picker/clipboard load failure instead of upstream error.message.

Overview
Mobile composer image flows now use a ComposerImageOperationError tagged error (operation, optional URI length/protocol, preserved cause) instead of generic errors or logging raw pasted-image URIs.

Image picker, clipboard, and pasted-file paths wrap dynamic imports and async steps in this error type; load failures still return the same user-facing fallback strings but console.warn with structured payloads. Pasted-image diagnostics use getUrlDiagnostics (new @t3tools/shared/urlDiagnostics export) so logs keep protocol and length only—paths and query tokens stay out of warnings.

Shared also adds redactDpopRequestTarget for safe DPoP URL logging (scheme/host/port/path, no credentials/query/fragment), with tests; it is not wired into composer code in this PR.

A new test asserts read failures emit structured warnings without sensitive URI fragments in the error object or string form.

^{Reviewed by Cursor Bugbot for commit 3f2c845. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Preserve structured error context for mobile composer image input failures

• Adds ComposerImageOperationError, a tagged error class in composerImages.ts with fields for operation name, URI length, and URI protocol — without exposing the raw URI.
• Replaces generic Error throws and raw URI logging in pickComposerImages, pasteComposerClipboard, and convertPastedImagesToAttachments with structured ComposerImageOperationError instances.
• Adds a describeComposerImageUri helper to extract safe URI diagnostics (length and protocol) for use in error construction.
• Adds a test verifying that pasted image read failures log a structured error and do not leak sensitive URI tokens.
• Behavioral Change: import failures for the image picker and clipboard now log a warning and return a generic user-facing error string instead of propagating the raw error message.

^{Macroscope summarized 3f2c845.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 4c6a5e49-4871-4422-9480-889678927878

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/mobile-composer-image-errors

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[macroscopeapp]

Approvability

Verdict: Approved

This PR improves error handling observability by adding structured error types with sanitized diagnostics. User-facing behavior is unchanged - error messages remain the same generic strings. Test coverage verifies sensitive URI content (tokens) is not exposed in error context.

^{You can customize Macroscope's approvability policy. Learn more.}

Dismissing prior approval to re-evaluate 405993e

[juliusmarminge]

Summary

• replace image-picker, clipboard, and pasted-file failures with a structured operation error
• preserve the exact upstream cause while retaining only URI protocol and input length for pasted-image diagnostics
• keep existing friendly fallback messages, per-file recovery, and temporary-file cleanup behavior
• cover file-path and query-token redaction in structured warning payloads

Stack dependency

• Based on [codex] Share safe URL diagnostics #3403 for @t3tools/shared/urlDiagnostics.

Validation

• vp test run apps/mobile/src/lib/composerImages.test.ts (4 tests)
• vp check (passes with 20 pre-existing warnings)
• vp run typecheck
• vp run lint:mobile

---

Note

Low Risk
Observability and error-shaping only; user-visible success/fallback behavior is largely unchanged aside from fixed messages on picker/clipboard load failure instead of upstream error.message.

Overview
Mobile composer image flows now use a ComposerImageOperationError tagged error (operation, optional URI length/protocol, preserved cause) instead of generic errors or logging raw pasted-image URIs.

Image picker, clipboard, and pasted-file paths wrap dynamic imports and async steps in this error type; load failures still return the same user-facing fallback strings but console.warn with structured payloads. Pasted-image diagnostics use getUrlDiagnostics (new @t3tools/shared/urlDiagnostics export) so logs keep protocol and length only—paths and query tokens stay out of warnings.

Shared also adds redactDpopRequestTarget for safe DPoP URL logging (scheme/host/port/path, no credentials/query/fragment), with tests; it is not wired into composer code in this PR.

A new test asserts read failures emit structured warnings without sensitive URI fragments in the error object or string form.

^{Reviewed by Cursor Bugbot for commit 3f2c845. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Preserve structured error context for mobile composer image input failures

• Adds ComposerImageOperationError, a tagged error class in composerImages.ts with fields for operation name, URI length, and URI protocol — without exposing the raw URI.
• Replaces generic Error throws and raw URI logging in pickComposerImages, pasteComposerClipboard, and convertPastedImagesToAttachments with structured ComposerImageOperationError instances.
• Adds a describeComposerImageUri helper to extract safe URI diagnostics (length and protocol) for use in error construction.
• Adds a test verifying that pasted image read failures log a structured error and do not leak sensitive URI tokens.
• Behavioral Change: import failures for the image picker and clipboard now log a warning and return a generic user-facing error string instead of propagating the raw error message.

^{Macroscope summarized 3f2c845.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 4c6a5e49-4871-4422-9480-889678927878

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/mobile-composer-image-errors

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[macroscopeapp]

Approvability

Verdict: Approved

This PR improves error handling observability by adding structured error types with sanitized diagnostics. User-facing behavior is unchanged - error messages remain the same generic strings. Test coverage verifies sensitive URI content (tokens) is not exposed in error context.

^{You can customize Macroscope's approvability policy. Learn more.}

Dismissing prior approval to re-evaluate 405993e

[juliusmarminge]

Summary

• replace image-picker, clipboard, and pasted-file failures with a structured operation error
• preserve the exact upstream cause while retaining only URI protocol and input length for pasted-image diagnostics
• keep existing friendly fallback messages, per-file recovery, and temporary-file cleanup behavior
• cover file-path and query-token redaction in structured warning payloads

Stack dependency

• Based on [codex] Share safe URL diagnostics #3403 for @t3tools/shared/urlDiagnostics.

Validation

• vp test run apps/mobile/src/lib/composerImages.test.ts (4 tests)
• vp check (passes with 20 pre-existing warnings)
• vp run typecheck
• vp run lint:mobile

---

Note

Low Risk
Observability and error-shaping only; user-visible success/fallback behavior is largely unchanged aside from fixed messages on picker/clipboard load failure instead of upstream error.message.

Overview
Mobile composer image flows now use a ComposerImageOperationError tagged error (operation, optional URI length/protocol, preserved cause) instead of generic errors or logging raw pasted-image URIs.

Image picker, clipboard, and pasted-file paths wrap dynamic imports and async steps in this error type; load failures still return the same user-facing fallback strings but console.warn with structured payloads. Pasted-image diagnostics use getUrlDiagnostics (new @t3tools/shared/urlDiagnostics export) so logs keep protocol and length only—paths and query tokens stay out of warnings.

Shared also adds redactDpopRequestTarget for safe DPoP URL logging (scheme/host/port/path, no credentials/query/fragment), with tests; it is not wired into composer code in this PR.

A new test asserts read failures emit structured warnings without sensitive URI fragments in the error object or string form.

^{Reviewed by Cursor Bugbot for commit 3f2c845. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Preserve structured error context for mobile composer image input failures

• Adds ComposerImageOperationError, a tagged error class in composerImages.ts with fields for operation name, URI length, and URI protocol — without exposing the raw URI.
• Replaces generic Error throws and raw URI logging in pickComposerImages, pasteComposerClipboard, and convertPastedImagesToAttachments with structured ComposerImageOperationError instances.
• Adds a describeComposerImageUri helper to extract safe URI diagnostics (length and protocol) for use in error construction.
• Adds a test verifying that pasted image read failures log a structured error and do not leak sensitive URI tokens.
• Behavioral Change: import failures for the image picker and clipboard now log a warning and return a generic user-facing error string instead of propagating the raw error message.

^{Macroscope summarized 3f2c845.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 4c6a5e49-4871-4422-9480-889678927878

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/mobile-composer-image-errors

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[macroscopeapp]

Approvability

Verdict: Approved

This PR improves error handling observability by adding structured error types with sanitized diagnostics. User-facing behavior is unchanged - error messages remain the same generic strings. Test coverage verifies sensitive URI content (tokens) is not exposed in error context.

^{You can customize Macroscope's approvability policy. Learn more.}

Dismissing prior approval to re-evaluate 405993e

[juliusmarminge]

Summary

• replace image-picker, clipboard, and pasted-file failures with a structured operation error
• preserve the exact upstream cause while retaining only URI protocol and input length for pasted-image diagnostics
• keep existing friendly fallback messages, per-file recovery, and temporary-file cleanup behavior
• cover file-path and query-token redaction in structured warning payloads

Stack dependency

• Based on [codex] Share safe URL diagnostics #3403 for @t3tools/shared/urlDiagnostics.

Validation

• vp test run apps/mobile/src/lib/composerImages.test.ts (4 tests)
• vp check (passes with 20 pre-existing warnings)
• vp run typecheck
• vp run lint:mobile

---

Note

Low Risk
Observability and error-shaping only; user-visible success/fallback behavior is largely unchanged aside from fixed messages on picker/clipboard load failure instead of upstream error.message.

Overview
Mobile composer image flows now use a ComposerImageOperationError tagged error (operation, optional URI length/protocol, preserved cause) instead of generic errors or logging raw pasted-image URIs.

Image picker, clipboard, and pasted-file paths wrap dynamic imports and async steps in this error type; load failures still return the same user-facing fallback strings but console.warn with structured payloads. Pasted-image diagnostics use getUrlDiagnostics (new @t3tools/shared/urlDiagnostics export) so logs keep protocol and length only—paths and query tokens stay out of warnings.

Shared also adds redactDpopRequestTarget for safe DPoP URL logging (scheme/host/port/path, no credentials/query/fragment), with tests; it is not wired into composer code in this PR.

A new test asserts read failures emit structured warnings without sensitive URI fragments in the error object or string form.

^{Reviewed by Cursor Bugbot for commit 3f2c845. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Preserve structured error context for mobile composer image input failures

• Adds ComposerImageOperationError, a tagged error class in composerImages.ts with fields for operation name, URI length, and URI protocol — without exposing the raw URI.
• Replaces generic Error throws and raw URI logging in pickComposerImages, pasteComposerClipboard, and convertPastedImagesToAttachments with structured ComposerImageOperationError instances.
• Adds a describeComposerImageUri helper to extract safe URI diagnostics (length and protocol) for use in error construction.
• Adds a test verifying that pasted image read failures log a structured error and do not leak sensitive URI tokens.
• Behavioral Change: import failures for the image picker and clipboard now log a warning and return a generic user-facing error string instead of propagating the raw error message.

^{Macroscope summarized 3f2c845.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 4c6a5e49-4871-4422-9480-889678927878

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/mobile-composer-image-errors

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[macroscopeapp]

Approvability

Verdict: Approved

This PR improves error handling observability by adding structured error types with sanitized diagnostics. User-facing behavior is unchanged - error messages remain the same generic strings. Test coverage verifies sensitive URI content (tokens) is not exposed in error context.

^{You can customize Macroscope's approvability policy. Learn more.}

Dismissing prior approval to re-evaluate 405993e

[juliusmarminge]

Summary

• replace image-picker, clipboard, and pasted-file failures with a structured operation error
• preserve the exact upstream cause while retaining only URI protocol and input length for pasted-image diagnostics
• keep existing friendly fallback messages, per-file recovery, and temporary-file cleanup behavior
• cover file-path and query-token redaction in structured warning payloads

Stack dependency

• Based on [codex] Share safe URL diagnostics #3403 for @t3tools/shared/urlDiagnostics.

Validation

• vp test run apps/mobile/src/lib/composerImages.test.ts (4 tests)
• vp check (passes with 20 pre-existing warnings)
• vp run typecheck
• vp run lint:mobile

---

Note

Low Risk
Observability and error-shaping only; user-visible success/fallback behavior is largely unchanged aside from fixed messages on picker/clipboard load failure instead of upstream error.message.

Overview
Mobile composer image flows now use a ComposerImageOperationError tagged error (operation, optional URI length/protocol, preserved cause) instead of generic errors or logging raw pasted-image URIs.

Image picker, clipboard, and pasted-file paths wrap dynamic imports and async steps in this error type; load failures still return the same user-facing fallback strings but console.warn with structured payloads. Pasted-image diagnostics use getUrlDiagnostics (new @t3tools/shared/urlDiagnostics export) so logs keep protocol and length only—paths and query tokens stay out of warnings.

Shared also adds redactDpopRequestTarget for safe DPoP URL logging (scheme/host/port/path, no credentials/query/fragment), with tests; it is not wired into composer code in this PR.

A new test asserts read failures emit structured warnings without sensitive URI fragments in the error object or string form.

^{Reviewed by Cursor Bugbot for commit 3f2c845. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Preserve structured error context for mobile composer image input failures

• Adds ComposerImageOperationError, a tagged error class in composerImages.ts with fields for operation name, URI length, and URI protocol — without exposing the raw URI.
• Replaces generic Error throws and raw URI logging in pickComposerImages, pasteComposerClipboard, and convertPastedImagesToAttachments with structured ComposerImageOperationError instances.
• Adds a describeComposerImageUri helper to extract safe URI diagnostics (length and protocol) for use in error construction.
• Adds a test verifying that pasted image read failures log a structured error and do not leak sensitive URI tokens.
• Behavioral Change: import failures for the image picker and clipboard now log a warning and return a generic user-facing error string instead of propagating the raw error message.

^{Macroscope summarized 3f2c845.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 4c6a5e49-4871-4422-9480-889678927878

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/mobile-composer-image-errors

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[macroscopeapp]

Approvability

Verdict: Approved

This PR improves error handling observability by adding structured error types with sanitized diagnostics. User-facing behavior is unchanged - error messages remain the same generic strings. Test coverage verifies sensitive URI content (tokens) is not exposed in error context.

^{You can customize Macroscope's approvability policy. Learn more.}

Dismissing prior approval to re-evaluate 405993e

[juliusmarminge]

Summary

• replace image-picker, clipboard, and pasted-file failures with a structured operation error
• preserve the exact upstream cause while retaining only URI protocol and input length for pasted-image diagnostics
• keep existing friendly fallback messages, per-file recovery, and temporary-file cleanup behavior
• cover file-path and query-token redaction in structured warning payloads

Stack dependency

• Based on [codex] Share safe URL diagnostics #3403 for @t3tools/shared/urlDiagnostics.

Validation

• vp test run apps/mobile/src/lib/composerImages.test.ts (4 tests)
• vp check (passes with 20 pre-existing warnings)
• vp run typecheck
• vp run lint:mobile

---

Note

Low Risk
Observability and error-shaping only; user-visible success/fallback behavior is largely unchanged aside from fixed messages on picker/clipboard load failure instead of upstream error.message.

Overview
Mobile composer image flows now use a ComposerImageOperationError tagged error (operation, optional URI length/protocol, preserved cause) instead of generic errors or logging raw pasted-image URIs.

Image picker, clipboard, and pasted-file paths wrap dynamic imports and async steps in this error type; load failures still return the same user-facing fallback strings but console.warn with structured payloads. Pasted-image diagnostics use getUrlDiagnostics (new @t3tools/shared/urlDiagnostics export) so logs keep protocol and length only—paths and query tokens stay out of warnings.

Shared also adds redactDpopRequestTarget for safe DPoP URL logging (scheme/host/port/path, no credentials/query/fragment), with tests; it is not wired into composer code in this PR.

A new test asserts read failures emit structured warnings without sensitive URI fragments in the error object or string form.

^{Reviewed by Cursor Bugbot for commit 3f2c845. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Preserve structured error context for mobile composer image input failures

• Adds ComposerImageOperationError, a tagged error class in composerImages.ts with fields for operation name, URI length, and URI protocol — without exposing the raw URI.
• Replaces generic Error throws and raw URI logging in pickComposerImages, pasteComposerClipboard, and convertPastedImagesToAttachments with structured ComposerImageOperationError instances.
• Adds a describeComposerImageUri helper to extract safe URI diagnostics (length and protocol) for use in error construction.
• Adds a test verifying that pasted image read failures log a structured error and do not leak sensitive URI tokens.
• Behavioral Change: import failures for the image picker and clipboard now log a warning and return a generic user-facing error string instead of propagating the raw error message.

^{Macroscope summarized 3f2c845.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 4c6a5e49-4871-4422-9480-889678927878

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/mobile-composer-image-errors

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[macroscopeapp]

Approvability

Verdict: Approved

This PR improves error handling observability by adding structured error types with sanitized diagnostics. User-facing behavior is unchanged - error messages remain the same generic strings. Test coverage verifies sensitive URI content (tokens) is not exposed in error context.

^{You can customize Macroscope's approvability policy. Learn more.}

Dismissing prior approval to re-evaluate 405993e

[juliusmarminge]

Summary

• replace image-picker, clipboard, and pasted-file failures with a structured operation error
• preserve the exact upstream cause while retaining only URI protocol and input length for pasted-image diagnostics
• keep existing friendly fallback messages, per-file recovery, and temporary-file cleanup behavior
• cover file-path and query-token redaction in structured warning payloads

Stack dependency

• Based on [codex] Share safe URL diagnostics #3403 for @t3tools/shared/urlDiagnostics.

Validation

• vp test run apps/mobile/src/lib/composerImages.test.ts (4 tests)
• vp check (passes with 20 pre-existing warnings)
• vp run typecheck
• vp run lint:mobile

---

Note

Low Risk
Observability and error-shaping only; user-visible success/fallback behavior is largely unchanged aside from fixed messages on picker/clipboard load failure instead of upstream error.message.

Overview
Mobile composer image flows now use a ComposerImageOperationError tagged error (operation, optional URI length/protocol, preserved cause) instead of generic errors or logging raw pasted-image URIs.

Image picker, clipboard, and pasted-file paths wrap dynamic imports and async steps in this error type; load failures still return the same user-facing fallback strings but console.warn with structured payloads. Pasted-image diagnostics use getUrlDiagnostics (new @t3tools/shared/urlDiagnostics export) so logs keep protocol and length only—paths and query tokens stay out of warnings.

Shared also adds redactDpopRequestTarget for safe DPoP URL logging (scheme/host/port/path, no credentials/query/fragment), with tests; it is not wired into composer code in this PR.

A new test asserts read failures emit structured warnings without sensitive URI fragments in the error object or string form.

^{Reviewed by Cursor Bugbot for commit 3f2c845. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Preserve structured error context for mobile composer image input failures

• Adds ComposerImageOperationError, a tagged error class in composerImages.ts with fields for operation name, URI length, and URI protocol — without exposing the raw URI.
• Replaces generic Error throws and raw URI logging in pickComposerImages, pasteComposerClipboard, and convertPastedImagesToAttachments with structured ComposerImageOperationError instances.
• Adds a describeComposerImageUri helper to extract safe URI diagnostics (length and protocol) for use in error construction.
• Adds a test verifying that pasted image read failures log a structured error and do not leak sensitive URI tokens.
• Behavioral Change: import failures for the image picker and clipboard now log a warning and return a generic user-facing error string instead of propagating the raw error message.

^{Macroscope summarized 3f2c845.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 4c6a5e49-4871-4422-9480-889678927878

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/mobile-composer-image-errors

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[macroscopeapp]

Approvability

Verdict: Approved

This PR improves error handling observability by adding structured error types with sanitized diagnostics. User-facing behavior is unchanged - error messages remain the same generic strings. Test coverage verifies sensitive URI content (tokens) is not exposed in error context.

^{You can customize Macroscope's approvability policy. Learn more.}

Dismissing prior approval to re-evaluate 405993e