[codex] Structure relay device persistence errors

[juliusmarminge]

Summary

• attach user and device identifiers to relay device persistence failures
• identify the exact registration or unregistration database stage that failed
• preserve the original database cause and derive messages from structured fields
• cover registration, unregistration, and list failure diagnostics

Validation

• vp test infra/relay/src/agentActivity/Devices.test.ts --no-cache
• vp check
• vp run typecheck
• vpr typecheck

Overlap audit

No active error/service refactor touches these files. The only exact-file overlaps are older broad draft feature PRs #2925 and #3135.

---

Note

Low Risk
Observability and error-shape changes only; persistence behavior is unchanged aside from dropping explicit concurrency on parallel claim/delete steps.

Overview
Relay mobile device persistence failures now carry structured context (userId, deviceId, and a stage label) instead of a generic message plus cause.

Registration errors tag which step failed: claim-push-token, claim-push-to-start-token, or upsert-device. Unregistration errors distinguish delete-live-activity vs delete-device. List failures include userId. Each DB step uses its own Effect.mapError instead of one wrapper on the whole register/unregister/listForUser effect, so the reported stage matches the failing operation. Error messages are derived from those fields.

Tests assert stage, identifiers, preserved cause, and message text for register, unregister, and list failures.

^{Reviewed by Cursor Bugbot for commit 142db89. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Structure relay device persistence errors with userId, deviceId, and stage context

• Expands DeviceRegistrationPersistenceError, DeviceUnregistrationPersistenceError, and DeviceListPersistenceError in Devices.ts to carry userId, deviceId, stage, and cause fields, and updates their message getters to include these values.
• Refactors Devices.register, Devices.unregister, and Devices.listForUser to map errors at each individual database operation stage (e.g. 'claim-push-token', 'delete-live-activity') rather than wrapping the whole pipeline.
• Removes explicit { concurrency: 2 } from Effect.all calls in register and unregister, leaving only { discard: true }.
• Adds tests in Devices.test.ts that verify each error class carries the correct fields and stage when the underlying database call fails.

^{Macroscope summarized 142db89.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: fd4eebba-aaf0-42d5-a584-d3007ce2ebdf

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/relay-device-persistence-errors

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[cursor]

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Bugbot Autofix prepared a fix for the issue found in the latest run.

• ✅ Fixed: Parallel failures hide other failed stages
  • Removed concurrency: 2 from both Effect.all calls so paired DB writes run sequentially, ensuring only one stage can fail at a time and the reported stage is always deterministic.

Or push these changes by commenting:

@cursor push 4868945fd1

Preview (4868945fd1)

diff --git a/infra/relay/src/agentActivity/Devices.ts b/infra/relay/src/agentActivity/Devices.ts--- a/infra/relay/src/agentActivity/Devices.ts+++ b/infra/relay/src/agentActivity/Devices.ts@@ -118,7 +118,7 @@
)
: Effect.void,
],
- { concurrency: 2, discard: true },+ { discard: true },
);
yield* db
@@ -209,7 +209,7 @@
),
),
],
- { concurrency: 2, discard: true },+ { discard: true },
);
}),
listForUser: Effect.fn("relay.devices.listForUser")(function* (input) {

_{You can send follow-ups to the cloud agent here.}

^{Reviewed by Cursor Bugbot for commit 4c423f9. Configure here.}

[macroscopeapp]

Approvability

Verdict: Approved

This PR adds structured fields (userId, deviceId, stage) to existing persistence error classes for better debugging context. The core database operations remain unchanged - only error messages and error mapping locations are modified, with corresponding test coverage added.

^{You can customize Macroscope's approvability policy. Learn more.}

Dismissing prior approval to re-evaluate 142db89

[juliusmarminge]

Summary

• attach user and device identifiers to relay device persistence failures
• identify the exact registration or unregistration database stage that failed
• preserve the original database cause and derive messages from structured fields
• cover registration, unregistration, and list failure diagnostics

Validation

• vp test infra/relay/src/agentActivity/Devices.test.ts --no-cache
• vp check
• vp run typecheck
• vpr typecheck

Overlap audit

No active error/service refactor touches these files. The only exact-file overlaps are older broad draft feature PRs #2925 and #3135.

---

Note

Low Risk
Observability and error-shape changes only; persistence behavior is unchanged aside from dropping explicit concurrency on parallel claim/delete steps.

Overview
Relay mobile device persistence failures now carry structured context (userId, deviceId, and a stage label) instead of a generic message plus cause.

Registration errors tag which step failed: claim-push-token, claim-push-to-start-token, or upsert-device. Unregistration errors distinguish delete-live-activity vs delete-device. List failures include userId. Each DB step uses its own Effect.mapError instead of one wrapper on the whole register/unregister/listForUser effect, so the reported stage matches the failing operation. Error messages are derived from those fields.

Tests assert stage, identifiers, preserved cause, and message text for register, unregister, and list failures.

^{Reviewed by Cursor Bugbot for commit 142db89. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Structure relay device persistence errors with userId, deviceId, and stage context

• Expands DeviceRegistrationPersistenceError, DeviceUnregistrationPersistenceError, and DeviceListPersistenceError in Devices.ts to carry userId, deviceId, stage, and cause fields, and updates their message getters to include these values.
• Refactors Devices.register, Devices.unregister, and Devices.listForUser to map errors at each individual database operation stage (e.g. 'claim-push-token', 'delete-live-activity') rather than wrapping the whole pipeline.
• Removes explicit { concurrency: 2 } from Effect.all calls in register and unregister, leaving only { discard: true }.
• Adds tests in Devices.test.ts that verify each error class carries the correct fields and stage when the underlying database call fails.

^{Macroscope summarized 142db89.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: fd4eebba-aaf0-42d5-a584-d3007ce2ebdf

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/relay-device-persistence-errors

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[cursor]

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Bugbot Autofix prepared a fix for the issue found in the latest run.

• ✅ Fixed: Parallel failures hide other failed stages
  • Removed concurrency: 2 from both Effect.all calls so paired DB writes run sequentially, ensuring only one stage can fail at a time and the reported stage is always deterministic.

Or push these changes by commenting:

@cursor push 4868945fd1

Preview (4868945fd1)

diff --git a/infra/relay/src/agentActivity/Devices.ts b/infra/relay/src/agentActivity/Devices.ts--- a/infra/relay/src/agentActivity/Devices.ts+++ b/infra/relay/src/agentActivity/Devices.ts@@ -118,7 +118,7 @@
)
: Effect.void,
],
- { concurrency: 2, discard: true },+ { discard: true },
);
yield* db
@@ -209,7 +209,7 @@
),
),
],
- { concurrency: 2, discard: true },+ { discard: true },
);
}),
listForUser: Effect.fn("relay.devices.listForUser")(function* (input) {

_{You can send follow-ups to the cloud agent here.}

^{Reviewed by Cursor Bugbot for commit 4c423f9. Configure here.}

[macroscopeapp]

Approvability

Verdict: Approved

This PR adds structured fields (userId, deviceId, stage) to existing persistence error classes for better debugging context. The core database operations remain unchanged - only error messages and error mapping locations are modified, with corresponding test coverage added.

^{You can customize Macroscope's approvability policy. Learn more.}

Dismissing prior approval to re-evaluate 142db89

[juliusmarminge]

Summary

• attach user and device identifiers to relay device persistence failures
• identify the exact registration or unregistration database stage that failed
• preserve the original database cause and derive messages from structured fields
• cover registration, unregistration, and list failure diagnostics

Validation

• vp test infra/relay/src/agentActivity/Devices.test.ts --no-cache
• vp check
• vp run typecheck
• vpr typecheck

Overlap audit

No active error/service refactor touches these files. The only exact-file overlaps are older broad draft feature PRs #2925 and #3135.

---

Note

Low Risk
Observability and error-shape changes only; persistence behavior is unchanged aside from dropping explicit concurrency on parallel claim/delete steps.

Overview
Relay mobile device persistence failures now carry structured context (userId, deviceId, and a stage label) instead of a generic message plus cause.

Registration errors tag which step failed: claim-push-token, claim-push-to-start-token, or upsert-device. Unregistration errors distinguish delete-live-activity vs delete-device. List failures include userId. Each DB step uses its own Effect.mapError instead of one wrapper on the whole register/unregister/listForUser effect, so the reported stage matches the failing operation. Error messages are derived from those fields.

Tests assert stage, identifiers, preserved cause, and message text for register, unregister, and list failures.

^{Reviewed by Cursor Bugbot for commit 142db89. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Structure relay device persistence errors with userId, deviceId, and stage context

• Expands DeviceRegistrationPersistenceError, DeviceUnregistrationPersistenceError, and DeviceListPersistenceError in Devices.ts to carry userId, deviceId, stage, and cause fields, and updates their message getters to include these values.
• Refactors Devices.register, Devices.unregister, and Devices.listForUser to map errors at each individual database operation stage (e.g. 'claim-push-token', 'delete-live-activity') rather than wrapping the whole pipeline.
• Removes explicit { concurrency: 2 } from Effect.all calls in register and unregister, leaving only { discard: true }.
• Adds tests in Devices.test.ts that verify each error class carries the correct fields and stage when the underlying database call fails.

^{Macroscope summarized 142db89.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: fd4eebba-aaf0-42d5-a584-d3007ce2ebdf

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/relay-device-persistence-errors

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[cursor]

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Bugbot Autofix prepared a fix for the issue found in the latest run.

• ✅ Fixed: Parallel failures hide other failed stages
  • Removed concurrency: 2 from both Effect.all calls so paired DB writes run sequentially, ensuring only one stage can fail at a time and the reported stage is always deterministic.

Or push these changes by commenting:

@cursor push 4868945fd1

Preview (4868945fd1)

diff --git a/infra/relay/src/agentActivity/Devices.ts b/infra/relay/src/agentActivity/Devices.ts--- a/infra/relay/src/agentActivity/Devices.ts+++ b/infra/relay/src/agentActivity/Devices.ts@@ -118,7 +118,7 @@
)
: Effect.void,
],
- { concurrency: 2, discard: true },+ { discard: true },
);
yield* db
@@ -209,7 +209,7 @@
),
),
],
- { concurrency: 2, discard: true },+ { discard: true },
);
}),
listForUser: Effect.fn("relay.devices.listForUser")(function* (input) {

_{You can send follow-ups to the cloud agent here.}

^{Reviewed by Cursor Bugbot for commit 4c423f9. Configure here.}

[macroscopeapp]

Approvability

Verdict: Approved

This PR adds structured fields (userId, deviceId, stage) to existing persistence error classes for better debugging context. The core database operations remain unchanged - only error messages and error mapping locations are modified, with corresponding test coverage added.

^{You can customize Macroscope's approvability policy. Learn more.}

Dismissing prior approval to re-evaluate 142db89

[juliusmarminge]

Summary

• attach user and device identifiers to relay device persistence failures
• identify the exact registration or unregistration database stage that failed
• preserve the original database cause and derive messages from structured fields
• cover registration, unregistration, and list failure diagnostics

Validation

• vp test infra/relay/src/agentActivity/Devices.test.ts --no-cache
• vp check
• vp run typecheck
• vpr typecheck

Overlap audit

No active error/service refactor touches these files. The only exact-file overlaps are older broad draft feature PRs #2925 and #3135.

---

Note

Low Risk
Observability and error-shape changes only; persistence behavior is unchanged aside from dropping explicit concurrency on parallel claim/delete steps.

Overview
Relay mobile device persistence failures now carry structured context (userId, deviceId, and a stage label) instead of a generic message plus cause.

Registration errors tag which step failed: claim-push-token, claim-push-to-start-token, or upsert-device. Unregistration errors distinguish delete-live-activity vs delete-device. List failures include userId. Each DB step uses its own Effect.mapError instead of one wrapper on the whole register/unregister/listForUser effect, so the reported stage matches the failing operation. Error messages are derived from those fields.

Tests assert stage, identifiers, preserved cause, and message text for register, unregister, and list failures.

^{Reviewed by Cursor Bugbot for commit 142db89. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Structure relay device persistence errors with userId, deviceId, and stage context

• Expands DeviceRegistrationPersistenceError, DeviceUnregistrationPersistenceError, and DeviceListPersistenceError in Devices.ts to carry userId, deviceId, stage, and cause fields, and updates their message getters to include these values.
• Refactors Devices.register, Devices.unregister, and Devices.listForUser to map errors at each individual database operation stage (e.g. 'claim-push-token', 'delete-live-activity') rather than wrapping the whole pipeline.
• Removes explicit { concurrency: 2 } from Effect.all calls in register and unregister, leaving only { discard: true }.
• Adds tests in Devices.test.ts that verify each error class carries the correct fields and stage when the underlying database call fails.

^{Macroscope summarized 142db89.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: fd4eebba-aaf0-42d5-a584-d3007ce2ebdf

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/relay-device-persistence-errors

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[cursor]

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Bugbot Autofix prepared a fix for the issue found in the latest run.

• ✅ Fixed: Parallel failures hide other failed stages
  • Removed concurrency: 2 from both Effect.all calls so paired DB writes run sequentially, ensuring only one stage can fail at a time and the reported stage is always deterministic.

Or push these changes by commenting:

@cursor push 4868945fd1

Preview (4868945fd1)

diff --git a/infra/relay/src/agentActivity/Devices.ts b/infra/relay/src/agentActivity/Devices.ts--- a/infra/relay/src/agentActivity/Devices.ts+++ b/infra/relay/src/agentActivity/Devices.ts@@ -118,7 +118,7 @@
)
: Effect.void,
],
- { concurrency: 2, discard: true },+ { discard: true },
);
yield* db
@@ -209,7 +209,7 @@
),
),
],
- { concurrency: 2, discard: true },+ { discard: true },
);
}),
listForUser: Effect.fn("relay.devices.listForUser")(function* (input) {

_{You can send follow-ups to the cloud agent here.}

^{Reviewed by Cursor Bugbot for commit 4c423f9. Configure here.}

[macroscopeapp]

Approvability

Verdict: Approved

This PR adds structured fields (userId, deviceId, stage) to existing persistence error classes for better debugging context. The core database operations remain unchanged - only error messages and error mapping locations are modified, with corresponding test coverage added.

^{You can customize Macroscope's approvability policy. Learn more.}

Dismissing prior approval to re-evaluate 142db89

[juliusmarminge]

Summary

• attach user and device identifiers to relay device persistence failures
• identify the exact registration or unregistration database stage that failed
• preserve the original database cause and derive messages from structured fields
• cover registration, unregistration, and list failure diagnostics

Validation

• vp test infra/relay/src/agentActivity/Devices.test.ts --no-cache
• vp check
• vp run typecheck
• vpr typecheck

Overlap audit

No active error/service refactor touches these files. The only exact-file overlaps are older broad draft feature PRs #2925 and #3135.

---

Note

Low Risk
Observability and error-shape changes only; persistence behavior is unchanged aside from dropping explicit concurrency on parallel claim/delete steps.

Overview
Relay mobile device persistence failures now carry structured context (userId, deviceId, and a stage label) instead of a generic message plus cause.

Registration errors tag which step failed: claim-push-token, claim-push-to-start-token, or upsert-device. Unregistration errors distinguish delete-live-activity vs delete-device. List failures include userId. Each DB step uses its own Effect.mapError instead of one wrapper on the whole register/unregister/listForUser effect, so the reported stage matches the failing operation. Error messages are derived from those fields.

Tests assert stage, identifiers, preserved cause, and message text for register, unregister, and list failures.

^{Reviewed by Cursor Bugbot for commit 142db89. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Structure relay device persistence errors with userId, deviceId, and stage context

• Expands DeviceRegistrationPersistenceError, DeviceUnregistrationPersistenceError, and DeviceListPersistenceError in Devices.ts to carry userId, deviceId, stage, and cause fields, and updates their message getters to include these values.
• Refactors Devices.register, Devices.unregister, and Devices.listForUser to map errors at each individual database operation stage (e.g. 'claim-push-token', 'delete-live-activity') rather than wrapping the whole pipeline.
• Removes explicit { concurrency: 2 } from Effect.all calls in register and unregister, leaving only { discard: true }.
• Adds tests in Devices.test.ts that verify each error class carries the correct fields and stage when the underlying database call fails.

^{Macroscope summarized 142db89.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: fd4eebba-aaf0-42d5-a584-d3007ce2ebdf

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/relay-device-persistence-errors

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[cursor]

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Bugbot Autofix prepared a fix for the issue found in the latest run.

• ✅ Fixed: Parallel failures hide other failed stages
  • Removed concurrency: 2 from both Effect.all calls so paired DB writes run sequentially, ensuring only one stage can fail at a time and the reported stage is always deterministic.

Or push these changes by commenting:

@cursor push 4868945fd1

Preview (4868945fd1)

diff --git a/infra/relay/src/agentActivity/Devices.ts b/infra/relay/src/agentActivity/Devices.ts--- a/infra/relay/src/agentActivity/Devices.ts+++ b/infra/relay/src/agentActivity/Devices.ts@@ -118,7 +118,7 @@
)
: Effect.void,
],
- { concurrency: 2, discard: true },+ { discard: true },
);
yield* db
@@ -209,7 +209,7 @@
),
),
],
- { concurrency: 2, discard: true },+ { discard: true },
);
}),
listForUser: Effect.fn("relay.devices.listForUser")(function* (input) {

_{You can send follow-ups to the cloud agent here.}

^{Reviewed by Cursor Bugbot for commit 4c423f9. Configure here.}

[macroscopeapp]

Approvability

Verdict: Approved

This PR adds structured fields (userId, deviceId, stage) to existing persistence error classes for better debugging context. The core database operations remain unchanged - only error messages and error mapping locations are modified, with corresponding test coverage added.

^{You can customize Macroscope's approvability policy. Learn more.}

Dismissing prior approval to re-evaluate 142db89

[juliusmarminge]

Summary

• attach user and device identifiers to relay device persistence failures
• identify the exact registration or unregistration database stage that failed
• preserve the original database cause and derive messages from structured fields
• cover registration, unregistration, and list failure diagnostics

Validation

• vp test infra/relay/src/agentActivity/Devices.test.ts --no-cache
• vp check
• vp run typecheck
• vpr typecheck

Overlap audit

No active error/service refactor touches these files. The only exact-file overlaps are older broad draft feature PRs #2925 and #3135.

---

Note

Low Risk
Observability and error-shape changes only; persistence behavior is unchanged aside from dropping explicit concurrency on parallel claim/delete steps.

Overview
Relay mobile device persistence failures now carry structured context (userId, deviceId, and a stage label) instead of a generic message plus cause.

Registration errors tag which step failed: claim-push-token, claim-push-to-start-token, or upsert-device. Unregistration errors distinguish delete-live-activity vs delete-device. List failures include userId. Each DB step uses its own Effect.mapError instead of one wrapper on the whole register/unregister/listForUser effect, so the reported stage matches the failing operation. Error messages are derived from those fields.

Tests assert stage, identifiers, preserved cause, and message text for register, unregister, and list failures.

^{Reviewed by Cursor Bugbot for commit 142db89. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Structure relay device persistence errors with userId, deviceId, and stage context

• Expands DeviceRegistrationPersistenceError, DeviceUnregistrationPersistenceError, and DeviceListPersistenceError in Devices.ts to carry userId, deviceId, stage, and cause fields, and updates their message getters to include these values.
• Refactors Devices.register, Devices.unregister, and Devices.listForUser to map errors at each individual database operation stage (e.g. 'claim-push-token', 'delete-live-activity') rather than wrapping the whole pipeline.
• Removes explicit { concurrency: 2 } from Effect.all calls in register and unregister, leaving only { discard: true }.
• Adds tests in Devices.test.ts that verify each error class carries the correct fields and stage when the underlying database call fails.

^{Macroscope summarized 142db89.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: fd4eebba-aaf0-42d5-a584-d3007ce2ebdf

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/relay-device-persistence-errors

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[cursor]

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Bugbot Autofix prepared a fix for the issue found in the latest run.

• ✅ Fixed: Parallel failures hide other failed stages
  • Removed concurrency: 2 from both Effect.all calls so paired DB writes run sequentially, ensuring only one stage can fail at a time and the reported stage is always deterministic.

Or push these changes by commenting:

@cursor push 4868945fd1

Preview (4868945fd1)

diff --git a/infra/relay/src/agentActivity/Devices.ts b/infra/relay/src/agentActivity/Devices.ts--- a/infra/relay/src/agentActivity/Devices.ts+++ b/infra/relay/src/agentActivity/Devices.ts@@ -118,7 +118,7 @@
)
: Effect.void,
],
- { concurrency: 2, discard: true },+ { discard: true },
);
yield* db
@@ -209,7 +209,7 @@
),
),
],
- { concurrency: 2, discard: true },+ { discard: true },
);
}),
listForUser: Effect.fn("relay.devices.listForUser")(function* (input) {

_{You can send follow-ups to the cloud agent here.}

^{Reviewed by Cursor Bugbot for commit 4c423f9. Configure here.}

[macroscopeapp]

Approvability

Verdict: Approved

This PR adds structured fields (userId, deviceId, stage) to existing persistence error classes for better debugging context. The core database operations remain unchanged - only error messages and error mapping locations are modified, with corresponding test coverage added.

^{You can customize Macroscope's approvability policy. Learn more.}

Dismissing prior approval to re-evaluate 142db89

[juliusmarminge]

Summary

• attach user and device identifiers to relay device persistence failures
• identify the exact registration or unregistration database stage that failed
• preserve the original database cause and derive messages from structured fields
• cover registration, unregistration, and list failure diagnostics

Validation

• vp test infra/relay/src/agentActivity/Devices.test.ts --no-cache
• vp check
• vp run typecheck
• vpr typecheck

Overlap audit

No active error/service refactor touches these files. The only exact-file overlaps are older broad draft feature PRs #2925 and #3135.

---

Note

Low Risk
Observability and error-shape changes only; persistence behavior is unchanged aside from dropping explicit concurrency on parallel claim/delete steps.

Overview
Relay mobile device persistence failures now carry structured context (userId, deviceId, and a stage label) instead of a generic message plus cause.

Registration errors tag which step failed: claim-push-token, claim-push-to-start-token, or upsert-device. Unregistration errors distinguish delete-live-activity vs delete-device. List failures include userId. Each DB step uses its own Effect.mapError instead of one wrapper on the whole register/unregister/listForUser effect, so the reported stage matches the failing operation. Error messages are derived from those fields.

Tests assert stage, identifiers, preserved cause, and message text for register, unregister, and list failures.

^{Reviewed by Cursor Bugbot for commit 142db89. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Structure relay device persistence errors with userId, deviceId, and stage context

• Expands DeviceRegistrationPersistenceError, DeviceUnregistrationPersistenceError, and DeviceListPersistenceError in Devices.ts to carry userId, deviceId, stage, and cause fields, and updates their message getters to include these values.
• Refactors Devices.register, Devices.unregister, and Devices.listForUser to map errors at each individual database operation stage (e.g. 'claim-push-token', 'delete-live-activity') rather than wrapping the whole pipeline.
• Removes explicit { concurrency: 2 } from Effect.all calls in register and unregister, leaving only { discard: true }.
• Adds tests in Devices.test.ts that verify each error class carries the correct fields and stage when the underlying database call fails.

^{Macroscope summarized 142db89.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: fd4eebba-aaf0-42d5-a584-d3007ce2ebdf

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/relay-device-persistence-errors

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[cursor]

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Bugbot Autofix prepared a fix for the issue found in the latest run.

• ✅ Fixed: Parallel failures hide other failed stages
  • Removed concurrency: 2 from both Effect.all calls so paired DB writes run sequentially, ensuring only one stage can fail at a time and the reported stage is always deterministic.

Or push these changes by commenting:

@cursor push 4868945fd1

Preview (4868945fd1)

diff --git a/infra/relay/src/agentActivity/Devices.ts b/infra/relay/src/agentActivity/Devices.ts--- a/infra/relay/src/agentActivity/Devices.ts+++ b/infra/relay/src/agentActivity/Devices.ts@@ -118,7 +118,7 @@
)
: Effect.void,
],
- { concurrency: 2, discard: true },+ { discard: true },
);
yield* db
@@ -209,7 +209,7 @@
),
),
],
- { concurrency: 2, discard: true },+ { discard: true },
);
}),
listForUser: Effect.fn("relay.devices.listForUser")(function* (input) {

_{You can send follow-ups to the cloud agent here.}

^{Reviewed by Cursor Bugbot for commit 4c423f9. Configure here.}

[macroscopeapp]

Approvability

Verdict: Approved

This PR adds structured fields (userId, deviceId, stage) to existing persistence error classes for better debugging context. The core database operations remain unchanged - only error messages and error mapping locations are modified, with corresponding test coverage added.

^{You can customize Macroscope's approvability policy. Learn more.}

Dismissing prior approval to re-evaluate 142db89

[juliusmarminge]

Summary

• attach user and device identifiers to relay device persistence failures
• identify the exact registration or unregistration database stage that failed
• preserve the original database cause and derive messages from structured fields
• cover registration, unregistration, and list failure diagnostics

Validation

• vp test infra/relay/src/agentActivity/Devices.test.ts --no-cache
• vp check
• vp run typecheck
• vpr typecheck

Overlap audit

No active error/service refactor touches these files. The only exact-file overlaps are older broad draft feature PRs #2925 and #3135.

---

Note

Low Risk
Observability and error-shape changes only; persistence behavior is unchanged aside from dropping explicit concurrency on parallel claim/delete steps.

Overview
Relay mobile device persistence failures now carry structured context (userId, deviceId, and a stage label) instead of a generic message plus cause.

Registration errors tag which step failed: claim-push-token, claim-push-to-start-token, or upsert-device. Unregistration errors distinguish delete-live-activity vs delete-device. List failures include userId. Each DB step uses its own Effect.mapError instead of one wrapper on the whole register/unregister/listForUser effect, so the reported stage matches the failing operation. Error messages are derived from those fields.

Tests assert stage, identifiers, preserved cause, and message text for register, unregister, and list failures.

^{Reviewed by Cursor Bugbot for commit 142db89. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Structure relay device persistence errors with userId, deviceId, and stage context

• Expands DeviceRegistrationPersistenceError, DeviceUnregistrationPersistenceError, and DeviceListPersistenceError in Devices.ts to carry userId, deviceId, stage, and cause fields, and updates their message getters to include these values.
• Refactors Devices.register, Devices.unregister, and Devices.listForUser to map errors at each individual database operation stage (e.g. 'claim-push-token', 'delete-live-activity') rather than wrapping the whole pipeline.
• Removes explicit { concurrency: 2 } from Effect.all calls in register and unregister, leaving only { discard: true }.
• Adds tests in Devices.test.ts that verify each error class carries the correct fields and stage when the underlying database call fails.

^{Macroscope summarized 142db89.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: fd4eebba-aaf0-42d5-a584-d3007ce2ebdf

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/relay-device-persistence-errors

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[cursor]

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Bugbot Autofix prepared a fix for the issue found in the latest run.

• ✅ Fixed: Parallel failures hide other failed stages
  • Removed concurrency: 2 from both Effect.all calls so paired DB writes run sequentially, ensuring only one stage can fail at a time and the reported stage is always deterministic.

Or push these changes by commenting:

@cursor push 4868945fd1

Preview (4868945fd1)

diff --git a/infra/relay/src/agentActivity/Devices.ts b/infra/relay/src/agentActivity/Devices.ts--- a/infra/relay/src/agentActivity/Devices.ts+++ b/infra/relay/src/agentActivity/Devices.ts@@ -118,7 +118,7 @@
)
: Effect.void,
],
- { concurrency: 2, discard: true },+ { discard: true },
);
yield* db
@@ -209,7 +209,7 @@
),
),
],
- { concurrency: 2, discard: true },+ { discard: true },
);
}),
listForUser: Effect.fn("relay.devices.listForUser")(function* (input) {

_{You can send follow-ups to the cloud agent here.}

^{Reviewed by Cursor Bugbot for commit 4c423f9. Configure here.}

[macroscopeapp]

Approvability

Verdict: Approved

This PR adds structured fields (userId, deviceId, stage) to existing persistence error classes for better debugging context. The core database operations remain unchanged - only error messages and error mapping locations are modified, with corresponding test coverage added.

^{You can customize Macroscope's approvability policy. Learn more.}

Dismissing prior approval to re-evaluate 142db89