[codex] Structure Codex schema generator errors

[juliusmarminge]

Summary

• replace the generator's free-form error and generic throws with structured Schema errors
• retain fetch, decode, and process causes while attaching URLs, repository paths, resolution candidates, commands, and exit codes
• cover fetch/decode/formatter failure boundaries with focused tests

Validation

• vp test packages/effect-codex-app-server/scripts/generate.test.ts --no-cache
• vp check (passes with pre-existing warnings)
• vp run typecheck
• vpr typecheck

Overlap audit

No current open PR touches either changed path, including previous filenames.

---

Note

Low Risk
Dev-time codegen script refactor with tests; no runtime app behavior change beyond safer import of generate.ts.

Overview
Replaces the Codex schema generator’s single GeneratorError and ad-hoc throw new Error paths with Effect Schema.TaggedErrorClass types (fetch, directory/schema decode, formatter spawn/exit, generated declaration parsing, type and external-ref resolution). Network-related failures attach redacted URL diagnostics via @t3tools/sharedgetUrlDiagnostics (length, protocol, hostname—no raw URLs or secrets in messages).

Exported helpers (fetchText, fetchDirectoryEntries, decodeSchemaDocument, formatGeneratedFiles, collectSchemaEntries) so failures can be tested in isolation; formatGeneratedFiles centralizes vp fmt and maps nonzero exits to structured errors. Schema JSON handling threads repositoryPath into decode errors.

generateFiles only runs when executed as the script (if (import.meta.main)), so importing generate.ts no longer triggers generation. Adds generate.test.ts covering safe fetch diagnostics, decode context, formatter exit codes, and malformed generator output.

^{Reviewed by Cursor Bugbot for commit c9cb0c3. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Structure Codex schema generator errors into typed, sanitized error classes

• Replaces the single generic GeneratorError in generate.ts with distinct tagged error classes for each failure mode: fetch, directory decode, schema decode, format process/exit, missing declarations, name parse, type resolution, and external reference resolution.
• Each error class captures sanitized, structured fields (e.g. URL diagnostics without raw URLs, command args count, exit code, line index) instead of raw error messages.
• Refactors fetchText, fetchDirectoryEntries, decodeSchemaDocument, formatGeneratedFiles, and collectSchemaEntries into exported Effect.fn functions that propagate typed failures.
• Adds a comprehensive test suite in generate.test.ts covering error behavior for all new error classes using custom HTTP and process test doubles.
• Wraps the CLI entrypoint in an import.meta.main guard so importing the module no longer triggers generation.

^{Macroscope summarized c9cb0c3.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 4fbb68c5-0eef-4958-a57d-e56371b844eb

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/codex-generator-errors

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[macroscopeapp]

Approvability

Verdict: Approved

This PR refactors error handling in the Codex schema generator by replacing a generic error class with multiple specific typed error classes, adds URL sanitization for security, and includes comprehensive tests. The changes are structural improvements to error reporting without altering the generator's core behavior.

^{You can customize Macroscope's approvability policy. Learn more.}

Dismissing prior approval to re-evaluate 1a4e059

Dismissing prior approval to re-evaluate a31eb6f

Dismissing prior approval to re-evaluate c9cb0c3

[juliusmarminge]

Summary

• replace the generator's free-form error and generic throws with structured Schema errors
• retain fetch, decode, and process causes while attaching URLs, repository paths, resolution candidates, commands, and exit codes
• cover fetch/decode/formatter failure boundaries with focused tests

Validation

• vp test packages/effect-codex-app-server/scripts/generate.test.ts --no-cache
• vp check (passes with pre-existing warnings)
• vp run typecheck
• vpr typecheck

Overlap audit

No current open PR touches either changed path, including previous filenames.

---

Note

Low Risk
Dev-time codegen script refactor with tests; no runtime app behavior change beyond safer import of generate.ts.

Overview
Replaces the Codex schema generator’s single GeneratorError and ad-hoc throw new Error paths with Effect Schema.TaggedErrorClass types (fetch, directory/schema decode, formatter spawn/exit, generated declaration parsing, type and external-ref resolution). Network-related failures attach redacted URL diagnostics via @t3tools/sharedgetUrlDiagnostics (length, protocol, hostname—no raw URLs or secrets in messages).

Exported helpers (fetchText, fetchDirectoryEntries, decodeSchemaDocument, formatGeneratedFiles, collectSchemaEntries) so failures can be tested in isolation; formatGeneratedFiles centralizes vp fmt and maps nonzero exits to structured errors. Schema JSON handling threads repositoryPath into decode errors.

generateFiles only runs when executed as the script (if (import.meta.main)), so importing generate.ts no longer triggers generation. Adds generate.test.ts covering safe fetch diagnostics, decode context, formatter exit codes, and malformed generator output.

^{Reviewed by Cursor Bugbot for commit c9cb0c3. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Structure Codex schema generator errors into typed, sanitized error classes

• Replaces the single generic GeneratorError in generate.ts with distinct tagged error classes for each failure mode: fetch, directory decode, schema decode, format process/exit, missing declarations, name parse, type resolution, and external reference resolution.
• Each error class captures sanitized, structured fields (e.g. URL diagnostics without raw URLs, command args count, exit code, line index) instead of raw error messages.
• Refactors fetchText, fetchDirectoryEntries, decodeSchemaDocument, formatGeneratedFiles, and collectSchemaEntries into exported Effect.fn functions that propagate typed failures.
• Adds a comprehensive test suite in generate.test.ts covering error behavior for all new error classes using custom HTTP and process test doubles.
• Wraps the CLI entrypoint in an import.meta.main guard so importing the module no longer triggers generation.

^{Macroscope summarized c9cb0c3.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 4fbb68c5-0eef-4958-a57d-e56371b844eb

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/codex-generator-errors

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[macroscopeapp]

Approvability

Verdict: Approved

This PR refactors error handling in the Codex schema generator by replacing a generic error class with multiple specific typed error classes, adds URL sanitization for security, and includes comprehensive tests. The changes are structural improvements to error reporting without altering the generator's core behavior.

^{You can customize Macroscope's approvability policy. Learn more.}

Dismissing prior approval to re-evaluate 1a4e059

Dismissing prior approval to re-evaluate a31eb6f

Dismissing prior approval to re-evaluate c9cb0c3

[juliusmarminge]

Summary

• replace the generator's free-form error and generic throws with structured Schema errors
• retain fetch, decode, and process causes while attaching URLs, repository paths, resolution candidates, commands, and exit codes
• cover fetch/decode/formatter failure boundaries with focused tests

Validation

• vp test packages/effect-codex-app-server/scripts/generate.test.ts --no-cache
• vp check (passes with pre-existing warnings)
• vp run typecheck
• vpr typecheck

Overlap audit

No current open PR touches either changed path, including previous filenames.

---

Note

Low Risk
Dev-time codegen script refactor with tests; no runtime app behavior change beyond safer import of generate.ts.

Overview
Replaces the Codex schema generator’s single GeneratorError and ad-hoc throw new Error paths with Effect Schema.TaggedErrorClass types (fetch, directory/schema decode, formatter spawn/exit, generated declaration parsing, type and external-ref resolution). Network-related failures attach redacted URL diagnostics via @t3tools/sharedgetUrlDiagnostics (length, protocol, hostname—no raw URLs or secrets in messages).

Exported helpers (fetchText, fetchDirectoryEntries, decodeSchemaDocument, formatGeneratedFiles, collectSchemaEntries) so failures can be tested in isolation; formatGeneratedFiles centralizes vp fmt and maps nonzero exits to structured errors. Schema JSON handling threads repositoryPath into decode errors.

generateFiles only runs when executed as the script (if (import.meta.main)), so importing generate.ts no longer triggers generation. Adds generate.test.ts covering safe fetch diagnostics, decode context, formatter exit codes, and malformed generator output.

^{Reviewed by Cursor Bugbot for commit c9cb0c3. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Structure Codex schema generator errors into typed, sanitized error classes

• Replaces the single generic GeneratorError in generate.ts with distinct tagged error classes for each failure mode: fetch, directory decode, schema decode, format process/exit, missing declarations, name parse, type resolution, and external reference resolution.
• Each error class captures sanitized, structured fields (e.g. URL diagnostics without raw URLs, command args count, exit code, line index) instead of raw error messages.
• Refactors fetchText, fetchDirectoryEntries, decodeSchemaDocument, formatGeneratedFiles, and collectSchemaEntries into exported Effect.fn functions that propagate typed failures.
• Adds a comprehensive test suite in generate.test.ts covering error behavior for all new error classes using custom HTTP and process test doubles.
• Wraps the CLI entrypoint in an import.meta.main guard so importing the module no longer triggers generation.

^{Macroscope summarized c9cb0c3.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 4fbb68c5-0eef-4958-a57d-e56371b844eb

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/codex-generator-errors

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[macroscopeapp]

Approvability

Verdict: Approved

This PR refactors error handling in the Codex schema generator by replacing a generic error class with multiple specific typed error classes, adds URL sanitization for security, and includes comprehensive tests. The changes are structural improvements to error reporting without altering the generator's core behavior.

^{You can customize Macroscope's approvability policy. Learn more.}

Dismissing prior approval to re-evaluate 1a4e059

Dismissing prior approval to re-evaluate a31eb6f

Dismissing prior approval to re-evaluate c9cb0c3

[juliusmarminge]

Summary

• replace the generator's free-form error and generic throws with structured Schema errors
• retain fetch, decode, and process causes while attaching URLs, repository paths, resolution candidates, commands, and exit codes
• cover fetch/decode/formatter failure boundaries with focused tests

Validation

• vp test packages/effect-codex-app-server/scripts/generate.test.ts --no-cache
• vp check (passes with pre-existing warnings)
• vp run typecheck
• vpr typecheck

Overlap audit

No current open PR touches either changed path, including previous filenames.

---

Note

Low Risk
Dev-time codegen script refactor with tests; no runtime app behavior change beyond safer import of generate.ts.

Overview
Replaces the Codex schema generator’s single GeneratorError and ad-hoc throw new Error paths with Effect Schema.TaggedErrorClass types (fetch, directory/schema decode, formatter spawn/exit, generated declaration parsing, type and external-ref resolution). Network-related failures attach redacted URL diagnostics via @t3tools/sharedgetUrlDiagnostics (length, protocol, hostname—no raw URLs or secrets in messages).

Exported helpers (fetchText, fetchDirectoryEntries, decodeSchemaDocument, formatGeneratedFiles, collectSchemaEntries) so failures can be tested in isolation; formatGeneratedFiles centralizes vp fmt and maps nonzero exits to structured errors. Schema JSON handling threads repositoryPath into decode errors.

generateFiles only runs when executed as the script (if (import.meta.main)), so importing generate.ts no longer triggers generation. Adds generate.test.ts covering safe fetch diagnostics, decode context, formatter exit codes, and malformed generator output.

^{Reviewed by Cursor Bugbot for commit c9cb0c3. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Structure Codex schema generator errors into typed, sanitized error classes

• Replaces the single generic GeneratorError in generate.ts with distinct tagged error classes for each failure mode: fetch, directory decode, schema decode, format process/exit, missing declarations, name parse, type resolution, and external reference resolution.
• Each error class captures sanitized, structured fields (e.g. URL diagnostics without raw URLs, command args count, exit code, line index) instead of raw error messages.
• Refactors fetchText, fetchDirectoryEntries, decodeSchemaDocument, formatGeneratedFiles, and collectSchemaEntries into exported Effect.fn functions that propagate typed failures.
• Adds a comprehensive test suite in generate.test.ts covering error behavior for all new error classes using custom HTTP and process test doubles.
• Wraps the CLI entrypoint in an import.meta.main guard so importing the module no longer triggers generation.

^{Macroscope summarized c9cb0c3.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 4fbb68c5-0eef-4958-a57d-e56371b844eb

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/codex-generator-errors

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[macroscopeapp]

Approvability

Verdict: Approved

This PR refactors error handling in the Codex schema generator by replacing a generic error class with multiple specific typed error classes, adds URL sanitization for security, and includes comprehensive tests. The changes are structural improvements to error reporting without altering the generator's core behavior.

^{You can customize Macroscope's approvability policy. Learn more.}

Dismissing prior approval to re-evaluate 1a4e059

Dismissing prior approval to re-evaluate a31eb6f

Dismissing prior approval to re-evaluate c9cb0c3

[juliusmarminge]

Summary

• replace the generator's free-form error and generic throws with structured Schema errors
• retain fetch, decode, and process causes while attaching URLs, repository paths, resolution candidates, commands, and exit codes
• cover fetch/decode/formatter failure boundaries with focused tests

Validation

• vp test packages/effect-codex-app-server/scripts/generate.test.ts --no-cache
• vp check (passes with pre-existing warnings)
• vp run typecheck
• vpr typecheck

Overlap audit

No current open PR touches either changed path, including previous filenames.

---

Note

Low Risk
Dev-time codegen script refactor with tests; no runtime app behavior change beyond safer import of generate.ts.

Overview
Replaces the Codex schema generator’s single GeneratorError and ad-hoc throw new Error paths with Effect Schema.TaggedErrorClass types (fetch, directory/schema decode, formatter spawn/exit, generated declaration parsing, type and external-ref resolution). Network-related failures attach redacted URL diagnostics via @t3tools/sharedgetUrlDiagnostics (length, protocol, hostname—no raw URLs or secrets in messages).

Exported helpers (fetchText, fetchDirectoryEntries, decodeSchemaDocument, formatGeneratedFiles, collectSchemaEntries) so failures can be tested in isolation; formatGeneratedFiles centralizes vp fmt and maps nonzero exits to structured errors. Schema JSON handling threads repositoryPath into decode errors.

generateFiles only runs when executed as the script (if (import.meta.main)), so importing generate.ts no longer triggers generation. Adds generate.test.ts covering safe fetch diagnostics, decode context, formatter exit codes, and malformed generator output.

^{Reviewed by Cursor Bugbot for commit c9cb0c3. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Structure Codex schema generator errors into typed, sanitized error classes

• Replaces the single generic GeneratorError in generate.ts with distinct tagged error classes for each failure mode: fetch, directory decode, schema decode, format process/exit, missing declarations, name parse, type resolution, and external reference resolution.
• Each error class captures sanitized, structured fields (e.g. URL diagnostics without raw URLs, command args count, exit code, line index) instead of raw error messages.
• Refactors fetchText, fetchDirectoryEntries, decodeSchemaDocument, formatGeneratedFiles, and collectSchemaEntries into exported Effect.fn functions that propagate typed failures.
• Adds a comprehensive test suite in generate.test.ts covering error behavior for all new error classes using custom HTTP and process test doubles.
• Wraps the CLI entrypoint in an import.meta.main guard so importing the module no longer triggers generation.

^{Macroscope summarized c9cb0c3.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 4fbb68c5-0eef-4958-a57d-e56371b844eb

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/codex-generator-errors

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[macroscopeapp]

Approvability

Verdict: Approved

This PR refactors error handling in the Codex schema generator by replacing a generic error class with multiple specific typed error classes, adds URL sanitization for security, and includes comprehensive tests. The changes are structural improvements to error reporting without altering the generator's core behavior.

^{You can customize Macroscope's approvability policy. Learn more.}

Dismissing prior approval to re-evaluate 1a4e059

Dismissing prior approval to re-evaluate a31eb6f

Dismissing prior approval to re-evaluate c9cb0c3

[juliusmarminge]

Summary

• replace the generator's free-form error and generic throws with structured Schema errors
• retain fetch, decode, and process causes while attaching URLs, repository paths, resolution candidates, commands, and exit codes
• cover fetch/decode/formatter failure boundaries with focused tests

Validation

• vp test packages/effect-codex-app-server/scripts/generate.test.ts --no-cache
• vp check (passes with pre-existing warnings)
• vp run typecheck
• vpr typecheck

Overlap audit

No current open PR touches either changed path, including previous filenames.

---

Note

Low Risk
Dev-time codegen script refactor with tests; no runtime app behavior change beyond safer import of generate.ts.

Overview
Replaces the Codex schema generator’s single GeneratorError and ad-hoc throw new Error paths with Effect Schema.TaggedErrorClass types (fetch, directory/schema decode, formatter spawn/exit, generated declaration parsing, type and external-ref resolution). Network-related failures attach redacted URL diagnostics via @t3tools/sharedgetUrlDiagnostics (length, protocol, hostname—no raw URLs or secrets in messages).

Exported helpers (fetchText, fetchDirectoryEntries, decodeSchemaDocument, formatGeneratedFiles, collectSchemaEntries) so failures can be tested in isolation; formatGeneratedFiles centralizes vp fmt and maps nonzero exits to structured errors. Schema JSON handling threads repositoryPath into decode errors.

generateFiles only runs when executed as the script (if (import.meta.main)), so importing generate.ts no longer triggers generation. Adds generate.test.ts covering safe fetch diagnostics, decode context, formatter exit codes, and malformed generator output.

^{Reviewed by Cursor Bugbot for commit c9cb0c3. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Structure Codex schema generator errors into typed, sanitized error classes

• Replaces the single generic GeneratorError in generate.ts with distinct tagged error classes for each failure mode: fetch, directory decode, schema decode, format process/exit, missing declarations, name parse, type resolution, and external reference resolution.
• Each error class captures sanitized, structured fields (e.g. URL diagnostics without raw URLs, command args count, exit code, line index) instead of raw error messages.
• Refactors fetchText, fetchDirectoryEntries, decodeSchemaDocument, formatGeneratedFiles, and collectSchemaEntries into exported Effect.fn functions that propagate typed failures.
• Adds a comprehensive test suite in generate.test.ts covering error behavior for all new error classes using custom HTTP and process test doubles.
• Wraps the CLI entrypoint in an import.meta.main guard so importing the module no longer triggers generation.

^{Macroscope summarized c9cb0c3.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 4fbb68c5-0eef-4958-a57d-e56371b844eb

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/codex-generator-errors

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[macroscopeapp]

Approvability

Verdict: Approved

This PR refactors error handling in the Codex schema generator by replacing a generic error class with multiple specific typed error classes, adds URL sanitization for security, and includes comprehensive tests. The changes are structural improvements to error reporting without altering the generator's core behavior.

^{You can customize Macroscope's approvability policy. Learn more.}

Dismissing prior approval to re-evaluate 1a4e059

Dismissing prior approval to re-evaluate a31eb6f

Dismissing prior approval to re-evaluate c9cb0c3

[juliusmarminge]

Summary

• replace the generator's free-form error and generic throws with structured Schema errors
• retain fetch, decode, and process causes while attaching URLs, repository paths, resolution candidates, commands, and exit codes
• cover fetch/decode/formatter failure boundaries with focused tests

Validation

• vp test packages/effect-codex-app-server/scripts/generate.test.ts --no-cache
• vp check (passes with pre-existing warnings)
• vp run typecheck
• vpr typecheck

Overlap audit

No current open PR touches either changed path, including previous filenames.

---

Note

Low Risk
Dev-time codegen script refactor with tests; no runtime app behavior change beyond safer import of generate.ts.

Overview
Replaces the Codex schema generator’s single GeneratorError and ad-hoc throw new Error paths with Effect Schema.TaggedErrorClass types (fetch, directory/schema decode, formatter spawn/exit, generated declaration parsing, type and external-ref resolution). Network-related failures attach redacted URL diagnostics via @t3tools/sharedgetUrlDiagnostics (length, protocol, hostname—no raw URLs or secrets in messages).

Exported helpers (fetchText, fetchDirectoryEntries, decodeSchemaDocument, formatGeneratedFiles, collectSchemaEntries) so failures can be tested in isolation; formatGeneratedFiles centralizes vp fmt and maps nonzero exits to structured errors. Schema JSON handling threads repositoryPath into decode errors.

generateFiles only runs when executed as the script (if (import.meta.main)), so importing generate.ts no longer triggers generation. Adds generate.test.ts covering safe fetch diagnostics, decode context, formatter exit codes, and malformed generator output.

^{Reviewed by Cursor Bugbot for commit c9cb0c3. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Structure Codex schema generator errors into typed, sanitized error classes

• Replaces the single generic GeneratorError in generate.ts with distinct tagged error classes for each failure mode: fetch, directory decode, schema decode, format process/exit, missing declarations, name parse, type resolution, and external reference resolution.
• Each error class captures sanitized, structured fields (e.g. URL diagnostics without raw URLs, command args count, exit code, line index) instead of raw error messages.
• Refactors fetchText, fetchDirectoryEntries, decodeSchemaDocument, formatGeneratedFiles, and collectSchemaEntries into exported Effect.fn functions that propagate typed failures.
• Adds a comprehensive test suite in generate.test.ts covering error behavior for all new error classes using custom HTTP and process test doubles.
• Wraps the CLI entrypoint in an import.meta.main guard so importing the module no longer triggers generation.

^{Macroscope summarized c9cb0c3.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 4fbb68c5-0eef-4958-a57d-e56371b844eb

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/codex-generator-errors

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[macroscopeapp]

Approvability

Verdict: Approved

This PR refactors error handling in the Codex schema generator by replacing a generic error class with multiple specific typed error classes, adds URL sanitization for security, and includes comprehensive tests. The changes are structural improvements to error reporting without altering the generator's core behavior.

^{You can customize Macroscope's approvability policy. Learn more.}

Dismissing prior approval to re-evaluate 1a4e059

Dismissing prior approval to re-evaluate a31eb6f

Dismissing prior approval to re-evaluate c9cb0c3

[juliusmarminge]

Summary

• replace the generator's free-form error and generic throws with structured Schema errors
• retain fetch, decode, and process causes while attaching URLs, repository paths, resolution candidates, commands, and exit codes
• cover fetch/decode/formatter failure boundaries with focused tests

Validation

• vp test packages/effect-codex-app-server/scripts/generate.test.ts --no-cache
• vp check (passes with pre-existing warnings)
• vp run typecheck
• vpr typecheck

Overlap audit

No current open PR touches either changed path, including previous filenames.

---

Note

Low Risk
Dev-time codegen script refactor with tests; no runtime app behavior change beyond safer import of generate.ts.

Overview
Replaces the Codex schema generator’s single GeneratorError and ad-hoc throw new Error paths with Effect Schema.TaggedErrorClass types (fetch, directory/schema decode, formatter spawn/exit, generated declaration parsing, type and external-ref resolution). Network-related failures attach redacted URL diagnostics via @t3tools/sharedgetUrlDiagnostics (length, protocol, hostname—no raw URLs or secrets in messages).

Exported helpers (fetchText, fetchDirectoryEntries, decodeSchemaDocument, formatGeneratedFiles, collectSchemaEntries) so failures can be tested in isolation; formatGeneratedFiles centralizes vp fmt and maps nonzero exits to structured errors. Schema JSON handling threads repositoryPath into decode errors.

generateFiles only runs when executed as the script (if (import.meta.main)), so importing generate.ts no longer triggers generation. Adds generate.test.ts covering safe fetch diagnostics, decode context, formatter exit codes, and malformed generator output.

^{Reviewed by Cursor Bugbot for commit c9cb0c3. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Structure Codex schema generator errors into typed, sanitized error classes

• Replaces the single generic GeneratorError in generate.ts with distinct tagged error classes for each failure mode: fetch, directory decode, schema decode, format process/exit, missing declarations, name parse, type resolution, and external reference resolution.
• Each error class captures sanitized, structured fields (e.g. URL diagnostics without raw URLs, command args count, exit code, line index) instead of raw error messages.
• Refactors fetchText, fetchDirectoryEntries, decodeSchemaDocument, formatGeneratedFiles, and collectSchemaEntries into exported Effect.fn functions that propagate typed failures.
• Adds a comprehensive test suite in generate.test.ts covering error behavior for all new error classes using custom HTTP and process test doubles.
• Wraps the CLI entrypoint in an import.meta.main guard so importing the module no longer triggers generation.

^{Macroscope summarized c9cb0c3.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 4fbb68c5-0eef-4958-a57d-e56371b844eb

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/codex-generator-errors

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[macroscopeapp]

Approvability

Verdict: Approved

This PR refactors error handling in the Codex schema generator by replacing a generic error class with multiple specific typed error classes, adds URL sanitization for security, and includes comprehensive tests. The changes are structural improvements to error reporting without altering the generator's core behavior.

^{You can customize Macroscope's approvability policy. Learn more.}

Dismissing prior approval to re-evaluate 1a4e059

Dismissing prior approval to re-evaluate a31eb6f

Dismissing prior approval to re-evaluate c9cb0c3