[codex] Structure preview asset URL failures - #3399

Merged
juliusmarminge merged 1 commit into
codex/stack-pr-3259from
codex/web-preview-error-context
Jun 21, 2026
Merged

[codex] Structure preview asset URL failures#3399
juliusmarminge merged 1 commit into
codex/stack-pr-3259from
codex/web-preview-error-context

Conversation

@juliusmarminge

@juliusmarmingejuliusmarminge commented Jun 20, 2026•
edited by macroscopeapp Bot
Loading

Copy link
Copy Markdown
Member

Summary

  • replace malformed preview asset URL defects with BrowserPreviewAssetUrlInvalidError
  • preserve the exact URL parser cause for the full failure chain
  • attach safe environment, thread, file, URL-length, and expiry diagnostics; do not store the signed relative URL or raw base URL as direct structured attributes
  • cover cause identity and absence of direct raw URL attributes with a focused regression test

Scope

Stack dependency

Validation

  • pnpm vp test apps/web/src/browser/openFileInPreview.test.ts
  • pnpm vp check
  • pnpm vp run typecheck

Note

Medium Risk
Changes integrated-browser open paths and error typing in chat markdown; invalid asset URLs now fail recoverably instead of dying, with safer diagnostics around signed URLs.

Overview
Preview asset URL construction in openFileInPreview no longer uses resolveAssetUrl or Cause.die when the base/relative URL pair is invalid. It builds the URL with new URL(relative, base) and returns BrowserPreviewAssetUrlInvalidError via Cause.fail, carrying environment/thread/file context, URL lengths and expiry, and the original parser cause—without storing raw base or signed relative URLs.

Browser preview errors are refactored to Effect Schema.TaggedErrorClass types with fixed user-facing messages: BrowserPreviewUnavailableError (runtime unsupported), plus new BrowserPreviewThreadContextUnavailableError and BrowserPreviewEnvironmentDisconnectedError. ChatMarkdown returns these specific failures when opening links or workspace files in the integrated browser instead of overloading BrowserPreviewUnavailableError with ad hoc messages.

Tests in openFileInPreview.test.ts cover the fixed unavailable message, invalid-asset-URL diagnostics, cause identity, and that serialized errors do not leak signed tokens.

Reviewed by Cursor Bugbot for commit 56e0750. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Structure browser preview asset URL failures as typed errors in openFileInPreview

  • Replaces generic defect failures with typed Schema.TaggedErrorClass errors for three new failure cases: missing thread context (BrowserPreviewThreadContextUnavailableError), disconnected environment (BrowserPreviewEnvironmentDisconnectedError), and invalid asset URL (BrowserPreviewAssetUrlInvalidError).
  • BrowserPreviewAssetUrlInvalidError captures safe diagnostic fields (environmentId, threadId, filePath, httpBaseUrlLength, relativeUrlLength, expiresAt) and preserves the original cause, avoiding exposure of sensitive URL contents.
  • Replaces resolveAssetUrl with a new URL(relativeUrl, httpBaseUrl) call wrapped in try/catch; failures are surfaced as BrowserPreviewAssetUrlInvalidError instead of a defect die.
  • Exports isBrowserPreviewAssetUrlInvalidError as a type guard via Schema.is.
  • Behavioral Change: callers of openFileInPreview now receive typed failures for URL construction errors instead of unhandled defects.

Macroscope summarized 56e0750.

@coderabbitai

coderabbitaiBot commented Jun 20, 2026•
edited
Loading

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: c935d6bb-72b9-4e0a-bb44-2ac2ce02b98a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/web-preview-error-context

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:L 100-499 changed lines (additions + deletions). labels Jun 20, 2026
macroscopeapp[bot]
macroscopeappBot previously approved these changes Jun 20, 2026
View reviewed changes
@macroscopeapp

macroscopeappBot commented Jun 20, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved

This PR refactors error handling for browser preview asset URLs, converting to Schema-based error classes with structured context fields while ensuring sensitive data isn't leaked. The changes are limited to error infrastructure with comprehensive test coverage.

You can customize Macroscope's approvability policy. Learn more.

@juliusmarminge
juliusmarmingeforce-pushed the codex/web-preview-error-context branch from 6989347 to 199dc14CompareJune 20, 2026 15:36
@juliusmarmingejuliusmarminge changed the title refactor(web): add structured preview errors[codex] Structure browser preview open failuresJun 20, 2026
@juliusmarminge
juliusmarminge changed the base branch from main to codex/web-markdown-action-errorsJune 20, 2026 15:36
@macroscopeapp
macroscopeappBot dismissed their stale reviewJune 20, 2026 15:36

Dismissing prior approval to re-evaluate 199dc14

macroscopeapp[bot]
macroscopeappBot previously approved these changes Jun 20, 2026
View reviewed changes
@juliusmarminge
juliusmarmingeforce-pushed the codex/web-preview-error-context branch from 199dc14 to c048ffeCompareJune 20, 2026 15:43
@juliusmarminge
juliusmarminge changed the base branch from codex/web-markdown-action-errors to codex/stack-pr-3259June 20, 2026 15:43
@macroscopeapp
macroscopeappBot dismissed their stale reviewJune 20, 2026 15:43

Dismissing prior approval to re-evaluate c048ffe

@github-actionsgithub-actionsBot added size:M 30-99 changed lines (additions + deletions). and removed size:L 100-499 changed lines (additions + deletions). labels Jun 20, 2026
@juliusmarmingejuliusmarminge changed the title [codex] Structure browser preview open failures[codex] Structure preview asset URL failuresJun 20, 2026
macroscopeapp[bot]
macroscopeappBot previously approved these changes Jun 20, 2026
View reviewed changes
@juliusmarminge
juliusmarmingeforce-pushed the codex/web-preview-error-context branch from c048ffe to 215b085CompareJune 20, 2026 22:48
@juliusmarminge
juliusmarmingeforce-pushed the codex/web-preview-error-context branch from 215b085 to 8751fdbCompareJune 20, 2026 22:50
@juliusmarminge
juliusmarmingeforce-pushed the codex/web-preview-error-context branch from 8751fdb to 087f4d1CompareJune 20, 2026 23:20
@juliusmarminge
juliusmarmingeforce-pushed the codex/web-preview-error-context branch from 087f4d1 to 8c4c9b9CompareJune 20, 2026 23:43
@juliusmarminge
juliusmarmingeforce-pushed the codex/web-preview-error-context branch from 8c4c9b9 to e2f90b8CompareJune 20, 2026 23:47
@juliusmarminge
juliusmarmingeforce-pushed the codex/web-preview-error-context branch from e2f90b8 to 0de1a6fCompareJune 21, 2026 00:00
@juliusmarminge
juliusmarmingeforce-pushed the codex/web-preview-error-context branch 2 times, most recently from 8184293 to 6604762CompareJune 21, 2026 00:22
@macroscopeapp
macroscopeappBot dismissed their stale reviewJune 21, 2026 00:22

Dismissing prior approval to re-evaluate 6604762

@github-actionsgithub-actionsBot added size:L 100-499 changed lines (additions + deletions). and removed size:M 30-99 changed lines (additions + deletions). labels Jun 21, 2026
@juliusmarminge
juliusmarmingeforce-pushed the codex/web-preview-error-context branch from 6604762 to 83d49a1CompareJune 21, 2026 00:25
@juliusmarminge
juliusmarmingeforce-pushed the codex/web-preview-error-context branch from 83d49a1 to 5dc67afCompareJune 21, 2026 00:26
@juliusmarminge
juliusmarmingeforce-pushed the codex/web-preview-error-context branch from 5dc67af to b6ec6cfCompareJune 21, 2026 00:30
@juliusmarminge
juliusmarmingeforce-pushed the codex/web-preview-error-context branch from b6ec6cf to 9952de4CompareJune 21, 2026 00:32
@juliusmarminge
juliusmarmingeforce-pushed the codex/web-preview-error-context branch 2 times, most recently from 6c4608c to f1b1d68CompareJune 21, 2026 00:45
@juliusmarminge
juliusmarmingeforce-pushed the codex/web-preview-error-context branch from f1b1d68 to 6e21cc7CompareJune 21, 2026 01:11
@juliusmarminge
juliusmarmingeforce-pushed the codex/web-preview-error-context branch from 6e21cc7 to 2d0461bCompareJune 21, 2026 01:22
@juliusmarminge@codex
fix(web): structure preview asset URL failures
56e0750
Co-authored-by: codex <codex@users.noreply.github.com>
@juliusmarminge
juliusmarmingeforce-pushed the codex/web-preview-error-context branch from 2d0461b to 56e0750CompareJune 21, 2026 01:39
@juliusmarminge
juliusmarminge merged commit 27ac96a into codex/stack-pr-3259Jun 21, 2026
16 checks passed
@juliusmarminge
juliusmarminge deleted the codex/web-preview-error-context branch June 21, 2026 01:47
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@macroscopeappmacroscopeapp[bot]macroscopeapp[bot] approved these changes

Assignees

No one assigned

Labels

size:L100-499 changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@juliusmarminge
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
[codex] Structure preview asset URL failures - #3399
Merged
juliusmarminge merged 1 commit into
codex/stack-pr-3259from 
codex/web-preview-error-context
Jun 21, 2026
Merged
[codex] Structure preview asset URL failures#3399
juliusmarminge merged 1 commit into
codex/stack-pr-3259from 
codex/web-preview-error-context
Conversation
@juliusmarminge
@juliusmarmingejuliusmarminge
commented
Jun 20, 2026•

edited by macroscopeapp
Bot
Loading

Copy link


Copy Markdown

Member
Summary
  • replace malformed preview asset URL defects with BrowserPreviewAssetUrlInvalidError
  • preserve the exact URL parser cause for the full failure chain
  • attach safe environment, thread, file, URL-length, and expiry diagnostics; do not store the signed relative URL or raw base URL as direct structured attributes
  • cover cause identity and absence of direct raw URL attributes with a focused regression test
Scope
Stack dependency
Validation
  • pnpm vp test apps/web/src/browser/openFileInPreview.test.ts
  • pnpm vp check
  • pnpm vp run typecheck
Note
Medium Risk

Changes integrated-browser open paths and error typing in chat markdown; invalid asset URLs now fail recoverably instead of dying, with safer diagnostics around signed URLs.
Overview
Preview asset URL construction in openFileInPreview no longer uses resolveAssetUrl or Cause.die when the base/relative URL pair is invalid. It builds the URL with new URL(relative, base) and returns BrowserPreviewAssetUrlInvalidError via Cause.fail, carrying environment/thread/file context, URL lengths and expiry, and the original parser cause—without storing raw base or signed relative URLs.
Browser preview errors are refactored to Effect Schema.TaggedErrorClass types with fixed user-facing messages: BrowserPreviewUnavailableError (runtime unsupported), plus new BrowserPreviewThreadContextUnavailableError and BrowserPreviewEnvironmentDisconnectedError. ChatMarkdown returns these specific failures when opening links or workspace files in the integrated browser instead of overloading BrowserPreviewUnavailableError with ad hoc messages.
Tests in openFileInPreview.test.ts cover the fixed unavailable message, invalid-asset-URL diagnostics, cause identity, and that serialized errors do not leak signed tokens.
Reviewed by Cursor Bugbot for commit 56e0750. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Structure browser preview asset URL failures as typed errors in openFileInPreview
  • Replaces generic defect failures with typed Schema.TaggedErrorClass errors for three new failure cases: missing thread context (BrowserPreviewThreadContextUnavailableError), disconnected environment (BrowserPreviewEnvironmentDisconnectedError), and invalid asset URL (BrowserPreviewAssetUrlInvalidError).
  • BrowserPreviewAssetUrlInvalidError captures safe diagnostic fields (environmentId, threadId, filePath, httpBaseUrlLength, relativeUrlLength, expiresAt) and preserves the original cause, avoiding exposure of sensitive URL contents.
  • Replaces resolveAssetUrl with a new URL(relativeUrl, httpBaseUrl) call wrapped in try/catch; failures are surfaced as BrowserPreviewAssetUrlInvalidError instead of a defect die.
  • Exports isBrowserPreviewAssetUrlInvalidError as a type guard via Schema.is.
  • Behavioral Change: callers of openFileInPreview now receive typed failures for URL construction errors instead of unhandled defects.
Macroscope summarized 56e0750.
@coderabbitai
coderabbitaiBot
commented
Jun 20, 2026•

edited

Loading

Copy link


Copy Markdown

Important
Review skipped
Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: c935d6bb-72b9-4e0a-bb44-2ac2ce02b98a
You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.
Use the checkbox below for a quick retry:
  •  🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Commit unit tests in branch codex/web-preview-error-context
Comment @coderabbitai help to get the list of available commands and usage tips.
@github-actionsgithub-actionsBot
added

vouch:trusted
PR author is trusted by repo permissions or the VOUCHED list.
size:L
100-499 changed lines (additions + deletions).
labels
Jun 20, 2026
macroscopeapp[bot]
macroscopeappBot
previously approved these changes
Jun 20, 2026
View reviewed changes
@macroscopeapp
macroscopeappBot
commented
Jun 20, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Approvability
Verdict: Approved
This PR refactors error handling for browser preview asset URLs, converting to Schema-based error classes with structured context fields while ensuring sensitive data isn't leaked. The changes are limited to error infrastructure with comprehensive test coverage.
You can customize Macroscope's approvability policy. Learn more.
@juliusmarminge
juliusmarmingeforce-pushed
the
codex/web-preview-error-context
branch
from
6989347 to
199dc14CompareJune 20, 2026 15:36
@juliusmarmingejuliusmarminge
changed the title
refactor(web): add structured preview errors[codex] Structure browser preview open failuresJun 20, 2026
@juliusmarminge
juliusmarminge
changed the base branch from
main
to
codex/web-markdown-action-errorsJune 20, 2026 15:36
@macroscopeapp
macroscopeappBot
dismissed
their stale reviewJune 20, 2026 15:36
Dismissing prior approval to re-evaluate 199dc14
macroscopeapp[bot]
macroscopeappBot
previously approved these changes
Jun 20, 2026
View reviewed changes
@juliusmarminge
juliusmarmingeforce-pushed
the
codex/web-preview-error-context
branch
from
199dc14 to
c048ffeCompareJune 20, 2026 15:43
@juliusmarminge
juliusmarminge
changed the base branch from
codex/web-markdown-action-errors
to
codex/stack-pr-3259June 20, 2026 15:43
@macroscopeapp
macroscopeappBot
dismissed
their stale reviewJune 20, 2026 15:43
Dismissing prior approval to re-evaluate c048ffe
@github-actionsgithub-actionsBot
added

size:M
30-99 changed lines (additions + deletions).
and removed

size:L
100-499 changed lines (additions + deletions).
labels
Jun 20, 2026
@juliusmarmingejuliusmarminge
changed the title
[codex] Structure browser preview open failures[codex] Structure preview asset URL failuresJun 20, 2026
macroscopeapp[bot]
macroscopeappBot
previously approved these changes
Jun 20, 2026
View reviewed changes
@juliusmarminge
juliusmarmingeforce-pushed
the
codex/web-preview-error-context
branch
from
c048ffe to
215b085CompareJune 20, 2026 22:48
@juliusmarminge
juliusmarmingeforce-pushed
the
codex/web-preview-error-context
branch
from
215b085 to
8751fdbCompareJune 20, 2026 22:50
@juliusmarminge
juliusmarmingeforce-pushed
the
codex/web-preview-error-context
branch
from
8751fdb to
087f4d1CompareJune 20, 2026 23:20
@juliusmarminge
juliusmarmingeforce-pushed
the
codex/web-preview-error-context
branch
from
087f4d1 to
8c4c9b9CompareJune 20, 2026 23:43
@juliusmarminge
juliusmarmingeforce-pushed
the
codex/web-preview-error-context
branch
from
8c4c9b9 to
e2f90b8CompareJune 20, 2026 23:47
@juliusmarminge
juliusmarmingeforce-pushed
the
codex/web-preview-error-context
branch
from
e2f90b8 to
0de1a6fCompareJune 21, 2026 00:00
@juliusmarminge
juliusmarmingeforce-pushed
the
codex/web-preview-error-context
branch
2 times, most recently
from
8184293 to
6604762CompareJune 21, 2026 00:22
@macroscopeapp
macroscopeappBot
dismissed
their stale reviewJune 21, 2026 00:22
Dismissing prior approval to re-evaluate 6604762
@github-actionsgithub-actionsBot
added

size:L
100-499 changed lines (additions + deletions).
and removed

size:M
30-99 changed lines (additions + deletions).
labels
Jun 21, 2026
@juliusmarminge
juliusmarmingeforce-pushed
the
codex/web-preview-error-context
branch
from
6604762 to
83d49a1CompareJune 21, 2026 00:25
@juliusmarminge
juliusmarmingeforce-pushed
the
codex/web-preview-error-context
branch
from
83d49a1 to
5dc67afCompareJune 21, 2026 00:26
@juliusmarminge
juliusmarmingeforce-pushed
the
codex/web-preview-error-context
branch
from
5dc67af to
b6ec6cfCompareJune 21, 2026 00:30
@juliusmarminge
juliusmarmingeforce-pushed
the
codex/web-preview-error-context
branch
from
b6ec6cf to
9952de4CompareJune 21, 2026 00:32
@juliusmarminge
juliusmarmingeforce-pushed
the
codex/web-preview-error-context
branch
2 times, most recently
from
6c4608c to
f1b1d68CompareJune 21, 2026 00:45
@juliusmarminge
juliusmarmingeforce-pushed
the
codex/web-preview-error-context
branch
from
f1b1d68 to
6e21cc7CompareJune 21, 2026 01:11
@juliusmarminge
juliusmarmingeforce-pushed
the
codex/web-preview-error-context
branch
from
6e21cc7 to
2d0461bCompareJune 21, 2026 01:22
@juliusmarminge@codex
fix(web): structure preview asset URL failures
56e0750
Co-authored-by: codex <codex@users.noreply.github.com>
@juliusmarminge
juliusmarmingeforce-pushed
the
codex/web-preview-error-context
branch
from
2d0461b to
56e0750CompareJune 21, 2026 01:39
@juliusmarminge
juliusmarminge
merged commit 27ac96a
into
codex/stack-pr-3259Jun 21, 2026

16 checks passed

@juliusmarminge
juliusmarminge
deleted the

codex/web-preview-error-context

branch
June 21, 2026 01:47
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@macroscopeappmacroscopeapp[bot]macroscopeapp[bot] approved these changes

Assignees


No one assigned


Labels

size:L100-499 changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@juliusmarminge

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[codex] Structure preview asset URL failures - #3399
Merged
juliusmarminge merged 1 commit into
codex/stack-pr-3259from 
codex/web-preview-error-context
Jun 21, 2026
Merged
[codex] Structure preview asset URL failures#3399
juliusmarminge merged 1 commit into
codex/stack-pr-3259from 
codex/web-preview-error-context
Conversation
@juliusmarminge
@juliusmarmingejuliusmarminge
commented
Jun 20, 2026•

edited by macroscopeapp
Bot
Loading

Copy link


Copy Markdown

Member
Summary
  • replace malformed preview asset URL defects with BrowserPreviewAssetUrlInvalidError
  • preserve the exact URL parser cause for the full failure chain
  • attach safe environment, thread, file, URL-length, and expiry diagnostics; do not store the signed relative URL or raw base URL as direct structured attributes
  • cover cause identity and absence of direct raw URL attributes with a focused regression test
Scope
Stack dependency
Validation
  • pnpm vp test apps/web/src/browser/openFileInPreview.test.ts
  • pnpm vp check
  • pnpm vp run typecheck
Note
Medium Risk

Changes integrated-browser open paths and error typing in chat markdown; invalid asset URLs now fail recoverably instead of dying, with safer diagnostics around signed URLs.
Overview
Preview asset URL construction in openFileInPreview no longer uses resolveAssetUrl or Cause.die when the base/relative URL pair is invalid. It builds the URL with new URL(relative, base) and returns BrowserPreviewAssetUrlInvalidError via Cause.fail, carrying environment/thread/file context, URL lengths and expiry, and the original parser cause—without storing raw base or signed relative URLs.
Browser preview errors are refactored to Effect Schema.TaggedErrorClass types with fixed user-facing messages: BrowserPreviewUnavailableError (runtime unsupported), plus new BrowserPreviewThreadContextUnavailableError and BrowserPreviewEnvironmentDisconnectedError. ChatMarkdown returns these specific failures when opening links or workspace files in the integrated browser instead of overloading BrowserPreviewUnavailableError with ad hoc messages.
Tests in openFileInPreview.test.ts cover the fixed unavailable message, invalid-asset-URL diagnostics, cause identity, and that serialized errors do not leak signed tokens.
Reviewed by Cursor Bugbot for commit 56e0750. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Structure browser preview asset URL failures as typed errors in openFileInPreview
  • Replaces generic defect failures with typed Schema.TaggedErrorClass errors for three new failure cases: missing thread context (BrowserPreviewThreadContextUnavailableError), disconnected environment (BrowserPreviewEnvironmentDisconnectedError), and invalid asset URL (BrowserPreviewAssetUrlInvalidError).
  • BrowserPreviewAssetUrlInvalidError captures safe diagnostic fields (environmentId, threadId, filePath, httpBaseUrlLength, relativeUrlLength, expiresAt) and preserves the original cause, avoiding exposure of sensitive URL contents.
  • Replaces resolveAssetUrl with a new URL(relativeUrl, httpBaseUrl) call wrapped in try/catch; failures are surfaced as BrowserPreviewAssetUrlInvalidError instead of a defect die.
  • Exports isBrowserPreviewAssetUrlInvalidError as a type guard via Schema.is.
  • Behavioral Change: callers of openFileInPreview now receive typed failures for URL construction errors instead of unhandled defects.
Macroscope summarized 56e0750.
@coderabbitai
coderabbitaiBot
commented
Jun 20, 2026•

edited

Loading

Copy link


Copy Markdown

Important
Review skipped
Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: c935d6bb-72b9-4e0a-bb44-2ac2ce02b98a
You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.
Use the checkbox below for a quick retry:
  •  🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Commit unit tests in branch codex/web-preview-error-context
Comment @coderabbitai help to get the list of available commands and usage tips.
@github-actionsgithub-actionsBot
added

vouch:trusted
PR author is trusted by repo permissions or the VOUCHED list.
size:L
100-499 changed lines (additions + deletions).
labels
Jun 20, 2026
macroscopeapp[bot]
macroscopeappBot
previously approved these changes
Jun 20, 2026
View reviewed changes
@macroscopeapp
macroscopeappBot
commented
Jun 20, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Approvability
Verdict: Approved
This PR refactors error handling for browser preview asset URLs, converting to Schema-based error classes with structured context fields while ensuring sensitive data isn't leaked. The changes are limited to error infrastructure with comprehensive test coverage.
You can customize Macroscope's approvability policy. Learn more.
@juliusmarminge
juliusmarmingeforce-pushed
the
codex/web-preview-error-context
branch
from
6989347 to
199dc14CompareJune 20, 2026 15:36
@juliusmarmingejuliusmarminge
changed the title
refactor(web): add structured preview errors[codex] Structure browser preview open failuresJun 20, 2026
@juliusmarminge
juliusmarminge
changed the base branch from
main
to
codex/web-markdown-action-errorsJune 20, 2026 15:36
@macroscopeapp
macroscopeappBot
dismissed
their stale reviewJune 20, 2026 15:36
Dismissing prior approval to re-evaluate 199dc14
macroscopeapp[bot]
macroscopeappBot
previously approved these changes
Jun 20, 2026
View reviewed changes
@juliusmarminge
juliusmarmingeforce-pushed
the
codex/web-preview-error-context
branch
from
199dc14 to
c048ffeCompareJune 20, 2026 15:43
@juliusmarminge
juliusmarminge
changed the base branch from
codex/web-markdown-action-errors
to
codex/stack-pr-3259June 20, 2026 15:43
@macroscopeapp
macroscopeappBot
dismissed
their stale reviewJune 20, 2026 15:43
Dismissing prior approval to re-evaluate c048ffe
@github-actionsgithub-actionsBot
added

size:M
30-99 changed lines (additions + deletions).
and removed

size:L
100-499 changed lines (additions + deletions).
labels
Jun 20, 2026
@juliusmarmingejuliusmarminge
changed the title
[codex] Structure browser preview open failures[codex] Structure preview asset URL failuresJun 20, 2026
macroscopeapp[bot]
macroscopeappBot
previously approved these changes
Jun 20, 2026
View reviewed changes
@juliusmarminge
juliusmarmingeforce-pushed
the
codex/web-preview-error-context
branch
from
c048ffe to
215b085CompareJune 20, 2026 22:48
@juliusmarminge
juliusmarmingeforce-pushed
the
codex/web-preview-error-context
branch
from
215b085 to
8751fdbCompareJune 20, 2026 22:50
@juliusmarminge
juliusmarmingeforce-pushed
the
codex/web-preview-error-context
branch
from
8751fdb to
087f4d1CompareJune 20, 2026 23:20
@juliusmarminge
juliusmarmingeforce-pushed
the
codex/web-preview-error-context
branch
from
087f4d1 to
8c4c9b9CompareJune 20, 2026 23:43
@juliusmarminge
juliusmarmingeforce-pushed
the
codex/web-preview-error-context
branch
from
8c4c9b9 to
e2f90b8CompareJune 20, 2026 23:47
@juliusmarminge
juliusmarmingeforce-pushed
the
codex/web-preview-error-context
branch
from
e2f90b8 to
0de1a6fCompareJune 21, 2026 00:00
@juliusmarminge
juliusmarmingeforce-pushed
the
codex/web-preview-error-context
branch
2 times, most recently
from
8184293 to
6604762CompareJune 21, 2026 00:22
@macroscopeapp
macroscopeappBot
dismissed
their stale reviewJune 21, 2026 00:22
Dismissing prior approval to re-evaluate 6604762
@github-actionsgithub-actionsBot
added

size:L
100-499 changed lines (additions + deletions).
and removed

size:M
30-99 changed lines (additions + deletions).
labels
Jun 21, 2026
@juliusmarminge
juliusmarmingeforce-pushed
the
codex/web-preview-error-context
branch
from
6604762 to
83d49a1CompareJune 21, 2026 00:25
@juliusmarminge
juliusmarmingeforce-pushed
the
codex/web-preview-error-context
branch
from
83d49a1 to
5dc67afCompareJune 21, 2026 00:26
@juliusmarminge
juliusmarmingeforce-pushed
the
codex/web-preview-error-context
branch
from
5dc67af to
b6ec6cfCompareJune 21, 2026 00:30
@juliusmarminge
juliusmarmingeforce-pushed
the
codex/web-preview-error-context
branch
from
b6ec6cf to
9952de4CompareJune 21, 2026 00:32
@juliusmarminge
juliusmarmingeforce-pushed
the
codex/web-preview-error-context
branch
2 times, most recently
from
6c4608c to
f1b1d68CompareJune 21, 2026 00:45
@juliusmarminge
juliusmarmingeforce-pushed
the
codex/web-preview-error-context
branch
from
f1b1d68 to
6e21cc7CompareJune 21, 2026 01:11
@juliusmarminge
juliusmarmingeforce-pushed
the
codex/web-preview-error-context
branch
from
6e21cc7 to
2d0461bCompareJune 21, 2026 01:22
@juliusmarminge@codex
fix(web): structure preview asset URL failures
56e0750
Co-authored-by: codex <codex@users.noreply.github.com>
@juliusmarminge
juliusmarmingeforce-pushed
the
codex/web-preview-error-context
branch
from
2d0461b to
56e0750CompareJune 21, 2026 01:39
@juliusmarminge
juliusmarminge
merged commit 27ac96a
into
codex/stack-pr-3259Jun 21, 2026

16 checks passed

@juliusmarminge
juliusmarminge
deleted the

codex/web-preview-error-context

branch
June 21, 2026 01:47
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@macroscopeappmacroscopeapp[bot]macroscopeapp[bot] approved these changes

Assignees


No one assigned


Labels

size:L100-499 changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@juliusmarminge

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[codex] Structure preview asset URL failures - #3399
Merged
juliusmarminge merged 1 commit into
codex/stack-pr-3259from 
codex/web-preview-error-context
Jun 21, 2026
Merged
[codex] Structure preview asset URL failures#3399
juliusmarminge merged 1 commit into
codex/stack-pr-3259from 
codex/web-preview-error-context
Conversation
@juliusmarminge
@juliusmarmingejuliusmarminge
commented
Jun 20, 2026•

edited by macroscopeapp
Bot
Loading

Copy link


Copy Markdown

Member
Summary
  • replace malformed preview asset URL defects with BrowserPreviewAssetUrlInvalidError
  • preserve the exact URL parser cause for the full failure chain
  • attach safe environment, thread, file, URL-length, and expiry diagnostics; do not store the signed relative URL or raw base URL as direct structured attributes
  • cover cause identity and absence of direct raw URL attributes with a focused regression test
Scope
Stack dependency
Validation
  • pnpm vp test apps/web/src/browser/openFileInPreview.test.ts
  • pnpm vp check
  • pnpm vp run typecheck
Note
Medium Risk

Changes integrated-browser open paths and error typing in chat markdown; invalid asset URLs now fail recoverably instead of dying, with safer diagnostics around signed URLs.
Overview
Preview asset URL construction in openFileInPreview no longer uses resolveAssetUrl or Cause.die when the base/relative URL pair is invalid. It builds the URL with new URL(relative, base) and returns BrowserPreviewAssetUrlInvalidError via Cause.fail, carrying environment/thread/file context, URL lengths and expiry, and the original parser cause—without storing raw base or signed relative URLs.
Browser preview errors are refactored to Effect Schema.TaggedErrorClass types with fixed user-facing messages: BrowserPreviewUnavailableError (runtime unsupported), plus new BrowserPreviewThreadContextUnavailableError and BrowserPreviewEnvironmentDisconnectedError. ChatMarkdown returns these specific failures when opening links or workspace files in the integrated browser instead of overloading BrowserPreviewUnavailableError with ad hoc messages.
Tests in openFileInPreview.test.ts cover the fixed unavailable message, invalid-asset-URL diagnostics, cause identity, and that serialized errors do not leak signed tokens.
Reviewed by Cursor Bugbot for commit 56e0750. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Structure browser preview asset URL failures as typed errors in openFileInPreview
  • Replaces generic defect failures with typed Schema.TaggedErrorClass errors for three new failure cases: missing thread context (BrowserPreviewThreadContextUnavailableError), disconnected environment (BrowserPreviewEnvironmentDisconnectedError), and invalid asset URL (BrowserPreviewAssetUrlInvalidError).
  • BrowserPreviewAssetUrlInvalidError captures safe diagnostic fields (environmentId, threadId, filePath, httpBaseUrlLength, relativeUrlLength, expiresAt) and preserves the original cause, avoiding exposure of sensitive URL contents.
  • Replaces resolveAssetUrl with a new URL(relativeUrl, httpBaseUrl) call wrapped in try/catch; failures are surfaced as BrowserPreviewAssetUrlInvalidError instead of a defect die.
  • Exports isBrowserPreviewAssetUrlInvalidError as a type guard via Schema.is.
  • Behavioral Change: callers of openFileInPreview now receive typed failures for URL construction errors instead of unhandled defects.
Macroscope summarized 56e0750.
@coderabbitai
coderabbitaiBot
commented
Jun 20, 2026•

edited

Loading

Copy link


Copy Markdown

Important
Review skipped
Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: c935d6bb-72b9-4e0a-bb44-2ac2ce02b98a
You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.
Use the checkbox below for a quick retry:
  •  🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Commit unit tests in branch codex/web-preview-error-context
Comment @coderabbitai help to get the list of available commands and usage tips.
@github-actionsgithub-actionsBot
added

vouch:trusted
PR author is trusted by repo permissions or the VOUCHED list.
size:L
100-499 changed lines (additions + deletions).
labels
Jun 20, 2026
macroscopeapp[bot]
macroscopeappBot
previously approved these changes
Jun 20, 2026
View reviewed changes
@macroscopeapp
macroscopeappBot
commented
Jun 20, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Approvability
Verdict: Approved
This PR refactors error handling for browser preview asset URLs, converting to Schema-based error classes with structured context fields while ensuring sensitive data isn't leaked. The changes are limited to error infrastructure with comprehensive test coverage.
You can customize Macroscope's approvability policy. Learn more.
@juliusmarminge
juliusmarmingeforce-pushed
the
codex/web-preview-error-context
branch
from
6989347 to
199dc14CompareJune 20, 2026 15:36
@juliusmarmingejuliusmarminge
changed the title
refactor(web): add structured preview errors[codex] Structure browser preview open failuresJun 20, 2026
@juliusmarminge
juliusmarminge
changed the base branch from
main
to
codex/web-markdown-action-errorsJune 20, 2026 15:36
@macroscopeapp
macroscopeappBot
dismissed
their stale reviewJune 20, 2026 15:36
Dismissing prior approval to re-evaluate 199dc14
macroscopeapp[bot]
macroscopeappBot
previously approved these changes
Jun 20, 2026
View reviewed changes
@juliusmarminge
juliusmarmingeforce-pushed
the
codex/web-preview-error-context
branch
from
199dc14 to
c048ffeCompareJune 20, 2026 15:43
@juliusmarminge
juliusmarminge
changed the base branch from
codex/web-markdown-action-errors
to
codex/stack-pr-3259June 20, 2026 15:43
@macroscopeapp
macroscopeappBot
dismissed
their stale reviewJune 20, 2026 15:43
Dismissing prior approval to re-evaluate c048ffe
@github-actionsgithub-actionsBot
added

size:M
30-99 changed lines (additions + deletions).
and removed

size:L
100-499 changed lines (additions + deletions).
labels
Jun 20, 2026
@juliusmarmingejuliusmarminge
changed the title
[codex] Structure browser preview open failures[codex] Structure preview asset URL failuresJun 20, 2026
macroscopeapp[bot]
macroscopeappBot
previously approved these changes
Jun 20, 2026
View reviewed changes
@juliusmarminge
juliusmarmingeforce-pushed
the
codex/web-preview-error-context
branch
from
c048ffe to
215b085CompareJune 20, 2026 22:48
@juliusmarminge
juliusmarmingeforce-pushed
the
codex/web-preview-error-context
branch
from
215b085 to
8751fdbCompareJune 20, 2026 22:50
@juliusmarminge
juliusmarmingeforce-pushed
the
codex/web-preview-error-context
branch
from
8751fdb to
087f4d1CompareJune 20, 2026 23:20
@juliusmarminge
juliusmarmingeforce-pushed
the
codex/web-preview-error-context
branch
from
087f4d1 to
8c4c9b9CompareJune 20, 2026 23:43
@juliusmarminge
juliusmarmingeforce-pushed
the
codex/web-preview-error-context
branch
from
8c4c9b9 to
e2f90b8CompareJune 20, 2026 23:47
@juliusmarminge
juliusmarmingeforce-pushed
the
codex/web-preview-error-context
branch
from
e2f90b8 to
0de1a6fCompareJune 21, 2026 00:00
@juliusmarminge
juliusmarmingeforce-pushed
the
codex/web-preview-error-context
branch
2 times, most recently
from
8184293 to
6604762CompareJune 21, 2026 00:22
@macroscopeapp
macroscopeappBot
dismissed
their stale reviewJune 21, 2026 00:22
Dismissing prior approval to re-evaluate 6604762
@github-actionsgithub-actionsBot
added

size:L
100-499 changed lines (additions + deletions).
and removed

size:M
30-99 changed lines (additions + deletions).
labels
Jun 21, 2026
@juliusmarminge
juliusmarmingeforce-pushed
the
codex/web-preview-error-context
branch
from
6604762 to
83d49a1CompareJune 21, 2026 00:25
@juliusmarminge
juliusmarmingeforce-pushed
the
codex/web-preview-error-context
branch
from
83d49a1 to
5dc67afCompareJune 21, 2026 00:26
@juliusmarminge
juliusmarmingeforce-pushed
the
codex/web-preview-error-context
branch
from
5dc67af to
b6ec6cfCompareJune 21, 2026 00:30
@juliusmarminge
juliusmarmingeforce-pushed
the
codex/web-preview-error-context
branch
from
b6ec6cf to
9952de4CompareJune 21, 2026 00:32
@juliusmarminge
juliusmarmingeforce-pushed
the
codex/web-preview-error-context
branch
2 times, most recently
from
6c4608c to
f1b1d68CompareJune 21, 2026 00:45
@juliusmarminge
juliusmarmingeforce-pushed
the
codex/web-preview-error-context
branch
from
f1b1d68 to
6e21cc7CompareJune 21, 2026 01:11
@juliusmarminge
juliusmarmingeforce-pushed
the
codex/web-preview-error-context
branch
from
6e21cc7 to
2d0461bCompareJune 21, 2026 01:22
@juliusmarminge@codex
fix(web): structure preview asset URL failures
56e0750
Co-authored-by: codex <codex@users.noreply.github.com>
@juliusmarminge
juliusmarmingeforce-pushed
the
codex/web-preview-error-context
branch
from
2d0461b to
56e0750CompareJune 21, 2026 01:39
@juliusmarminge
juliusmarminge
merged commit 27ac96a
into
codex/stack-pr-3259Jun 21, 2026

16 checks passed

@juliusmarminge
juliusmarminge
deleted the

codex/web-preview-error-context

branch
June 21, 2026 01:47
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@macroscopeappmacroscopeapp[bot]macroscopeapp[bot] approved these changes

Assignees


No one assigned


Labels

size:L100-499 changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@juliusmarminge

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
[codex] Structure preview asset URL failures - #3399
Merged
juliusmarminge merged 1 commit into
codex/stack-pr-3259from 
codex/web-preview-error-context
Jun 21, 2026
Merged
[codex] Structure preview asset URL failures#3399
juliusmarminge merged 1 commit into
codex/stack-pr-3259from 
codex/web-preview-error-context
Conversation
@juliusmarminge
@juliusmarmingejuliusmarminge
commented
Jun 20, 2026•

edited by macroscopeapp
Bot
Loading

Copy link


Copy Markdown

Member
Summary
  • replace malformed preview asset URL defects with BrowserPreviewAssetUrlInvalidError
  • preserve the exact URL parser cause for the full failure chain
  • attach safe environment, thread, file, URL-length, and expiry diagnostics; do not store the signed relative URL or raw base URL as direct structured attributes
  • cover cause identity and absence of direct raw URL attributes with a focused regression test
Scope
Stack dependency
Validation
  • pnpm vp test apps/web/src/browser/openFileInPreview.test.ts
  • pnpm vp check
  • pnpm vp run typecheck
Note
Medium Risk

Changes integrated-browser open paths and error typing in chat markdown; invalid asset URLs now fail recoverably instead of dying, with safer diagnostics around signed URLs.
Overview
Preview asset URL construction in openFileInPreview no longer uses resolveAssetUrl or Cause.die when the base/relative URL pair is invalid. It builds the URL with new URL(relative, base) and returns BrowserPreviewAssetUrlInvalidError via Cause.fail, carrying environment/thread/file context, URL lengths and expiry, and the original parser cause—without storing raw base or signed relative URLs.
Browser preview errors are refactored to Effect Schema.TaggedErrorClass types with fixed user-facing messages: BrowserPreviewUnavailableError (runtime unsupported), plus new BrowserPreviewThreadContextUnavailableError and BrowserPreviewEnvironmentDisconnectedError. ChatMarkdown returns these specific failures when opening links or workspace files in the integrated browser instead of overloading BrowserPreviewUnavailableError with ad hoc messages.
Tests in openFileInPreview.test.ts cover the fixed unavailable message, invalid-asset-URL diagnostics, cause identity, and that serialized errors do not leak signed tokens.
Reviewed by Cursor Bugbot for commit 56e0750. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Structure browser preview asset URL failures as typed errors in openFileInPreview
  • Replaces generic defect failures with typed Schema.TaggedErrorClass errors for three new failure cases: missing thread context (BrowserPreviewThreadContextUnavailableError), disconnected environment (BrowserPreviewEnvironmentDisconnectedError), and invalid asset URL (BrowserPreviewAssetUrlInvalidError).
  • BrowserPreviewAssetUrlInvalidError captures safe diagnostic fields (environmentId, threadId, filePath, httpBaseUrlLength, relativeUrlLength, expiresAt) and preserves the original cause, avoiding exposure of sensitive URL contents.
  • Replaces resolveAssetUrl with a new URL(relativeUrl, httpBaseUrl) call wrapped in try/catch; failures are surfaced as BrowserPreviewAssetUrlInvalidError instead of a defect die.
  • Exports isBrowserPreviewAssetUrlInvalidError as a type guard via Schema.is.
  • Behavioral Change: callers of openFileInPreview now receive typed failures for URL construction errors instead of unhandled defects.
Macroscope summarized 56e0750.
@coderabbitai
coderabbitaiBot
commented
Jun 20, 2026•

edited

Loading

Copy link


Copy Markdown

Important
Review skipped
Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: c935d6bb-72b9-4e0a-bb44-2ac2ce02b98a
You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.
Use the checkbox below for a quick retry:
  •  🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Commit unit tests in branch codex/web-preview-error-context
Comment @coderabbitai help to get the list of available commands and usage tips.
@github-actionsgithub-actionsBot
added

vouch:trusted
PR author is trusted by repo permissions or the VOUCHED list.
size:L
100-499 changed lines (additions + deletions).
labels
Jun 20, 2026
macroscopeapp[bot]
macroscopeappBot
previously approved these changes
Jun 20, 2026
View reviewed changes
@macroscopeapp
macroscopeappBot
commented
Jun 20, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Approvability
Verdict: Approved
This PR refactors error handling for browser preview asset URLs, converting to Schema-based error classes with structured context fields while ensuring sensitive data isn't leaked. The changes are limited to error infrastructure with comprehensive test coverage.
You can customize Macroscope's approvability policy. Learn more.
@juliusmarminge
juliusmarmingeforce-pushed
the
codex/web-preview-error-context
branch
from
6989347 to
199dc14CompareJune 20, 2026 15:36
@juliusmarmingejuliusmarminge
changed the title
refactor(web): add structured preview errors[codex] Structure browser preview open failuresJun 20, 2026
@juliusmarminge
juliusmarminge
changed the base branch from
main
to
codex/web-markdown-action-errorsJune 20, 2026 15:36
@macroscopeapp
macroscopeappBot
dismissed
their stale reviewJune 20, 2026 15:36
Dismissing prior approval to re-evaluate 199dc14
macroscopeapp[bot]
macroscopeappBot
previously approved these changes
Jun 20, 2026
View reviewed changes
@juliusmarminge
juliusmarmingeforce-pushed
the
codex/web-preview-error-context
branch
from
199dc14 to
c048ffeCompareJune 20, 2026 15:43
@juliusmarminge
juliusmarminge
changed the base branch from
codex/web-markdown-action-errors
to
codex/stack-pr-3259June 20, 2026 15:43
@macroscopeapp
macroscopeappBot
dismissed
their stale reviewJune 20, 2026 15:43
Dismissing prior approval to re-evaluate c048ffe
@github-actionsgithub-actionsBot
added

size:M
30-99 changed lines (additions + deletions).
and removed

size:L
100-499 changed lines (additions + deletions).
labels
Jun 20, 2026
@juliusmarmingejuliusmarminge
changed the title
[codex] Structure browser preview open failures[codex] Structure preview asset URL failuresJun 20, 2026
macroscopeapp[bot]
macroscopeappBot
previously approved these changes
Jun 20, 2026
View reviewed changes
@juliusmarminge
juliusmarmingeforce-pushed
the
codex/web-preview-error-context
branch
from
c048ffe to
215b085CompareJune 20, 2026 22:48
@juliusmarminge
juliusmarmingeforce-pushed
the
codex/web-preview-error-context
branch
from
215b085 to
8751fdbCompareJune 20, 2026 22:50
@juliusmarminge
juliusmarmingeforce-pushed
the
codex/web-preview-error-context
branch
from
8751fdb to
087f4d1CompareJune 20, 2026 23:20
@juliusmarminge
juliusmarmingeforce-pushed
the
codex/web-preview-error-context
branch
from
087f4d1 to
8c4c9b9CompareJune 20, 2026 23:43
@juliusmarminge
juliusmarmingeforce-pushed
the
codex/web-preview-error-context
branch
from
8c4c9b9 to
e2f90b8CompareJune 20, 2026 23:47
@juliusmarminge
juliusmarmingeforce-pushed
the
codex/web-preview-error-context
branch
from
e2f90b8 to
0de1a6fCompareJune 21, 2026 00:00
@juliusmarminge
juliusmarmingeforce-pushed
the
codex/web-preview-error-context
branch
2 times, most recently
from
8184293 to
6604762CompareJune 21, 2026 00:22
@macroscopeapp
macroscopeappBot
dismissed
their stale reviewJune 21, 2026 00:22
Dismissing prior approval to re-evaluate 6604762
@github-actionsgithub-actionsBot
added

size:L
100-499 changed lines (additions + deletions).
and removed

size:M
30-99 changed lines (additions + deletions).
labels
Jun 21, 2026
@juliusmarminge
juliusmarmingeforce-pushed
the
codex/web-preview-error-context
branch
from
6604762 to
83d49a1CompareJune 21, 2026 00:25
@juliusmarminge
juliusmarmingeforce-pushed
the
codex/web-preview-error-context
branch
from
83d49a1 to
5dc67afCompareJune 21, 2026 00:26
@juliusmarminge
juliusmarmingeforce-pushed
the
codex/web-preview-error-context
branch
from
5dc67af to
b6ec6cfCompareJune 21, 2026 00:30
@juliusmarminge
juliusmarmingeforce-pushed
the
codex/web-preview-error-context
branch
from
b6ec6cf to
9952de4CompareJune 21, 2026 00:32
@juliusmarminge
juliusmarmingeforce-pushed
the
codex/web-preview-error-context
branch
2 times, most recently
from
6c4608c to
f1b1d68CompareJune 21, 2026 00:45
@juliusmarminge
juliusmarmingeforce-pushed
the
codex/web-preview-error-context
branch
from
f1b1d68 to
6e21cc7CompareJune 21, 2026 01:11
@juliusmarminge
juliusmarmingeforce-pushed
the
codex/web-preview-error-context
branch
from
6e21cc7 to
2d0461bCompareJune 21, 2026 01:22
@juliusmarminge@codex
fix(web): structure preview asset URL failures
56e0750
Co-authored-by: codex <codex@users.noreply.github.com>
@juliusmarminge
juliusmarmingeforce-pushed
the
codex/web-preview-error-context
branch
from
2d0461b to
56e0750CompareJune 21, 2026 01:39
@juliusmarminge
juliusmarminge
merged commit 27ac96a
into
codex/stack-pr-3259Jun 21, 2026

16 checks passed

@juliusmarminge
juliusmarminge
deleted the

codex/web-preview-error-context

branch
June 21, 2026 01:47
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@macroscopeappmacroscopeapp[bot]macroscopeapp[bot] approved these changes

Assignees


No one assigned


Labels

size:L100-499 changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@juliusmarminge

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[codex] Structure preview asset URL failures - #3399
Merged
juliusmarminge merged 1 commit into
codex/stack-pr-3259from 
codex/web-preview-error-context
Jun 21, 2026
Merged
[codex] Structure preview asset URL failures#3399
juliusmarminge merged 1 commit into
codex/stack-pr-3259from 
codex/web-preview-error-context
Conversation
@juliusmarminge
@juliusmarmingejuliusmarminge
commented
Jun 20, 2026•

edited by macroscopeapp
Bot
Loading

Copy link


Copy Markdown

Member
Summary
  • replace malformed preview asset URL defects with BrowserPreviewAssetUrlInvalidError
  • preserve the exact URL parser cause for the full failure chain
  • attach safe environment, thread, file, URL-length, and expiry diagnostics; do not store the signed relative URL or raw base URL as direct structured attributes
  • cover cause identity and absence of direct raw URL attributes with a focused regression test
Scope
Stack dependency
Validation
  • pnpm vp test apps/web/src/browser/openFileInPreview.test.ts
  • pnpm vp check
  • pnpm vp run typecheck
Note
Medium Risk

Changes integrated-browser open paths and error typing in chat markdown; invalid asset URLs now fail recoverably instead of dying, with safer diagnostics around signed URLs.
Overview
Preview asset URL construction in openFileInPreview no longer uses resolveAssetUrl or Cause.die when the base/relative URL pair is invalid. It builds the URL with new URL(relative, base) and returns BrowserPreviewAssetUrlInvalidError via Cause.fail, carrying environment/thread/file context, URL lengths and expiry, and the original parser cause—without storing raw base or signed relative URLs.
Browser preview errors are refactored to Effect Schema.TaggedErrorClass types with fixed user-facing messages: BrowserPreviewUnavailableError (runtime unsupported), plus new BrowserPreviewThreadContextUnavailableError and BrowserPreviewEnvironmentDisconnectedError. ChatMarkdown returns these specific failures when opening links or workspace files in the integrated browser instead of overloading BrowserPreviewUnavailableError with ad hoc messages.
Tests in openFileInPreview.test.ts cover the fixed unavailable message, invalid-asset-URL diagnostics, cause identity, and that serialized errors do not leak signed tokens.
Reviewed by Cursor Bugbot for commit 56e0750. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Structure browser preview asset URL failures as typed errors in openFileInPreview
  • Replaces generic defect failures with typed Schema.TaggedErrorClass errors for three new failure cases: missing thread context (BrowserPreviewThreadContextUnavailableError), disconnected environment (BrowserPreviewEnvironmentDisconnectedError), and invalid asset URL (BrowserPreviewAssetUrlInvalidError).
  • BrowserPreviewAssetUrlInvalidError captures safe diagnostic fields (environmentId, threadId, filePath, httpBaseUrlLength, relativeUrlLength, expiresAt) and preserves the original cause, avoiding exposure of sensitive URL contents.
  • Replaces resolveAssetUrl with a new URL(relativeUrl, httpBaseUrl) call wrapped in try/catch; failures are surfaced as BrowserPreviewAssetUrlInvalidError instead of a defect die.
  • Exports isBrowserPreviewAssetUrlInvalidError as a type guard via Schema.is.
  • Behavioral Change: callers of openFileInPreview now receive typed failures for URL construction errors instead of unhandled defects.
Macroscope summarized 56e0750.
@coderabbitai
coderabbitaiBot
commented
Jun 20, 2026•

edited

Loading

Copy link


Copy Markdown

Important
Review skipped
Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: c935d6bb-72b9-4e0a-bb44-2ac2ce02b98a
You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.
Use the checkbox below for a quick retry:
  •  🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Commit unit tests in branch codex/web-preview-error-context
Comment @coderabbitai help to get the list of available commands and usage tips.
@github-actionsgithub-actionsBot
added

vouch:trusted
PR author is trusted by repo permissions or the VOUCHED list.
size:L
100-499 changed lines (additions + deletions).
labels
Jun 20, 2026
macroscopeapp[bot]
macroscopeappBot
previously approved these changes
Jun 20, 2026
View reviewed changes
@macroscopeapp
macroscopeappBot
commented
Jun 20, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Approvability
Verdict: Approved
This PR refactors error handling for browser preview asset URLs, converting to Schema-based error classes with structured context fields while ensuring sensitive data isn't leaked. The changes are limited to error infrastructure with comprehensive test coverage.
You can customize Macroscope's approvability policy. Learn more.
@juliusmarminge
juliusmarmingeforce-pushed
the
codex/web-preview-error-context
branch
from
6989347 to
199dc14CompareJune 20, 2026 15:36
@juliusmarmingejuliusmarminge
changed the title
refactor(web): add structured preview errors[codex] Structure browser preview open failuresJun 20, 2026
@juliusmarminge
juliusmarminge
changed the base branch from
main
to
codex/web-markdown-action-errorsJune 20, 2026 15:36
@macroscopeapp
macroscopeappBot
dismissed
their stale reviewJune 20, 2026 15:36
Dismissing prior approval to re-evaluate 199dc14
macroscopeapp[bot]
macroscopeappBot
previously approved these changes
Jun 20, 2026
View reviewed changes
@juliusmarminge
juliusmarmingeforce-pushed
the
codex/web-preview-error-context
branch
from
199dc14 to
c048ffeCompareJune 20, 2026 15:43
@juliusmarminge
juliusmarminge
changed the base branch from
codex/web-markdown-action-errors
to
codex/stack-pr-3259June 20, 2026 15:43
@macroscopeapp
macroscopeappBot
dismissed
their stale reviewJune 20, 2026 15:43
Dismissing prior approval to re-evaluate c048ffe
@github-actionsgithub-actionsBot
added

size:M
30-99 changed lines (additions + deletions).
and removed

size:L
100-499 changed lines (additions + deletions).
labels
Jun 20, 2026
@juliusmarmingejuliusmarminge
changed the title
[codex] Structure browser preview open failures[codex] Structure preview asset URL failuresJun 20, 2026
macroscopeapp[bot]
macroscopeappBot
previously approved these changes
Jun 20, 2026
View reviewed changes
@juliusmarminge
juliusmarmingeforce-pushed
the
codex/web-preview-error-context
branch
from
c048ffe to
215b085CompareJune 20, 2026 22:48
@juliusmarminge
juliusmarmingeforce-pushed
the
codex/web-preview-error-context
branch
from
215b085 to
8751fdbCompareJune 20, 2026 22:50
@juliusmarminge
juliusmarmingeforce-pushed
the
codex/web-preview-error-context
branch
from
8751fdb to
087f4d1CompareJune 20, 2026 23:20
@juliusmarminge
juliusmarmingeforce-pushed
the
codex/web-preview-error-context
branch
from
087f4d1 to
8c4c9b9CompareJune 20, 2026 23:43
@juliusmarminge
juliusmarmingeforce-pushed
the
codex/web-preview-error-context
branch
from
8c4c9b9 to
e2f90b8CompareJune 20, 2026 23:47
@juliusmarminge
juliusmarmingeforce-pushed
the
codex/web-preview-error-context
branch
from
e2f90b8 to
0de1a6fCompareJune 21, 2026 00:00
@juliusmarminge
juliusmarmingeforce-pushed
the
codex/web-preview-error-context
branch
2 times, most recently
from
8184293 to
6604762CompareJune 21, 2026 00:22
@macroscopeapp
macroscopeappBot
dismissed
their stale reviewJune 21, 2026 00:22
Dismissing prior approval to re-evaluate 6604762
@github-actionsgithub-actionsBot
added

size:L
100-499 changed lines (additions + deletions).
and removed

size:M
30-99 changed lines (additions + deletions).
labels
Jun 21, 2026
@juliusmarminge
juliusmarmingeforce-pushed
the
codex/web-preview-error-context
branch
from
6604762 to
83d49a1CompareJune 21, 2026 00:25
@juliusmarminge
juliusmarmingeforce-pushed
the
codex/web-preview-error-context
branch
from
83d49a1 to
5dc67afCompareJune 21, 2026 00:26
@juliusmarminge
juliusmarmingeforce-pushed
the
codex/web-preview-error-context
branch
from
5dc67af to
b6ec6cfCompareJune 21, 2026 00:30
@juliusmarminge
juliusmarmingeforce-pushed
the
codex/web-preview-error-context
branch
from
b6ec6cf to
9952de4CompareJune 21, 2026 00:32
@juliusmarminge
juliusmarmingeforce-pushed
the
codex/web-preview-error-context
branch
2 times, most recently
from
6c4608c to
f1b1d68CompareJune 21, 2026 00:45
@juliusmarminge
juliusmarmingeforce-pushed
the
codex/web-preview-error-context
branch
from
f1b1d68 to
6e21cc7CompareJune 21, 2026 01:11
@juliusmarminge
juliusmarmingeforce-pushed
the
codex/web-preview-error-context
branch
from
6e21cc7 to
2d0461bCompareJune 21, 2026 01:22
@juliusmarminge@codex
fix(web): structure preview asset URL failures
56e0750
Co-authored-by: codex <codex@users.noreply.github.com>
@juliusmarminge
juliusmarmingeforce-pushed
the
codex/web-preview-error-context
branch
from
2d0461b to
56e0750CompareJune 21, 2026 01:39
@juliusmarminge
juliusmarminge
merged commit 27ac96a
into
codex/stack-pr-3259Jun 21, 2026

16 checks passed

@juliusmarminge
juliusmarminge
deleted the

codex/web-preview-error-context

branch
June 21, 2026 01:47
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@macroscopeappmacroscopeapp[bot]macroscopeapp[bot] approved these changes

Assignees


No one assigned


Labels

size:L100-499 changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@juliusmarminge

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[codex] Structure preview asset URL failures - #3399
Merged
juliusmarminge merged 1 commit into
codex/stack-pr-3259from 
codex/web-preview-error-context
Jun 21, 2026
Merged
[codex] Structure preview asset URL failures#3399
juliusmarminge merged 1 commit into
codex/stack-pr-3259from 
codex/web-preview-error-context
Conversation
@juliusmarminge
@juliusmarmingejuliusmarminge
commented
Jun 20, 2026•

edited by macroscopeapp
Bot
Loading

Copy link


Copy Markdown

Member
Summary
  • replace malformed preview asset URL defects with BrowserPreviewAssetUrlInvalidError
  • preserve the exact URL parser cause for the full failure chain
  • attach safe environment, thread, file, URL-length, and expiry diagnostics; do not store the signed relative URL or raw base URL as direct structured attributes
  • cover cause identity and absence of direct raw URL attributes with a focused regression test
Scope
Stack dependency
Validation
  • pnpm vp test apps/web/src/browser/openFileInPreview.test.ts
  • pnpm vp check
  • pnpm vp run typecheck
Note
Medium Risk

Changes integrated-browser open paths and error typing in chat markdown; invalid asset URLs now fail recoverably instead of dying, with safer diagnostics around signed URLs.
Overview
Preview asset URL construction in openFileInPreview no longer uses resolveAssetUrl or Cause.die when the base/relative URL pair is invalid. It builds the URL with new URL(relative, base) and returns BrowserPreviewAssetUrlInvalidError via Cause.fail, carrying environment/thread/file context, URL lengths and expiry, and the original parser cause—without storing raw base or signed relative URLs.
Browser preview errors are refactored to Effect Schema.TaggedErrorClass types with fixed user-facing messages: BrowserPreviewUnavailableError (runtime unsupported), plus new BrowserPreviewThreadContextUnavailableError and BrowserPreviewEnvironmentDisconnectedError. ChatMarkdown returns these specific failures when opening links or workspace files in the integrated browser instead of overloading BrowserPreviewUnavailableError with ad hoc messages.
Tests in openFileInPreview.test.ts cover the fixed unavailable message, invalid-asset-URL diagnostics, cause identity, and that serialized errors do not leak signed tokens.
Reviewed by Cursor Bugbot for commit 56e0750. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Structure browser preview asset URL failures as typed errors in openFileInPreview
  • Replaces generic defect failures with typed Schema.TaggedErrorClass errors for three new failure cases: missing thread context (BrowserPreviewThreadContextUnavailableError), disconnected environment (BrowserPreviewEnvironmentDisconnectedError), and invalid asset URL (BrowserPreviewAssetUrlInvalidError).
  • BrowserPreviewAssetUrlInvalidError captures safe diagnostic fields (environmentId, threadId, filePath, httpBaseUrlLength, relativeUrlLength, expiresAt) and preserves the original cause, avoiding exposure of sensitive URL contents.
  • Replaces resolveAssetUrl with a new URL(relativeUrl, httpBaseUrl) call wrapped in try/catch; failures are surfaced as BrowserPreviewAssetUrlInvalidError instead of a defect die.
  • Exports isBrowserPreviewAssetUrlInvalidError as a type guard via Schema.is.
  • Behavioral Change: callers of openFileInPreview now receive typed failures for URL construction errors instead of unhandled defects.
Macroscope summarized 56e0750.
@coderabbitai
coderabbitaiBot
commented
Jun 20, 2026•

edited

Loading

Copy link


Copy Markdown

Important
Review skipped
Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: c935d6bb-72b9-4e0a-bb44-2ac2ce02b98a
You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.
Use the checkbox below for a quick retry:
  •  🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Commit unit tests in branch codex/web-preview-error-context
Comment @coderabbitai help to get the list of available commands and usage tips.
@github-actionsgithub-actionsBot
added

vouch:trusted
PR author is trusted by repo permissions or the VOUCHED list.
size:L
100-499 changed lines (additions + deletions).
labels
Jun 20, 2026
macroscopeapp[bot]
macroscopeappBot
previously approved these changes
Jun 20, 2026
View reviewed changes
@macroscopeapp
macroscopeappBot
commented
Jun 20, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Approvability
Verdict: Approved
This PR refactors error handling for browser preview asset URLs, converting to Schema-based error classes with structured context fields while ensuring sensitive data isn't leaked. The changes are limited to error infrastructure with comprehensive test coverage.
You can customize Macroscope's approvability policy. Learn more.
@juliusmarminge
juliusmarmingeforce-pushed
the
codex/web-preview-error-context
branch
from
6989347 to
199dc14CompareJune 20, 2026 15:36
@juliusmarmingejuliusmarminge
changed the title
refactor(web): add structured preview errors[codex] Structure browser preview open failuresJun 20, 2026
@juliusmarminge
juliusmarminge
changed the base branch from
main
to
codex/web-markdown-action-errorsJune 20, 2026 15:36
@macroscopeapp
macroscopeappBot
dismissed
their stale reviewJune 20, 2026 15:36
Dismissing prior approval to re-evaluate 199dc14
macroscopeapp[bot]
macroscopeappBot
previously approved these changes
Jun 20, 2026
View reviewed changes
@juliusmarminge
juliusmarmingeforce-pushed
the
codex/web-preview-error-context
branch
from
199dc14 to
c048ffeCompareJune 20, 2026 15:43
@juliusmarminge
juliusmarminge
changed the base branch from
codex/web-markdown-action-errors
to
codex/stack-pr-3259June 20, 2026 15:43
@macroscopeapp
macroscopeappBot
dismissed
their stale reviewJune 20, 2026 15:43
Dismissing prior approval to re-evaluate c048ffe
@github-actionsgithub-actionsBot
added

size:M
30-99 changed lines (additions + deletions).
and removed

size:L
100-499 changed lines (additions + deletions).
labels
Jun 20, 2026
@juliusmarmingejuliusmarminge
changed the title
[codex] Structure browser preview open failures[codex] Structure preview asset URL failuresJun 20, 2026
macroscopeapp[bot]
macroscopeappBot
previously approved these changes
Jun 20, 2026
View reviewed changes
@juliusmarminge
juliusmarmingeforce-pushed
the
codex/web-preview-error-context
branch
from
c048ffe to
215b085CompareJune 20, 2026 22:48
@juliusmarminge
juliusmarmingeforce-pushed
the
codex/web-preview-error-context
branch
from
215b085 to
8751fdbCompareJune 20, 2026 22:50
@juliusmarminge
juliusmarmingeforce-pushed
the
codex/web-preview-error-context
branch
from
8751fdb to
087f4d1CompareJune 20, 2026 23:20
@juliusmarminge
juliusmarmingeforce-pushed
the
codex/web-preview-error-context
branch
from
087f4d1 to
8c4c9b9CompareJune 20, 2026 23:43
@juliusmarminge
juliusmarmingeforce-pushed
the
codex/web-preview-error-context
branch
from
8c4c9b9 to
e2f90b8CompareJune 20, 2026 23:47
@juliusmarminge
juliusmarmingeforce-pushed
the
codex/web-preview-error-context
branch
from
e2f90b8 to
0de1a6fCompareJune 21, 2026 00:00
@juliusmarminge
juliusmarmingeforce-pushed
the
codex/web-preview-error-context
branch
2 times, most recently
from
8184293 to
6604762CompareJune 21, 2026 00:22
@macroscopeapp
macroscopeappBot
dismissed
their stale reviewJune 21, 2026 00:22
Dismissing prior approval to re-evaluate 6604762
@github-actionsgithub-actionsBot
added

size:L
100-499 changed lines (additions + deletions).
and removed

size:M
30-99 changed lines (additions + deletions).
labels
Jun 21, 2026
@juliusmarminge
juliusmarmingeforce-pushed
the
codex/web-preview-error-context
branch
from
6604762 to
83d49a1CompareJune 21, 2026 00:25
@juliusmarminge
juliusmarmingeforce-pushed
the
codex/web-preview-error-context
branch
from
83d49a1 to
5dc67afCompareJune 21, 2026 00:26
@juliusmarminge
juliusmarmingeforce-pushed
the
codex/web-preview-error-context
branch
from
5dc67af to
b6ec6cfCompareJune 21, 2026 00:30
@juliusmarminge
juliusmarmingeforce-pushed
the
codex/web-preview-error-context
branch
from
b6ec6cf to
9952de4CompareJune 21, 2026 00:32
@juliusmarminge
juliusmarmingeforce-pushed
the
codex/web-preview-error-context
branch
2 times, most recently
from
6c4608c to
f1b1d68CompareJune 21, 2026 00:45
@juliusmarminge
juliusmarmingeforce-pushed
the
codex/web-preview-error-context
branch
from
f1b1d68 to
6e21cc7CompareJune 21, 2026 01:11
@juliusmarminge
juliusmarmingeforce-pushed
the
codex/web-preview-error-context
branch
from
6e21cc7 to
2d0461bCompareJune 21, 2026 01:22
@juliusmarminge@codex
fix(web): structure preview asset URL failures
56e0750
Co-authored-by: codex <codex@users.noreply.github.com>
@juliusmarminge
juliusmarmingeforce-pushed
the
codex/web-preview-error-context
branch
from
2d0461b to
56e0750CompareJune 21, 2026 01:39
@juliusmarminge
juliusmarminge
merged commit 27ac96a
into
codex/stack-pr-3259Jun 21, 2026

16 checks passed

@juliusmarminge
juliusmarminge
deleted the

codex/web-preview-error-context

branch
June 21, 2026 01:47
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@macroscopeappmacroscopeapp[bot]macroscopeapp[bot] approved these changes

Assignees


No one assigned


Labels

size:L100-499 changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@juliusmarminge

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
[codex] Structure preview asset URL failures - #3399
Merged
juliusmarminge merged 1 commit into
codex/stack-pr-3259from 
codex/web-preview-error-context
Jun 21, 2026
Merged
[codex] Structure preview asset URL failures#3399
juliusmarminge merged 1 commit into
codex/stack-pr-3259from 
codex/web-preview-error-context
Conversation
@juliusmarminge
@juliusmarmingejuliusmarminge
commented
Jun 20, 2026•

edited by macroscopeapp
Bot
Loading

Copy link


Copy Markdown

Member
Summary
  • replace malformed preview asset URL defects with BrowserPreviewAssetUrlInvalidError
  • preserve the exact URL parser cause for the full failure chain
  • attach safe environment, thread, file, URL-length, and expiry diagnostics; do not store the signed relative URL or raw base URL as direct structured attributes
  • cover cause identity and absence of direct raw URL attributes with a focused regression test
Scope
Stack dependency
Validation
  • pnpm vp test apps/web/src/browser/openFileInPreview.test.ts
  • pnpm vp check
  • pnpm vp run typecheck
Note
Medium Risk

Changes integrated-browser open paths and error typing in chat markdown; invalid asset URLs now fail recoverably instead of dying, with safer diagnostics around signed URLs.
Overview
Preview asset URL construction in openFileInPreview no longer uses resolveAssetUrl or Cause.die when the base/relative URL pair is invalid. It builds the URL with new URL(relative, base) and returns BrowserPreviewAssetUrlInvalidError via Cause.fail, carrying environment/thread/file context, URL lengths and expiry, and the original parser cause—without storing raw base or signed relative URLs.
Browser preview errors are refactored to Effect Schema.TaggedErrorClass types with fixed user-facing messages: BrowserPreviewUnavailableError (runtime unsupported), plus new BrowserPreviewThreadContextUnavailableError and BrowserPreviewEnvironmentDisconnectedError. ChatMarkdown returns these specific failures when opening links or workspace files in the integrated browser instead of overloading BrowserPreviewUnavailableError with ad hoc messages.
Tests in openFileInPreview.test.ts cover the fixed unavailable message, invalid-asset-URL diagnostics, cause identity, and that serialized errors do not leak signed tokens.
Reviewed by Cursor Bugbot for commit 56e0750. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Structure browser preview asset URL failures as typed errors in openFileInPreview
  • Replaces generic defect failures with typed Schema.TaggedErrorClass errors for three new failure cases: missing thread context (BrowserPreviewThreadContextUnavailableError), disconnected environment (BrowserPreviewEnvironmentDisconnectedError), and invalid asset URL (BrowserPreviewAssetUrlInvalidError).
  • BrowserPreviewAssetUrlInvalidError captures safe diagnostic fields (environmentId, threadId, filePath, httpBaseUrlLength, relativeUrlLength, expiresAt) and preserves the original cause, avoiding exposure of sensitive URL contents.
  • Replaces resolveAssetUrl with a new URL(relativeUrl, httpBaseUrl) call wrapped in try/catch; failures are surfaced as BrowserPreviewAssetUrlInvalidError instead of a defect die.
  • Exports isBrowserPreviewAssetUrlInvalidError as a type guard via Schema.is.
  • Behavioral Change: callers of openFileInPreview now receive typed failures for URL construction errors instead of unhandled defects.
Macroscope summarized 56e0750.
@coderabbitai
coderabbitaiBot
commented
Jun 20, 2026•

edited

Loading

Copy link


Copy Markdown

Important
Review skipped
Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: c935d6bb-72b9-4e0a-bb44-2ac2ce02b98a
You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.
Use the checkbox below for a quick retry:
  •  🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Commit unit tests in branch codex/web-preview-error-context
Comment @coderabbitai help to get the list of available commands and usage tips.
@github-actionsgithub-actionsBot
added

vouch:trusted
PR author is trusted by repo permissions or the VOUCHED list.
size:L
100-499 changed lines (additions + deletions).
labels
Jun 20, 2026
macroscopeapp[bot]
macroscopeappBot
previously approved these changes
Jun 20, 2026
View reviewed changes
@macroscopeapp
macroscopeappBot
commented
Jun 20, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Approvability
Verdict: Approved
This PR refactors error handling for browser preview asset URLs, converting to Schema-based error classes with structured context fields while ensuring sensitive data isn't leaked. The changes are limited to error infrastructure with comprehensive test coverage.
You can customize Macroscope's approvability policy. Learn more.
@juliusmarminge
juliusmarmingeforce-pushed
the
codex/web-preview-error-context
branch
from
6989347 to
199dc14CompareJune 20, 2026 15:36
@juliusmarmingejuliusmarminge
changed the title
refactor(web): add structured preview errors[codex] Structure browser preview open failuresJun 20, 2026
@juliusmarminge
juliusmarminge
changed the base branch from
main
to
codex/web-markdown-action-errorsJune 20, 2026 15:36
@macroscopeapp
macroscopeappBot
dismissed
their stale reviewJune 20, 2026 15:36
Dismissing prior approval to re-evaluate 199dc14
macroscopeapp[bot]
macroscopeappBot
previously approved these changes
Jun 20, 2026
View reviewed changes
@juliusmarminge
juliusmarmingeforce-pushed
the
codex/web-preview-error-context
branch
from
199dc14 to
c048ffeCompareJune 20, 2026 15:43
@juliusmarminge
juliusmarminge
changed the base branch from
codex/web-markdown-action-errors
to
codex/stack-pr-3259June 20, 2026 15:43
@macroscopeapp
macroscopeappBot
dismissed
their stale reviewJune 20, 2026 15:43
Dismissing prior approval to re-evaluate c048ffe
@github-actionsgithub-actionsBot
added

size:M
30-99 changed lines (additions + deletions).
and removed

size:L
100-499 changed lines (additions + deletions).
labels
Jun 20, 2026
@juliusmarmingejuliusmarminge
changed the title
[codex] Structure browser preview open failures[codex] Structure preview asset URL failuresJun 20, 2026
macroscopeapp[bot]
macroscopeappBot
previously approved these changes
Jun 20, 2026
View reviewed changes
@juliusmarminge
juliusmarmingeforce-pushed
the
codex/web-preview-error-context
branch
from
c048ffe to
215b085CompareJune 20, 2026 22:48
@juliusmarminge
juliusmarmingeforce-pushed
the
codex/web-preview-error-context
branch
from
215b085 to
8751fdbCompareJune 20, 2026 22:50
@juliusmarminge
juliusmarmingeforce-pushed
the
codex/web-preview-error-context
branch
from
8751fdb to
087f4d1CompareJune 20, 2026 23:20
@juliusmarminge
juliusmarmingeforce-pushed
the
codex/web-preview-error-context
branch
from
087f4d1 to
8c4c9b9CompareJune 20, 2026 23:43
@juliusmarminge
juliusmarmingeforce-pushed
the
codex/web-preview-error-context
branch
from
8c4c9b9 to
e2f90b8CompareJune 20, 2026 23:47
@juliusmarminge
juliusmarmingeforce-pushed
the
codex/web-preview-error-context
branch
from
e2f90b8 to
0de1a6fCompareJune 21, 2026 00:00
@juliusmarminge
juliusmarmingeforce-pushed
the
codex/web-preview-error-context
branch
2 times, most recently
from
8184293 to
6604762CompareJune 21, 2026 00:22
@macroscopeapp
macroscopeappBot
dismissed
their stale reviewJune 21, 2026 00:22
Dismissing prior approval to re-evaluate 6604762
@github-actionsgithub-actionsBot
added

size:L
100-499 changed lines (additions + deletions).
and removed

size:M
30-99 changed lines (additions + deletions).
labels
Jun 21, 2026
@juliusmarminge
juliusmarmingeforce-pushed
the
codex/web-preview-error-context
branch
from
6604762 to
83d49a1CompareJune 21, 2026 00:25
@juliusmarminge
juliusmarmingeforce-pushed
the
codex/web-preview-error-context
branch
from
83d49a1 to
5dc67afCompareJune 21, 2026 00:26
@juliusmarminge
juliusmarmingeforce-pushed
the
codex/web-preview-error-context
branch
from
5dc67af to
b6ec6cfCompareJune 21, 2026 00:30
@juliusmarminge
juliusmarmingeforce-pushed
the
codex/web-preview-error-context
branch
from
b6ec6cf to
9952de4CompareJune 21, 2026 00:32
@juliusmarminge
juliusmarmingeforce-pushed
the
codex/web-preview-error-context
branch
2 times, most recently
from
6c4608c to
f1b1d68CompareJune 21, 2026 00:45
@juliusmarminge
juliusmarmingeforce-pushed
the
codex/web-preview-error-context
branch
from
f1b1d68 to
6e21cc7CompareJune 21, 2026 01:11
@juliusmarminge
juliusmarmingeforce-pushed
the
codex/web-preview-error-context
branch
from
6e21cc7 to
2d0461bCompareJune 21, 2026 01:22
@juliusmarminge@codex
fix(web): structure preview asset URL failures
56e0750
Co-authored-by: codex <codex@users.noreply.github.com>
@juliusmarminge
juliusmarmingeforce-pushed
the
codex/web-preview-error-context
branch
from
2d0461b to
56e0750CompareJune 21, 2026 01:39
@juliusmarminge
juliusmarminge
merged commit 27ac96a
into
codex/stack-pr-3259Jun 21, 2026

16 checks passed

@juliusmarminge
juliusmarminge
deleted the

codex/web-preview-error-context

branch
June 21, 2026 01:47
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@macroscopeappmacroscopeapp[bot]macroscopeapp[bot] approved these changes

Assignees


No one assigned


Labels

size:L100-499 changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@juliusmarminge