[codex] Structure OTLP export diagnostics

[juliusmarminge]

Problem

Browser OTLP decode and export failures were logged with raw request payloads, collector URLs, and nested causes. Those values can contain credentials or private path, query, and fragment data, and the ad hoc errors did not expose stable structural diagnostics.

Changes

• replace the unstructured decode failure with a schema error carrying resource-span count and the original cause
• add a schema export error that derives safe collector URL diagnostics while preserving the exact cause chain
• use catchTags for the two distinct failures
• log only stable error/cause tags and redacted URL diagnostics; never serialize raw payloads, collector URLs, or nested HTTP causes
• keep the derivation logic on value-adding static error mappers

Validation

• vp check
• vp test apps/server/src/http.test.ts
• vp run typecheck

Tests cover exact cause identity and sentinel credentials, private path, query, and fragment redaction.

---

Note

Medium Risk
Touches observability proxy logging and error handling on an authenticated route; behavior for clients is intended to stay the same but mis-handled defects could affect trace collection visibility.

Overview
Browser OTLP decode, local collection, and export failures now use schema tagged errors instead of ad hoc Data.TaggedError types that held full request bodies or collector URLs.

Decode failures map to BrowserOtlpTraceDecodeError with resourceSpanCount and the original cause only; local browserTraceCollector.record defects become BrowserOtlpTraceCollectionError with recordCount and cause. The proxy logs warnings via Effect.catchTags using stable fields (errorTag, causeTag) and does not serialize payloads or records.

Export failures map to BrowserOtlpTraceExportError, which stores redacted URL metadata from getUrlDiagnostics (protocol, hostname, input length) while preserving the cause chain; logs omit credentials, paths, query, and fragments. HTTP behavior is unchanged: decode/collection issues are logged and the handler continues (still 204 when no upstream URL); export failure still returns 502 with "Trace export failed."

Unit tests assert cause identity and redaction; an integration test confirms OTLP requests still return 204 when local collection dies.

^{Reviewed by Cursor Bugbot for commit 8ab9c61. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Structure OTLP export diagnostics with redacted, typed errors in the browser trace handler

• Introduces three typed error classes (BrowserOtlpTraceDecodeError, BrowserOtlpTraceCollectionError, BrowserOtlpTraceExportError) in http.ts to replace broad, unstructured error handling in the POST /api/observability/v1/traces handler.
• Each error class captures only safe diagnostic fields (span/record counts, redacted URL components) and omits raw payloads, records, and collector URLs from logs.
• Adds errorDiagnosticTag helper to derive a causeTag from error causes for structured log output.
• Wraps local trace collection defects with Effect.catchDefect so the handler continues and returns 204 even when BrowserTraceCollector.record throws.
• Behavioral Change: warning logs for decode, collection, and export failures now emit structured fields instead of raw values; the handler no longer logs bodyJson or otlpTracesUrl.

^{Macroscope summarized 8ab9c61.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 5a5b74ac-6bb0-42b8-9cb6-3d318c6614d0

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/redact-otlp-export-diagnostics

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[cursor]

Cursor Bugbot has reviewed your changes using high effort and found 2 potential issues.

Bugbot Autofix prepared fixes for both issues found in the latest run.

• ✅ Fixed: Decode error mapper throws
  • Guarded payload.resourceSpans.length in fromPayload with Array.isArray(payload?.resourceSpans) so it safely returns 0 when resourceSpans is absent, null, or not an array.
• ✅ Fixed: Collector record errors propagate
  • Added Effect.catchDefect after Effect.catchTags to absorb synchronous throw defects from browserTraceCollector.record, logging a warning instead of aborting the request before remote export.

Or push these changes by commenting:

@cursor push bb12877dfd

Preview (bb12877dfd)

diff --git a/apps/server/src/http.ts b/apps/server/src/http.ts--- a/apps/server/src/http.ts+++ b/apps/server/src/http.ts@@ -131,7 +131,7 @@
) {
static fromPayload(payload: OtlpTracer.TraceData, cause: unknown): BrowserOtlpTraceDecodeError {
return new BrowserOtlpTraceDecodeError({
- resourceSpanCount: payload.resourceSpans.length,+ resourceSpanCount: Array.isArray(payload?.resourceSpans) ? payload.resourceSpans.length : 0,
cause,
});
}
@@ -194,6 +194,11 @@
causeTag: errorDiagnosticTag(error.cause),
}),
}),
+ Effect.catchDefect((defect) =>+ Effect.logWarning("Failed to record browser OTLP traces locally.", {+ causeTag: errorDiagnosticTag(defect),+ }),+ ),
);
if (otlpTracesUrl === undefined) {

_{You can send follow-ups to the cloud agent here.}

^{Reviewed by Cursor Bugbot for commit 64e1b72a098f80651a238c4d4206f3f8ba1412b7. Configure here.}

[macroscopeapp]

Approvability

Verdict: Approved

This PR refactors OTLP trace error handling to use structured error classes that avoid retaining sensitive data (trace payloads, URL credentials). The changes preserve existing runtime behavior while improving diagnostic structure, and include comprehensive tests.

^{You can customize Macroscope's approvability policy. Learn more.}

[juliusmarminge]

Problem

Browser OTLP decode and export failures were logged with raw request payloads, collector URLs, and nested causes. Those values can contain credentials or private path, query, and fragment data, and the ad hoc errors did not expose stable structural diagnostics.

Changes

• replace the unstructured decode failure with a schema error carrying resource-span count and the original cause
• add a schema export error that derives safe collector URL diagnostics while preserving the exact cause chain
• use catchTags for the two distinct failures
• log only stable error/cause tags and redacted URL diagnostics; never serialize raw payloads, collector URLs, or nested HTTP causes
• keep the derivation logic on value-adding static error mappers

Validation

• vp check
• vp test apps/server/src/http.test.ts
• vp run typecheck

Tests cover exact cause identity and sentinel credentials, private path, query, and fragment redaction.

---

Note

Medium Risk
Touches observability proxy logging and error handling on an authenticated route; behavior for clients is intended to stay the same but mis-handled defects could affect trace collection visibility.

Overview
Browser OTLP decode, local collection, and export failures now use schema tagged errors instead of ad hoc Data.TaggedError types that held full request bodies or collector URLs.

Decode failures map to BrowserOtlpTraceDecodeError with resourceSpanCount and the original cause only; local browserTraceCollector.record defects become BrowserOtlpTraceCollectionError with recordCount and cause. The proxy logs warnings via Effect.catchTags using stable fields (errorTag, causeTag) and does not serialize payloads or records.

Export failures map to BrowserOtlpTraceExportError, which stores redacted URL metadata from getUrlDiagnostics (protocol, hostname, input length) while preserving the cause chain; logs omit credentials, paths, query, and fragments. HTTP behavior is unchanged: decode/collection issues are logged and the handler continues (still 204 when no upstream URL); export failure still returns 502 with "Trace export failed."

Unit tests assert cause identity and redaction; an integration test confirms OTLP requests still return 204 when local collection dies.

^{Reviewed by Cursor Bugbot for commit 8ab9c61. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Structure OTLP export diagnostics with redacted, typed errors in the browser trace handler

• Introduces three typed error classes (BrowserOtlpTraceDecodeError, BrowserOtlpTraceCollectionError, BrowserOtlpTraceExportError) in http.ts to replace broad, unstructured error handling in the POST /api/observability/v1/traces handler.
• Each error class captures only safe diagnostic fields (span/record counts, redacted URL components) and omits raw payloads, records, and collector URLs from logs.
• Adds errorDiagnosticTag helper to derive a causeTag from error causes for structured log output.
• Wraps local trace collection defects with Effect.catchDefect so the handler continues and returns 204 even when BrowserTraceCollector.record throws.
• Behavioral Change: warning logs for decode, collection, and export failures now emit structured fields instead of raw values; the handler no longer logs bodyJson or otlpTracesUrl.

^{Macroscope summarized 8ab9c61.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 5a5b74ac-6bb0-42b8-9cb6-3d318c6614d0

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/redact-otlp-export-diagnostics

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[cursor]

Cursor Bugbot has reviewed your changes using high effort and found 2 potential issues.

Bugbot Autofix prepared fixes for both issues found in the latest run.

• ✅ Fixed: Decode error mapper throws
  • Guarded payload.resourceSpans.length in fromPayload with Array.isArray(payload?.resourceSpans) so it safely returns 0 when resourceSpans is absent, null, or not an array.
• ✅ Fixed: Collector record errors propagate
  • Added Effect.catchDefect after Effect.catchTags to absorb synchronous throw defects from browserTraceCollector.record, logging a warning instead of aborting the request before remote export.

Or push these changes by commenting:

@cursor push bb12877dfd

Preview (bb12877dfd)

diff --git a/apps/server/src/http.ts b/apps/server/src/http.ts--- a/apps/server/src/http.ts+++ b/apps/server/src/http.ts@@ -131,7 +131,7 @@
) {
static fromPayload(payload: OtlpTracer.TraceData, cause: unknown): BrowserOtlpTraceDecodeError {
return new BrowserOtlpTraceDecodeError({
- resourceSpanCount: payload.resourceSpans.length,+ resourceSpanCount: Array.isArray(payload?.resourceSpans) ? payload.resourceSpans.length : 0,
cause,
});
}
@@ -194,6 +194,11 @@
causeTag: errorDiagnosticTag(error.cause),
}),
}),
+ Effect.catchDefect((defect) =>+ Effect.logWarning("Failed to record browser OTLP traces locally.", {+ causeTag: errorDiagnosticTag(defect),+ }),+ ),
);
if (otlpTracesUrl === undefined) {

_{You can send follow-ups to the cloud agent here.}

^{Reviewed by Cursor Bugbot for commit 64e1b72a098f80651a238c4d4206f3f8ba1412b7. Configure here.}

[macroscopeapp]

Approvability

Verdict: Approved

This PR refactors OTLP trace error handling to use structured error classes that avoid retaining sensitive data (trace payloads, URL credentials). The changes preserve existing runtime behavior while improving diagnostic structure, and include comprehensive tests.

^{You can customize Macroscope's approvability policy. Learn more.}

[juliusmarminge]

Problem

Browser OTLP decode and export failures were logged with raw request payloads, collector URLs, and nested causes. Those values can contain credentials or private path, query, and fragment data, and the ad hoc errors did not expose stable structural diagnostics.

Changes

• replace the unstructured decode failure with a schema error carrying resource-span count and the original cause
• add a schema export error that derives safe collector URL diagnostics while preserving the exact cause chain
• use catchTags for the two distinct failures
• log only stable error/cause tags and redacted URL diagnostics; never serialize raw payloads, collector URLs, or nested HTTP causes
• keep the derivation logic on value-adding static error mappers

Validation

• vp check
• vp test apps/server/src/http.test.ts
• vp run typecheck

Tests cover exact cause identity and sentinel credentials, private path, query, and fragment redaction.

---

Note

Medium Risk
Touches observability proxy logging and error handling on an authenticated route; behavior for clients is intended to stay the same but mis-handled defects could affect trace collection visibility.

Overview
Browser OTLP decode, local collection, and export failures now use schema tagged errors instead of ad hoc Data.TaggedError types that held full request bodies or collector URLs.

Decode failures map to BrowserOtlpTraceDecodeError with resourceSpanCount and the original cause only; local browserTraceCollector.record defects become BrowserOtlpTraceCollectionError with recordCount and cause. The proxy logs warnings via Effect.catchTags using stable fields (errorTag, causeTag) and does not serialize payloads or records.

Export failures map to BrowserOtlpTraceExportError, which stores redacted URL metadata from getUrlDiagnostics (protocol, hostname, input length) while preserving the cause chain; logs omit credentials, paths, query, and fragments. HTTP behavior is unchanged: decode/collection issues are logged and the handler continues (still 204 when no upstream URL); export failure still returns 502 with "Trace export failed."

Unit tests assert cause identity and redaction; an integration test confirms OTLP requests still return 204 when local collection dies.

^{Reviewed by Cursor Bugbot for commit 8ab9c61. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Structure OTLP export diagnostics with redacted, typed errors in the browser trace handler

• Introduces three typed error classes (BrowserOtlpTraceDecodeError, BrowserOtlpTraceCollectionError, BrowserOtlpTraceExportError) in http.ts to replace broad, unstructured error handling in the POST /api/observability/v1/traces handler.
• Each error class captures only safe diagnostic fields (span/record counts, redacted URL components) and omits raw payloads, records, and collector URLs from logs.
• Adds errorDiagnosticTag helper to derive a causeTag from error causes for structured log output.
• Wraps local trace collection defects with Effect.catchDefect so the handler continues and returns 204 even when BrowserTraceCollector.record throws.
• Behavioral Change: warning logs for decode, collection, and export failures now emit structured fields instead of raw values; the handler no longer logs bodyJson or otlpTracesUrl.

^{Macroscope summarized 8ab9c61.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 5a5b74ac-6bb0-42b8-9cb6-3d318c6614d0

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/redact-otlp-export-diagnostics

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[cursor]

Cursor Bugbot has reviewed your changes using high effort and found 2 potential issues.

Bugbot Autofix prepared fixes for both issues found in the latest run.

• ✅ Fixed: Decode error mapper throws
  • Guarded payload.resourceSpans.length in fromPayload with Array.isArray(payload?.resourceSpans) so it safely returns 0 when resourceSpans is absent, null, or not an array.
• ✅ Fixed: Collector record errors propagate
  • Added Effect.catchDefect after Effect.catchTags to absorb synchronous throw defects from browserTraceCollector.record, logging a warning instead of aborting the request before remote export.

Or push these changes by commenting:

@cursor push bb12877dfd

Preview (bb12877dfd)

diff --git a/apps/server/src/http.ts b/apps/server/src/http.ts--- a/apps/server/src/http.ts+++ b/apps/server/src/http.ts@@ -131,7 +131,7 @@
) {
static fromPayload(payload: OtlpTracer.TraceData, cause: unknown): BrowserOtlpTraceDecodeError {
return new BrowserOtlpTraceDecodeError({
- resourceSpanCount: payload.resourceSpans.length,+ resourceSpanCount: Array.isArray(payload?.resourceSpans) ? payload.resourceSpans.length : 0,
cause,
});
}
@@ -194,6 +194,11 @@
causeTag: errorDiagnosticTag(error.cause),
}),
}),
+ Effect.catchDefect((defect) =>+ Effect.logWarning("Failed to record browser OTLP traces locally.", {+ causeTag: errorDiagnosticTag(defect),+ }),+ ),
);
if (otlpTracesUrl === undefined) {

_{You can send follow-ups to the cloud agent here.}

^{Reviewed by Cursor Bugbot for commit 64e1b72a098f80651a238c4d4206f3f8ba1412b7. Configure here.}

[macroscopeapp]

Approvability

Verdict: Approved

This PR refactors OTLP trace error handling to use structured error classes that avoid retaining sensitive data (trace payloads, URL credentials). The changes preserve existing runtime behavior while improving diagnostic structure, and include comprehensive tests.

^{You can customize Macroscope's approvability policy. Learn more.}

[juliusmarminge]

Problem

Browser OTLP decode and export failures were logged with raw request payloads, collector URLs, and nested causes. Those values can contain credentials or private path, query, and fragment data, and the ad hoc errors did not expose stable structural diagnostics.

Changes

• replace the unstructured decode failure with a schema error carrying resource-span count and the original cause
• add a schema export error that derives safe collector URL diagnostics while preserving the exact cause chain
• use catchTags for the two distinct failures
• log only stable error/cause tags and redacted URL diagnostics; never serialize raw payloads, collector URLs, or nested HTTP causes
• keep the derivation logic on value-adding static error mappers

Validation

• vp check
• vp test apps/server/src/http.test.ts
• vp run typecheck

Tests cover exact cause identity and sentinel credentials, private path, query, and fragment redaction.

---

Note

Medium Risk
Touches observability proxy logging and error handling on an authenticated route; behavior for clients is intended to stay the same but mis-handled defects could affect trace collection visibility.

Overview
Browser OTLP decode, local collection, and export failures now use schema tagged errors instead of ad hoc Data.TaggedError types that held full request bodies or collector URLs.

Decode failures map to BrowserOtlpTraceDecodeError with resourceSpanCount and the original cause only; local browserTraceCollector.record defects become BrowserOtlpTraceCollectionError with recordCount and cause. The proxy logs warnings via Effect.catchTags using stable fields (errorTag, causeTag) and does not serialize payloads or records.

Export failures map to BrowserOtlpTraceExportError, which stores redacted URL metadata from getUrlDiagnostics (protocol, hostname, input length) while preserving the cause chain; logs omit credentials, paths, query, and fragments. HTTP behavior is unchanged: decode/collection issues are logged and the handler continues (still 204 when no upstream URL); export failure still returns 502 with "Trace export failed."

Unit tests assert cause identity and redaction; an integration test confirms OTLP requests still return 204 when local collection dies.

^{Reviewed by Cursor Bugbot for commit 8ab9c61. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Structure OTLP export diagnostics with redacted, typed errors in the browser trace handler

• Introduces three typed error classes (BrowserOtlpTraceDecodeError, BrowserOtlpTraceCollectionError, BrowserOtlpTraceExportError) in http.ts to replace broad, unstructured error handling in the POST /api/observability/v1/traces handler.
• Each error class captures only safe diagnostic fields (span/record counts, redacted URL components) and omits raw payloads, records, and collector URLs from logs.
• Adds errorDiagnosticTag helper to derive a causeTag from error causes for structured log output.
• Wraps local trace collection defects with Effect.catchDefect so the handler continues and returns 204 even when BrowserTraceCollector.record throws.
• Behavioral Change: warning logs for decode, collection, and export failures now emit structured fields instead of raw values; the handler no longer logs bodyJson or otlpTracesUrl.

^{Macroscope summarized 8ab9c61.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 5a5b74ac-6bb0-42b8-9cb6-3d318c6614d0

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/redact-otlp-export-diagnostics

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[cursor]

Cursor Bugbot has reviewed your changes using high effort and found 2 potential issues.

Bugbot Autofix prepared fixes for both issues found in the latest run.

• ✅ Fixed: Decode error mapper throws
  • Guarded payload.resourceSpans.length in fromPayload with Array.isArray(payload?.resourceSpans) so it safely returns 0 when resourceSpans is absent, null, or not an array.
• ✅ Fixed: Collector record errors propagate
  • Added Effect.catchDefect after Effect.catchTags to absorb synchronous throw defects from browserTraceCollector.record, logging a warning instead of aborting the request before remote export.

Or push these changes by commenting:

@cursor push bb12877dfd

Preview (bb12877dfd)

diff --git a/apps/server/src/http.ts b/apps/server/src/http.ts--- a/apps/server/src/http.ts+++ b/apps/server/src/http.ts@@ -131,7 +131,7 @@
) {
static fromPayload(payload: OtlpTracer.TraceData, cause: unknown): BrowserOtlpTraceDecodeError {
return new BrowserOtlpTraceDecodeError({
- resourceSpanCount: payload.resourceSpans.length,+ resourceSpanCount: Array.isArray(payload?.resourceSpans) ? payload.resourceSpans.length : 0,
cause,
});
}
@@ -194,6 +194,11 @@
causeTag: errorDiagnosticTag(error.cause),
}),
}),
+ Effect.catchDefect((defect) =>+ Effect.logWarning("Failed to record browser OTLP traces locally.", {+ causeTag: errorDiagnosticTag(defect),+ }),+ ),
);
if (otlpTracesUrl === undefined) {

_{You can send follow-ups to the cloud agent here.}

^{Reviewed by Cursor Bugbot for commit 64e1b72a098f80651a238c4d4206f3f8ba1412b7. Configure here.}

[macroscopeapp]

Approvability

Verdict: Approved

This PR refactors OTLP trace error handling to use structured error classes that avoid retaining sensitive data (trace payloads, URL credentials). The changes preserve existing runtime behavior while improving diagnostic structure, and include comprehensive tests.

^{You can customize Macroscope's approvability policy. Learn more.}

[juliusmarminge]

Problem

Browser OTLP decode and export failures were logged with raw request payloads, collector URLs, and nested causes. Those values can contain credentials or private path, query, and fragment data, and the ad hoc errors did not expose stable structural diagnostics.

Changes

• replace the unstructured decode failure with a schema error carrying resource-span count and the original cause
• add a schema export error that derives safe collector URL diagnostics while preserving the exact cause chain
• use catchTags for the two distinct failures
• log only stable error/cause tags and redacted URL diagnostics; never serialize raw payloads, collector URLs, or nested HTTP causes
• keep the derivation logic on value-adding static error mappers

Validation

• vp check
• vp test apps/server/src/http.test.ts
• vp run typecheck

Tests cover exact cause identity and sentinel credentials, private path, query, and fragment redaction.

---

Note

Medium Risk
Touches observability proxy logging and error handling on an authenticated route; behavior for clients is intended to stay the same but mis-handled defects could affect trace collection visibility.

Overview
Browser OTLP decode, local collection, and export failures now use schema tagged errors instead of ad hoc Data.TaggedError types that held full request bodies or collector URLs.

Decode failures map to BrowserOtlpTraceDecodeError with resourceSpanCount and the original cause only; local browserTraceCollector.record defects become BrowserOtlpTraceCollectionError with recordCount and cause. The proxy logs warnings via Effect.catchTags using stable fields (errorTag, causeTag) and does not serialize payloads or records.

Export failures map to BrowserOtlpTraceExportError, which stores redacted URL metadata from getUrlDiagnostics (protocol, hostname, input length) while preserving the cause chain; logs omit credentials, paths, query, and fragments. HTTP behavior is unchanged: decode/collection issues are logged and the handler continues (still 204 when no upstream URL); export failure still returns 502 with "Trace export failed."

Unit tests assert cause identity and redaction; an integration test confirms OTLP requests still return 204 when local collection dies.

^{Reviewed by Cursor Bugbot for commit 8ab9c61. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Structure OTLP export diagnostics with redacted, typed errors in the browser trace handler

• Introduces three typed error classes (BrowserOtlpTraceDecodeError, BrowserOtlpTraceCollectionError, BrowserOtlpTraceExportError) in http.ts to replace broad, unstructured error handling in the POST /api/observability/v1/traces handler.
• Each error class captures only safe diagnostic fields (span/record counts, redacted URL components) and omits raw payloads, records, and collector URLs from logs.
• Adds errorDiagnosticTag helper to derive a causeTag from error causes for structured log output.
• Wraps local trace collection defects with Effect.catchDefect so the handler continues and returns 204 even when BrowserTraceCollector.record throws.
• Behavioral Change: warning logs for decode, collection, and export failures now emit structured fields instead of raw values; the handler no longer logs bodyJson or otlpTracesUrl.

^{Macroscope summarized 8ab9c61.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 5a5b74ac-6bb0-42b8-9cb6-3d318c6614d0

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/redact-otlp-export-diagnostics

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[cursor]

Cursor Bugbot has reviewed your changes using high effort and found 2 potential issues.

Bugbot Autofix prepared fixes for both issues found in the latest run.

• ✅ Fixed: Decode error mapper throws
  • Guarded payload.resourceSpans.length in fromPayload with Array.isArray(payload?.resourceSpans) so it safely returns 0 when resourceSpans is absent, null, or not an array.
• ✅ Fixed: Collector record errors propagate
  • Added Effect.catchDefect after Effect.catchTags to absorb synchronous throw defects from browserTraceCollector.record, logging a warning instead of aborting the request before remote export.

Or push these changes by commenting:

@cursor push bb12877dfd

Preview (bb12877dfd)

diff --git a/apps/server/src/http.ts b/apps/server/src/http.ts--- a/apps/server/src/http.ts+++ b/apps/server/src/http.ts@@ -131,7 +131,7 @@
) {
static fromPayload(payload: OtlpTracer.TraceData, cause: unknown): BrowserOtlpTraceDecodeError {
return new BrowserOtlpTraceDecodeError({
- resourceSpanCount: payload.resourceSpans.length,+ resourceSpanCount: Array.isArray(payload?.resourceSpans) ? payload.resourceSpans.length : 0,
cause,
});
}
@@ -194,6 +194,11 @@
causeTag: errorDiagnosticTag(error.cause),
}),
}),
+ Effect.catchDefect((defect) =>+ Effect.logWarning("Failed to record browser OTLP traces locally.", {+ causeTag: errorDiagnosticTag(defect),+ }),+ ),
);
if (otlpTracesUrl === undefined) {

_{You can send follow-ups to the cloud agent here.}

^{Reviewed by Cursor Bugbot for commit 64e1b72a098f80651a238c4d4206f3f8ba1412b7. Configure here.}

[macroscopeapp]

Approvability

Verdict: Approved

This PR refactors OTLP trace error handling to use structured error classes that avoid retaining sensitive data (trace payloads, URL credentials). The changes preserve existing runtime behavior while improving diagnostic structure, and include comprehensive tests.

^{You can customize Macroscope's approvability policy. Learn more.}

[juliusmarminge]

Problem

Browser OTLP decode and export failures were logged with raw request payloads, collector URLs, and nested causes. Those values can contain credentials or private path, query, and fragment data, and the ad hoc errors did not expose stable structural diagnostics.

Changes

• replace the unstructured decode failure with a schema error carrying resource-span count and the original cause
• add a schema export error that derives safe collector URL diagnostics while preserving the exact cause chain
• use catchTags for the two distinct failures
• log only stable error/cause tags and redacted URL diagnostics; never serialize raw payloads, collector URLs, or nested HTTP causes
• keep the derivation logic on value-adding static error mappers

Validation

• vp check
• vp test apps/server/src/http.test.ts
• vp run typecheck

Tests cover exact cause identity and sentinel credentials, private path, query, and fragment redaction.

---

Note

Medium Risk
Touches observability proxy logging and error handling on an authenticated route; behavior for clients is intended to stay the same but mis-handled defects could affect trace collection visibility.

Overview
Browser OTLP decode, local collection, and export failures now use schema tagged errors instead of ad hoc Data.TaggedError types that held full request bodies or collector URLs.

Decode failures map to BrowserOtlpTraceDecodeError with resourceSpanCount and the original cause only; local browserTraceCollector.record defects become BrowserOtlpTraceCollectionError with recordCount and cause. The proxy logs warnings via Effect.catchTags using stable fields (errorTag, causeTag) and does not serialize payloads or records.

Export failures map to BrowserOtlpTraceExportError, which stores redacted URL metadata from getUrlDiagnostics (protocol, hostname, input length) while preserving the cause chain; logs omit credentials, paths, query, and fragments. HTTP behavior is unchanged: decode/collection issues are logged and the handler continues (still 204 when no upstream URL); export failure still returns 502 with "Trace export failed."

Unit tests assert cause identity and redaction; an integration test confirms OTLP requests still return 204 when local collection dies.

^{Reviewed by Cursor Bugbot for commit 8ab9c61. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Structure OTLP export diagnostics with redacted, typed errors in the browser trace handler

• Introduces three typed error classes (BrowserOtlpTraceDecodeError, BrowserOtlpTraceCollectionError, BrowserOtlpTraceExportError) in http.ts to replace broad, unstructured error handling in the POST /api/observability/v1/traces handler.
• Each error class captures only safe diagnostic fields (span/record counts, redacted URL components) and omits raw payloads, records, and collector URLs from logs.
• Adds errorDiagnosticTag helper to derive a causeTag from error causes for structured log output.
• Wraps local trace collection defects with Effect.catchDefect so the handler continues and returns 204 even when BrowserTraceCollector.record throws.
• Behavioral Change: warning logs for decode, collection, and export failures now emit structured fields instead of raw values; the handler no longer logs bodyJson or otlpTracesUrl.

^{Macroscope summarized 8ab9c61.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 5a5b74ac-6bb0-42b8-9cb6-3d318c6614d0

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/redact-otlp-export-diagnostics

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[cursor]

Cursor Bugbot has reviewed your changes using high effort and found 2 potential issues.

Bugbot Autofix prepared fixes for both issues found in the latest run.

• ✅ Fixed: Decode error mapper throws
  • Guarded payload.resourceSpans.length in fromPayload with Array.isArray(payload?.resourceSpans) so it safely returns 0 when resourceSpans is absent, null, or not an array.
• ✅ Fixed: Collector record errors propagate
  • Added Effect.catchDefect after Effect.catchTags to absorb synchronous throw defects from browserTraceCollector.record, logging a warning instead of aborting the request before remote export.

Or push these changes by commenting:

@cursor push bb12877dfd

Preview (bb12877dfd)

diff --git a/apps/server/src/http.ts b/apps/server/src/http.ts--- a/apps/server/src/http.ts+++ b/apps/server/src/http.ts@@ -131,7 +131,7 @@
) {
static fromPayload(payload: OtlpTracer.TraceData, cause: unknown): BrowserOtlpTraceDecodeError {
return new BrowserOtlpTraceDecodeError({
- resourceSpanCount: payload.resourceSpans.length,+ resourceSpanCount: Array.isArray(payload?.resourceSpans) ? payload.resourceSpans.length : 0,
cause,
});
}
@@ -194,6 +194,11 @@
causeTag: errorDiagnosticTag(error.cause),
}),
}),
+ Effect.catchDefect((defect) =>+ Effect.logWarning("Failed to record browser OTLP traces locally.", {+ causeTag: errorDiagnosticTag(defect),+ }),+ ),
);
if (otlpTracesUrl === undefined) {

_{You can send follow-ups to the cloud agent here.}

^{Reviewed by Cursor Bugbot for commit 64e1b72a098f80651a238c4d4206f3f8ba1412b7. Configure here.}

[macroscopeapp]

Approvability

Verdict: Approved

This PR refactors OTLP trace error handling to use structured error classes that avoid retaining sensitive data (trace payloads, URL credentials). The changes preserve existing runtime behavior while improving diagnostic structure, and include comprehensive tests.

^{You can customize Macroscope's approvability policy. Learn more.}

[juliusmarminge]

Problem

Browser OTLP decode and export failures were logged with raw request payloads, collector URLs, and nested causes. Those values can contain credentials or private path, query, and fragment data, and the ad hoc errors did not expose stable structural diagnostics.

Changes

• replace the unstructured decode failure with a schema error carrying resource-span count and the original cause
• add a schema export error that derives safe collector URL diagnostics while preserving the exact cause chain
• use catchTags for the two distinct failures
• log only stable error/cause tags and redacted URL diagnostics; never serialize raw payloads, collector URLs, or nested HTTP causes
• keep the derivation logic on value-adding static error mappers

Validation

• vp check
• vp test apps/server/src/http.test.ts
• vp run typecheck

Tests cover exact cause identity and sentinel credentials, private path, query, and fragment redaction.

---

Note

Medium Risk
Touches observability proxy logging and error handling on an authenticated route; behavior for clients is intended to stay the same but mis-handled defects could affect trace collection visibility.

Overview
Browser OTLP decode, local collection, and export failures now use schema tagged errors instead of ad hoc Data.TaggedError types that held full request bodies or collector URLs.

Decode failures map to BrowserOtlpTraceDecodeError with resourceSpanCount and the original cause only; local browserTraceCollector.record defects become BrowserOtlpTraceCollectionError with recordCount and cause. The proxy logs warnings via Effect.catchTags using stable fields (errorTag, causeTag) and does not serialize payloads or records.

Export failures map to BrowserOtlpTraceExportError, which stores redacted URL metadata from getUrlDiagnostics (protocol, hostname, input length) while preserving the cause chain; logs omit credentials, paths, query, and fragments. HTTP behavior is unchanged: decode/collection issues are logged and the handler continues (still 204 when no upstream URL); export failure still returns 502 with "Trace export failed."

Unit tests assert cause identity and redaction; an integration test confirms OTLP requests still return 204 when local collection dies.

^{Reviewed by Cursor Bugbot for commit 8ab9c61. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Structure OTLP export diagnostics with redacted, typed errors in the browser trace handler

• Introduces three typed error classes (BrowserOtlpTraceDecodeError, BrowserOtlpTraceCollectionError, BrowserOtlpTraceExportError) in http.ts to replace broad, unstructured error handling in the POST /api/observability/v1/traces handler.
• Each error class captures only safe diagnostic fields (span/record counts, redacted URL components) and omits raw payloads, records, and collector URLs from logs.
• Adds errorDiagnosticTag helper to derive a causeTag from error causes for structured log output.
• Wraps local trace collection defects with Effect.catchDefect so the handler continues and returns 204 even when BrowserTraceCollector.record throws.
• Behavioral Change: warning logs for decode, collection, and export failures now emit structured fields instead of raw values; the handler no longer logs bodyJson or otlpTracesUrl.

^{Macroscope summarized 8ab9c61.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 5a5b74ac-6bb0-42b8-9cb6-3d318c6614d0

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/redact-otlp-export-diagnostics

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[cursor]

Cursor Bugbot has reviewed your changes using high effort and found 2 potential issues.

Bugbot Autofix prepared fixes for both issues found in the latest run.

• ✅ Fixed: Decode error mapper throws
  • Guarded payload.resourceSpans.length in fromPayload with Array.isArray(payload?.resourceSpans) so it safely returns 0 when resourceSpans is absent, null, or not an array.
• ✅ Fixed: Collector record errors propagate
  • Added Effect.catchDefect after Effect.catchTags to absorb synchronous throw defects from browserTraceCollector.record, logging a warning instead of aborting the request before remote export.

Or push these changes by commenting:

@cursor push bb12877dfd

Preview (bb12877dfd)

diff --git a/apps/server/src/http.ts b/apps/server/src/http.ts--- a/apps/server/src/http.ts+++ b/apps/server/src/http.ts@@ -131,7 +131,7 @@
) {
static fromPayload(payload: OtlpTracer.TraceData, cause: unknown): BrowserOtlpTraceDecodeError {
return new BrowserOtlpTraceDecodeError({
- resourceSpanCount: payload.resourceSpans.length,+ resourceSpanCount: Array.isArray(payload?.resourceSpans) ? payload.resourceSpans.length : 0,
cause,
});
}
@@ -194,6 +194,11 @@
causeTag: errorDiagnosticTag(error.cause),
}),
}),
+ Effect.catchDefect((defect) =>+ Effect.logWarning("Failed to record browser OTLP traces locally.", {+ causeTag: errorDiagnosticTag(defect),+ }),+ ),
);
if (otlpTracesUrl === undefined) {

_{You can send follow-ups to the cloud agent here.}

^{Reviewed by Cursor Bugbot for commit 64e1b72a098f80651a238c4d4206f3f8ba1412b7. Configure here.}

[macroscopeapp]

Approvability

Verdict: Approved

This PR refactors OTLP trace error handling to use structured error classes that avoid retaining sensitive data (trace payloads, URL credentials). The changes preserve existing runtime behavior while improving diagnostic structure, and include comprehensive tests.

^{You can customize Macroscope's approvability policy. Learn more.}

[juliusmarminge]

Problem

Browser OTLP decode and export failures were logged with raw request payloads, collector URLs, and nested causes. Those values can contain credentials or private path, query, and fragment data, and the ad hoc errors did not expose stable structural diagnostics.

Changes

• replace the unstructured decode failure with a schema error carrying resource-span count and the original cause
• add a schema export error that derives safe collector URL diagnostics while preserving the exact cause chain
• use catchTags for the two distinct failures
• log only stable error/cause tags and redacted URL diagnostics; never serialize raw payloads, collector URLs, or nested HTTP causes
• keep the derivation logic on value-adding static error mappers

Validation

• vp check
• vp test apps/server/src/http.test.ts
• vp run typecheck

Tests cover exact cause identity and sentinel credentials, private path, query, and fragment redaction.

---

Note

Medium Risk
Touches observability proxy logging and error handling on an authenticated route; behavior for clients is intended to stay the same but mis-handled defects could affect trace collection visibility.

Overview
Browser OTLP decode, local collection, and export failures now use schema tagged errors instead of ad hoc Data.TaggedError types that held full request bodies or collector URLs.

Decode failures map to BrowserOtlpTraceDecodeError with resourceSpanCount and the original cause only; local browserTraceCollector.record defects become BrowserOtlpTraceCollectionError with recordCount and cause. The proxy logs warnings via Effect.catchTags using stable fields (errorTag, causeTag) and does not serialize payloads or records.

Export failures map to BrowserOtlpTraceExportError, which stores redacted URL metadata from getUrlDiagnostics (protocol, hostname, input length) while preserving the cause chain; logs omit credentials, paths, query, and fragments. HTTP behavior is unchanged: decode/collection issues are logged and the handler continues (still 204 when no upstream URL); export failure still returns 502 with "Trace export failed."

Unit tests assert cause identity and redaction; an integration test confirms OTLP requests still return 204 when local collection dies.

^{Reviewed by Cursor Bugbot for commit 8ab9c61. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Structure OTLP export diagnostics with redacted, typed errors in the browser trace handler

• Introduces three typed error classes (BrowserOtlpTraceDecodeError, BrowserOtlpTraceCollectionError, BrowserOtlpTraceExportError) in http.ts to replace broad, unstructured error handling in the POST /api/observability/v1/traces handler.
• Each error class captures only safe diagnostic fields (span/record counts, redacted URL components) and omits raw payloads, records, and collector URLs from logs.
• Adds errorDiagnosticTag helper to derive a causeTag from error causes for structured log output.
• Wraps local trace collection defects with Effect.catchDefect so the handler continues and returns 204 even when BrowserTraceCollector.record throws.
• Behavioral Change: warning logs for decode, collection, and export failures now emit structured fields instead of raw values; the handler no longer logs bodyJson or otlpTracesUrl.

^{Macroscope summarized 8ab9c61.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 5a5b74ac-6bb0-42b8-9cb6-3d318c6614d0

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/redact-otlp-export-diagnostics

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[cursor]

Cursor Bugbot has reviewed your changes using high effort and found 2 potential issues.

Bugbot Autofix prepared fixes for both issues found in the latest run.

• ✅ Fixed: Decode error mapper throws
  • Guarded payload.resourceSpans.length in fromPayload with Array.isArray(payload?.resourceSpans) so it safely returns 0 when resourceSpans is absent, null, or not an array.
• ✅ Fixed: Collector record errors propagate
  • Added Effect.catchDefect after Effect.catchTags to absorb synchronous throw defects from browserTraceCollector.record, logging a warning instead of aborting the request before remote export.

Or push these changes by commenting:

@cursor push bb12877dfd

Preview (bb12877dfd)

diff --git a/apps/server/src/http.ts b/apps/server/src/http.ts--- a/apps/server/src/http.ts+++ b/apps/server/src/http.ts@@ -131,7 +131,7 @@
) {
static fromPayload(payload: OtlpTracer.TraceData, cause: unknown): BrowserOtlpTraceDecodeError {
return new BrowserOtlpTraceDecodeError({
- resourceSpanCount: payload.resourceSpans.length,+ resourceSpanCount: Array.isArray(payload?.resourceSpans) ? payload.resourceSpans.length : 0,
cause,
});
}
@@ -194,6 +194,11 @@
causeTag: errorDiagnosticTag(error.cause),
}),
}),
+ Effect.catchDefect((defect) =>+ Effect.logWarning("Failed to record browser OTLP traces locally.", {+ causeTag: errorDiagnosticTag(defect),+ }),+ ),
);
if (otlpTracesUrl === undefined) {

_{You can send follow-ups to the cloud agent here.}

^{Reviewed by Cursor Bugbot for commit 64e1b72a098f80651a238c4d4206f3f8ba1412b7. Configure here.}

[macroscopeapp]

Approvability

Verdict: Approved

This PR refactors OTLP trace error handling to use structured error classes that avoid retaining sensitive data (trace payloads, URL credentials). The changes preserve existing runtime behavior while improving diagnostic structure, and include comprehensive tests.

^{You can customize Macroscope's approvability policy. Learn more.}