[codex] Sanitize client runtime failure diagnostics by juliusmarminge · Pull Request #3411 · pingdotgg/t3code

juliusmarminge · 2026-06-20T17:36:53Z

Summary

project shell cache, session bootstrap, and supervisor defects into the shared safe error-log attributes instead of serializing messages, nested errors, or Cause.pretty output
keep archived-thread and shell synchronization UI failures generic rather than exposing remote or persistence error messages
retain safe correlation data and stack frames through the shared projection

This is stacked on #3405 for the shared safe projection. The separate approved #3255 owns the connection error schema cause fields, so this PR intentionally avoids overlapping connection/model.ts.

Validation

vp test packages/client-runtime/src/errors packages/client-runtime/src/state/archivedThreads.test.ts packages/client-runtime/src/state/session.test.ts packages/client-runtime/src/state/shell.test.ts packages/client-runtime/src/state/shell-sync.test.ts packages/client-runtime/src/connection/supervisor.test.ts (46 tests)
vp check
vp run typecheck

Note

Low Risk
Intentional reduction of error detail in UI and logs; no auth or data-path logic changes, with tests covering archived-thread message sanitization.

Overview
Sanitizes client-runtime failure handling so logs and reactive state no longer surface raw error messages, nested errors, or full Cause.pretty output.

Connection supervisor unexpected-defect logs now record cause.reason_count and safeErrorLogAttributes from the die defect instead of a pretty-printed cause. Session bootstrap and shell cache/persist/sync warnings use the same safe projection for structured logs; shell stream failures still log the real error safely but set UI state to the fixed message "Could not synchronize environment data."Archived thread snapshot failures always expose "Failed to load archived threads." in atom state, with a test asserting sensitive Error.message text is not leaked.

Behavior change: operators and users see generic copy where underlying persistence/remote messages used to appear; diagnostics remain in logs via sanitized type/name/tag/trace/stack fields.

^{Reviewed by Cursor Bugbot for commit 44a4c95. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Sanitize client runtime failure diagnostics to avoid exposing raw error details

In supervisor.ts, replaces the pretty-printed cause in defect logs with reason_count and sanitized error attributes via safeErrorLogAttributes.
In archivedThreads.ts, archived thread snapshot failures now always return the generic message 'Failed to load archived threads.' instead of the underlying error message.
In session.ts and shell.ts, initial config load and shell sync error logs now use sanitized attributes instead of raw error objects.
Behavioral Change: error messages surfaced to callers and logs are now generic/sanitized; previously, raw error messages may have been exposed in state and structured logs.

^{Macroscope summarized 44a4c95.}

coderabbitai · 2026-06-20T17:37:01Z

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 9c841aea-ed53-4645-a200-539fbe690e6e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch codex/sanitize-client-runtime-diagnostics

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Co-authored-by: codex <codex@users.noreply.github.com>

macroscopeapp · 2026-06-20T17:40:35Z

Approvability

Verdict: Approved

This PR sanitizes error logging by replacing potentially sensitive error messages with generic user-facing strings and a safe metadata extraction utility. The changes are security-focused, well-scoped, and include test coverage confirming sensitive data is not exposed.

^{You can customize Macroscope's approvability policy. Learn more.}

juliusmarminge · 2026-06-20T17:36:53Z

Summary

project shell cache, session bootstrap, and supervisor defects into the shared safe error-log attributes instead of serializing messages, nested errors, or Cause.pretty output
keep archived-thread and shell synchronization UI failures generic rather than exposing remote or persistence error messages
retain safe correlation data and stack frames through the shared projection

This is stacked on #3405 for the shared safe projection. The separate approved #3255 owns the connection error schema cause fields, so this PR intentionally avoids overlapping connection/model.ts.

Validation

vp test packages/client-runtime/src/errors packages/client-runtime/src/state/archivedThreads.test.ts packages/client-runtime/src/state/session.test.ts packages/client-runtime/src/state/shell.test.ts packages/client-runtime/src/state/shell-sync.test.ts packages/client-runtime/src/connection/supervisor.test.ts (46 tests)
vp check
vp run typecheck

Note

Low Risk
Intentional reduction of error detail in UI and logs; no auth or data-path logic changes, with tests covering archived-thread message sanitization.

Overview
Sanitizes client-runtime failure handling so logs and reactive state no longer surface raw error messages, nested errors, or full Cause.pretty output.

Connection supervisor unexpected-defect logs now record cause.reason_count and safeErrorLogAttributes from the die defect instead of a pretty-printed cause. Session bootstrap and shell cache/persist/sync warnings use the same safe projection for structured logs; shell stream failures still log the real error safely but set UI state to the fixed message "Could not synchronize environment data."Archived thread snapshot failures always expose "Failed to load archived threads." in atom state, with a test asserting sensitive Error.message text is not leaked.

Behavior change: operators and users see generic copy where underlying persistence/remote messages used to appear; diagnostics remain in logs via sanitized type/name/tag/trace/stack fields.

^{Reviewed by Cursor Bugbot for commit 44a4c95. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Sanitize client runtime failure diagnostics to avoid exposing raw error details

In supervisor.ts, replaces the pretty-printed cause in defect logs with reason_count and sanitized error attributes via safeErrorLogAttributes.
In archivedThreads.ts, archived thread snapshot failures now always return the generic message 'Failed to load archived threads.' instead of the underlying error message.
In session.ts and shell.ts, initial config load and shell sync error logs now use sanitized attributes instead of raw error objects.
Behavioral Change: error messages surfaced to callers and logs are now generic/sanitized; previously, raw error messages may have been exposed in state and structured logs.

^{Macroscope summarized 44a4c95.}

coderabbitai · 2026-06-20T17:37:01Z

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 9c841aea-ed53-4645-a200-539fbe690e6e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch codex/sanitize-client-runtime-diagnostics

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Co-authored-by: codex <codex@users.noreply.github.com>

macroscopeapp · 2026-06-20T17:40:35Z

Approvability

Verdict: Approved

This PR sanitizes error logging by replacing potentially sensitive error messages with generic user-facing strings and a safe metadata extraction utility. The changes are security-focused, well-scoped, and include test coverage confirming sensitive data is not exposed.

^{You can customize Macroscope's approvability policy. Learn more.}

juliusmarminge · 2026-06-20T17:36:53Z

Summary

project shell cache, session bootstrap, and supervisor defects into the shared safe error-log attributes instead of serializing messages, nested errors, or Cause.pretty output
keep archived-thread and shell synchronization UI failures generic rather than exposing remote or persistence error messages
retain safe correlation data and stack frames through the shared projection

This is stacked on #3405 for the shared safe projection. The separate approved #3255 owns the connection error schema cause fields, so this PR intentionally avoids overlapping connection/model.ts.

Validation

vp test packages/client-runtime/src/errors packages/client-runtime/src/state/archivedThreads.test.ts packages/client-runtime/src/state/session.test.ts packages/client-runtime/src/state/shell.test.ts packages/client-runtime/src/state/shell-sync.test.ts packages/client-runtime/src/connection/supervisor.test.ts (46 tests)
vp check
vp run typecheck

Note

Low Risk
Intentional reduction of error detail in UI and logs; no auth or data-path logic changes, with tests covering archived-thread message sanitization.

Overview
Sanitizes client-runtime failure handling so logs and reactive state no longer surface raw error messages, nested errors, or full Cause.pretty output.

Connection supervisor unexpected-defect logs now record cause.reason_count and safeErrorLogAttributes from the die defect instead of a pretty-printed cause. Session bootstrap and shell cache/persist/sync warnings use the same safe projection for structured logs; shell stream failures still log the real error safely but set UI state to the fixed message "Could not synchronize environment data."Archived thread snapshot failures always expose "Failed to load archived threads." in atom state, with a test asserting sensitive Error.message text is not leaked.

Behavior change: operators and users see generic copy where underlying persistence/remote messages used to appear; diagnostics remain in logs via sanitized type/name/tag/trace/stack fields.

^{Reviewed by Cursor Bugbot for commit 44a4c95. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Sanitize client runtime failure diagnostics to avoid exposing raw error details

In supervisor.ts, replaces the pretty-printed cause in defect logs with reason_count and sanitized error attributes via safeErrorLogAttributes.
In archivedThreads.ts, archived thread snapshot failures now always return the generic message 'Failed to load archived threads.' instead of the underlying error message.
In session.ts and shell.ts, initial config load and shell sync error logs now use sanitized attributes instead of raw error objects.
Behavioral Change: error messages surfaced to callers and logs are now generic/sanitized; previously, raw error messages may have been exposed in state and structured logs.

^{Macroscope summarized 44a4c95.}

coderabbitai · 2026-06-20T17:37:01Z

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 9c841aea-ed53-4645-a200-539fbe690e6e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch codex/sanitize-client-runtime-diagnostics

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Co-authored-by: codex <codex@users.noreply.github.com>

macroscopeapp · 2026-06-20T17:40:35Z

Approvability

Verdict: Approved

This PR sanitizes error logging by replacing potentially sensitive error messages with generic user-facing strings and a safe metadata extraction utility. The changes are security-focused, well-scoped, and include test coverage confirming sensitive data is not exposed.

^{You can customize Macroscope's approvability policy. Learn more.}

juliusmarminge · 2026-06-20T17:36:53Z

Summary

project shell cache, session bootstrap, and supervisor defects into the shared safe error-log attributes instead of serializing messages, nested errors, or Cause.pretty output
keep archived-thread and shell synchronization UI failures generic rather than exposing remote or persistence error messages
retain safe correlation data and stack frames through the shared projection

This is stacked on #3405 for the shared safe projection. The separate approved #3255 owns the connection error schema cause fields, so this PR intentionally avoids overlapping connection/model.ts.

Validation

vp test packages/client-runtime/src/errors packages/client-runtime/src/state/archivedThreads.test.ts packages/client-runtime/src/state/session.test.ts packages/client-runtime/src/state/shell.test.ts packages/client-runtime/src/state/shell-sync.test.ts packages/client-runtime/src/connection/supervisor.test.ts (46 tests)
vp check
vp run typecheck

Note

Low Risk
Intentional reduction of error detail in UI and logs; no auth or data-path logic changes, with tests covering archived-thread message sanitization.

Overview
Sanitizes client-runtime failure handling so logs and reactive state no longer surface raw error messages, nested errors, or full Cause.pretty output.

Connection supervisor unexpected-defect logs now record cause.reason_count and safeErrorLogAttributes from the die defect instead of a pretty-printed cause. Session bootstrap and shell cache/persist/sync warnings use the same safe projection for structured logs; shell stream failures still log the real error safely but set UI state to the fixed message "Could not synchronize environment data."Archived thread snapshot failures always expose "Failed to load archived threads." in atom state, with a test asserting sensitive Error.message text is not leaked.

Behavior change: operators and users see generic copy where underlying persistence/remote messages used to appear; diagnostics remain in logs via sanitized type/name/tag/trace/stack fields.

^{Reviewed by Cursor Bugbot for commit 44a4c95. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Sanitize client runtime failure diagnostics to avoid exposing raw error details

In supervisor.ts, replaces the pretty-printed cause in defect logs with reason_count and sanitized error attributes via safeErrorLogAttributes.
In archivedThreads.ts, archived thread snapshot failures now always return the generic message 'Failed to load archived threads.' instead of the underlying error message.
In session.ts and shell.ts, initial config load and shell sync error logs now use sanitized attributes instead of raw error objects.
Behavioral Change: error messages surfaced to callers and logs are now generic/sanitized; previously, raw error messages may have been exposed in state and structured logs.

^{Macroscope summarized 44a4c95.}

coderabbitai · 2026-06-20T17:37:01Z

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 9c841aea-ed53-4645-a200-539fbe690e6e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch codex/sanitize-client-runtime-diagnostics

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Co-authored-by: codex <codex@users.noreply.github.com>

macroscopeapp · 2026-06-20T17:40:35Z

Approvability

Verdict: Approved

This PR sanitizes error logging by replacing potentially sensitive error messages with generic user-facing strings and a safe metadata extraction utility. The changes are security-focused, well-scoped, and include test coverage confirming sensitive data is not exposed.

^{You can customize Macroscope's approvability policy. Learn more.}

juliusmarminge · 2026-06-20T17:36:53Z

Summary

project shell cache, session bootstrap, and supervisor defects into the shared safe error-log attributes instead of serializing messages, nested errors, or Cause.pretty output
keep archived-thread and shell synchronization UI failures generic rather than exposing remote or persistence error messages
retain safe correlation data and stack frames through the shared projection

This is stacked on #3405 for the shared safe projection. The separate approved #3255 owns the connection error schema cause fields, so this PR intentionally avoids overlapping connection/model.ts.

Validation

vp test packages/client-runtime/src/errors packages/client-runtime/src/state/archivedThreads.test.ts packages/client-runtime/src/state/session.test.ts packages/client-runtime/src/state/shell.test.ts packages/client-runtime/src/state/shell-sync.test.ts packages/client-runtime/src/connection/supervisor.test.ts (46 tests)
vp check
vp run typecheck

Note

Low Risk
Intentional reduction of error detail in UI and logs; no auth or data-path logic changes, with tests covering archived-thread message sanitization.

Overview
Sanitizes client-runtime failure handling so logs and reactive state no longer surface raw error messages, nested errors, or full Cause.pretty output.

Connection supervisor unexpected-defect logs now record cause.reason_count and safeErrorLogAttributes from the die defect instead of a pretty-printed cause. Session bootstrap and shell cache/persist/sync warnings use the same safe projection for structured logs; shell stream failures still log the real error safely but set UI state to the fixed message "Could not synchronize environment data."Archived thread snapshot failures always expose "Failed to load archived threads." in atom state, with a test asserting sensitive Error.message text is not leaked.

Behavior change: operators and users see generic copy where underlying persistence/remote messages used to appear; diagnostics remain in logs via sanitized type/name/tag/trace/stack fields.

^{Reviewed by Cursor Bugbot for commit 44a4c95. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Sanitize client runtime failure diagnostics to avoid exposing raw error details

In supervisor.ts, replaces the pretty-printed cause in defect logs with reason_count and sanitized error attributes via safeErrorLogAttributes.
In archivedThreads.ts, archived thread snapshot failures now always return the generic message 'Failed to load archived threads.' instead of the underlying error message.
In session.ts and shell.ts, initial config load and shell sync error logs now use sanitized attributes instead of raw error objects.
Behavioral Change: error messages surfaced to callers and logs are now generic/sanitized; previously, raw error messages may have been exposed in state and structured logs.

^{Macroscope summarized 44a4c95.}

coderabbitai · 2026-06-20T17:37:01Z

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 9c841aea-ed53-4645-a200-539fbe690e6e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch codex/sanitize-client-runtime-diagnostics

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Co-authored-by: codex <codex@users.noreply.github.com>

macroscopeapp · 2026-06-20T17:40:35Z

Approvability

Verdict: Approved

This PR sanitizes error logging by replacing potentially sensitive error messages with generic user-facing strings and a safe metadata extraction utility. The changes are security-focused, well-scoped, and include test coverage confirming sensitive data is not exposed.

^{You can customize Macroscope's approvability policy. Learn more.}

juliusmarminge · 2026-06-20T17:36:53Z

Summary

project shell cache, session bootstrap, and supervisor defects into the shared safe error-log attributes instead of serializing messages, nested errors, or Cause.pretty output
keep archived-thread and shell synchronization UI failures generic rather than exposing remote or persistence error messages
retain safe correlation data and stack frames through the shared projection

This is stacked on #3405 for the shared safe projection. The separate approved #3255 owns the connection error schema cause fields, so this PR intentionally avoids overlapping connection/model.ts.

Validation

vp test packages/client-runtime/src/errors packages/client-runtime/src/state/archivedThreads.test.ts packages/client-runtime/src/state/session.test.ts packages/client-runtime/src/state/shell.test.ts packages/client-runtime/src/state/shell-sync.test.ts packages/client-runtime/src/connection/supervisor.test.ts (46 tests)
vp check
vp run typecheck

Note

Low Risk
Intentional reduction of error detail in UI and logs; no auth or data-path logic changes, with tests covering archived-thread message sanitization.

Overview
Sanitizes client-runtime failure handling so logs and reactive state no longer surface raw error messages, nested errors, or full Cause.pretty output.

Connection supervisor unexpected-defect logs now record cause.reason_count and safeErrorLogAttributes from the die defect instead of a pretty-printed cause. Session bootstrap and shell cache/persist/sync warnings use the same safe projection for structured logs; shell stream failures still log the real error safely but set UI state to the fixed message "Could not synchronize environment data."Archived thread snapshot failures always expose "Failed to load archived threads." in atom state, with a test asserting sensitive Error.message text is not leaked.

Behavior change: operators and users see generic copy where underlying persistence/remote messages used to appear; diagnostics remain in logs via sanitized type/name/tag/trace/stack fields.

^{Reviewed by Cursor Bugbot for commit 44a4c95. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Sanitize client runtime failure diagnostics to avoid exposing raw error details

In supervisor.ts, replaces the pretty-printed cause in defect logs with reason_count and sanitized error attributes via safeErrorLogAttributes.
In archivedThreads.ts, archived thread snapshot failures now always return the generic message 'Failed to load archived threads.' instead of the underlying error message.
In session.ts and shell.ts, initial config load and shell sync error logs now use sanitized attributes instead of raw error objects.
Behavioral Change: error messages surfaced to callers and logs are now generic/sanitized; previously, raw error messages may have been exposed in state and structured logs.

^{Macroscope summarized 44a4c95.}

coderabbitai · 2026-06-20T17:37:01Z

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 9c841aea-ed53-4645-a200-539fbe690e6e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch codex/sanitize-client-runtime-diagnostics

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Co-authored-by: codex <codex@users.noreply.github.com>

macroscopeapp · 2026-06-20T17:40:35Z

Approvability

Verdict: Approved

This PR sanitizes error logging by replacing potentially sensitive error messages with generic user-facing strings and a safe metadata extraction utility. The changes are security-focused, well-scoped, and include test coverage confirming sensitive data is not exposed.

^{You can customize Macroscope's approvability policy. Learn more.}

juliusmarminge · 2026-06-20T17:36:53Z

Summary

project shell cache, session bootstrap, and supervisor defects into the shared safe error-log attributes instead of serializing messages, nested errors, or Cause.pretty output
keep archived-thread and shell synchronization UI failures generic rather than exposing remote or persistence error messages
retain safe correlation data and stack frames through the shared projection

This is stacked on #3405 for the shared safe projection. The separate approved #3255 owns the connection error schema cause fields, so this PR intentionally avoids overlapping connection/model.ts.

Validation

vp test packages/client-runtime/src/errors packages/client-runtime/src/state/archivedThreads.test.ts packages/client-runtime/src/state/session.test.ts packages/client-runtime/src/state/shell.test.ts packages/client-runtime/src/state/shell-sync.test.ts packages/client-runtime/src/connection/supervisor.test.ts (46 tests)
vp check
vp run typecheck

Note

Low Risk
Intentional reduction of error detail in UI and logs; no auth or data-path logic changes, with tests covering archived-thread message sanitization.

Overview
Sanitizes client-runtime failure handling so logs and reactive state no longer surface raw error messages, nested errors, or full Cause.pretty output.

Connection supervisor unexpected-defect logs now record cause.reason_count and safeErrorLogAttributes from the die defect instead of a pretty-printed cause. Session bootstrap and shell cache/persist/sync warnings use the same safe projection for structured logs; shell stream failures still log the real error safely but set UI state to the fixed message "Could not synchronize environment data."Archived thread snapshot failures always expose "Failed to load archived threads." in atom state, with a test asserting sensitive Error.message text is not leaked.

Behavior change: operators and users see generic copy where underlying persistence/remote messages used to appear; diagnostics remain in logs via sanitized type/name/tag/trace/stack fields.

^{Reviewed by Cursor Bugbot for commit 44a4c95. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Sanitize client runtime failure diagnostics to avoid exposing raw error details

In supervisor.ts, replaces the pretty-printed cause in defect logs with reason_count and sanitized error attributes via safeErrorLogAttributes.
In archivedThreads.ts, archived thread snapshot failures now always return the generic message 'Failed to load archived threads.' instead of the underlying error message.
In session.ts and shell.ts, initial config load and shell sync error logs now use sanitized attributes instead of raw error objects.
Behavioral Change: error messages surfaced to callers and logs are now generic/sanitized; previously, raw error messages may have been exposed in state and structured logs.

^{Macroscope summarized 44a4c95.}

coderabbitai · 2026-06-20T17:37:01Z

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 9c841aea-ed53-4645-a200-539fbe690e6e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch codex/sanitize-client-runtime-diagnostics

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Co-authored-by: codex <codex@users.noreply.github.com>

macroscopeapp · 2026-06-20T17:40:35Z

Approvability

Verdict: Approved

This PR sanitizes error logging by replacing potentially sensitive error messages with generic user-facing strings and a safe metadata extraction utility. The changes are security-focused, well-scoped, and include test coverage confirming sensitive data is not exposed.

^{You can customize Macroscope's approvability policy. Learn more.}

juliusmarminge · 2026-06-20T17:36:53Z

Summary

project shell cache, session bootstrap, and supervisor defects into the shared safe error-log attributes instead of serializing messages, nested errors, or Cause.pretty output
keep archived-thread and shell synchronization UI failures generic rather than exposing remote or persistence error messages
retain safe correlation data and stack frames through the shared projection

This is stacked on #3405 for the shared safe projection. The separate approved #3255 owns the connection error schema cause fields, so this PR intentionally avoids overlapping connection/model.ts.

Validation

vp test packages/client-runtime/src/errors packages/client-runtime/src/state/archivedThreads.test.ts packages/client-runtime/src/state/session.test.ts packages/client-runtime/src/state/shell.test.ts packages/client-runtime/src/state/shell-sync.test.ts packages/client-runtime/src/connection/supervisor.test.ts (46 tests)
vp check
vp run typecheck

Note

Low Risk
Intentional reduction of error detail in UI and logs; no auth or data-path logic changes, with tests covering archived-thread message sanitization.

Overview
Sanitizes client-runtime failure handling so logs and reactive state no longer surface raw error messages, nested errors, or full Cause.pretty output.

Connection supervisor unexpected-defect logs now record cause.reason_count and safeErrorLogAttributes from the die defect instead of a pretty-printed cause. Session bootstrap and shell cache/persist/sync warnings use the same safe projection for structured logs; shell stream failures still log the real error safely but set UI state to the fixed message "Could not synchronize environment data."Archived thread snapshot failures always expose "Failed to load archived threads." in atom state, with a test asserting sensitive Error.message text is not leaked.

Behavior change: operators and users see generic copy where underlying persistence/remote messages used to appear; diagnostics remain in logs via sanitized type/name/tag/trace/stack fields.

^{Reviewed by Cursor Bugbot for commit 44a4c95. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Sanitize client runtime failure diagnostics to avoid exposing raw error details

In supervisor.ts, replaces the pretty-printed cause in defect logs with reason_count and sanitized error attributes via safeErrorLogAttributes.
In archivedThreads.ts, archived thread snapshot failures now always return the generic message 'Failed to load archived threads.' instead of the underlying error message.
In session.ts and shell.ts, initial config load and shell sync error logs now use sanitized attributes instead of raw error objects.
Behavioral Change: error messages surfaced to callers and logs are now generic/sanitized; previously, raw error messages may have been exposed in state and structured logs.

^{Macroscope summarized 44a4c95.}

coderabbitai · 2026-06-20T17:37:01Z

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 9c841aea-ed53-4645-a200-539fbe690e6e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch codex/sanitize-client-runtime-diagnostics

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Co-authored-by: codex <codex@users.noreply.github.com>

macroscopeapp · 2026-06-20T17:40:35Z

Approvability

Verdict: Approved

This PR sanitizes error logging by replacing potentially sensitive error messages with generic user-facing strings and a safe metadata extraction utility. The changes are security-focused, well-scoped, and include test coverage confirming sensitive data is not exposed.

^{You can customize Macroscope's approvability policy. Learn more.}

github-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:M 30-99 changed lines (additions + deletions). labels Jun 20, 2026

fix(client-runtime): sanitize failure diagnostics
44a4c95
Co-authored-by: codex <codex@users.noreply.github.com>