[codex] Structure server CLI failures

[juliusmarminge]

Summary

• replace the arbitrary-message server script CliError with six distinct schema error tags
• retain the exact existing caller-facing messages while attaching structural paths or exit codes
• keep constructors inline at failure sites and add focused error-shape coverage

Why

The previous catch-all error could only be correlated through free-form message text. These failures now expose stable tags and the relevant path or exit code without adding redundant operation fields or constructor wrappers.

Validation

• vp check
• vp run typecheck
• vp test apps/server/scripts/cliErrors.test.ts

---

Note

Low Risk
Refactor limited to internal server scripts CLI error types and messages; no runtime server or auth paths touched.

Overview
Replaces the scripts CLI’s single CliError with six Schema.TaggedErrorClass types in cliErrors.ts, each with stable _tag fields and structured context (paths, or command/args/cwd/exitCode for subprocess failures). User-facing message strings stay the same via overridden getters.

cli.ts now fails with the specific error at each site (build assets, publish/dev icon overrides, non-zero runCommand exits) and types spawned commands as ChildProcess.StandardCommand. Adds cliErrors.test.ts to lock in tags, fields, and messages for representative cases.

^{Reviewed by Cursor Bugbot for commit df59234. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Replace generic CliError with structured error classes in server CLI scripts

• Adds six typed error classes in cliErrors.ts: ServerCliCommandExitError, ServerCliBuildAssetMissingError, and four icon-related errors, each carrying relevant context fields (e.g. exitCode, assetPath, sourcePath).
• Replaces all CliError usages in cli.ts with the appropriate specific error class, preserving existing error messages.
• Adds a vitest suite in cliErrors.test.ts verifying that context fields and messages are preserved on the new error classes.

^{Macroscope summarized df59234.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 19d923af-b7e9-4779-889f-23bc334ce7d7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/server-cli-schema-errors

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[macroscopeapp]

Approvability

Verdict: Approved

Mechanical refactor extracting CLI error classes into a dedicated file with more specific types. Error messages and runtime behavior remain unchanged, with tests added to verify the new error classes.

^{You can customize Macroscope's approvability policy. Learn more.}

[juliusmarminge]

Summary

• replace the arbitrary-message server script CliError with six distinct schema error tags
• retain the exact existing caller-facing messages while attaching structural paths or exit codes
• keep constructors inline at failure sites and add focused error-shape coverage

Why

The previous catch-all error could only be correlated through free-form message text. These failures now expose stable tags and the relevant path or exit code without adding redundant operation fields or constructor wrappers.

Validation

• vp check
• vp run typecheck
• vp test apps/server/scripts/cliErrors.test.ts

---

Note

Low Risk
Refactor limited to internal server scripts CLI error types and messages; no runtime server or auth paths touched.

Overview
Replaces the scripts CLI’s single CliError with six Schema.TaggedErrorClass types in cliErrors.ts, each with stable _tag fields and structured context (paths, or command/args/cwd/exitCode for subprocess failures). User-facing message strings stay the same via overridden getters.

cli.ts now fails with the specific error at each site (build assets, publish/dev icon overrides, non-zero runCommand exits) and types spawned commands as ChildProcess.StandardCommand. Adds cliErrors.test.ts to lock in tags, fields, and messages for representative cases.

^{Reviewed by Cursor Bugbot for commit df59234. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Replace generic CliError with structured error classes in server CLI scripts

• Adds six typed error classes in cliErrors.ts: ServerCliCommandExitError, ServerCliBuildAssetMissingError, and four icon-related errors, each carrying relevant context fields (e.g. exitCode, assetPath, sourcePath).
• Replaces all CliError usages in cli.ts with the appropriate specific error class, preserving existing error messages.
• Adds a vitest suite in cliErrors.test.ts verifying that context fields and messages are preserved on the new error classes.

^{Macroscope summarized df59234.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 19d923af-b7e9-4779-889f-23bc334ce7d7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/server-cli-schema-errors

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[macroscopeapp]

Approvability

Verdict: Approved

Mechanical refactor extracting CLI error classes into a dedicated file with more specific types. Error messages and runtime behavior remain unchanged, with tests added to verify the new error classes.

^{You can customize Macroscope's approvability policy. Learn more.}

[juliusmarminge]

Summary

• replace the arbitrary-message server script CliError with six distinct schema error tags
• retain the exact existing caller-facing messages while attaching structural paths or exit codes
• keep constructors inline at failure sites and add focused error-shape coverage

Why

The previous catch-all error could only be correlated through free-form message text. These failures now expose stable tags and the relevant path or exit code without adding redundant operation fields or constructor wrappers.

Validation

• vp check
• vp run typecheck
• vp test apps/server/scripts/cliErrors.test.ts

---

Note

Low Risk
Refactor limited to internal server scripts CLI error types and messages; no runtime server or auth paths touched.

Overview
Replaces the scripts CLI’s single CliError with six Schema.TaggedErrorClass types in cliErrors.ts, each with stable _tag fields and structured context (paths, or command/args/cwd/exitCode for subprocess failures). User-facing message strings stay the same via overridden getters.

cli.ts now fails with the specific error at each site (build assets, publish/dev icon overrides, non-zero runCommand exits) and types spawned commands as ChildProcess.StandardCommand. Adds cliErrors.test.ts to lock in tags, fields, and messages for representative cases.

^{Reviewed by Cursor Bugbot for commit df59234. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Replace generic CliError with structured error classes in server CLI scripts

• Adds six typed error classes in cliErrors.ts: ServerCliCommandExitError, ServerCliBuildAssetMissingError, and four icon-related errors, each carrying relevant context fields (e.g. exitCode, assetPath, sourcePath).
• Replaces all CliError usages in cli.ts with the appropriate specific error class, preserving existing error messages.
• Adds a vitest suite in cliErrors.test.ts verifying that context fields and messages are preserved on the new error classes.

^{Macroscope summarized df59234.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 19d923af-b7e9-4779-889f-23bc334ce7d7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/server-cli-schema-errors

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[macroscopeapp]

Approvability

Verdict: Approved

Mechanical refactor extracting CLI error classes into a dedicated file with more specific types. Error messages and runtime behavior remain unchanged, with tests added to verify the new error classes.

^{You can customize Macroscope's approvability policy. Learn more.}

[juliusmarminge]

Summary

• replace the arbitrary-message server script CliError with six distinct schema error tags
• retain the exact existing caller-facing messages while attaching structural paths or exit codes
• keep constructors inline at failure sites and add focused error-shape coverage

Why

The previous catch-all error could only be correlated through free-form message text. These failures now expose stable tags and the relevant path or exit code without adding redundant operation fields or constructor wrappers.

Validation

• vp check
• vp run typecheck
• vp test apps/server/scripts/cliErrors.test.ts

---

Note

Low Risk
Refactor limited to internal server scripts CLI error types and messages; no runtime server or auth paths touched.

Overview
Replaces the scripts CLI’s single CliError with six Schema.TaggedErrorClass types in cliErrors.ts, each with stable _tag fields and structured context (paths, or command/args/cwd/exitCode for subprocess failures). User-facing message strings stay the same via overridden getters.

cli.ts now fails with the specific error at each site (build assets, publish/dev icon overrides, non-zero runCommand exits) and types spawned commands as ChildProcess.StandardCommand. Adds cliErrors.test.ts to lock in tags, fields, and messages for representative cases.

^{Reviewed by Cursor Bugbot for commit df59234. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Replace generic CliError with structured error classes in server CLI scripts

• Adds six typed error classes in cliErrors.ts: ServerCliCommandExitError, ServerCliBuildAssetMissingError, and four icon-related errors, each carrying relevant context fields (e.g. exitCode, assetPath, sourcePath).
• Replaces all CliError usages in cli.ts with the appropriate specific error class, preserving existing error messages.
• Adds a vitest suite in cliErrors.test.ts verifying that context fields and messages are preserved on the new error classes.

^{Macroscope summarized df59234.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 19d923af-b7e9-4779-889f-23bc334ce7d7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/server-cli-schema-errors

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[macroscopeapp]

Approvability

Verdict: Approved

Mechanical refactor extracting CLI error classes into a dedicated file with more specific types. Error messages and runtime behavior remain unchanged, with tests added to verify the new error classes.

^{You can customize Macroscope's approvability policy. Learn more.}

[juliusmarminge]

Summary

• replace the arbitrary-message server script CliError with six distinct schema error tags
• retain the exact existing caller-facing messages while attaching structural paths or exit codes
• keep constructors inline at failure sites and add focused error-shape coverage

Why

The previous catch-all error could only be correlated through free-form message text. These failures now expose stable tags and the relevant path or exit code without adding redundant operation fields or constructor wrappers.

Validation

• vp check
• vp run typecheck
• vp test apps/server/scripts/cliErrors.test.ts

---

Note

Low Risk
Refactor limited to internal server scripts CLI error types and messages; no runtime server or auth paths touched.

Overview
Replaces the scripts CLI’s single CliError with six Schema.TaggedErrorClass types in cliErrors.ts, each with stable _tag fields and structured context (paths, or command/args/cwd/exitCode for subprocess failures). User-facing message strings stay the same via overridden getters.

cli.ts now fails with the specific error at each site (build assets, publish/dev icon overrides, non-zero runCommand exits) and types spawned commands as ChildProcess.StandardCommand. Adds cliErrors.test.ts to lock in tags, fields, and messages for representative cases.

^{Reviewed by Cursor Bugbot for commit df59234. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Replace generic CliError with structured error classes in server CLI scripts

• Adds six typed error classes in cliErrors.ts: ServerCliCommandExitError, ServerCliBuildAssetMissingError, and four icon-related errors, each carrying relevant context fields (e.g. exitCode, assetPath, sourcePath).
• Replaces all CliError usages in cli.ts with the appropriate specific error class, preserving existing error messages.
• Adds a vitest suite in cliErrors.test.ts verifying that context fields and messages are preserved on the new error classes.

^{Macroscope summarized df59234.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 19d923af-b7e9-4779-889f-23bc334ce7d7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/server-cli-schema-errors

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[macroscopeapp]

Approvability

Verdict: Approved

Mechanical refactor extracting CLI error classes into a dedicated file with more specific types. Error messages and runtime behavior remain unchanged, with tests added to verify the new error classes.

^{You can customize Macroscope's approvability policy. Learn more.}

[juliusmarminge]

Summary

• replace the arbitrary-message server script CliError with six distinct schema error tags
• retain the exact existing caller-facing messages while attaching structural paths or exit codes
• keep constructors inline at failure sites and add focused error-shape coverage

Why

The previous catch-all error could only be correlated through free-form message text. These failures now expose stable tags and the relevant path or exit code without adding redundant operation fields or constructor wrappers.

Validation

• vp check
• vp run typecheck
• vp test apps/server/scripts/cliErrors.test.ts

---

Note

Low Risk
Refactor limited to internal server scripts CLI error types and messages; no runtime server or auth paths touched.

Overview
Replaces the scripts CLI’s single CliError with six Schema.TaggedErrorClass types in cliErrors.ts, each with stable _tag fields and structured context (paths, or command/args/cwd/exitCode for subprocess failures). User-facing message strings stay the same via overridden getters.

cli.ts now fails with the specific error at each site (build assets, publish/dev icon overrides, non-zero runCommand exits) and types spawned commands as ChildProcess.StandardCommand. Adds cliErrors.test.ts to lock in tags, fields, and messages for representative cases.

^{Reviewed by Cursor Bugbot for commit df59234. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Replace generic CliError with structured error classes in server CLI scripts

• Adds six typed error classes in cliErrors.ts: ServerCliCommandExitError, ServerCliBuildAssetMissingError, and four icon-related errors, each carrying relevant context fields (e.g. exitCode, assetPath, sourcePath).
• Replaces all CliError usages in cli.ts with the appropriate specific error class, preserving existing error messages.
• Adds a vitest suite in cliErrors.test.ts verifying that context fields and messages are preserved on the new error classes.

^{Macroscope summarized df59234.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 19d923af-b7e9-4779-889f-23bc334ce7d7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/server-cli-schema-errors

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[macroscopeapp]

Approvability

Verdict: Approved

Mechanical refactor extracting CLI error classes into a dedicated file with more specific types. Error messages and runtime behavior remain unchanged, with tests added to verify the new error classes.

^{You can customize Macroscope's approvability policy. Learn more.}

[juliusmarminge]

Summary

• replace the arbitrary-message server script CliError with six distinct schema error tags
• retain the exact existing caller-facing messages while attaching structural paths or exit codes
• keep constructors inline at failure sites and add focused error-shape coverage

Why

The previous catch-all error could only be correlated through free-form message text. These failures now expose stable tags and the relevant path or exit code without adding redundant operation fields or constructor wrappers.

Validation

• vp check
• vp run typecheck
• vp test apps/server/scripts/cliErrors.test.ts

---

Note

Low Risk
Refactor limited to internal server scripts CLI error types and messages; no runtime server or auth paths touched.

Overview
Replaces the scripts CLI’s single CliError with six Schema.TaggedErrorClass types in cliErrors.ts, each with stable _tag fields and structured context (paths, or command/args/cwd/exitCode for subprocess failures). User-facing message strings stay the same via overridden getters.

cli.ts now fails with the specific error at each site (build assets, publish/dev icon overrides, non-zero runCommand exits) and types spawned commands as ChildProcess.StandardCommand. Adds cliErrors.test.ts to lock in tags, fields, and messages for representative cases.

^{Reviewed by Cursor Bugbot for commit df59234. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Replace generic CliError with structured error classes in server CLI scripts

• Adds six typed error classes in cliErrors.ts: ServerCliCommandExitError, ServerCliBuildAssetMissingError, and four icon-related errors, each carrying relevant context fields (e.g. exitCode, assetPath, sourcePath).
• Replaces all CliError usages in cli.ts with the appropriate specific error class, preserving existing error messages.
• Adds a vitest suite in cliErrors.test.ts verifying that context fields and messages are preserved on the new error classes.

^{Macroscope summarized df59234.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 19d923af-b7e9-4779-889f-23bc334ce7d7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/server-cli-schema-errors

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[macroscopeapp]

Approvability

Verdict: Approved

Mechanical refactor extracting CLI error classes into a dedicated file with more specific types. Error messages and runtime behavior remain unchanged, with tests added to verify the new error classes.

^{You can customize Macroscope's approvability policy. Learn more.}

[juliusmarminge]

Summary

• replace the arbitrary-message server script CliError with six distinct schema error tags
• retain the exact existing caller-facing messages while attaching structural paths or exit codes
• keep constructors inline at failure sites and add focused error-shape coverage

Why

The previous catch-all error could only be correlated through free-form message text. These failures now expose stable tags and the relevant path or exit code without adding redundant operation fields or constructor wrappers.

Validation

• vp check
• vp run typecheck
• vp test apps/server/scripts/cliErrors.test.ts

---

Note

Low Risk
Refactor limited to internal server scripts CLI error types and messages; no runtime server or auth paths touched.

Overview
Replaces the scripts CLI’s single CliError with six Schema.TaggedErrorClass types in cliErrors.ts, each with stable _tag fields and structured context (paths, or command/args/cwd/exitCode for subprocess failures). User-facing message strings stay the same via overridden getters.

cli.ts now fails with the specific error at each site (build assets, publish/dev icon overrides, non-zero runCommand exits) and types spawned commands as ChildProcess.StandardCommand. Adds cliErrors.test.ts to lock in tags, fields, and messages for representative cases.

^{Reviewed by Cursor Bugbot for commit df59234. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Replace generic CliError with structured error classes in server CLI scripts

• Adds six typed error classes in cliErrors.ts: ServerCliCommandExitError, ServerCliBuildAssetMissingError, and four icon-related errors, each carrying relevant context fields (e.g. exitCode, assetPath, sourcePath).
• Replaces all CliError usages in cli.ts with the appropriate specific error class, preserving existing error messages.
• Adds a vitest suite in cliErrors.test.ts verifying that context fields and messages are preserved on the new error classes.

^{Macroscope summarized df59234.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 19d923af-b7e9-4779-889f-23bc334ce7d7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/server-cli-schema-errors

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[macroscopeapp]

Approvability

Verdict: Approved

Mechanical refactor extracting CLI error classes into a dedicated file with more specific types. Error messages and runtime behavior remain unchanged, with tests added to verify the new error classes.

^{You can customize Macroscope's approvability policy. Learn more.}