[codex] Structure unroutable app-server messages

[juliusmarminge]

Summary

• replace the free-form unroutable-message detail with safe payload and envelope-field diagnostics
• retain valid method and request identifiers without copying arbitrary payload contents
• centralize the structural mapping on the protocol error and cover malformed envelopes with a compact test

Validation

• vp test run packages/effect-codex-app-server/src/protocol.test.ts (7 tests)
• vp check (0 errors; 20 pre-existing warnings)
• vp run typecheck

---

Note

Low Risk
Localized error-shape and routing diagnostics for malformed protocol envelopes; no auth or transport behavior changes beyond safer failure metadata.

Overview
When an inbound wire message decodes but cannot be routed (not a valid request, notification, or response), failures now use structured diagnostics instead of a free-form detail string.

CodexAppServerProtocolParseError drops detail and adds optional payloadKind and presentFields (which of id, method, params, result, error appear on the object). A new fromUnroutableMessage factory records method and stringified requestId only when types match—it does not copy params or other arbitrary payload values, so secrets in malformed envelopes are less likely to leak into errors or logs. Routing in protocol.ts calls this factory for unknown shapes.

A protocol test sends a message with a boolean id and sensitive params, asserting the expected structural fields and that the secret never appears in the error message.

^{Reviewed by Cursor Bugbot for commit 8b09393. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Add structured diagnostics to CodexAppServerProtocolParseError for unroutable messages

• Adds a static fromUnroutableMessage constructor to CodexAppServerProtocolParseError that extracts payloadKind, presentFields, method, and requestId from an unroutable message instead of using a generic detail string.
• Updates the router in protocol.ts to call fromUnroutableMessage when an incoming message cannot be routed.
• Removes the detail field from the error and replaces it with typed schema fields (payloadKind and presentFields).
• The new test verifies that secret values embedded in the payload are not included in the error message.

^{Macroscope summarized 8b09393.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 8bc65ff7-b637-4d46-9de3-ad56af269d26

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/structure-app-server-errors-followup

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[macroscopeapp]

Approvability

Verdict: Approved

This PR adds structured diagnostic fields to protocol parse errors for unroutable messages, improving debuggability while explicitly avoiding leakage of sensitive data. Changes are self-contained to error handling with no runtime behavior impact.

^{You can customize Macroscope's approvability policy. Learn more.}

[juliusmarminge]

Summary

• replace the free-form unroutable-message detail with safe payload and envelope-field diagnostics
• retain valid method and request identifiers without copying arbitrary payload contents
• centralize the structural mapping on the protocol error and cover malformed envelopes with a compact test

Validation

• vp test run packages/effect-codex-app-server/src/protocol.test.ts (7 tests)
• vp check (0 errors; 20 pre-existing warnings)
• vp run typecheck

---

Note

Low Risk
Localized error-shape and routing diagnostics for malformed protocol envelopes; no auth or transport behavior changes beyond safer failure metadata.

Overview
When an inbound wire message decodes but cannot be routed (not a valid request, notification, or response), failures now use structured diagnostics instead of a free-form detail string.

CodexAppServerProtocolParseError drops detail and adds optional payloadKind and presentFields (which of id, method, params, result, error appear on the object). A new fromUnroutableMessage factory records method and stringified requestId only when types match—it does not copy params or other arbitrary payload values, so secrets in malformed envelopes are less likely to leak into errors or logs. Routing in protocol.ts calls this factory for unknown shapes.

A protocol test sends a message with a boolean id and sensitive params, asserting the expected structural fields and that the secret never appears in the error message.

^{Reviewed by Cursor Bugbot for commit 8b09393. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Add structured diagnostics to CodexAppServerProtocolParseError for unroutable messages

• Adds a static fromUnroutableMessage constructor to CodexAppServerProtocolParseError that extracts payloadKind, presentFields, method, and requestId from an unroutable message instead of using a generic detail string.
• Updates the router in protocol.ts to call fromUnroutableMessage when an incoming message cannot be routed.
• Removes the detail field from the error and replaces it with typed schema fields (payloadKind and presentFields).
• The new test verifies that secret values embedded in the payload are not included in the error message.

^{Macroscope summarized 8b09393.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 8bc65ff7-b637-4d46-9de3-ad56af269d26

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/structure-app-server-errors-followup

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[macroscopeapp]

Approvability

Verdict: Approved

This PR adds structured diagnostic fields to protocol parse errors for unroutable messages, improving debuggability while explicitly avoiding leakage of sensitive data. Changes are self-contained to error handling with no runtime behavior impact.

^{You can customize Macroscope's approvability policy. Learn more.}

[juliusmarminge]

Summary

• replace the free-form unroutable-message detail with safe payload and envelope-field diagnostics
• retain valid method and request identifiers without copying arbitrary payload contents
• centralize the structural mapping on the protocol error and cover malformed envelopes with a compact test

Validation

• vp test run packages/effect-codex-app-server/src/protocol.test.ts (7 tests)
• vp check (0 errors; 20 pre-existing warnings)
• vp run typecheck

---

Note

Low Risk
Localized error-shape and routing diagnostics for malformed protocol envelopes; no auth or transport behavior changes beyond safer failure metadata.

Overview
When an inbound wire message decodes but cannot be routed (not a valid request, notification, or response), failures now use structured diagnostics instead of a free-form detail string.

CodexAppServerProtocolParseError drops detail and adds optional payloadKind and presentFields (which of id, method, params, result, error appear on the object). A new fromUnroutableMessage factory records method and stringified requestId only when types match—it does not copy params or other arbitrary payload values, so secrets in malformed envelopes are less likely to leak into errors or logs. Routing in protocol.ts calls this factory for unknown shapes.

A protocol test sends a message with a boolean id and sensitive params, asserting the expected structural fields and that the secret never appears in the error message.

^{Reviewed by Cursor Bugbot for commit 8b09393. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Add structured diagnostics to CodexAppServerProtocolParseError for unroutable messages

• Adds a static fromUnroutableMessage constructor to CodexAppServerProtocolParseError that extracts payloadKind, presentFields, method, and requestId from an unroutable message instead of using a generic detail string.
• Updates the router in protocol.ts to call fromUnroutableMessage when an incoming message cannot be routed.
• Removes the detail field from the error and replaces it with typed schema fields (payloadKind and presentFields).
• The new test verifies that secret values embedded in the payload are not included in the error message.

^{Macroscope summarized 8b09393.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 8bc65ff7-b637-4d46-9de3-ad56af269d26

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/structure-app-server-errors-followup

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[macroscopeapp]

Approvability

Verdict: Approved

This PR adds structured diagnostic fields to protocol parse errors for unroutable messages, improving debuggability while explicitly avoiding leakage of sensitive data. Changes are self-contained to error handling with no runtime behavior impact.

^{You can customize Macroscope's approvability policy. Learn more.}

[juliusmarminge]

Summary

• replace the free-form unroutable-message detail with safe payload and envelope-field diagnostics
• retain valid method and request identifiers without copying arbitrary payload contents
• centralize the structural mapping on the protocol error and cover malformed envelopes with a compact test

Validation

• vp test run packages/effect-codex-app-server/src/protocol.test.ts (7 tests)
• vp check (0 errors; 20 pre-existing warnings)
• vp run typecheck

---

Note

Low Risk
Localized error-shape and routing diagnostics for malformed protocol envelopes; no auth or transport behavior changes beyond safer failure metadata.

Overview
When an inbound wire message decodes but cannot be routed (not a valid request, notification, or response), failures now use structured diagnostics instead of a free-form detail string.

CodexAppServerProtocolParseError drops detail and adds optional payloadKind and presentFields (which of id, method, params, result, error appear on the object). A new fromUnroutableMessage factory records method and stringified requestId only when types match—it does not copy params or other arbitrary payload values, so secrets in malformed envelopes are less likely to leak into errors or logs. Routing in protocol.ts calls this factory for unknown shapes.

A protocol test sends a message with a boolean id and sensitive params, asserting the expected structural fields and that the secret never appears in the error message.

^{Reviewed by Cursor Bugbot for commit 8b09393. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Add structured diagnostics to CodexAppServerProtocolParseError for unroutable messages

• Adds a static fromUnroutableMessage constructor to CodexAppServerProtocolParseError that extracts payloadKind, presentFields, method, and requestId from an unroutable message instead of using a generic detail string.
• Updates the router in protocol.ts to call fromUnroutableMessage when an incoming message cannot be routed.
• Removes the detail field from the error and replaces it with typed schema fields (payloadKind and presentFields).
• The new test verifies that secret values embedded in the payload are not included in the error message.

^{Macroscope summarized 8b09393.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 8bc65ff7-b637-4d46-9de3-ad56af269d26

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/structure-app-server-errors-followup

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[macroscopeapp]

Approvability

Verdict: Approved

This PR adds structured diagnostic fields to protocol parse errors for unroutable messages, improving debuggability while explicitly avoiding leakage of sensitive data. Changes are self-contained to error handling with no runtime behavior impact.

^{You can customize Macroscope's approvability policy. Learn more.}

[juliusmarminge]

Summary

• replace the free-form unroutable-message detail with safe payload and envelope-field diagnostics
• retain valid method and request identifiers without copying arbitrary payload contents
• centralize the structural mapping on the protocol error and cover malformed envelopes with a compact test

Validation

• vp test run packages/effect-codex-app-server/src/protocol.test.ts (7 tests)
• vp check (0 errors; 20 pre-existing warnings)
• vp run typecheck

---

Note

Low Risk
Localized error-shape and routing diagnostics for malformed protocol envelopes; no auth or transport behavior changes beyond safer failure metadata.

Overview
When an inbound wire message decodes but cannot be routed (not a valid request, notification, or response), failures now use structured diagnostics instead of a free-form detail string.

CodexAppServerProtocolParseError drops detail and adds optional payloadKind and presentFields (which of id, method, params, result, error appear on the object). A new fromUnroutableMessage factory records method and stringified requestId only when types match—it does not copy params or other arbitrary payload values, so secrets in malformed envelopes are less likely to leak into errors or logs. Routing in protocol.ts calls this factory for unknown shapes.

A protocol test sends a message with a boolean id and sensitive params, asserting the expected structural fields and that the secret never appears in the error message.

^{Reviewed by Cursor Bugbot for commit 8b09393. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Add structured diagnostics to CodexAppServerProtocolParseError for unroutable messages

• Adds a static fromUnroutableMessage constructor to CodexAppServerProtocolParseError that extracts payloadKind, presentFields, method, and requestId from an unroutable message instead of using a generic detail string.
• Updates the router in protocol.ts to call fromUnroutableMessage when an incoming message cannot be routed.
• Removes the detail field from the error and replaces it with typed schema fields (payloadKind and presentFields).
• The new test verifies that secret values embedded in the payload are not included in the error message.

^{Macroscope summarized 8b09393.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 8bc65ff7-b637-4d46-9de3-ad56af269d26

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/structure-app-server-errors-followup

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[macroscopeapp]

Approvability

Verdict: Approved

This PR adds structured diagnostic fields to protocol parse errors for unroutable messages, improving debuggability while explicitly avoiding leakage of sensitive data. Changes are self-contained to error handling with no runtime behavior impact.

^{You can customize Macroscope's approvability policy. Learn more.}

[juliusmarminge]

Summary

• replace the free-form unroutable-message detail with safe payload and envelope-field diagnostics
• retain valid method and request identifiers without copying arbitrary payload contents
• centralize the structural mapping on the protocol error and cover malformed envelopes with a compact test

Validation

• vp test run packages/effect-codex-app-server/src/protocol.test.ts (7 tests)
• vp check (0 errors; 20 pre-existing warnings)
• vp run typecheck

---

Note

Low Risk
Localized error-shape and routing diagnostics for malformed protocol envelopes; no auth or transport behavior changes beyond safer failure metadata.

Overview
When an inbound wire message decodes but cannot be routed (not a valid request, notification, or response), failures now use structured diagnostics instead of a free-form detail string.

CodexAppServerProtocolParseError drops detail and adds optional payloadKind and presentFields (which of id, method, params, result, error appear on the object). A new fromUnroutableMessage factory records method and stringified requestId only when types match—it does not copy params or other arbitrary payload values, so secrets in malformed envelopes are less likely to leak into errors or logs. Routing in protocol.ts calls this factory for unknown shapes.

A protocol test sends a message with a boolean id and sensitive params, asserting the expected structural fields and that the secret never appears in the error message.

^{Reviewed by Cursor Bugbot for commit 8b09393. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Add structured diagnostics to CodexAppServerProtocolParseError for unroutable messages

• Adds a static fromUnroutableMessage constructor to CodexAppServerProtocolParseError that extracts payloadKind, presentFields, method, and requestId from an unroutable message instead of using a generic detail string.
• Updates the router in protocol.ts to call fromUnroutableMessage when an incoming message cannot be routed.
• Removes the detail field from the error and replaces it with typed schema fields (payloadKind and presentFields).
• The new test verifies that secret values embedded in the payload are not included in the error message.

^{Macroscope summarized 8b09393.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 8bc65ff7-b637-4d46-9de3-ad56af269d26

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/structure-app-server-errors-followup

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[macroscopeapp]

Approvability

Verdict: Approved

This PR adds structured diagnostic fields to protocol parse errors for unroutable messages, improving debuggability while explicitly avoiding leakage of sensitive data. Changes are self-contained to error handling with no runtime behavior impact.

^{You can customize Macroscope's approvability policy. Learn more.}

[juliusmarminge]

Summary

• replace the free-form unroutable-message detail with safe payload and envelope-field diagnostics
• retain valid method and request identifiers without copying arbitrary payload contents
• centralize the structural mapping on the protocol error and cover malformed envelopes with a compact test

Validation

• vp test run packages/effect-codex-app-server/src/protocol.test.ts (7 tests)
• vp check (0 errors; 20 pre-existing warnings)
• vp run typecheck

---

Note

Low Risk
Localized error-shape and routing diagnostics for malformed protocol envelopes; no auth or transport behavior changes beyond safer failure metadata.

Overview
When an inbound wire message decodes but cannot be routed (not a valid request, notification, or response), failures now use structured diagnostics instead of a free-form detail string.

CodexAppServerProtocolParseError drops detail and adds optional payloadKind and presentFields (which of id, method, params, result, error appear on the object). A new fromUnroutableMessage factory records method and stringified requestId only when types match—it does not copy params or other arbitrary payload values, so secrets in malformed envelopes are less likely to leak into errors or logs. Routing in protocol.ts calls this factory for unknown shapes.

A protocol test sends a message with a boolean id and sensitive params, asserting the expected structural fields and that the secret never appears in the error message.

^{Reviewed by Cursor Bugbot for commit 8b09393. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Add structured diagnostics to CodexAppServerProtocolParseError for unroutable messages

• Adds a static fromUnroutableMessage constructor to CodexAppServerProtocolParseError that extracts payloadKind, presentFields, method, and requestId from an unroutable message instead of using a generic detail string.
• Updates the router in protocol.ts to call fromUnroutableMessage when an incoming message cannot be routed.
• Removes the detail field from the error and replaces it with typed schema fields (payloadKind and presentFields).
• The new test verifies that secret values embedded in the payload are not included in the error message.

^{Macroscope summarized 8b09393.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 8bc65ff7-b637-4d46-9de3-ad56af269d26

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/structure-app-server-errors-followup

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[macroscopeapp]

Approvability

Verdict: Approved

This PR adds structured diagnostic fields to protocol parse errors for unroutable messages, improving debuggability while explicitly avoiding leakage of sensitive data. Changes are self-contained to error handling with no runtime behavior impact.

^{You can customize Macroscope's approvability policy. Learn more.}

[juliusmarminge]

Summary

• replace the free-form unroutable-message detail with safe payload and envelope-field diagnostics
• retain valid method and request identifiers without copying arbitrary payload contents
• centralize the structural mapping on the protocol error and cover malformed envelopes with a compact test

Validation

• vp test run packages/effect-codex-app-server/src/protocol.test.ts (7 tests)
• vp check (0 errors; 20 pre-existing warnings)
• vp run typecheck

---

Note

Low Risk
Localized error-shape and routing diagnostics for malformed protocol envelopes; no auth or transport behavior changes beyond safer failure metadata.

Overview
When an inbound wire message decodes but cannot be routed (not a valid request, notification, or response), failures now use structured diagnostics instead of a free-form detail string.

CodexAppServerProtocolParseError drops detail and adds optional payloadKind and presentFields (which of id, method, params, result, error appear on the object). A new fromUnroutableMessage factory records method and stringified requestId only when types match—it does not copy params or other arbitrary payload values, so secrets in malformed envelopes are less likely to leak into errors or logs. Routing in protocol.ts calls this factory for unknown shapes.

A protocol test sends a message with a boolean id and sensitive params, asserting the expected structural fields and that the secret never appears in the error message.

^{Reviewed by Cursor Bugbot for commit 8b09393. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Add structured diagnostics to CodexAppServerProtocolParseError for unroutable messages

• Adds a static fromUnroutableMessage constructor to CodexAppServerProtocolParseError that extracts payloadKind, presentFields, method, and requestId from an unroutable message instead of using a generic detail string.
• Updates the router in protocol.ts to call fromUnroutableMessage when an incoming message cannot be routed.
• Removes the detail field from the error and replaces it with typed schema fields (payloadKind and presentFields).
• The new test verifies that secret values embedded in the payload are not included in the error message.

^{Macroscope summarized 8b09393.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 8bc65ff7-b637-4d46-9de3-ad56af269d26

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/structure-app-server-errors-followup

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[macroscopeapp]

Approvability

Verdict: Approved

This PR adds structured diagnostic fields to protocol parse errors for unroutable messages, improving debuggability while explicitly avoiding leakage of sensitive data. Changes are self-contained to error handling with no runtime behavior impact.

^{You can customize Macroscope's approvability policy. Learn more.}