[codex] Structure workspace search cleanup failures

[juliusmarminge]

Summary

• Preserve FileFinder.destroy() failures as WorkspaceSearchIndexDestroyFailed defects with the workspace path and immediate cause.
• Restrict workspace-index refresh recovery to the three expected tagged failures so defects and unexpected errors are not silently converted into cache invalidation.
• Add focused coverage for finalizer failure structure and cause preservation.

Validation

• vp test apps/server/src/workspace/WorkspaceSearchIndex.test.ts apps/server/src/workspace/WorkspaceEntries.test.ts (21 tests)
• vp check
• vp run typecheck

---

Note

Low Risk
Localized error-handling and test changes in workspace search indexing; no auth, data, or API contract changes.

Overview
Workspace search cleanup now turns FileFinder.destroy() failures into a tagged WorkspaceSearchIndexDestroyFailed defect (workspace path + cause) via Effect.try/orDie on the scoped release finalizer, instead of letting them escape as unstructured errors.

Refresh recovery in WorkspaceEntries.refresh is narrowed from a catch-all handler to Effect.catchTags on WorkspaceSearchIndexCreateFailed, WorkspaceSearchIndexScanTimedOut, and WorkspaceSearchIndexRefreshFailed only—so defects (e.g. destroy failures) and other unexpected errors are no longer logged and used to invalidate the index cache.

Tests add coverage that scoped teardown preserves destroy failure structure in the cause chain.

^{Reviewed by Cursor Bugbot for commit 0cb6387. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Structure workspace search index cleanup failures as typed defects

• Adds WorkspaceSearchIndexDestroyFailed error class to WorkspaceSearchIndex.ts; when FileFinder.destroy throws during scope release, the scope now dies with this structured defect carrying cwd and the original cause instead of an unstructured exception.
• Narrows error handling in WorkspaceEntries.ts from a broad Effect.catch to Effect.catchTags covering only WorkspaceSearchIndexCreateFailed, WorkspaceSearchIndexScanTimedOut, and WorkspaceSearchIndexRefreshFailed.
• Adds a test in WorkspaceSearchIndex.test.ts asserting that FileFinder.destroy failures exit as WorkspaceSearchIndexDestroyFailed defects.
• Behavioral Change: other failures from the refresh pipeline now propagate to the caller instead of being silently logged and invalidated.

^{Macroscope summarized 0cb6387.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 3ca769cd-61f0-49a6-88c3-80b0b0888c98

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/structure-workspace-search-finalizer

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[macroscopeapp]

Approvability

Verdict: Approved

This PR refactors error handling to use explicit typed error classes and tag-based catching instead of generic catch-all handlers. The runtime behavior remains functionally identical - a low-risk improvement to type safety with accompanying test coverage.

^{You can customize Macroscope's approvability policy. Learn more.}

[juliusmarminge]

Summary

• Preserve FileFinder.destroy() failures as WorkspaceSearchIndexDestroyFailed defects with the workspace path and immediate cause.
• Restrict workspace-index refresh recovery to the three expected tagged failures so defects and unexpected errors are not silently converted into cache invalidation.
• Add focused coverage for finalizer failure structure and cause preservation.

Validation

• vp test apps/server/src/workspace/WorkspaceSearchIndex.test.ts apps/server/src/workspace/WorkspaceEntries.test.ts (21 tests)
• vp check
• vp run typecheck

---

Note

Low Risk
Localized error-handling and test changes in workspace search indexing; no auth, data, or API contract changes.

Overview
Workspace search cleanup now turns FileFinder.destroy() failures into a tagged WorkspaceSearchIndexDestroyFailed defect (workspace path + cause) via Effect.try/orDie on the scoped release finalizer, instead of letting them escape as unstructured errors.

Refresh recovery in WorkspaceEntries.refresh is narrowed from a catch-all handler to Effect.catchTags on WorkspaceSearchIndexCreateFailed, WorkspaceSearchIndexScanTimedOut, and WorkspaceSearchIndexRefreshFailed only—so defects (e.g. destroy failures) and other unexpected errors are no longer logged and used to invalidate the index cache.

Tests add coverage that scoped teardown preserves destroy failure structure in the cause chain.

^{Reviewed by Cursor Bugbot for commit 0cb6387. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Structure workspace search index cleanup failures as typed defects

• Adds WorkspaceSearchIndexDestroyFailed error class to WorkspaceSearchIndex.ts; when FileFinder.destroy throws during scope release, the scope now dies with this structured defect carrying cwd and the original cause instead of an unstructured exception.
• Narrows error handling in WorkspaceEntries.ts from a broad Effect.catch to Effect.catchTags covering only WorkspaceSearchIndexCreateFailed, WorkspaceSearchIndexScanTimedOut, and WorkspaceSearchIndexRefreshFailed.
• Adds a test in WorkspaceSearchIndex.test.ts asserting that FileFinder.destroy failures exit as WorkspaceSearchIndexDestroyFailed defects.
• Behavioral Change: other failures from the refresh pipeline now propagate to the caller instead of being silently logged and invalidated.

^{Macroscope summarized 0cb6387.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 3ca769cd-61f0-49a6-88c3-80b0b0888c98

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/structure-workspace-search-finalizer

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[macroscopeapp]

Approvability

Verdict: Approved

This PR refactors error handling to use explicit typed error classes and tag-based catching instead of generic catch-all handlers. The runtime behavior remains functionally identical - a low-risk improvement to type safety with accompanying test coverage.

^{You can customize Macroscope's approvability policy. Learn more.}

[juliusmarminge]

Summary

• Preserve FileFinder.destroy() failures as WorkspaceSearchIndexDestroyFailed defects with the workspace path and immediate cause.
• Restrict workspace-index refresh recovery to the three expected tagged failures so defects and unexpected errors are not silently converted into cache invalidation.
• Add focused coverage for finalizer failure structure and cause preservation.

Validation

• vp test apps/server/src/workspace/WorkspaceSearchIndex.test.ts apps/server/src/workspace/WorkspaceEntries.test.ts (21 tests)
• vp check
• vp run typecheck

---

Note

Low Risk
Localized error-handling and test changes in workspace search indexing; no auth, data, or API contract changes.

Overview
Workspace search cleanup now turns FileFinder.destroy() failures into a tagged WorkspaceSearchIndexDestroyFailed defect (workspace path + cause) via Effect.try/orDie on the scoped release finalizer, instead of letting them escape as unstructured errors.

Refresh recovery in WorkspaceEntries.refresh is narrowed from a catch-all handler to Effect.catchTags on WorkspaceSearchIndexCreateFailed, WorkspaceSearchIndexScanTimedOut, and WorkspaceSearchIndexRefreshFailed only—so defects (e.g. destroy failures) and other unexpected errors are no longer logged and used to invalidate the index cache.

Tests add coverage that scoped teardown preserves destroy failure structure in the cause chain.

^{Reviewed by Cursor Bugbot for commit 0cb6387. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Structure workspace search index cleanup failures as typed defects

• Adds WorkspaceSearchIndexDestroyFailed error class to WorkspaceSearchIndex.ts; when FileFinder.destroy throws during scope release, the scope now dies with this structured defect carrying cwd and the original cause instead of an unstructured exception.
• Narrows error handling in WorkspaceEntries.ts from a broad Effect.catch to Effect.catchTags covering only WorkspaceSearchIndexCreateFailed, WorkspaceSearchIndexScanTimedOut, and WorkspaceSearchIndexRefreshFailed.
• Adds a test in WorkspaceSearchIndex.test.ts asserting that FileFinder.destroy failures exit as WorkspaceSearchIndexDestroyFailed defects.
• Behavioral Change: other failures from the refresh pipeline now propagate to the caller instead of being silently logged and invalidated.

^{Macroscope summarized 0cb6387.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 3ca769cd-61f0-49a6-88c3-80b0b0888c98

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/structure-workspace-search-finalizer

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[macroscopeapp]

Approvability

Verdict: Approved

This PR refactors error handling to use explicit typed error classes and tag-based catching instead of generic catch-all handlers. The runtime behavior remains functionally identical - a low-risk improvement to type safety with accompanying test coverage.

^{You can customize Macroscope's approvability policy. Learn more.}

[juliusmarminge]

Summary

• Preserve FileFinder.destroy() failures as WorkspaceSearchIndexDestroyFailed defects with the workspace path and immediate cause.
• Restrict workspace-index refresh recovery to the three expected tagged failures so defects and unexpected errors are not silently converted into cache invalidation.
• Add focused coverage for finalizer failure structure and cause preservation.

Validation

• vp test apps/server/src/workspace/WorkspaceSearchIndex.test.ts apps/server/src/workspace/WorkspaceEntries.test.ts (21 tests)
• vp check
• vp run typecheck

---

Note

Low Risk
Localized error-handling and test changes in workspace search indexing; no auth, data, or API contract changes.

Overview
Workspace search cleanup now turns FileFinder.destroy() failures into a tagged WorkspaceSearchIndexDestroyFailed defect (workspace path + cause) via Effect.try/orDie on the scoped release finalizer, instead of letting them escape as unstructured errors.

Refresh recovery in WorkspaceEntries.refresh is narrowed from a catch-all handler to Effect.catchTags on WorkspaceSearchIndexCreateFailed, WorkspaceSearchIndexScanTimedOut, and WorkspaceSearchIndexRefreshFailed only—so defects (e.g. destroy failures) and other unexpected errors are no longer logged and used to invalidate the index cache.

Tests add coverage that scoped teardown preserves destroy failure structure in the cause chain.

^{Reviewed by Cursor Bugbot for commit 0cb6387. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Structure workspace search index cleanup failures as typed defects

• Adds WorkspaceSearchIndexDestroyFailed error class to WorkspaceSearchIndex.ts; when FileFinder.destroy throws during scope release, the scope now dies with this structured defect carrying cwd and the original cause instead of an unstructured exception.
• Narrows error handling in WorkspaceEntries.ts from a broad Effect.catch to Effect.catchTags covering only WorkspaceSearchIndexCreateFailed, WorkspaceSearchIndexScanTimedOut, and WorkspaceSearchIndexRefreshFailed.
• Adds a test in WorkspaceSearchIndex.test.ts asserting that FileFinder.destroy failures exit as WorkspaceSearchIndexDestroyFailed defects.
• Behavioral Change: other failures from the refresh pipeline now propagate to the caller instead of being silently logged and invalidated.

^{Macroscope summarized 0cb6387.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 3ca769cd-61f0-49a6-88c3-80b0b0888c98

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/structure-workspace-search-finalizer

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[macroscopeapp]

Approvability

Verdict: Approved

This PR refactors error handling to use explicit typed error classes and tag-based catching instead of generic catch-all handlers. The runtime behavior remains functionally identical - a low-risk improvement to type safety with accompanying test coverage.

^{You can customize Macroscope's approvability policy. Learn more.}

[juliusmarminge]

Summary

• Preserve FileFinder.destroy() failures as WorkspaceSearchIndexDestroyFailed defects with the workspace path and immediate cause.
• Restrict workspace-index refresh recovery to the three expected tagged failures so defects and unexpected errors are not silently converted into cache invalidation.
• Add focused coverage for finalizer failure structure and cause preservation.

Validation

• vp test apps/server/src/workspace/WorkspaceSearchIndex.test.ts apps/server/src/workspace/WorkspaceEntries.test.ts (21 tests)
• vp check
• vp run typecheck

---

Note

Low Risk
Localized error-handling and test changes in workspace search indexing; no auth, data, or API contract changes.

Overview
Workspace search cleanup now turns FileFinder.destroy() failures into a tagged WorkspaceSearchIndexDestroyFailed defect (workspace path + cause) via Effect.try/orDie on the scoped release finalizer, instead of letting them escape as unstructured errors.

Refresh recovery in WorkspaceEntries.refresh is narrowed from a catch-all handler to Effect.catchTags on WorkspaceSearchIndexCreateFailed, WorkspaceSearchIndexScanTimedOut, and WorkspaceSearchIndexRefreshFailed only—so defects (e.g. destroy failures) and other unexpected errors are no longer logged and used to invalidate the index cache.

Tests add coverage that scoped teardown preserves destroy failure structure in the cause chain.

^{Reviewed by Cursor Bugbot for commit 0cb6387. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Structure workspace search index cleanup failures as typed defects

• Adds WorkspaceSearchIndexDestroyFailed error class to WorkspaceSearchIndex.ts; when FileFinder.destroy throws during scope release, the scope now dies with this structured defect carrying cwd and the original cause instead of an unstructured exception.
• Narrows error handling in WorkspaceEntries.ts from a broad Effect.catch to Effect.catchTags covering only WorkspaceSearchIndexCreateFailed, WorkspaceSearchIndexScanTimedOut, and WorkspaceSearchIndexRefreshFailed.
• Adds a test in WorkspaceSearchIndex.test.ts asserting that FileFinder.destroy failures exit as WorkspaceSearchIndexDestroyFailed defects.
• Behavioral Change: other failures from the refresh pipeline now propagate to the caller instead of being silently logged and invalidated.

^{Macroscope summarized 0cb6387.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 3ca769cd-61f0-49a6-88c3-80b0b0888c98

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/structure-workspace-search-finalizer

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[macroscopeapp]

Approvability

Verdict: Approved

This PR refactors error handling to use explicit typed error classes and tag-based catching instead of generic catch-all handlers. The runtime behavior remains functionally identical - a low-risk improvement to type safety with accompanying test coverage.

^{You can customize Macroscope's approvability policy. Learn more.}

[juliusmarminge]

Summary

• Preserve FileFinder.destroy() failures as WorkspaceSearchIndexDestroyFailed defects with the workspace path and immediate cause.
• Restrict workspace-index refresh recovery to the three expected tagged failures so defects and unexpected errors are not silently converted into cache invalidation.
• Add focused coverage for finalizer failure structure and cause preservation.

Validation

• vp test apps/server/src/workspace/WorkspaceSearchIndex.test.ts apps/server/src/workspace/WorkspaceEntries.test.ts (21 tests)
• vp check
• vp run typecheck

---

Note

Low Risk
Localized error-handling and test changes in workspace search indexing; no auth, data, or API contract changes.

Overview
Workspace search cleanup now turns FileFinder.destroy() failures into a tagged WorkspaceSearchIndexDestroyFailed defect (workspace path + cause) via Effect.try/orDie on the scoped release finalizer, instead of letting them escape as unstructured errors.

Refresh recovery in WorkspaceEntries.refresh is narrowed from a catch-all handler to Effect.catchTags on WorkspaceSearchIndexCreateFailed, WorkspaceSearchIndexScanTimedOut, and WorkspaceSearchIndexRefreshFailed only—so defects (e.g. destroy failures) and other unexpected errors are no longer logged and used to invalidate the index cache.

Tests add coverage that scoped teardown preserves destroy failure structure in the cause chain.

^{Reviewed by Cursor Bugbot for commit 0cb6387. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Structure workspace search index cleanup failures as typed defects

• Adds WorkspaceSearchIndexDestroyFailed error class to WorkspaceSearchIndex.ts; when FileFinder.destroy throws during scope release, the scope now dies with this structured defect carrying cwd and the original cause instead of an unstructured exception.
• Narrows error handling in WorkspaceEntries.ts from a broad Effect.catch to Effect.catchTags covering only WorkspaceSearchIndexCreateFailed, WorkspaceSearchIndexScanTimedOut, and WorkspaceSearchIndexRefreshFailed.
• Adds a test in WorkspaceSearchIndex.test.ts asserting that FileFinder.destroy failures exit as WorkspaceSearchIndexDestroyFailed defects.
• Behavioral Change: other failures from the refresh pipeline now propagate to the caller instead of being silently logged and invalidated.

^{Macroscope summarized 0cb6387.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 3ca769cd-61f0-49a6-88c3-80b0b0888c98

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/structure-workspace-search-finalizer

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[macroscopeapp]

Approvability

Verdict: Approved

This PR refactors error handling to use explicit typed error classes and tag-based catching instead of generic catch-all handlers. The runtime behavior remains functionally identical - a low-risk improvement to type safety with accompanying test coverage.

^{You can customize Macroscope's approvability policy. Learn more.}

[juliusmarminge]

Summary

• Preserve FileFinder.destroy() failures as WorkspaceSearchIndexDestroyFailed defects with the workspace path and immediate cause.
• Restrict workspace-index refresh recovery to the three expected tagged failures so defects and unexpected errors are not silently converted into cache invalidation.
• Add focused coverage for finalizer failure structure and cause preservation.

Validation

• vp test apps/server/src/workspace/WorkspaceSearchIndex.test.ts apps/server/src/workspace/WorkspaceEntries.test.ts (21 tests)
• vp check
• vp run typecheck

---

Note

Low Risk
Localized error-handling and test changes in workspace search indexing; no auth, data, or API contract changes.

Overview
Workspace search cleanup now turns FileFinder.destroy() failures into a tagged WorkspaceSearchIndexDestroyFailed defect (workspace path + cause) via Effect.try/orDie on the scoped release finalizer, instead of letting them escape as unstructured errors.

Refresh recovery in WorkspaceEntries.refresh is narrowed from a catch-all handler to Effect.catchTags on WorkspaceSearchIndexCreateFailed, WorkspaceSearchIndexScanTimedOut, and WorkspaceSearchIndexRefreshFailed only—so defects (e.g. destroy failures) and other unexpected errors are no longer logged and used to invalidate the index cache.

Tests add coverage that scoped teardown preserves destroy failure structure in the cause chain.

^{Reviewed by Cursor Bugbot for commit 0cb6387. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Structure workspace search index cleanup failures as typed defects

• Adds WorkspaceSearchIndexDestroyFailed error class to WorkspaceSearchIndex.ts; when FileFinder.destroy throws during scope release, the scope now dies with this structured defect carrying cwd and the original cause instead of an unstructured exception.
• Narrows error handling in WorkspaceEntries.ts from a broad Effect.catch to Effect.catchTags covering only WorkspaceSearchIndexCreateFailed, WorkspaceSearchIndexScanTimedOut, and WorkspaceSearchIndexRefreshFailed.
• Adds a test in WorkspaceSearchIndex.test.ts asserting that FileFinder.destroy failures exit as WorkspaceSearchIndexDestroyFailed defects.
• Behavioral Change: other failures from the refresh pipeline now propagate to the caller instead of being silently logged and invalidated.

^{Macroscope summarized 0cb6387.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 3ca769cd-61f0-49a6-88c3-80b0b0888c98

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/structure-workspace-search-finalizer

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[macroscopeapp]

Approvability

Verdict: Approved

This PR refactors error handling to use explicit typed error classes and tag-based catching instead of generic catch-all handlers. The runtime behavior remains functionally identical - a low-risk improvement to type safety with accompanying test coverage.

^{You can customize Macroscope's approvability policy. Learn more.}

[juliusmarminge]

Summary

• Preserve FileFinder.destroy() failures as WorkspaceSearchIndexDestroyFailed defects with the workspace path and immediate cause.
• Restrict workspace-index refresh recovery to the three expected tagged failures so defects and unexpected errors are not silently converted into cache invalidation.
• Add focused coverage for finalizer failure structure and cause preservation.

Validation

• vp test apps/server/src/workspace/WorkspaceSearchIndex.test.ts apps/server/src/workspace/WorkspaceEntries.test.ts (21 tests)
• vp check
• vp run typecheck

---

Note

Low Risk
Localized error-handling and test changes in workspace search indexing; no auth, data, or API contract changes.

Overview
Workspace search cleanup now turns FileFinder.destroy() failures into a tagged WorkspaceSearchIndexDestroyFailed defect (workspace path + cause) via Effect.try/orDie on the scoped release finalizer, instead of letting them escape as unstructured errors.

Refresh recovery in WorkspaceEntries.refresh is narrowed from a catch-all handler to Effect.catchTags on WorkspaceSearchIndexCreateFailed, WorkspaceSearchIndexScanTimedOut, and WorkspaceSearchIndexRefreshFailed only—so defects (e.g. destroy failures) and other unexpected errors are no longer logged and used to invalidate the index cache.

Tests add coverage that scoped teardown preserves destroy failure structure in the cause chain.

^{Reviewed by Cursor Bugbot for commit 0cb6387. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Structure workspace search index cleanup failures as typed defects

• Adds WorkspaceSearchIndexDestroyFailed error class to WorkspaceSearchIndex.ts; when FileFinder.destroy throws during scope release, the scope now dies with this structured defect carrying cwd and the original cause instead of an unstructured exception.
• Narrows error handling in WorkspaceEntries.ts from a broad Effect.catch to Effect.catchTags covering only WorkspaceSearchIndexCreateFailed, WorkspaceSearchIndexScanTimedOut, and WorkspaceSearchIndexRefreshFailed.
• Adds a test in WorkspaceSearchIndex.test.ts asserting that FileFinder.destroy failures exit as WorkspaceSearchIndexDestroyFailed defects.
• Behavioral Change: other failures from the refresh pipeline now propagate to the caller instead of being silently logged and invalidated.

^{Macroscope summarized 0cb6387.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 3ca769cd-61f0-49a6-88c3-80b0b0888c98

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/structure-workspace-search-finalizer

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[macroscopeapp]

Approvability

Verdict: Approved

This PR refactors error handling to use explicit typed error classes and tag-based catching instead of generic catch-all handlers. The runtime behavior remains functionally identical - a low-risk improvement to type safety with accompanying test coverage.

^{You can customize Macroscope's approvability policy. Learn more.}