[codex] Structure theme synchronization failures

[juliusmarminge]

What changed

• represent local theme-storage failures with structured operation, key, optional theme, and exact cause data
• represent desktop theme synchronization failures with the requested theme and exact IPC cause
• keep theme persistence and desktop synchronization cosmetic: recover with the default theme, log only safe attributes, and retry desktop sync after failures
• add focused coverage for storage failures, module-load fallback, safe diagnostics, exact causes, and retry behavior

Why

Browser storage access and the desktop theme bridge could throw raw errors. Storage reads could also fail during module initialization and prevent the theme module from loading. The new boundaries preserve the full error chain while exposing stable, non-sensitive context for diagnostics.

Verification

• vp test apps/web/src/hooks/useTheme.test.ts
• vp check
• vp run typecheck
• npx -y react-doctor@latest . --verbose --diff (no findings in useTheme; command reports unrelated existing findings elsewhere in the comparison base)

---

Note

Low Risk
Cosmetic theme persistence and desktop shell sync only; failures degrade to defaults without blocking the app, with a minor UX change when writes fail.

Overview
Adds Effect Schema tagged errors (ThemeStorageError, DesktopThemeSyncError) and exported readThemePreference / writeThemePreference / syncDesktopThemePreference so localStorage and desktop IPC failures carry operation, key, theme, and full cause chains.

Graceful degradation: failed reads cache in themeStorageReadFailure, fall back to the default theme, and log via safeErrorLogAttributes (no raw causes in logs). Cross-tab storage events clear that latch so reads retry. Failed desktop sync clears lastDesktopTheme so the next cycle retries IPC.

Behavior change:setTheme no longer applies the theme when persistence throws; module init can still load and apply the default theme when storage read fails at load time.

Adds useTheme.test.ts covering error shape, safe logging, storage-event retry, and desktop sync retry.

^{Reviewed by Cursor Bugbot for commit 2058298. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Structure theme synchronization failures with typed errors in useTheme

• Introduces ThemeStorageError and DesktopThemeSyncError tagged error classes in useTheme.ts, replacing unstructured throws with structured errors carrying operation, storageKey, theme, and cause context.
• Storage read failures are cached in themeStorageReadFailure so repeated reads return the default theme without re-attempting until a relevant storage event clears the flag.
• setTheme no longer throws on write failure; it logs a redacted error and returns early, leaving the theme unchanged.
• Desktop sync failures in syncDesktopTheme log a structured, cause-redacted error and allow retry by clearing lastDesktopTheme only when the attempted theme is still current.
• Adds a test suite in useTheme.test.ts covering error cause preservation, safe logging, read-failure retry gating, and desktop sync error propagation.

^{Macroscope summarized 2058298.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 31844d5d-141b-4dd5-8dfb-6e116c3be89b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/structure-theme-sync-errors

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[cursor]

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Bugbot Autofix prepared a fix for the issue found in the latest run.

• ✅ Fixed: Repeated storage read error logs
  • Added a module-level storageReadErrorLogged flag so the console.error in getStored() fires at most once, preventing repeated logging on every render when localStorage is persistently failing.

Or push these changes by commenting:

@cursor push 02acc6c0fd

Preview (02acc6c0fd)

diff --git a/apps/web/src/hooks/useTheme.ts b/apps/web/src/hooks/useTheme.ts--- a/apps/web/src/hooks/useTheme.ts+++ b/apps/web/src/hooks/useTheme.ts@@ -55,6 +55,7 @@
let lastSnapshot: ThemeSnapshot | null = null;
let lastDesktopTheme: Theme | null = null;
let lastAppliedTheme: ThemeSnapshot | null = null;
+let storageReadErrorLogged = false;
function emitChange() {
for (const listener of listeners) listener();
@@ -102,18 +103,21 @@
try {
return readThemePreference();
} catch (cause) {
- const error = isThemeStorageError(cause)- ? cause- : new ThemeStorageError({- operation: "read",- storageKey: STORAGE_KEY,- cause,- });- console.error(error.message, {- operation: error.operation,- storageKey: error.storageKey,- ...safeErrorLogAttributes(error),- });+ if (!storageReadErrorLogged) {+ storageReadErrorLogged = true;+ const error = isThemeStorageError(cause)+ ? cause+ : new ThemeStorageError({+ operation: "read",+ storageKey: STORAGE_KEY,+ cause,+ });+ console.error(error.message, {+ operation: error.operation,+ storageKey: error.storageKey,+ ...safeErrorLogAttributes(error),+ });+ }
return DEFAULT_THEME_SNAPSHOT.theme;
}
}

_{You can send follow-ups to the cloud agent here.}

^{Reviewed by Cursor Bugbot for commit ea4fb6d. Configure here.}

[macroscopeapp]

Approvability

Verdict: Approved

Adds structured error classes and comprehensive tests for theme storage/sync operations. The core theme behavior is unchanged; the changes wrap existing operations with proper error handling and graceful fallbacks.

^{You can customize Macroscope's approvability policy. Learn more.}

[juliusmarminge]

What changed

• represent local theme-storage failures with structured operation, key, optional theme, and exact cause data
• represent desktop theme synchronization failures with the requested theme and exact IPC cause
• keep theme persistence and desktop synchronization cosmetic: recover with the default theme, log only safe attributes, and retry desktop sync after failures
• add focused coverage for storage failures, module-load fallback, safe diagnostics, exact causes, and retry behavior

Why

Browser storage access and the desktop theme bridge could throw raw errors. Storage reads could also fail during module initialization and prevent the theme module from loading. The new boundaries preserve the full error chain while exposing stable, non-sensitive context for diagnostics.

Verification

• vp test apps/web/src/hooks/useTheme.test.ts
• vp check
• vp run typecheck
• npx -y react-doctor@latest . --verbose --diff (no findings in useTheme; command reports unrelated existing findings elsewhere in the comparison base)

---

Note

Low Risk
Cosmetic theme persistence and desktop shell sync only; failures degrade to defaults without blocking the app, with a minor UX change when writes fail.

Overview
Adds Effect Schema tagged errors (ThemeStorageError, DesktopThemeSyncError) and exported readThemePreference / writeThemePreference / syncDesktopThemePreference so localStorage and desktop IPC failures carry operation, key, theme, and full cause chains.

Graceful degradation: failed reads cache in themeStorageReadFailure, fall back to the default theme, and log via safeErrorLogAttributes (no raw causes in logs). Cross-tab storage events clear that latch so reads retry. Failed desktop sync clears lastDesktopTheme so the next cycle retries IPC.

Behavior change:setTheme no longer applies the theme when persistence throws; module init can still load and apply the default theme when storage read fails at load time.

Adds useTheme.test.ts covering error shape, safe logging, storage-event retry, and desktop sync retry.

^{Reviewed by Cursor Bugbot for commit 2058298. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Structure theme synchronization failures with typed errors in useTheme

• Introduces ThemeStorageError and DesktopThemeSyncError tagged error classes in useTheme.ts, replacing unstructured throws with structured errors carrying operation, storageKey, theme, and cause context.
• Storage read failures are cached in themeStorageReadFailure so repeated reads return the default theme without re-attempting until a relevant storage event clears the flag.
• setTheme no longer throws on write failure; it logs a redacted error and returns early, leaving the theme unchanged.
• Desktop sync failures in syncDesktopTheme log a structured, cause-redacted error and allow retry by clearing lastDesktopTheme only when the attempted theme is still current.
• Adds a test suite in useTheme.test.ts covering error cause preservation, safe logging, read-failure retry gating, and desktop sync error propagation.

^{Macroscope summarized 2058298.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 31844d5d-141b-4dd5-8dfb-6e116c3be89b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/structure-theme-sync-errors

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[cursor]

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Bugbot Autofix prepared a fix for the issue found in the latest run.

• ✅ Fixed: Repeated storage read error logs
  • Added a module-level storageReadErrorLogged flag so the console.error in getStored() fires at most once, preventing repeated logging on every render when localStorage is persistently failing.

Or push these changes by commenting:

@cursor push 02acc6c0fd

Preview (02acc6c0fd)

diff --git a/apps/web/src/hooks/useTheme.ts b/apps/web/src/hooks/useTheme.ts--- a/apps/web/src/hooks/useTheme.ts+++ b/apps/web/src/hooks/useTheme.ts@@ -55,6 +55,7 @@
let lastSnapshot: ThemeSnapshot | null = null;
let lastDesktopTheme: Theme | null = null;
let lastAppliedTheme: ThemeSnapshot | null = null;
+let storageReadErrorLogged = false;
function emitChange() {
for (const listener of listeners) listener();
@@ -102,18 +103,21 @@
try {
return readThemePreference();
} catch (cause) {
- const error = isThemeStorageError(cause)- ? cause- : new ThemeStorageError({- operation: "read",- storageKey: STORAGE_KEY,- cause,- });- console.error(error.message, {- operation: error.operation,- storageKey: error.storageKey,- ...safeErrorLogAttributes(error),- });+ if (!storageReadErrorLogged) {+ storageReadErrorLogged = true;+ const error = isThemeStorageError(cause)+ ? cause+ : new ThemeStorageError({+ operation: "read",+ storageKey: STORAGE_KEY,+ cause,+ });+ console.error(error.message, {+ operation: error.operation,+ storageKey: error.storageKey,+ ...safeErrorLogAttributes(error),+ });+ }
return DEFAULT_THEME_SNAPSHOT.theme;
}
}

_{You can send follow-ups to the cloud agent here.}

^{Reviewed by Cursor Bugbot for commit ea4fb6d. Configure here.}

[macroscopeapp]

Approvability

Verdict: Approved

Adds structured error classes and comprehensive tests for theme storage/sync operations. The core theme behavior is unchanged; the changes wrap existing operations with proper error handling and graceful fallbacks.

^{You can customize Macroscope's approvability policy. Learn more.}

[juliusmarminge]

What changed

• represent local theme-storage failures with structured operation, key, optional theme, and exact cause data
• represent desktop theme synchronization failures with the requested theme and exact IPC cause
• keep theme persistence and desktop synchronization cosmetic: recover with the default theme, log only safe attributes, and retry desktop sync after failures
• add focused coverage for storage failures, module-load fallback, safe diagnostics, exact causes, and retry behavior

Why

Browser storage access and the desktop theme bridge could throw raw errors. Storage reads could also fail during module initialization and prevent the theme module from loading. The new boundaries preserve the full error chain while exposing stable, non-sensitive context for diagnostics.

Verification

• vp test apps/web/src/hooks/useTheme.test.ts
• vp check
• vp run typecheck
• npx -y react-doctor@latest . --verbose --diff (no findings in useTheme; command reports unrelated existing findings elsewhere in the comparison base)

---

Note

Low Risk
Cosmetic theme persistence and desktop shell sync only; failures degrade to defaults without blocking the app, with a minor UX change when writes fail.

Overview
Adds Effect Schema tagged errors (ThemeStorageError, DesktopThemeSyncError) and exported readThemePreference / writeThemePreference / syncDesktopThemePreference so localStorage and desktop IPC failures carry operation, key, theme, and full cause chains.

Graceful degradation: failed reads cache in themeStorageReadFailure, fall back to the default theme, and log via safeErrorLogAttributes (no raw causes in logs). Cross-tab storage events clear that latch so reads retry. Failed desktop sync clears lastDesktopTheme so the next cycle retries IPC.

Behavior change:setTheme no longer applies the theme when persistence throws; module init can still load and apply the default theme when storage read fails at load time.

Adds useTheme.test.ts covering error shape, safe logging, storage-event retry, and desktop sync retry.

^{Reviewed by Cursor Bugbot for commit 2058298. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Structure theme synchronization failures with typed errors in useTheme

• Introduces ThemeStorageError and DesktopThemeSyncError tagged error classes in useTheme.ts, replacing unstructured throws with structured errors carrying operation, storageKey, theme, and cause context.
• Storage read failures are cached in themeStorageReadFailure so repeated reads return the default theme without re-attempting until a relevant storage event clears the flag.
• setTheme no longer throws on write failure; it logs a redacted error and returns early, leaving the theme unchanged.
• Desktop sync failures in syncDesktopTheme log a structured, cause-redacted error and allow retry by clearing lastDesktopTheme only when the attempted theme is still current.
• Adds a test suite in useTheme.test.ts covering error cause preservation, safe logging, read-failure retry gating, and desktop sync error propagation.

^{Macroscope summarized 2058298.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 31844d5d-141b-4dd5-8dfb-6e116c3be89b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/structure-theme-sync-errors

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[cursor]

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Bugbot Autofix prepared a fix for the issue found in the latest run.

• ✅ Fixed: Repeated storage read error logs
  • Added a module-level storageReadErrorLogged flag so the console.error in getStored() fires at most once, preventing repeated logging on every render when localStorage is persistently failing.

Or push these changes by commenting:

@cursor push 02acc6c0fd

Preview (02acc6c0fd)

diff --git a/apps/web/src/hooks/useTheme.ts b/apps/web/src/hooks/useTheme.ts--- a/apps/web/src/hooks/useTheme.ts+++ b/apps/web/src/hooks/useTheme.ts@@ -55,6 +55,7 @@
let lastSnapshot: ThemeSnapshot | null = null;
let lastDesktopTheme: Theme | null = null;
let lastAppliedTheme: ThemeSnapshot | null = null;
+let storageReadErrorLogged = false;
function emitChange() {
for (const listener of listeners) listener();
@@ -102,18 +103,21 @@
try {
return readThemePreference();
} catch (cause) {
- const error = isThemeStorageError(cause)- ? cause- : new ThemeStorageError({- operation: "read",- storageKey: STORAGE_KEY,- cause,- });- console.error(error.message, {- operation: error.operation,- storageKey: error.storageKey,- ...safeErrorLogAttributes(error),- });+ if (!storageReadErrorLogged) {+ storageReadErrorLogged = true;+ const error = isThemeStorageError(cause)+ ? cause+ : new ThemeStorageError({+ operation: "read",+ storageKey: STORAGE_KEY,+ cause,+ });+ console.error(error.message, {+ operation: error.operation,+ storageKey: error.storageKey,+ ...safeErrorLogAttributes(error),+ });+ }
return DEFAULT_THEME_SNAPSHOT.theme;
}
}

_{You can send follow-ups to the cloud agent here.}

^{Reviewed by Cursor Bugbot for commit ea4fb6d. Configure here.}

[macroscopeapp]

Approvability

Verdict: Approved

Adds structured error classes and comprehensive tests for theme storage/sync operations. The core theme behavior is unchanged; the changes wrap existing operations with proper error handling and graceful fallbacks.

^{You can customize Macroscope's approvability policy. Learn more.}

[juliusmarminge]

What changed

• represent local theme-storage failures with structured operation, key, optional theme, and exact cause data
• represent desktop theme synchronization failures with the requested theme and exact IPC cause
• keep theme persistence and desktop synchronization cosmetic: recover with the default theme, log only safe attributes, and retry desktop sync after failures
• add focused coverage for storage failures, module-load fallback, safe diagnostics, exact causes, and retry behavior

Why

Browser storage access and the desktop theme bridge could throw raw errors. Storage reads could also fail during module initialization and prevent the theme module from loading. The new boundaries preserve the full error chain while exposing stable, non-sensitive context for diagnostics.

Verification

• vp test apps/web/src/hooks/useTheme.test.ts
• vp check
• vp run typecheck
• npx -y react-doctor@latest . --verbose --diff (no findings in useTheme; command reports unrelated existing findings elsewhere in the comparison base)

---

Note

Low Risk
Cosmetic theme persistence and desktop shell sync only; failures degrade to defaults without blocking the app, with a minor UX change when writes fail.

Overview
Adds Effect Schema tagged errors (ThemeStorageError, DesktopThemeSyncError) and exported readThemePreference / writeThemePreference / syncDesktopThemePreference so localStorage and desktop IPC failures carry operation, key, theme, and full cause chains.

Graceful degradation: failed reads cache in themeStorageReadFailure, fall back to the default theme, and log via safeErrorLogAttributes (no raw causes in logs). Cross-tab storage events clear that latch so reads retry. Failed desktop sync clears lastDesktopTheme so the next cycle retries IPC.

Behavior change:setTheme no longer applies the theme when persistence throws; module init can still load and apply the default theme when storage read fails at load time.

Adds useTheme.test.ts covering error shape, safe logging, storage-event retry, and desktop sync retry.

^{Reviewed by Cursor Bugbot for commit 2058298. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Structure theme synchronization failures with typed errors in useTheme

• Introduces ThemeStorageError and DesktopThemeSyncError tagged error classes in useTheme.ts, replacing unstructured throws with structured errors carrying operation, storageKey, theme, and cause context.
• Storage read failures are cached in themeStorageReadFailure so repeated reads return the default theme without re-attempting until a relevant storage event clears the flag.
• setTheme no longer throws on write failure; it logs a redacted error and returns early, leaving the theme unchanged.
• Desktop sync failures in syncDesktopTheme log a structured, cause-redacted error and allow retry by clearing lastDesktopTheme only when the attempted theme is still current.
• Adds a test suite in useTheme.test.ts covering error cause preservation, safe logging, read-failure retry gating, and desktop sync error propagation.

^{Macroscope summarized 2058298.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 31844d5d-141b-4dd5-8dfb-6e116c3be89b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/structure-theme-sync-errors

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[cursor]

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Bugbot Autofix prepared a fix for the issue found in the latest run.

• ✅ Fixed: Repeated storage read error logs
  • Added a module-level storageReadErrorLogged flag so the console.error in getStored() fires at most once, preventing repeated logging on every render when localStorage is persistently failing.

Or push these changes by commenting:

@cursor push 02acc6c0fd

Preview (02acc6c0fd)

diff --git a/apps/web/src/hooks/useTheme.ts b/apps/web/src/hooks/useTheme.ts--- a/apps/web/src/hooks/useTheme.ts+++ b/apps/web/src/hooks/useTheme.ts@@ -55,6 +55,7 @@
let lastSnapshot: ThemeSnapshot | null = null;
let lastDesktopTheme: Theme | null = null;
let lastAppliedTheme: ThemeSnapshot | null = null;
+let storageReadErrorLogged = false;
function emitChange() {
for (const listener of listeners) listener();
@@ -102,18 +103,21 @@
try {
return readThemePreference();
} catch (cause) {
- const error = isThemeStorageError(cause)- ? cause- : new ThemeStorageError({- operation: "read",- storageKey: STORAGE_KEY,- cause,- });- console.error(error.message, {- operation: error.operation,- storageKey: error.storageKey,- ...safeErrorLogAttributes(error),- });+ if (!storageReadErrorLogged) {+ storageReadErrorLogged = true;+ const error = isThemeStorageError(cause)+ ? cause+ : new ThemeStorageError({+ operation: "read",+ storageKey: STORAGE_KEY,+ cause,+ });+ console.error(error.message, {+ operation: error.operation,+ storageKey: error.storageKey,+ ...safeErrorLogAttributes(error),+ });+ }
return DEFAULT_THEME_SNAPSHOT.theme;
}
}

_{You can send follow-ups to the cloud agent here.}

^{Reviewed by Cursor Bugbot for commit ea4fb6d. Configure here.}

[macroscopeapp]

Approvability

Verdict: Approved

Adds structured error classes and comprehensive tests for theme storage/sync operations. The core theme behavior is unchanged; the changes wrap existing operations with proper error handling and graceful fallbacks.

^{You can customize Macroscope's approvability policy. Learn more.}

[juliusmarminge]

What changed

• represent local theme-storage failures with structured operation, key, optional theme, and exact cause data
• represent desktop theme synchronization failures with the requested theme and exact IPC cause
• keep theme persistence and desktop synchronization cosmetic: recover with the default theme, log only safe attributes, and retry desktop sync after failures
• add focused coverage for storage failures, module-load fallback, safe diagnostics, exact causes, and retry behavior

Why

Browser storage access and the desktop theme bridge could throw raw errors. Storage reads could also fail during module initialization and prevent the theme module from loading. The new boundaries preserve the full error chain while exposing stable, non-sensitive context for diagnostics.

Verification

• vp test apps/web/src/hooks/useTheme.test.ts
• vp check
• vp run typecheck
• npx -y react-doctor@latest . --verbose --diff (no findings in useTheme; command reports unrelated existing findings elsewhere in the comparison base)

---

Note

Low Risk
Cosmetic theme persistence and desktop shell sync only; failures degrade to defaults without blocking the app, with a minor UX change when writes fail.

Overview
Adds Effect Schema tagged errors (ThemeStorageError, DesktopThemeSyncError) and exported readThemePreference / writeThemePreference / syncDesktopThemePreference so localStorage and desktop IPC failures carry operation, key, theme, and full cause chains.

Graceful degradation: failed reads cache in themeStorageReadFailure, fall back to the default theme, and log via safeErrorLogAttributes (no raw causes in logs). Cross-tab storage events clear that latch so reads retry. Failed desktop sync clears lastDesktopTheme so the next cycle retries IPC.

Behavior change:setTheme no longer applies the theme when persistence throws; module init can still load and apply the default theme when storage read fails at load time.

Adds useTheme.test.ts covering error shape, safe logging, storage-event retry, and desktop sync retry.

^{Reviewed by Cursor Bugbot for commit 2058298. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Structure theme synchronization failures with typed errors in useTheme

• Introduces ThemeStorageError and DesktopThemeSyncError tagged error classes in useTheme.ts, replacing unstructured throws with structured errors carrying operation, storageKey, theme, and cause context.
• Storage read failures are cached in themeStorageReadFailure so repeated reads return the default theme without re-attempting until a relevant storage event clears the flag.
• setTheme no longer throws on write failure; it logs a redacted error and returns early, leaving the theme unchanged.
• Desktop sync failures in syncDesktopTheme log a structured, cause-redacted error and allow retry by clearing lastDesktopTheme only when the attempted theme is still current.
• Adds a test suite in useTheme.test.ts covering error cause preservation, safe logging, read-failure retry gating, and desktop sync error propagation.

^{Macroscope summarized 2058298.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 31844d5d-141b-4dd5-8dfb-6e116c3be89b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/structure-theme-sync-errors

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[cursor]

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Bugbot Autofix prepared a fix for the issue found in the latest run.

• ✅ Fixed: Repeated storage read error logs
  • Added a module-level storageReadErrorLogged flag so the console.error in getStored() fires at most once, preventing repeated logging on every render when localStorage is persistently failing.

Or push these changes by commenting:

@cursor push 02acc6c0fd

Preview (02acc6c0fd)

diff --git a/apps/web/src/hooks/useTheme.ts b/apps/web/src/hooks/useTheme.ts--- a/apps/web/src/hooks/useTheme.ts+++ b/apps/web/src/hooks/useTheme.ts@@ -55,6 +55,7 @@
let lastSnapshot: ThemeSnapshot | null = null;
let lastDesktopTheme: Theme | null = null;
let lastAppliedTheme: ThemeSnapshot | null = null;
+let storageReadErrorLogged = false;
function emitChange() {
for (const listener of listeners) listener();
@@ -102,18 +103,21 @@
try {
return readThemePreference();
} catch (cause) {
- const error = isThemeStorageError(cause)- ? cause- : new ThemeStorageError({- operation: "read",- storageKey: STORAGE_KEY,- cause,- });- console.error(error.message, {- operation: error.operation,- storageKey: error.storageKey,- ...safeErrorLogAttributes(error),- });+ if (!storageReadErrorLogged) {+ storageReadErrorLogged = true;+ const error = isThemeStorageError(cause)+ ? cause+ : new ThemeStorageError({+ operation: "read",+ storageKey: STORAGE_KEY,+ cause,+ });+ console.error(error.message, {+ operation: error.operation,+ storageKey: error.storageKey,+ ...safeErrorLogAttributes(error),+ });+ }
return DEFAULT_THEME_SNAPSHOT.theme;
}
}

_{You can send follow-ups to the cloud agent here.}

^{Reviewed by Cursor Bugbot for commit ea4fb6d. Configure here.}

[macroscopeapp]

Approvability

Verdict: Approved

Adds structured error classes and comprehensive tests for theme storage/sync operations. The core theme behavior is unchanged; the changes wrap existing operations with proper error handling and graceful fallbacks.

^{You can customize Macroscope's approvability policy. Learn more.}

[juliusmarminge]

What changed

• represent local theme-storage failures with structured operation, key, optional theme, and exact cause data
• represent desktop theme synchronization failures with the requested theme and exact IPC cause
• keep theme persistence and desktop synchronization cosmetic: recover with the default theme, log only safe attributes, and retry desktop sync after failures
• add focused coverage for storage failures, module-load fallback, safe diagnostics, exact causes, and retry behavior

Why

Browser storage access and the desktop theme bridge could throw raw errors. Storage reads could also fail during module initialization and prevent the theme module from loading. The new boundaries preserve the full error chain while exposing stable, non-sensitive context for diagnostics.

Verification

• vp test apps/web/src/hooks/useTheme.test.ts
• vp check
• vp run typecheck
• npx -y react-doctor@latest . --verbose --diff (no findings in useTheme; command reports unrelated existing findings elsewhere in the comparison base)

---

Note

Low Risk
Cosmetic theme persistence and desktop shell sync only; failures degrade to defaults without blocking the app, with a minor UX change when writes fail.

Overview
Adds Effect Schema tagged errors (ThemeStorageError, DesktopThemeSyncError) and exported readThemePreference / writeThemePreference / syncDesktopThemePreference so localStorage and desktop IPC failures carry operation, key, theme, and full cause chains.

Graceful degradation: failed reads cache in themeStorageReadFailure, fall back to the default theme, and log via safeErrorLogAttributes (no raw causes in logs). Cross-tab storage events clear that latch so reads retry. Failed desktop sync clears lastDesktopTheme so the next cycle retries IPC.

Behavior change:setTheme no longer applies the theme when persistence throws; module init can still load and apply the default theme when storage read fails at load time.

Adds useTheme.test.ts covering error shape, safe logging, storage-event retry, and desktop sync retry.

^{Reviewed by Cursor Bugbot for commit 2058298. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Structure theme synchronization failures with typed errors in useTheme

• Introduces ThemeStorageError and DesktopThemeSyncError tagged error classes in useTheme.ts, replacing unstructured throws with structured errors carrying operation, storageKey, theme, and cause context.
• Storage read failures are cached in themeStorageReadFailure so repeated reads return the default theme without re-attempting until a relevant storage event clears the flag.
• setTheme no longer throws on write failure; it logs a redacted error and returns early, leaving the theme unchanged.
• Desktop sync failures in syncDesktopTheme log a structured, cause-redacted error and allow retry by clearing lastDesktopTheme only when the attempted theme is still current.
• Adds a test suite in useTheme.test.ts covering error cause preservation, safe logging, read-failure retry gating, and desktop sync error propagation.

^{Macroscope summarized 2058298.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 31844d5d-141b-4dd5-8dfb-6e116c3be89b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/structure-theme-sync-errors

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[cursor]

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Bugbot Autofix prepared a fix for the issue found in the latest run.

• ✅ Fixed: Repeated storage read error logs
  • Added a module-level storageReadErrorLogged flag so the console.error in getStored() fires at most once, preventing repeated logging on every render when localStorage is persistently failing.

Or push these changes by commenting:

@cursor push 02acc6c0fd

Preview (02acc6c0fd)

diff --git a/apps/web/src/hooks/useTheme.ts b/apps/web/src/hooks/useTheme.ts--- a/apps/web/src/hooks/useTheme.ts+++ b/apps/web/src/hooks/useTheme.ts@@ -55,6 +55,7 @@
let lastSnapshot: ThemeSnapshot | null = null;
let lastDesktopTheme: Theme | null = null;
let lastAppliedTheme: ThemeSnapshot | null = null;
+let storageReadErrorLogged = false;
function emitChange() {
for (const listener of listeners) listener();
@@ -102,18 +103,21 @@
try {
return readThemePreference();
} catch (cause) {
- const error = isThemeStorageError(cause)- ? cause- : new ThemeStorageError({- operation: "read",- storageKey: STORAGE_KEY,- cause,- });- console.error(error.message, {- operation: error.operation,- storageKey: error.storageKey,- ...safeErrorLogAttributes(error),- });+ if (!storageReadErrorLogged) {+ storageReadErrorLogged = true;+ const error = isThemeStorageError(cause)+ ? cause+ : new ThemeStorageError({+ operation: "read",+ storageKey: STORAGE_KEY,+ cause,+ });+ console.error(error.message, {+ operation: error.operation,+ storageKey: error.storageKey,+ ...safeErrorLogAttributes(error),+ });+ }
return DEFAULT_THEME_SNAPSHOT.theme;
}
}

_{You can send follow-ups to the cloud agent here.}

^{Reviewed by Cursor Bugbot for commit ea4fb6d. Configure here.}

[macroscopeapp]

Approvability

Verdict: Approved

Adds structured error classes and comprehensive tests for theme storage/sync operations. The core theme behavior is unchanged; the changes wrap existing operations with proper error handling and graceful fallbacks.

^{You can customize Macroscope's approvability policy. Learn more.}

[juliusmarminge]

What changed

• represent local theme-storage failures with structured operation, key, optional theme, and exact cause data
• represent desktop theme synchronization failures with the requested theme and exact IPC cause
• keep theme persistence and desktop synchronization cosmetic: recover with the default theme, log only safe attributes, and retry desktop sync after failures
• add focused coverage for storage failures, module-load fallback, safe diagnostics, exact causes, and retry behavior

Why

Browser storage access and the desktop theme bridge could throw raw errors. Storage reads could also fail during module initialization and prevent the theme module from loading. The new boundaries preserve the full error chain while exposing stable, non-sensitive context for diagnostics.

Verification

• vp test apps/web/src/hooks/useTheme.test.ts
• vp check
• vp run typecheck
• npx -y react-doctor@latest . --verbose --diff (no findings in useTheme; command reports unrelated existing findings elsewhere in the comparison base)

---

Note

Low Risk
Cosmetic theme persistence and desktop shell sync only; failures degrade to defaults without blocking the app, with a minor UX change when writes fail.

Overview
Adds Effect Schema tagged errors (ThemeStorageError, DesktopThemeSyncError) and exported readThemePreference / writeThemePreference / syncDesktopThemePreference so localStorage and desktop IPC failures carry operation, key, theme, and full cause chains.

Graceful degradation: failed reads cache in themeStorageReadFailure, fall back to the default theme, and log via safeErrorLogAttributes (no raw causes in logs). Cross-tab storage events clear that latch so reads retry. Failed desktop sync clears lastDesktopTheme so the next cycle retries IPC.

Behavior change:setTheme no longer applies the theme when persistence throws; module init can still load and apply the default theme when storage read fails at load time.

Adds useTheme.test.ts covering error shape, safe logging, storage-event retry, and desktop sync retry.

^{Reviewed by Cursor Bugbot for commit 2058298. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Structure theme synchronization failures with typed errors in useTheme

• Introduces ThemeStorageError and DesktopThemeSyncError tagged error classes in useTheme.ts, replacing unstructured throws with structured errors carrying operation, storageKey, theme, and cause context.
• Storage read failures are cached in themeStorageReadFailure so repeated reads return the default theme without re-attempting until a relevant storage event clears the flag.
• setTheme no longer throws on write failure; it logs a redacted error and returns early, leaving the theme unchanged.
• Desktop sync failures in syncDesktopTheme log a structured, cause-redacted error and allow retry by clearing lastDesktopTheme only when the attempted theme is still current.
• Adds a test suite in useTheme.test.ts covering error cause preservation, safe logging, read-failure retry gating, and desktop sync error propagation.

^{Macroscope summarized 2058298.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 31844d5d-141b-4dd5-8dfb-6e116c3be89b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/structure-theme-sync-errors

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[cursor]

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Bugbot Autofix prepared a fix for the issue found in the latest run.

• ✅ Fixed: Repeated storage read error logs
  • Added a module-level storageReadErrorLogged flag so the console.error in getStored() fires at most once, preventing repeated logging on every render when localStorage is persistently failing.

Or push these changes by commenting:

@cursor push 02acc6c0fd

Preview (02acc6c0fd)

diff --git a/apps/web/src/hooks/useTheme.ts b/apps/web/src/hooks/useTheme.ts--- a/apps/web/src/hooks/useTheme.ts+++ b/apps/web/src/hooks/useTheme.ts@@ -55,6 +55,7 @@
let lastSnapshot: ThemeSnapshot | null = null;
let lastDesktopTheme: Theme | null = null;
let lastAppliedTheme: ThemeSnapshot | null = null;
+let storageReadErrorLogged = false;
function emitChange() {
for (const listener of listeners) listener();
@@ -102,18 +103,21 @@
try {
return readThemePreference();
} catch (cause) {
- const error = isThemeStorageError(cause)- ? cause- : new ThemeStorageError({- operation: "read",- storageKey: STORAGE_KEY,- cause,- });- console.error(error.message, {- operation: error.operation,- storageKey: error.storageKey,- ...safeErrorLogAttributes(error),- });+ if (!storageReadErrorLogged) {+ storageReadErrorLogged = true;+ const error = isThemeStorageError(cause)+ ? cause+ : new ThemeStorageError({+ operation: "read",+ storageKey: STORAGE_KEY,+ cause,+ });+ console.error(error.message, {+ operation: error.operation,+ storageKey: error.storageKey,+ ...safeErrorLogAttributes(error),+ });+ }
return DEFAULT_THEME_SNAPSHOT.theme;
}
}

_{You can send follow-ups to the cloud agent here.}

^{Reviewed by Cursor Bugbot for commit ea4fb6d. Configure here.}

[macroscopeapp]

Approvability

Verdict: Approved

Adds structured error classes and comprehensive tests for theme storage/sync operations. The core theme behavior is unchanged; the changes wrap existing operations with proper error handling and graceful fallbacks.

^{You can customize Macroscope's approvability policy. Learn more.}

[juliusmarminge]

What changed

• represent local theme-storage failures with structured operation, key, optional theme, and exact cause data
• represent desktop theme synchronization failures with the requested theme and exact IPC cause
• keep theme persistence and desktop synchronization cosmetic: recover with the default theme, log only safe attributes, and retry desktop sync after failures
• add focused coverage for storage failures, module-load fallback, safe diagnostics, exact causes, and retry behavior

Why

Browser storage access and the desktop theme bridge could throw raw errors. Storage reads could also fail during module initialization and prevent the theme module from loading. The new boundaries preserve the full error chain while exposing stable, non-sensitive context for diagnostics.

Verification

• vp test apps/web/src/hooks/useTheme.test.ts
• vp check
• vp run typecheck
• npx -y react-doctor@latest . --verbose --diff (no findings in useTheme; command reports unrelated existing findings elsewhere in the comparison base)

---

Note

Low Risk
Cosmetic theme persistence and desktop shell sync only; failures degrade to defaults without blocking the app, with a minor UX change when writes fail.

Overview
Adds Effect Schema tagged errors (ThemeStorageError, DesktopThemeSyncError) and exported readThemePreference / writeThemePreference / syncDesktopThemePreference so localStorage and desktop IPC failures carry operation, key, theme, and full cause chains.

Graceful degradation: failed reads cache in themeStorageReadFailure, fall back to the default theme, and log via safeErrorLogAttributes (no raw causes in logs). Cross-tab storage events clear that latch so reads retry. Failed desktop sync clears lastDesktopTheme so the next cycle retries IPC.

Behavior change:setTheme no longer applies the theme when persistence throws; module init can still load and apply the default theme when storage read fails at load time.

Adds useTheme.test.ts covering error shape, safe logging, storage-event retry, and desktop sync retry.

^{Reviewed by Cursor Bugbot for commit 2058298. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Structure theme synchronization failures with typed errors in useTheme

• Introduces ThemeStorageError and DesktopThemeSyncError tagged error classes in useTheme.ts, replacing unstructured throws with structured errors carrying operation, storageKey, theme, and cause context.
• Storage read failures are cached in themeStorageReadFailure so repeated reads return the default theme without re-attempting until a relevant storage event clears the flag.
• setTheme no longer throws on write failure; it logs a redacted error and returns early, leaving the theme unchanged.
• Desktop sync failures in syncDesktopTheme log a structured, cause-redacted error and allow retry by clearing lastDesktopTheme only when the attempted theme is still current.
• Adds a test suite in useTheme.test.ts covering error cause preservation, safe logging, read-failure retry gating, and desktop sync error propagation.

^{Macroscope summarized 2058298.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 31844d5d-141b-4dd5-8dfb-6e116c3be89b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/structure-theme-sync-errors

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[cursor]

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Bugbot Autofix prepared a fix for the issue found in the latest run.

• ✅ Fixed: Repeated storage read error logs
  • Added a module-level storageReadErrorLogged flag so the console.error in getStored() fires at most once, preventing repeated logging on every render when localStorage is persistently failing.

Or push these changes by commenting:

@cursor push 02acc6c0fd

Preview (02acc6c0fd)

diff --git a/apps/web/src/hooks/useTheme.ts b/apps/web/src/hooks/useTheme.ts--- a/apps/web/src/hooks/useTheme.ts+++ b/apps/web/src/hooks/useTheme.ts@@ -55,6 +55,7 @@
let lastSnapshot: ThemeSnapshot | null = null;
let lastDesktopTheme: Theme | null = null;
let lastAppliedTheme: ThemeSnapshot | null = null;
+let storageReadErrorLogged = false;
function emitChange() {
for (const listener of listeners) listener();
@@ -102,18 +103,21 @@
try {
return readThemePreference();
} catch (cause) {
- const error = isThemeStorageError(cause)- ? cause- : new ThemeStorageError({- operation: "read",- storageKey: STORAGE_KEY,- cause,- });- console.error(error.message, {- operation: error.operation,- storageKey: error.storageKey,- ...safeErrorLogAttributes(error),- });+ if (!storageReadErrorLogged) {+ storageReadErrorLogged = true;+ const error = isThemeStorageError(cause)+ ? cause+ : new ThemeStorageError({+ operation: "read",+ storageKey: STORAGE_KEY,+ cause,+ });+ console.error(error.message, {+ operation: error.operation,+ storageKey: error.storageKey,+ ...safeErrorLogAttributes(error),+ });+ }
return DEFAULT_THEME_SNAPSHOT.theme;
}
}

_{You can send follow-ups to the cloud agent here.}

^{Reviewed by Cursor Bugbot for commit ea4fb6d. Configure here.}

[macroscopeapp]

Approvability

Verdict: Approved

Adds structured error classes and comprehensive tests for theme storage/sync operations. The core theme behavior is unchanged; the changes wrap existing operations with proper error handling and graceful fallbacks.

^{You can customize Macroscope's approvability policy. Learn more.}