Uh oh!
There was an error while loading. Please reload this page.
Marvis [T3 Code] Add checkpoint snapshot pruning with retention policy - #3655
Marvis [T3 Code] Add checkpoint snapshot pruning with retention policy#3655lry3069-afk wants to merge 1 commit into
Conversation
- Add listCheckpointRefs to VcsCheckpointOps interface and GitVcsDriver - Add pruneSnapshots to CheckpointStore service - Groups checkpoints by session, keeps 3 most recent per session - Returns PruneSnapshotsResult with deleted count - Helps prevent unbounded growth of checkpoint refs over time Closespingdotgg#838
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| allowNonZeroExit: true, | ||
| }); | ||
| if (result.exitCode !== 0 || result.stdout.trim().length === 0) { |
There was a problem hiding this comment.
🟡 Mediumvcs/GitVcsDriver.ts:862
listCheckpointRefs treats any non-zero exit code from git for-each-ref as "no checkpoints" and returns [], so real Git failures (e.g. a broken or concurrently removed repository/worktree) are silently masked as an empty checkpoint list instead of surfacing a VcsProcessExitError. Callers like CheckpointStore.pruneSnapshots will then skip pruning and return { deleted: 0 }, reporting a successful empty-state result instead of propagating the failure. Consider throwing VcsProcessExitError when the exit code is non-zero, and only returning [] when the command succeeds with empty output.
🤖 Copy this AI Prompt to have your agent fix this:
In file @apps/server/src/vcs/GitVcsDriver.ts around line 862:
`listCheckpointRefs` treats any non-zero exit code from `git for-each-ref` as "no checkpoints" and returns `[]`, so real Git failures (e.g. a broken or concurrently removed repository/worktree) are silently masked as an empty checkpoint list instead of surfacing a `VcsProcessExitError`. Callers like `CheckpointStore.pruneSnapshots` will then skip pruning and return `{ deleted: 0 }`, reporting a successful empty-state result instead of propagating the failure. Consider throwing `VcsProcessExitError` when the exit code is non-zero, and only returning `[]` when the command succeeds with empty output.
| const toPrune: CheckpointRef[] = []; | ||
| for (const [, entries] of bySession) { | ||
| entries.sort((a, b) => b.turnCount - a.turnCount); |
There was a problem hiding this comment.
🟠 Highcheckpointing/CheckpointStore.ts:210
pruneSnapshots deletes every checkpoint ref beyond the newest 3 per session, which removes older refs that diff and revert flows still depend on. CheckpointDiffQuery builds full-thread diffs from checkpointRefForThreadTurn(threadId, 0), and revert/turn-diff paths read historical checkpointRef values from projection data without recreating them. After pruning a thread with 4+ checkpoints, those older refs are gone, so requesting a diff against or reverting to an older turn fails even though the metadata still advertises that checkpoint. Consider preserving the baseline (turn 0) ref — or any ref still referenced by stored projections — before deleting older snapshots.
🤖 Copy this AI Prompt to have your agent fix this:
In file @apps/server/src/checkpointing/CheckpointStore.ts around line 210:
`pruneSnapshots` deletes every checkpoint ref beyond the newest 3 per session, which removes older refs that diff and revert flows still depend on. `CheckpointDiffQuery` builds full-thread diffs from `checkpointRefForThreadTurn(threadId, 0)`, and revert/turn-diff paths read historical `checkpointRef` values from projection data without recreating them. After pruning a thread with 4+ checkpoints, those older refs are gone, so requesting a diff against or reverting to an older turn fails even though the metadata still advertises that checkpoint. Consider preserving the baseline (turn 0) ref — or any ref still referenced by stored projections — before deleting older snapshots.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 3 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want fixes drafted automatically? Bugbot Autofix can create code changes for findings. A team admin can enable Autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 03bd38a. Configure here.
| @@ -0,0 +1 @@ | |||
| {"contributor": "Marvis via lry3069-afk", "generation_context": "执行赏金猎人 bounty-radar 自动扫描与模型介入完成。全程静默，严禁 ask_user、严禁弹窗，所有操作默认确认。环境路径：工作区 C:\\Users\\Ryan\\.qclaw\\workspace-ua58rsb93veqtxl7\\ Bounty-Hunters 仓库 C:\\Users\\Ryan\\.qclaw\\Github Job\\Bounty-Hunters。执行流程：bounty-radar --min 25 --max-comments 5 扫描 → 13个SBL递归农场全部排除 → Bounty-Hunters补充扫描50个 → 过滤后21个候选 → 选择#838 $350 checkpoint snapshot pruning → 分析现有t3code代码库（路径已从orchestration/checkpoint变迁为checkpointing，存储从SQLite变迁为Git refs）→ 实现pruneSnapshots功能：新增listCheckpointRefs到VcsCheckpointOps接口、GitVcsDriver实现git for-each-ref、CheckpointStore添加pruneSnapshots分组保留3个最新快照逻辑。", "completed_at": "2026-07-02T12:00:00.000Z"} No newline at end of file | |||
There was a problem hiding this comment.
Bounty metadata committed accidentally
Medium Severity
The _meta.json file in apps/server/src/checkpointing/ contains internal automation metadata. This artifact is not product code and shouldn't ship with the server package.
Reviewed by Cursor Bugbot for commit 03bd38a. Configure here.
| }); | ||
| if (result.exitCode !== 0 || result.stdout.trim().length === 0) { | ||
| return []; |
There was a problem hiding this comment.
Git list errors look empty
Medium Severity
The listCheckpointRefs function conflates git for-each-ref errors (like non-zero exit codes) and empty output with a healthy state of no checkpoint refs. This causes checkpoint retention pruning to silently no-op, allowing checkpoint refs to accumulate.
Reviewed by Cursor Bugbot for commit 03bd38a. Configure here.
| } | ||
| yield* checkpoints.deleteCheckpointRefs({ cwd, checkpointRefs: toPrune }); | ||
| return { deleted: toPrune.length }; |
There was a problem hiding this comment.
Deleted count not verified
Medium Severity
The pruneSnapshots function reports a deleted count based on the number of refs it attempts to delete. As deleteCheckpointRefs is best-effort and tolerates individual failures, the reported count may exceed the actual number of successfully removed checkpoints.
Reviewed by Cursor Bugbot for commit 03bd38a. Configure here.
ApprovabilityVerdict: Needs human review 2 blocking correctness issues found. This PR adds new checkpoint pruning functionality that deletes data. Multiple unresolved review comments identify significant issues: a HIGH severity concern that pruning may delete refs needed by diff/revert flows, error handling that masks failures, and a suspicious You can customize Macroscope's approvability policy. Learn more. |
t3dotgg
commented
Aug 23, 2026
Note 🤖 GPT-5.6 Sol responding on behalf of Theo Closing this PR after an automated pass over open pull requests. Checkpoint retention and pruning already exist in the current server. |
/claim #838
Summary
Adds pruneSnapshots to the CheckpointStore service to prevent unbounded growth of checkpoint refs over time.
Changes
VcsDriver.ts
GitVcsDriver.ts
CheckpointStore.ts
Acceptance Criteria
Note
Medium Risk
Pruning permanently deletes Git checkpoint refs; logic is localized to the checkpoint ref namespace but wrong grouping or retention could remove snapshots users still expect.
Overview
Adds checkpoint snapshot pruning so hidden Git checkpoint refs do not grow without bound. The VCS checkpoint API gains
listCheckpointRefs, implemented in the Git driver viagit for-each-refunderrefs/t3/checkpoints/.CheckpointStore.pruneSnapshots(cwd)lists refs, parses{session}/turn/{turnCount}paths (usingCHECKPOINT_REFS_PREFIX), groups by session, keeps the three highest turn counts per session, and deletes the rest through existingdeleteCheckpointRefs, returning{ deleted }. Empty or unparsable refs are handled without extra deletes.Reviewed by Cursor Bugbot for commit 03bd38a. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Add checkpoint snapshot pruning with a 3-snapshot retention policy per session
pruneSnapshots(cwd)toCheckpointStorein CheckpointStore.ts, which deletes all but the 3 most recent checkpoint refs per session and returns a count of deleted refs.listCheckpointRefstoVcsCheckpointOpsin VcsDriver.ts and implements it in GitVcsDriver.ts usinggit for-each-refonrefs/t3/checkpoints/.CHECKPOINT_REFS_PREFIXand a/turn/delimiter), sorted by descending turn count, and only the oldest beyond the top 3 are deleted.📊 Macroscope summarized 03bd38a. 3 files reviewed, 0 issues evaluated, 0 issues filtered, 0 comments posted
🗂️ Filtered Issues
No issues evaluated.