Uh oh!
There was an error while loading. Please reload this page.
fix(server): stop surfacing Claude 'task_updated' messages as work-log errors - #3741
fix(server): stop surfacing Claude 'task_updated' messages as work-log errors#3741t3dotgg wants to merge 3 commits into
Conversation
…g errors The Claude Agent SDK emits system/task_updated as a task-state sync patch (per its typings, clients merge it into their local task map). The adapter's system-message switch had no case for it, so it fell into the unknown-message default and showed up in the work log as a red-X 'Claude system message' row on every background task status change. Terminal statuses already arrive via task_notification, so absorb the message silently; the raw payload remains in the provider log file. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
ApprovabilityVerdict: Needs human review The production code change is straightforward, but there's an unresolved high-severity comment indicating the new test may hang due to expecting 6 events when only 5 are produced. This test issue should be addressed before merging. You can customize Macroscope's approvability policy. Learn more. |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
apps/server/src/provider/Layers/ClaudeAdapter.ts (1)
2744-2748: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winAdd regression test for
task_updatedsilent handling.Since the bug being fixed was exactly this subtype falling into the
defaultbranch and emitting aruntime.warning(surfaced as an error row), a test asserting no runtime event/warning is emitted fortask_updatedwould guard against regression. The existingtask_progresstest atClaudeAdapter.test.ts:1682-1700is a good template to adapt.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@apps/server/src/provider/Layers/ClaudeAdapter.ts` around lines 2744 - 2748, Add a regression test for ClaudeAdapter’s `task_updated` handling so it does not fall through to the `default` branch or emit a `runtime.warning`. Mirror the existing `task_progress` case in `ClaudeAdapter.test.ts` and assert that `task_updated` is handled silently with no runtime event or warning surfaced. Use the `task_updated` switch branch in `ClaudeAdapter` and the relevant runtime/warning assertions in the test suite to anchor the new case.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@apps/server/src/provider/Layers/ClaudeAdapter.ts`:
- Around line 2744-2748: Add a regression test for ClaudeAdapter’s
`task_updated` handling so it does not fall through to the `default` branch or
emit a `runtime.warning`. Mirror the existing `task_progress` case in
`ClaudeAdapter.test.ts` and assert that `task_updated` is handled silently with
no runtime event or warning surfaced. Use the `task_updated` switch branch in
`ClaudeAdapter` and the relevant runtime/warning assertions in the test suite to
anchor the new case.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: ca86c5b4-8fae-4d67-8211-11b6ff093fef
📒 Files selected for processing (1)
apps/server/src/provider/Layers/ClaudeAdapter.ts
Co-authored-by: codex <codex@users.noreply.github.com>
Dismissing prior approval to re-evaluate f315a42
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit f315a42. Configure here.
| uuid: "task-progress-after-update-1", | ||
| } as unknown as SDKMessage); | ||
| const runtimeEvents = Array.from(yield* Fiber.join(runtimeEventsFiber)); |
There was a problem hiding this comment.
Test stream take count too high
High Severity
The new test does not surface Claude task_updated messages as runtime warnings expects 6 events from adapter.streamEvents. However, only 5 events are produced in this scenario because task_updated messages are ignored and the task_progress message lacks usage data for a thread.token-usage.updated event. This prevents Stream.take(6) from completing, causing the test to hang.
Reviewed by Cursor Bugbot for commit f315a42. Configure here.
t3dotgg
commented
Jul 30, 2026
Closing as superseded by #4244. Main now explicitly consumes task_updated and background_tasks_changed without surfacing warning rows, and this branch also retains the hanging event-count test finding. |
What Changed
Added a
task_updatedcase to the Claude adapter's system-message switch so the message is absorbed instead of falling into the unknown-message default, which rendered it as a red-X "Claude system message 'task_updated'" error row in the work log.Why
The Claude Agent SDK emits
system/task_updatedas a task-state sync patch — per the SDK's own typings, "clients merge into their local task map." It's not a loggable event, and every status patch observed in practice is redundant withtask_notification(which the adapter already maps totask.completed). So users saw a scary error on every background-task status change for a message that carries no user-facing information. The raw payload is still captured in the provider log file for debugging.Checklist
🤖 Generated with Claude Code
Note
Low Risk
Narrow adapter behavior change with a focused regression test; no auth, data, or API surface changes.
Overview
Stops treating Claude
system/task_updatedas an unknown system message that showed up as work-log errors (runtime.warning).The Claude adapter now no-ops on
task_updatedin the system-message switch (same idea asthinking_tokens): no runtime event is emitted because these messages are SDK task-map sync patches, while user-visible terminal state still comes fromtask_notification/ existingtask_progresshandling.A harness test emits
task_updatedplustask_progressand asserts noruntime.warningand thattask.progressstill appears.Reviewed by Cursor Bugbot for commit f315a42. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Fix
ClaudeAdapterto ignoretask_updatedsystem messages instead of emitting runtime warningsClaude sends
task_updatedsystem messages as task-state sync patches, but the adapter was previously surfacing them asruntime.warningevents. An explicittask_updatedcase is added to the message-handling switch in ClaudeAdapter.ts that returns immediately without enqueuing any event.Macroscope summarized f315a42.
Summary by CodeRabbit
task_updatedevent no longer triggers an unexpected warning.