Add sounds for completed turns and user input requests - #3892

Open
jakeleventhal wants to merge 12 commits into
pingdotgg:mainfrom
jakeleventhal:t3code/add-turn-status-sounds
Open

Add sounds for completed turns and user input requests#3892
jakeleventhal wants to merge 12 commits into
pingdotgg:mainfrom
jakeleventhal:t3code/add-turn-status-sounds

Conversation

@jakeleventhal

@jakeleventhaljakeleventhal commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

Summary

Screen.Recording.2026-07-11.at.6.57.13.PM.mov
  • add Cuelume's synthesized success cue when a turn completes
  • add the bloom cue when a thread begins requesting user input
  • listen to global thread-shell transitions so background threads are covered
  • suppress sounds during initial thread hydration and avoid replaying unchanged states

User impact

Users receive an audible signal when agent work finishes or pauses for input, including when the affected thread is not currently open.

Validation

  • vp test apps/web/src/interactionSounds.test.ts
  • vp check
  • vp run typecheck

Note

Medium Risk
Touches orchestration projection queries and latest-turn contract shape; incorrect turn association or hydration gating could cause missed or spurious audio, but behavior is heavily unit-tested.

Overview
Adds interaction sounds across web (via cuelume) and mobile (via expo-audio + generated WAV assets): a success cue when a user-initiated turn completes and a bloom cue when a thread newly needs input or approval. Per-thread coordinators in the app shell watch all thread shells (including background threads) and use shared logic in @t3tools/client-runtime/interaction-sounds to derive cues while skipping initial hydration, cached startup, and unchanged state; liveEnvironmentIdsAtom gates when environments are treated as live.

Introduces enableCompletionSounds (default on) in client settings with UI on web/desktop General settings and completionSoundEnabled on mobile (device-local preferences). Disabling completion sounds leaves input-required bloom cues on.

Server/API: OrchestrationLatestTurn.initiatingUserMessageId (from projection_turns.pending_message_id) so clients can distinguish user-started turns from background work, with a legacy time-window fallback when the field is absent.

Reviewed by Cursor Bugbot for commit 4afad56. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Add interaction sounds for completed turns and user input requests

  • Adds platform-agnostic logic in interactionSounds.ts to derive success and bloom sound cues from thread state transitions.
  • Implements InteractionSoundCoordinator components for web (via cuelume) and mobile (via expo-audio) to play cues globally.
  • Adds an enableCompletionSounds setting to client settings, persistence, and settings UIs across platforms.
  • Updates ProjectionSnapshotQuery to select turns.pending_message_id and map it to OrchestrationLatestTurn.initiatingUserMessageId for sound association.
  • Risk: The OrchestrationLatestTurn schema change adds an optional initiatingUserMessageId field; out-of-tree contract consumers must handle the new field.

Macroscope summarized 4afad56.

@coderabbitai

coderabbitaiBot commented Jul 11, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 61a9b950-c1a1-46c8-b029-7cf67a7b7de6

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actionsgithub-actionsBot added size:M 30-99 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list. labels Jul 11, 2026
@jakeleventhal
jakeleventhal marked this pull request as ready for review July 11, 2026 18:06
@macroscopeapp

macroscopeappBot commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This change adds a cross-platform audible notification system that runs globally across thread state, introduces platform-specific audio integrations/assets, and extends server/client projection data and settings. Its impact is broader than a small isolated toggle or additive field, so the runtime behavior and multi-platform integration merit human review.

You can add or adjust custom eligibility rules. Learn more.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@github-actionsgithub-actionsBot added size:L 100-499 changed lines (additions + deletions). and removed size:M 30-99 changed lines (additions + deletions). labels Jul 11, 2026
Comment threadapps/web/src/routes/__root.tsx Outdated
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

Comment threadapps/web/src/interactionSounds.ts Outdated
Comment threadpackages/client-runtime/src/interactionSounds.ts Outdated

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:9626d0808d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadapps/web/src/routes/__root.tsx Outdated

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:ac5b546dc8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadapps/web/src/interactionSounds.ts Outdated

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:61cef120a4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadapps/web/src/routes/__root.tsx Outdated
Comment threadapps/web/src/interactionSounds.ts Outdated

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:163b2edcbc

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadapps/web/src/interactionSounds.ts Outdated
Comment threadapps/web/src/routes/__root.tsx Outdated
@jakeleventhal
jakeleventhalforce-pushed the t3code/add-turn-status-sounds branch 2 times, most recently from 88fe364 to 37c74dbCompareJuly 29, 2026 16:58
Comment threadapps/web/src/state/shell.ts Outdated

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:37c74db3b1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadapps/web/src/components/settings/SettingsPanels.tsx
Comment threadapps/web/src/routes/__root.tsx
@jakeleventhal
jakeleventhalforce-pushed the t3code/add-turn-status-sounds branch from 37c74db to b4353cfCompareJuly 29, 2026 17:42
@github-actionsgithub-actionsBot added size:XL 500-999 changed lines (additions + deletions). and removed size:L 100-499 changed lines (additions + deletions). labels Jul 29, 2026
Comment threadpackages/client-runtime/src/interactionSounds.ts Outdated
Comment threadapps/web/src/routes/__root.tsx Outdated

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:b4353cf67b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadapps/web/src/routes/__root.tsx Outdated
Comment threadapps/web/src/state/shell.ts
Comment threaddocs/user/interaction-sounds.md Outdated

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:1b1cf11d7a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadpackages/client-runtime/src/interactionSounds.ts Outdated
mwolson added a commit to mwolson/t3code that referenced this pull request Aug 19, 2026
CTM already deleted this main-era suite in the stranded-main port. The
pingdotgg#3892 interaction-sounds port only needed initiatingUserMessageId on the
live query path, which remains in ProjectionSnapshotQuery.ts.
mwolson added a commit to mwolson/t3code that referenced this pull request Aug 19, 2026
pingdotgg#3892 targets main's latestTurn shape. CTM EnvironmentThreadShell exposes
latestRun with runId/status timestamps and no initiatingUserMessageId.
Drive success cues from completed runs associated with a nearby user
message, and keep bloom on pending input/approval edges.
@t3dotggt3dotgg added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. and removed vouch:unvouched PR author is not yet trusted in the VOUCHED list. labels Aug 24, 2026
@jakeleventhal
jakeleventhalforce-pushed the t3code/add-turn-status-sounds branch from 39c55e7 to d29f5ddCompareAugust 26, 2026 02:36
Comment threadpackages/client-runtime/src/interactionSounds.ts

@macroscopeappmacroscopeappBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the web-side changes for UI consistency. The new General → Completion sound row follows the existing SettingsRow + Switch + searchableSetting + SettingResetButton contract exactly, and the restore-defaults label/patch wiring is consistent, so no primitive, Tailwind, theme, or scroll findings there. Two consistency/robustness points on the new coordinator plumbing are noted inline.

Posted via Macroscope — UI Consistency

Comment threadapps/web/src/routes/__root.tsx
Comment threadapps/web/src/state/shell.ts Outdated
mwolson added a commit to mwolson/t3code that referenced this pull request Aug 29, 2026
CTM already deleted this main-era suite in the stranded-main port. The
pingdotgg#3892 interaction-sounds port only needed initiatingUserMessageId on the
live query path, which remains in ProjectionSnapshotQuery.ts.
mwolson added a commit to mwolson/t3code that referenced this pull request Aug 29, 2026
pingdotgg#3892 targets main's latestTurn shape. CTM EnvironmentThreadShell exposes
latestRun with runId/status timestamps and no initiatingUserMessageId.
Drive success cues from completed runs associated with a nearby user
message, and keep bloom on pending input/approval edges.
mwolson added a commit to mwolson/t3code that referenced this pull request Sep 1, 2026
CTM already deleted this main-era suite in the stranded-main port. The
pingdotgg#3892 interaction-sounds port only needed initiatingUserMessageId on the
live query path, which remains in ProjectionSnapshotQuery.ts.
mwolson added a commit to mwolson/t3code that referenced this pull request Sep 1, 2026
pingdotgg#3892 targets main's latestTurn shape. CTM EnvironmentThreadShell exposes
latestRun with runId/status timestamps and no initiatingUserMessageId.
Drive success cues from completed runs associated with a nearby user
message, and keep bloom on pending input/approval edges.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XL500-999 changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@jakeleventhal@t3dotgg
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

Add sounds for completed turns and user input requests - #3892

Open
jakeleventhal wants to merge 12 commits into
pingdotgg:mainfrom
jakeleventhal:t3code/add-turn-status-sounds
Open

Add sounds for completed turns and user input requests#3892
jakeleventhal wants to merge 12 commits into
pingdotgg:mainfrom
jakeleventhal:t3code/add-turn-status-sounds

Conversation

@jakeleventhal

@jakeleventhaljakeleventhal commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

Summary

Screen.Recording.2026-07-11.at.6.57.13.PM.mov
  • add Cuelume's synthesized success cue when a turn completes
  • add the bloom cue when a thread begins requesting user input
  • listen to global thread-shell transitions so background threads are covered
  • suppress sounds during initial thread hydration and avoid replaying unchanged states

User impact

Users receive an audible signal when agent work finishes or pauses for input, including when the affected thread is not currently open.

Validation

  • vp test apps/web/src/interactionSounds.test.ts
  • vp check
  • vp run typecheck

Note

Medium Risk
Touches orchestration projection queries and latest-turn contract shape; incorrect turn association or hydration gating could cause missed or spurious audio, but behavior is heavily unit-tested.

Overview
Adds interaction sounds across web (via cuelume) and mobile (via expo-audio + generated WAV assets): a success cue when a user-initiated turn completes and a bloom cue when a thread newly needs input or approval. Per-thread coordinators in the app shell watch all thread shells (including background threads) and use shared logic in @t3tools/client-runtime/interaction-sounds to derive cues while skipping initial hydration, cached startup, and unchanged state; liveEnvironmentIdsAtom gates when environments are treated as live.

Introduces enableCompletionSounds (default on) in client settings with UI on web/desktop General settings and completionSoundEnabled on mobile (device-local preferences). Disabling completion sounds leaves input-required bloom cues on.

Server/API: OrchestrationLatestTurn.initiatingUserMessageId (from projection_turns.pending_message_id) so clients can distinguish user-started turns from background work, with a legacy time-window fallback when the field is absent.

Reviewed by Cursor Bugbot for commit 4afad56. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Add interaction sounds for completed turns and user input requests

  • Adds platform-agnostic logic in interactionSounds.ts to derive success and bloom sound cues from thread state transitions.
  • Implements InteractionSoundCoordinator components for web (via cuelume) and mobile (via expo-audio) to play cues globally.
  • Adds an enableCompletionSounds setting to client settings, persistence, and settings UIs across platforms.
  • Updates ProjectionSnapshotQuery to select turns.pending_message_id and map it to OrchestrationLatestTurn.initiatingUserMessageId for sound association.
  • Risk: The OrchestrationLatestTurn schema change adds an optional initiatingUserMessageId field; out-of-tree contract consumers must handle the new field.

Macroscope summarized 4afad56.

@coderabbitai

coderabbitaiBot commented Jul 11, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 61a9b950-c1a1-46c8-b029-7cf67a7b7de6

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actionsgithub-actionsBot added size:M 30-99 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list. labels Jul 11, 2026
@jakeleventhal
jakeleventhal marked this pull request as ready for review July 11, 2026 18:06
@macroscopeapp

macroscopeappBot commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This change adds a cross-platform audible notification system that runs globally across thread state, introduces platform-specific audio integrations/assets, and extends server/client projection data and settings. Its impact is broader than a small isolated toggle or additive field, so the runtime behavior and multi-platform integration merit human review.

You can add or adjust custom eligibility rules. Learn more.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@github-actionsgithub-actionsBot added size:L 100-499 changed lines (additions + deletions). and removed size:M 30-99 changed lines (additions + deletions). labels Jul 11, 2026
Comment threadapps/web/src/routes/__root.tsx Outdated
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

Comment threadapps/web/src/interactionSounds.ts Outdated
Comment threadpackages/client-runtime/src/interactionSounds.ts Outdated

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:9626d0808d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadapps/web/src/routes/__root.tsx Outdated

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:ac5b546dc8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadapps/web/src/interactionSounds.ts Outdated

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:61cef120a4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadapps/web/src/routes/__root.tsx Outdated
Comment threadapps/web/src/interactionSounds.ts Outdated

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:163b2edcbc

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadapps/web/src/interactionSounds.ts Outdated
Comment threadapps/web/src/routes/__root.tsx Outdated
@jakeleventhal
jakeleventhalforce-pushed the t3code/add-turn-status-sounds branch 2 times, most recently from 88fe364 to 37c74dbCompareJuly 29, 2026 16:58
Comment threadapps/web/src/state/shell.ts Outdated

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:37c74db3b1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadapps/web/src/components/settings/SettingsPanels.tsx
Comment threadapps/web/src/routes/__root.tsx
@jakeleventhal
jakeleventhalforce-pushed the t3code/add-turn-status-sounds branch from 37c74db to b4353cfCompareJuly 29, 2026 17:42
@github-actionsgithub-actionsBot added size:XL 500-999 changed lines (additions + deletions). and removed size:L 100-499 changed lines (additions + deletions). labels Jul 29, 2026
Comment threadpackages/client-runtime/src/interactionSounds.ts Outdated
Comment threadapps/web/src/routes/__root.tsx Outdated

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:b4353cf67b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadapps/web/src/routes/__root.tsx Outdated
Comment threadapps/web/src/state/shell.ts
Comment threaddocs/user/interaction-sounds.md Outdated

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:1b1cf11d7a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadpackages/client-runtime/src/interactionSounds.ts Outdated
mwolson added a commit to mwolson/t3code that referenced this pull request Aug 19, 2026
CTM already deleted this main-era suite in the stranded-main port. The
pingdotgg#3892 interaction-sounds port only needed initiatingUserMessageId on the
live query path, which remains in ProjectionSnapshotQuery.ts.
mwolson added a commit to mwolson/t3code that referenced this pull request Aug 19, 2026
pingdotgg#3892 targets main's latestTurn shape. CTM EnvironmentThreadShell exposes
latestRun with runId/status timestamps and no initiatingUserMessageId.
Drive success cues from completed runs associated with a nearby user
message, and keep bloom on pending input/approval edges.
@t3dotggt3dotgg added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. and removed vouch:unvouched PR author is not yet trusted in the VOUCHED list. labels Aug 24, 2026
@jakeleventhal
jakeleventhalforce-pushed the t3code/add-turn-status-sounds branch from 39c55e7 to d29f5ddCompareAugust 26, 2026 02:36
Comment threadpackages/client-runtime/src/interactionSounds.ts

@macroscopeappmacroscopeappBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the web-side changes for UI consistency. The new General → Completion sound row follows the existing SettingsRow + Switch + searchableSetting + SettingResetButton contract exactly, and the restore-defaults label/patch wiring is consistent, so no primitive, Tailwind, theme, or scroll findings there. Two consistency/robustness points on the new coordinator plumbing are noted inline.

Posted via Macroscope — UI Consistency

Comment threadapps/web/src/routes/__root.tsx
Comment threadapps/web/src/state/shell.ts Outdated
mwolson added a commit to mwolson/t3code that referenced this pull request Aug 29, 2026
CTM already deleted this main-era suite in the stranded-main port. The
pingdotgg#3892 interaction-sounds port only needed initiatingUserMessageId on the
live query path, which remains in ProjectionSnapshotQuery.ts.
mwolson added a commit to mwolson/t3code that referenced this pull request Aug 29, 2026
pingdotgg#3892 targets main's latestTurn shape. CTM EnvironmentThreadShell exposes
latestRun with runId/status timestamps and no initiatingUserMessageId.
Drive success cues from completed runs associated with a nearby user
message, and keep bloom on pending input/approval edges.
mwolson added a commit to mwolson/t3code that referenced this pull request Sep 1, 2026
CTM already deleted this main-era suite in the stranded-main port. The
pingdotgg#3892 interaction-sounds port only needed initiatingUserMessageId on the
live query path, which remains in ProjectionSnapshotQuery.ts.
mwolson added a commit to mwolson/t3code that referenced this pull request Sep 1, 2026
pingdotgg#3892 targets main's latestTurn shape. CTM EnvironmentThreadShell exposes
latestRun with runId/status timestamps and no initiatingUserMessageId.
Drive success cues from completed runs associated with a nearby user
message, and keep bloom on pending input/approval edges.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XL500-999 changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@jakeleventhal@t3dotgg
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Add sounds for completed turns and user input requests - #3892

Open
jakeleventhal wants to merge 12 commits into
pingdotgg:mainfrom
jakeleventhal:t3code/add-turn-status-sounds
Open

Add sounds for completed turns and user input requests#3892
jakeleventhal wants to merge 12 commits into
pingdotgg:mainfrom
jakeleventhal:t3code/add-turn-status-sounds

Conversation

@jakeleventhal

@jakeleventhaljakeleventhal commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

Summary

Screen.Recording.2026-07-11.at.6.57.13.PM.mov
  • add Cuelume's synthesized success cue when a turn completes
  • add the bloom cue when a thread begins requesting user input
  • listen to global thread-shell transitions so background threads are covered
  • suppress sounds during initial thread hydration and avoid replaying unchanged states

User impact

Users receive an audible signal when agent work finishes or pauses for input, including when the affected thread is not currently open.

Validation

  • vp test apps/web/src/interactionSounds.test.ts
  • vp check
  • vp run typecheck

Note

Medium Risk
Touches orchestration projection queries and latest-turn contract shape; incorrect turn association or hydration gating could cause missed or spurious audio, but behavior is heavily unit-tested.

Overview
Adds interaction sounds across web (via cuelume) and mobile (via expo-audio + generated WAV assets): a success cue when a user-initiated turn completes and a bloom cue when a thread newly needs input or approval. Per-thread coordinators in the app shell watch all thread shells (including background threads) and use shared logic in @t3tools/client-runtime/interaction-sounds to derive cues while skipping initial hydration, cached startup, and unchanged state; liveEnvironmentIdsAtom gates when environments are treated as live.

Introduces enableCompletionSounds (default on) in client settings with UI on web/desktop General settings and completionSoundEnabled on mobile (device-local preferences). Disabling completion sounds leaves input-required bloom cues on.

Server/API: OrchestrationLatestTurn.initiatingUserMessageId (from projection_turns.pending_message_id) so clients can distinguish user-started turns from background work, with a legacy time-window fallback when the field is absent.

Reviewed by Cursor Bugbot for commit 4afad56. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Add interaction sounds for completed turns and user input requests

  • Adds platform-agnostic logic in interactionSounds.ts to derive success and bloom sound cues from thread state transitions.
  • Implements InteractionSoundCoordinator components for web (via cuelume) and mobile (via expo-audio) to play cues globally.
  • Adds an enableCompletionSounds setting to client settings, persistence, and settings UIs across platforms.
  • Updates ProjectionSnapshotQuery to select turns.pending_message_id and map it to OrchestrationLatestTurn.initiatingUserMessageId for sound association.
  • Risk: The OrchestrationLatestTurn schema change adds an optional initiatingUserMessageId field; out-of-tree contract consumers must handle the new field.

Macroscope summarized 4afad56.

@coderabbitai

coderabbitaiBot commented Jul 11, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 61a9b950-c1a1-46c8-b029-7cf67a7b7de6

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actionsgithub-actionsBot added size:M 30-99 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list. labels Jul 11, 2026
@jakeleventhal
jakeleventhal marked this pull request as ready for review July 11, 2026 18:06
@macroscopeapp

macroscopeappBot commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This change adds a cross-platform audible notification system that runs globally across thread state, introduces platform-specific audio integrations/assets, and extends server/client projection data and settings. Its impact is broader than a small isolated toggle or additive field, so the runtime behavior and multi-platform integration merit human review.

You can add or adjust custom eligibility rules. Learn more.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@github-actionsgithub-actionsBot added size:L 100-499 changed lines (additions + deletions). and removed size:M 30-99 changed lines (additions + deletions). labels Jul 11, 2026
Comment threadapps/web/src/routes/__root.tsx Outdated
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

Comment threadapps/web/src/interactionSounds.ts Outdated
Comment threadpackages/client-runtime/src/interactionSounds.ts Outdated

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:9626d0808d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadapps/web/src/routes/__root.tsx Outdated

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:ac5b546dc8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadapps/web/src/interactionSounds.ts Outdated

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:61cef120a4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadapps/web/src/routes/__root.tsx Outdated
Comment threadapps/web/src/interactionSounds.ts Outdated

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:163b2edcbc

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadapps/web/src/interactionSounds.ts Outdated
Comment threadapps/web/src/routes/__root.tsx Outdated
@jakeleventhal
jakeleventhalforce-pushed the t3code/add-turn-status-sounds branch 2 times, most recently from 88fe364 to 37c74dbCompareJuly 29, 2026 16:58
Comment threadapps/web/src/state/shell.ts Outdated

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:37c74db3b1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadapps/web/src/components/settings/SettingsPanels.tsx
Comment threadapps/web/src/routes/__root.tsx
@jakeleventhal
jakeleventhalforce-pushed the t3code/add-turn-status-sounds branch from 37c74db to b4353cfCompareJuly 29, 2026 17:42
@github-actionsgithub-actionsBot added size:XL 500-999 changed lines (additions + deletions). and removed size:L 100-499 changed lines (additions + deletions). labels Jul 29, 2026
Comment threadpackages/client-runtime/src/interactionSounds.ts Outdated
Comment threadapps/web/src/routes/__root.tsx Outdated

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:b4353cf67b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadapps/web/src/routes/__root.tsx Outdated
Comment threadapps/web/src/state/shell.ts
Comment threaddocs/user/interaction-sounds.md Outdated

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:1b1cf11d7a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadpackages/client-runtime/src/interactionSounds.ts Outdated
mwolson added a commit to mwolson/t3code that referenced this pull request Aug 19, 2026
CTM already deleted this main-era suite in the stranded-main port. The
pingdotgg#3892 interaction-sounds port only needed initiatingUserMessageId on the
live query path, which remains in ProjectionSnapshotQuery.ts.
mwolson added a commit to mwolson/t3code that referenced this pull request Aug 19, 2026
pingdotgg#3892 targets main's latestTurn shape. CTM EnvironmentThreadShell exposes
latestRun with runId/status timestamps and no initiatingUserMessageId.
Drive success cues from completed runs associated with a nearby user
message, and keep bloom on pending input/approval edges.
@t3dotggt3dotgg added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. and removed vouch:unvouched PR author is not yet trusted in the VOUCHED list. labels Aug 24, 2026
@jakeleventhal
jakeleventhalforce-pushed the t3code/add-turn-status-sounds branch from 39c55e7 to d29f5ddCompareAugust 26, 2026 02:36
Comment threadpackages/client-runtime/src/interactionSounds.ts

@macroscopeappmacroscopeappBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the web-side changes for UI consistency. The new General → Completion sound row follows the existing SettingsRow + Switch + searchableSetting + SettingResetButton contract exactly, and the restore-defaults label/patch wiring is consistent, so no primitive, Tailwind, theme, or scroll findings there. Two consistency/robustness points on the new coordinator plumbing are noted inline.

Posted via Macroscope — UI Consistency

Comment threadapps/web/src/routes/__root.tsx
Comment threadapps/web/src/state/shell.ts Outdated
mwolson added a commit to mwolson/t3code that referenced this pull request Aug 29, 2026
CTM already deleted this main-era suite in the stranded-main port. The
pingdotgg#3892 interaction-sounds port only needed initiatingUserMessageId on the
live query path, which remains in ProjectionSnapshotQuery.ts.
mwolson added a commit to mwolson/t3code that referenced this pull request Aug 29, 2026
pingdotgg#3892 targets main's latestTurn shape. CTM EnvironmentThreadShell exposes
latestRun with runId/status timestamps and no initiatingUserMessageId.
Drive success cues from completed runs associated with a nearby user
message, and keep bloom on pending input/approval edges.
mwolson added a commit to mwolson/t3code that referenced this pull request Sep 1, 2026
CTM already deleted this main-era suite in the stranded-main port. The
pingdotgg#3892 interaction-sounds port only needed initiatingUserMessageId on the
live query path, which remains in ProjectionSnapshotQuery.ts.
mwolson added a commit to mwolson/t3code that referenced this pull request Sep 1, 2026
pingdotgg#3892 targets main's latestTurn shape. CTM EnvironmentThreadShell exposes
latestRun with runId/status timestamps and no initiatingUserMessageId.
Drive success cues from completed runs associated with a nearby user
message, and keep bloom on pending input/approval edges.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XL500-999 changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@jakeleventhal@t3dotgg
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Add sounds for completed turns and user input requests - #3892

Open
jakeleventhal wants to merge 12 commits into
pingdotgg:mainfrom
jakeleventhal:t3code/add-turn-status-sounds
Open

Add sounds for completed turns and user input requests#3892
jakeleventhal wants to merge 12 commits into
pingdotgg:mainfrom
jakeleventhal:t3code/add-turn-status-sounds

Conversation

@jakeleventhal

@jakeleventhaljakeleventhal commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

Summary

Screen.Recording.2026-07-11.at.6.57.13.PM.mov
  • add Cuelume's synthesized success cue when a turn completes
  • add the bloom cue when a thread begins requesting user input
  • listen to global thread-shell transitions so background threads are covered
  • suppress sounds during initial thread hydration and avoid replaying unchanged states

User impact

Users receive an audible signal when agent work finishes or pauses for input, including when the affected thread is not currently open.

Validation

  • vp test apps/web/src/interactionSounds.test.ts
  • vp check
  • vp run typecheck

Note

Medium Risk
Touches orchestration projection queries and latest-turn contract shape; incorrect turn association or hydration gating could cause missed or spurious audio, but behavior is heavily unit-tested.

Overview
Adds interaction sounds across web (via cuelume) and mobile (via expo-audio + generated WAV assets): a success cue when a user-initiated turn completes and a bloom cue when a thread newly needs input or approval. Per-thread coordinators in the app shell watch all thread shells (including background threads) and use shared logic in @t3tools/client-runtime/interaction-sounds to derive cues while skipping initial hydration, cached startup, and unchanged state; liveEnvironmentIdsAtom gates when environments are treated as live.

Introduces enableCompletionSounds (default on) in client settings with UI on web/desktop General settings and completionSoundEnabled on mobile (device-local preferences). Disabling completion sounds leaves input-required bloom cues on.

Server/API: OrchestrationLatestTurn.initiatingUserMessageId (from projection_turns.pending_message_id) so clients can distinguish user-started turns from background work, with a legacy time-window fallback when the field is absent.

Reviewed by Cursor Bugbot for commit 4afad56. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Add interaction sounds for completed turns and user input requests

  • Adds platform-agnostic logic in interactionSounds.ts to derive success and bloom sound cues from thread state transitions.
  • Implements InteractionSoundCoordinator components for web (via cuelume) and mobile (via expo-audio) to play cues globally.
  • Adds an enableCompletionSounds setting to client settings, persistence, and settings UIs across platforms.
  • Updates ProjectionSnapshotQuery to select turns.pending_message_id and map it to OrchestrationLatestTurn.initiatingUserMessageId for sound association.
  • Risk: The OrchestrationLatestTurn schema change adds an optional initiatingUserMessageId field; out-of-tree contract consumers must handle the new field.

Macroscope summarized 4afad56.

@coderabbitai

coderabbitaiBot commented Jul 11, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 61a9b950-c1a1-46c8-b029-7cf67a7b7de6

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actionsgithub-actionsBot added size:M 30-99 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list. labels Jul 11, 2026
@jakeleventhal
jakeleventhal marked this pull request as ready for review July 11, 2026 18:06
@macroscopeapp

macroscopeappBot commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This change adds a cross-platform audible notification system that runs globally across thread state, introduces platform-specific audio integrations/assets, and extends server/client projection data and settings. Its impact is broader than a small isolated toggle or additive field, so the runtime behavior and multi-platform integration merit human review.

You can add or adjust custom eligibility rules. Learn more.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@github-actionsgithub-actionsBot added size:L 100-499 changed lines (additions + deletions). and removed size:M 30-99 changed lines (additions + deletions). labels Jul 11, 2026
Comment threadapps/web/src/routes/__root.tsx Outdated
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

Comment threadapps/web/src/interactionSounds.ts Outdated
Comment threadpackages/client-runtime/src/interactionSounds.ts Outdated

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:9626d0808d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadapps/web/src/routes/__root.tsx Outdated

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:ac5b546dc8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadapps/web/src/interactionSounds.ts Outdated

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:61cef120a4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadapps/web/src/routes/__root.tsx Outdated
Comment threadapps/web/src/interactionSounds.ts Outdated

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:163b2edcbc

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadapps/web/src/interactionSounds.ts Outdated
Comment threadapps/web/src/routes/__root.tsx Outdated
@jakeleventhal
jakeleventhalforce-pushed the t3code/add-turn-status-sounds branch 2 times, most recently from 88fe364 to 37c74dbCompareJuly 29, 2026 16:58
Comment threadapps/web/src/state/shell.ts Outdated

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:37c74db3b1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadapps/web/src/components/settings/SettingsPanels.tsx
Comment threadapps/web/src/routes/__root.tsx
@jakeleventhal
jakeleventhalforce-pushed the t3code/add-turn-status-sounds branch from 37c74db to b4353cfCompareJuly 29, 2026 17:42
@github-actionsgithub-actionsBot added size:XL 500-999 changed lines (additions + deletions). and removed size:L 100-499 changed lines (additions + deletions). labels Jul 29, 2026
Comment threadpackages/client-runtime/src/interactionSounds.ts Outdated
Comment threadapps/web/src/routes/__root.tsx Outdated

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:b4353cf67b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadapps/web/src/routes/__root.tsx Outdated
Comment threadapps/web/src/state/shell.ts
Comment threaddocs/user/interaction-sounds.md Outdated

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:1b1cf11d7a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadpackages/client-runtime/src/interactionSounds.ts Outdated
mwolson added a commit to mwolson/t3code that referenced this pull request Aug 19, 2026
CTM already deleted this main-era suite in the stranded-main port. The
pingdotgg#3892 interaction-sounds port only needed initiatingUserMessageId on the
live query path, which remains in ProjectionSnapshotQuery.ts.
mwolson added a commit to mwolson/t3code that referenced this pull request Aug 19, 2026
pingdotgg#3892 targets main's latestTurn shape. CTM EnvironmentThreadShell exposes
latestRun with runId/status timestamps and no initiatingUserMessageId.
Drive success cues from completed runs associated with a nearby user
message, and keep bloom on pending input/approval edges.
@t3dotggt3dotgg added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. and removed vouch:unvouched PR author is not yet trusted in the VOUCHED list. labels Aug 24, 2026
@jakeleventhal
jakeleventhalforce-pushed the t3code/add-turn-status-sounds branch from 39c55e7 to d29f5ddCompareAugust 26, 2026 02:36
Comment threadpackages/client-runtime/src/interactionSounds.ts

@macroscopeappmacroscopeappBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the web-side changes for UI consistency. The new General → Completion sound row follows the existing SettingsRow + Switch + searchableSetting + SettingResetButton contract exactly, and the restore-defaults label/patch wiring is consistent, so no primitive, Tailwind, theme, or scroll findings there. Two consistency/robustness points on the new coordinator plumbing are noted inline.

Posted via Macroscope — UI Consistency

Comment threadapps/web/src/routes/__root.tsx
Comment threadapps/web/src/state/shell.ts Outdated
mwolson added a commit to mwolson/t3code that referenced this pull request Aug 29, 2026
CTM already deleted this main-era suite in the stranded-main port. The
pingdotgg#3892 interaction-sounds port only needed initiatingUserMessageId on the
live query path, which remains in ProjectionSnapshotQuery.ts.
mwolson added a commit to mwolson/t3code that referenced this pull request Aug 29, 2026
pingdotgg#3892 targets main's latestTurn shape. CTM EnvironmentThreadShell exposes
latestRun with runId/status timestamps and no initiatingUserMessageId.
Drive success cues from completed runs associated with a nearby user
message, and keep bloom on pending input/approval edges.
mwolson added a commit to mwolson/t3code that referenced this pull request Sep 1, 2026
CTM already deleted this main-era suite in the stranded-main port. The
pingdotgg#3892 interaction-sounds port only needed initiatingUserMessageId on the
live query path, which remains in ProjectionSnapshotQuery.ts.
mwolson added a commit to mwolson/t3code that referenced this pull request Sep 1, 2026
pingdotgg#3892 targets main's latestTurn shape. CTM EnvironmentThreadShell exposes
latestRun with runId/status timestamps and no initiatingUserMessageId.
Drive success cues from completed runs associated with a nearby user
message, and keep bloom on pending input/approval edges.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XL500-999 changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@jakeleventhal@t3dotgg
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

Add sounds for completed turns and user input requests - #3892

Open
jakeleventhal wants to merge 12 commits into
pingdotgg:mainfrom
jakeleventhal:t3code/add-turn-status-sounds
Open

Add sounds for completed turns and user input requests#3892
jakeleventhal wants to merge 12 commits into
pingdotgg:mainfrom
jakeleventhal:t3code/add-turn-status-sounds

Conversation

@jakeleventhal

@jakeleventhaljakeleventhal commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

Summary

Screen.Recording.2026-07-11.at.6.57.13.PM.mov
  • add Cuelume's synthesized success cue when a turn completes
  • add the bloom cue when a thread begins requesting user input
  • listen to global thread-shell transitions so background threads are covered
  • suppress sounds during initial thread hydration and avoid replaying unchanged states

User impact

Users receive an audible signal when agent work finishes or pauses for input, including when the affected thread is not currently open.

Validation

  • vp test apps/web/src/interactionSounds.test.ts
  • vp check
  • vp run typecheck

Note

Medium Risk
Touches orchestration projection queries and latest-turn contract shape; incorrect turn association or hydration gating could cause missed or spurious audio, but behavior is heavily unit-tested.

Overview
Adds interaction sounds across web (via cuelume) and mobile (via expo-audio + generated WAV assets): a success cue when a user-initiated turn completes and a bloom cue when a thread newly needs input or approval. Per-thread coordinators in the app shell watch all thread shells (including background threads) and use shared logic in @t3tools/client-runtime/interaction-sounds to derive cues while skipping initial hydration, cached startup, and unchanged state; liveEnvironmentIdsAtom gates when environments are treated as live.

Introduces enableCompletionSounds (default on) in client settings with UI on web/desktop General settings and completionSoundEnabled on mobile (device-local preferences). Disabling completion sounds leaves input-required bloom cues on.

Server/API: OrchestrationLatestTurn.initiatingUserMessageId (from projection_turns.pending_message_id) so clients can distinguish user-started turns from background work, with a legacy time-window fallback when the field is absent.

Reviewed by Cursor Bugbot for commit 4afad56. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Add interaction sounds for completed turns and user input requests

  • Adds platform-agnostic logic in interactionSounds.ts to derive success and bloom sound cues from thread state transitions.
  • Implements InteractionSoundCoordinator components for web (via cuelume) and mobile (via expo-audio) to play cues globally.
  • Adds an enableCompletionSounds setting to client settings, persistence, and settings UIs across platforms.
  • Updates ProjectionSnapshotQuery to select turns.pending_message_id and map it to OrchestrationLatestTurn.initiatingUserMessageId for sound association.
  • Risk: The OrchestrationLatestTurn schema change adds an optional initiatingUserMessageId field; out-of-tree contract consumers must handle the new field.

Macroscope summarized 4afad56.

@coderabbitai

coderabbitaiBot commented Jul 11, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 61a9b950-c1a1-46c8-b029-7cf67a7b7de6

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actionsgithub-actionsBot added size:M 30-99 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list. labels Jul 11, 2026
@jakeleventhal
jakeleventhal marked this pull request as ready for review July 11, 2026 18:06
@macroscopeapp

macroscopeappBot commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This change adds a cross-platform audible notification system that runs globally across thread state, introduces platform-specific audio integrations/assets, and extends server/client projection data and settings. Its impact is broader than a small isolated toggle or additive field, so the runtime behavior and multi-platform integration merit human review.

You can add or adjust custom eligibility rules. Learn more.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@github-actionsgithub-actionsBot added size:L 100-499 changed lines (additions + deletions). and removed size:M 30-99 changed lines (additions + deletions). labels Jul 11, 2026
Comment threadapps/web/src/routes/__root.tsx Outdated
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

Comment threadapps/web/src/interactionSounds.ts Outdated
Comment threadpackages/client-runtime/src/interactionSounds.ts Outdated

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:9626d0808d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadapps/web/src/routes/__root.tsx Outdated

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:ac5b546dc8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadapps/web/src/interactionSounds.ts Outdated

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:61cef120a4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadapps/web/src/routes/__root.tsx Outdated
Comment threadapps/web/src/interactionSounds.ts Outdated

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:163b2edcbc

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadapps/web/src/interactionSounds.ts Outdated
Comment threadapps/web/src/routes/__root.tsx Outdated
@jakeleventhal
jakeleventhalforce-pushed the t3code/add-turn-status-sounds branch 2 times, most recently from 88fe364 to 37c74dbCompareJuly 29, 2026 16:58
Comment threadapps/web/src/state/shell.ts Outdated

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:37c74db3b1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadapps/web/src/components/settings/SettingsPanels.tsx
Comment threadapps/web/src/routes/__root.tsx
@jakeleventhal
jakeleventhalforce-pushed the t3code/add-turn-status-sounds branch from 37c74db to b4353cfCompareJuly 29, 2026 17:42
@github-actionsgithub-actionsBot added size:XL 500-999 changed lines (additions + deletions). and removed size:L 100-499 changed lines (additions + deletions). labels Jul 29, 2026
Comment threadpackages/client-runtime/src/interactionSounds.ts Outdated
Comment threadapps/web/src/routes/__root.tsx Outdated

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:b4353cf67b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadapps/web/src/routes/__root.tsx Outdated
Comment threadapps/web/src/state/shell.ts
Comment threaddocs/user/interaction-sounds.md Outdated

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:1b1cf11d7a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadpackages/client-runtime/src/interactionSounds.ts Outdated
mwolson added a commit to mwolson/t3code that referenced this pull request Aug 19, 2026
CTM already deleted this main-era suite in the stranded-main port. The
pingdotgg#3892 interaction-sounds port only needed initiatingUserMessageId on the
live query path, which remains in ProjectionSnapshotQuery.ts.
mwolson added a commit to mwolson/t3code that referenced this pull request Aug 19, 2026
pingdotgg#3892 targets main's latestTurn shape. CTM EnvironmentThreadShell exposes
latestRun with runId/status timestamps and no initiatingUserMessageId.
Drive success cues from completed runs associated with a nearby user
message, and keep bloom on pending input/approval edges.
@t3dotggt3dotgg added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. and removed vouch:unvouched PR author is not yet trusted in the VOUCHED list. labels Aug 24, 2026
@jakeleventhal
jakeleventhalforce-pushed the t3code/add-turn-status-sounds branch from 39c55e7 to d29f5ddCompareAugust 26, 2026 02:36
Comment threadpackages/client-runtime/src/interactionSounds.ts

@macroscopeappmacroscopeappBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the web-side changes for UI consistency. The new General → Completion sound row follows the existing SettingsRow + Switch + searchableSetting + SettingResetButton contract exactly, and the restore-defaults label/patch wiring is consistent, so no primitive, Tailwind, theme, or scroll findings there. Two consistency/robustness points on the new coordinator plumbing are noted inline.

Posted via Macroscope — UI Consistency

Comment threadapps/web/src/routes/__root.tsx
Comment threadapps/web/src/state/shell.ts Outdated
mwolson added a commit to mwolson/t3code that referenced this pull request Aug 29, 2026
CTM already deleted this main-era suite in the stranded-main port. The
pingdotgg#3892 interaction-sounds port only needed initiatingUserMessageId on the
live query path, which remains in ProjectionSnapshotQuery.ts.
mwolson added a commit to mwolson/t3code that referenced this pull request Aug 29, 2026
pingdotgg#3892 targets main's latestTurn shape. CTM EnvironmentThreadShell exposes
latestRun with runId/status timestamps and no initiatingUserMessageId.
Drive success cues from completed runs associated with a nearby user
message, and keep bloom on pending input/approval edges.
mwolson added a commit to mwolson/t3code that referenced this pull request Sep 1, 2026
CTM already deleted this main-era suite in the stranded-main port. The
pingdotgg#3892 interaction-sounds port only needed initiatingUserMessageId on the
live query path, which remains in ProjectionSnapshotQuery.ts.
mwolson added a commit to mwolson/t3code that referenced this pull request Sep 1, 2026
pingdotgg#3892 targets main's latestTurn shape. CTM EnvironmentThreadShell exposes
latestRun with runId/status timestamps and no initiatingUserMessageId.
Drive success cues from completed runs associated with a nearby user
message, and keep bloom on pending input/approval edges.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XL500-999 changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@jakeleventhal@t3dotgg
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Add sounds for completed turns and user input requests - #3892

Open
jakeleventhal wants to merge 12 commits into
pingdotgg:mainfrom
jakeleventhal:t3code/add-turn-status-sounds
Open

Add sounds for completed turns and user input requests#3892
jakeleventhal wants to merge 12 commits into
pingdotgg:mainfrom
jakeleventhal:t3code/add-turn-status-sounds

Conversation

@jakeleventhal

@jakeleventhaljakeleventhal commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

Summary

Screen.Recording.2026-07-11.at.6.57.13.PM.mov
  • add Cuelume's synthesized success cue when a turn completes
  • add the bloom cue when a thread begins requesting user input
  • listen to global thread-shell transitions so background threads are covered
  • suppress sounds during initial thread hydration and avoid replaying unchanged states

User impact

Users receive an audible signal when agent work finishes or pauses for input, including when the affected thread is not currently open.

Validation

  • vp test apps/web/src/interactionSounds.test.ts
  • vp check
  • vp run typecheck

Note

Medium Risk
Touches orchestration projection queries and latest-turn contract shape; incorrect turn association or hydration gating could cause missed or spurious audio, but behavior is heavily unit-tested.

Overview
Adds interaction sounds across web (via cuelume) and mobile (via expo-audio + generated WAV assets): a success cue when a user-initiated turn completes and a bloom cue when a thread newly needs input or approval. Per-thread coordinators in the app shell watch all thread shells (including background threads) and use shared logic in @t3tools/client-runtime/interaction-sounds to derive cues while skipping initial hydration, cached startup, and unchanged state; liveEnvironmentIdsAtom gates when environments are treated as live.

Introduces enableCompletionSounds (default on) in client settings with UI on web/desktop General settings and completionSoundEnabled on mobile (device-local preferences). Disabling completion sounds leaves input-required bloom cues on.

Server/API: OrchestrationLatestTurn.initiatingUserMessageId (from projection_turns.pending_message_id) so clients can distinguish user-started turns from background work, with a legacy time-window fallback when the field is absent.

Reviewed by Cursor Bugbot for commit 4afad56. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Add interaction sounds for completed turns and user input requests

  • Adds platform-agnostic logic in interactionSounds.ts to derive success and bloom sound cues from thread state transitions.
  • Implements InteractionSoundCoordinator components for web (via cuelume) and mobile (via expo-audio) to play cues globally.
  • Adds an enableCompletionSounds setting to client settings, persistence, and settings UIs across platforms.
  • Updates ProjectionSnapshotQuery to select turns.pending_message_id and map it to OrchestrationLatestTurn.initiatingUserMessageId for sound association.
  • Risk: The OrchestrationLatestTurn schema change adds an optional initiatingUserMessageId field; out-of-tree contract consumers must handle the new field.

Macroscope summarized 4afad56.

@coderabbitai

coderabbitaiBot commented Jul 11, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 61a9b950-c1a1-46c8-b029-7cf67a7b7de6

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actionsgithub-actionsBot added size:M 30-99 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list. labels Jul 11, 2026
@jakeleventhal
jakeleventhal marked this pull request as ready for review July 11, 2026 18:06
@macroscopeapp

macroscopeappBot commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This change adds a cross-platform audible notification system that runs globally across thread state, introduces platform-specific audio integrations/assets, and extends server/client projection data and settings. Its impact is broader than a small isolated toggle or additive field, so the runtime behavior and multi-platform integration merit human review.

You can add or adjust custom eligibility rules. Learn more.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@github-actionsgithub-actionsBot added size:L 100-499 changed lines (additions + deletions). and removed size:M 30-99 changed lines (additions + deletions). labels Jul 11, 2026
Comment threadapps/web/src/routes/__root.tsx Outdated
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

Comment threadapps/web/src/interactionSounds.ts Outdated
Comment threadpackages/client-runtime/src/interactionSounds.ts Outdated

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:9626d0808d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadapps/web/src/routes/__root.tsx Outdated

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:ac5b546dc8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadapps/web/src/interactionSounds.ts Outdated

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:61cef120a4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadapps/web/src/routes/__root.tsx Outdated
Comment threadapps/web/src/interactionSounds.ts Outdated

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:163b2edcbc

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadapps/web/src/interactionSounds.ts Outdated
Comment threadapps/web/src/routes/__root.tsx Outdated
@jakeleventhal
jakeleventhalforce-pushed the t3code/add-turn-status-sounds branch 2 times, most recently from 88fe364 to 37c74dbCompareJuly 29, 2026 16:58
Comment threadapps/web/src/state/shell.ts Outdated

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:37c74db3b1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadapps/web/src/components/settings/SettingsPanels.tsx
Comment threadapps/web/src/routes/__root.tsx
@jakeleventhal
jakeleventhalforce-pushed the t3code/add-turn-status-sounds branch from 37c74db to b4353cfCompareJuly 29, 2026 17:42
@github-actionsgithub-actionsBot added size:XL 500-999 changed lines (additions + deletions). and removed size:L 100-499 changed lines (additions + deletions). labels Jul 29, 2026
Comment threadpackages/client-runtime/src/interactionSounds.ts Outdated
Comment threadapps/web/src/routes/__root.tsx Outdated

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:b4353cf67b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadapps/web/src/routes/__root.tsx Outdated
Comment threadapps/web/src/state/shell.ts
Comment threaddocs/user/interaction-sounds.md Outdated

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:1b1cf11d7a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadpackages/client-runtime/src/interactionSounds.ts Outdated
mwolson added a commit to mwolson/t3code that referenced this pull request Aug 19, 2026
CTM already deleted this main-era suite in the stranded-main port. The
pingdotgg#3892 interaction-sounds port only needed initiatingUserMessageId on the
live query path, which remains in ProjectionSnapshotQuery.ts.
mwolson added a commit to mwolson/t3code that referenced this pull request Aug 19, 2026
pingdotgg#3892 targets main's latestTurn shape. CTM EnvironmentThreadShell exposes
latestRun with runId/status timestamps and no initiatingUserMessageId.
Drive success cues from completed runs associated with a nearby user
message, and keep bloom on pending input/approval edges.
@t3dotggt3dotgg added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. and removed vouch:unvouched PR author is not yet trusted in the VOUCHED list. labels Aug 24, 2026
@jakeleventhal
jakeleventhalforce-pushed the t3code/add-turn-status-sounds branch from 39c55e7 to d29f5ddCompareAugust 26, 2026 02:36
Comment threadpackages/client-runtime/src/interactionSounds.ts

@macroscopeappmacroscopeappBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the web-side changes for UI consistency. The new General → Completion sound row follows the existing SettingsRow + Switch + searchableSetting + SettingResetButton contract exactly, and the restore-defaults label/patch wiring is consistent, so no primitive, Tailwind, theme, or scroll findings there. Two consistency/robustness points on the new coordinator plumbing are noted inline.

Posted via Macroscope — UI Consistency

Comment threadapps/web/src/routes/__root.tsx
Comment threadapps/web/src/state/shell.ts Outdated
mwolson added a commit to mwolson/t3code that referenced this pull request Aug 29, 2026
CTM already deleted this main-era suite in the stranded-main port. The
pingdotgg#3892 interaction-sounds port only needed initiatingUserMessageId on the
live query path, which remains in ProjectionSnapshotQuery.ts.
mwolson added a commit to mwolson/t3code that referenced this pull request Aug 29, 2026
pingdotgg#3892 targets main's latestTurn shape. CTM EnvironmentThreadShell exposes
latestRun with runId/status timestamps and no initiatingUserMessageId.
Drive success cues from completed runs associated with a nearby user
message, and keep bloom on pending input/approval edges.
mwolson added a commit to mwolson/t3code that referenced this pull request Sep 1, 2026
CTM already deleted this main-era suite in the stranded-main port. The
pingdotgg#3892 interaction-sounds port only needed initiatingUserMessageId on the
live query path, which remains in ProjectionSnapshotQuery.ts.
mwolson added a commit to mwolson/t3code that referenced this pull request Sep 1, 2026
pingdotgg#3892 targets main's latestTurn shape. CTM EnvironmentThreadShell exposes
latestRun with runId/status timestamps and no initiatingUserMessageId.
Drive success cues from completed runs associated with a nearby user
message, and keep bloom on pending input/approval edges.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XL500-999 changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@jakeleventhal@t3dotgg
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Add sounds for completed turns and user input requests - #3892

Open
jakeleventhal wants to merge 12 commits into
pingdotgg:mainfrom
jakeleventhal:t3code/add-turn-status-sounds
Open

Add sounds for completed turns and user input requests#3892
jakeleventhal wants to merge 12 commits into
pingdotgg:mainfrom
jakeleventhal:t3code/add-turn-status-sounds

Conversation

@jakeleventhal

@jakeleventhaljakeleventhal commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

Summary

Screen.Recording.2026-07-11.at.6.57.13.PM.mov
  • add Cuelume's synthesized success cue when a turn completes
  • add the bloom cue when a thread begins requesting user input
  • listen to global thread-shell transitions so background threads are covered
  • suppress sounds during initial thread hydration and avoid replaying unchanged states

User impact

Users receive an audible signal when agent work finishes or pauses for input, including when the affected thread is not currently open.

Validation

  • vp test apps/web/src/interactionSounds.test.ts
  • vp check
  • vp run typecheck

Note

Medium Risk
Touches orchestration projection queries and latest-turn contract shape; incorrect turn association or hydration gating could cause missed or spurious audio, but behavior is heavily unit-tested.

Overview
Adds interaction sounds across web (via cuelume) and mobile (via expo-audio + generated WAV assets): a success cue when a user-initiated turn completes and a bloom cue when a thread newly needs input or approval. Per-thread coordinators in the app shell watch all thread shells (including background threads) and use shared logic in @t3tools/client-runtime/interaction-sounds to derive cues while skipping initial hydration, cached startup, and unchanged state; liveEnvironmentIdsAtom gates when environments are treated as live.

Introduces enableCompletionSounds (default on) in client settings with UI on web/desktop General settings and completionSoundEnabled on mobile (device-local preferences). Disabling completion sounds leaves input-required bloom cues on.

Server/API: OrchestrationLatestTurn.initiatingUserMessageId (from projection_turns.pending_message_id) so clients can distinguish user-started turns from background work, with a legacy time-window fallback when the field is absent.

Reviewed by Cursor Bugbot for commit 4afad56. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Add interaction sounds for completed turns and user input requests

  • Adds platform-agnostic logic in interactionSounds.ts to derive success and bloom sound cues from thread state transitions.
  • Implements InteractionSoundCoordinator components for web (via cuelume) and mobile (via expo-audio) to play cues globally.
  • Adds an enableCompletionSounds setting to client settings, persistence, and settings UIs across platforms.
  • Updates ProjectionSnapshotQuery to select turns.pending_message_id and map it to OrchestrationLatestTurn.initiatingUserMessageId for sound association.
  • Risk: The OrchestrationLatestTurn schema change adds an optional initiatingUserMessageId field; out-of-tree contract consumers must handle the new field.

Macroscope summarized 4afad56.

@coderabbitai

coderabbitaiBot commented Jul 11, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 61a9b950-c1a1-46c8-b029-7cf67a7b7de6

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actionsgithub-actionsBot added size:M 30-99 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list. labels Jul 11, 2026
@jakeleventhal
jakeleventhal marked this pull request as ready for review July 11, 2026 18:06
@macroscopeapp

macroscopeappBot commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This change adds a cross-platform audible notification system that runs globally across thread state, introduces platform-specific audio integrations/assets, and extends server/client projection data and settings. Its impact is broader than a small isolated toggle or additive field, so the runtime behavior and multi-platform integration merit human review.

You can add or adjust custom eligibility rules. Learn more.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@github-actionsgithub-actionsBot added size:L 100-499 changed lines (additions + deletions). and removed size:M 30-99 changed lines (additions + deletions). labels Jul 11, 2026
Comment threadapps/web/src/routes/__root.tsx Outdated
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

Comment threadapps/web/src/interactionSounds.ts Outdated
Comment threadpackages/client-runtime/src/interactionSounds.ts Outdated

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:9626d0808d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadapps/web/src/routes/__root.tsx Outdated

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:ac5b546dc8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadapps/web/src/interactionSounds.ts Outdated

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:61cef120a4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadapps/web/src/routes/__root.tsx Outdated
Comment threadapps/web/src/interactionSounds.ts Outdated

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:163b2edcbc

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadapps/web/src/interactionSounds.ts Outdated
Comment threadapps/web/src/routes/__root.tsx Outdated
@jakeleventhal
jakeleventhalforce-pushed the t3code/add-turn-status-sounds branch 2 times, most recently from 88fe364 to 37c74dbCompareJuly 29, 2026 16:58
Comment threadapps/web/src/state/shell.ts Outdated

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:37c74db3b1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadapps/web/src/components/settings/SettingsPanels.tsx
Comment threadapps/web/src/routes/__root.tsx
@jakeleventhal
jakeleventhalforce-pushed the t3code/add-turn-status-sounds branch from 37c74db to b4353cfCompareJuly 29, 2026 17:42
@github-actionsgithub-actionsBot added size:XL 500-999 changed lines (additions + deletions). and removed size:L 100-499 changed lines (additions + deletions). labels Jul 29, 2026
Comment threadpackages/client-runtime/src/interactionSounds.ts Outdated
Comment threadapps/web/src/routes/__root.tsx Outdated

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:b4353cf67b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadapps/web/src/routes/__root.tsx Outdated
Comment threadapps/web/src/state/shell.ts
Comment threaddocs/user/interaction-sounds.md Outdated

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:1b1cf11d7a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadpackages/client-runtime/src/interactionSounds.ts Outdated
mwolson added a commit to mwolson/t3code that referenced this pull request Aug 19, 2026
CTM already deleted this main-era suite in the stranded-main port. The
pingdotgg#3892 interaction-sounds port only needed initiatingUserMessageId on the
live query path, which remains in ProjectionSnapshotQuery.ts.
mwolson added a commit to mwolson/t3code that referenced this pull request Aug 19, 2026
pingdotgg#3892 targets main's latestTurn shape. CTM EnvironmentThreadShell exposes
latestRun with runId/status timestamps and no initiatingUserMessageId.
Drive success cues from completed runs associated with a nearby user
message, and keep bloom on pending input/approval edges.
@t3dotggt3dotgg added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. and removed vouch:unvouched PR author is not yet trusted in the VOUCHED list. labels Aug 24, 2026
@jakeleventhal
jakeleventhalforce-pushed the t3code/add-turn-status-sounds branch from 39c55e7 to d29f5ddCompareAugust 26, 2026 02:36
Comment threadpackages/client-runtime/src/interactionSounds.ts

@macroscopeappmacroscopeappBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the web-side changes for UI consistency. The new General → Completion sound row follows the existing SettingsRow + Switch + searchableSetting + SettingResetButton contract exactly, and the restore-defaults label/patch wiring is consistent, so no primitive, Tailwind, theme, or scroll findings there. Two consistency/robustness points on the new coordinator plumbing are noted inline.

Posted via Macroscope — UI Consistency

Comment threadapps/web/src/routes/__root.tsx
Comment threadapps/web/src/state/shell.ts Outdated
mwolson added a commit to mwolson/t3code that referenced this pull request Aug 29, 2026
CTM already deleted this main-era suite in the stranded-main port. The
pingdotgg#3892 interaction-sounds port only needed initiatingUserMessageId on the
live query path, which remains in ProjectionSnapshotQuery.ts.
mwolson added a commit to mwolson/t3code that referenced this pull request Aug 29, 2026
pingdotgg#3892 targets main's latestTurn shape. CTM EnvironmentThreadShell exposes
latestRun with runId/status timestamps and no initiatingUserMessageId.
Drive success cues from completed runs associated with a nearby user
message, and keep bloom on pending input/approval edges.
mwolson added a commit to mwolson/t3code that referenced this pull request Sep 1, 2026
CTM already deleted this main-era suite in the stranded-main port. The
pingdotgg#3892 interaction-sounds port only needed initiatingUserMessageId on the
live query path, which remains in ProjectionSnapshotQuery.ts.
mwolson added a commit to mwolson/t3code that referenced this pull request Sep 1, 2026
pingdotgg#3892 targets main's latestTurn shape. CTM EnvironmentThreadShell exposes
latestRun with runId/status timestamps and no initiatingUserMessageId.
Drive success cues from completed runs associated with a nearby user
message, and keep bloom on pending input/approval edges.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XL500-999 changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@jakeleventhal@t3dotgg
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

Add sounds for completed turns and user input requests - #3892

Open
jakeleventhal wants to merge 12 commits into
pingdotgg:mainfrom
jakeleventhal:t3code/add-turn-status-sounds
Open

Add sounds for completed turns and user input requests#3892
jakeleventhal wants to merge 12 commits into
pingdotgg:mainfrom
jakeleventhal:t3code/add-turn-status-sounds

Conversation

@jakeleventhal

@jakeleventhaljakeleventhal commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

Summary

Screen.Recording.2026-07-11.at.6.57.13.PM.mov
  • add Cuelume's synthesized success cue when a turn completes
  • add the bloom cue when a thread begins requesting user input
  • listen to global thread-shell transitions so background threads are covered
  • suppress sounds during initial thread hydration and avoid replaying unchanged states

User impact

Users receive an audible signal when agent work finishes or pauses for input, including when the affected thread is not currently open.

Validation

  • vp test apps/web/src/interactionSounds.test.ts
  • vp check
  • vp run typecheck

Note

Medium Risk
Touches orchestration projection queries and latest-turn contract shape; incorrect turn association or hydration gating could cause missed or spurious audio, but behavior is heavily unit-tested.

Overview
Adds interaction sounds across web (via cuelume) and mobile (via expo-audio + generated WAV assets): a success cue when a user-initiated turn completes and a bloom cue when a thread newly needs input or approval. Per-thread coordinators in the app shell watch all thread shells (including background threads) and use shared logic in @t3tools/client-runtime/interaction-sounds to derive cues while skipping initial hydration, cached startup, and unchanged state; liveEnvironmentIdsAtom gates when environments are treated as live.

Introduces enableCompletionSounds (default on) in client settings with UI on web/desktop General settings and completionSoundEnabled on mobile (device-local preferences). Disabling completion sounds leaves input-required bloom cues on.

Server/API: OrchestrationLatestTurn.initiatingUserMessageId (from projection_turns.pending_message_id) so clients can distinguish user-started turns from background work, with a legacy time-window fallback when the field is absent.

Reviewed by Cursor Bugbot for commit 4afad56. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Add interaction sounds for completed turns and user input requests

  • Adds platform-agnostic logic in interactionSounds.ts to derive success and bloom sound cues from thread state transitions.
  • Implements InteractionSoundCoordinator components for web (via cuelume) and mobile (via expo-audio) to play cues globally.
  • Adds an enableCompletionSounds setting to client settings, persistence, and settings UIs across platforms.
  • Updates ProjectionSnapshotQuery to select turns.pending_message_id and map it to OrchestrationLatestTurn.initiatingUserMessageId for sound association.
  • Risk: The OrchestrationLatestTurn schema change adds an optional initiatingUserMessageId field; out-of-tree contract consumers must handle the new field.

Macroscope summarized 4afad56.

@coderabbitai

coderabbitaiBot commented Jul 11, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 61a9b950-c1a1-46c8-b029-7cf67a7b7de6

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actionsgithub-actionsBot added size:M 30-99 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list. labels Jul 11, 2026
@jakeleventhal
jakeleventhal marked this pull request as ready for review July 11, 2026 18:06
@macroscopeapp

macroscopeappBot commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This change adds a cross-platform audible notification system that runs globally across thread state, introduces platform-specific audio integrations/assets, and extends server/client projection data and settings. Its impact is broader than a small isolated toggle or additive field, so the runtime behavior and multi-platform integration merit human review.

You can add or adjust custom eligibility rules. Learn more.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@github-actionsgithub-actionsBot added size:L 100-499 changed lines (additions + deletions). and removed size:M 30-99 changed lines (additions + deletions). labels Jul 11, 2026
Comment threadapps/web/src/routes/__root.tsx Outdated
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

Comment threadapps/web/src/interactionSounds.ts Outdated
Comment threadpackages/client-runtime/src/interactionSounds.ts Outdated

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:9626d0808d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadapps/web/src/routes/__root.tsx Outdated

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:ac5b546dc8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadapps/web/src/interactionSounds.ts Outdated

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:61cef120a4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadapps/web/src/routes/__root.tsx Outdated
Comment threadapps/web/src/interactionSounds.ts Outdated

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:163b2edcbc

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadapps/web/src/interactionSounds.ts Outdated
Comment threadapps/web/src/routes/__root.tsx Outdated
@jakeleventhal
jakeleventhalforce-pushed the t3code/add-turn-status-sounds branch 2 times, most recently from 88fe364 to 37c74dbCompareJuly 29, 2026 16:58
Comment threadapps/web/src/state/shell.ts Outdated

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:37c74db3b1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadapps/web/src/components/settings/SettingsPanels.tsx
Comment threadapps/web/src/routes/__root.tsx
@jakeleventhal
jakeleventhalforce-pushed the t3code/add-turn-status-sounds branch from 37c74db to b4353cfCompareJuly 29, 2026 17:42
@github-actionsgithub-actionsBot added size:XL 500-999 changed lines (additions + deletions). and removed size:L 100-499 changed lines (additions + deletions). labels Jul 29, 2026
Comment threadpackages/client-runtime/src/interactionSounds.ts Outdated
Comment threadapps/web/src/routes/__root.tsx Outdated

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:b4353cf67b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadapps/web/src/routes/__root.tsx Outdated
Comment threadapps/web/src/state/shell.ts
Comment threaddocs/user/interaction-sounds.md Outdated

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:1b1cf11d7a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadpackages/client-runtime/src/interactionSounds.ts Outdated
mwolson added a commit to mwolson/t3code that referenced this pull request Aug 19, 2026
CTM already deleted this main-era suite in the stranded-main port. The
pingdotgg#3892 interaction-sounds port only needed initiatingUserMessageId on the
live query path, which remains in ProjectionSnapshotQuery.ts.
mwolson added a commit to mwolson/t3code that referenced this pull request Aug 19, 2026
pingdotgg#3892 targets main's latestTurn shape. CTM EnvironmentThreadShell exposes
latestRun with runId/status timestamps and no initiatingUserMessageId.
Drive success cues from completed runs associated with a nearby user
message, and keep bloom on pending input/approval edges.
@t3dotggt3dotgg added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. and removed vouch:unvouched PR author is not yet trusted in the VOUCHED list. labels Aug 24, 2026
@jakeleventhal
jakeleventhalforce-pushed the t3code/add-turn-status-sounds branch from 39c55e7 to d29f5ddCompareAugust 26, 2026 02:36
Comment threadpackages/client-runtime/src/interactionSounds.ts

@macroscopeappmacroscopeappBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the web-side changes for UI consistency. The new General → Completion sound row follows the existing SettingsRow + Switch + searchableSetting + SettingResetButton contract exactly, and the restore-defaults label/patch wiring is consistent, so no primitive, Tailwind, theme, or scroll findings there. Two consistency/robustness points on the new coordinator plumbing are noted inline.

Posted via Macroscope — UI Consistency

Comment threadapps/web/src/routes/__root.tsx
Comment threadapps/web/src/state/shell.ts Outdated
mwolson added a commit to mwolson/t3code that referenced this pull request Aug 29, 2026
CTM already deleted this main-era suite in the stranded-main port. The
pingdotgg#3892 interaction-sounds port only needed initiatingUserMessageId on the
live query path, which remains in ProjectionSnapshotQuery.ts.
mwolson added a commit to mwolson/t3code that referenced this pull request Aug 29, 2026
pingdotgg#3892 targets main's latestTurn shape. CTM EnvironmentThreadShell exposes
latestRun with runId/status timestamps and no initiatingUserMessageId.
Drive success cues from completed runs associated with a nearby user
message, and keep bloom on pending input/approval edges.
mwolson added a commit to mwolson/t3code that referenced this pull request Sep 1, 2026
CTM already deleted this main-era suite in the stranded-main port. The
pingdotgg#3892 interaction-sounds port only needed initiatingUserMessageId on the
live query path, which remains in ProjectionSnapshotQuery.ts.
mwolson added a commit to mwolson/t3code that referenced this pull request Sep 1, 2026
pingdotgg#3892 targets main's latestTurn shape. CTM EnvironmentThreadShell exposes
latestRun with runId/status timestamps and no initiatingUserMessageId.
Drive success cues from completed runs associated with a nearby user
message, and keep bloom on pending input/approval edges.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XL500-999 changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@jakeleventhal@t3dotgg