[orchestrator-v2] fix(orchestrator): Codex background command completion and subagent resume

[mwolson]

What Changed

• Preserve Codex turn context long enough to project command completions that
  arrive after the root turn settles.
• Request one continuation run for each newly completed post-settle background
  command, while avoiding wakes for commands completed during the root turn.
• Reopen and hydrate resumed Codex subagents, and keep sessions resident while
  tracked background commands or subagents are still active.
• Add replay coverage for post-settle command completion, continuation
  deduplication, subagent resume, and pending-background state.

Why

Codex app-server can continue emitting command and subagent lifecycle events
after turn/completed. The adapter removed the owning turn from activeTurns
at settlement, so a later item/completed could not resolve its projection
context. The command card remained running, its final output was lost, and the
root agent was not notified. Resuming a completed subagent had a similar stale
projection problem because its new lifecycle was not reopened before the next
child turn.

Problem and Fix

Problem and Why it Happened	Fix
Post-settle command completion could not resolve an active turn, leaving the item running and dropping final output.	Retain settled turn context while tracked background items remain, then project the late completion and release the context when drained.
A completed background command did not wake the root agent.	Offer a continuation through the shared continuation queue once per completed post-settle command.
Resuming a completed subagent left its prior result and terminal state in the projection.	Reopen the subagent lifecycle on the resumed child turn and apply its later result and terminal state.
Idle release could stop a Codex session with provider work still active.	Report pending tracked commands and subagents through hasPendingBackgroundWork.

Validation

• vp check: pass with zero errors
• vp run typecheck: pass across all 15 packages
• vp test run apps/server/src/orchestration-v2/Adapters/CodexAdapterV2.test.ts apps/server/src/orchestration-v2/RunExecutionService.test.ts: 30 tests pass
• Headless Codex smoke and continuation packs: all pass, including strengthened
  assertions that command and subagent turn items reach completed
• AppImage manual matrix: prompts 1 through 8 pass, including two-command wake
  ordering, mixed command and subagent activity, subagent resume, and the
  in-turn no-wake case

Checklist

• This PR is small and focused
• I explained what changed and why

---

Note

Medium Risk
Changes Codex turn lifecycle, continuation scheduling, and session pinning in orchestration-v2; behavior is well covered by new replay tests but incorrect continuation or release logic could affect run completion or duplicate wakes.

Overview
Fixes Codex adapter handling when app-server events arrive after turn/completed, which previously dropped late item/completed projections and left background commands stuck.

The adapter now keeps settled turn context while in-flight commandExecution items are tracked, resolves late completions via resolveItemEventContext, and offers one continuation per newly completed post-settle command through ProviderContinuationRequests (with deduplication and codexBackgroundCommandDetail for the wake message). Commands that finish before settle do not trigger continuations; failed/interrupted turns stop tracking so late completions cannot wake stopped work.

Subagent projection is broadened: resumed child turns re-emit running state, terminal node/task updates apply beyond the first turn, and agent messages update subagent results without the old first-turn-only guard. hasPendingBackgroundWork reports active background commands or running subagents so idle release does not tear down sessions too early.

Adds replay tests for post-settle command wake, pre-settle no-wake, and resumed subagent hydration; exports makeReplayServerConfig from the testkit for harness reuse.

^{Reviewed by Cursor Bugbot for commit f6f10b4. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Fix Codex background command completion and subagent resume in orchestrator adapter

• Adds post-settle background command tracking in CodexAdapterV2: settled turn contexts are retained until all running background commands complete, allowing late item.completed events to be projected correctly.
• Offers a ProviderContinuationRequest when a root turn's background command completes after turn settle, using a new codexBackgroundCommandDetail helper that formats command text, exit code, and output tail (capped at 1,000 chars).
• Emits subagent.updated to running when a subsequent provider turn starts for a subagent task that wasn't already running, and emits status updates consistently on subagent completion.
• Exposes hasPendingBackgroundWork on the adapter runtime, returning true while any command items or subagents are still running.
• Adds integration tests covering post-settle completion, pre-settle no-continuation, and subagent resume with hydration of late results.

^{Macroscope summarized f6f10b4.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: edad5d2a-bb88-4b58-ab37-8c0ff70d5635

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[macroscopeapp]

Approvability

Verdict: Needs human review

This PR adds new runtime behavior for tracking background commands past turn settlement and triggering continuation requests when they complete. While well-tested, the changes affect orchestration flow decisions and should be reviewed by someone familiar with the CodexAdapter's event processing model.

^{You can customize Macroscope's approvability policy. Learn more.}

[mwolson]

What Changed

• Preserve Codex turn context long enough to project command completions that
  arrive after the root turn settles.
• Request one continuation run for each newly completed post-settle background
  command, while avoiding wakes for commands completed during the root turn.
• Reopen and hydrate resumed Codex subagents, and keep sessions resident while
  tracked background commands or subagents are still active.
• Add replay coverage for post-settle command completion, continuation
  deduplication, subagent resume, and pending-background state.

Why

Codex app-server can continue emitting command and subagent lifecycle events
after turn/completed. The adapter removed the owning turn from activeTurns
at settlement, so a later item/completed could not resolve its projection
context. The command card remained running, its final output was lost, and the
root agent was not notified. Resuming a completed subagent had a similar stale
projection problem because its new lifecycle was not reopened before the next
child turn.

Problem and Fix

Problem and Why it Happened	Fix
Post-settle command completion could not resolve an active turn, leaving the item running and dropping final output.	Retain settled turn context while tracked background items remain, then project the late completion and release the context when drained.
A completed background command did not wake the root agent.	Offer a continuation through the shared continuation queue once per completed post-settle command.
Resuming a completed subagent left its prior result and terminal state in the projection.	Reopen the subagent lifecycle on the resumed child turn and apply its later result and terminal state.
Idle release could stop a Codex session with provider work still active.	Report pending tracked commands and subagents through hasPendingBackgroundWork.

Validation

• vp check: pass with zero errors
• vp run typecheck: pass across all 15 packages
• vp test run apps/server/src/orchestration-v2/Adapters/CodexAdapterV2.test.ts apps/server/src/orchestration-v2/RunExecutionService.test.ts: 30 tests pass
• Headless Codex smoke and continuation packs: all pass, including strengthened
  assertions that command and subagent turn items reach completed
• AppImage manual matrix: prompts 1 through 8 pass, including two-command wake
  ordering, mixed command and subagent activity, subagent resume, and the
  in-turn no-wake case

Checklist

• This PR is small and focused
• I explained what changed and why

---

Note

Medium Risk
Changes Codex turn lifecycle, continuation scheduling, and session pinning in orchestration-v2; behavior is well covered by new replay tests but incorrect continuation or release logic could affect run completion or duplicate wakes.

Overview
Fixes Codex adapter handling when app-server events arrive after turn/completed, which previously dropped late item/completed projections and left background commands stuck.

The adapter now keeps settled turn context while in-flight commandExecution items are tracked, resolves late completions via resolveItemEventContext, and offers one continuation per newly completed post-settle command through ProviderContinuationRequests (with deduplication and codexBackgroundCommandDetail for the wake message). Commands that finish before settle do not trigger continuations; failed/interrupted turns stop tracking so late completions cannot wake stopped work.

Subagent projection is broadened: resumed child turns re-emit running state, terminal node/task updates apply beyond the first turn, and agent messages update subagent results without the old first-turn-only guard. hasPendingBackgroundWork reports active background commands or running subagents so idle release does not tear down sessions too early.

Adds replay tests for post-settle command wake, pre-settle no-wake, and resumed subagent hydration; exports makeReplayServerConfig from the testkit for harness reuse.

^{Reviewed by Cursor Bugbot for commit f6f10b4. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Fix Codex background command completion and subagent resume in orchestrator adapter

• Adds post-settle background command tracking in CodexAdapterV2: settled turn contexts are retained until all running background commands complete, allowing late item.completed events to be projected correctly.
• Offers a ProviderContinuationRequest when a root turn's background command completes after turn settle, using a new codexBackgroundCommandDetail helper that formats command text, exit code, and output tail (capped at 1,000 chars).
• Emits subagent.updated to running when a subsequent provider turn starts for a subagent task that wasn't already running, and emits status updates consistently on subagent completion.
• Exposes hasPendingBackgroundWork on the adapter runtime, returning true while any command items or subagents are still running.
• Adds integration tests covering post-settle completion, pre-settle no-continuation, and subagent resume with hydration of late results.

^{Macroscope summarized f6f10b4.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: edad5d2a-bb88-4b58-ab37-8c0ff70d5635

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[macroscopeapp]

Approvability

Verdict: Needs human review

This PR adds new runtime behavior for tracking background commands past turn settlement and triggering continuation requests when they complete. While well-tested, the changes affect orchestration flow decisions and should be reviewed by someone familiar with the CodexAdapter's event processing model.

^{You can customize Macroscope's approvability policy. Learn more.}

[mwolson]

What Changed

• Preserve Codex turn context long enough to project command completions that
  arrive after the root turn settles.
• Request one continuation run for each newly completed post-settle background
  command, while avoiding wakes for commands completed during the root turn.
• Reopen and hydrate resumed Codex subagents, and keep sessions resident while
  tracked background commands or subagents are still active.
• Add replay coverage for post-settle command completion, continuation
  deduplication, subagent resume, and pending-background state.

Why

Codex app-server can continue emitting command and subagent lifecycle events
after turn/completed. The adapter removed the owning turn from activeTurns
at settlement, so a later item/completed could not resolve its projection
context. The command card remained running, its final output was lost, and the
root agent was not notified. Resuming a completed subagent had a similar stale
projection problem because its new lifecycle was not reopened before the next
child turn.

Problem and Fix

Problem and Why it Happened	Fix
Post-settle command completion could not resolve an active turn, leaving the item running and dropping final output.	Retain settled turn context while tracked background items remain, then project the late completion and release the context when drained.
A completed background command did not wake the root agent.	Offer a continuation through the shared continuation queue once per completed post-settle command.
Resuming a completed subagent left its prior result and terminal state in the projection.	Reopen the subagent lifecycle on the resumed child turn and apply its later result and terminal state.
Idle release could stop a Codex session with provider work still active.	Report pending tracked commands and subagents through hasPendingBackgroundWork.

Validation

• vp check: pass with zero errors
• vp run typecheck: pass across all 15 packages
• vp test run apps/server/src/orchestration-v2/Adapters/CodexAdapterV2.test.ts apps/server/src/orchestration-v2/RunExecutionService.test.ts: 30 tests pass
• Headless Codex smoke and continuation packs: all pass, including strengthened
  assertions that command and subagent turn items reach completed
• AppImage manual matrix: prompts 1 through 8 pass, including two-command wake
  ordering, mixed command and subagent activity, subagent resume, and the
  in-turn no-wake case

Checklist

• This PR is small and focused
• I explained what changed and why

---

Note

Medium Risk
Changes Codex turn lifecycle, continuation scheduling, and session pinning in orchestration-v2; behavior is well covered by new replay tests but incorrect continuation or release logic could affect run completion or duplicate wakes.

Overview
Fixes Codex adapter handling when app-server events arrive after turn/completed, which previously dropped late item/completed projections and left background commands stuck.

The adapter now keeps settled turn context while in-flight commandExecution items are tracked, resolves late completions via resolveItemEventContext, and offers one continuation per newly completed post-settle command through ProviderContinuationRequests (with deduplication and codexBackgroundCommandDetail for the wake message). Commands that finish before settle do not trigger continuations; failed/interrupted turns stop tracking so late completions cannot wake stopped work.

Subagent projection is broadened: resumed child turns re-emit running state, terminal node/task updates apply beyond the first turn, and agent messages update subagent results without the old first-turn-only guard. hasPendingBackgroundWork reports active background commands or running subagents so idle release does not tear down sessions too early.

Adds replay tests for post-settle command wake, pre-settle no-wake, and resumed subagent hydration; exports makeReplayServerConfig from the testkit for harness reuse.

^{Reviewed by Cursor Bugbot for commit f6f10b4. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Fix Codex background command completion and subagent resume in orchestrator adapter

• Adds post-settle background command tracking in CodexAdapterV2: settled turn contexts are retained until all running background commands complete, allowing late item.completed events to be projected correctly.
• Offers a ProviderContinuationRequest when a root turn's background command completes after turn settle, using a new codexBackgroundCommandDetail helper that formats command text, exit code, and output tail (capped at 1,000 chars).
• Emits subagent.updated to running when a subsequent provider turn starts for a subagent task that wasn't already running, and emits status updates consistently on subagent completion.
• Exposes hasPendingBackgroundWork on the adapter runtime, returning true while any command items or subagents are still running.
• Adds integration tests covering post-settle completion, pre-settle no-continuation, and subagent resume with hydration of late results.

^{Macroscope summarized f6f10b4.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: edad5d2a-bb88-4b58-ab37-8c0ff70d5635

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[macroscopeapp]

Approvability

Verdict: Needs human review

This PR adds new runtime behavior for tracking background commands past turn settlement and triggering continuation requests when they complete. While well-tested, the changes affect orchestration flow decisions and should be reviewed by someone familiar with the CodexAdapter's event processing model.

^{You can customize Macroscope's approvability policy. Learn more.}

[mwolson]

What Changed

• Preserve Codex turn context long enough to project command completions that
  arrive after the root turn settles.
• Request one continuation run for each newly completed post-settle background
  command, while avoiding wakes for commands completed during the root turn.
• Reopen and hydrate resumed Codex subagents, and keep sessions resident while
  tracked background commands or subagents are still active.
• Add replay coverage for post-settle command completion, continuation
  deduplication, subagent resume, and pending-background state.

Why

Codex app-server can continue emitting command and subagent lifecycle events
after turn/completed. The adapter removed the owning turn from activeTurns
at settlement, so a later item/completed could not resolve its projection
context. The command card remained running, its final output was lost, and the
root agent was not notified. Resuming a completed subagent had a similar stale
projection problem because its new lifecycle was not reopened before the next
child turn.

Problem and Fix

Problem and Why it Happened	Fix
Post-settle command completion could not resolve an active turn, leaving the item running and dropping final output.	Retain settled turn context while tracked background items remain, then project the late completion and release the context when drained.
A completed background command did not wake the root agent.	Offer a continuation through the shared continuation queue once per completed post-settle command.
Resuming a completed subagent left its prior result and terminal state in the projection.	Reopen the subagent lifecycle on the resumed child turn and apply its later result and terminal state.
Idle release could stop a Codex session with provider work still active.	Report pending tracked commands and subagents through hasPendingBackgroundWork.

Validation

• vp check: pass with zero errors
• vp run typecheck: pass across all 15 packages
• vp test run apps/server/src/orchestration-v2/Adapters/CodexAdapterV2.test.ts apps/server/src/orchestration-v2/RunExecutionService.test.ts: 30 tests pass
• Headless Codex smoke and continuation packs: all pass, including strengthened
  assertions that command and subagent turn items reach completed
• AppImage manual matrix: prompts 1 through 8 pass, including two-command wake
  ordering, mixed command and subagent activity, subagent resume, and the
  in-turn no-wake case

Checklist

• This PR is small and focused
• I explained what changed and why

---

Note

Medium Risk
Changes Codex turn lifecycle, continuation scheduling, and session pinning in orchestration-v2; behavior is well covered by new replay tests but incorrect continuation or release logic could affect run completion or duplicate wakes.

Overview
Fixes Codex adapter handling when app-server events arrive after turn/completed, which previously dropped late item/completed projections and left background commands stuck.

The adapter now keeps settled turn context while in-flight commandExecution items are tracked, resolves late completions via resolveItemEventContext, and offers one continuation per newly completed post-settle command through ProviderContinuationRequests (with deduplication and codexBackgroundCommandDetail for the wake message). Commands that finish before settle do not trigger continuations; failed/interrupted turns stop tracking so late completions cannot wake stopped work.

Subagent projection is broadened: resumed child turns re-emit running state, terminal node/task updates apply beyond the first turn, and agent messages update subagent results without the old first-turn-only guard. hasPendingBackgroundWork reports active background commands or running subagents so idle release does not tear down sessions too early.

Adds replay tests for post-settle command wake, pre-settle no-wake, and resumed subagent hydration; exports makeReplayServerConfig from the testkit for harness reuse.

^{Reviewed by Cursor Bugbot for commit f6f10b4. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Fix Codex background command completion and subagent resume in orchestrator adapter

• Adds post-settle background command tracking in CodexAdapterV2: settled turn contexts are retained until all running background commands complete, allowing late item.completed events to be projected correctly.
• Offers a ProviderContinuationRequest when a root turn's background command completes after turn settle, using a new codexBackgroundCommandDetail helper that formats command text, exit code, and output tail (capped at 1,000 chars).
• Emits subagent.updated to running when a subsequent provider turn starts for a subagent task that wasn't already running, and emits status updates consistently on subagent completion.
• Exposes hasPendingBackgroundWork on the adapter runtime, returning true while any command items or subagents are still running.
• Adds integration tests covering post-settle completion, pre-settle no-continuation, and subagent resume with hydration of late results.

^{Macroscope summarized f6f10b4.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: edad5d2a-bb88-4b58-ab37-8c0ff70d5635

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[macroscopeapp]

Approvability

Verdict: Needs human review

This PR adds new runtime behavior for tracking background commands past turn settlement and triggering continuation requests when they complete. While well-tested, the changes affect orchestration flow decisions and should be reviewed by someone familiar with the CodexAdapter's event processing model.

^{You can customize Macroscope's approvability policy. Learn more.}

[mwolson]

What Changed

• Preserve Codex turn context long enough to project command completions that
  arrive after the root turn settles.
• Request one continuation run for each newly completed post-settle background
  command, while avoiding wakes for commands completed during the root turn.
• Reopen and hydrate resumed Codex subagents, and keep sessions resident while
  tracked background commands or subagents are still active.
• Add replay coverage for post-settle command completion, continuation
  deduplication, subagent resume, and pending-background state.

Why

Codex app-server can continue emitting command and subagent lifecycle events
after turn/completed. The adapter removed the owning turn from activeTurns
at settlement, so a later item/completed could not resolve its projection
context. The command card remained running, its final output was lost, and the
root agent was not notified. Resuming a completed subagent had a similar stale
projection problem because its new lifecycle was not reopened before the next
child turn.

Problem and Fix

Problem and Why it Happened	Fix
Post-settle command completion could not resolve an active turn, leaving the item running and dropping final output.	Retain settled turn context while tracked background items remain, then project the late completion and release the context when drained.
A completed background command did not wake the root agent.	Offer a continuation through the shared continuation queue once per completed post-settle command.
Resuming a completed subagent left its prior result and terminal state in the projection.	Reopen the subagent lifecycle on the resumed child turn and apply its later result and terminal state.
Idle release could stop a Codex session with provider work still active.	Report pending tracked commands and subagents through hasPendingBackgroundWork.

Validation

• vp check: pass with zero errors
• vp run typecheck: pass across all 15 packages
• vp test run apps/server/src/orchestration-v2/Adapters/CodexAdapterV2.test.ts apps/server/src/orchestration-v2/RunExecutionService.test.ts: 30 tests pass
• Headless Codex smoke and continuation packs: all pass, including strengthened
  assertions that command and subagent turn items reach completed
• AppImage manual matrix: prompts 1 through 8 pass, including two-command wake
  ordering, mixed command and subagent activity, subagent resume, and the
  in-turn no-wake case

Checklist

• This PR is small and focused
• I explained what changed and why

---

Note

Medium Risk
Changes Codex turn lifecycle, continuation scheduling, and session pinning in orchestration-v2; behavior is well covered by new replay tests but incorrect continuation or release logic could affect run completion or duplicate wakes.

Overview
Fixes Codex adapter handling when app-server events arrive after turn/completed, which previously dropped late item/completed projections and left background commands stuck.

The adapter now keeps settled turn context while in-flight commandExecution items are tracked, resolves late completions via resolveItemEventContext, and offers one continuation per newly completed post-settle command through ProviderContinuationRequests (with deduplication and codexBackgroundCommandDetail for the wake message). Commands that finish before settle do not trigger continuations; failed/interrupted turns stop tracking so late completions cannot wake stopped work.

Subagent projection is broadened: resumed child turns re-emit running state, terminal node/task updates apply beyond the first turn, and agent messages update subagent results without the old first-turn-only guard. hasPendingBackgroundWork reports active background commands or running subagents so idle release does not tear down sessions too early.

Adds replay tests for post-settle command wake, pre-settle no-wake, and resumed subagent hydration; exports makeReplayServerConfig from the testkit for harness reuse.

^{Reviewed by Cursor Bugbot for commit f6f10b4. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Fix Codex background command completion and subagent resume in orchestrator adapter

• Adds post-settle background command tracking in CodexAdapterV2: settled turn contexts are retained until all running background commands complete, allowing late item.completed events to be projected correctly.
• Offers a ProviderContinuationRequest when a root turn's background command completes after turn settle, using a new codexBackgroundCommandDetail helper that formats command text, exit code, and output tail (capped at 1,000 chars).
• Emits subagent.updated to running when a subsequent provider turn starts for a subagent task that wasn't already running, and emits status updates consistently on subagent completion.
• Exposes hasPendingBackgroundWork on the adapter runtime, returning true while any command items or subagents are still running.
• Adds integration tests covering post-settle completion, pre-settle no-continuation, and subagent resume with hydration of late results.

^{Macroscope summarized f6f10b4.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: edad5d2a-bb88-4b58-ab37-8c0ff70d5635

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[macroscopeapp]

Approvability

Verdict: Needs human review

This PR adds new runtime behavior for tracking background commands past turn settlement and triggering continuation requests when they complete. While well-tested, the changes affect orchestration flow decisions and should be reviewed by someone familiar with the CodexAdapter's event processing model.

^{You can customize Macroscope's approvability policy. Learn more.}

[mwolson]

What Changed

• Preserve Codex turn context long enough to project command completions that
  arrive after the root turn settles.
• Request one continuation run for each newly completed post-settle background
  command, while avoiding wakes for commands completed during the root turn.
• Reopen and hydrate resumed Codex subagents, and keep sessions resident while
  tracked background commands or subagents are still active.
• Add replay coverage for post-settle command completion, continuation
  deduplication, subagent resume, and pending-background state.

Why

Codex app-server can continue emitting command and subagent lifecycle events
after turn/completed. The adapter removed the owning turn from activeTurns
at settlement, so a later item/completed could not resolve its projection
context. The command card remained running, its final output was lost, and the
root agent was not notified. Resuming a completed subagent had a similar stale
projection problem because its new lifecycle was not reopened before the next
child turn.

Problem and Fix

Problem and Why it Happened	Fix
Post-settle command completion could not resolve an active turn, leaving the item running and dropping final output.	Retain settled turn context while tracked background items remain, then project the late completion and release the context when drained.
A completed background command did not wake the root agent.	Offer a continuation through the shared continuation queue once per completed post-settle command.
Resuming a completed subagent left its prior result and terminal state in the projection.	Reopen the subagent lifecycle on the resumed child turn and apply its later result and terminal state.
Idle release could stop a Codex session with provider work still active.	Report pending tracked commands and subagents through hasPendingBackgroundWork.

Validation

• vp check: pass with zero errors
• vp run typecheck: pass across all 15 packages
• vp test run apps/server/src/orchestration-v2/Adapters/CodexAdapterV2.test.ts apps/server/src/orchestration-v2/RunExecutionService.test.ts: 30 tests pass
• Headless Codex smoke and continuation packs: all pass, including strengthened
  assertions that command and subagent turn items reach completed
• AppImage manual matrix: prompts 1 through 8 pass, including two-command wake
  ordering, mixed command and subagent activity, subagent resume, and the
  in-turn no-wake case

Checklist

• This PR is small and focused
• I explained what changed and why

---

Note

Medium Risk
Changes Codex turn lifecycle, continuation scheduling, and session pinning in orchestration-v2; behavior is well covered by new replay tests but incorrect continuation or release logic could affect run completion or duplicate wakes.

Overview
Fixes Codex adapter handling when app-server events arrive after turn/completed, which previously dropped late item/completed projections and left background commands stuck.

The adapter now keeps settled turn context while in-flight commandExecution items are tracked, resolves late completions via resolveItemEventContext, and offers one continuation per newly completed post-settle command through ProviderContinuationRequests (with deduplication and codexBackgroundCommandDetail for the wake message). Commands that finish before settle do not trigger continuations; failed/interrupted turns stop tracking so late completions cannot wake stopped work.

Subagent projection is broadened: resumed child turns re-emit running state, terminal node/task updates apply beyond the first turn, and agent messages update subagent results without the old first-turn-only guard. hasPendingBackgroundWork reports active background commands or running subagents so idle release does not tear down sessions too early.

Adds replay tests for post-settle command wake, pre-settle no-wake, and resumed subagent hydration; exports makeReplayServerConfig from the testkit for harness reuse.

^{Reviewed by Cursor Bugbot for commit f6f10b4. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Fix Codex background command completion and subagent resume in orchestrator adapter

• Adds post-settle background command tracking in CodexAdapterV2: settled turn contexts are retained until all running background commands complete, allowing late item.completed events to be projected correctly.
• Offers a ProviderContinuationRequest when a root turn's background command completes after turn settle, using a new codexBackgroundCommandDetail helper that formats command text, exit code, and output tail (capped at 1,000 chars).
• Emits subagent.updated to running when a subsequent provider turn starts for a subagent task that wasn't already running, and emits status updates consistently on subagent completion.
• Exposes hasPendingBackgroundWork on the adapter runtime, returning true while any command items or subagents are still running.
• Adds integration tests covering post-settle completion, pre-settle no-continuation, and subagent resume with hydration of late results.

^{Macroscope summarized f6f10b4.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: edad5d2a-bb88-4b58-ab37-8c0ff70d5635

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[macroscopeapp]

Approvability

Verdict: Needs human review

This PR adds new runtime behavior for tracking background commands past turn settlement and triggering continuation requests when they complete. While well-tested, the changes affect orchestration flow decisions and should be reviewed by someone familiar with the CodexAdapter's event processing model.

^{You can customize Macroscope's approvability policy. Learn more.}

[mwolson]

What Changed

• Preserve Codex turn context long enough to project command completions that
  arrive after the root turn settles.
• Request one continuation run for each newly completed post-settle background
  command, while avoiding wakes for commands completed during the root turn.
• Reopen and hydrate resumed Codex subagents, and keep sessions resident while
  tracked background commands or subagents are still active.
• Add replay coverage for post-settle command completion, continuation
  deduplication, subagent resume, and pending-background state.

Why

Codex app-server can continue emitting command and subagent lifecycle events
after turn/completed. The adapter removed the owning turn from activeTurns
at settlement, so a later item/completed could not resolve its projection
context. The command card remained running, its final output was lost, and the
root agent was not notified. Resuming a completed subagent had a similar stale
projection problem because its new lifecycle was not reopened before the next
child turn.

Problem and Fix

Problem and Why it Happened	Fix
Post-settle command completion could not resolve an active turn, leaving the item running and dropping final output.	Retain settled turn context while tracked background items remain, then project the late completion and release the context when drained.
A completed background command did not wake the root agent.	Offer a continuation through the shared continuation queue once per completed post-settle command.
Resuming a completed subagent left its prior result and terminal state in the projection.	Reopen the subagent lifecycle on the resumed child turn and apply its later result and terminal state.
Idle release could stop a Codex session with provider work still active.	Report pending tracked commands and subagents through hasPendingBackgroundWork.

Validation

• vp check: pass with zero errors
• vp run typecheck: pass across all 15 packages
• vp test run apps/server/src/orchestration-v2/Adapters/CodexAdapterV2.test.ts apps/server/src/orchestration-v2/RunExecutionService.test.ts: 30 tests pass
• Headless Codex smoke and continuation packs: all pass, including strengthened
  assertions that command and subagent turn items reach completed
• AppImage manual matrix: prompts 1 through 8 pass, including two-command wake
  ordering, mixed command and subagent activity, subagent resume, and the
  in-turn no-wake case

Checklist

• This PR is small and focused
• I explained what changed and why

---

Note

Medium Risk
Changes Codex turn lifecycle, continuation scheduling, and session pinning in orchestration-v2; behavior is well covered by new replay tests but incorrect continuation or release logic could affect run completion or duplicate wakes.

Overview
Fixes Codex adapter handling when app-server events arrive after turn/completed, which previously dropped late item/completed projections and left background commands stuck.

The adapter now keeps settled turn context while in-flight commandExecution items are tracked, resolves late completions via resolveItemEventContext, and offers one continuation per newly completed post-settle command through ProviderContinuationRequests (with deduplication and codexBackgroundCommandDetail for the wake message). Commands that finish before settle do not trigger continuations; failed/interrupted turns stop tracking so late completions cannot wake stopped work.

Subagent projection is broadened: resumed child turns re-emit running state, terminal node/task updates apply beyond the first turn, and agent messages update subagent results without the old first-turn-only guard. hasPendingBackgroundWork reports active background commands or running subagents so idle release does not tear down sessions too early.

Adds replay tests for post-settle command wake, pre-settle no-wake, and resumed subagent hydration; exports makeReplayServerConfig from the testkit for harness reuse.

^{Reviewed by Cursor Bugbot for commit f6f10b4. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Fix Codex background command completion and subagent resume in orchestrator adapter

• Adds post-settle background command tracking in CodexAdapterV2: settled turn contexts are retained until all running background commands complete, allowing late item.completed events to be projected correctly.
• Offers a ProviderContinuationRequest when a root turn's background command completes after turn settle, using a new codexBackgroundCommandDetail helper that formats command text, exit code, and output tail (capped at 1,000 chars).
• Emits subagent.updated to running when a subsequent provider turn starts for a subagent task that wasn't already running, and emits status updates consistently on subagent completion.
• Exposes hasPendingBackgroundWork on the adapter runtime, returning true while any command items or subagents are still running.
• Adds integration tests covering post-settle completion, pre-settle no-continuation, and subagent resume with hydration of late results.

^{Macroscope summarized f6f10b4.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: edad5d2a-bb88-4b58-ab37-8c0ff70d5635

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[macroscopeapp]

Approvability

Verdict: Needs human review

This PR adds new runtime behavior for tracking background commands past turn settlement and triggering continuation requests when they complete. While well-tested, the changes affect orchestration flow decisions and should be reviewed by someone familiar with the CodexAdapter's event processing model.

^{You can customize Macroscope's approvability policy. Learn more.}

[mwolson]

What Changed

• Preserve Codex turn context long enough to project command completions that
  arrive after the root turn settles.
• Request one continuation run for each newly completed post-settle background
  command, while avoiding wakes for commands completed during the root turn.
• Reopen and hydrate resumed Codex subagents, and keep sessions resident while
  tracked background commands or subagents are still active.
• Add replay coverage for post-settle command completion, continuation
  deduplication, subagent resume, and pending-background state.

Why

Codex app-server can continue emitting command and subagent lifecycle events
after turn/completed. The adapter removed the owning turn from activeTurns
at settlement, so a later item/completed could not resolve its projection
context. The command card remained running, its final output was lost, and the
root agent was not notified. Resuming a completed subagent had a similar stale
projection problem because its new lifecycle was not reopened before the next
child turn.

Problem and Fix

Problem and Why it Happened	Fix
Post-settle command completion could not resolve an active turn, leaving the item running and dropping final output.	Retain settled turn context while tracked background items remain, then project the late completion and release the context when drained.
A completed background command did not wake the root agent.	Offer a continuation through the shared continuation queue once per completed post-settle command.
Resuming a completed subagent left its prior result and terminal state in the projection.	Reopen the subagent lifecycle on the resumed child turn and apply its later result and terminal state.
Idle release could stop a Codex session with provider work still active.	Report pending tracked commands and subagents through hasPendingBackgroundWork.

Validation

• vp check: pass with zero errors
• vp run typecheck: pass across all 15 packages
• vp test run apps/server/src/orchestration-v2/Adapters/CodexAdapterV2.test.ts apps/server/src/orchestration-v2/RunExecutionService.test.ts: 30 tests pass
• Headless Codex smoke and continuation packs: all pass, including strengthened
  assertions that command and subagent turn items reach completed
• AppImage manual matrix: prompts 1 through 8 pass, including two-command wake
  ordering, mixed command and subagent activity, subagent resume, and the
  in-turn no-wake case

Checklist

• This PR is small and focused
• I explained what changed and why

---

Note

Medium Risk
Changes Codex turn lifecycle, continuation scheduling, and session pinning in orchestration-v2; behavior is well covered by new replay tests but incorrect continuation or release logic could affect run completion or duplicate wakes.

Overview
Fixes Codex adapter handling when app-server events arrive after turn/completed, which previously dropped late item/completed projections and left background commands stuck.

The adapter now keeps settled turn context while in-flight commandExecution items are tracked, resolves late completions via resolveItemEventContext, and offers one continuation per newly completed post-settle command through ProviderContinuationRequests (with deduplication and codexBackgroundCommandDetail for the wake message). Commands that finish before settle do not trigger continuations; failed/interrupted turns stop tracking so late completions cannot wake stopped work.

Subagent projection is broadened: resumed child turns re-emit running state, terminal node/task updates apply beyond the first turn, and agent messages update subagent results without the old first-turn-only guard. hasPendingBackgroundWork reports active background commands or running subagents so idle release does not tear down sessions too early.

Adds replay tests for post-settle command wake, pre-settle no-wake, and resumed subagent hydration; exports makeReplayServerConfig from the testkit for harness reuse.

^{Reviewed by Cursor Bugbot for commit f6f10b4. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Fix Codex background command completion and subagent resume in orchestrator adapter

• Adds post-settle background command tracking in CodexAdapterV2: settled turn contexts are retained until all running background commands complete, allowing late item.completed events to be projected correctly.
• Offers a ProviderContinuationRequest when a root turn's background command completes after turn settle, using a new codexBackgroundCommandDetail helper that formats command text, exit code, and output tail (capped at 1,000 chars).
• Emits subagent.updated to running when a subsequent provider turn starts for a subagent task that wasn't already running, and emits status updates consistently on subagent completion.
• Exposes hasPendingBackgroundWork on the adapter runtime, returning true while any command items or subagents are still running.
• Adds integration tests covering post-settle completion, pre-settle no-continuation, and subagent resume with hydration of late results.

^{Macroscope summarized f6f10b4.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: edad5d2a-bb88-4b58-ab37-8c0ff70d5635

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[macroscopeapp]

Approvability

Verdict: Needs human review

This PR adds new runtime behavior for tracking background commands past turn settlement and triggering continuation requests when they complete. While well-tested, the changes affect orchestration flow decisions and should be reviewed by someone familiar with the CodexAdapter's event processing model.

^{You can customize Macroscope's approvability policy. Learn more.}