Uh oh!
There was an error while loading. Please reload this page.
feat: add native turn notifications - #4003
Conversation
…ions Co-Authored-By: AI Context Agent <noreply@anthropic.com>
…ions Co-Authored-By: AI Context Agent <noreply@anthropic.com>
…ions Co-Authored-By: AI Context Agent <noreply@anthropic.com>
Co-Authored-By: AI Context Agent <noreply@anthropic.com>
…tions Co-Authored-By: AI Context Agent <noreply@anthropic.com>
…tions Co-Authored-By: AI Context Agent <noreply@anthropic.com>
…tions Co-Authored-By: AI Context Agent <noreply@anthropic.com>
…tions Co-Authored-By: AI Context Agent <noreply@anthropic.com>
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| function pruneNotifications(notifications: Map<string, Electron.Notification>): void { | ||
| while (notifications.size > MAX_ACTIVE_NOTIFICATIONS) { | ||
| const oldestKey = notifications.keys().next().value; | ||
| if (oldestKey === undefined) return; | ||
| notifications.delete(oldestKey); | ||
| } | ||
| } |
There was a problem hiding this comment.
🟡 Mediumelectron/ElectronNotification.ts:41
pruneNotifications evicts notifications from the tracking map without closing them, so the OS notification remains visible but its click handler is lost. Clicking an evicted banner silently fails to fire onClick because the Notification instance is no longer retained. It also fails to enforce the 64-active-notification cap since the notifications keep running. Consider calling close() on the evicted Notification before removing it from the map.
function pruneNotifications(notifications: Map<string, Electron.Notification>): void {
while (notifications.size > MAX_ACTIVE_NOTIFICATIONS) {
const oldestKey = notifications.keys().next().value;
if (oldestKey === undefined) return;
+ notifications.get(oldestKey)?.close();
notifications.delete(oldestKey);
}
}🤖 Copy this AI Prompt to have your agent fix this:
In file @apps/desktop/src/electron/ElectronNotification.ts around lines 41-47:
`pruneNotifications` evicts notifications from the tracking map without closing them, so the OS notification remains visible but its click handler is lost. Clicking an evicted banner silently fails to fire `onClick` because the `Notification` instance is no longer retained. It also fails to enforce the 64-active-notification cap since the notifications keep running. Consider calling `close()` on the evicted `Notification` before removing it from the map.
t3dotgg
commented
Aug 23, 2026
Note 🤖 GPT-5.6 Sol responding on behalf of Theo Closing this PR after an automated pass over open pull requests. Unfinished July notification draft changes 65 files and commits unrelated agent working material. |
Closes#780
Scope
Technical decisions
Notification; unsupported or failed delivery is non-fatal.Validation
vp test: 586 files, 4,620 tests passed; 2 files/7 tests skipped.vp check: passed; 9 pre-existing React warnings.vp run typecheck: 15 tasks passed; existing Effect suggestions only.git diff --check: passed.macOS smoke
An isolated desktop run produced completion, approval, user-input, and failure transitions; each reached
desktop.notifications.showonce. Native banner/click, focused/disabled suppression, and denied-permission cycles remain pending because the T3 host and dev app sharecom.github.Electron, causing bundle-level foreground suppression. This PR stays draft until that matrix is completed from a packaged build with an independent bundle or manual focus outside Electron.Full evidence:
.context/evidence/issue-780-native-desktop-notifications-validation.md.Out of scope and limits
Note
Add native turn notifications to the Electron desktop app
DesktopNotificationsservice in the desktop main process that shows silent native OS notifications for AI turn completions, approvals, and user-input requests, with deduplication byeventIdand a click handler that navigates to the relevant thread.reduceDesktopNotificationObservationreducer in the web layer that tracks per-thread attention state across environment shell updates and emits one-shot events (turn-completed,turn-failed,approval-required,user-input-required) on significant transitions.DesktopNotificationBootstrap,subscribeDesktopNotificationEnvironment, and preload bridge APIs (showDesktopNotification,consumePendingDesktopNotificationTarget,onDesktopNotificationTargetAvailable).desktopNotificationsEnabledfield inClientSettingsSchemadefaulting tofalse.📊 Macroscope summarized cba3e39. 43 files reviewed, 0 issues evaluated, 0 issues filtered, 0 comments posted
🗂️ Filtered Issues
No issues evaluated.