Uh oh!
There was an error while loading. Please reload this page.
Add configurable add-project shortcut - #4258
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Uh oh!
There was an error while loading. Please reload this page.
ApprovabilityVerdict: Needs human review This PR introduces a new user-facing keyboard shortcut (Alt+A) for the add-project command, including new shortcut handling logic and state management for flow tracking. While well-tested and from an experienced contributor, new feature capabilities warrant human review. You can customize Macroscope's approvability policy. Learn more. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
e7cb807 to
42b605fCompareUh oh!
There was an error while loading. Please reload this page.
Dismissing prior approval to re-evaluate 51e185e
681668e to
48a7327CompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
ac10e74 to
b9a4196CompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
2e0cf21 to
d1740c6Compare88cfcca to
7c2a7f9Compare# Conflicts: # apps/web/src/components/CommandPalette.logic.test.ts # apps/web/src/components/CommandPalette.tsx
# Conflicts: # apps/web/src/components/CommandPalette.logic.test.ts # apps/web/src/components/CommandPalette.tsx
7c2a7f9 to
0dcb2e9Compare0dcb2e9 to
dad869dComparet3dotgg
commented
Aug 28, 2026
Note 🤖 GPT-5.6 Sol responding on behalf of Theo We're closing this PR as we clean up the T3 Code backlog. Thank you for taking the time to put this together. This adds a global command, setting, server validation, palette action, and default Alt+A binding for the existing Add project flow. The shortcut does not justify the extra command and default key chord across eight files. If you believe we closed this in error, please reopen the PR and leave a comment explaining what we missed. |
Summary
project.addkeybinding with a default ofalt+aWhy
T3 Code already models user-facing shortcuts as named, configurable commands. Using that same system keeps shortcut conflict resolution, per-user overrides, and the Keybindings settings UI consistent instead of hard-coding a palette-only key. Plain
Alt+Ais unused by the app;Ctrl+Aremains available for standard Select All behavior.Validation
vp test packages/contracts/src/keybindings.test.ts apps/web/src/keybindings.test.ts apps/server/src/keybindings.test.tsvp checkvp run typecheckExact-head evidence
Revalidated at ac10e74ae628 on current main (9a0a071): focused tests, vp check, and vp run typecheck passed. The capture uses only disposable local projects.
Note
Low Risk
UI and keybinding changes only; no auth or data-layer changes. Main risk is Alt+A conflicting with typing in the palette search when open, which is intentional.
Overview
Adds a new
project.addkeybinding command (defaultalt+a, disabled in terminal focus) across contracts, shared defaults, and server config, so users can rebind it like other shortcuts.The command palette’s global key handler now routes
project.addinto the existing add-project flow (not onlycommandPalette.toggle), withshouldHandleCommandPaletteShortcutso Alt+A does not steal focus from editors unless the palette is already open; key repeat is ignored.Add project is surfaced in New thread in… via
buildNewThreadInGroupswith the binding shown on the action. The add-project wizard tracks stack depth to avoid reopening while active and fully resets clone/environment state when backing out to the parent view.Reviewed by Cursor Bugbot for commit dad869d. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Add configurable
project.addshortcut (Alt+A) to open the add-project flowproject.addas a new static keybinding command with a defaultalt+abinding (outside terminal focus) in keybindings.ts and keybindings.ts.project.addfires, skipping editable targets unless the palette is already open.New thread in...submenu now includes anAdd projectaction with the shortcut displayed alongside the project list.addProjectFlowBaseDepthRefto prevent duplicate openings and resets state when the user pops back to or above that depth.Macroscope summarized dad869d.