Add stop thread keybinding command - #4308

Open
jakeleventhal wants to merge 7 commits into
pingdotgg:mainfrom
jakeleventhal:t3code/add-stop-thread-keybinding
Open

Add stop thread keybinding command#4308
jakeleventhal wants to merge 7 commits into
pingdotgg:mainfrom
jakeleventhal:t3code/add-stop-thread-keybinding

Conversation

@jakeleventhal

@jakeleventhaljakeleventhal commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Summary

Screen.Recording.2026-07-22.at.4.36.45.PM.mov
  • add a typed thread.stop keybinding command without assigning a default shortcut
  • expose all static commands, including unbound ones, in the keybinding picker
  • route the command through the focused thread's existing turn-interrupt behavior

Testing

  • vp test run packages/contracts/src/keybindings.test.ts apps/web/src/keybindings.test.ts apps/web/src/components/settings/KeybindingsSettings.logic.test.ts (58 tests)
  • vp run typecheck in packages/contracts
  • vp run typecheck in apps/web
  • targeted vp fmt --check and vp lint for all changed files
  • integrated browser verification with a real running Codex turn and a custom thread.stop binding; the turn returned to ready with no active turn or error

Note

Add thread.stop keybinding command to interrupt running thread turns

  • Introduces buildRunningThreadTurnInterruptInput in ChatView.logic.ts, which returns a turn interrupt input only when both the current phase and thread session status are running; otherwise returns null
  • Updates ChatViewContent in ChatView.tsx to handle the thread.stop keybinding: it ignores auto-repeated keydowns, checks canInterruptRunningThread, and invokes interruptThreadTurn using the active thread's environmentId
  • Registers thread.stop in THREAD_KEYBINDING_COMMANDS in keybindings.ts so schemas and validators accept it; it is unassigned by default
  • Extends keybinding resolution context with previewFocus and previewOpen flags, allowing thread.stop (and other commands) to be conditionally guarded on preview state
  • Behavioral Change: the old onInterrupt always built input via buildThreadTurnInterruptInput using the environmentId prop; it now uses interruptContextRef and the active thread's environmentId, so interrupt requests target the currently active thread rather than a static prop

Macroscope summarized ee284b0.


Note

Medium Risk
New keyboard path can cancel in-flight agent turns; behavior is gated on running state but mis-bound shortcuts or when rules could still interrupt unexpectedly.

Overview
Adds a thread.stop keybinding command (typed in contracts, no default shortcut) so users can interrupt the active turn from the keyboard when they assign a binding in Settings.

ChatView handles thread.stop in the global keydown path: it only runs when buildRunningThreadTurnInterruptInput says the UI phase and thread session are both running (including before activeTurnId is projected), ignores key repeat, and calls the existing interruptThreadTurn flow with errors surfaced on the active thread. Turn-interrupt input building is tightened so a running session without a projected turn omits turnId instead of sending a stale id.

Shortcut resolution context now includes previewFocus and previewOpen, so custom when clauses can gate commands (including stop) on preview state. The keybinding picker is expected to list all static commands, not only ones with default bindings—thread.stop appears there but stays out of DEFAULT_RESOLVED_KEYBINDINGS.

User docs note that thread.stop is unassigned by default.

Reviewed by Cursor Bugbot for commit 2722997. Bugbot is set up for automated code reviews on this repo. Configure here.

@coderabbitai

coderabbitaiBot commented Jul 22, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 656f1296-54e7-490e-8b5a-242f03656535

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actionsgithub-actionsBot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:M 30-99 changed lines (additions + deletions). labels Jul 22, 2026
@jakeleventhal
jakeleventhal marked this pull request as ready for review July 22, 2026 20:40
Comment threadapps/web/src/components/ChatView.tsx
Comment threadapps/web/src/components/ChatView.tsx
@macroscopeapp

macroscopeappBot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at 2722997

Macroscope's review found this PR approvable — This is a small, opt-in keybinding that exposes an existing turn-interrupt action without changing default shortcuts or stored configuration behavior. The running-state guards, repeat handling, context support, and focused tests keep the production impact bounded.

You can add or adjust custom eligibility rules. Learn more.

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:7ae04963d6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadapps/web/src/components/ChatView.tsx

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:b98d4ac1e5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadapps/web/src/components/ChatView.tsx
Comment threadapps/web/src/components/ChatView.tsx Outdated
Comment threadpackages/contracts/src/keybindings.ts
Comment threadapps/web/src/components/ChatView.tsx
Comment threadapps/web/src/components/ChatView.tsx
@jakeleventhal
jakeleventhalforce-pushed the t3code/add-stop-thread-keybinding branch from 47f88dd to ef70decCompareAugust 10, 2026 20:28
Comment threadapps/web/src/components/ChatView.tsx
@t3dotggt3dotgg added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. and removed vouch:unvouched PR author is not yet trusted in the VOUCHED list. labels Aug 24, 2026
@jakeleventhal
jakeleventhalforce-pushed the t3code/add-stop-thread-keybinding branch from 28efa1f to 8944667CompareAugust 26, 2026 02:30
Comment threadapps/web/src/components/ChatView.tsx
@jakeleventhal
jakeleventhalforce-pushed the t3code/add-stop-thread-keybinding branch from 8944667 to ab07696CompareAugust 26, 2026 02:37
Comment threadapps/web/src/components/ChatView.tsx

@cursorcursorBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit ee284b0. Configure here.

Comment threadapps/web/src/components/ChatView.tsx
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M30-99 changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@jakeleventhal@t3dotgg
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

Add stop thread keybinding command - #4308

Open
jakeleventhal wants to merge 7 commits into
pingdotgg:mainfrom
jakeleventhal:t3code/add-stop-thread-keybinding
Open

Add stop thread keybinding command#4308
jakeleventhal wants to merge 7 commits into
pingdotgg:mainfrom
jakeleventhal:t3code/add-stop-thread-keybinding

Conversation

@jakeleventhal

@jakeleventhaljakeleventhal commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Summary

Screen.Recording.2026-07-22.at.4.36.45.PM.mov
  • add a typed thread.stop keybinding command without assigning a default shortcut
  • expose all static commands, including unbound ones, in the keybinding picker
  • route the command through the focused thread's existing turn-interrupt behavior

Testing

  • vp test run packages/contracts/src/keybindings.test.ts apps/web/src/keybindings.test.ts apps/web/src/components/settings/KeybindingsSettings.logic.test.ts (58 tests)
  • vp run typecheck in packages/contracts
  • vp run typecheck in apps/web
  • targeted vp fmt --check and vp lint for all changed files
  • integrated browser verification with a real running Codex turn and a custom thread.stop binding; the turn returned to ready with no active turn or error

Note

Add thread.stop keybinding command to interrupt running thread turns

  • Introduces buildRunningThreadTurnInterruptInput in ChatView.logic.ts, which returns a turn interrupt input only when both the current phase and thread session status are running; otherwise returns null
  • Updates ChatViewContent in ChatView.tsx to handle the thread.stop keybinding: it ignores auto-repeated keydowns, checks canInterruptRunningThread, and invokes interruptThreadTurn using the active thread's environmentId
  • Registers thread.stop in THREAD_KEYBINDING_COMMANDS in keybindings.ts so schemas and validators accept it; it is unassigned by default
  • Extends keybinding resolution context with previewFocus and previewOpen flags, allowing thread.stop (and other commands) to be conditionally guarded on preview state
  • Behavioral Change: the old onInterrupt always built input via buildThreadTurnInterruptInput using the environmentId prop; it now uses interruptContextRef and the active thread's environmentId, so interrupt requests target the currently active thread rather than a static prop

Macroscope summarized ee284b0.


Note

Medium Risk
New keyboard path can cancel in-flight agent turns; behavior is gated on running state but mis-bound shortcuts or when rules could still interrupt unexpectedly.

Overview
Adds a thread.stop keybinding command (typed in contracts, no default shortcut) so users can interrupt the active turn from the keyboard when they assign a binding in Settings.

ChatView handles thread.stop in the global keydown path: it only runs when buildRunningThreadTurnInterruptInput says the UI phase and thread session are both running (including before activeTurnId is projected), ignores key repeat, and calls the existing interruptThreadTurn flow with errors surfaced on the active thread. Turn-interrupt input building is tightened so a running session without a projected turn omits turnId instead of sending a stale id.

Shortcut resolution context now includes previewFocus and previewOpen, so custom when clauses can gate commands (including stop) on preview state. The keybinding picker is expected to list all static commands, not only ones with default bindings—thread.stop appears there but stays out of DEFAULT_RESOLVED_KEYBINDINGS.

User docs note that thread.stop is unassigned by default.

Reviewed by Cursor Bugbot for commit 2722997. Bugbot is set up for automated code reviews on this repo. Configure here.

@coderabbitai

coderabbitaiBot commented Jul 22, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 656f1296-54e7-490e-8b5a-242f03656535

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actionsgithub-actionsBot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:M 30-99 changed lines (additions + deletions). labels Jul 22, 2026
@jakeleventhal
jakeleventhal marked this pull request as ready for review July 22, 2026 20:40
Comment threadapps/web/src/components/ChatView.tsx
Comment threadapps/web/src/components/ChatView.tsx
@macroscopeapp

macroscopeappBot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at 2722997

Macroscope's review found this PR approvable — This is a small, opt-in keybinding that exposes an existing turn-interrupt action without changing default shortcuts or stored configuration behavior. The running-state guards, repeat handling, context support, and focused tests keep the production impact bounded.

You can add or adjust custom eligibility rules. Learn more.

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:7ae04963d6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadapps/web/src/components/ChatView.tsx

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:b98d4ac1e5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadapps/web/src/components/ChatView.tsx
Comment threadapps/web/src/components/ChatView.tsx Outdated
Comment threadpackages/contracts/src/keybindings.ts
Comment threadapps/web/src/components/ChatView.tsx
Comment threadapps/web/src/components/ChatView.tsx
@jakeleventhal
jakeleventhalforce-pushed the t3code/add-stop-thread-keybinding branch from 47f88dd to ef70decCompareAugust 10, 2026 20:28
Comment threadapps/web/src/components/ChatView.tsx
@t3dotggt3dotgg added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. and removed vouch:unvouched PR author is not yet trusted in the VOUCHED list. labels Aug 24, 2026
@jakeleventhal
jakeleventhalforce-pushed the t3code/add-stop-thread-keybinding branch from 28efa1f to 8944667CompareAugust 26, 2026 02:30
Comment threadapps/web/src/components/ChatView.tsx
@jakeleventhal
jakeleventhalforce-pushed the t3code/add-stop-thread-keybinding branch from 8944667 to ab07696CompareAugust 26, 2026 02:37
Comment threadapps/web/src/components/ChatView.tsx

@cursorcursorBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit ee284b0. Configure here.

Comment threadapps/web/src/components/ChatView.tsx
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M30-99 changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@jakeleventhal@t3dotgg
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Add stop thread keybinding command - #4308

Open
jakeleventhal wants to merge 7 commits into
pingdotgg:mainfrom
jakeleventhal:t3code/add-stop-thread-keybinding
Open

Add stop thread keybinding command#4308
jakeleventhal wants to merge 7 commits into
pingdotgg:mainfrom
jakeleventhal:t3code/add-stop-thread-keybinding

Conversation

@jakeleventhal

@jakeleventhaljakeleventhal commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Summary

Screen.Recording.2026-07-22.at.4.36.45.PM.mov
  • add a typed thread.stop keybinding command without assigning a default shortcut
  • expose all static commands, including unbound ones, in the keybinding picker
  • route the command through the focused thread's existing turn-interrupt behavior

Testing

  • vp test run packages/contracts/src/keybindings.test.ts apps/web/src/keybindings.test.ts apps/web/src/components/settings/KeybindingsSettings.logic.test.ts (58 tests)
  • vp run typecheck in packages/contracts
  • vp run typecheck in apps/web
  • targeted vp fmt --check and vp lint for all changed files
  • integrated browser verification with a real running Codex turn and a custom thread.stop binding; the turn returned to ready with no active turn or error

Note

Add thread.stop keybinding command to interrupt running thread turns

  • Introduces buildRunningThreadTurnInterruptInput in ChatView.logic.ts, which returns a turn interrupt input only when both the current phase and thread session status are running; otherwise returns null
  • Updates ChatViewContent in ChatView.tsx to handle the thread.stop keybinding: it ignores auto-repeated keydowns, checks canInterruptRunningThread, and invokes interruptThreadTurn using the active thread's environmentId
  • Registers thread.stop in THREAD_KEYBINDING_COMMANDS in keybindings.ts so schemas and validators accept it; it is unassigned by default
  • Extends keybinding resolution context with previewFocus and previewOpen flags, allowing thread.stop (and other commands) to be conditionally guarded on preview state
  • Behavioral Change: the old onInterrupt always built input via buildThreadTurnInterruptInput using the environmentId prop; it now uses interruptContextRef and the active thread's environmentId, so interrupt requests target the currently active thread rather than a static prop

Macroscope summarized ee284b0.


Note

Medium Risk
New keyboard path can cancel in-flight agent turns; behavior is gated on running state but mis-bound shortcuts or when rules could still interrupt unexpectedly.

Overview
Adds a thread.stop keybinding command (typed in contracts, no default shortcut) so users can interrupt the active turn from the keyboard when they assign a binding in Settings.

ChatView handles thread.stop in the global keydown path: it only runs when buildRunningThreadTurnInterruptInput says the UI phase and thread session are both running (including before activeTurnId is projected), ignores key repeat, and calls the existing interruptThreadTurn flow with errors surfaced on the active thread. Turn-interrupt input building is tightened so a running session without a projected turn omits turnId instead of sending a stale id.

Shortcut resolution context now includes previewFocus and previewOpen, so custom when clauses can gate commands (including stop) on preview state. The keybinding picker is expected to list all static commands, not only ones with default bindings—thread.stop appears there but stays out of DEFAULT_RESOLVED_KEYBINDINGS.

User docs note that thread.stop is unassigned by default.

Reviewed by Cursor Bugbot for commit 2722997. Bugbot is set up for automated code reviews on this repo. Configure here.

@coderabbitai

coderabbitaiBot commented Jul 22, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 656f1296-54e7-490e-8b5a-242f03656535

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actionsgithub-actionsBot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:M 30-99 changed lines (additions + deletions). labels Jul 22, 2026
@jakeleventhal
jakeleventhal marked this pull request as ready for review July 22, 2026 20:40
Comment threadapps/web/src/components/ChatView.tsx
Comment threadapps/web/src/components/ChatView.tsx
@macroscopeapp

macroscopeappBot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at 2722997

Macroscope's review found this PR approvable — This is a small, opt-in keybinding that exposes an existing turn-interrupt action without changing default shortcuts or stored configuration behavior. The running-state guards, repeat handling, context support, and focused tests keep the production impact bounded.

You can add or adjust custom eligibility rules. Learn more.

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:7ae04963d6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadapps/web/src/components/ChatView.tsx

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:b98d4ac1e5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadapps/web/src/components/ChatView.tsx
Comment threadapps/web/src/components/ChatView.tsx Outdated
Comment threadpackages/contracts/src/keybindings.ts
Comment threadapps/web/src/components/ChatView.tsx
Comment threadapps/web/src/components/ChatView.tsx
@jakeleventhal
jakeleventhalforce-pushed the t3code/add-stop-thread-keybinding branch from 47f88dd to ef70decCompareAugust 10, 2026 20:28
Comment threadapps/web/src/components/ChatView.tsx
@t3dotggt3dotgg added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. and removed vouch:unvouched PR author is not yet trusted in the VOUCHED list. labels Aug 24, 2026
@jakeleventhal
jakeleventhalforce-pushed the t3code/add-stop-thread-keybinding branch from 28efa1f to 8944667CompareAugust 26, 2026 02:30
Comment threadapps/web/src/components/ChatView.tsx
@jakeleventhal
jakeleventhalforce-pushed the t3code/add-stop-thread-keybinding branch from 8944667 to ab07696CompareAugust 26, 2026 02:37
Comment threadapps/web/src/components/ChatView.tsx

@cursorcursorBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit ee284b0. Configure here.

Comment threadapps/web/src/components/ChatView.tsx
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M30-99 changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@jakeleventhal@t3dotgg
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Add stop thread keybinding command - #4308

Open
jakeleventhal wants to merge 7 commits into
pingdotgg:mainfrom
jakeleventhal:t3code/add-stop-thread-keybinding
Open

Add stop thread keybinding command#4308
jakeleventhal wants to merge 7 commits into
pingdotgg:mainfrom
jakeleventhal:t3code/add-stop-thread-keybinding

Conversation

@jakeleventhal

@jakeleventhaljakeleventhal commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Summary

Screen.Recording.2026-07-22.at.4.36.45.PM.mov
  • add a typed thread.stop keybinding command without assigning a default shortcut
  • expose all static commands, including unbound ones, in the keybinding picker
  • route the command through the focused thread's existing turn-interrupt behavior

Testing

  • vp test run packages/contracts/src/keybindings.test.ts apps/web/src/keybindings.test.ts apps/web/src/components/settings/KeybindingsSettings.logic.test.ts (58 tests)
  • vp run typecheck in packages/contracts
  • vp run typecheck in apps/web
  • targeted vp fmt --check and vp lint for all changed files
  • integrated browser verification with a real running Codex turn and a custom thread.stop binding; the turn returned to ready with no active turn or error

Note

Add thread.stop keybinding command to interrupt running thread turns

  • Introduces buildRunningThreadTurnInterruptInput in ChatView.logic.ts, which returns a turn interrupt input only when both the current phase and thread session status are running; otherwise returns null
  • Updates ChatViewContent in ChatView.tsx to handle the thread.stop keybinding: it ignores auto-repeated keydowns, checks canInterruptRunningThread, and invokes interruptThreadTurn using the active thread's environmentId
  • Registers thread.stop in THREAD_KEYBINDING_COMMANDS in keybindings.ts so schemas and validators accept it; it is unassigned by default
  • Extends keybinding resolution context with previewFocus and previewOpen flags, allowing thread.stop (and other commands) to be conditionally guarded on preview state
  • Behavioral Change: the old onInterrupt always built input via buildThreadTurnInterruptInput using the environmentId prop; it now uses interruptContextRef and the active thread's environmentId, so interrupt requests target the currently active thread rather than a static prop

Macroscope summarized ee284b0.


Note

Medium Risk
New keyboard path can cancel in-flight agent turns; behavior is gated on running state but mis-bound shortcuts or when rules could still interrupt unexpectedly.

Overview
Adds a thread.stop keybinding command (typed in contracts, no default shortcut) so users can interrupt the active turn from the keyboard when they assign a binding in Settings.

ChatView handles thread.stop in the global keydown path: it only runs when buildRunningThreadTurnInterruptInput says the UI phase and thread session are both running (including before activeTurnId is projected), ignores key repeat, and calls the existing interruptThreadTurn flow with errors surfaced on the active thread. Turn-interrupt input building is tightened so a running session without a projected turn omits turnId instead of sending a stale id.

Shortcut resolution context now includes previewFocus and previewOpen, so custom when clauses can gate commands (including stop) on preview state. The keybinding picker is expected to list all static commands, not only ones with default bindings—thread.stop appears there but stays out of DEFAULT_RESOLVED_KEYBINDINGS.

User docs note that thread.stop is unassigned by default.

Reviewed by Cursor Bugbot for commit 2722997. Bugbot is set up for automated code reviews on this repo. Configure here.

@coderabbitai

coderabbitaiBot commented Jul 22, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 656f1296-54e7-490e-8b5a-242f03656535

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actionsgithub-actionsBot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:M 30-99 changed lines (additions + deletions). labels Jul 22, 2026
@jakeleventhal
jakeleventhal marked this pull request as ready for review July 22, 2026 20:40
Comment threadapps/web/src/components/ChatView.tsx
Comment threadapps/web/src/components/ChatView.tsx
@macroscopeapp

macroscopeappBot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at 2722997

Macroscope's review found this PR approvable — This is a small, opt-in keybinding that exposes an existing turn-interrupt action without changing default shortcuts or stored configuration behavior. The running-state guards, repeat handling, context support, and focused tests keep the production impact bounded.

You can add or adjust custom eligibility rules. Learn more.

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:7ae04963d6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadapps/web/src/components/ChatView.tsx

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:b98d4ac1e5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadapps/web/src/components/ChatView.tsx
Comment threadapps/web/src/components/ChatView.tsx Outdated
Comment threadpackages/contracts/src/keybindings.ts
Comment threadapps/web/src/components/ChatView.tsx
Comment threadapps/web/src/components/ChatView.tsx
@jakeleventhal
jakeleventhalforce-pushed the t3code/add-stop-thread-keybinding branch from 47f88dd to ef70decCompareAugust 10, 2026 20:28
Comment threadapps/web/src/components/ChatView.tsx
@t3dotggt3dotgg added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. and removed vouch:unvouched PR author is not yet trusted in the VOUCHED list. labels Aug 24, 2026
@jakeleventhal
jakeleventhalforce-pushed the t3code/add-stop-thread-keybinding branch from 28efa1f to 8944667CompareAugust 26, 2026 02:30
Comment threadapps/web/src/components/ChatView.tsx
@jakeleventhal
jakeleventhalforce-pushed the t3code/add-stop-thread-keybinding branch from 8944667 to ab07696CompareAugust 26, 2026 02:37
Comment threadapps/web/src/components/ChatView.tsx

@cursorcursorBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit ee284b0. Configure here.

Comment threadapps/web/src/components/ChatView.tsx
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M30-99 changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@jakeleventhal@t3dotgg
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

Add stop thread keybinding command - #4308

Open
jakeleventhal wants to merge 7 commits into
pingdotgg:mainfrom
jakeleventhal:t3code/add-stop-thread-keybinding
Open

Add stop thread keybinding command#4308
jakeleventhal wants to merge 7 commits into
pingdotgg:mainfrom
jakeleventhal:t3code/add-stop-thread-keybinding

Conversation

@jakeleventhal

@jakeleventhaljakeleventhal commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Summary

Screen.Recording.2026-07-22.at.4.36.45.PM.mov
  • add a typed thread.stop keybinding command without assigning a default shortcut
  • expose all static commands, including unbound ones, in the keybinding picker
  • route the command through the focused thread's existing turn-interrupt behavior

Testing

  • vp test run packages/contracts/src/keybindings.test.ts apps/web/src/keybindings.test.ts apps/web/src/components/settings/KeybindingsSettings.logic.test.ts (58 tests)
  • vp run typecheck in packages/contracts
  • vp run typecheck in apps/web
  • targeted vp fmt --check and vp lint for all changed files
  • integrated browser verification with a real running Codex turn and a custom thread.stop binding; the turn returned to ready with no active turn or error

Note

Add thread.stop keybinding command to interrupt running thread turns

  • Introduces buildRunningThreadTurnInterruptInput in ChatView.logic.ts, which returns a turn interrupt input only when both the current phase and thread session status are running; otherwise returns null
  • Updates ChatViewContent in ChatView.tsx to handle the thread.stop keybinding: it ignores auto-repeated keydowns, checks canInterruptRunningThread, and invokes interruptThreadTurn using the active thread's environmentId
  • Registers thread.stop in THREAD_KEYBINDING_COMMANDS in keybindings.ts so schemas and validators accept it; it is unassigned by default
  • Extends keybinding resolution context with previewFocus and previewOpen flags, allowing thread.stop (and other commands) to be conditionally guarded on preview state
  • Behavioral Change: the old onInterrupt always built input via buildThreadTurnInterruptInput using the environmentId prop; it now uses interruptContextRef and the active thread's environmentId, so interrupt requests target the currently active thread rather than a static prop

Macroscope summarized ee284b0.


Note

Medium Risk
New keyboard path can cancel in-flight agent turns; behavior is gated on running state but mis-bound shortcuts or when rules could still interrupt unexpectedly.

Overview
Adds a thread.stop keybinding command (typed in contracts, no default shortcut) so users can interrupt the active turn from the keyboard when they assign a binding in Settings.

ChatView handles thread.stop in the global keydown path: it only runs when buildRunningThreadTurnInterruptInput says the UI phase and thread session are both running (including before activeTurnId is projected), ignores key repeat, and calls the existing interruptThreadTurn flow with errors surfaced on the active thread. Turn-interrupt input building is tightened so a running session without a projected turn omits turnId instead of sending a stale id.

Shortcut resolution context now includes previewFocus and previewOpen, so custom when clauses can gate commands (including stop) on preview state. The keybinding picker is expected to list all static commands, not only ones with default bindings—thread.stop appears there but stays out of DEFAULT_RESOLVED_KEYBINDINGS.

User docs note that thread.stop is unassigned by default.

Reviewed by Cursor Bugbot for commit 2722997. Bugbot is set up for automated code reviews on this repo. Configure here.

@coderabbitai

coderabbitaiBot commented Jul 22, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 656f1296-54e7-490e-8b5a-242f03656535

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actionsgithub-actionsBot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:M 30-99 changed lines (additions + deletions). labels Jul 22, 2026
@jakeleventhal
jakeleventhal marked this pull request as ready for review July 22, 2026 20:40
Comment threadapps/web/src/components/ChatView.tsx
Comment threadapps/web/src/components/ChatView.tsx
@macroscopeapp

macroscopeappBot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at 2722997

Macroscope's review found this PR approvable — This is a small, opt-in keybinding that exposes an existing turn-interrupt action without changing default shortcuts or stored configuration behavior. The running-state guards, repeat handling, context support, and focused tests keep the production impact bounded.

You can add or adjust custom eligibility rules. Learn more.

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:7ae04963d6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadapps/web/src/components/ChatView.tsx

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:b98d4ac1e5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadapps/web/src/components/ChatView.tsx
Comment threadapps/web/src/components/ChatView.tsx Outdated
Comment threadpackages/contracts/src/keybindings.ts
Comment threadapps/web/src/components/ChatView.tsx
Comment threadapps/web/src/components/ChatView.tsx
@jakeleventhal
jakeleventhalforce-pushed the t3code/add-stop-thread-keybinding branch from 47f88dd to ef70decCompareAugust 10, 2026 20:28
Comment threadapps/web/src/components/ChatView.tsx
@t3dotggt3dotgg added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. and removed vouch:unvouched PR author is not yet trusted in the VOUCHED list. labels Aug 24, 2026
@jakeleventhal
jakeleventhalforce-pushed the t3code/add-stop-thread-keybinding branch from 28efa1f to 8944667CompareAugust 26, 2026 02:30
Comment threadapps/web/src/components/ChatView.tsx
@jakeleventhal
jakeleventhalforce-pushed the t3code/add-stop-thread-keybinding branch from 8944667 to ab07696CompareAugust 26, 2026 02:37
Comment threadapps/web/src/components/ChatView.tsx

@cursorcursorBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit ee284b0. Configure here.

Comment threadapps/web/src/components/ChatView.tsx
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M30-99 changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@jakeleventhal@t3dotgg
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Add stop thread keybinding command - #4308

Open
jakeleventhal wants to merge 7 commits into
pingdotgg:mainfrom
jakeleventhal:t3code/add-stop-thread-keybinding
Open

Add stop thread keybinding command#4308
jakeleventhal wants to merge 7 commits into
pingdotgg:mainfrom
jakeleventhal:t3code/add-stop-thread-keybinding

Conversation

@jakeleventhal

@jakeleventhaljakeleventhal commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Summary

Screen.Recording.2026-07-22.at.4.36.45.PM.mov
  • add a typed thread.stop keybinding command without assigning a default shortcut
  • expose all static commands, including unbound ones, in the keybinding picker
  • route the command through the focused thread's existing turn-interrupt behavior

Testing

  • vp test run packages/contracts/src/keybindings.test.ts apps/web/src/keybindings.test.ts apps/web/src/components/settings/KeybindingsSettings.logic.test.ts (58 tests)
  • vp run typecheck in packages/contracts
  • vp run typecheck in apps/web
  • targeted vp fmt --check and vp lint for all changed files
  • integrated browser verification with a real running Codex turn and a custom thread.stop binding; the turn returned to ready with no active turn or error

Note

Add thread.stop keybinding command to interrupt running thread turns

  • Introduces buildRunningThreadTurnInterruptInput in ChatView.logic.ts, which returns a turn interrupt input only when both the current phase and thread session status are running; otherwise returns null
  • Updates ChatViewContent in ChatView.tsx to handle the thread.stop keybinding: it ignores auto-repeated keydowns, checks canInterruptRunningThread, and invokes interruptThreadTurn using the active thread's environmentId
  • Registers thread.stop in THREAD_KEYBINDING_COMMANDS in keybindings.ts so schemas and validators accept it; it is unassigned by default
  • Extends keybinding resolution context with previewFocus and previewOpen flags, allowing thread.stop (and other commands) to be conditionally guarded on preview state
  • Behavioral Change: the old onInterrupt always built input via buildThreadTurnInterruptInput using the environmentId prop; it now uses interruptContextRef and the active thread's environmentId, so interrupt requests target the currently active thread rather than a static prop

Macroscope summarized ee284b0.


Note

Medium Risk
New keyboard path can cancel in-flight agent turns; behavior is gated on running state but mis-bound shortcuts or when rules could still interrupt unexpectedly.

Overview
Adds a thread.stop keybinding command (typed in contracts, no default shortcut) so users can interrupt the active turn from the keyboard when they assign a binding in Settings.

ChatView handles thread.stop in the global keydown path: it only runs when buildRunningThreadTurnInterruptInput says the UI phase and thread session are both running (including before activeTurnId is projected), ignores key repeat, and calls the existing interruptThreadTurn flow with errors surfaced on the active thread. Turn-interrupt input building is tightened so a running session without a projected turn omits turnId instead of sending a stale id.

Shortcut resolution context now includes previewFocus and previewOpen, so custom when clauses can gate commands (including stop) on preview state. The keybinding picker is expected to list all static commands, not only ones with default bindings—thread.stop appears there but stays out of DEFAULT_RESOLVED_KEYBINDINGS.

User docs note that thread.stop is unassigned by default.

Reviewed by Cursor Bugbot for commit 2722997. Bugbot is set up for automated code reviews on this repo. Configure here.

@coderabbitai

coderabbitaiBot commented Jul 22, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 656f1296-54e7-490e-8b5a-242f03656535

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actionsgithub-actionsBot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:M 30-99 changed lines (additions + deletions). labels Jul 22, 2026
@jakeleventhal
jakeleventhal marked this pull request as ready for review July 22, 2026 20:40
Comment threadapps/web/src/components/ChatView.tsx
Comment threadapps/web/src/components/ChatView.tsx
@macroscopeapp

macroscopeappBot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at 2722997

Macroscope's review found this PR approvable — This is a small, opt-in keybinding that exposes an existing turn-interrupt action without changing default shortcuts or stored configuration behavior. The running-state guards, repeat handling, context support, and focused tests keep the production impact bounded.

You can add or adjust custom eligibility rules. Learn more.

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:7ae04963d6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadapps/web/src/components/ChatView.tsx

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:b98d4ac1e5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadapps/web/src/components/ChatView.tsx
Comment threadapps/web/src/components/ChatView.tsx Outdated
Comment threadpackages/contracts/src/keybindings.ts
Comment threadapps/web/src/components/ChatView.tsx
Comment threadapps/web/src/components/ChatView.tsx
@jakeleventhal
jakeleventhalforce-pushed the t3code/add-stop-thread-keybinding branch from 47f88dd to ef70decCompareAugust 10, 2026 20:28
Comment threadapps/web/src/components/ChatView.tsx
@t3dotggt3dotgg added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. and removed vouch:unvouched PR author is not yet trusted in the VOUCHED list. labels Aug 24, 2026
@jakeleventhal
jakeleventhalforce-pushed the t3code/add-stop-thread-keybinding branch from 28efa1f to 8944667CompareAugust 26, 2026 02:30
Comment threadapps/web/src/components/ChatView.tsx
@jakeleventhal
jakeleventhalforce-pushed the t3code/add-stop-thread-keybinding branch from 8944667 to ab07696CompareAugust 26, 2026 02:37
Comment threadapps/web/src/components/ChatView.tsx

@cursorcursorBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit ee284b0. Configure here.

Comment threadapps/web/src/components/ChatView.tsx
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M30-99 changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@jakeleventhal@t3dotgg
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Add stop thread keybinding command - #4308

Open
jakeleventhal wants to merge 7 commits into
pingdotgg:mainfrom
jakeleventhal:t3code/add-stop-thread-keybinding
Open

Add stop thread keybinding command#4308
jakeleventhal wants to merge 7 commits into
pingdotgg:mainfrom
jakeleventhal:t3code/add-stop-thread-keybinding

Conversation

@jakeleventhal

@jakeleventhaljakeleventhal commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Summary

Screen.Recording.2026-07-22.at.4.36.45.PM.mov
  • add a typed thread.stop keybinding command without assigning a default shortcut
  • expose all static commands, including unbound ones, in the keybinding picker
  • route the command through the focused thread's existing turn-interrupt behavior

Testing

  • vp test run packages/contracts/src/keybindings.test.ts apps/web/src/keybindings.test.ts apps/web/src/components/settings/KeybindingsSettings.logic.test.ts (58 tests)
  • vp run typecheck in packages/contracts
  • vp run typecheck in apps/web
  • targeted vp fmt --check and vp lint for all changed files
  • integrated browser verification with a real running Codex turn and a custom thread.stop binding; the turn returned to ready with no active turn or error

Note

Add thread.stop keybinding command to interrupt running thread turns

  • Introduces buildRunningThreadTurnInterruptInput in ChatView.logic.ts, which returns a turn interrupt input only when both the current phase and thread session status are running; otherwise returns null
  • Updates ChatViewContent in ChatView.tsx to handle the thread.stop keybinding: it ignores auto-repeated keydowns, checks canInterruptRunningThread, and invokes interruptThreadTurn using the active thread's environmentId
  • Registers thread.stop in THREAD_KEYBINDING_COMMANDS in keybindings.ts so schemas and validators accept it; it is unassigned by default
  • Extends keybinding resolution context with previewFocus and previewOpen flags, allowing thread.stop (and other commands) to be conditionally guarded on preview state
  • Behavioral Change: the old onInterrupt always built input via buildThreadTurnInterruptInput using the environmentId prop; it now uses interruptContextRef and the active thread's environmentId, so interrupt requests target the currently active thread rather than a static prop

Macroscope summarized ee284b0.


Note

Medium Risk
New keyboard path can cancel in-flight agent turns; behavior is gated on running state but mis-bound shortcuts or when rules could still interrupt unexpectedly.

Overview
Adds a thread.stop keybinding command (typed in contracts, no default shortcut) so users can interrupt the active turn from the keyboard when they assign a binding in Settings.

ChatView handles thread.stop in the global keydown path: it only runs when buildRunningThreadTurnInterruptInput says the UI phase and thread session are both running (including before activeTurnId is projected), ignores key repeat, and calls the existing interruptThreadTurn flow with errors surfaced on the active thread. Turn-interrupt input building is tightened so a running session without a projected turn omits turnId instead of sending a stale id.

Shortcut resolution context now includes previewFocus and previewOpen, so custom when clauses can gate commands (including stop) on preview state. The keybinding picker is expected to list all static commands, not only ones with default bindings—thread.stop appears there but stays out of DEFAULT_RESOLVED_KEYBINDINGS.

User docs note that thread.stop is unassigned by default.

Reviewed by Cursor Bugbot for commit 2722997. Bugbot is set up for automated code reviews on this repo. Configure here.

@coderabbitai

coderabbitaiBot commented Jul 22, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 656f1296-54e7-490e-8b5a-242f03656535

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actionsgithub-actionsBot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:M 30-99 changed lines (additions + deletions). labels Jul 22, 2026
@jakeleventhal
jakeleventhal marked this pull request as ready for review July 22, 2026 20:40
Comment threadapps/web/src/components/ChatView.tsx
Comment threadapps/web/src/components/ChatView.tsx
@macroscopeapp

macroscopeappBot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at 2722997

Macroscope's review found this PR approvable — This is a small, opt-in keybinding that exposes an existing turn-interrupt action without changing default shortcuts or stored configuration behavior. The running-state guards, repeat handling, context support, and focused tests keep the production impact bounded.

You can add or adjust custom eligibility rules. Learn more.

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:7ae04963d6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadapps/web/src/components/ChatView.tsx

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:b98d4ac1e5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadapps/web/src/components/ChatView.tsx
Comment threadapps/web/src/components/ChatView.tsx Outdated
Comment threadpackages/contracts/src/keybindings.ts
Comment threadapps/web/src/components/ChatView.tsx
Comment threadapps/web/src/components/ChatView.tsx
@jakeleventhal
jakeleventhalforce-pushed the t3code/add-stop-thread-keybinding branch from 47f88dd to ef70decCompareAugust 10, 2026 20:28
Comment threadapps/web/src/components/ChatView.tsx
@t3dotggt3dotgg added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. and removed vouch:unvouched PR author is not yet trusted in the VOUCHED list. labels Aug 24, 2026
@jakeleventhal
jakeleventhalforce-pushed the t3code/add-stop-thread-keybinding branch from 28efa1f to 8944667CompareAugust 26, 2026 02:30
Comment threadapps/web/src/components/ChatView.tsx
@jakeleventhal
jakeleventhalforce-pushed the t3code/add-stop-thread-keybinding branch from 8944667 to ab07696CompareAugust 26, 2026 02:37
Comment threadapps/web/src/components/ChatView.tsx

@cursorcursorBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit ee284b0. Configure here.

Comment threadapps/web/src/components/ChatView.tsx
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M30-99 changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@jakeleventhal@t3dotgg
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

Add stop thread keybinding command - #4308

Open
jakeleventhal wants to merge 7 commits into
pingdotgg:mainfrom
jakeleventhal:t3code/add-stop-thread-keybinding
Open

Add stop thread keybinding command#4308
jakeleventhal wants to merge 7 commits into
pingdotgg:mainfrom
jakeleventhal:t3code/add-stop-thread-keybinding

Conversation

@jakeleventhal

@jakeleventhaljakeleventhal commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Summary

Screen.Recording.2026-07-22.at.4.36.45.PM.mov
  • add a typed thread.stop keybinding command without assigning a default shortcut
  • expose all static commands, including unbound ones, in the keybinding picker
  • route the command through the focused thread's existing turn-interrupt behavior

Testing

  • vp test run packages/contracts/src/keybindings.test.ts apps/web/src/keybindings.test.ts apps/web/src/components/settings/KeybindingsSettings.logic.test.ts (58 tests)
  • vp run typecheck in packages/contracts
  • vp run typecheck in apps/web
  • targeted vp fmt --check and vp lint for all changed files
  • integrated browser verification with a real running Codex turn and a custom thread.stop binding; the turn returned to ready with no active turn or error

Note

Add thread.stop keybinding command to interrupt running thread turns

  • Introduces buildRunningThreadTurnInterruptInput in ChatView.logic.ts, which returns a turn interrupt input only when both the current phase and thread session status are running; otherwise returns null
  • Updates ChatViewContent in ChatView.tsx to handle the thread.stop keybinding: it ignores auto-repeated keydowns, checks canInterruptRunningThread, and invokes interruptThreadTurn using the active thread's environmentId
  • Registers thread.stop in THREAD_KEYBINDING_COMMANDS in keybindings.ts so schemas and validators accept it; it is unassigned by default
  • Extends keybinding resolution context with previewFocus and previewOpen flags, allowing thread.stop (and other commands) to be conditionally guarded on preview state
  • Behavioral Change: the old onInterrupt always built input via buildThreadTurnInterruptInput using the environmentId prop; it now uses interruptContextRef and the active thread's environmentId, so interrupt requests target the currently active thread rather than a static prop

Macroscope summarized ee284b0.


Note

Medium Risk
New keyboard path can cancel in-flight agent turns; behavior is gated on running state but mis-bound shortcuts or when rules could still interrupt unexpectedly.

Overview
Adds a thread.stop keybinding command (typed in contracts, no default shortcut) so users can interrupt the active turn from the keyboard when they assign a binding in Settings.

ChatView handles thread.stop in the global keydown path: it only runs when buildRunningThreadTurnInterruptInput says the UI phase and thread session are both running (including before activeTurnId is projected), ignores key repeat, and calls the existing interruptThreadTurn flow with errors surfaced on the active thread. Turn-interrupt input building is tightened so a running session without a projected turn omits turnId instead of sending a stale id.

Shortcut resolution context now includes previewFocus and previewOpen, so custom when clauses can gate commands (including stop) on preview state. The keybinding picker is expected to list all static commands, not only ones with default bindings—thread.stop appears there but stays out of DEFAULT_RESOLVED_KEYBINDINGS.

User docs note that thread.stop is unassigned by default.

Reviewed by Cursor Bugbot for commit 2722997. Bugbot is set up for automated code reviews on this repo. Configure here.

@coderabbitai

coderabbitaiBot commented Jul 22, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 656f1296-54e7-490e-8b5a-242f03656535

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actionsgithub-actionsBot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:M 30-99 changed lines (additions + deletions). labels Jul 22, 2026
@jakeleventhal
jakeleventhal marked this pull request as ready for review July 22, 2026 20:40
Comment threadapps/web/src/components/ChatView.tsx
Comment threadapps/web/src/components/ChatView.tsx
@macroscopeapp

macroscopeappBot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at 2722997

Macroscope's review found this PR approvable — This is a small, opt-in keybinding that exposes an existing turn-interrupt action without changing default shortcuts or stored configuration behavior. The running-state guards, repeat handling, context support, and focused tests keep the production impact bounded.

You can add or adjust custom eligibility rules. Learn more.

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:7ae04963d6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadapps/web/src/components/ChatView.tsx

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:b98d4ac1e5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadapps/web/src/components/ChatView.tsx
Comment threadapps/web/src/components/ChatView.tsx Outdated
Comment threadpackages/contracts/src/keybindings.ts
Comment threadapps/web/src/components/ChatView.tsx
Comment threadapps/web/src/components/ChatView.tsx
@jakeleventhal
jakeleventhalforce-pushed the t3code/add-stop-thread-keybinding branch from 47f88dd to ef70decCompareAugust 10, 2026 20:28
Comment threadapps/web/src/components/ChatView.tsx
@t3dotggt3dotgg added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. and removed vouch:unvouched PR author is not yet trusted in the VOUCHED list. labels Aug 24, 2026
@jakeleventhal
jakeleventhalforce-pushed the t3code/add-stop-thread-keybinding branch from 28efa1f to 8944667CompareAugust 26, 2026 02:30
Comment threadapps/web/src/components/ChatView.tsx
@jakeleventhal
jakeleventhalforce-pushed the t3code/add-stop-thread-keybinding branch from 8944667 to ab07696CompareAugust 26, 2026 02:37
Comment threadapps/web/src/components/ChatView.tsx

@cursorcursorBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit ee284b0. Configure here.

Comment threadapps/web/src/components/ChatView.tsx
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M30-99 changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@jakeleventhal@t3dotgg