Fix session renaming bug by kridaydave · Pull Request #4558 · pingdotgg/t3code

kridaydave · 2026-07-26T05:23:08Z

Provider-emitted thread.metadata.updated events were unconditionally overwriting thread titles, reverting user custom renames and blocking auto-titling from working reliably.

The fix:

Guard provider title updates — only apply a provider's thread title when the current title is still the default "New thread" (checked via isDefaultThreadTitle)
Sanitize provider titles — strip control characters and truncate at 500 chars
Unify title policy — ProviderCommandReactor.canReplaceThreadTitle now delegates to the shared isDefaultThreadTitle instead of its own local constant
Tests — unit tests for isDefaultThreadTitle / sanitizeTitle, integration tests for default/custom/missing/empty title scenarios

Note

Medium Risk
Changes orchestration thread metadata behavior that users see in the UI, but the logic is narrowly scoped with clear guards and broad test coverage.

Overview
Fixes provider-driven session renaming by stopping thread.metadata.updated from overwriting user-chosen titles.

Provider title updates in runtime ingestion now run only when the current title is still the default ("New thread" via isDefaultThreadTitle), and the incoming name is passed through sanitizeTitle (control-character stripping, 500-char cap) before thread.meta.update is dispatched. Custom titles are left unchanged; empty or whitespace-only provider names are ignored.

Shared title helpers live in @t3tools/shared/threadTitle and replace the server’s local default constant in ProviderCommandReactor.canReplaceThreadTitle. Integration expectations were updated so a non-default harness title ("Thread") is not renamed by provider metadata; new tests cover default apply, custom reject, and missing/empty/sanitized-empty names.

^{Reviewed by Cursor Bugbot for commit acd29c4. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Fix session renaming bug by preventing providers from overwriting user-customized thread titles

Adds a shared threadTitle module (threadTitle.ts) exporting DEFAULT_THREAD_TITLE, isDefaultThreadTitle, and sanitizeTitle utilities.
Updates the thread.metadata.updated handler in ProviderRuntimeIngestion.ts to only apply provider-proposed names when the current thread title is the default; the proposed name is also sanitized before use.
Updates canReplaceThreadTitle in ProviderCommandReactor.ts to use isDefaultThreadTitle instead of a local constant.
Behavioral Change: Provider-driven renames are now silently ignored if the user has already set a custom title, or if the sanitized proposed name is empty.

^{Macroscope summarized acd29c4.}

- Guard provider thread.metadata.updated with isDefaultThreadTitle so user custom titles are not overwritten - Sanitize provider-supplied titles (length limit, strip control chars) - Unify DEFAULT_THREAD_TITLE policy across ingestion and command reactor - Add unit tests for threadTitle utilities and integration tests for edge cases

chatgpt-codex-connector · 2026-07-26T05:23:12Z

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

coderabbitai · 2026-07-26T05:23:16Z

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: f45fc325-e595-4add-ad83-c68a1a5937fc

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

macroscopeapp · 2026-07-26T05:26:48Z

Approvability

Verdict: Approved

Straightforward bug fix that prevents provider-initiated title updates from overwriting user-customized thread titles. The change is well-scoped, introduces simple utility functions, and includes comprehensive test coverage for the new behavior.

^{You can customize Macroscope's approvability policy. Learn more.}

Extract renderThreadLeadingContent and renderThreadTrailingContent out of OpenCommandPaletteDialog to satisfy react/no-unstable-nested-components.

Compute the sanitized title first and dispatch only when non-empty. Otherwise whitespace-only provider names become an empty thread title that permanently blocks future updates.

Use a callback-based replace instead of a control-character regex pattern to satisfy oxlint's eslint(no-control-regex) rule.

Dismissing prior approval to re-evaluate 791f6f2

Convert new tests from it() with Effect.runPromise to effectIt.effect with Effect.gen to satisfy the custom rule.

Dismissing prior approval to re-evaluate acd29c4

kridaydave · 2026-07-26T05:43:53Z

Sorry for the extreme commits :3

…tgg#4558) Imported from https://github.com/pingdotgg/t3code/pull/4558\n\nAdapted to retain our provider restart-recovery constants while replacing the local default-title check with the shared policy.

juliusmarminge · 2026-07-30T15:37:30Z

Closing in favor of #2829 (orchestration V2).

#2829 deletes the V1 orchestration layer this PR builds on — apps/server/src/orchestration/**, provider/Layers/*Adapter.ts and provider/Services/** are removed and replaced by apps/server/src/orchestration-v2/**, with the IPC surface renamed to ORCHESTRATION_V2_WS_METHODS. The files this PR touches either no longer exist or are rewritten, so it can't be rebased — it would need reimplementing against the V2 adapters.

This is not a judgement on the change itself. Several of these are real gaps we still want fixed; the base just moved out from under them.

Once #2829 merges, please rebase onto main, port the change to the V2 equivalent, and reopen (or open a fresh PR). Ping me and I'll prioritise the review.

…tgg#4558) Imported from https://github.com/pingdotgg/t3code/pull/4558\n\nAdapted to retain our provider restart-recovery constants while replacing the local default-title check with the shared policy.

kridaydave · 2026-07-26T05:23:08Z

Provider-emitted thread.metadata.updated events were unconditionally overwriting thread titles, reverting user custom renames and blocking auto-titling from working reliably.

The fix:

Guard provider title updates — only apply a provider's thread title when the current title is still the default "New thread" (checked via isDefaultThreadTitle)
Sanitize provider titles — strip control characters and truncate at 500 chars
Unify title policy — ProviderCommandReactor.canReplaceThreadTitle now delegates to the shared isDefaultThreadTitle instead of its own local constant
Tests — unit tests for isDefaultThreadTitle / sanitizeTitle, integration tests for default/custom/missing/empty title scenarios

Note

Medium Risk
Changes orchestration thread metadata behavior that users see in the UI, but the logic is narrowly scoped with clear guards and broad test coverage.

Overview
Fixes provider-driven session renaming by stopping thread.metadata.updated from overwriting user-chosen titles.

Provider title updates in runtime ingestion now run only when the current title is still the default ("New thread" via isDefaultThreadTitle), and the incoming name is passed through sanitizeTitle (control-character stripping, 500-char cap) before thread.meta.update is dispatched. Custom titles are left unchanged; empty or whitespace-only provider names are ignored.

Shared title helpers live in @t3tools/shared/threadTitle and replace the server’s local default constant in ProviderCommandReactor.canReplaceThreadTitle. Integration expectations were updated so a non-default harness title ("Thread") is not renamed by provider metadata; new tests cover default apply, custom reject, and missing/empty/sanitized-empty names.

^{Reviewed by Cursor Bugbot for commit acd29c4. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Fix session renaming bug by preventing providers from overwriting user-customized thread titles

Adds a shared threadTitle module (threadTitle.ts) exporting DEFAULT_THREAD_TITLE, isDefaultThreadTitle, and sanitizeTitle utilities.
Updates the thread.metadata.updated handler in ProviderRuntimeIngestion.ts to only apply provider-proposed names when the current thread title is the default; the proposed name is also sanitized before use.
Updates canReplaceThreadTitle in ProviderCommandReactor.ts to use isDefaultThreadTitle instead of a local constant.
Behavioral Change: Provider-driven renames are now silently ignored if the user has already set a custom title, or if the sanitized proposed name is empty.

^{Macroscope summarized acd29c4.}

- Guard provider thread.metadata.updated with isDefaultThreadTitle so user custom titles are not overwritten - Sanitize provider-supplied titles (length limit, strip control chars) - Unify DEFAULT_THREAD_TITLE policy across ingestion and command reactor - Add unit tests for threadTitle utilities and integration tests for edge cases

chatgpt-codex-connector · 2026-07-26T05:23:12Z

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

coderabbitai · 2026-07-26T05:23:16Z

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: f45fc325-e595-4add-ad83-c68a1a5937fc

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

macroscopeapp · 2026-07-26T05:26:48Z

Approvability

Verdict: Approved

Straightforward bug fix that prevents provider-initiated title updates from overwriting user-customized thread titles. The change is well-scoped, introduces simple utility functions, and includes comprehensive test coverage for the new behavior.

^{You can customize Macroscope's approvability policy. Learn more.}

Extract renderThreadLeadingContent and renderThreadTrailingContent out of OpenCommandPaletteDialog to satisfy react/no-unstable-nested-components.

Compute the sanitized title first and dispatch only when non-empty. Otherwise whitespace-only provider names become an empty thread title that permanently blocks future updates.

Use a callback-based replace instead of a control-character regex pattern to satisfy oxlint's eslint(no-control-regex) rule.

Dismissing prior approval to re-evaluate 791f6f2

Convert new tests from it() with Effect.runPromise to effectIt.effect with Effect.gen to satisfy the custom rule.

Dismissing prior approval to re-evaluate acd29c4

kridaydave · 2026-07-26T05:43:53Z

Sorry for the extreme commits :3

…tgg#4558) Imported from https://github.com/pingdotgg/t3code/pull/4558\n\nAdapted to retain our provider restart-recovery constants while replacing the local default-title check with the shared policy.

juliusmarminge · 2026-07-30T15:37:30Z

Closing in favor of #2829 (orchestration V2).

#2829 deletes the V1 orchestration layer this PR builds on — apps/server/src/orchestration/**, provider/Layers/*Adapter.ts and provider/Services/** are removed and replaced by apps/server/src/orchestration-v2/**, with the IPC surface renamed to ORCHESTRATION_V2_WS_METHODS. The files this PR touches either no longer exist or are rewritten, so it can't be rebased — it would need reimplementing against the V2 adapters.

This is not a judgement on the change itself. Several of these are real gaps we still want fixed; the base just moved out from under them.

Once #2829 merges, please rebase onto main, port the change to the V2 equivalent, and reopen (or open a fresh PR). Ping me and I'll prioritise the review.

…tgg#4558) Imported from https://github.com/pingdotgg/t3code/pull/4558\n\nAdapted to retain our provider restart-recovery constants while replacing the local default-title check with the shared policy.

kridaydave · 2026-07-26T05:23:08Z

Provider-emitted thread.metadata.updated events were unconditionally overwriting thread titles, reverting user custom renames and blocking auto-titling from working reliably.

The fix:

Guard provider title updates — only apply a provider's thread title when the current title is still the default "New thread" (checked via isDefaultThreadTitle)
Sanitize provider titles — strip control characters and truncate at 500 chars
Unify title policy — ProviderCommandReactor.canReplaceThreadTitle now delegates to the shared isDefaultThreadTitle instead of its own local constant
Tests — unit tests for isDefaultThreadTitle / sanitizeTitle, integration tests for default/custom/missing/empty title scenarios

Note

Medium Risk
Changes orchestration thread metadata behavior that users see in the UI, but the logic is narrowly scoped with clear guards and broad test coverage.

Overview
Fixes provider-driven session renaming by stopping thread.metadata.updated from overwriting user-chosen titles.

Provider title updates in runtime ingestion now run only when the current title is still the default ("New thread" via isDefaultThreadTitle), and the incoming name is passed through sanitizeTitle (control-character stripping, 500-char cap) before thread.meta.update is dispatched. Custom titles are left unchanged; empty or whitespace-only provider names are ignored.

Shared title helpers live in @t3tools/shared/threadTitle and replace the server’s local default constant in ProviderCommandReactor.canReplaceThreadTitle. Integration expectations were updated so a non-default harness title ("Thread") is not renamed by provider metadata; new tests cover default apply, custom reject, and missing/empty/sanitized-empty names.

^{Reviewed by Cursor Bugbot for commit acd29c4. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Fix session renaming bug by preventing providers from overwriting user-customized thread titles

Adds a shared threadTitle module (threadTitle.ts) exporting DEFAULT_THREAD_TITLE, isDefaultThreadTitle, and sanitizeTitle utilities.
Updates the thread.metadata.updated handler in ProviderRuntimeIngestion.ts to only apply provider-proposed names when the current thread title is the default; the proposed name is also sanitized before use.
Updates canReplaceThreadTitle in ProviderCommandReactor.ts to use isDefaultThreadTitle instead of a local constant.
Behavioral Change: Provider-driven renames are now silently ignored if the user has already set a custom title, or if the sanitized proposed name is empty.

^{Macroscope summarized acd29c4.}

- Guard provider thread.metadata.updated with isDefaultThreadTitle so user custom titles are not overwritten - Sanitize provider-supplied titles (length limit, strip control chars) - Unify DEFAULT_THREAD_TITLE policy across ingestion and command reactor - Add unit tests for threadTitle utilities and integration tests for edge cases

chatgpt-codex-connector · 2026-07-26T05:23:12Z

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

coderabbitai · 2026-07-26T05:23:16Z

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: f45fc325-e595-4add-ad83-c68a1a5937fc

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

macroscopeapp · 2026-07-26T05:26:48Z

Approvability

Verdict: Approved

Straightforward bug fix that prevents provider-initiated title updates from overwriting user-customized thread titles. The change is well-scoped, introduces simple utility functions, and includes comprehensive test coverage for the new behavior.

^{You can customize Macroscope's approvability policy. Learn more.}

Extract renderThreadLeadingContent and renderThreadTrailingContent out of OpenCommandPaletteDialog to satisfy react/no-unstable-nested-components.

Compute the sanitized title first and dispatch only when non-empty. Otherwise whitespace-only provider names become an empty thread title that permanently blocks future updates.

Use a callback-based replace instead of a control-character regex pattern to satisfy oxlint's eslint(no-control-regex) rule.

Dismissing prior approval to re-evaluate 791f6f2

Convert new tests from it() with Effect.runPromise to effectIt.effect with Effect.gen to satisfy the custom rule.

Dismissing prior approval to re-evaluate acd29c4

kridaydave · 2026-07-26T05:43:53Z

Sorry for the extreme commits :3

…tgg#4558) Imported from https://github.com/pingdotgg/t3code/pull/4558\n\nAdapted to retain our provider restart-recovery constants while replacing the local default-title check with the shared policy.

juliusmarminge · 2026-07-30T15:37:30Z

Closing in favor of #2829 (orchestration V2).

#2829 deletes the V1 orchestration layer this PR builds on — apps/server/src/orchestration/**, provider/Layers/*Adapter.ts and provider/Services/** are removed and replaced by apps/server/src/orchestration-v2/**, with the IPC surface renamed to ORCHESTRATION_V2_WS_METHODS. The files this PR touches either no longer exist or are rewritten, so it can't be rebased — it would need reimplementing against the V2 adapters.

This is not a judgement on the change itself. Several of these are real gaps we still want fixed; the base just moved out from under them.

Once #2829 merges, please rebase onto main, port the change to the V2 equivalent, and reopen (or open a fresh PR). Ping me and I'll prioritise the review.

…tgg#4558) Imported from https://github.com/pingdotgg/t3code/pull/4558\n\nAdapted to retain our provider restart-recovery constants while replacing the local default-title check with the shared policy.

kridaydave · 2026-07-26T05:23:08Z

Provider-emitted thread.metadata.updated events were unconditionally overwriting thread titles, reverting user custom renames and blocking auto-titling from working reliably.

The fix:

Guard provider title updates — only apply a provider's thread title when the current title is still the default "New thread" (checked via isDefaultThreadTitle)
Sanitize provider titles — strip control characters and truncate at 500 chars
Unify title policy — ProviderCommandReactor.canReplaceThreadTitle now delegates to the shared isDefaultThreadTitle instead of its own local constant
Tests — unit tests for isDefaultThreadTitle / sanitizeTitle, integration tests for default/custom/missing/empty title scenarios

Note

Medium Risk
Changes orchestration thread metadata behavior that users see in the UI, but the logic is narrowly scoped with clear guards and broad test coverage.

Overview
Fixes provider-driven session renaming by stopping thread.metadata.updated from overwriting user-chosen titles.

Provider title updates in runtime ingestion now run only when the current title is still the default ("New thread" via isDefaultThreadTitle), and the incoming name is passed through sanitizeTitle (control-character stripping, 500-char cap) before thread.meta.update is dispatched. Custom titles are left unchanged; empty or whitespace-only provider names are ignored.

Shared title helpers live in @t3tools/shared/threadTitle and replace the server’s local default constant in ProviderCommandReactor.canReplaceThreadTitle. Integration expectations were updated so a non-default harness title ("Thread") is not renamed by provider metadata; new tests cover default apply, custom reject, and missing/empty/sanitized-empty names.

^{Reviewed by Cursor Bugbot for commit acd29c4. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Fix session renaming bug by preventing providers from overwriting user-customized thread titles

Adds a shared threadTitle module (threadTitle.ts) exporting DEFAULT_THREAD_TITLE, isDefaultThreadTitle, and sanitizeTitle utilities.
Updates the thread.metadata.updated handler in ProviderRuntimeIngestion.ts to only apply provider-proposed names when the current thread title is the default; the proposed name is also sanitized before use.
Updates canReplaceThreadTitle in ProviderCommandReactor.ts to use isDefaultThreadTitle instead of a local constant.
Behavioral Change: Provider-driven renames are now silently ignored if the user has already set a custom title, or if the sanitized proposed name is empty.

^{Macroscope summarized acd29c4.}

- Guard provider thread.metadata.updated with isDefaultThreadTitle so user custom titles are not overwritten - Sanitize provider-supplied titles (length limit, strip control chars) - Unify DEFAULT_THREAD_TITLE policy across ingestion and command reactor - Add unit tests for threadTitle utilities and integration tests for edge cases

chatgpt-codex-connector · 2026-07-26T05:23:12Z

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

coderabbitai · 2026-07-26T05:23:16Z

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: f45fc325-e595-4add-ad83-c68a1a5937fc

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

macroscopeapp · 2026-07-26T05:26:48Z

Approvability

Verdict: Approved

Straightforward bug fix that prevents provider-initiated title updates from overwriting user-customized thread titles. The change is well-scoped, introduces simple utility functions, and includes comprehensive test coverage for the new behavior.

^{You can customize Macroscope's approvability policy. Learn more.}

Extract renderThreadLeadingContent and renderThreadTrailingContent out of OpenCommandPaletteDialog to satisfy react/no-unstable-nested-components.

Compute the sanitized title first and dispatch only when non-empty. Otherwise whitespace-only provider names become an empty thread title that permanently blocks future updates.

Use a callback-based replace instead of a control-character regex pattern to satisfy oxlint's eslint(no-control-regex) rule.

Dismissing prior approval to re-evaluate 791f6f2

Convert new tests from it() with Effect.runPromise to effectIt.effect with Effect.gen to satisfy the custom rule.

Dismissing prior approval to re-evaluate acd29c4

kridaydave · 2026-07-26T05:43:53Z

Sorry for the extreme commits :3

…tgg#4558) Imported from https://github.com/pingdotgg/t3code/pull/4558\n\nAdapted to retain our provider restart-recovery constants while replacing the local default-title check with the shared policy.

juliusmarminge · 2026-07-30T15:37:30Z

Closing in favor of #2829 (orchestration V2).

#2829 deletes the V1 orchestration layer this PR builds on — apps/server/src/orchestration/**, provider/Layers/*Adapter.ts and provider/Services/** are removed and replaced by apps/server/src/orchestration-v2/**, with the IPC surface renamed to ORCHESTRATION_V2_WS_METHODS. The files this PR touches either no longer exist or are rewritten, so it can't be rebased — it would need reimplementing against the V2 adapters.

This is not a judgement on the change itself. Several of these are real gaps we still want fixed; the base just moved out from under them.

Once #2829 merges, please rebase onto main, port the change to the V2 equivalent, and reopen (or open a fresh PR). Ping me and I'll prioritise the review.

…tgg#4558) Imported from https://github.com/pingdotgg/t3code/pull/4558\n\nAdapted to retain our provider restart-recovery constants while replacing the local default-title check with the shared policy.

kridaydave · 2026-07-26T05:23:08Z

Provider-emitted thread.metadata.updated events were unconditionally overwriting thread titles, reverting user custom renames and blocking auto-titling from working reliably.

The fix:

Guard provider title updates — only apply a provider's thread title when the current title is still the default "New thread" (checked via isDefaultThreadTitle)
Sanitize provider titles — strip control characters and truncate at 500 chars
Unify title policy — ProviderCommandReactor.canReplaceThreadTitle now delegates to the shared isDefaultThreadTitle instead of its own local constant
Tests — unit tests for isDefaultThreadTitle / sanitizeTitle, integration tests for default/custom/missing/empty title scenarios

Note

Medium Risk
Changes orchestration thread metadata behavior that users see in the UI, but the logic is narrowly scoped with clear guards and broad test coverage.

Overview
Fixes provider-driven session renaming by stopping thread.metadata.updated from overwriting user-chosen titles.

Provider title updates in runtime ingestion now run only when the current title is still the default ("New thread" via isDefaultThreadTitle), and the incoming name is passed through sanitizeTitle (control-character stripping, 500-char cap) before thread.meta.update is dispatched. Custom titles are left unchanged; empty or whitespace-only provider names are ignored.

Shared title helpers live in @t3tools/shared/threadTitle and replace the server’s local default constant in ProviderCommandReactor.canReplaceThreadTitle. Integration expectations were updated so a non-default harness title ("Thread") is not renamed by provider metadata; new tests cover default apply, custom reject, and missing/empty/sanitized-empty names.

^{Reviewed by Cursor Bugbot for commit acd29c4. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Fix session renaming bug by preventing providers from overwriting user-customized thread titles

Adds a shared threadTitle module (threadTitle.ts) exporting DEFAULT_THREAD_TITLE, isDefaultThreadTitle, and sanitizeTitle utilities.
Updates the thread.metadata.updated handler in ProviderRuntimeIngestion.ts to only apply provider-proposed names when the current thread title is the default; the proposed name is also sanitized before use.
Updates canReplaceThreadTitle in ProviderCommandReactor.ts to use isDefaultThreadTitle instead of a local constant.
Behavioral Change: Provider-driven renames are now silently ignored if the user has already set a custom title, or if the sanitized proposed name is empty.

^{Macroscope summarized acd29c4.}

- Guard provider thread.metadata.updated with isDefaultThreadTitle so user custom titles are not overwritten - Sanitize provider-supplied titles (length limit, strip control chars) - Unify DEFAULT_THREAD_TITLE policy across ingestion and command reactor - Add unit tests for threadTitle utilities and integration tests for edge cases

chatgpt-codex-connector · 2026-07-26T05:23:12Z

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

coderabbitai · 2026-07-26T05:23:16Z

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: f45fc325-e595-4add-ad83-c68a1a5937fc

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

macroscopeapp · 2026-07-26T05:26:48Z

Approvability

Verdict: Approved

Straightforward bug fix that prevents provider-initiated title updates from overwriting user-customized thread titles. The change is well-scoped, introduces simple utility functions, and includes comprehensive test coverage for the new behavior.

^{You can customize Macroscope's approvability policy. Learn more.}

Extract renderThreadLeadingContent and renderThreadTrailingContent out of OpenCommandPaletteDialog to satisfy react/no-unstable-nested-components.

Compute the sanitized title first and dispatch only when non-empty. Otherwise whitespace-only provider names become an empty thread title that permanently blocks future updates.

Use a callback-based replace instead of a control-character regex pattern to satisfy oxlint's eslint(no-control-regex) rule.

Dismissing prior approval to re-evaluate 791f6f2

Convert new tests from it() with Effect.runPromise to effectIt.effect with Effect.gen to satisfy the custom rule.

Dismissing prior approval to re-evaluate acd29c4

kridaydave · 2026-07-26T05:43:53Z

Sorry for the extreme commits :3

…tgg#4558) Imported from https://github.com/pingdotgg/t3code/pull/4558\n\nAdapted to retain our provider restart-recovery constants while replacing the local default-title check with the shared policy.

juliusmarminge · 2026-07-30T15:37:30Z

Closing in favor of #2829 (orchestration V2).

#2829 deletes the V1 orchestration layer this PR builds on — apps/server/src/orchestration/**, provider/Layers/*Adapter.ts and provider/Services/** are removed and replaced by apps/server/src/orchestration-v2/**, with the IPC surface renamed to ORCHESTRATION_V2_WS_METHODS. The files this PR touches either no longer exist or are rewritten, so it can't be rebased — it would need reimplementing against the V2 adapters.

This is not a judgement on the change itself. Several of these are real gaps we still want fixed; the base just moved out from under them.

Once #2829 merges, please rebase onto main, port the change to the V2 equivalent, and reopen (or open a fresh PR). Ping me and I'll prioritise the review.

…tgg#4558) Imported from https://github.com/pingdotgg/t3code/pull/4558\n\nAdapted to retain our provider restart-recovery constants while replacing the local default-title check with the shared policy.

kridaydave · 2026-07-26T05:23:08Z

Provider-emitted thread.metadata.updated events were unconditionally overwriting thread titles, reverting user custom renames and blocking auto-titling from working reliably.

The fix:

Guard provider title updates — only apply a provider's thread title when the current title is still the default "New thread" (checked via isDefaultThreadTitle)
Sanitize provider titles — strip control characters and truncate at 500 chars
Unify title policy — ProviderCommandReactor.canReplaceThreadTitle now delegates to the shared isDefaultThreadTitle instead of its own local constant
Tests — unit tests for isDefaultThreadTitle / sanitizeTitle, integration tests for default/custom/missing/empty title scenarios

Note

Medium Risk
Changes orchestration thread metadata behavior that users see in the UI, but the logic is narrowly scoped with clear guards and broad test coverage.

Overview
Fixes provider-driven session renaming by stopping thread.metadata.updated from overwriting user-chosen titles.

Provider title updates in runtime ingestion now run only when the current title is still the default ("New thread" via isDefaultThreadTitle), and the incoming name is passed through sanitizeTitle (control-character stripping, 500-char cap) before thread.meta.update is dispatched. Custom titles are left unchanged; empty or whitespace-only provider names are ignored.

Shared title helpers live in @t3tools/shared/threadTitle and replace the server’s local default constant in ProviderCommandReactor.canReplaceThreadTitle. Integration expectations were updated so a non-default harness title ("Thread") is not renamed by provider metadata; new tests cover default apply, custom reject, and missing/empty/sanitized-empty names.

^{Reviewed by Cursor Bugbot for commit acd29c4. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Fix session renaming bug by preventing providers from overwriting user-customized thread titles

Adds a shared threadTitle module (threadTitle.ts) exporting DEFAULT_THREAD_TITLE, isDefaultThreadTitle, and sanitizeTitle utilities.
Updates the thread.metadata.updated handler in ProviderRuntimeIngestion.ts to only apply provider-proposed names when the current thread title is the default; the proposed name is also sanitized before use.
Updates canReplaceThreadTitle in ProviderCommandReactor.ts to use isDefaultThreadTitle instead of a local constant.
Behavioral Change: Provider-driven renames are now silently ignored if the user has already set a custom title, or if the sanitized proposed name is empty.

^{Macroscope summarized acd29c4.}

- Guard provider thread.metadata.updated with isDefaultThreadTitle so user custom titles are not overwritten - Sanitize provider-supplied titles (length limit, strip control chars) - Unify DEFAULT_THREAD_TITLE policy across ingestion and command reactor - Add unit tests for threadTitle utilities and integration tests for edge cases

chatgpt-codex-connector · 2026-07-26T05:23:12Z

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

coderabbitai · 2026-07-26T05:23:16Z

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: f45fc325-e595-4add-ad83-c68a1a5937fc

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

macroscopeapp · 2026-07-26T05:26:48Z

Approvability

Verdict: Approved

Straightforward bug fix that prevents provider-initiated title updates from overwriting user-customized thread titles. The change is well-scoped, introduces simple utility functions, and includes comprehensive test coverage for the new behavior.

^{You can customize Macroscope's approvability policy. Learn more.}

Extract renderThreadLeadingContent and renderThreadTrailingContent out of OpenCommandPaletteDialog to satisfy react/no-unstable-nested-components.

Compute the sanitized title first and dispatch only when non-empty. Otherwise whitespace-only provider names become an empty thread title that permanently blocks future updates.

Use a callback-based replace instead of a control-character regex pattern to satisfy oxlint's eslint(no-control-regex) rule.

Dismissing prior approval to re-evaluate 791f6f2

Convert new tests from it() with Effect.runPromise to effectIt.effect with Effect.gen to satisfy the custom rule.

Dismissing prior approval to re-evaluate acd29c4

kridaydave · 2026-07-26T05:43:53Z

Sorry for the extreme commits :3

…tgg#4558) Imported from https://github.com/pingdotgg/t3code/pull/4558\n\nAdapted to retain our provider restart-recovery constants while replacing the local default-title check with the shared policy.

juliusmarminge · 2026-07-30T15:37:30Z

Closing in favor of #2829 (orchestration V2).

#2829 deletes the V1 orchestration layer this PR builds on — apps/server/src/orchestration/**, provider/Layers/*Adapter.ts and provider/Services/** are removed and replaced by apps/server/src/orchestration-v2/**, with the IPC surface renamed to ORCHESTRATION_V2_WS_METHODS. The files this PR touches either no longer exist or are rewritten, so it can't be rebased — it would need reimplementing against the V2 adapters.

This is not a judgement on the change itself. Several of these are real gaps we still want fixed; the base just moved out from under them.

Once #2829 merges, please rebase onto main, port the change to the V2 equivalent, and reopen (or open a fresh PR). Ping me and I'll prioritise the review.

…tgg#4558) Imported from https://github.com/pingdotgg/t3code/pull/4558\n\nAdapted to retain our provider restart-recovery constants while replacing the local default-title check with the shared policy.

kridaydave · 2026-07-26T05:23:08Z

Provider-emitted thread.metadata.updated events were unconditionally overwriting thread titles, reverting user custom renames and blocking auto-titling from working reliably.

The fix:

Guard provider title updates — only apply a provider's thread title when the current title is still the default "New thread" (checked via isDefaultThreadTitle)
Sanitize provider titles — strip control characters and truncate at 500 chars
Unify title policy — ProviderCommandReactor.canReplaceThreadTitle now delegates to the shared isDefaultThreadTitle instead of its own local constant
Tests — unit tests for isDefaultThreadTitle / sanitizeTitle, integration tests for default/custom/missing/empty title scenarios

Note

Medium Risk
Changes orchestration thread metadata behavior that users see in the UI, but the logic is narrowly scoped with clear guards and broad test coverage.

Overview
Fixes provider-driven session renaming by stopping thread.metadata.updated from overwriting user-chosen titles.

Provider title updates in runtime ingestion now run only when the current title is still the default ("New thread" via isDefaultThreadTitle), and the incoming name is passed through sanitizeTitle (control-character stripping, 500-char cap) before thread.meta.update is dispatched. Custom titles are left unchanged; empty or whitespace-only provider names are ignored.

Shared title helpers live in @t3tools/shared/threadTitle and replace the server’s local default constant in ProviderCommandReactor.canReplaceThreadTitle. Integration expectations were updated so a non-default harness title ("Thread") is not renamed by provider metadata; new tests cover default apply, custom reject, and missing/empty/sanitized-empty names.

^{Reviewed by Cursor Bugbot for commit acd29c4. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Fix session renaming bug by preventing providers from overwriting user-customized thread titles

Adds a shared threadTitle module (threadTitle.ts) exporting DEFAULT_THREAD_TITLE, isDefaultThreadTitle, and sanitizeTitle utilities.
Updates the thread.metadata.updated handler in ProviderRuntimeIngestion.ts to only apply provider-proposed names when the current thread title is the default; the proposed name is also sanitized before use.
Updates canReplaceThreadTitle in ProviderCommandReactor.ts to use isDefaultThreadTitle instead of a local constant.
Behavioral Change: Provider-driven renames are now silently ignored if the user has already set a custom title, or if the sanitized proposed name is empty.

^{Macroscope summarized acd29c4.}

- Guard provider thread.metadata.updated with isDefaultThreadTitle so user custom titles are not overwritten - Sanitize provider-supplied titles (length limit, strip control chars) - Unify DEFAULT_THREAD_TITLE policy across ingestion and command reactor - Add unit tests for threadTitle utilities and integration tests for edge cases

chatgpt-codex-connector · 2026-07-26T05:23:12Z

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

coderabbitai · 2026-07-26T05:23:16Z

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: f45fc325-e595-4add-ad83-c68a1a5937fc

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

macroscopeapp · 2026-07-26T05:26:48Z

Approvability

Verdict: Approved

Straightforward bug fix that prevents provider-initiated title updates from overwriting user-customized thread titles. The change is well-scoped, introduces simple utility functions, and includes comprehensive test coverage for the new behavior.

^{You can customize Macroscope's approvability policy. Learn more.}

Extract renderThreadLeadingContent and renderThreadTrailingContent out of OpenCommandPaletteDialog to satisfy react/no-unstable-nested-components.

Compute the sanitized title first and dispatch only when non-empty. Otherwise whitespace-only provider names become an empty thread title that permanently blocks future updates.

Use a callback-based replace instead of a control-character regex pattern to satisfy oxlint's eslint(no-control-regex) rule.

Dismissing prior approval to re-evaluate 791f6f2

Convert new tests from it() with Effect.runPromise to effectIt.effect with Effect.gen to satisfy the custom rule.

Dismissing prior approval to re-evaluate acd29c4

kridaydave · 2026-07-26T05:43:53Z

Sorry for the extreme commits :3

…tgg#4558) Imported from https://github.com/pingdotgg/t3code/pull/4558\n\nAdapted to retain our provider restart-recovery constants while replacing the local default-title check with the shared policy.

juliusmarminge · 2026-07-30T15:37:30Z

Closing in favor of #2829 (orchestration V2).

#2829 deletes the V1 orchestration layer this PR builds on — apps/server/src/orchestration/**, provider/Layers/*Adapter.ts and provider/Services/** are removed and replaced by apps/server/src/orchestration-v2/**, with the IPC surface renamed to ORCHESTRATION_V2_WS_METHODS. The files this PR touches either no longer exist or are rewritten, so it can't be rebased — it would need reimplementing against the V2 adapters.

This is not a judgement on the change itself. Several of these are real gaps we still want fixed; the base just moved out from under them.

Once #2829 merges, please rebase onto main, port the change to the V2 equivalent, and reopen (or open a fresh PR). Ping me and I'll prioritise the review.

…tgg#4558) Imported from https://github.com/pingdotgg/t3code/pull/4558\n\nAdapted to retain our provider restart-recovery constants while replacing the local default-title check with the shared policy.

kridaydave · 2026-07-26T05:23:08Z

Provider-emitted thread.metadata.updated events were unconditionally overwriting thread titles, reverting user custom renames and blocking auto-titling from working reliably.

The fix:

Guard provider title updates — only apply a provider's thread title when the current title is still the default "New thread" (checked via isDefaultThreadTitle)
Sanitize provider titles — strip control characters and truncate at 500 chars
Unify title policy — ProviderCommandReactor.canReplaceThreadTitle now delegates to the shared isDefaultThreadTitle instead of its own local constant
Tests — unit tests for isDefaultThreadTitle / sanitizeTitle, integration tests for default/custom/missing/empty title scenarios

Note

Medium Risk
Changes orchestration thread metadata behavior that users see in the UI, but the logic is narrowly scoped with clear guards and broad test coverage.

Overview
Fixes provider-driven session renaming by stopping thread.metadata.updated from overwriting user-chosen titles.

Provider title updates in runtime ingestion now run only when the current title is still the default ("New thread" via isDefaultThreadTitle), and the incoming name is passed through sanitizeTitle (control-character stripping, 500-char cap) before thread.meta.update is dispatched. Custom titles are left unchanged; empty or whitespace-only provider names are ignored.

Shared title helpers live in @t3tools/shared/threadTitle and replace the server’s local default constant in ProviderCommandReactor.canReplaceThreadTitle. Integration expectations were updated so a non-default harness title ("Thread") is not renamed by provider metadata; new tests cover default apply, custom reject, and missing/empty/sanitized-empty names.

^{Reviewed by Cursor Bugbot for commit acd29c4. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Fix session renaming bug by preventing providers from overwriting user-customized thread titles

Adds a shared threadTitle module (threadTitle.ts) exporting DEFAULT_THREAD_TITLE, isDefaultThreadTitle, and sanitizeTitle utilities.
Updates the thread.metadata.updated handler in ProviderRuntimeIngestion.ts to only apply provider-proposed names when the current thread title is the default; the proposed name is also sanitized before use.
Updates canReplaceThreadTitle in ProviderCommandReactor.ts to use isDefaultThreadTitle instead of a local constant.
Behavioral Change: Provider-driven renames are now silently ignored if the user has already set a custom title, or if the sanitized proposed name is empty.

^{Macroscope summarized acd29c4.}

- Guard provider thread.metadata.updated with isDefaultThreadTitle so user custom titles are not overwritten - Sanitize provider-supplied titles (length limit, strip control chars) - Unify DEFAULT_THREAD_TITLE policy across ingestion and command reactor - Add unit tests for threadTitle utilities and integration tests for edge cases

chatgpt-codex-connector · 2026-07-26T05:23:12Z

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

coderabbitai · 2026-07-26T05:23:16Z

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: f45fc325-e595-4add-ad83-c68a1a5937fc

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

macroscopeapp · 2026-07-26T05:26:48Z

Approvability

Verdict: Approved

Straightforward bug fix that prevents provider-initiated title updates from overwriting user-customized thread titles. The change is well-scoped, introduces simple utility functions, and includes comprehensive test coverage for the new behavior.

^{You can customize Macroscope's approvability policy. Learn more.}

Extract renderThreadLeadingContent and renderThreadTrailingContent out of OpenCommandPaletteDialog to satisfy react/no-unstable-nested-components.

Compute the sanitized title first and dispatch only when non-empty. Otherwise whitespace-only provider names become an empty thread title that permanently blocks future updates.

Use a callback-based replace instead of a control-character regex pattern to satisfy oxlint's eslint(no-control-regex) rule.

Dismissing prior approval to re-evaluate 791f6f2

Convert new tests from it() with Effect.runPromise to effectIt.effect with Effect.gen to satisfy the custom rule.

Dismissing prior approval to re-evaluate acd29c4

kridaydave · 2026-07-26T05:43:53Z

Sorry for the extreme commits :3

…tgg#4558) Imported from https://github.com/pingdotgg/t3code/pull/4558\n\nAdapted to retain our provider restart-recovery constants while replacing the local default-title check with the shared policy.

juliusmarminge · 2026-07-30T15:37:30Z

Closing in favor of #2829 (orchestration V2).

#2829 deletes the V1 orchestration layer this PR builds on — apps/server/src/orchestration/**, provider/Layers/*Adapter.ts and provider/Services/** are removed and replaced by apps/server/src/orchestration-v2/**, with the IPC surface renamed to ORCHESTRATION_V2_WS_METHODS. The files this PR touches either no longer exist or are rewritten, so it can't be rebased — it would need reimplementing against the V2 adapters.

This is not a judgement on the change itself. Several of these are real gaps we still want fixed; the base just moved out from under them.

Once #2829 merges, please rebase onto main, port the change to the V2 equivalent, and reopen (or open a fresh PR). Ping me and I'll prioritise the review.

…tgg#4558) Imported from https://github.com/pingdotgg/t3code/pull/4558\n\nAdapted to retain our provider restart-recovery constants while replacing the local default-title check with the shared policy.

github-actionsBot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:M 30-99 changed lines (additions + deletions). labels Jul 26, 2026

macroscopeappBot reviewed Jul 26, 2026
View reviewed changes

Comment threadpackages/shared/src/threadTitle.ts

kridaydave added 2 commits July 26, 2026 10:58

Fix lint: extract nested render functions to module scope
ffef3e6
Extract renderThreadLeadingContent and renderThreadTrailingContent out of OpenCommandPaletteDialog to satisfy react/no-unstable-nested-components.

Guard against empty title from sanitizeTitle
77a9fd2
Compute the sanitized title first and dispatch only when non-empty. Otherwise whitespace-only provider names become an empty thread title that permanently blocks future updates.

macroscopeappBot previously approved these changes Jul 26, 2026
View reviewed changes

Fix oxlint no-control-regex in sanitizeTitle
791f6f2
Use a callback-based replace instead of a control-character regex pattern to satisfy oxlint's eslint(no-control-regex) rule.

macroscopeappBot previously approved these changes Jul 26, 2026
View reviewed changes

Fix t3code(no-manual-effect-runtime-in-tests) lint
acd29c4
Convert new tests from it() with Effect.runPromise to effectIt.effect with Effect.gen to satisfy the custom rule.

macroscopeappBot approved these changes Jul 26, 2026
View reviewed changes

patroza mentioned this pull request Jul 26, 2026
perf: import mobile reliability and server efficiency candidates patroza/t3code#68
Merged

juliusmarminge closed this Jul 30, 2026