Uh oh!
There was an error while loading. Please reload this page.
fix(web): clear stale provider update toast action - #4651
Conversation
📝 WalkthroughWalkthroughThe provider update toast helper is exported, clears stale action properties during loading and success updates, and gains parameterized tests covering both phases. ChangesProvider update toast
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
mason50x
commented
Jul 27, 2026
@coderabbitai review |
✅ Action performedReview finished.
|
There was a problem hiding this comment.
🧹 Nitpick comments (1)
apps/web/src/components/ProviderUpdatePrimaryNotification.test.tsx (1)
23-55: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winCover the preserved Settings-action states.
This parameterized test only covers loading and success. Add failed/unchanged cases asserting the
Settingsaction andonClickcallback remain present, so future toast-update changes cannot regress the preservation contract.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@apps/web/src/components/ProviderUpdatePrimaryNotification.test.tsx` around lines 23 - 55, Extend the parameterized test for updateProviderUpdateToast to include failed and unchanged view states, supplying the expected Settings action and openSettings callback. Assert that toastMocks.update preserves both the Settings action and its onClick callback in those states, while retaining the existing loading and succeeded expectations.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@apps/web/src/components/ProviderUpdatePrimaryNotification.test.tsx`:
- Around line 23-55: Extend the parameterized test for updateProviderUpdateToast
to include failed and unchanged view states, supplying the expected Settings
action and openSettings callback. Assert that toastMocks.update preserves both
the Settings action and its onClick callback in those states, while retaining
the existing loading and succeeded expectations.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro Plus
Run ID: ebadd67f-0edf-4c5f-ad62-e027b2e20c94
📒 Files selected for processing (2)
apps/web/src/components/ProviderUpdatePrimaryNotification.test.tsxapps/web/src/components/ProviderUpdatePrimaryNotification.tsx
ApprovabilityVerdict: Approved Straightforward bug fix that explicitly clears stale toast action buttons during loading/success states. The change is small, well-documented with comments, and includes comprehensive test coverage. You can customize Macroscope's approvability policy. Learn more. |
What changed
Updateaction when it enters loading or success.Why
UI shallow-merges toast updates. The initial prompt supplies
actionProps, but the loading and success updates previously omitted that field, so the staleUpdatebutton remained visible while the command ran and after completion.Explicitly setting
actionProps: undefinedremoves the stale control. Failed and unchanged states still provide their intended Settings action.Related work
This overlaps #3563 and #2655, which contain the same core one-line fix. This version is based on current
mainafter the notification split intoProviderUpdatePrimaryNotification.tsxand adds regression coverage for both affected states.Validation
vp test run apps/web/src/components/ProviderUpdatePrimaryNotification.test.tsx apps/web/src/components/ProviderUpdateLaunchNotification.logic.test.ts apps/web/src/components/ProviderUpdateEnvironmentRows.test.tsx— 49 tests passedvp lintvp fmt --checkvp run --filter @t3tools/web typecheckgit diff --checkOpenCode was downgraded from
1.18.7to1.18.6locally to leave a natural update-available state for manual verification.Summary by CodeRabbit
Bug Fixes
Tests
Note
Low Risk
Small UI toast behavior fix with regression tests; no auth, data, or API changes.
Overview
Fixes provider update toasts that still showed the initial Update button while loading or after success.
updateProviderUpdateToastnow passesactionProps: undefinedon loading and success updates because Base UI shallow-merges toast state—omitting the field left the prompt’s action in place. Failed and unchanged states still set a Settings action.The helper is exported and covered by a new unit test that checks
actionPropsfor running, succeeded, failed, and unchanged views.Reviewed by Cursor Bugbot for commit 2728487. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Clear stale action from provider update toast in loading and success states
When a provider update toast transitions to a loading or success state, any previously set action (e.g. a Settings button) was being retained due to shallow-merge behavior in
toastManager.update. ProviderUpdatePrimaryNotification.tsx now explicitly setsactionPropstoundefinedin those branches to clear the stale action. A comment explaining the shallow-merge behavior is also added.Macroscope summarized 2728487.