Uh oh!
There was an error while loading. Please reload this page.
Fix inline Markdown image previews in chat - #4785
Conversation
- Resolve workspace image paths against the thread cwd - Add loading, unavailable, and expandable image states - Cover markdown image path resolution with focused tests
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want fixes drafted automatically? Bugbot Autofix can create code changes for findings. A team admin can enable Autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit a8dbe3e. Configure here.
| className?: string; | ||
| /** Treat single newlines as hard breaks — chat-style user input. */ | ||
| lineBreaks?: boolean; | ||
| onImageExpand?: ((preview: ExpandedImagePreview) => void) | undefined; |
There was a problem hiding this comment.
File image URLs sanitized away
Medium Severity
rehype-sanitize strips file:// image src attributes because CHAT_MARKDOWN_SANITIZE_SCHEMA only permits the file protocol for href. This prevents file:// workspace images from rendering, as the custom image component never receives the original source to process.
Reviewed by Cursor Bugbot for commit a8dbe3e. Configure here.
ApprovabilityVerdict: Needs human review This PR introduces a new feature (inline Markdown image previews) with multiple new components and UI capabilities. There is also an unresolved review comment identifying a potential bug where file:// URLs get sanitized, which could prevent workspace images from rendering correctly. You can customize Macroscope's approvability policy. Learn more. |
TheBit
commented
Aug 9, 2026
It doesn't matter if this is on one device/client or another. You can't just see any pics in the chat, which is very sad :(
 |
t3dotgg
commented
Aug 23, 2026
Note 🤖 GPT-5.6 Sol responding on behalf of Theo Closing this PR after an automated pass over open pull requests. Workspace image rendering already shipped in #6433. |
What Changed
file://paths.Why
When the T3 Code server runs on one device and the web client is opened on another, local image paths from assistant messages cannot be loaded directly by the browser. They currently render as broken images with only their alt text visible.
Using the existing thread-scoped asset flow lets the environment that owns the workspace serve the image securely to the connected client without broadening filesystem access.
UI Changes
Before
Workspace-local Markdown images render as broken image icons and alt text.
Before screenshot to be attached.
After
Images render as compact previews with a subtle outline. Clicking a preview opens the existing expanded-image dialog, and Escape closes it again.
After screenshot and short interaction recording to be attached.
Verification
vp test run apps/web/src/markdown-images.test.ts apps/web/src/components/chat/MessagesTimeline.test.tsx— 19 tests passed.vp run --filter @t3tools/web typecheckpassed./api/assets/; standalone images expanded and closed with Escape, while a linked image opened only its link without rendering a nested button or opening the image dialog.Checklist
Note
Medium Risk
Touches chat rendering and workspace file asset URLs for assistant messages; scope is bounded to image paths and existing asset APIs, but remote clients now depend on signed asset delivery for local paths.
Overview
Assistant chat Markdown now renders
imgnodes as inline previews instead of raw broken<img>tags when paths point at workspace images.Workspace-local sources (relative, absolute, and
file://) are resolved with newresolveMarkdownImageFileand loaded through the existing thread-scoped signed asset route viauseAssetUrlState, with loading and unavailable placeholders. External URLs still use directsrc. Standalone previews can open the existing expanded-image dialog through a newonImageExpandprop wired fromMessagesTimeline.Linked images (
[](url)) no longer nest a zoom button inside the anchor—a context flag disables expand so the link keeps sole click behavior.Tests cover path resolution and linked-vs-standalone image semantics in the timeline markup.
Reviewed by Cursor Bugbot for commit a8dbe3e. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Fix inline Markdown image previews in chat with workspace file resolution and expansion
onImageExpandcallback on click.resolveMarkdownImageFileto determine when a markdown image src refers to a workspace file eligible for asset resolution.MarkdownImageInsideLinkContext.onImageExpandthroughAssistantTimelineRowin MessagesTimeline.tsx so assistant message images trigger the timeline's existing image expansion handler.Macroscope summarized a8dbe3e.