Uh oh!
There was an error while loading. Please reload this page.
fix(web): allow removing stale Connect environments - #4968
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
StiensWout
commented
Jul 30, 2026
already exists in #4844 |
soestin
commented
Jul 30, 2026
Closing as a duplicate of #4844. Thanks for pointing this out. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit:902a37c54d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| setRemovingEnvironmentId(null); | ||
| if (result._tag === "Success") { | ||
| setPendingRemoval(null); | ||
| await refreshRelayEnvironments(); |
There was a problem hiding this comment.
When Remove is clicked while the initial discovery is still checking environment statuses, this call joins that existing refresh because relayEnvironmentDiscovery.refresh is single-flight. That refresh fetched its environment list before the DELETE, so it completes with the removed record still in state; this is especially likely for an inaccessible environment whose status check takes time. The success toast then appears while the stale row remains until a later manual or lifecycle refresh. Queue a new refresh after the active one, or remove the environment from discovery state after a successful unlink.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want fixes drafted automatically? Bugbot Autofix can create code changes for findings. A team admin can enable Autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 902a37c. Configure here.
| </p> | ||
| </div> | ||
| </div> | ||
| {savedConnection ? ( |
There was a problem hiding this comment.
Confirm dialog drops on refresh
Medium Severity
The environment removal confirmation AlertDialog is only rendered when the environment list is not empty. During a discovery refresh in standalone mode, if the environment list temporarily clears, early returns will unmount the dialog even if pendingRemoval is set. This causes the confirmation to vanish mid-flow and potentially reappear for a stale environment.
Reviewed by Cursor Bugbot for commit 902a37c. Configure here.
ApprovabilityVerdict: Needs human review This PR introduces a new user-facing capability to remove stale environments, including new API calls, UI components, and confirmation dialogs. Additionally, two unresolved review comments identify potential bugs in state management (stale data after deletion, dialog disappearing during refresh). New features with open bug findings warrant human review. You can customize Macroscope's approvability policy. Learn more. |
Problem
T3 Connect environments discovered through the relay only offered Connect. If the original machine was lost or rebuilt, users could not unlink its stale relay record because
t3 connect unlinkalways targets the machine running the command.Fix
unlinkEnvironmentoperationThis stays web-only; desktop inherits the web surface. It does not add a new relay contract or expand the CLI.
Fixes#4965.
Validation
vp test run src/cloud/linkEnvironment.test.ts --project unit --passWithNoTests— 10 tests passedpnpm typecheckinapps/webvp lintfor the four changed filespnpm buildinapps/webUI evidence
Before — existing connected environment
After — stale environment can be removed
Confirmation
Generated with GPT-5.6-sol through the T3 Code Codex harness.
Note
Add Remove button to Connect environment list to unlink stale relay environments
unlinkRelayEnvironmentFromCloudin linkEnvironment.ts that calls the relay client'sunlinkEnvironmentmethod via a DELETE request to/v1/client/environment-links/:environmentId.unlinkRelayEnvironmentatom command in linkEnvironmentAtoms.ts that serializes execution perenvironmentId.Macroscope summarized 902a37c.
Note
Medium Risk
Changes account-linked environment records via the relay API with destructive UI; scope is web-only and reuses existing unlink contracts rather than new auth paths.
Overview
Users can unlink stale T3 Connect environments from relay discovery when the original machine is gone—without running unlink on that host.
Relay-discovered rows that are not already saved now show Remove next to Connect. Remove opens a confirmation dialog (label + environment ID), then calls the existing authenticated relay
unlinkEnvironmentpath via newunlinkRelayEnvironmentFromCloudand theunlinkRelayEnvironmentatom command. On success the list refreshes and a toast confirms; failures surface trace-aware errors. Saved/connected rows still only show the disabled connection state—no Remove there.A unit test asserts the direct relay DELETE to
/v1/client/environment-links/:idwith the Clerk bearer token.Reviewed by Cursor Bugbot for commit 902a37c. Bugbot is set up for automated code reviews on this repo. Configure here.