Uh oh!
There was an error while loading. Please reload this page.
fix(mobile): iOS long-press opens the row menu without opening the thread - #4987
fix(mobile): iOS long-press opens the row menu without opening the thread#4987Zeus-Deus wants to merge 1 commit into
Conversation
…read On iOS the context-menu interaction is hosted inside the RN view tree by our @react-native-menu patch, so RN never cancels the touch it is tracking while the menu presents. The thread row Pressables define onPress but no onLongPress, and Pressability only drops onPress after a long press when an onLongPress handler exists - so lifting the finger navigated into the thread behind the menu. ControlPillMenu now injects a no-op onLongPress with a 400ms delay into its child on iOS, mirroring the injection the Android branch already does, which makes Pressability cancel the tap before UIKit's ~500ms menu commit. Fixes Thread List v2 rows, pending rows, and the same latent defect in v1 rows.
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ApprovabilityVerdict: Approved 593c6b1 Straightforward iOS bug fix with limited scope. Leverages documented React Native Pressability behavior to cancel the tap when long-press fires, preventing the thread from opening behind the menu. Includes tests and clear inline documentation. You can customize Macroscope's approvability policy. Learn more. |
juliusmarminge
commented
Aug 15, 2026
Closing as superseded by #5901, which has merged and covers this change on the current architecture. Thanks for the contribution. |
Fixes#4938
Problem
On iOS with Thread List v2, long-pressing a thread row opened the native context menu and also navigated into the thread behind it. The repo's
@react-native-menupatch hosts theUIContextMenuInteractionon the component view inside the RN view tree, and React Native's touch handler only cancels its tracked touch for recognizers outside its own tree — so the row'sPressablekept receiving the whole touch sequence while the menu presented. Since the row definesonPressbut noonLongPress, and RN Pressability only suppressesonPressafter a long press when anonLongPresshandler exists, lifting the finger fired the navigation behind the menu. The Android branch ofControlPillMenualready injects anonLongPressinto its child (which is why Android behaves correctly); the iOS branch passed children through untouched.Fix
ControlPillMenu's iOS branch now mirrors Android: the wrapped child is cloned with a stable no-oponLongPressanddelayLongPress: 400(below UIKit's ~500 ms context-menu commit), so Pressability cancels the tap once the long-press fires. The injected props replace any child handler, matching the Android branch's semantics. This one change in the shared wrapper fixes Thread List v2 rows, v2 pending rows, and the same latent defect in Thread List v1 rows and pending rows — everyshouldOpenOnLongPresscall site in the app. A stale comment inthread-list-items.tsxthat encoded the old wrong assumption ("row taps keep working") was corrected. Android code path, swipe actions, scroll, and VoiceOver activation (a synthetic quick activation that never runs the long-press timer) are unaffected.Known narrow gaps of the timer approach, declared deliberately (the deterministic alternative — suppressing via
MenuView.onOpenMenu— adds stateful arbitration whose touch timing we could not verify in this environment): a ~400-500 ms press-and-release before the menu presents now does nothing instead of navigating; a finger drifting >10 pt during the hold cancels RN's timer while UIKit may still present, in which case the old behavior can recur; heavy JS-thread congestion could delay the 400 ms timer past release. All three fail toward pre-existing behavior and are candidates for anonOpenMenu-based follow-up if on-device testing shows they matter.Verification status
The core gesture arbitration lives in RN Pressability + UIKit and is not unit-testable in this repo (mobile tests are pure logic only). A small helper module carries the injected props with a regression test pinning the delay below UIKit's 500 ms threshold. The RN mechanism (
isPressCanceledByLongPress, timer arithmetic, responder-termination on scroll/swipe) was verified against the vendored RN 0.85.3 source. Scoped mobile typecheck, lint, and format checks are green.Native iOS verification is still required and was not performed (this change was developed and tested on Linux). Before merge, on a device/simulator with Thread List v2: long-press a thread row → menu only, no navigation behind it; short tap still navigates; same for pending rows, v1 rows, and the iPad split-view sidebar; swipe actions and scroll unaffected; menu actions fire exactly once; VoiceOver double-tap still navigates; Android smoke test (unchanged branch). A deliberate ~450 ms press-and-release and a drift-while-holding probe are worth explicit checks for the declared gaps.
Implemented and reviewed with Claude Code (Fable 5).
Note
Medium Risk
Touches shared gesture handling for all long-press menus on iOS; logic is localized to ControlPillMenu but timing edge cases (press-and-release ~400–500ms, drift while holding) may still allow navigation in rare cases.
Overview
Fixes iOS thread rows (and other
shouldOpenOnLongPressmenus) where lifting the finger after a long-press opened the context menu also fired the row’sonPress, navigating into the thread behind the menu.ControlPillMenuon iOS now matches Android: whenshouldOpenOnLongPressis set, the wrapped child is cloned with frozenlongPressMenuChildProps— a no-oponLongPressanddelayLongPress: 400ms(under UIKit’s ~500ms menu commit) so React Native Pressability cancels the tap once the long press registers.Adds
longPressMenuChildProps.tsplus a small test pinning the delay below 500ms. Updates the thread-list comment to document why iOS needs the injection alongside the patched context-menu interaction.Reviewed by Cursor Bugbot for commit 593c6b1. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Fix iOS long-press on thread list rows to open the row menu without triggering thread open
longPressMenuChildPropsmodule exporting a frozen prop bundle with a no-oponLongPressand a 400msdelayLongPressconstant.ControlPillMenu, the iOS path now clones its child with these props whenshouldOpenOnLongPressis true, causingPressabilityto cancel the tap when the long-press gesture fires.MenuViewbranch is affected.Macroscope summarized 593c6b1.