Skip to content

fix(claude): make "Always allow for session" stick, and only for the session#5041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juliusmarminge merged 1 commit into from
Aug 15, 2026
Merged

fix(claude): make "Always allow for session" stick, and only for the session #5041

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
112 changes: 112 additions & 0 deletions apps/server/src/provider/Layers/ClaudeAdapter.test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -2882,6 +2882,118 @@ describe("ClaudeAdapterLive", () => {
);
});

it.effect("acceptForSession returns session-scoped permission updates", () => {
const harness = makeHarness();
return Effect.gen(function* () {
const adapter = yield* ClaudeAdapter;

const session = yield* adapter.startSession({
threadId: THREAD_ID,
provider: ProviderDriverKind.make("claudeAgent"),
runtimeMode: "approval-required",
});

yield* Stream.take(adapter.streamEvents, 3).pipe(Stream.runDrain);

yield* adapter.sendTurn({
threadId: session.threadId,
input: "approve this for the session",
attachments: [],
});
yield* Stream.take(adapter.streamEvents, 1).pipe(Stream.runDrain);

const createInput = harness.getLastCreateQueryInput();
const canUseTool = createInput?.options.canUseTool;
assert.equal(typeof canUseTool, "function");
if (!canUseTool) {
return;
}

const respondToNextRequest = Effect.gen(function* () {
const requested = yield* Stream.runHead(adapter.streamEvents);
assert.equal(requested._tag, "Some");
if (requested._tag !== "Some" || requested.value.type !== "request.opened") {
return;
}
const runtimeRequestId = requested.value.requestId;
assert.equal(typeof runtimeRequestId, "string");
if (runtimeRequestId === undefined) {
return;
}
yield* adapter.respondToRequest(
session.threadId,
ApprovalRequestId.make(runtimeRequestId),
"acceptForSession",
);
yield* Stream.take(adapter.streamEvents, 1).pipe(Stream.runDrain);
});

// MCP tools frequently arrive with no usable suggestion (Claude Code
// sends an empty array); the decision must still stick for the session.
const mcpPermissionPromise = canUseTool(
"mcp__linear__create_issue",
{ title: "hello" },
{
signal: new AbortController().signal,
suggestions: [],
toolUseID: "tool-use-mcp-1",
},
);
yield* respondToNextRequest;
const mcpPermission = (yield* Effect.promise(() => mcpPermissionPromise)) as PermissionResult;
assert.equal(mcpPermission.behavior, "allow");
if (mcpPermission.behavior !== "allow") {
return;
}
assert.deepEqual(mcpPermission.updatedPermissions, [
{
type: "addRules",
rules: [{ toolName: "mcp__linear__create_issue" }],
behavior: "allow",
destination: "session",
},
]);

// Received suggestions are reused but rescoped to the session —
// echoing "localSettings" would persist a session-only choice to disk.
const bashPermissionPromise = canUseTool(
"Bash",
{ command: "git status" },
{
signal: new AbortController().signal,
suggestions: [
{
type: "addRules",
rules: [{ toolName: "Bash", ruleContent: "git status" }],
behavior: "allow",
destination: "localSettings",
},
],
toolUseID: "tool-use-bash-1",
},
);
yield* respondToNextRequest;
const bashPermission = (yield* Effect.promise(
() => bashPermissionPromise,
)) as PermissionResult;
assert.equal(bashPermission.behavior, "allow");
if (bashPermission.behavior !== "allow") {
return;
}
assert.deepEqual(bashPermission.updatedPermissions, [
{
type: "addRules",
rules: [{ toolName: "Bash", ruleContent: "git status" }],
behavior: "allow",
destination: "session",
},
]);
}).pipe(
Effect.provideService(Random.Random, makeDeterministicRandomService()),
Effect.provide(harness.layer),
);
});

it.effect("classifies Agent tools and read-only Claude tools correctly for approvals", () => {
const harness = makeHarness();
return Effect.gen(function* () {
Expand Down
38 changes: 36 additions & 2 deletions apps/server/src/provider/Layers/ClaudeAdapter.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -155,6 +155,37 @@ interface PendingApproval {
readonly decision: Deferred.Deferred<ProviderApprovalDecision>;
}

/**
* Permission updates applied for an "Always allow this session" decision.
*
* Claude Code's suggestions are reused when present but rescoped to
* `destination: "session"` — echoing them verbatim would persist the
* session-only choice as a permanent rule (suggestions typically target
* `localSettings`, i.e. `.claude/settings.local.json`). When Claude Code
* offers no suggestion — common for MCP tools — fall back to a whole-tool
* session allow rule so the decision still sticks for the session instead of
* silently degrading into a one-shot accept.
*/
function toSessionPermissionUpdates(
toolName: string,
suggestions: ReadonlyArray<PermissionUpdate> | undefined,
): Array<PermissionUpdate> {
const sessionScoped = (suggestions ?? []).map(
(suggestion): PermissionUpdate => ({ ...suggestion, destination: "session" }),
);
if (sessionScoped.length > 0) {
return sessionScoped;
}
return [
{
type: "addRules",
rules: [{ toolName }],
behavior: "allow",
destination: "session",
},
];
}

interface PendingUserInput {
readonly questions: ReadonlyArray<UserInputQuestion>;
readonly answers: Deferred.Deferred<ProviderUserInputAnswers>;
Expand DownExpand Up@@ -3465,9 +3496,12 @@ export const makeClaudeAdapter = Effect.fn("makeClaudeAdapter")(function* (
return {
behavior: "allow",
updatedInput: toolInput,
...(decision === "acceptForSession" && pendingApproval.suggestions
...(decision === "acceptForSession"
? {
updatedPermissions: [...pendingApproval.suggestions],
updatedPermissions: toSessionPermissionUpdates(
toolName,
pendingApproval.suggestions,
),
}
: {}),
} satisfies PermissionResult;
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
fix(claude): make "Always allow for session" stick, and only for the session by kakismash · Pull Request #5041 · pingdotgg/t3code · GitHub
Skip to content
fix(claude): make "Always allow for session" stick, and only for the session#5041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

juliusmarminge
merged 1 commit into

from

Aug 15, 2026
 Merged


fix(claude): make "Always allow for session" stick, and only for the session
#5041
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


112 changes: 112 additions & 0 deletions
apps/server/src/provider/Layers/ClaudeAdapter.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2882,6 +2882,118 @@ describe("ClaudeAdapterLive", () => {
 );
 });

 it.effect("acceptForSession returns session-scoped permission updates", () => {
 const harness = makeHarness();
 return Effect.gen(function* () {
 const adapter = yield* ClaudeAdapter;

 const session = yield* adapter.startSession({
 threadId: THREAD_ID,
 provider: ProviderDriverKind.make("claudeAgent"),
 runtimeMode: "approval-required",
 });

 yield* Stream.take(adapter.streamEvents, 3).pipe(Stream.runDrain);

 yield* adapter.sendTurn({
 threadId: session.threadId,
 input: "approve this for the session",
 attachments: [],
 });
 yield* Stream.take(adapter.streamEvents, 1).pipe(Stream.runDrain);

 const createInput = harness.getLastCreateQueryInput();
 const canUseTool = createInput?.options.canUseTool;
 assert.equal(typeof canUseTool, "function");
 if (!canUseTool) {
 return;
 }

 const respondToNextRequest = Effect.gen(function* () {
 const requested = yield* Stream.runHead(adapter.streamEvents);
 assert.equal(requested._tag, "Some");
 if (requested._tag !== "Some" || requested.value.type !== "request.opened") {
 return;
 }
 const runtimeRequestId = requested.value.requestId;
 assert.equal(typeof runtimeRequestId, "string");
 if (runtimeRequestId === undefined) {
 return;
 }
 yield* adapter.respondToRequest(
 session.threadId,
 ApprovalRequestId.make(runtimeRequestId),
 "acceptForSession",
 );
 yield* Stream.take(adapter.streamEvents, 1).pipe(Stream.runDrain);
 });

 // MCP tools frequently arrive with no usable suggestion (Claude Code
 // sends an empty array); the decision must still stick for the session.
 const mcpPermissionPromise = canUseTool(
 "mcp__linear__create_issue",
 { title: "hello" },
 {
 signal: new AbortController().signal,
 suggestions: [],
 toolUseID: "tool-use-mcp-1",
 },
 );
 yield* respondToNextRequest;
 const mcpPermission = (yield* Effect.promise(() => mcpPermissionPromise)) as PermissionResult;
 assert.equal(mcpPermission.behavior, "allow");
 if (mcpPermission.behavior !== "allow") {
 return;
 }
 assert.deepEqual(mcpPermission.updatedPermissions, [
 {
 type: "addRules",
 rules: [{ toolName: "mcp__linear__create_issue" }],
 behavior: "allow",
 destination: "session",
 },
 ]);

 // Received suggestions are reused but rescoped to the session —
 // echoing "localSettings" would persist a session-only choice to disk.
 const bashPermissionPromise = canUseTool(
 "Bash",
 { command: "git status" },
 {
 signal: new AbortController().signal,
 suggestions: [
 {
 type: "addRules",
 rules: [{ toolName: "Bash", ruleContent: "git status" }],
 behavior: "allow",
 destination: "localSettings",
 },
 ],
 toolUseID: "tool-use-bash-1",
 },
 );
 yield* respondToNextRequest;
 const bashPermission = (yield* Effect.promise(
 () => bashPermissionPromise,
 )) as PermissionResult;
 assert.equal(bashPermission.behavior, "allow");
 if (bashPermission.behavior !== "allow") {
 return;
 }
 assert.deepEqual(bashPermission.updatedPermissions, [
 {
 type: "addRules",
 rules: [{ toolName: "Bash", ruleContent: "git status" }],
 behavior: "allow",
 destination: "session",
 },
 ]);
 }).pipe(
 Effect.provideService(Random.Random, makeDeterministicRandomService()),
 Effect.provide(harness.layer),
 );
 });

 it.effect("classifies Agent tools and read-only Claude tools correctly for approvals", () => {
 const harness = makeHarness();
 return Effect.gen(function* () {
Expand Down

38 changes: 36 additions & 2 deletions
apps/server/src/provider/Layers/ClaudeAdapter.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -155,6 +155,37 @@ interface PendingApproval {
 readonly decision: Deferred.Deferred<ProviderApprovalDecision>;
}

/**
 * Permission updates applied for an "Always allow this session" decision.
 *
 * Claude Code's suggestions are reused when present but rescoped to
 * `destination: "session"` — echoing them verbatim would persist the
 * session-only choice as a permanent rule (suggestions typically target
 * `localSettings`, i.e. `.claude/settings.local.json`). When Claude Code
 * offers no suggestion — common for MCP tools — fall back to a whole-tool
 * session allow rule so the decision still sticks for the session instead of
 * silently degrading into a one-shot accept.
 */
function toSessionPermissionUpdates(
 toolName: string,
 suggestions: ReadonlyArray<PermissionUpdate> | undefined,
): Array<PermissionUpdate> {
 const sessionScoped = (suggestions ?? []).map(
 (suggestion): PermissionUpdate => ({ ...suggestion, destination: "session" }),
 );
 if (sessionScoped.length > 0) {
 return sessionScoped;
 }
 return [
 {
 type: "addRules",
 rules: [{ toolName }],
 behavior: "allow",
 destination: "session",
 },
 ];
}

interface PendingUserInput {
 readonly questions: ReadonlyArray<UserInputQuestion>;
 readonly answers: Deferred.Deferred<ProviderUserInputAnswers>;
Expand DownExpand Up@@ -3465,9 +3496,12 @@ export const makeClaudeAdapter = Effect.fn("makeClaudeAdapter")(function* (
 return {
 behavior: "allow",
 updatedInput: toolInput,
 ...(decision === "acceptForSession" && pendingApproval.suggestions
 ...(decision === "acceptForSession"
 ? {
 updatedPermissions: [...pendingApproval.suggestions],
 updatedPermissions: toSessionPermissionUpdates(
 toolName,
 pendingApproval.suggestions,
 ),
 }
 : {}),
 } satisfies PermissionResult;
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix(claude): make "Always allow for session" stick, and only for the session by kakismash · Pull Request #5041 · pingdotgg/t3code · GitHub
Skip to content
fix(claude): make "Always allow for session" stick, and only for the session#5041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

juliusmarminge
merged 1 commit into

from

Aug 15, 2026
 Merged


fix(claude): make "Always allow for session" stick, and only for the session
#5041
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


112 changes: 112 additions & 0 deletions
apps/server/src/provider/Layers/ClaudeAdapter.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2882,6 +2882,118 @@ describe("ClaudeAdapterLive", () => {
 );
 });

 it.effect("acceptForSession returns session-scoped permission updates", () => {
 const harness = makeHarness();
 return Effect.gen(function* () {
 const adapter = yield* ClaudeAdapter;

 const session = yield* adapter.startSession({
 threadId: THREAD_ID,
 provider: ProviderDriverKind.make("claudeAgent"),
 runtimeMode: "approval-required",
 });

 yield* Stream.take(adapter.streamEvents, 3).pipe(Stream.runDrain);

 yield* adapter.sendTurn({
 threadId: session.threadId,
 input: "approve this for the session",
 attachments: [],
 });
 yield* Stream.take(adapter.streamEvents, 1).pipe(Stream.runDrain);

 const createInput = harness.getLastCreateQueryInput();
 const canUseTool = createInput?.options.canUseTool;
 assert.equal(typeof canUseTool, "function");
 if (!canUseTool) {
 return;
 }

 const respondToNextRequest = Effect.gen(function* () {
 const requested = yield* Stream.runHead(adapter.streamEvents);
 assert.equal(requested._tag, "Some");
 if (requested._tag !== "Some" || requested.value.type !== "request.opened") {
 return;
 }
 const runtimeRequestId = requested.value.requestId;
 assert.equal(typeof runtimeRequestId, "string");
 if (runtimeRequestId === undefined) {
 return;
 }
 yield* adapter.respondToRequest(
 session.threadId,
 ApprovalRequestId.make(runtimeRequestId),
 "acceptForSession",
 );
 yield* Stream.take(adapter.streamEvents, 1).pipe(Stream.runDrain);
 });

 // MCP tools frequently arrive with no usable suggestion (Claude Code
 // sends an empty array); the decision must still stick for the session.
 const mcpPermissionPromise = canUseTool(
 "mcp__linear__create_issue",
 { title: "hello" },
 {
 signal: new AbortController().signal,
 suggestions: [],
 toolUseID: "tool-use-mcp-1",
 },
 );
 yield* respondToNextRequest;
 const mcpPermission = (yield* Effect.promise(() => mcpPermissionPromise)) as PermissionResult;
 assert.equal(mcpPermission.behavior, "allow");
 if (mcpPermission.behavior !== "allow") {
 return;
 }
 assert.deepEqual(mcpPermission.updatedPermissions, [
 {
 type: "addRules",
 rules: [{ toolName: "mcp__linear__create_issue" }],
 behavior: "allow",
 destination: "session",
 },
 ]);

 // Received suggestions are reused but rescoped to the session —
 // echoing "localSettings" would persist a session-only choice to disk.
 const bashPermissionPromise = canUseTool(
 "Bash",
 { command: "git status" },
 {
 signal: new AbortController().signal,
 suggestions: [
 {
 type: "addRules",
 rules: [{ toolName: "Bash", ruleContent: "git status" }],
 behavior: "allow",
 destination: "localSettings",
 },
 ],
 toolUseID: "tool-use-bash-1",
 },
 );
 yield* respondToNextRequest;
 const bashPermission = (yield* Effect.promise(
 () => bashPermissionPromise,
 )) as PermissionResult;
 assert.equal(bashPermission.behavior, "allow");
 if (bashPermission.behavior !== "allow") {
 return;
 }
 assert.deepEqual(bashPermission.updatedPermissions, [
 {
 type: "addRules",
 rules: [{ toolName: "Bash", ruleContent: "git status" }],
 behavior: "allow",
 destination: "session",
 },
 ]);
 }).pipe(
 Effect.provideService(Random.Random, makeDeterministicRandomService()),
 Effect.provide(harness.layer),
 );
 });

 it.effect("classifies Agent tools and read-only Claude tools correctly for approvals", () => {
 const harness = makeHarness();
 return Effect.gen(function* () {
Expand Down

38 changes: 36 additions & 2 deletions
apps/server/src/provider/Layers/ClaudeAdapter.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -155,6 +155,37 @@ interface PendingApproval {
 readonly decision: Deferred.Deferred<ProviderApprovalDecision>;
}

/**
 * Permission updates applied for an "Always allow this session" decision.
 *
 * Claude Code's suggestions are reused when present but rescoped to
 * `destination: "session"` — echoing them verbatim would persist the
 * session-only choice as a permanent rule (suggestions typically target
 * `localSettings`, i.e. `.claude/settings.local.json`). When Claude Code
 * offers no suggestion — common for MCP tools — fall back to a whole-tool
 * session allow rule so the decision still sticks for the session instead of
 * silently degrading into a one-shot accept.
 */
function toSessionPermissionUpdates(
 toolName: string,
 suggestions: ReadonlyArray<PermissionUpdate> | undefined,
): Array<PermissionUpdate> {
 const sessionScoped = (suggestions ?? []).map(
 (suggestion): PermissionUpdate => ({ ...suggestion, destination: "session" }),
 );
 if (sessionScoped.length > 0) {
 return sessionScoped;
 }
 return [
 {
 type: "addRules",
 rules: [{ toolName }],
 behavior: "allow",
 destination: "session",
 },
 ];
}

interface PendingUserInput {
 readonly questions: ReadonlyArray<UserInputQuestion>;
 readonly answers: Deferred.Deferred<ProviderUserInputAnswers>;
Expand DownExpand Up@@ -3465,9 +3496,12 @@ export const makeClaudeAdapter = Effect.fn("makeClaudeAdapter")(function* (
 return {
 behavior: "allow",
 updatedInput: toolInput,
 ...(decision === "acceptForSession" && pendingApproval.suggestions
 ...(decision === "acceptForSession"
 ? {
 updatedPermissions: [...pendingApproval.suggestions],
 updatedPermissions: toSessionPermissionUpdates(
 toolName,
 pendingApproval.suggestions,
 ),
 }
 : {}),
 } satisfies PermissionResult;
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix(claude): make "Always allow for session" stick, and only for the session by kakismash · Pull Request #5041 · pingdotgg/t3code · GitHub
Skip to content
fix(claude): make "Always allow for session" stick, and only for the session#5041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

juliusmarminge
merged 1 commit into

from

Aug 15, 2026
 Merged


fix(claude): make "Always allow for session" stick, and only for the session
#5041
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


112 changes: 112 additions & 0 deletions
apps/server/src/provider/Layers/ClaudeAdapter.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2882,6 +2882,118 @@ describe("ClaudeAdapterLive", () => {
 );
 });

 it.effect("acceptForSession returns session-scoped permission updates", () => {
 const harness = makeHarness();
 return Effect.gen(function* () {
 const adapter = yield* ClaudeAdapter;

 const session = yield* adapter.startSession({
 threadId: THREAD_ID,
 provider: ProviderDriverKind.make("claudeAgent"),
 runtimeMode: "approval-required",
 });

 yield* Stream.take(adapter.streamEvents, 3).pipe(Stream.runDrain);

 yield* adapter.sendTurn({
 threadId: session.threadId,
 input: "approve this for the session",
 attachments: [],
 });
 yield* Stream.take(adapter.streamEvents, 1).pipe(Stream.runDrain);

 const createInput = harness.getLastCreateQueryInput();
 const canUseTool = createInput?.options.canUseTool;
 assert.equal(typeof canUseTool, "function");
 if (!canUseTool) {
 return;
 }

 const respondToNextRequest = Effect.gen(function* () {
 const requested = yield* Stream.runHead(adapter.streamEvents);
 assert.equal(requested._tag, "Some");
 if (requested._tag !== "Some" || requested.value.type !== "request.opened") {
 return;
 }
 const runtimeRequestId = requested.value.requestId;
 assert.equal(typeof runtimeRequestId, "string");
 if (runtimeRequestId === undefined) {
 return;
 }
 yield* adapter.respondToRequest(
 session.threadId,
 ApprovalRequestId.make(runtimeRequestId),
 "acceptForSession",
 );
 yield* Stream.take(adapter.streamEvents, 1).pipe(Stream.runDrain);
 });

 // MCP tools frequently arrive with no usable suggestion (Claude Code
 // sends an empty array); the decision must still stick for the session.
 const mcpPermissionPromise = canUseTool(
 "mcp__linear__create_issue",
 { title: "hello" },
 {
 signal: new AbortController().signal,
 suggestions: [],
 toolUseID: "tool-use-mcp-1",
 },
 );
 yield* respondToNextRequest;
 const mcpPermission = (yield* Effect.promise(() => mcpPermissionPromise)) as PermissionResult;
 assert.equal(mcpPermission.behavior, "allow");
 if (mcpPermission.behavior !== "allow") {
 return;
 }
 assert.deepEqual(mcpPermission.updatedPermissions, [
 {
 type: "addRules",
 rules: [{ toolName: "mcp__linear__create_issue" }],
 behavior: "allow",
 destination: "session",
 },
 ]);

 // Received suggestions are reused but rescoped to the session —
 // echoing "localSettings" would persist a session-only choice to disk.
 const bashPermissionPromise = canUseTool(
 "Bash",
 { command: "git status" },
 {
 signal: new AbortController().signal,
 suggestions: [
 {
 type: "addRules",
 rules: [{ toolName: "Bash", ruleContent: "git status" }],
 behavior: "allow",
 destination: "localSettings",
 },
 ],
 toolUseID: "tool-use-bash-1",
 },
 );
 yield* respondToNextRequest;
 const bashPermission = (yield* Effect.promise(
 () => bashPermissionPromise,
 )) as PermissionResult;
 assert.equal(bashPermission.behavior, "allow");
 if (bashPermission.behavior !== "allow") {
 return;
 }
 assert.deepEqual(bashPermission.updatedPermissions, [
 {
 type: "addRules",
 rules: [{ toolName: "Bash", ruleContent: "git status" }],
 behavior: "allow",
 destination: "session",
 },
 ]);
 }).pipe(
 Effect.provideService(Random.Random, makeDeterministicRandomService()),
 Effect.provide(harness.layer),
 );
 });

 it.effect("classifies Agent tools and read-only Claude tools correctly for approvals", () => {
 const harness = makeHarness();
 return Effect.gen(function* () {
Expand Down

38 changes: 36 additions & 2 deletions
apps/server/src/provider/Layers/ClaudeAdapter.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -155,6 +155,37 @@ interface PendingApproval {
 readonly decision: Deferred.Deferred<ProviderApprovalDecision>;
}

/**
 * Permission updates applied for an "Always allow this session" decision.
 *
 * Claude Code's suggestions are reused when present but rescoped to
 * `destination: "session"` — echoing them verbatim would persist the
 * session-only choice as a permanent rule (suggestions typically target
 * `localSettings`, i.e. `.claude/settings.local.json`). When Claude Code
 * offers no suggestion — common for MCP tools — fall back to a whole-tool
 * session allow rule so the decision still sticks for the session instead of
 * silently degrading into a one-shot accept.
 */
function toSessionPermissionUpdates(
 toolName: string,
 suggestions: ReadonlyArray<PermissionUpdate> | undefined,
): Array<PermissionUpdate> {
 const sessionScoped = (suggestions ?? []).map(
 (suggestion): PermissionUpdate => ({ ...suggestion, destination: "session" }),
 );
 if (sessionScoped.length > 0) {
 return sessionScoped;
 }
 return [
 {
 type: "addRules",
 rules: [{ toolName }],
 behavior: "allow",
 destination: "session",
 },
 ];
}

interface PendingUserInput {
 readonly questions: ReadonlyArray<UserInputQuestion>;
 readonly answers: Deferred.Deferred<ProviderUserInputAnswers>;
Expand DownExpand Up@@ -3465,9 +3496,12 @@ export const makeClaudeAdapter = Effect.fn("makeClaudeAdapter")(function* (
 return {
 behavior: "allow",
 updatedInput: toolInput,
 ...(decision === "acceptForSession" && pendingApproval.suggestions
 ...(decision === "acceptForSession"
 ? {
 updatedPermissions: [...pendingApproval.suggestions],
 updatedPermissions: toSessionPermissionUpdates(
 toolName,
 pendingApproval.suggestions,
 ),
 }
 : {}),
 } satisfies PermissionResult;
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
fix(claude): make "Always allow for session" stick, and only for the session by kakismash · Pull Request #5041 · pingdotgg/t3code · GitHub
Skip to content
fix(claude): make "Always allow for session" stick, and only for the session#5041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

juliusmarminge
merged 1 commit into

from

Aug 15, 2026
 Merged


fix(claude): make "Always allow for session" stick, and only for the session
#5041
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


112 changes: 112 additions & 0 deletions
apps/server/src/provider/Layers/ClaudeAdapter.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2882,6 +2882,118 @@ describe("ClaudeAdapterLive", () => {
 );
 });

 it.effect("acceptForSession returns session-scoped permission updates", () => {
 const harness = makeHarness();
 return Effect.gen(function* () {
 const adapter = yield* ClaudeAdapter;

 const session = yield* adapter.startSession({
 threadId: THREAD_ID,
 provider: ProviderDriverKind.make("claudeAgent"),
 runtimeMode: "approval-required",
 });

 yield* Stream.take(adapter.streamEvents, 3).pipe(Stream.runDrain);

 yield* adapter.sendTurn({
 threadId: session.threadId,
 input: "approve this for the session",
 attachments: [],
 });
 yield* Stream.take(adapter.streamEvents, 1).pipe(Stream.runDrain);

 const createInput = harness.getLastCreateQueryInput();
 const canUseTool = createInput?.options.canUseTool;
 assert.equal(typeof canUseTool, "function");
 if (!canUseTool) {
 return;
 }

 const respondToNextRequest = Effect.gen(function* () {
 const requested = yield* Stream.runHead(adapter.streamEvents);
 assert.equal(requested._tag, "Some");
 if (requested._tag !== "Some" || requested.value.type !== "request.opened") {
 return;
 }
 const runtimeRequestId = requested.value.requestId;
 assert.equal(typeof runtimeRequestId, "string");
 if (runtimeRequestId === undefined) {
 return;
 }
 yield* adapter.respondToRequest(
 session.threadId,
 ApprovalRequestId.make(runtimeRequestId),
 "acceptForSession",
 );
 yield* Stream.take(adapter.streamEvents, 1).pipe(Stream.runDrain);
 });

 // MCP tools frequently arrive with no usable suggestion (Claude Code
 // sends an empty array); the decision must still stick for the session.
 const mcpPermissionPromise = canUseTool(
 "mcp__linear__create_issue",
 { title: "hello" },
 {
 signal: new AbortController().signal,
 suggestions: [],
 toolUseID: "tool-use-mcp-1",
 },
 );
 yield* respondToNextRequest;
 const mcpPermission = (yield* Effect.promise(() => mcpPermissionPromise)) as PermissionResult;
 assert.equal(mcpPermission.behavior, "allow");
 if (mcpPermission.behavior !== "allow") {
 return;
 }
 assert.deepEqual(mcpPermission.updatedPermissions, [
 {
 type: "addRules",
 rules: [{ toolName: "mcp__linear__create_issue" }],
 behavior: "allow",
 destination: "session",
 },
 ]);

 // Received suggestions are reused but rescoped to the session —
 // echoing "localSettings" would persist a session-only choice to disk.
 const bashPermissionPromise = canUseTool(
 "Bash",
 { command: "git status" },
 {
 signal: new AbortController().signal,
 suggestions: [
 {
 type: "addRules",
 rules: [{ toolName: "Bash", ruleContent: "git status" }],
 behavior: "allow",
 destination: "localSettings",
 },
 ],
 toolUseID: "tool-use-bash-1",
 },
 );
 yield* respondToNextRequest;
 const bashPermission = (yield* Effect.promise(
 () => bashPermissionPromise,
 )) as PermissionResult;
 assert.equal(bashPermission.behavior, "allow");
 if (bashPermission.behavior !== "allow") {
 return;
 }
 assert.deepEqual(bashPermission.updatedPermissions, [
 {
 type: "addRules",
 rules: [{ toolName: "Bash", ruleContent: "git status" }],
 behavior: "allow",
 destination: "session",
 },
 ]);
 }).pipe(
 Effect.provideService(Random.Random, makeDeterministicRandomService()),
 Effect.provide(harness.layer),
 );
 });

 it.effect("classifies Agent tools and read-only Claude tools correctly for approvals", () => {
 const harness = makeHarness();
 return Effect.gen(function* () {
Expand Down

38 changes: 36 additions & 2 deletions
apps/server/src/provider/Layers/ClaudeAdapter.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -155,6 +155,37 @@ interface PendingApproval {
 readonly decision: Deferred.Deferred<ProviderApprovalDecision>;
}

/**
 * Permission updates applied for an "Always allow this session" decision.
 *
 * Claude Code's suggestions are reused when present but rescoped to
 * `destination: "session"` — echoing them verbatim would persist the
 * session-only choice as a permanent rule (suggestions typically target
 * `localSettings`, i.e. `.claude/settings.local.json`). When Claude Code
 * offers no suggestion — common for MCP tools — fall back to a whole-tool
 * session allow rule so the decision still sticks for the session instead of
 * silently degrading into a one-shot accept.
 */
function toSessionPermissionUpdates(
 toolName: string,
 suggestions: ReadonlyArray<PermissionUpdate> | undefined,
): Array<PermissionUpdate> {
 const sessionScoped = (suggestions ?? []).map(
 (suggestion): PermissionUpdate => ({ ...suggestion, destination: "session" }),
 );
 if (sessionScoped.length > 0) {
 return sessionScoped;
 }
 return [
 {
 type: "addRules",
 rules: [{ toolName }],
 behavior: "allow",
 destination: "session",
 },
 ];
}

interface PendingUserInput {
 readonly questions: ReadonlyArray<UserInputQuestion>;
 readonly answers: Deferred.Deferred<ProviderUserInputAnswers>;
Expand DownExpand Up@@ -3465,9 +3496,12 @@ export const makeClaudeAdapter = Effect.fn("makeClaudeAdapter")(function* (
 return {
 behavior: "allow",
 updatedInput: toolInput,
 ...(decision === "acceptForSession" && pendingApproval.suggestions
 ...(decision === "acceptForSession"
 ? {
 updatedPermissions: [...pendingApproval.suggestions],
 updatedPermissions: toSessionPermissionUpdates(
 toolName,
 pendingApproval.suggestions,
 ),
 }
 : {}),
 } satisfies PermissionResult;
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix(claude): make "Always allow for session" stick, and only for the session by kakismash · Pull Request #5041 · pingdotgg/t3code · GitHub
Skip to content
fix(claude): make "Always allow for session" stick, and only for the session#5041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

juliusmarminge
merged 1 commit into

from

Aug 15, 2026
 Merged


fix(claude): make "Always allow for session" stick, and only for the session
#5041
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


112 changes: 112 additions & 0 deletions
apps/server/src/provider/Layers/ClaudeAdapter.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2882,6 +2882,118 @@ describe("ClaudeAdapterLive", () => {
 );
 });

 it.effect("acceptForSession returns session-scoped permission updates", () => {
 const harness = makeHarness();
 return Effect.gen(function* () {
 const adapter = yield* ClaudeAdapter;

 const session = yield* adapter.startSession({
 threadId: THREAD_ID,
 provider: ProviderDriverKind.make("claudeAgent"),
 runtimeMode: "approval-required",
 });

 yield* Stream.take(adapter.streamEvents, 3).pipe(Stream.runDrain);

 yield* adapter.sendTurn({
 threadId: session.threadId,
 input: "approve this for the session",
 attachments: [],
 });
 yield* Stream.take(adapter.streamEvents, 1).pipe(Stream.runDrain);

 const createInput = harness.getLastCreateQueryInput();
 const canUseTool = createInput?.options.canUseTool;
 assert.equal(typeof canUseTool, "function");
 if (!canUseTool) {
 return;
 }

 const respondToNextRequest = Effect.gen(function* () {
 const requested = yield* Stream.runHead(adapter.streamEvents);
 assert.equal(requested._tag, "Some");
 if (requested._tag !== "Some" || requested.value.type !== "request.opened") {
 return;
 }
 const runtimeRequestId = requested.value.requestId;
 assert.equal(typeof runtimeRequestId, "string");
 if (runtimeRequestId === undefined) {
 return;
 }
 yield* adapter.respondToRequest(
 session.threadId,
 ApprovalRequestId.make(runtimeRequestId),
 "acceptForSession",
 );
 yield* Stream.take(adapter.streamEvents, 1).pipe(Stream.runDrain);
 });

 // MCP tools frequently arrive with no usable suggestion (Claude Code
 // sends an empty array); the decision must still stick for the session.
 const mcpPermissionPromise = canUseTool(
 "mcp__linear__create_issue",
 { title: "hello" },
 {
 signal: new AbortController().signal,
 suggestions: [],
 toolUseID: "tool-use-mcp-1",
 },
 );
 yield* respondToNextRequest;
 const mcpPermission = (yield* Effect.promise(() => mcpPermissionPromise)) as PermissionResult;
 assert.equal(mcpPermission.behavior, "allow");
 if (mcpPermission.behavior !== "allow") {
 return;
 }
 assert.deepEqual(mcpPermission.updatedPermissions, [
 {
 type: "addRules",
 rules: [{ toolName: "mcp__linear__create_issue" }],
 behavior: "allow",
 destination: "session",
 },
 ]);

 // Received suggestions are reused but rescoped to the session —
 // echoing "localSettings" would persist a session-only choice to disk.
 const bashPermissionPromise = canUseTool(
 "Bash",
 { command: "git status" },
 {
 signal: new AbortController().signal,
 suggestions: [
 {
 type: "addRules",
 rules: [{ toolName: "Bash", ruleContent: "git status" }],
 behavior: "allow",
 destination: "localSettings",
 },
 ],
 toolUseID: "tool-use-bash-1",
 },
 );
 yield* respondToNextRequest;
 const bashPermission = (yield* Effect.promise(
 () => bashPermissionPromise,
 )) as PermissionResult;
 assert.equal(bashPermission.behavior, "allow");
 if (bashPermission.behavior !== "allow") {
 return;
 }
 assert.deepEqual(bashPermission.updatedPermissions, [
 {
 type: "addRules",
 rules: [{ toolName: "Bash", ruleContent: "git status" }],
 behavior: "allow",
 destination: "session",
 },
 ]);
 }).pipe(
 Effect.provideService(Random.Random, makeDeterministicRandomService()),
 Effect.provide(harness.layer),
 );
 });

 it.effect("classifies Agent tools and read-only Claude tools correctly for approvals", () => {
 const harness = makeHarness();
 return Effect.gen(function* () {
Expand Down

38 changes: 36 additions & 2 deletions
apps/server/src/provider/Layers/ClaudeAdapter.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -155,6 +155,37 @@ interface PendingApproval {
 readonly decision: Deferred.Deferred<ProviderApprovalDecision>;
}

/**
 * Permission updates applied for an "Always allow this session" decision.
 *
 * Claude Code's suggestions are reused when present but rescoped to
 * `destination: "session"` — echoing them verbatim would persist the
 * session-only choice as a permanent rule (suggestions typically target
 * `localSettings`, i.e. `.claude/settings.local.json`). When Claude Code
 * offers no suggestion — common for MCP tools — fall back to a whole-tool
 * session allow rule so the decision still sticks for the session instead of
 * silently degrading into a one-shot accept.
 */
function toSessionPermissionUpdates(
 toolName: string,
 suggestions: ReadonlyArray<PermissionUpdate> | undefined,
): Array<PermissionUpdate> {
 const sessionScoped = (suggestions ?? []).map(
 (suggestion): PermissionUpdate => ({ ...suggestion, destination: "session" }),
 );
 if (sessionScoped.length > 0) {
 return sessionScoped;
 }
 return [
 {
 type: "addRules",
 rules: [{ toolName }],
 behavior: "allow",
 destination: "session",
 },
 ];
}

interface PendingUserInput {
 readonly questions: ReadonlyArray<UserInputQuestion>;
 readonly answers: Deferred.Deferred<ProviderUserInputAnswers>;
Expand DownExpand Up@@ -3465,9 +3496,12 @@ export const makeClaudeAdapter = Effect.fn("makeClaudeAdapter")(function* (
 return {
 behavior: "allow",
 updatedInput: toolInput,
 ...(decision === "acceptForSession" && pendingApproval.suggestions
 ...(decision === "acceptForSession"
 ? {
 updatedPermissions: [...pendingApproval.suggestions],
 updatedPermissions: toSessionPermissionUpdates(
 toolName,
 pendingApproval.suggestions,
 ),
 }
 : {}),
 } satisfies PermissionResult;
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix(claude): make "Always allow for session" stick, and only for the session by kakismash · Pull Request #5041 · pingdotgg/t3code · GitHub
Skip to content
fix(claude): make "Always allow for session" stick, and only for the session#5041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

juliusmarminge
merged 1 commit into

from

Aug 15, 2026
 Merged


fix(claude): make "Always allow for session" stick, and only for the session
#5041
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


112 changes: 112 additions & 0 deletions
apps/server/src/provider/Layers/ClaudeAdapter.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2882,6 +2882,118 @@ describe("ClaudeAdapterLive", () => {
 );
 });

 it.effect("acceptForSession returns session-scoped permission updates", () => {
 const harness = makeHarness();
 return Effect.gen(function* () {
 const adapter = yield* ClaudeAdapter;

 const session = yield* adapter.startSession({
 threadId: THREAD_ID,
 provider: ProviderDriverKind.make("claudeAgent"),
 runtimeMode: "approval-required",
 });

 yield* Stream.take(adapter.streamEvents, 3).pipe(Stream.runDrain);

 yield* adapter.sendTurn({
 threadId: session.threadId,
 input: "approve this for the session",
 attachments: [],
 });
 yield* Stream.take(adapter.streamEvents, 1).pipe(Stream.runDrain);

 const createInput = harness.getLastCreateQueryInput();
 const canUseTool = createInput?.options.canUseTool;
 assert.equal(typeof canUseTool, "function");
 if (!canUseTool) {
 return;
 }

 const respondToNextRequest = Effect.gen(function* () {
 const requested = yield* Stream.runHead(adapter.streamEvents);
 assert.equal(requested._tag, "Some");
 if (requested._tag !== "Some" || requested.value.type !== "request.opened") {
 return;
 }
 const runtimeRequestId = requested.value.requestId;
 assert.equal(typeof runtimeRequestId, "string");
 if (runtimeRequestId === undefined) {
 return;
 }
 yield* adapter.respondToRequest(
 session.threadId,
 ApprovalRequestId.make(runtimeRequestId),
 "acceptForSession",
 );
 yield* Stream.take(adapter.streamEvents, 1).pipe(Stream.runDrain);
 });

 // MCP tools frequently arrive with no usable suggestion (Claude Code
 // sends an empty array); the decision must still stick for the session.
 const mcpPermissionPromise = canUseTool(
 "mcp__linear__create_issue",
 { title: "hello" },
 {
 signal: new AbortController().signal,
 suggestions: [],
 toolUseID: "tool-use-mcp-1",
 },
 );
 yield* respondToNextRequest;
 const mcpPermission = (yield* Effect.promise(() => mcpPermissionPromise)) as PermissionResult;
 assert.equal(mcpPermission.behavior, "allow");
 if (mcpPermission.behavior !== "allow") {
 return;
 }
 assert.deepEqual(mcpPermission.updatedPermissions, [
 {
 type: "addRules",
 rules: [{ toolName: "mcp__linear__create_issue" }],
 behavior: "allow",
 destination: "session",
 },
 ]);

 // Received suggestions are reused but rescoped to the session —
 // echoing "localSettings" would persist a session-only choice to disk.
 const bashPermissionPromise = canUseTool(
 "Bash",
 { command: "git status" },
 {
 signal: new AbortController().signal,
 suggestions: [
 {
 type: "addRules",
 rules: [{ toolName: "Bash", ruleContent: "git status" }],
 behavior: "allow",
 destination: "localSettings",
 },
 ],
 toolUseID: "tool-use-bash-1",
 },
 );
 yield* respondToNextRequest;
 const bashPermission = (yield* Effect.promise(
 () => bashPermissionPromise,
 )) as PermissionResult;
 assert.equal(bashPermission.behavior, "allow");
 if (bashPermission.behavior !== "allow") {
 return;
 }
 assert.deepEqual(bashPermission.updatedPermissions, [
 {
 type: "addRules",
 rules: [{ toolName: "Bash", ruleContent: "git status" }],
 behavior: "allow",
 destination: "session",
 },
 ]);
 }).pipe(
 Effect.provideService(Random.Random, makeDeterministicRandomService()),
 Effect.provide(harness.layer),
 );
 });

 it.effect("classifies Agent tools and read-only Claude tools correctly for approvals", () => {
 const harness = makeHarness();
 return Effect.gen(function* () {
Expand Down

38 changes: 36 additions & 2 deletions
apps/server/src/provider/Layers/ClaudeAdapter.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -155,6 +155,37 @@ interface PendingApproval {
 readonly decision: Deferred.Deferred<ProviderApprovalDecision>;
}

/**
 * Permission updates applied for an "Always allow this session" decision.
 *
 * Claude Code's suggestions are reused when present but rescoped to
 * `destination: "session"` — echoing them verbatim would persist the
 * session-only choice as a permanent rule (suggestions typically target
 * `localSettings`, i.e. `.claude/settings.local.json`). When Claude Code
 * offers no suggestion — common for MCP tools — fall back to a whole-tool
 * session allow rule so the decision still sticks for the session instead of
 * silently degrading into a one-shot accept.
 */
function toSessionPermissionUpdates(
 toolName: string,
 suggestions: ReadonlyArray<PermissionUpdate> | undefined,
): Array<PermissionUpdate> {
 const sessionScoped = (suggestions ?? []).map(
 (suggestion): PermissionUpdate => ({ ...suggestion, destination: "session" }),
 );
 if (sessionScoped.length > 0) {
 return sessionScoped;
 }
 return [
 {
 type: "addRules",
 rules: [{ toolName }],
 behavior: "allow",
 destination: "session",
 },
 ];
}

interface PendingUserInput {
 readonly questions: ReadonlyArray<UserInputQuestion>;
 readonly answers: Deferred.Deferred<ProviderUserInputAnswers>;
Expand DownExpand Up@@ -3465,9 +3496,12 @@ export const makeClaudeAdapter = Effect.fn("makeClaudeAdapter")(function* (
 return {
 behavior: "allow",
 updatedInput: toolInput,
 ...(decision === "acceptForSession" && pendingApproval.suggestions
 ...(decision === "acceptForSession"
 ? {
 updatedPermissions: [...pendingApproval.suggestions],
 updatedPermissions: toSessionPermissionUpdates(
 toolName,
 pendingApproval.suggestions,
 ),
 }
 : {}),
 } satisfies PermissionResult;
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
fix(claude): make "Always allow for session" stick, and only for the session by kakismash · Pull Request #5041 · pingdotgg/t3code · GitHub
Skip to content
fix(claude): make "Always allow for session" stick, and only for the session#5041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

juliusmarminge
merged 1 commit into

from

Aug 15, 2026
 Merged


fix(claude): make "Always allow for session" stick, and only for the session
#5041
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


112 changes: 112 additions & 0 deletions
apps/server/src/provider/Layers/ClaudeAdapter.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2882,6 +2882,118 @@ describe("ClaudeAdapterLive", () => {
 );
 });

 it.effect("acceptForSession returns session-scoped permission updates", () => {
 const harness = makeHarness();
 return Effect.gen(function* () {
 const adapter = yield* ClaudeAdapter;

 const session = yield* adapter.startSession({
 threadId: THREAD_ID,
 provider: ProviderDriverKind.make("claudeAgent"),
 runtimeMode: "approval-required",
 });

 yield* Stream.take(adapter.streamEvents, 3).pipe(Stream.runDrain);

 yield* adapter.sendTurn({
 threadId: session.threadId,
 input: "approve this for the session",
 attachments: [],
 });
 yield* Stream.take(adapter.streamEvents, 1).pipe(Stream.runDrain);

 const createInput = harness.getLastCreateQueryInput();
 const canUseTool = createInput?.options.canUseTool;
 assert.equal(typeof canUseTool, "function");
 if (!canUseTool) {
 return;
 }

 const respondToNextRequest = Effect.gen(function* () {
 const requested = yield* Stream.runHead(adapter.streamEvents);
 assert.equal(requested._tag, "Some");
 if (requested._tag !== "Some" || requested.value.type !== "request.opened") {
 return;
 }
 const runtimeRequestId = requested.value.requestId;
 assert.equal(typeof runtimeRequestId, "string");
 if (runtimeRequestId === undefined) {
 return;
 }
 yield* adapter.respondToRequest(
 session.threadId,
 ApprovalRequestId.make(runtimeRequestId),
 "acceptForSession",
 );
 yield* Stream.take(adapter.streamEvents, 1).pipe(Stream.runDrain);
 });

 // MCP tools frequently arrive with no usable suggestion (Claude Code
 // sends an empty array); the decision must still stick for the session.
 const mcpPermissionPromise = canUseTool(
 "mcp__linear__create_issue",
 { title: "hello" },
 {
 signal: new AbortController().signal,
 suggestions: [],
 toolUseID: "tool-use-mcp-1",
 },
 );
 yield* respondToNextRequest;
 const mcpPermission = (yield* Effect.promise(() => mcpPermissionPromise)) as PermissionResult;
 assert.equal(mcpPermission.behavior, "allow");
 if (mcpPermission.behavior !== "allow") {
 return;
 }
 assert.deepEqual(mcpPermission.updatedPermissions, [
 {
 type: "addRules",
 rules: [{ toolName: "mcp__linear__create_issue" }],
 behavior: "allow",
 destination: "session",
 },
 ]);

 // Received suggestions are reused but rescoped to the session —
 // echoing "localSettings" would persist a session-only choice to disk.
 const bashPermissionPromise = canUseTool(
 "Bash",
 { command: "git status" },
 {
 signal: new AbortController().signal,
 suggestions: [
 {
 type: "addRules",
 rules: [{ toolName: "Bash", ruleContent: "git status" }],
 behavior: "allow",
 destination: "localSettings",
 },
 ],
 toolUseID: "tool-use-bash-1",
 },
 );
 yield* respondToNextRequest;
 const bashPermission = (yield* Effect.promise(
 () => bashPermissionPromise,
 )) as PermissionResult;
 assert.equal(bashPermission.behavior, "allow");
 if (bashPermission.behavior !== "allow") {
 return;
 }
 assert.deepEqual(bashPermission.updatedPermissions, [
 {
 type: "addRules",
 rules: [{ toolName: "Bash", ruleContent: "git status" }],
 behavior: "allow",
 destination: "session",
 },
 ]);
 }).pipe(
 Effect.provideService(Random.Random, makeDeterministicRandomService()),
 Effect.provide(harness.layer),
 );
 });

 it.effect("classifies Agent tools and read-only Claude tools correctly for approvals", () => {
 const harness = makeHarness();
 return Effect.gen(function* () {
Expand Down

38 changes: 36 additions & 2 deletions
apps/server/src/provider/Layers/ClaudeAdapter.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -155,6 +155,37 @@ interface PendingApproval {
 readonly decision: Deferred.Deferred<ProviderApprovalDecision>;
}

/**
 * Permission updates applied for an "Always allow this session" decision.
 *
 * Claude Code's suggestions are reused when present but rescoped to
 * `destination: "session"` — echoing them verbatim would persist the
 * session-only choice as a permanent rule (suggestions typically target
 * `localSettings`, i.e. `.claude/settings.local.json`). When Claude Code
 * offers no suggestion — common for MCP tools — fall back to a whole-tool
 * session allow rule so the decision still sticks for the session instead of
 * silently degrading into a one-shot accept.
 */
function toSessionPermissionUpdates(
 toolName: string,
 suggestions: ReadonlyArray<PermissionUpdate> | undefined,
): Array<PermissionUpdate> {
 const sessionScoped = (suggestions ?? []).map(
 (suggestion): PermissionUpdate => ({ ...suggestion, destination: "session" }),
 );
 if (sessionScoped.length > 0) {
 return sessionScoped;
 }
 return [
 {
 type: "addRules",
 rules: [{ toolName }],
 behavior: "allow",
 destination: "session",
 },
 ];
}

interface PendingUserInput {
 readonly questions: ReadonlyArray<UserInputQuestion>;
 readonly answers: Deferred.Deferred<ProviderUserInputAnswers>;
Expand DownExpand Up@@ -3465,9 +3496,12 @@ export const makeClaudeAdapter = Effect.fn("makeClaudeAdapter")(function* (
 return {
 behavior: "allow",
 updatedInput: toolInput,
 ...(decision === "acceptForSession" && pendingApproval.suggestions
 ...(decision === "acceptForSession"
 ? {
 updatedPermissions: [...pendingApproval.suggestions],
 updatedPermissions: toSessionPermissionUpdates(
 toolName,
 pendingApproval.suggestions,
 ),
 }
 : {}),
 } satisfies PermissionResult;
Expand Down
Loading