Uh oh!
There was an error while loading. Please reload this page.
feat(orchestrator): Surface Grok reasoning effort options - #5160
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Uh oh!
There was an error while loading. Please reload this page.
bbf8c77 to
d48e1e6Compared48e1e6 to
f2dc065CompareUh oh!
There was an error while loading. Please reload this page.
f2dc065 to
80e716cCompareUh oh!
There was an error while loading. Please reload this page.
80e716c to
aec2a42CompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
7880dc6 to
f4e2dfbComparea543fd4 to
378615bComparef4e2dfb to
2bf703aCompareUh oh!
There was an error while loading. Please reload this page.
2bf703a to
de862bdCompareUh oh!
There was an error while loading. Please reload this page.
de862bd to
d0d9f70Comparec5e53c8 to
922f352Comparee24b59c to
4213ac5Compared0d9f70 to
bc87a35CompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
6590540 to
ed0a330CompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
72e3863 to
a186d64CompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
ecac175 to
2c29c37CompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
mwolson
commented
Aug 12, 2026
mwolson
commented
Aug 12, 2026
a186d64 to
5b1a115Compare519c42a to
4c55679Compare1322776 to
64cbc0cCompareThere was a problem hiding this comment.
Reviewed the web UI changes for the session-bound provider-option lock (ChatView, ChatComposer, TraitsPicker, composerProviderState). Prop forwarding through composerProviderState and the display/dispatch split look consistent with the shared control contracts. Two findings on the new locked-option interaction.
Posted via Macroscope — UI Consistency
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
CI Check fails on current CTM because layerTest now surfaces ServerSettingsError while the ProviderSessionManager test layer requires never. orDie matches the other test layers.
Advertise Grok reasoning effort from ACP model metadata, with a known grok-4.5 fallback when metadata is absent, and apply the selected CLI-safe value through the agent spawn flag. Treat reasoning effort as a spawn-bound ACP option so active sessions reject changes, runtime restore paths preserve the applied value, and generic session configuration ignores it. Keep web and mobile selections aligned with the committed session, including durable mobile outbox delivery, while allowing cross-provider handoffs.
Grok 4.6 advertises Extra High and High as default. The picker badges every isDefault row, so keep at most one and prefer the advertised current effort.
9c587c9 to
b59e2d3CompareUh oh!
There was an error while loading. Please reload this page.
t3dotgg
commented
Aug 23, 2026
Note 🤖 GPT-5.6 Sol responding on behalf of Theo Closing this PR after an automated pass over open pull requests. Large stale reasoning-controls draft duplicates trusted Grok work in #6386. |



Summary
each model's ACP menu (Grok 4.5: Low / Medium / High; Grok 4.6 also includes
Extra High).
active conversation through ACP
session/set_modelmetadata.resumed, and restarted ACP sessions, including first-party text generation.
prefer the advertised current effort.
Problem and Fix
session/set_modelmetadata, while the generic ACP adapter previously treated model selection as only a model-id change.{ reasoningEffort }metadata so the next turn can apply either change in the same conversation.default: true, so the picker showed two Default badges.Defensive Fixes
UI Changes
After: Grok models with reasoning support expose their advertised choices in
the composer. Grok 4.6 shows Extra High when that is the advertised current
effort, with a single Default badge in the open menu.
A video is not applicable because this change has no animation or timing
behavior.
Validation
prompt, loaded the same session in a fresh runtime, and read Low back from
the advertised model metadata. Grok's durable session history recorded
"reasoning_effort":"low"on those assistant messages.High. Subsequent assistant messages recorded
"reasoning_effort":"xhigh".Grok 4.6 shows Extra High selected and a single Default badge on Extra High.
catalog, and Extra High as the current effort.
Checklist
Note
Surface Grok reasoning effort as a spawn-bound option in the orchestrator and UI
GROK_REASONING_EFFORT_OPTION_IDand supporting utilities in GrokAcpSupport.ts to resolve and pass--reasoning-effortas a CLI flag when spawning the Grok agent process.spawnOptionIdson flavors, excluding those options from ACP config validation andsetConfigOptioncalls, and logging a warning on mismatch._metaand advertise aReasoningselect capability on discovered Grok models, with a fallback for grok-4.5.📊 Macroscope summarized 64cbc0c. 26 files reviewed, 0 issues evaluated, 0 issues filtered, 0 comments posted
🗂️ Filtered Issues
No issues evaluated.