feat(web): open files in containing folder - #5366

Closed
t3-code[bot] wants to merge 9 commits into
mainfrom
feat/open-files-in-folder
Closed

feat(web): open files in containing folder#5366
t3-code[bot] wants to merge 9 commits into
mainfrom
feat/open-files-in-folder

Conversation

@t3-code

@t3-codet3-codeBot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

1|## problem
2|
3|file link context menus can open files in editors or copy their paths, but cannot reveal them in the host file manager.
4|
5|## fix
6|
7|- add an "Open in folder" action to markdown file chip context menus
8|- route the action through the thread's environment so remote hosts open their own file manager
9|- reveal files with Finder and Windows Explorer, and open the containing directory on Linux
10|- add launcher and websocket routing coverage
11|
12|## testing
13|
14|- GOMAXPROCS=2 pnpm --filter @t3tools/contracts typecheck
15|- GOMAXPROCS=2 pnpm --filter @t3tools/client-runtime typecheck
16|- GOMAXPROCS=2 pnpm --filter t3 typecheck
17|- GOMAXPROCS=1 pnpm --filter @t3tools/web typecheck
18|- GOMAXPROCS=2 pnpm --filter t3 exec vp test run src/process/externalLauncher.test.ts
19|- GOMAXPROCS=2 pnpm --filter t3 exec vp test run src/server.test.ts -t "routes websocket rpc shell.revealInFileManager"
20|
21|model: gpt-5.4
22|harness: t3bot
23|
24|


Note

Medium Risk
Spawns host processes from user-supplied paths and branches on SSH/WSL/session env; scope is bounded by capability gating and operate-scope auth, with broad platform test coverage.

Overview
Adds Open in folder for chat markdown file links, wired through a new shell.revealInFileManager RPC and a fileManagerReveal server capability so clients only show the action when the host can reveal paths.

The server’s external launcher now spawns the OS file manager with platform-specific behavior (Finder -R, Explorer /select,, Linux xdg-open on the parent folder), including WSL-without-display via explorer.exe and UNC paths. File-manager availability is gated on graphical sessions and suppressed for headless Linux, SSH, and Windows service contexts.

The web UI routes reveals through the thread’s environment, extends file-link context menus, and tightens markdown link handling (richer destination parsing, AST tagging so only real markdown links become file chips—not raw HTML or nested inline-code false positives).

Reviewed by Cursor Bugbot for commit bae4628. Bugbot is set up for automated code reviews on this repo. Configure here.

40|
41|

Note

Add 'Open in folder' file reveal action to chat file links

  • Adds a new shell.revealInFileManager WebSocket RPC that spawns the OS file manager to reveal or open the containing folder of a file path.
  • Server advertises a fileManagerReveal capability; the UI gates the 'Open in folder' context menu item on this capability, connection phase, and available editors.
  • Handles cross-platform behavior: macOS uses open -R, Windows uses explorer /select,, Linux uses xdg-open on the containing folder, and WSL without a display uses explorer.exe with UNC paths.
  • File manager availability is suppressed for headless, SSH, and Windows service sessions.
  • Improves markdown link parsing to support angle-bracketed destinations, balanced parentheses, spaces, and escapes, and distinguishes markdown-generated anchors from raw HTML anchors to avoid false file link matches.

Macroscope summarized bae4628.

58|

1|## request provenance
2|
3|- requested by: @MatthewFeroz
4|
5|
6|

@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:L 100-499 changed lines (additions + deletions). labels Aug 4, 2026
Comment threadapps/web/src/components/ChatMarkdown.tsx
Comment threadapps/server/src/process/externalLauncher.ts Outdated
@macroscopeapp

macroscopeappBot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Needs human review

This PR introduces a new feature ('open files in containing folder') with a new RPC endpoint, authorization scope, server capability, cross-platform file manager integration, and user-facing context menu functionality. New features introducing user-facing behavior and authorization changes warrant human review.

No code changes detected at bae4628. Prior analysis still applies.

You can customize Macroscope's approvability policy. Learn more.

@t3-code
t3-codeBotforce-pushed the feat/open-files-in-folder branch from c5ce623 to 71d99eeCompareAugust 5, 2026 01:40
@t3-code

t3-codeBot commented Aug 5, 2026

Copy link
Copy Markdown
ContributorAuthor

updated the review fixes: open in folder is first and only appears when the file’s connected environment advertises both the reveal rpc and an available file manager. added focused menu-order and visibility tests.

open in folder first

@t3-code
t3-codeBotforce-pushed the feat/open-files-in-folder branch from 47284e0 to 316bb7dCompareAugust 5, 2026 05:26
Comment threadapps/server/src/process/externalLauncher.ts
@t3-code
t3-codeBotforce-pushed the feat/open-files-in-folder branch 2 times, most recently from 0647b60 to 8709943CompareAugust 8, 2026 02:38
Comment threadapps/web/src/markdown-links.ts Outdated
@github-actions

github-actionsBot commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wire11.3 KiB11.3 KiB+7 B (+0.1%)15.1 KiB
CodexThread snapshot wire5.5 KiB5.5 KiB−4 B (−0.1%)7.3 KiB
CodexLive turn WebSocket wire5.9 KiB5.9 KiB+11 B (+0.2%)7.8 KiB
CodexLive turn WebSocket decoded49.7 KiB49.7 KiB0 B (0.0%)66.4 KiB
CodexLive turn messages16160 (0.0%)21
ClaudeTotal thread wire11.3 KiB11.3 KiB+10 B (+0.1%)15.1 KiB
ClaudeThread snapshot wire5.5 KiB5.5 KiB+2 B (+0.0%)7.3 KiB
ClaudeLive turn WebSocket wire5.9 KiB5.9 KiB+8 B (+0.1%)7.8 KiB
ClaudeLive turn WebSocket decoded50.6 KiB50.6 KiB0 B (0.0%)66.4 KiB
ClaudeLive turn messages16160 (0.0%)21

Baseline: 8c628f1 · PR result: bae4628 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 94.6 KiB
  • Claude decoded thread snapshot: 95.4 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@github-actionsgithub-actionsBot added size:XL 500-999 changed lines (additions + deletions). 📱 Native Change Changes the native fingerprint; merging blocks production OTAs until a new store build ships. and removed size:L 100-499 changed lines (additions + deletions). labels Aug 10, 2026

@t3-codet3-codeBot left a comment

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed the full diff, existing review threads, and the result merged onto current main (e321667b1). i found no blocking issues.

verified on the merged tree:

  • contracts, client-runtime, server, and web typechecks
  • external launcher tests: 17 passed
  • markdown and file-link menu tests: 51 passed
  • rpc routing test: 1 passed
  • authorization and environment capability tests: 7 passed
  • targeted lint, formatting, and git diff --check

all github ci on 50f611eaf is green. the pr is technically mergeable. this is a comment review rather than a human approval, so a maintainer approval may still be required by policy.

Comment threadapps/web/src/components/ChatMarkdown.tsx

@t3-codet3-codeBot left a comment

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correction to my earlier review: two blocking edge cases were found and reproduced after a deeper parser/platform pass.

  1. apps/web/src/markdown-links.ts:181-214: the custom href scanner parses markdown-looking text inside inline code. [see \x`](src/real.ts)renders one link tosrc/real.ts, but the scanner returns only fake.ts. ChatMarkdown` therefore misses the real file link and routes it as a normal link.

  2. apps/server/src/process/externalLauncher.ts:241-260: WSL uses Explorer only when DISPLAY and WAYLAND_DISPLAY are absent. Standard WSLg sets those variables, so the code chooses Linux xdg-open instead of the available Windows Explorer. This can hide the action when xdg-open is absent or invoke a handler that cannot reveal the file. Current WSL coverage tests only the non-WSLg environment.

these should be fixed before merge. the malformed-destination performance concern was also tested, but i could not reproduce quadratic behavior in the actual implementation, so i am not including it as a finding.

@cursorcursorBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 8d5ba1b. Configure here.

Comment threadapps/web/src/components/ChatMarkdown.tsx
Co-authored-by: Matthew Feroz <136640686+MatthewFeroz@users.noreply.github.com>
@t3-code
t3-codeBotforce-pushed the feat/open-files-in-folder branch from 8d5ba1b to bae4628CompareAugust 15, 2026 02:53
@github-actionsgithub-actionsBot removed the 📱 Native Change Changes the native fingerprint; merging blocks production OTAs until a new store build ships. label Aug 15, 2026
@t3-code

t3-codeBot commented Aug 20, 2026

Copy link
Copy Markdown
ContributorAuthor

closing in favor of #6463, the newer and broader implementation with authorization, launcher, contract, client, and test coverage.

@t3-codet3-codeBot closed this Aug 20, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XL500-999 changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants

, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

feat(web): open files in containing folder - #5366

Closed
t3-code[bot] wants to merge 9 commits into
mainfrom
feat/open-files-in-folder
Closed

feat(web): open files in containing folder#5366
t3-code[bot] wants to merge 9 commits into
mainfrom
feat/open-files-in-folder

Conversation

@t3-code

@t3-codet3-codeBot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

1|## problem
2|
3|file link context menus can open files in editors or copy their paths, but cannot reveal them in the host file manager.
4|
5|## fix
6|
7|- add an "Open in folder" action to markdown file chip context menus
8|- route the action through the thread's environment so remote hosts open their own file manager
9|- reveal files with Finder and Windows Explorer, and open the containing directory on Linux
10|- add launcher and websocket routing coverage
11|
12|## testing
13|
14|- GOMAXPROCS=2 pnpm --filter @t3tools/contracts typecheck
15|- GOMAXPROCS=2 pnpm --filter @t3tools/client-runtime typecheck
16|- GOMAXPROCS=2 pnpm --filter t3 typecheck
17|- GOMAXPROCS=1 pnpm --filter @t3tools/web typecheck
18|- GOMAXPROCS=2 pnpm --filter t3 exec vp test run src/process/externalLauncher.test.ts
19|- GOMAXPROCS=2 pnpm --filter t3 exec vp test run src/server.test.ts -t "routes websocket rpc shell.revealInFileManager"
20|
21|model: gpt-5.4
22|harness: t3bot
23|
24|


Note

Medium Risk
Spawns host processes from user-supplied paths and branches on SSH/WSL/session env; scope is bounded by capability gating and operate-scope auth, with broad platform test coverage.

Overview
Adds Open in folder for chat markdown file links, wired through a new shell.revealInFileManager RPC and a fileManagerReveal server capability so clients only show the action when the host can reveal paths.

The server’s external launcher now spawns the OS file manager with platform-specific behavior (Finder -R, Explorer /select,, Linux xdg-open on the parent folder), including WSL-without-display via explorer.exe and UNC paths. File-manager availability is gated on graphical sessions and suppressed for headless Linux, SSH, and Windows service contexts.

The web UI routes reveals through the thread’s environment, extends file-link context menus, and tightens markdown link handling (richer destination parsing, AST tagging so only real markdown links become file chips—not raw HTML or nested inline-code false positives).

Reviewed by Cursor Bugbot for commit bae4628. Bugbot is set up for automated code reviews on this repo. Configure here.

40|
41|

Note

Add 'Open in folder' file reveal action to chat file links

  • Adds a new shell.revealInFileManager WebSocket RPC that spawns the OS file manager to reveal or open the containing folder of a file path.
  • Server advertises a fileManagerReveal capability; the UI gates the 'Open in folder' context menu item on this capability, connection phase, and available editors.
  • Handles cross-platform behavior: macOS uses open -R, Windows uses explorer /select,, Linux uses xdg-open on the containing folder, and WSL without a display uses explorer.exe with UNC paths.
  • File manager availability is suppressed for headless, SSH, and Windows service sessions.
  • Improves markdown link parsing to support angle-bracketed destinations, balanced parentheses, spaces, and escapes, and distinguishes markdown-generated anchors from raw HTML anchors to avoid false file link matches.

Macroscope summarized bae4628.

58|

1|## request provenance
2|
3|- requested by: @MatthewFeroz
4|
5|
6|

@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:L 100-499 changed lines (additions + deletions). labels Aug 4, 2026
Comment threadapps/web/src/components/ChatMarkdown.tsx
Comment threadapps/server/src/process/externalLauncher.ts Outdated
@macroscopeapp

macroscopeappBot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Needs human review

This PR introduces a new feature ('open files in containing folder') with a new RPC endpoint, authorization scope, server capability, cross-platform file manager integration, and user-facing context menu functionality. New features introducing user-facing behavior and authorization changes warrant human review.

No code changes detected at bae4628. Prior analysis still applies.

You can customize Macroscope's approvability policy. Learn more.

@t3-code
t3-codeBotforce-pushed the feat/open-files-in-folder branch from c5ce623 to 71d99eeCompareAugust 5, 2026 01:40
@t3-code

t3-codeBot commented Aug 5, 2026

Copy link
Copy Markdown
ContributorAuthor

updated the review fixes: open in folder is first and only appears when the file’s connected environment advertises both the reveal rpc and an available file manager. added focused menu-order and visibility tests.

open in folder first

@t3-code
t3-codeBotforce-pushed the feat/open-files-in-folder branch from 47284e0 to 316bb7dCompareAugust 5, 2026 05:26
Comment threadapps/server/src/process/externalLauncher.ts
@t3-code
t3-codeBotforce-pushed the feat/open-files-in-folder branch 2 times, most recently from 0647b60 to 8709943CompareAugust 8, 2026 02:38
Comment threadapps/web/src/markdown-links.ts Outdated
@github-actions

github-actionsBot commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wire11.3 KiB11.3 KiB+7 B (+0.1%)15.1 KiB
CodexThread snapshot wire5.5 KiB5.5 KiB−4 B (−0.1%)7.3 KiB
CodexLive turn WebSocket wire5.9 KiB5.9 KiB+11 B (+0.2%)7.8 KiB
CodexLive turn WebSocket decoded49.7 KiB49.7 KiB0 B (0.0%)66.4 KiB
CodexLive turn messages16160 (0.0%)21
ClaudeTotal thread wire11.3 KiB11.3 KiB+10 B (+0.1%)15.1 KiB
ClaudeThread snapshot wire5.5 KiB5.5 KiB+2 B (+0.0%)7.3 KiB
ClaudeLive turn WebSocket wire5.9 KiB5.9 KiB+8 B (+0.1%)7.8 KiB
ClaudeLive turn WebSocket decoded50.6 KiB50.6 KiB0 B (0.0%)66.4 KiB
ClaudeLive turn messages16160 (0.0%)21

Baseline: 8c628f1 · PR result: bae4628 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 94.6 KiB
  • Claude decoded thread snapshot: 95.4 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@github-actionsgithub-actionsBot added size:XL 500-999 changed lines (additions + deletions). 📱 Native Change Changes the native fingerprint; merging blocks production OTAs until a new store build ships. and removed size:L 100-499 changed lines (additions + deletions). labels Aug 10, 2026

@t3-codet3-codeBot left a comment

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed the full diff, existing review threads, and the result merged onto current main (e321667b1). i found no blocking issues.

verified on the merged tree:

  • contracts, client-runtime, server, and web typechecks
  • external launcher tests: 17 passed
  • markdown and file-link menu tests: 51 passed
  • rpc routing test: 1 passed
  • authorization and environment capability tests: 7 passed
  • targeted lint, formatting, and git diff --check

all github ci on 50f611eaf is green. the pr is technically mergeable. this is a comment review rather than a human approval, so a maintainer approval may still be required by policy.

Comment threadapps/web/src/components/ChatMarkdown.tsx

@t3-codet3-codeBot left a comment

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correction to my earlier review: two blocking edge cases were found and reproduced after a deeper parser/platform pass.

  1. apps/web/src/markdown-links.ts:181-214: the custom href scanner parses markdown-looking text inside inline code. [see \x`](src/real.ts)renders one link tosrc/real.ts, but the scanner returns only fake.ts. ChatMarkdown` therefore misses the real file link and routes it as a normal link.

  2. apps/server/src/process/externalLauncher.ts:241-260: WSL uses Explorer only when DISPLAY and WAYLAND_DISPLAY are absent. Standard WSLg sets those variables, so the code chooses Linux xdg-open instead of the available Windows Explorer. This can hide the action when xdg-open is absent or invoke a handler that cannot reveal the file. Current WSL coverage tests only the non-WSLg environment.

these should be fixed before merge. the malformed-destination performance concern was also tested, but i could not reproduce quadratic behavior in the actual implementation, so i am not including it as a finding.

@cursorcursorBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 8d5ba1b. Configure here.

Comment threadapps/web/src/components/ChatMarkdown.tsx
Co-authored-by: Matthew Feroz <136640686+MatthewFeroz@users.noreply.github.com>
@t3-code
t3-codeBotforce-pushed the feat/open-files-in-folder branch from 8d5ba1b to bae4628CompareAugust 15, 2026 02:53
@github-actionsgithub-actionsBot removed the 📱 Native Change Changes the native fingerprint; merging blocks production OTAs until a new store build ships. label Aug 15, 2026
@t3-code

t3-codeBot commented Aug 20, 2026

Copy link
Copy Markdown
ContributorAuthor

closing in favor of #6463, the newer and broader implementation with authorization, launcher, contract, client, and test coverage.

@t3-codet3-codeBot closed this Aug 20, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XL500-999 changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants

, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

feat(web): open files in containing folder - #5366

Closed
t3-code[bot] wants to merge 9 commits into
mainfrom
feat/open-files-in-folder
Closed

feat(web): open files in containing folder#5366
t3-code[bot] wants to merge 9 commits into
mainfrom
feat/open-files-in-folder

Conversation

@t3-code

@t3-codet3-codeBot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

1|## problem
2|
3|file link context menus can open files in editors or copy their paths, but cannot reveal them in the host file manager.
4|
5|## fix
6|
7|- add an "Open in folder" action to markdown file chip context menus
8|- route the action through the thread's environment so remote hosts open their own file manager
9|- reveal files with Finder and Windows Explorer, and open the containing directory on Linux
10|- add launcher and websocket routing coverage
11|
12|## testing
13|
14|- GOMAXPROCS=2 pnpm --filter @t3tools/contracts typecheck
15|- GOMAXPROCS=2 pnpm --filter @t3tools/client-runtime typecheck
16|- GOMAXPROCS=2 pnpm --filter t3 typecheck
17|- GOMAXPROCS=1 pnpm --filter @t3tools/web typecheck
18|- GOMAXPROCS=2 pnpm --filter t3 exec vp test run src/process/externalLauncher.test.ts
19|- GOMAXPROCS=2 pnpm --filter t3 exec vp test run src/server.test.ts -t "routes websocket rpc shell.revealInFileManager"
20|
21|model: gpt-5.4
22|harness: t3bot
23|
24|


Note

Medium Risk
Spawns host processes from user-supplied paths and branches on SSH/WSL/session env; scope is bounded by capability gating and operate-scope auth, with broad platform test coverage.

Overview
Adds Open in folder for chat markdown file links, wired through a new shell.revealInFileManager RPC and a fileManagerReveal server capability so clients only show the action when the host can reveal paths.

The server’s external launcher now spawns the OS file manager with platform-specific behavior (Finder -R, Explorer /select,, Linux xdg-open on the parent folder), including WSL-without-display via explorer.exe and UNC paths. File-manager availability is gated on graphical sessions and suppressed for headless Linux, SSH, and Windows service contexts.

The web UI routes reveals through the thread’s environment, extends file-link context menus, and tightens markdown link handling (richer destination parsing, AST tagging so only real markdown links become file chips—not raw HTML or nested inline-code false positives).

Reviewed by Cursor Bugbot for commit bae4628. Bugbot is set up for automated code reviews on this repo. Configure here.

40|
41|

Note

Add 'Open in folder' file reveal action to chat file links

  • Adds a new shell.revealInFileManager WebSocket RPC that spawns the OS file manager to reveal or open the containing folder of a file path.
  • Server advertises a fileManagerReveal capability; the UI gates the 'Open in folder' context menu item on this capability, connection phase, and available editors.
  • Handles cross-platform behavior: macOS uses open -R, Windows uses explorer /select,, Linux uses xdg-open on the containing folder, and WSL without a display uses explorer.exe with UNC paths.
  • File manager availability is suppressed for headless, SSH, and Windows service sessions.
  • Improves markdown link parsing to support angle-bracketed destinations, balanced parentheses, spaces, and escapes, and distinguishes markdown-generated anchors from raw HTML anchors to avoid false file link matches.

Macroscope summarized bae4628.

58|

1|## request provenance
2|
3|- requested by: @MatthewFeroz
4|
5|
6|

@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:L 100-499 changed lines (additions + deletions). labels Aug 4, 2026
Comment threadapps/web/src/components/ChatMarkdown.tsx
Comment threadapps/server/src/process/externalLauncher.ts Outdated
@macroscopeapp

macroscopeappBot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Needs human review

This PR introduces a new feature ('open files in containing folder') with a new RPC endpoint, authorization scope, server capability, cross-platform file manager integration, and user-facing context menu functionality. New features introducing user-facing behavior and authorization changes warrant human review.

No code changes detected at bae4628. Prior analysis still applies.

You can customize Macroscope's approvability policy. Learn more.

@t3-code
t3-codeBotforce-pushed the feat/open-files-in-folder branch from c5ce623 to 71d99eeCompareAugust 5, 2026 01:40
@t3-code

t3-codeBot commented Aug 5, 2026

Copy link
Copy Markdown
ContributorAuthor

updated the review fixes: open in folder is first and only appears when the file’s connected environment advertises both the reveal rpc and an available file manager. added focused menu-order and visibility tests.

open in folder first

@t3-code
t3-codeBotforce-pushed the feat/open-files-in-folder branch from 47284e0 to 316bb7dCompareAugust 5, 2026 05:26
Comment threadapps/server/src/process/externalLauncher.ts
@t3-code
t3-codeBotforce-pushed the feat/open-files-in-folder branch 2 times, most recently from 0647b60 to 8709943CompareAugust 8, 2026 02:38
Comment threadapps/web/src/markdown-links.ts Outdated
@github-actions

github-actionsBot commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wire11.3 KiB11.3 KiB+7 B (+0.1%)15.1 KiB
CodexThread snapshot wire5.5 KiB5.5 KiB−4 B (−0.1%)7.3 KiB
CodexLive turn WebSocket wire5.9 KiB5.9 KiB+11 B (+0.2%)7.8 KiB
CodexLive turn WebSocket decoded49.7 KiB49.7 KiB0 B (0.0%)66.4 KiB
CodexLive turn messages16160 (0.0%)21
ClaudeTotal thread wire11.3 KiB11.3 KiB+10 B (+0.1%)15.1 KiB
ClaudeThread snapshot wire5.5 KiB5.5 KiB+2 B (+0.0%)7.3 KiB
ClaudeLive turn WebSocket wire5.9 KiB5.9 KiB+8 B (+0.1%)7.8 KiB
ClaudeLive turn WebSocket decoded50.6 KiB50.6 KiB0 B (0.0%)66.4 KiB
ClaudeLive turn messages16160 (0.0%)21

Baseline: 8c628f1 · PR result: bae4628 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 94.6 KiB
  • Claude decoded thread snapshot: 95.4 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@github-actionsgithub-actionsBot added size:XL 500-999 changed lines (additions + deletions). 📱 Native Change Changes the native fingerprint; merging blocks production OTAs until a new store build ships. and removed size:L 100-499 changed lines (additions + deletions). labels Aug 10, 2026

@t3-codet3-codeBot left a comment

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed the full diff, existing review threads, and the result merged onto current main (e321667b1). i found no blocking issues.

verified on the merged tree:

  • contracts, client-runtime, server, and web typechecks
  • external launcher tests: 17 passed
  • markdown and file-link menu tests: 51 passed
  • rpc routing test: 1 passed
  • authorization and environment capability tests: 7 passed
  • targeted lint, formatting, and git diff --check

all github ci on 50f611eaf is green. the pr is technically mergeable. this is a comment review rather than a human approval, so a maintainer approval may still be required by policy.

Comment threadapps/web/src/components/ChatMarkdown.tsx

@t3-codet3-codeBot left a comment

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correction to my earlier review: two blocking edge cases were found and reproduced after a deeper parser/platform pass.

  1. apps/web/src/markdown-links.ts:181-214: the custom href scanner parses markdown-looking text inside inline code. [see \x`](src/real.ts)renders one link tosrc/real.ts, but the scanner returns only fake.ts. ChatMarkdown` therefore misses the real file link and routes it as a normal link.

  2. apps/server/src/process/externalLauncher.ts:241-260: WSL uses Explorer only when DISPLAY and WAYLAND_DISPLAY are absent. Standard WSLg sets those variables, so the code chooses Linux xdg-open instead of the available Windows Explorer. This can hide the action when xdg-open is absent or invoke a handler that cannot reveal the file. Current WSL coverage tests only the non-WSLg environment.

these should be fixed before merge. the malformed-destination performance concern was also tested, but i could not reproduce quadratic behavior in the actual implementation, so i am not including it as a finding.

@cursorcursorBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 8d5ba1b. Configure here.

Comment threadapps/web/src/components/ChatMarkdown.tsx
Co-authored-by: Matthew Feroz <136640686+MatthewFeroz@users.noreply.github.com>
@t3-code
t3-codeBotforce-pushed the feat/open-files-in-folder branch from 8d5ba1b to bae4628CompareAugust 15, 2026 02:53
@github-actionsgithub-actionsBot removed the 📱 Native Change Changes the native fingerprint; merging blocks production OTAs until a new store build ships. label Aug 15, 2026
@t3-code

t3-codeBot commented Aug 20, 2026

Copy link
Copy Markdown
ContributorAuthor

closing in favor of #6463, the newer and broader implementation with authorization, launcher, contract, client, and test coverage.

@t3-codet3-codeBot closed this Aug 20, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XL500-999 changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants

, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

feat(web): open files in containing folder - #5366

Closed
t3-code[bot] wants to merge 9 commits into
mainfrom
feat/open-files-in-folder
Closed

feat(web): open files in containing folder#5366
t3-code[bot] wants to merge 9 commits into
mainfrom
feat/open-files-in-folder

Conversation

@t3-code

@t3-codet3-codeBot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

1|## problem
2|
3|file link context menus can open files in editors or copy their paths, but cannot reveal them in the host file manager.
4|
5|## fix
6|
7|- add an "Open in folder" action to markdown file chip context menus
8|- route the action through the thread's environment so remote hosts open their own file manager
9|- reveal files with Finder and Windows Explorer, and open the containing directory on Linux
10|- add launcher and websocket routing coverage
11|
12|## testing
13|
14|- GOMAXPROCS=2 pnpm --filter @t3tools/contracts typecheck
15|- GOMAXPROCS=2 pnpm --filter @t3tools/client-runtime typecheck
16|- GOMAXPROCS=2 pnpm --filter t3 typecheck
17|- GOMAXPROCS=1 pnpm --filter @t3tools/web typecheck
18|- GOMAXPROCS=2 pnpm --filter t3 exec vp test run src/process/externalLauncher.test.ts
19|- GOMAXPROCS=2 pnpm --filter t3 exec vp test run src/server.test.ts -t "routes websocket rpc shell.revealInFileManager"
20|
21|model: gpt-5.4
22|harness: t3bot
23|
24|


Note

Medium Risk
Spawns host processes from user-supplied paths and branches on SSH/WSL/session env; scope is bounded by capability gating and operate-scope auth, with broad platform test coverage.

Overview
Adds Open in folder for chat markdown file links, wired through a new shell.revealInFileManager RPC and a fileManagerReveal server capability so clients only show the action when the host can reveal paths.

The server’s external launcher now spawns the OS file manager with platform-specific behavior (Finder -R, Explorer /select,, Linux xdg-open on the parent folder), including WSL-without-display via explorer.exe and UNC paths. File-manager availability is gated on graphical sessions and suppressed for headless Linux, SSH, and Windows service contexts.

The web UI routes reveals through the thread’s environment, extends file-link context menus, and tightens markdown link handling (richer destination parsing, AST tagging so only real markdown links become file chips—not raw HTML or nested inline-code false positives).

Reviewed by Cursor Bugbot for commit bae4628. Bugbot is set up for automated code reviews on this repo. Configure here.

40|
41|

Note

Add 'Open in folder' file reveal action to chat file links

  • Adds a new shell.revealInFileManager WebSocket RPC that spawns the OS file manager to reveal or open the containing folder of a file path.
  • Server advertises a fileManagerReveal capability; the UI gates the 'Open in folder' context menu item on this capability, connection phase, and available editors.
  • Handles cross-platform behavior: macOS uses open -R, Windows uses explorer /select,, Linux uses xdg-open on the containing folder, and WSL without a display uses explorer.exe with UNC paths.
  • File manager availability is suppressed for headless, SSH, and Windows service sessions.
  • Improves markdown link parsing to support angle-bracketed destinations, balanced parentheses, spaces, and escapes, and distinguishes markdown-generated anchors from raw HTML anchors to avoid false file link matches.

Macroscope summarized bae4628.

58|

1|## request provenance
2|
3|- requested by: @MatthewFeroz
4|
5|
6|

@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:L 100-499 changed lines (additions + deletions). labels Aug 4, 2026
Comment threadapps/web/src/components/ChatMarkdown.tsx
Comment threadapps/server/src/process/externalLauncher.ts Outdated
@macroscopeapp

macroscopeappBot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Needs human review

This PR introduces a new feature ('open files in containing folder') with a new RPC endpoint, authorization scope, server capability, cross-platform file manager integration, and user-facing context menu functionality. New features introducing user-facing behavior and authorization changes warrant human review.

No code changes detected at bae4628. Prior analysis still applies.

You can customize Macroscope's approvability policy. Learn more.

@t3-code
t3-codeBotforce-pushed the feat/open-files-in-folder branch from c5ce623 to 71d99eeCompareAugust 5, 2026 01:40
@t3-code

t3-codeBot commented Aug 5, 2026

Copy link
Copy Markdown
ContributorAuthor

updated the review fixes: open in folder is first and only appears when the file’s connected environment advertises both the reveal rpc and an available file manager. added focused menu-order and visibility tests.

open in folder first

@t3-code
t3-codeBotforce-pushed the feat/open-files-in-folder branch from 47284e0 to 316bb7dCompareAugust 5, 2026 05:26
Comment threadapps/server/src/process/externalLauncher.ts
@t3-code
t3-codeBotforce-pushed the feat/open-files-in-folder branch 2 times, most recently from 0647b60 to 8709943CompareAugust 8, 2026 02:38
Comment threadapps/web/src/markdown-links.ts Outdated
@github-actions

github-actionsBot commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wire11.3 KiB11.3 KiB+7 B (+0.1%)15.1 KiB
CodexThread snapshot wire5.5 KiB5.5 KiB−4 B (−0.1%)7.3 KiB
CodexLive turn WebSocket wire5.9 KiB5.9 KiB+11 B (+0.2%)7.8 KiB
CodexLive turn WebSocket decoded49.7 KiB49.7 KiB0 B (0.0%)66.4 KiB
CodexLive turn messages16160 (0.0%)21
ClaudeTotal thread wire11.3 KiB11.3 KiB+10 B (+0.1%)15.1 KiB
ClaudeThread snapshot wire5.5 KiB5.5 KiB+2 B (+0.0%)7.3 KiB
ClaudeLive turn WebSocket wire5.9 KiB5.9 KiB+8 B (+0.1%)7.8 KiB
ClaudeLive turn WebSocket decoded50.6 KiB50.6 KiB0 B (0.0%)66.4 KiB
ClaudeLive turn messages16160 (0.0%)21

Baseline: 8c628f1 · PR result: bae4628 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 94.6 KiB
  • Claude decoded thread snapshot: 95.4 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@github-actionsgithub-actionsBot added size:XL 500-999 changed lines (additions + deletions). 📱 Native Change Changes the native fingerprint; merging blocks production OTAs until a new store build ships. and removed size:L 100-499 changed lines (additions + deletions). labels Aug 10, 2026

@t3-codet3-codeBot left a comment

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed the full diff, existing review threads, and the result merged onto current main (e321667b1). i found no blocking issues.

verified on the merged tree:

  • contracts, client-runtime, server, and web typechecks
  • external launcher tests: 17 passed
  • markdown and file-link menu tests: 51 passed
  • rpc routing test: 1 passed
  • authorization and environment capability tests: 7 passed
  • targeted lint, formatting, and git diff --check

all github ci on 50f611eaf is green. the pr is technically mergeable. this is a comment review rather than a human approval, so a maintainer approval may still be required by policy.

Comment threadapps/web/src/components/ChatMarkdown.tsx

@t3-codet3-codeBot left a comment

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correction to my earlier review: two blocking edge cases were found and reproduced after a deeper parser/platform pass.

  1. apps/web/src/markdown-links.ts:181-214: the custom href scanner parses markdown-looking text inside inline code. [see \x`](src/real.ts)renders one link tosrc/real.ts, but the scanner returns only fake.ts. ChatMarkdown` therefore misses the real file link and routes it as a normal link.

  2. apps/server/src/process/externalLauncher.ts:241-260: WSL uses Explorer only when DISPLAY and WAYLAND_DISPLAY are absent. Standard WSLg sets those variables, so the code chooses Linux xdg-open instead of the available Windows Explorer. This can hide the action when xdg-open is absent or invoke a handler that cannot reveal the file. Current WSL coverage tests only the non-WSLg environment.

these should be fixed before merge. the malformed-destination performance concern was also tested, but i could not reproduce quadratic behavior in the actual implementation, so i am not including it as a finding.

@cursorcursorBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 8d5ba1b. Configure here.

Comment threadapps/web/src/components/ChatMarkdown.tsx
Co-authored-by: Matthew Feroz <136640686+MatthewFeroz@users.noreply.github.com>
@t3-code
t3-codeBotforce-pushed the feat/open-files-in-folder branch from 8d5ba1b to bae4628CompareAugust 15, 2026 02:53
@github-actionsgithub-actionsBot removed the 📱 Native Change Changes the native fingerprint; merging blocks production OTAs until a new store build ships. label Aug 15, 2026
@t3-code

t3-codeBot commented Aug 20, 2026

Copy link
Copy Markdown
ContributorAuthor

closing in favor of #6463, the newer and broader implementation with authorization, launcher, contract, client, and test coverage.

@t3-codet3-codeBot closed this Aug 20, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XL500-999 changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants

, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

feat(web): open files in containing folder - #5366

Closed
t3-code[bot] wants to merge 9 commits into
mainfrom
feat/open-files-in-folder
Closed

feat(web): open files in containing folder#5366
t3-code[bot] wants to merge 9 commits into
mainfrom
feat/open-files-in-folder

Conversation

@t3-code

@t3-codet3-codeBot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

1|## problem
2|
3|file link context menus can open files in editors or copy their paths, but cannot reveal them in the host file manager.
4|
5|## fix
6|
7|- add an "Open in folder" action to markdown file chip context menus
8|- route the action through the thread's environment so remote hosts open their own file manager
9|- reveal files with Finder and Windows Explorer, and open the containing directory on Linux
10|- add launcher and websocket routing coverage
11|
12|## testing
13|
14|- GOMAXPROCS=2 pnpm --filter @t3tools/contracts typecheck
15|- GOMAXPROCS=2 pnpm --filter @t3tools/client-runtime typecheck
16|- GOMAXPROCS=2 pnpm --filter t3 typecheck
17|- GOMAXPROCS=1 pnpm --filter @t3tools/web typecheck
18|- GOMAXPROCS=2 pnpm --filter t3 exec vp test run src/process/externalLauncher.test.ts
19|- GOMAXPROCS=2 pnpm --filter t3 exec vp test run src/server.test.ts -t "routes websocket rpc shell.revealInFileManager"
20|
21|model: gpt-5.4
22|harness: t3bot
23|
24|


Note

Medium Risk
Spawns host processes from user-supplied paths and branches on SSH/WSL/session env; scope is bounded by capability gating and operate-scope auth, with broad platform test coverage.

Overview
Adds Open in folder for chat markdown file links, wired through a new shell.revealInFileManager RPC and a fileManagerReveal server capability so clients only show the action when the host can reveal paths.

The server’s external launcher now spawns the OS file manager with platform-specific behavior (Finder -R, Explorer /select,, Linux xdg-open on the parent folder), including WSL-without-display via explorer.exe and UNC paths. File-manager availability is gated on graphical sessions and suppressed for headless Linux, SSH, and Windows service contexts.

The web UI routes reveals through the thread’s environment, extends file-link context menus, and tightens markdown link handling (richer destination parsing, AST tagging so only real markdown links become file chips—not raw HTML or nested inline-code false positives).

Reviewed by Cursor Bugbot for commit bae4628. Bugbot is set up for automated code reviews on this repo. Configure here.

40|
41|

Note

Add 'Open in folder' file reveal action to chat file links

  • Adds a new shell.revealInFileManager WebSocket RPC that spawns the OS file manager to reveal or open the containing folder of a file path.
  • Server advertises a fileManagerReveal capability; the UI gates the 'Open in folder' context menu item on this capability, connection phase, and available editors.
  • Handles cross-platform behavior: macOS uses open -R, Windows uses explorer /select,, Linux uses xdg-open on the containing folder, and WSL without a display uses explorer.exe with UNC paths.
  • File manager availability is suppressed for headless, SSH, and Windows service sessions.
  • Improves markdown link parsing to support angle-bracketed destinations, balanced parentheses, spaces, and escapes, and distinguishes markdown-generated anchors from raw HTML anchors to avoid false file link matches.

Macroscope summarized bae4628.

58|

1|## request provenance
2|
3|- requested by: @MatthewFeroz
4|
5|
6|

@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:L 100-499 changed lines (additions + deletions). labels Aug 4, 2026
Comment threadapps/web/src/components/ChatMarkdown.tsx
Comment threadapps/server/src/process/externalLauncher.ts Outdated
@macroscopeapp

macroscopeappBot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Needs human review

This PR introduces a new feature ('open files in containing folder') with a new RPC endpoint, authorization scope, server capability, cross-platform file manager integration, and user-facing context menu functionality. New features introducing user-facing behavior and authorization changes warrant human review.

No code changes detected at bae4628. Prior analysis still applies.

You can customize Macroscope's approvability policy. Learn more.

@t3-code
t3-codeBotforce-pushed the feat/open-files-in-folder branch from c5ce623 to 71d99eeCompareAugust 5, 2026 01:40
@t3-code

t3-codeBot commented Aug 5, 2026

Copy link
Copy Markdown
ContributorAuthor

updated the review fixes: open in folder is first and only appears when the file’s connected environment advertises both the reveal rpc and an available file manager. added focused menu-order and visibility tests.

open in folder first

@t3-code
t3-codeBotforce-pushed the feat/open-files-in-folder branch from 47284e0 to 316bb7dCompareAugust 5, 2026 05:26
Comment threadapps/server/src/process/externalLauncher.ts
@t3-code
t3-codeBotforce-pushed the feat/open-files-in-folder branch 2 times, most recently from 0647b60 to 8709943CompareAugust 8, 2026 02:38
Comment threadapps/web/src/markdown-links.ts Outdated
@github-actions

github-actionsBot commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wire11.3 KiB11.3 KiB+7 B (+0.1%)15.1 KiB
CodexThread snapshot wire5.5 KiB5.5 KiB−4 B (−0.1%)7.3 KiB
CodexLive turn WebSocket wire5.9 KiB5.9 KiB+11 B (+0.2%)7.8 KiB
CodexLive turn WebSocket decoded49.7 KiB49.7 KiB0 B (0.0%)66.4 KiB
CodexLive turn messages16160 (0.0%)21
ClaudeTotal thread wire11.3 KiB11.3 KiB+10 B (+0.1%)15.1 KiB
ClaudeThread snapshot wire5.5 KiB5.5 KiB+2 B (+0.0%)7.3 KiB
ClaudeLive turn WebSocket wire5.9 KiB5.9 KiB+8 B (+0.1%)7.8 KiB
ClaudeLive turn WebSocket decoded50.6 KiB50.6 KiB0 B (0.0%)66.4 KiB
ClaudeLive turn messages16160 (0.0%)21

Baseline: 8c628f1 · PR result: bae4628 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 94.6 KiB
  • Claude decoded thread snapshot: 95.4 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@github-actionsgithub-actionsBot added size:XL 500-999 changed lines (additions + deletions). 📱 Native Change Changes the native fingerprint; merging blocks production OTAs until a new store build ships. and removed size:L 100-499 changed lines (additions + deletions). labels Aug 10, 2026

@t3-codet3-codeBot left a comment

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed the full diff, existing review threads, and the result merged onto current main (e321667b1). i found no blocking issues.

verified on the merged tree:

  • contracts, client-runtime, server, and web typechecks
  • external launcher tests: 17 passed
  • markdown and file-link menu tests: 51 passed
  • rpc routing test: 1 passed
  • authorization and environment capability tests: 7 passed
  • targeted lint, formatting, and git diff --check

all github ci on 50f611eaf is green. the pr is technically mergeable. this is a comment review rather than a human approval, so a maintainer approval may still be required by policy.

Comment threadapps/web/src/components/ChatMarkdown.tsx

@t3-codet3-codeBot left a comment

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correction to my earlier review: two blocking edge cases were found and reproduced after a deeper parser/platform pass.

  1. apps/web/src/markdown-links.ts:181-214: the custom href scanner parses markdown-looking text inside inline code. [see \x`](src/real.ts)renders one link tosrc/real.ts, but the scanner returns only fake.ts. ChatMarkdown` therefore misses the real file link and routes it as a normal link.

  2. apps/server/src/process/externalLauncher.ts:241-260: WSL uses Explorer only when DISPLAY and WAYLAND_DISPLAY are absent. Standard WSLg sets those variables, so the code chooses Linux xdg-open instead of the available Windows Explorer. This can hide the action when xdg-open is absent or invoke a handler that cannot reveal the file. Current WSL coverage tests only the non-WSLg environment.

these should be fixed before merge. the malformed-destination performance concern was also tested, but i could not reproduce quadratic behavior in the actual implementation, so i am not including it as a finding.

@cursorcursorBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 8d5ba1b. Configure here.

Comment threadapps/web/src/components/ChatMarkdown.tsx
Co-authored-by: Matthew Feroz <136640686+MatthewFeroz@users.noreply.github.com>
@t3-code
t3-codeBotforce-pushed the feat/open-files-in-folder branch from 8d5ba1b to bae4628CompareAugust 15, 2026 02:53
@github-actionsgithub-actionsBot removed the 📱 Native Change Changes the native fingerprint; merging blocks production OTAs until a new store build ships. label Aug 15, 2026
@t3-code

t3-codeBot commented Aug 20, 2026

Copy link
Copy Markdown
ContributorAuthor

closing in favor of #6463, the newer and broader implementation with authorization, launcher, contract, client, and test coverage.

@t3-codet3-codeBot closed this Aug 20, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XL500-999 changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants

, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

feat(web): open files in containing folder - #5366

Closed
t3-code[bot] wants to merge 9 commits into
mainfrom
feat/open-files-in-folder
Closed

feat(web): open files in containing folder#5366
t3-code[bot] wants to merge 9 commits into
mainfrom
feat/open-files-in-folder

Conversation

@t3-code

@t3-codet3-codeBot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

1|## problem
2|
3|file link context menus can open files in editors or copy their paths, but cannot reveal them in the host file manager.
4|
5|## fix
6|
7|- add an "Open in folder" action to markdown file chip context menus
8|- route the action through the thread's environment so remote hosts open their own file manager
9|- reveal files with Finder and Windows Explorer, and open the containing directory on Linux
10|- add launcher and websocket routing coverage
11|
12|## testing
13|
14|- GOMAXPROCS=2 pnpm --filter @t3tools/contracts typecheck
15|- GOMAXPROCS=2 pnpm --filter @t3tools/client-runtime typecheck
16|- GOMAXPROCS=2 pnpm --filter t3 typecheck
17|- GOMAXPROCS=1 pnpm --filter @t3tools/web typecheck
18|- GOMAXPROCS=2 pnpm --filter t3 exec vp test run src/process/externalLauncher.test.ts
19|- GOMAXPROCS=2 pnpm --filter t3 exec vp test run src/server.test.ts -t "routes websocket rpc shell.revealInFileManager"
20|
21|model: gpt-5.4
22|harness: t3bot
23|
24|


Note

Medium Risk
Spawns host processes from user-supplied paths and branches on SSH/WSL/session env; scope is bounded by capability gating and operate-scope auth, with broad platform test coverage.

Overview
Adds Open in folder for chat markdown file links, wired through a new shell.revealInFileManager RPC and a fileManagerReveal server capability so clients only show the action when the host can reveal paths.

The server’s external launcher now spawns the OS file manager with platform-specific behavior (Finder -R, Explorer /select,, Linux xdg-open on the parent folder), including WSL-without-display via explorer.exe and UNC paths. File-manager availability is gated on graphical sessions and suppressed for headless Linux, SSH, and Windows service contexts.

The web UI routes reveals through the thread’s environment, extends file-link context menus, and tightens markdown link handling (richer destination parsing, AST tagging so only real markdown links become file chips—not raw HTML or nested inline-code false positives).

Reviewed by Cursor Bugbot for commit bae4628. Bugbot is set up for automated code reviews on this repo. Configure here.

40|
41|

Note

Add 'Open in folder' file reveal action to chat file links

  • Adds a new shell.revealInFileManager WebSocket RPC that spawns the OS file manager to reveal or open the containing folder of a file path.
  • Server advertises a fileManagerReveal capability; the UI gates the 'Open in folder' context menu item on this capability, connection phase, and available editors.
  • Handles cross-platform behavior: macOS uses open -R, Windows uses explorer /select,, Linux uses xdg-open on the containing folder, and WSL without a display uses explorer.exe with UNC paths.
  • File manager availability is suppressed for headless, SSH, and Windows service sessions.
  • Improves markdown link parsing to support angle-bracketed destinations, balanced parentheses, spaces, and escapes, and distinguishes markdown-generated anchors from raw HTML anchors to avoid false file link matches.

Macroscope summarized bae4628.

58|

1|## request provenance
2|
3|- requested by: @MatthewFeroz
4|
5|
6|

@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:L 100-499 changed lines (additions + deletions). labels Aug 4, 2026
Comment threadapps/web/src/components/ChatMarkdown.tsx
Comment threadapps/server/src/process/externalLauncher.ts Outdated
@macroscopeapp

macroscopeappBot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Needs human review

This PR introduces a new feature ('open files in containing folder') with a new RPC endpoint, authorization scope, server capability, cross-platform file manager integration, and user-facing context menu functionality. New features introducing user-facing behavior and authorization changes warrant human review.

No code changes detected at bae4628. Prior analysis still applies.

You can customize Macroscope's approvability policy. Learn more.

@t3-code
t3-codeBotforce-pushed the feat/open-files-in-folder branch from c5ce623 to 71d99eeCompareAugust 5, 2026 01:40
@t3-code

t3-codeBot commented Aug 5, 2026

Copy link
Copy Markdown
ContributorAuthor

updated the review fixes: open in folder is first and only appears when the file’s connected environment advertises both the reveal rpc and an available file manager. added focused menu-order and visibility tests.

open in folder first

@t3-code
t3-codeBotforce-pushed the feat/open-files-in-folder branch from 47284e0 to 316bb7dCompareAugust 5, 2026 05:26
Comment threadapps/server/src/process/externalLauncher.ts
@t3-code
t3-codeBotforce-pushed the feat/open-files-in-folder branch 2 times, most recently from 0647b60 to 8709943CompareAugust 8, 2026 02:38
Comment threadapps/web/src/markdown-links.ts Outdated
@github-actions

github-actionsBot commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wire11.3 KiB11.3 KiB+7 B (+0.1%)15.1 KiB
CodexThread snapshot wire5.5 KiB5.5 KiB−4 B (−0.1%)7.3 KiB
CodexLive turn WebSocket wire5.9 KiB5.9 KiB+11 B (+0.2%)7.8 KiB
CodexLive turn WebSocket decoded49.7 KiB49.7 KiB0 B (0.0%)66.4 KiB
CodexLive turn messages16160 (0.0%)21
ClaudeTotal thread wire11.3 KiB11.3 KiB+10 B (+0.1%)15.1 KiB
ClaudeThread snapshot wire5.5 KiB5.5 KiB+2 B (+0.0%)7.3 KiB
ClaudeLive turn WebSocket wire5.9 KiB5.9 KiB+8 B (+0.1%)7.8 KiB
ClaudeLive turn WebSocket decoded50.6 KiB50.6 KiB0 B (0.0%)66.4 KiB
ClaudeLive turn messages16160 (0.0%)21

Baseline: 8c628f1 · PR result: bae4628 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 94.6 KiB
  • Claude decoded thread snapshot: 95.4 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@github-actionsgithub-actionsBot added size:XL 500-999 changed lines (additions + deletions). 📱 Native Change Changes the native fingerprint; merging blocks production OTAs until a new store build ships. and removed size:L 100-499 changed lines (additions + deletions). labels Aug 10, 2026

@t3-codet3-codeBot left a comment

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed the full diff, existing review threads, and the result merged onto current main (e321667b1). i found no blocking issues.

verified on the merged tree:

  • contracts, client-runtime, server, and web typechecks
  • external launcher tests: 17 passed
  • markdown and file-link menu tests: 51 passed
  • rpc routing test: 1 passed
  • authorization and environment capability tests: 7 passed
  • targeted lint, formatting, and git diff --check

all github ci on 50f611eaf is green. the pr is technically mergeable. this is a comment review rather than a human approval, so a maintainer approval may still be required by policy.

Comment threadapps/web/src/components/ChatMarkdown.tsx

@t3-codet3-codeBot left a comment

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correction to my earlier review: two blocking edge cases were found and reproduced after a deeper parser/platform pass.

  1. apps/web/src/markdown-links.ts:181-214: the custom href scanner parses markdown-looking text inside inline code. [see \x`](src/real.ts)renders one link tosrc/real.ts, but the scanner returns only fake.ts. ChatMarkdown` therefore misses the real file link and routes it as a normal link.

  2. apps/server/src/process/externalLauncher.ts:241-260: WSL uses Explorer only when DISPLAY and WAYLAND_DISPLAY are absent. Standard WSLg sets those variables, so the code chooses Linux xdg-open instead of the available Windows Explorer. This can hide the action when xdg-open is absent or invoke a handler that cannot reveal the file. Current WSL coverage tests only the non-WSLg environment.

these should be fixed before merge. the malformed-destination performance concern was also tested, but i could not reproduce quadratic behavior in the actual implementation, so i am not including it as a finding.

@cursorcursorBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 8d5ba1b. Configure here.

Comment threadapps/web/src/components/ChatMarkdown.tsx
Co-authored-by: Matthew Feroz <136640686+MatthewFeroz@users.noreply.github.com>
@t3-code
t3-codeBotforce-pushed the feat/open-files-in-folder branch from 8d5ba1b to bae4628CompareAugust 15, 2026 02:53
@github-actionsgithub-actionsBot removed the 📱 Native Change Changes the native fingerprint; merging blocks production OTAs until a new store build ships. label Aug 15, 2026
@t3-code

t3-codeBot commented Aug 20, 2026

Copy link
Copy Markdown
ContributorAuthor

closing in favor of #6463, the newer and broader implementation with authorization, launcher, contract, client, and test coverage.

@t3-codet3-codeBot closed this Aug 20, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XL500-999 changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants

, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

feat(web): open files in containing folder - #5366

Closed
t3-code[bot] wants to merge 9 commits into
mainfrom
feat/open-files-in-folder
Closed

feat(web): open files in containing folder#5366
t3-code[bot] wants to merge 9 commits into
mainfrom
feat/open-files-in-folder

Conversation

@t3-code

@t3-codet3-codeBot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

1|## problem
2|
3|file link context menus can open files in editors or copy their paths, but cannot reveal them in the host file manager.
4|
5|## fix
6|
7|- add an "Open in folder" action to markdown file chip context menus
8|- route the action through the thread's environment so remote hosts open their own file manager
9|- reveal files with Finder and Windows Explorer, and open the containing directory on Linux
10|- add launcher and websocket routing coverage
11|
12|## testing
13|
14|- GOMAXPROCS=2 pnpm --filter @t3tools/contracts typecheck
15|- GOMAXPROCS=2 pnpm --filter @t3tools/client-runtime typecheck
16|- GOMAXPROCS=2 pnpm --filter t3 typecheck
17|- GOMAXPROCS=1 pnpm --filter @t3tools/web typecheck
18|- GOMAXPROCS=2 pnpm --filter t3 exec vp test run src/process/externalLauncher.test.ts
19|- GOMAXPROCS=2 pnpm --filter t3 exec vp test run src/server.test.ts -t "routes websocket rpc shell.revealInFileManager"
20|
21|model: gpt-5.4
22|harness: t3bot
23|
24|


Note

Medium Risk
Spawns host processes from user-supplied paths and branches on SSH/WSL/session env; scope is bounded by capability gating and operate-scope auth, with broad platform test coverage.

Overview
Adds Open in folder for chat markdown file links, wired through a new shell.revealInFileManager RPC and a fileManagerReveal server capability so clients only show the action when the host can reveal paths.

The server’s external launcher now spawns the OS file manager with platform-specific behavior (Finder -R, Explorer /select,, Linux xdg-open on the parent folder), including WSL-without-display via explorer.exe and UNC paths. File-manager availability is gated on graphical sessions and suppressed for headless Linux, SSH, and Windows service contexts.

The web UI routes reveals through the thread’s environment, extends file-link context menus, and tightens markdown link handling (richer destination parsing, AST tagging so only real markdown links become file chips—not raw HTML or nested inline-code false positives).

Reviewed by Cursor Bugbot for commit bae4628. Bugbot is set up for automated code reviews on this repo. Configure here.

40|
41|

Note

Add 'Open in folder' file reveal action to chat file links

  • Adds a new shell.revealInFileManager WebSocket RPC that spawns the OS file manager to reveal or open the containing folder of a file path.
  • Server advertises a fileManagerReveal capability; the UI gates the 'Open in folder' context menu item on this capability, connection phase, and available editors.
  • Handles cross-platform behavior: macOS uses open -R, Windows uses explorer /select,, Linux uses xdg-open on the containing folder, and WSL without a display uses explorer.exe with UNC paths.
  • File manager availability is suppressed for headless, SSH, and Windows service sessions.
  • Improves markdown link parsing to support angle-bracketed destinations, balanced parentheses, spaces, and escapes, and distinguishes markdown-generated anchors from raw HTML anchors to avoid false file link matches.

Macroscope summarized bae4628.

58|

1|## request provenance
2|
3|- requested by: @MatthewFeroz
4|
5|
6|

@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:L 100-499 changed lines (additions + deletions). labels Aug 4, 2026
Comment threadapps/web/src/components/ChatMarkdown.tsx
Comment threadapps/server/src/process/externalLauncher.ts Outdated
@macroscopeapp

macroscopeappBot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Needs human review

This PR introduces a new feature ('open files in containing folder') with a new RPC endpoint, authorization scope, server capability, cross-platform file manager integration, and user-facing context menu functionality. New features introducing user-facing behavior and authorization changes warrant human review.

No code changes detected at bae4628. Prior analysis still applies.

You can customize Macroscope's approvability policy. Learn more.

@t3-code
t3-codeBotforce-pushed the feat/open-files-in-folder branch from c5ce623 to 71d99eeCompareAugust 5, 2026 01:40
@t3-code

t3-codeBot commented Aug 5, 2026

Copy link
Copy Markdown
ContributorAuthor

updated the review fixes: open in folder is first and only appears when the file’s connected environment advertises both the reveal rpc and an available file manager. added focused menu-order and visibility tests.

open in folder first

@t3-code
t3-codeBotforce-pushed the feat/open-files-in-folder branch from 47284e0 to 316bb7dCompareAugust 5, 2026 05:26
Comment threadapps/server/src/process/externalLauncher.ts
@t3-code
t3-codeBotforce-pushed the feat/open-files-in-folder branch 2 times, most recently from 0647b60 to 8709943CompareAugust 8, 2026 02:38
Comment threadapps/web/src/markdown-links.ts Outdated
@github-actions

github-actionsBot commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wire11.3 KiB11.3 KiB+7 B (+0.1%)15.1 KiB
CodexThread snapshot wire5.5 KiB5.5 KiB−4 B (−0.1%)7.3 KiB
CodexLive turn WebSocket wire5.9 KiB5.9 KiB+11 B (+0.2%)7.8 KiB
CodexLive turn WebSocket decoded49.7 KiB49.7 KiB0 B (0.0%)66.4 KiB
CodexLive turn messages16160 (0.0%)21
ClaudeTotal thread wire11.3 KiB11.3 KiB+10 B (+0.1%)15.1 KiB
ClaudeThread snapshot wire5.5 KiB5.5 KiB+2 B (+0.0%)7.3 KiB
ClaudeLive turn WebSocket wire5.9 KiB5.9 KiB+8 B (+0.1%)7.8 KiB
ClaudeLive turn WebSocket decoded50.6 KiB50.6 KiB0 B (0.0%)66.4 KiB
ClaudeLive turn messages16160 (0.0%)21

Baseline: 8c628f1 · PR result: bae4628 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 94.6 KiB
  • Claude decoded thread snapshot: 95.4 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@github-actionsgithub-actionsBot added size:XL 500-999 changed lines (additions + deletions). 📱 Native Change Changes the native fingerprint; merging blocks production OTAs until a new store build ships. and removed size:L 100-499 changed lines (additions + deletions). labels Aug 10, 2026

@t3-codet3-codeBot left a comment

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed the full diff, existing review threads, and the result merged onto current main (e321667b1). i found no blocking issues.

verified on the merged tree:

  • contracts, client-runtime, server, and web typechecks
  • external launcher tests: 17 passed
  • markdown and file-link menu tests: 51 passed
  • rpc routing test: 1 passed
  • authorization and environment capability tests: 7 passed
  • targeted lint, formatting, and git diff --check

all github ci on 50f611eaf is green. the pr is technically mergeable. this is a comment review rather than a human approval, so a maintainer approval may still be required by policy.

Comment threadapps/web/src/components/ChatMarkdown.tsx

@t3-codet3-codeBot left a comment

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correction to my earlier review: two blocking edge cases were found and reproduced after a deeper parser/platform pass.

  1. apps/web/src/markdown-links.ts:181-214: the custom href scanner parses markdown-looking text inside inline code. [see \x`](src/real.ts)renders one link tosrc/real.ts, but the scanner returns only fake.ts. ChatMarkdown` therefore misses the real file link and routes it as a normal link.

  2. apps/server/src/process/externalLauncher.ts:241-260: WSL uses Explorer only when DISPLAY and WAYLAND_DISPLAY are absent. Standard WSLg sets those variables, so the code chooses Linux xdg-open instead of the available Windows Explorer. This can hide the action when xdg-open is absent or invoke a handler that cannot reveal the file. Current WSL coverage tests only the non-WSLg environment.

these should be fixed before merge. the malformed-destination performance concern was also tested, but i could not reproduce quadratic behavior in the actual implementation, so i am not including it as a finding.

@cursorcursorBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 8d5ba1b. Configure here.

Comment threadapps/web/src/components/ChatMarkdown.tsx
Co-authored-by: Matthew Feroz <136640686+MatthewFeroz@users.noreply.github.com>
@t3-code
t3-codeBotforce-pushed the feat/open-files-in-folder branch from 8d5ba1b to bae4628CompareAugust 15, 2026 02:53
@github-actionsgithub-actionsBot removed the 📱 Native Change Changes the native fingerprint; merging blocks production OTAs until a new store build ships. label Aug 15, 2026
@t3-code

t3-codeBot commented Aug 20, 2026

Copy link
Copy Markdown
ContributorAuthor

closing in favor of #6463, the newer and broader implementation with authorization, launcher, contract, client, and test coverage.

@t3-codet3-codeBot closed this Aug 20, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XL500-999 changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants

, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

feat(web): open files in containing folder - #5366

Closed
t3-code[bot] wants to merge 9 commits into
mainfrom
feat/open-files-in-folder
Closed

feat(web): open files in containing folder#5366
t3-code[bot] wants to merge 9 commits into
mainfrom
feat/open-files-in-folder

Conversation

@t3-code

@t3-codet3-codeBot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

1|## problem
2|
3|file link context menus can open files in editors or copy their paths, but cannot reveal them in the host file manager.
4|
5|## fix
6|
7|- add an "Open in folder" action to markdown file chip context menus
8|- route the action through the thread's environment so remote hosts open their own file manager
9|- reveal files with Finder and Windows Explorer, and open the containing directory on Linux
10|- add launcher and websocket routing coverage
11|
12|## testing
13|
14|- GOMAXPROCS=2 pnpm --filter @t3tools/contracts typecheck
15|- GOMAXPROCS=2 pnpm --filter @t3tools/client-runtime typecheck
16|- GOMAXPROCS=2 pnpm --filter t3 typecheck
17|- GOMAXPROCS=1 pnpm --filter @t3tools/web typecheck
18|- GOMAXPROCS=2 pnpm --filter t3 exec vp test run src/process/externalLauncher.test.ts
19|- GOMAXPROCS=2 pnpm --filter t3 exec vp test run src/server.test.ts -t "routes websocket rpc shell.revealInFileManager"
20|
21|model: gpt-5.4
22|harness: t3bot
23|
24|


Note

Medium Risk
Spawns host processes from user-supplied paths and branches on SSH/WSL/session env; scope is bounded by capability gating and operate-scope auth, with broad platform test coverage.

Overview
Adds Open in folder for chat markdown file links, wired through a new shell.revealInFileManager RPC and a fileManagerReveal server capability so clients only show the action when the host can reveal paths.

The server’s external launcher now spawns the OS file manager with platform-specific behavior (Finder -R, Explorer /select,, Linux xdg-open on the parent folder), including WSL-without-display via explorer.exe and UNC paths. File-manager availability is gated on graphical sessions and suppressed for headless Linux, SSH, and Windows service contexts.

The web UI routes reveals through the thread’s environment, extends file-link context menus, and tightens markdown link handling (richer destination parsing, AST tagging so only real markdown links become file chips—not raw HTML or nested inline-code false positives).

Reviewed by Cursor Bugbot for commit bae4628. Bugbot is set up for automated code reviews on this repo. Configure here.

40|
41|

Note

Add 'Open in folder' file reveal action to chat file links

  • Adds a new shell.revealInFileManager WebSocket RPC that spawns the OS file manager to reveal or open the containing folder of a file path.
  • Server advertises a fileManagerReveal capability; the UI gates the 'Open in folder' context menu item on this capability, connection phase, and available editors.
  • Handles cross-platform behavior: macOS uses open -R, Windows uses explorer /select,, Linux uses xdg-open on the containing folder, and WSL without a display uses explorer.exe with UNC paths.
  • File manager availability is suppressed for headless, SSH, and Windows service sessions.
  • Improves markdown link parsing to support angle-bracketed destinations, balanced parentheses, spaces, and escapes, and distinguishes markdown-generated anchors from raw HTML anchors to avoid false file link matches.

Macroscope summarized bae4628.

58|

1|## request provenance
2|
3|- requested by: @MatthewFeroz
4|
5|
6|

@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:L 100-499 changed lines (additions + deletions). labels Aug 4, 2026
Comment threadapps/web/src/components/ChatMarkdown.tsx
Comment threadapps/server/src/process/externalLauncher.ts Outdated
@macroscopeapp

macroscopeappBot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Needs human review

This PR introduces a new feature ('open files in containing folder') with a new RPC endpoint, authorization scope, server capability, cross-platform file manager integration, and user-facing context menu functionality. New features introducing user-facing behavior and authorization changes warrant human review.

No code changes detected at bae4628. Prior analysis still applies.

You can customize Macroscope's approvability policy. Learn more.

@t3-code
t3-codeBotforce-pushed the feat/open-files-in-folder branch from c5ce623 to 71d99eeCompareAugust 5, 2026 01:40
@t3-code

t3-codeBot commented Aug 5, 2026

Copy link
Copy Markdown
ContributorAuthor

updated the review fixes: open in folder is first and only appears when the file’s connected environment advertises both the reveal rpc and an available file manager. added focused menu-order and visibility tests.

open in folder first

@t3-code
t3-codeBotforce-pushed the feat/open-files-in-folder branch from 47284e0 to 316bb7dCompareAugust 5, 2026 05:26
Comment threadapps/server/src/process/externalLauncher.ts
@t3-code
t3-codeBotforce-pushed the feat/open-files-in-folder branch 2 times, most recently from 0647b60 to 8709943CompareAugust 8, 2026 02:38
Comment threadapps/web/src/markdown-links.ts Outdated
@github-actions

github-actionsBot commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wire11.3 KiB11.3 KiB+7 B (+0.1%)15.1 KiB
CodexThread snapshot wire5.5 KiB5.5 KiB−4 B (−0.1%)7.3 KiB
CodexLive turn WebSocket wire5.9 KiB5.9 KiB+11 B (+0.2%)7.8 KiB
CodexLive turn WebSocket decoded49.7 KiB49.7 KiB0 B (0.0%)66.4 KiB
CodexLive turn messages16160 (0.0%)21
ClaudeTotal thread wire11.3 KiB11.3 KiB+10 B (+0.1%)15.1 KiB
ClaudeThread snapshot wire5.5 KiB5.5 KiB+2 B (+0.0%)7.3 KiB
ClaudeLive turn WebSocket wire5.9 KiB5.9 KiB+8 B (+0.1%)7.8 KiB
ClaudeLive turn WebSocket decoded50.6 KiB50.6 KiB0 B (0.0%)66.4 KiB
ClaudeLive turn messages16160 (0.0%)21

Baseline: 8c628f1 · PR result: bae4628 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 94.6 KiB
  • Claude decoded thread snapshot: 95.4 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@github-actionsgithub-actionsBot added size:XL 500-999 changed lines (additions + deletions). 📱 Native Change Changes the native fingerprint; merging blocks production OTAs until a new store build ships. and removed size:L 100-499 changed lines (additions + deletions). labels Aug 10, 2026

@t3-codet3-codeBot left a comment

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed the full diff, existing review threads, and the result merged onto current main (e321667b1). i found no blocking issues.

verified on the merged tree:

  • contracts, client-runtime, server, and web typechecks
  • external launcher tests: 17 passed
  • markdown and file-link menu tests: 51 passed
  • rpc routing test: 1 passed
  • authorization and environment capability tests: 7 passed
  • targeted lint, formatting, and git diff --check

all github ci on 50f611eaf is green. the pr is technically mergeable. this is a comment review rather than a human approval, so a maintainer approval may still be required by policy.

Comment threadapps/web/src/components/ChatMarkdown.tsx

@t3-codet3-codeBot left a comment

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correction to my earlier review: two blocking edge cases were found and reproduced after a deeper parser/platform pass.

  1. apps/web/src/markdown-links.ts:181-214: the custom href scanner parses markdown-looking text inside inline code. [see \x`](src/real.ts)renders one link tosrc/real.ts, but the scanner returns only fake.ts. ChatMarkdown` therefore misses the real file link and routes it as a normal link.

  2. apps/server/src/process/externalLauncher.ts:241-260: WSL uses Explorer only when DISPLAY and WAYLAND_DISPLAY are absent. Standard WSLg sets those variables, so the code chooses Linux xdg-open instead of the available Windows Explorer. This can hide the action when xdg-open is absent or invoke a handler that cannot reveal the file. Current WSL coverage tests only the non-WSLg environment.

these should be fixed before merge. the malformed-destination performance concern was also tested, but i could not reproduce quadratic behavior in the actual implementation, so i am not including it as a finding.

@cursorcursorBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 8d5ba1b. Configure here.

Comment threadapps/web/src/components/ChatMarkdown.tsx
Co-authored-by: Matthew Feroz <136640686+MatthewFeroz@users.noreply.github.com>
@t3-code
t3-codeBotforce-pushed the feat/open-files-in-folder branch from 8d5ba1b to bae4628CompareAugust 15, 2026 02:53
@github-actionsgithub-actionsBot removed the 📱 Native Change Changes the native fingerprint; merging blocks production OTAs until a new store build ships. label Aug 15, 2026
@t3-code

t3-codeBot commented Aug 20, 2026

Copy link
Copy Markdown
ContributorAuthor

closing in favor of #6463, the newer and broader implementation with authorization, launcher, contract, client, and test coverage.

@t3-codet3-codeBot closed this Aug 20, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XL500-999 changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants