perf(mobile): speed up large Android threads - #5393

Closed
shivamhwp wants to merge 7 commits into
pingdotgg:mainfrom
shivamhwp:perf/android-large-thread-loading
Closed

perf(mobile): speed up large Android threads#5393
shivamhwp wants to merge 7 commits into
pingdotgg:mainfrom
shivamhwp:perf/android-large-thread-loading

Conversation

@shivamhwp

@shivamhwpshivamhwp commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

Large Android threads can finish syncing while LegendList has no attached visible rows, leaving a blank feed until the user scrolls. Paginated prepends also changed the list-header height on the final page, which moved the title/feed anchor while Android restored visible content.

This draft stays mobile-only:

  • keep Android loading, unavailable, and hydrated thread headers on the same geometry;
  • recycle Android feed rows, reduce the Android draw window, and keep one row mounted at each list edge;
  • wake the Android native row-attachment path once after LegendList's initial end positioning;
  • keep a fixed-height history control through loading, additional pages, and “Beginning of thread” so final-page prepends do not change header height;
  • retain the existing feed-derivation and review-highlighter reductions already in this branch.

This does not replace server pagination from #5493. It also does not duplicate #5585: that PR seeds the composer inset before the initial scroll; this one handles positioned recycled rows that still fail to attach/paint. The final #5585 diff applies cleanly on top of this branch.

Verification on eeb9a52b2, rebased onto upstream main at 89c320df0:

  • signed-in preview development client on the API 36 Android emulator, using its existing T3 Connect account and three saved environments; no fixture or environment re-pairing;
  • fafo about t3code: cold current-head feed became visible without a gesture after roughly 40–45s; 24 alternating full-height swipes left 19 visible text nodes and six copy targets, with no blank recycled viewport;
  • dashboard thread: initial content became visible without a gesture after roughly 13s; its two older-page loads rendered in roughly 8–12s each; the final fixed control read “Beginning of thread”;
  • title bounds stayed exactly [129,136]–[696,197] across initial loading, both prepends, the final-page transition, and every stress pass;
  • the full-history dashboard stress pass rendered 201 frames with 45.27% modern jank, p50 32ms, p90 77ms, p95 93ms, p99 150ms, and 40 missed vsyncs;
  • preview-dev-client PSS rose from about 1.98 GB before opening the dashboard thread to about 2.39 GB after full history and stress scrolling; these absolute dev-client values are diagnostic, not release acceptance numbers;
  • 16 focused tests passed and mobile typecheck passed again after the rebase. Targeted lint, targeted formatting, and git diff --check passed on the implementation head before the rebase.

The native blank-until-gesture and title/header-shift failures are fixed in these runs, but the current emulator measurements are not merge-ready. Keep this draft until the final rebased head gets a physical-device release-profile A/B and the remaining thread-load latency and scroll-frame costs are profiled. An earlier same-device physical A/B on the broader mobile rendering scope improved p99 from about 150ms to 73ms and PSS growth from about 161 MB to 97 MB, but that is not a substitute for a final-head rerun.

Implemented with GPT-5.6 Sol in the T3 Code Codex harness.

@coderabbitai

coderabbitaiBot commented Aug 5, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 420b7305-60f5-4848-ac6f-01112731f5f9

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:L 100-499 changed lines (additions + deletions). labels Aug 5, 2026
Comment threadapps/mobile/src/features/threads/ThreadFeed.tsx
Comment threadapps/server/src/orchestration/ActivityPayloadProjection.ts Outdated
@shivamhwp
shivamhwpforce-pushed the perf/android-large-thread-loading branch from b3d6668 to 0ebe016CompareAugust 5, 2026 09:51
Comment threadapps/server/src/orchestration/ActivityPayloadProjection.ts Outdated
@shivamhwp
shivamhwpforce-pushed the perf/android-large-thread-loading branch 3 times, most recently from f897132 to 39bf858CompareAugust 8, 2026 11:17
Comment threadapps/mobile/src/features/threads/ThreadFeed.tsx Outdated
@shivamhwp
shivamhwpforce-pushed the perf/android-large-thread-loading branch from bba60e2 to eeb9a52CompareAugust 9, 2026 01:19
Comment threadapps/mobile/src/features/threads/ThreadRouteScreen.tsx Outdated
@shivamhwp
shivamhwpforce-pushed the perf/android-large-thread-loading branch from 6bf27aa to 3e07aabCompareAugust 10, 2026 05:34
Comment threadapps/mobile/src/features/threads/ThreadRouteScreen.tsx
@shivamhwp
shivamhwpforce-pushed the perf/android-large-thread-loading branch from 7533aeb to 17a7a67CompareAugust 10, 2026 12:16
@shivamhwp
shivamhwpforce-pushed the perf/android-large-thread-loading branch from 17a7a67 to bb6f6a8CompareAugust 11, 2026 03:20
);
}

function OpeningThreadRouteScreen(props: {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Mediumthreads/ThreadRouteScreen.tsx:207

OpeningThreadRouteScreen renders LoadingScreen below an in-flow AndroidScreenHeader, but LoadingScreen independently adds paddingTop: insets.top. On Android the header already reserves the top safe-area inset, so the loading state double-counts the status-bar inset and shifts the centered spinner/message downward relative to the hydrated thread screen. Consider using a loading body that omits the top inset when rendered under this header.

🤖 Copy this AI Prompt to have your agent fix this:
In file @apps/mobile/src/features/threads/ThreadRouteScreen.tsx around line 207:
`OpeningThreadRouteScreen` renders `LoadingScreen` below an in-flow `AndroidScreenHeader`, but `LoadingScreen` independently adds `paddingTop: insets.top`. On Android the header already reserves the top safe-area inset, so the loading state double-counts the status-bar inset and shifts the centered spinner/message downward relative to the hydrated thread screen. Consider using a loading body that omits the top inset when rendered under this header.

@shivamhwp

Copy link
Copy Markdown
CollaboratorAuthor

Closing this draft because its scope now overlaps multiple focused efforts and combines thread loading, rendering, navigation, and title/layout stability changes. We should revisit the remaining performance work as smaller, independently measured PRs after the adjacent changes settle.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L100-499 changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@shivamhwp
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

perf(mobile): speed up large Android threads - #5393

Closed
shivamhwp wants to merge 7 commits into
pingdotgg:mainfrom
shivamhwp:perf/android-large-thread-loading
Closed

perf(mobile): speed up large Android threads#5393
shivamhwp wants to merge 7 commits into
pingdotgg:mainfrom
shivamhwp:perf/android-large-thread-loading

Conversation

@shivamhwp

@shivamhwpshivamhwp commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

Large Android threads can finish syncing while LegendList has no attached visible rows, leaving a blank feed until the user scrolls. Paginated prepends also changed the list-header height on the final page, which moved the title/feed anchor while Android restored visible content.

This draft stays mobile-only:

  • keep Android loading, unavailable, and hydrated thread headers on the same geometry;
  • recycle Android feed rows, reduce the Android draw window, and keep one row mounted at each list edge;
  • wake the Android native row-attachment path once after LegendList's initial end positioning;
  • keep a fixed-height history control through loading, additional pages, and “Beginning of thread” so final-page prepends do not change header height;
  • retain the existing feed-derivation and review-highlighter reductions already in this branch.

This does not replace server pagination from #5493. It also does not duplicate #5585: that PR seeds the composer inset before the initial scroll; this one handles positioned recycled rows that still fail to attach/paint. The final #5585 diff applies cleanly on top of this branch.

Verification on eeb9a52b2, rebased onto upstream main at 89c320df0:

  • signed-in preview development client on the API 36 Android emulator, using its existing T3 Connect account and three saved environments; no fixture or environment re-pairing;
  • fafo about t3code: cold current-head feed became visible without a gesture after roughly 40–45s; 24 alternating full-height swipes left 19 visible text nodes and six copy targets, with no blank recycled viewport;
  • dashboard thread: initial content became visible without a gesture after roughly 13s; its two older-page loads rendered in roughly 8–12s each; the final fixed control read “Beginning of thread”;
  • title bounds stayed exactly [129,136]–[696,197] across initial loading, both prepends, the final-page transition, and every stress pass;
  • the full-history dashboard stress pass rendered 201 frames with 45.27% modern jank, p50 32ms, p90 77ms, p95 93ms, p99 150ms, and 40 missed vsyncs;
  • preview-dev-client PSS rose from about 1.98 GB before opening the dashboard thread to about 2.39 GB after full history and stress scrolling; these absolute dev-client values are diagnostic, not release acceptance numbers;
  • 16 focused tests passed and mobile typecheck passed again after the rebase. Targeted lint, targeted formatting, and git diff --check passed on the implementation head before the rebase.

The native blank-until-gesture and title/header-shift failures are fixed in these runs, but the current emulator measurements are not merge-ready. Keep this draft until the final rebased head gets a physical-device release-profile A/B and the remaining thread-load latency and scroll-frame costs are profiled. An earlier same-device physical A/B on the broader mobile rendering scope improved p99 from about 150ms to 73ms and PSS growth from about 161 MB to 97 MB, but that is not a substitute for a final-head rerun.

Implemented with GPT-5.6 Sol in the T3 Code Codex harness.

@coderabbitai

coderabbitaiBot commented Aug 5, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 420b7305-60f5-4848-ac6f-01112731f5f9

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:L 100-499 changed lines (additions + deletions). labels Aug 5, 2026
Comment threadapps/mobile/src/features/threads/ThreadFeed.tsx
Comment threadapps/server/src/orchestration/ActivityPayloadProjection.ts Outdated
@shivamhwp
shivamhwpforce-pushed the perf/android-large-thread-loading branch from b3d6668 to 0ebe016CompareAugust 5, 2026 09:51
Comment threadapps/server/src/orchestration/ActivityPayloadProjection.ts Outdated
@shivamhwp
shivamhwpforce-pushed the perf/android-large-thread-loading branch 3 times, most recently from f897132 to 39bf858CompareAugust 8, 2026 11:17
Comment threadapps/mobile/src/features/threads/ThreadFeed.tsx Outdated
@shivamhwp
shivamhwpforce-pushed the perf/android-large-thread-loading branch from bba60e2 to eeb9a52CompareAugust 9, 2026 01:19
Comment threadapps/mobile/src/features/threads/ThreadRouteScreen.tsx Outdated
@shivamhwp
shivamhwpforce-pushed the perf/android-large-thread-loading branch from 6bf27aa to 3e07aabCompareAugust 10, 2026 05:34
Comment threadapps/mobile/src/features/threads/ThreadRouteScreen.tsx
@shivamhwp
shivamhwpforce-pushed the perf/android-large-thread-loading branch from 7533aeb to 17a7a67CompareAugust 10, 2026 12:16
@shivamhwp
shivamhwpforce-pushed the perf/android-large-thread-loading branch from 17a7a67 to bb6f6a8CompareAugust 11, 2026 03:20
);
}

function OpeningThreadRouteScreen(props: {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Mediumthreads/ThreadRouteScreen.tsx:207

OpeningThreadRouteScreen renders LoadingScreen below an in-flow AndroidScreenHeader, but LoadingScreen independently adds paddingTop: insets.top. On Android the header already reserves the top safe-area inset, so the loading state double-counts the status-bar inset and shifts the centered spinner/message downward relative to the hydrated thread screen. Consider using a loading body that omits the top inset when rendered under this header.

🤖 Copy this AI Prompt to have your agent fix this:
In file @apps/mobile/src/features/threads/ThreadRouteScreen.tsx around line 207:
`OpeningThreadRouteScreen` renders `LoadingScreen` below an in-flow `AndroidScreenHeader`, but `LoadingScreen` independently adds `paddingTop: insets.top`. On Android the header already reserves the top safe-area inset, so the loading state double-counts the status-bar inset and shifts the centered spinner/message downward relative to the hydrated thread screen. Consider using a loading body that omits the top inset when rendered under this header.

@shivamhwp

Copy link
Copy Markdown
CollaboratorAuthor

Closing this draft because its scope now overlaps multiple focused efforts and combines thread loading, rendering, navigation, and title/layout stability changes. We should revisit the remaining performance work as smaller, independently measured PRs after the adjacent changes settle.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L100-499 changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@shivamhwp
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

perf(mobile): speed up large Android threads - #5393

Closed
shivamhwp wants to merge 7 commits into
pingdotgg:mainfrom
shivamhwp:perf/android-large-thread-loading
Closed

perf(mobile): speed up large Android threads#5393
shivamhwp wants to merge 7 commits into
pingdotgg:mainfrom
shivamhwp:perf/android-large-thread-loading

Conversation

@shivamhwp

@shivamhwpshivamhwp commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

Large Android threads can finish syncing while LegendList has no attached visible rows, leaving a blank feed until the user scrolls. Paginated prepends also changed the list-header height on the final page, which moved the title/feed anchor while Android restored visible content.

This draft stays mobile-only:

  • keep Android loading, unavailable, and hydrated thread headers on the same geometry;
  • recycle Android feed rows, reduce the Android draw window, and keep one row mounted at each list edge;
  • wake the Android native row-attachment path once after LegendList's initial end positioning;
  • keep a fixed-height history control through loading, additional pages, and “Beginning of thread” so final-page prepends do not change header height;
  • retain the existing feed-derivation and review-highlighter reductions already in this branch.

This does not replace server pagination from #5493. It also does not duplicate #5585: that PR seeds the composer inset before the initial scroll; this one handles positioned recycled rows that still fail to attach/paint. The final #5585 diff applies cleanly on top of this branch.

Verification on eeb9a52b2, rebased onto upstream main at 89c320df0:

  • signed-in preview development client on the API 36 Android emulator, using its existing T3 Connect account and three saved environments; no fixture or environment re-pairing;
  • fafo about t3code: cold current-head feed became visible without a gesture after roughly 40–45s; 24 alternating full-height swipes left 19 visible text nodes and six copy targets, with no blank recycled viewport;
  • dashboard thread: initial content became visible without a gesture after roughly 13s; its two older-page loads rendered in roughly 8–12s each; the final fixed control read “Beginning of thread”;
  • title bounds stayed exactly [129,136]–[696,197] across initial loading, both prepends, the final-page transition, and every stress pass;
  • the full-history dashboard stress pass rendered 201 frames with 45.27% modern jank, p50 32ms, p90 77ms, p95 93ms, p99 150ms, and 40 missed vsyncs;
  • preview-dev-client PSS rose from about 1.98 GB before opening the dashboard thread to about 2.39 GB after full history and stress scrolling; these absolute dev-client values are diagnostic, not release acceptance numbers;
  • 16 focused tests passed and mobile typecheck passed again after the rebase. Targeted lint, targeted formatting, and git diff --check passed on the implementation head before the rebase.

The native blank-until-gesture and title/header-shift failures are fixed in these runs, but the current emulator measurements are not merge-ready. Keep this draft until the final rebased head gets a physical-device release-profile A/B and the remaining thread-load latency and scroll-frame costs are profiled. An earlier same-device physical A/B on the broader mobile rendering scope improved p99 from about 150ms to 73ms and PSS growth from about 161 MB to 97 MB, but that is not a substitute for a final-head rerun.

Implemented with GPT-5.6 Sol in the T3 Code Codex harness.

@coderabbitai

coderabbitaiBot commented Aug 5, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 420b7305-60f5-4848-ac6f-01112731f5f9

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:L 100-499 changed lines (additions + deletions). labels Aug 5, 2026
Comment threadapps/mobile/src/features/threads/ThreadFeed.tsx
Comment threadapps/server/src/orchestration/ActivityPayloadProjection.ts Outdated
@shivamhwp
shivamhwpforce-pushed the perf/android-large-thread-loading branch from b3d6668 to 0ebe016CompareAugust 5, 2026 09:51
Comment threadapps/server/src/orchestration/ActivityPayloadProjection.ts Outdated
@shivamhwp
shivamhwpforce-pushed the perf/android-large-thread-loading branch 3 times, most recently from f897132 to 39bf858CompareAugust 8, 2026 11:17
Comment threadapps/mobile/src/features/threads/ThreadFeed.tsx Outdated
@shivamhwp
shivamhwpforce-pushed the perf/android-large-thread-loading branch from bba60e2 to eeb9a52CompareAugust 9, 2026 01:19
Comment threadapps/mobile/src/features/threads/ThreadRouteScreen.tsx Outdated
@shivamhwp
shivamhwpforce-pushed the perf/android-large-thread-loading branch from 6bf27aa to 3e07aabCompareAugust 10, 2026 05:34
Comment threadapps/mobile/src/features/threads/ThreadRouteScreen.tsx
@shivamhwp
shivamhwpforce-pushed the perf/android-large-thread-loading branch from 7533aeb to 17a7a67CompareAugust 10, 2026 12:16
@shivamhwp
shivamhwpforce-pushed the perf/android-large-thread-loading branch from 17a7a67 to bb6f6a8CompareAugust 11, 2026 03:20
);
}

function OpeningThreadRouteScreen(props: {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Mediumthreads/ThreadRouteScreen.tsx:207

OpeningThreadRouteScreen renders LoadingScreen below an in-flow AndroidScreenHeader, but LoadingScreen independently adds paddingTop: insets.top. On Android the header already reserves the top safe-area inset, so the loading state double-counts the status-bar inset and shifts the centered spinner/message downward relative to the hydrated thread screen. Consider using a loading body that omits the top inset when rendered under this header.

🤖 Copy this AI Prompt to have your agent fix this:
In file @apps/mobile/src/features/threads/ThreadRouteScreen.tsx around line 207:
`OpeningThreadRouteScreen` renders `LoadingScreen` below an in-flow `AndroidScreenHeader`, but `LoadingScreen` independently adds `paddingTop: insets.top`. On Android the header already reserves the top safe-area inset, so the loading state double-counts the status-bar inset and shifts the centered spinner/message downward relative to the hydrated thread screen. Consider using a loading body that omits the top inset when rendered under this header.

@shivamhwp

Copy link
Copy Markdown
CollaboratorAuthor

Closing this draft because its scope now overlaps multiple focused efforts and combines thread loading, rendering, navigation, and title/layout stability changes. We should revisit the remaining performance work as smaller, independently measured PRs after the adjacent changes settle.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L100-499 changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@shivamhwp
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

perf(mobile): speed up large Android threads - #5393

Closed
shivamhwp wants to merge 7 commits into
pingdotgg:mainfrom
shivamhwp:perf/android-large-thread-loading
Closed

perf(mobile): speed up large Android threads#5393
shivamhwp wants to merge 7 commits into
pingdotgg:mainfrom
shivamhwp:perf/android-large-thread-loading

Conversation

@shivamhwp

@shivamhwpshivamhwp commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

Large Android threads can finish syncing while LegendList has no attached visible rows, leaving a blank feed until the user scrolls. Paginated prepends also changed the list-header height on the final page, which moved the title/feed anchor while Android restored visible content.

This draft stays mobile-only:

  • keep Android loading, unavailable, and hydrated thread headers on the same geometry;
  • recycle Android feed rows, reduce the Android draw window, and keep one row mounted at each list edge;
  • wake the Android native row-attachment path once after LegendList's initial end positioning;
  • keep a fixed-height history control through loading, additional pages, and “Beginning of thread” so final-page prepends do not change header height;
  • retain the existing feed-derivation and review-highlighter reductions already in this branch.

This does not replace server pagination from #5493. It also does not duplicate #5585: that PR seeds the composer inset before the initial scroll; this one handles positioned recycled rows that still fail to attach/paint. The final #5585 diff applies cleanly on top of this branch.

Verification on eeb9a52b2, rebased onto upstream main at 89c320df0:

  • signed-in preview development client on the API 36 Android emulator, using its existing T3 Connect account and three saved environments; no fixture or environment re-pairing;
  • fafo about t3code: cold current-head feed became visible without a gesture after roughly 40–45s; 24 alternating full-height swipes left 19 visible text nodes and six copy targets, with no blank recycled viewport;
  • dashboard thread: initial content became visible without a gesture after roughly 13s; its two older-page loads rendered in roughly 8–12s each; the final fixed control read “Beginning of thread”;
  • title bounds stayed exactly [129,136]–[696,197] across initial loading, both prepends, the final-page transition, and every stress pass;
  • the full-history dashboard stress pass rendered 201 frames with 45.27% modern jank, p50 32ms, p90 77ms, p95 93ms, p99 150ms, and 40 missed vsyncs;
  • preview-dev-client PSS rose from about 1.98 GB before opening the dashboard thread to about 2.39 GB after full history and stress scrolling; these absolute dev-client values are diagnostic, not release acceptance numbers;
  • 16 focused tests passed and mobile typecheck passed again after the rebase. Targeted lint, targeted formatting, and git diff --check passed on the implementation head before the rebase.

The native blank-until-gesture and title/header-shift failures are fixed in these runs, but the current emulator measurements are not merge-ready. Keep this draft until the final rebased head gets a physical-device release-profile A/B and the remaining thread-load latency and scroll-frame costs are profiled. An earlier same-device physical A/B on the broader mobile rendering scope improved p99 from about 150ms to 73ms and PSS growth from about 161 MB to 97 MB, but that is not a substitute for a final-head rerun.

Implemented with GPT-5.6 Sol in the T3 Code Codex harness.

@coderabbitai

coderabbitaiBot commented Aug 5, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 420b7305-60f5-4848-ac6f-01112731f5f9

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:L 100-499 changed lines (additions + deletions). labels Aug 5, 2026
Comment threadapps/mobile/src/features/threads/ThreadFeed.tsx
Comment threadapps/server/src/orchestration/ActivityPayloadProjection.ts Outdated
@shivamhwp
shivamhwpforce-pushed the perf/android-large-thread-loading branch from b3d6668 to 0ebe016CompareAugust 5, 2026 09:51
Comment threadapps/server/src/orchestration/ActivityPayloadProjection.ts Outdated
@shivamhwp
shivamhwpforce-pushed the perf/android-large-thread-loading branch 3 times, most recently from f897132 to 39bf858CompareAugust 8, 2026 11:17
Comment threadapps/mobile/src/features/threads/ThreadFeed.tsx Outdated
@shivamhwp
shivamhwpforce-pushed the perf/android-large-thread-loading branch from bba60e2 to eeb9a52CompareAugust 9, 2026 01:19
Comment threadapps/mobile/src/features/threads/ThreadRouteScreen.tsx Outdated
@shivamhwp
shivamhwpforce-pushed the perf/android-large-thread-loading branch from 6bf27aa to 3e07aabCompareAugust 10, 2026 05:34
Comment threadapps/mobile/src/features/threads/ThreadRouteScreen.tsx
@shivamhwp
shivamhwpforce-pushed the perf/android-large-thread-loading branch from 7533aeb to 17a7a67CompareAugust 10, 2026 12:16
@shivamhwp
shivamhwpforce-pushed the perf/android-large-thread-loading branch from 17a7a67 to bb6f6a8CompareAugust 11, 2026 03:20
);
}

function OpeningThreadRouteScreen(props: {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Mediumthreads/ThreadRouteScreen.tsx:207

OpeningThreadRouteScreen renders LoadingScreen below an in-flow AndroidScreenHeader, but LoadingScreen independently adds paddingTop: insets.top. On Android the header already reserves the top safe-area inset, so the loading state double-counts the status-bar inset and shifts the centered spinner/message downward relative to the hydrated thread screen. Consider using a loading body that omits the top inset when rendered under this header.

🤖 Copy this AI Prompt to have your agent fix this:
In file @apps/mobile/src/features/threads/ThreadRouteScreen.tsx around line 207:
`OpeningThreadRouteScreen` renders `LoadingScreen` below an in-flow `AndroidScreenHeader`, but `LoadingScreen` independently adds `paddingTop: insets.top`. On Android the header already reserves the top safe-area inset, so the loading state double-counts the status-bar inset and shifts the centered spinner/message downward relative to the hydrated thread screen. Consider using a loading body that omits the top inset when rendered under this header.

@shivamhwp

Copy link
Copy Markdown
CollaboratorAuthor

Closing this draft because its scope now overlaps multiple focused efforts and combines thread loading, rendering, navigation, and title/layout stability changes. We should revisit the remaining performance work as smaller, independently measured PRs after the adjacent changes settle.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L100-499 changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@shivamhwp
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

perf(mobile): speed up large Android threads - #5393

Closed
shivamhwp wants to merge 7 commits into
pingdotgg:mainfrom
shivamhwp:perf/android-large-thread-loading
Closed

perf(mobile): speed up large Android threads#5393
shivamhwp wants to merge 7 commits into
pingdotgg:mainfrom
shivamhwp:perf/android-large-thread-loading

Conversation

@shivamhwp

@shivamhwpshivamhwp commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

Large Android threads can finish syncing while LegendList has no attached visible rows, leaving a blank feed until the user scrolls. Paginated prepends also changed the list-header height on the final page, which moved the title/feed anchor while Android restored visible content.

This draft stays mobile-only:

  • keep Android loading, unavailable, and hydrated thread headers on the same geometry;
  • recycle Android feed rows, reduce the Android draw window, and keep one row mounted at each list edge;
  • wake the Android native row-attachment path once after LegendList's initial end positioning;
  • keep a fixed-height history control through loading, additional pages, and “Beginning of thread” so final-page prepends do not change header height;
  • retain the existing feed-derivation and review-highlighter reductions already in this branch.

This does not replace server pagination from #5493. It also does not duplicate #5585: that PR seeds the composer inset before the initial scroll; this one handles positioned recycled rows that still fail to attach/paint. The final #5585 diff applies cleanly on top of this branch.

Verification on eeb9a52b2, rebased onto upstream main at 89c320df0:

  • signed-in preview development client on the API 36 Android emulator, using its existing T3 Connect account and three saved environments; no fixture or environment re-pairing;
  • fafo about t3code: cold current-head feed became visible without a gesture after roughly 40–45s; 24 alternating full-height swipes left 19 visible text nodes and six copy targets, with no blank recycled viewport;
  • dashboard thread: initial content became visible without a gesture after roughly 13s; its two older-page loads rendered in roughly 8–12s each; the final fixed control read “Beginning of thread”;
  • title bounds stayed exactly [129,136]–[696,197] across initial loading, both prepends, the final-page transition, and every stress pass;
  • the full-history dashboard stress pass rendered 201 frames with 45.27% modern jank, p50 32ms, p90 77ms, p95 93ms, p99 150ms, and 40 missed vsyncs;
  • preview-dev-client PSS rose from about 1.98 GB before opening the dashboard thread to about 2.39 GB after full history and stress scrolling; these absolute dev-client values are diagnostic, not release acceptance numbers;
  • 16 focused tests passed and mobile typecheck passed again after the rebase. Targeted lint, targeted formatting, and git diff --check passed on the implementation head before the rebase.

The native blank-until-gesture and title/header-shift failures are fixed in these runs, but the current emulator measurements are not merge-ready. Keep this draft until the final rebased head gets a physical-device release-profile A/B and the remaining thread-load latency and scroll-frame costs are profiled. An earlier same-device physical A/B on the broader mobile rendering scope improved p99 from about 150ms to 73ms and PSS growth from about 161 MB to 97 MB, but that is not a substitute for a final-head rerun.

Implemented with GPT-5.6 Sol in the T3 Code Codex harness.

@coderabbitai

coderabbitaiBot commented Aug 5, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 420b7305-60f5-4848-ac6f-01112731f5f9

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:L 100-499 changed lines (additions + deletions). labels Aug 5, 2026
Comment threadapps/mobile/src/features/threads/ThreadFeed.tsx
Comment threadapps/server/src/orchestration/ActivityPayloadProjection.ts Outdated
@shivamhwp
shivamhwpforce-pushed the perf/android-large-thread-loading branch from b3d6668 to 0ebe016CompareAugust 5, 2026 09:51
Comment threadapps/server/src/orchestration/ActivityPayloadProjection.ts Outdated
@shivamhwp
shivamhwpforce-pushed the perf/android-large-thread-loading branch 3 times, most recently from f897132 to 39bf858CompareAugust 8, 2026 11:17
Comment threadapps/mobile/src/features/threads/ThreadFeed.tsx Outdated
@shivamhwp
shivamhwpforce-pushed the perf/android-large-thread-loading branch from bba60e2 to eeb9a52CompareAugust 9, 2026 01:19
Comment threadapps/mobile/src/features/threads/ThreadRouteScreen.tsx Outdated
@shivamhwp
shivamhwpforce-pushed the perf/android-large-thread-loading branch from 6bf27aa to 3e07aabCompareAugust 10, 2026 05:34
Comment threadapps/mobile/src/features/threads/ThreadRouteScreen.tsx
@shivamhwp
shivamhwpforce-pushed the perf/android-large-thread-loading branch from 7533aeb to 17a7a67CompareAugust 10, 2026 12:16
@shivamhwp
shivamhwpforce-pushed the perf/android-large-thread-loading branch from 17a7a67 to bb6f6a8CompareAugust 11, 2026 03:20
);
}

function OpeningThreadRouteScreen(props: {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Mediumthreads/ThreadRouteScreen.tsx:207

OpeningThreadRouteScreen renders LoadingScreen below an in-flow AndroidScreenHeader, but LoadingScreen independently adds paddingTop: insets.top. On Android the header already reserves the top safe-area inset, so the loading state double-counts the status-bar inset and shifts the centered spinner/message downward relative to the hydrated thread screen. Consider using a loading body that omits the top inset when rendered under this header.

🤖 Copy this AI Prompt to have your agent fix this:
In file @apps/mobile/src/features/threads/ThreadRouteScreen.tsx around line 207:
`OpeningThreadRouteScreen` renders `LoadingScreen` below an in-flow `AndroidScreenHeader`, but `LoadingScreen` independently adds `paddingTop: insets.top`. On Android the header already reserves the top safe-area inset, so the loading state double-counts the status-bar inset and shifts the centered spinner/message downward relative to the hydrated thread screen. Consider using a loading body that omits the top inset when rendered under this header.

@shivamhwp

Copy link
Copy Markdown
CollaboratorAuthor

Closing this draft because its scope now overlaps multiple focused efforts and combines thread loading, rendering, navigation, and title/layout stability changes. We should revisit the remaining performance work as smaller, independently measured PRs after the adjacent changes settle.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L100-499 changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@shivamhwp
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

perf(mobile): speed up large Android threads - #5393

Closed
shivamhwp wants to merge 7 commits into
pingdotgg:mainfrom
shivamhwp:perf/android-large-thread-loading
Closed

perf(mobile): speed up large Android threads#5393
shivamhwp wants to merge 7 commits into
pingdotgg:mainfrom
shivamhwp:perf/android-large-thread-loading

Conversation

@shivamhwp

@shivamhwpshivamhwp commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

Large Android threads can finish syncing while LegendList has no attached visible rows, leaving a blank feed until the user scrolls. Paginated prepends also changed the list-header height on the final page, which moved the title/feed anchor while Android restored visible content.

This draft stays mobile-only:

  • keep Android loading, unavailable, and hydrated thread headers on the same geometry;
  • recycle Android feed rows, reduce the Android draw window, and keep one row mounted at each list edge;
  • wake the Android native row-attachment path once after LegendList's initial end positioning;
  • keep a fixed-height history control through loading, additional pages, and “Beginning of thread” so final-page prepends do not change header height;
  • retain the existing feed-derivation and review-highlighter reductions already in this branch.

This does not replace server pagination from #5493. It also does not duplicate #5585: that PR seeds the composer inset before the initial scroll; this one handles positioned recycled rows that still fail to attach/paint. The final #5585 diff applies cleanly on top of this branch.

Verification on eeb9a52b2, rebased onto upstream main at 89c320df0:

  • signed-in preview development client on the API 36 Android emulator, using its existing T3 Connect account and three saved environments; no fixture or environment re-pairing;
  • fafo about t3code: cold current-head feed became visible without a gesture after roughly 40–45s; 24 alternating full-height swipes left 19 visible text nodes and six copy targets, with no blank recycled viewport;
  • dashboard thread: initial content became visible without a gesture after roughly 13s; its two older-page loads rendered in roughly 8–12s each; the final fixed control read “Beginning of thread”;
  • title bounds stayed exactly [129,136]–[696,197] across initial loading, both prepends, the final-page transition, and every stress pass;
  • the full-history dashboard stress pass rendered 201 frames with 45.27% modern jank, p50 32ms, p90 77ms, p95 93ms, p99 150ms, and 40 missed vsyncs;
  • preview-dev-client PSS rose from about 1.98 GB before opening the dashboard thread to about 2.39 GB after full history and stress scrolling; these absolute dev-client values are diagnostic, not release acceptance numbers;
  • 16 focused tests passed and mobile typecheck passed again after the rebase. Targeted lint, targeted formatting, and git diff --check passed on the implementation head before the rebase.

The native blank-until-gesture and title/header-shift failures are fixed in these runs, but the current emulator measurements are not merge-ready. Keep this draft until the final rebased head gets a physical-device release-profile A/B and the remaining thread-load latency and scroll-frame costs are profiled. An earlier same-device physical A/B on the broader mobile rendering scope improved p99 from about 150ms to 73ms and PSS growth from about 161 MB to 97 MB, but that is not a substitute for a final-head rerun.

Implemented with GPT-5.6 Sol in the T3 Code Codex harness.

@coderabbitai

coderabbitaiBot commented Aug 5, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 420b7305-60f5-4848-ac6f-01112731f5f9

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:L 100-499 changed lines (additions + deletions). labels Aug 5, 2026
Comment threadapps/mobile/src/features/threads/ThreadFeed.tsx
Comment threadapps/server/src/orchestration/ActivityPayloadProjection.ts Outdated
@shivamhwp
shivamhwpforce-pushed the perf/android-large-thread-loading branch from b3d6668 to 0ebe016CompareAugust 5, 2026 09:51
Comment threadapps/server/src/orchestration/ActivityPayloadProjection.ts Outdated
@shivamhwp
shivamhwpforce-pushed the perf/android-large-thread-loading branch 3 times, most recently from f897132 to 39bf858CompareAugust 8, 2026 11:17
Comment threadapps/mobile/src/features/threads/ThreadFeed.tsx Outdated
@shivamhwp
shivamhwpforce-pushed the perf/android-large-thread-loading branch from bba60e2 to eeb9a52CompareAugust 9, 2026 01:19
Comment threadapps/mobile/src/features/threads/ThreadRouteScreen.tsx Outdated
@shivamhwp
shivamhwpforce-pushed the perf/android-large-thread-loading branch from 6bf27aa to 3e07aabCompareAugust 10, 2026 05:34
Comment threadapps/mobile/src/features/threads/ThreadRouteScreen.tsx
@shivamhwp
shivamhwpforce-pushed the perf/android-large-thread-loading branch from 7533aeb to 17a7a67CompareAugust 10, 2026 12:16
@shivamhwp
shivamhwpforce-pushed the perf/android-large-thread-loading branch from 17a7a67 to bb6f6a8CompareAugust 11, 2026 03:20
);
}

function OpeningThreadRouteScreen(props: {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Mediumthreads/ThreadRouteScreen.tsx:207

OpeningThreadRouteScreen renders LoadingScreen below an in-flow AndroidScreenHeader, but LoadingScreen independently adds paddingTop: insets.top. On Android the header already reserves the top safe-area inset, so the loading state double-counts the status-bar inset and shifts the centered spinner/message downward relative to the hydrated thread screen. Consider using a loading body that omits the top inset when rendered under this header.

🤖 Copy this AI Prompt to have your agent fix this:
In file @apps/mobile/src/features/threads/ThreadRouteScreen.tsx around line 207:
`OpeningThreadRouteScreen` renders `LoadingScreen` below an in-flow `AndroidScreenHeader`, but `LoadingScreen` independently adds `paddingTop: insets.top`. On Android the header already reserves the top safe-area inset, so the loading state double-counts the status-bar inset and shifts the centered spinner/message downward relative to the hydrated thread screen. Consider using a loading body that omits the top inset when rendered under this header.

@shivamhwp

Copy link
Copy Markdown
CollaboratorAuthor

Closing this draft because its scope now overlaps multiple focused efforts and combines thread loading, rendering, navigation, and title/layout stability changes. We should revisit the remaining performance work as smaller, independently measured PRs after the adjacent changes settle.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L100-499 changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@shivamhwp
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

perf(mobile): speed up large Android threads - #5393

Closed
shivamhwp wants to merge 7 commits into
pingdotgg:mainfrom
shivamhwp:perf/android-large-thread-loading
Closed

perf(mobile): speed up large Android threads#5393
shivamhwp wants to merge 7 commits into
pingdotgg:mainfrom
shivamhwp:perf/android-large-thread-loading

Conversation

@shivamhwp

@shivamhwpshivamhwp commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

Large Android threads can finish syncing while LegendList has no attached visible rows, leaving a blank feed until the user scrolls. Paginated prepends also changed the list-header height on the final page, which moved the title/feed anchor while Android restored visible content.

This draft stays mobile-only:

  • keep Android loading, unavailable, and hydrated thread headers on the same geometry;
  • recycle Android feed rows, reduce the Android draw window, and keep one row mounted at each list edge;
  • wake the Android native row-attachment path once after LegendList's initial end positioning;
  • keep a fixed-height history control through loading, additional pages, and “Beginning of thread” so final-page prepends do not change header height;
  • retain the existing feed-derivation and review-highlighter reductions already in this branch.

This does not replace server pagination from #5493. It also does not duplicate #5585: that PR seeds the composer inset before the initial scroll; this one handles positioned recycled rows that still fail to attach/paint. The final #5585 diff applies cleanly on top of this branch.

Verification on eeb9a52b2, rebased onto upstream main at 89c320df0:

  • signed-in preview development client on the API 36 Android emulator, using its existing T3 Connect account and three saved environments; no fixture or environment re-pairing;
  • fafo about t3code: cold current-head feed became visible without a gesture after roughly 40–45s; 24 alternating full-height swipes left 19 visible text nodes and six copy targets, with no blank recycled viewport;
  • dashboard thread: initial content became visible without a gesture after roughly 13s; its two older-page loads rendered in roughly 8–12s each; the final fixed control read “Beginning of thread”;
  • title bounds stayed exactly [129,136]–[696,197] across initial loading, both prepends, the final-page transition, and every stress pass;
  • the full-history dashboard stress pass rendered 201 frames with 45.27% modern jank, p50 32ms, p90 77ms, p95 93ms, p99 150ms, and 40 missed vsyncs;
  • preview-dev-client PSS rose from about 1.98 GB before opening the dashboard thread to about 2.39 GB after full history and stress scrolling; these absolute dev-client values are diagnostic, not release acceptance numbers;
  • 16 focused tests passed and mobile typecheck passed again after the rebase. Targeted lint, targeted formatting, and git diff --check passed on the implementation head before the rebase.

The native blank-until-gesture and title/header-shift failures are fixed in these runs, but the current emulator measurements are not merge-ready. Keep this draft until the final rebased head gets a physical-device release-profile A/B and the remaining thread-load latency and scroll-frame costs are profiled. An earlier same-device physical A/B on the broader mobile rendering scope improved p99 from about 150ms to 73ms and PSS growth from about 161 MB to 97 MB, but that is not a substitute for a final-head rerun.

Implemented with GPT-5.6 Sol in the T3 Code Codex harness.

@coderabbitai

coderabbitaiBot commented Aug 5, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 420b7305-60f5-4848-ac6f-01112731f5f9

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:L 100-499 changed lines (additions + deletions). labels Aug 5, 2026
Comment threadapps/mobile/src/features/threads/ThreadFeed.tsx
Comment threadapps/server/src/orchestration/ActivityPayloadProjection.ts Outdated
@shivamhwp
shivamhwpforce-pushed the perf/android-large-thread-loading branch from b3d6668 to 0ebe016CompareAugust 5, 2026 09:51
Comment threadapps/server/src/orchestration/ActivityPayloadProjection.ts Outdated
@shivamhwp
shivamhwpforce-pushed the perf/android-large-thread-loading branch 3 times, most recently from f897132 to 39bf858CompareAugust 8, 2026 11:17
Comment threadapps/mobile/src/features/threads/ThreadFeed.tsx Outdated
@shivamhwp
shivamhwpforce-pushed the perf/android-large-thread-loading branch from bba60e2 to eeb9a52CompareAugust 9, 2026 01:19
Comment threadapps/mobile/src/features/threads/ThreadRouteScreen.tsx Outdated
@shivamhwp
shivamhwpforce-pushed the perf/android-large-thread-loading branch from 6bf27aa to 3e07aabCompareAugust 10, 2026 05:34
Comment threadapps/mobile/src/features/threads/ThreadRouteScreen.tsx
@shivamhwp
shivamhwpforce-pushed the perf/android-large-thread-loading branch from 7533aeb to 17a7a67CompareAugust 10, 2026 12:16
@shivamhwp
shivamhwpforce-pushed the perf/android-large-thread-loading branch from 17a7a67 to bb6f6a8CompareAugust 11, 2026 03:20
);
}

function OpeningThreadRouteScreen(props: {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Mediumthreads/ThreadRouteScreen.tsx:207

OpeningThreadRouteScreen renders LoadingScreen below an in-flow AndroidScreenHeader, but LoadingScreen independently adds paddingTop: insets.top. On Android the header already reserves the top safe-area inset, so the loading state double-counts the status-bar inset and shifts the centered spinner/message downward relative to the hydrated thread screen. Consider using a loading body that omits the top inset when rendered under this header.

🤖 Copy this AI Prompt to have your agent fix this:
In file @apps/mobile/src/features/threads/ThreadRouteScreen.tsx around line 207:
`OpeningThreadRouteScreen` renders `LoadingScreen` below an in-flow `AndroidScreenHeader`, but `LoadingScreen` independently adds `paddingTop: insets.top`. On Android the header already reserves the top safe-area inset, so the loading state double-counts the status-bar inset and shifts the centered spinner/message downward relative to the hydrated thread screen. Consider using a loading body that omits the top inset when rendered under this header.

@shivamhwp

Copy link
Copy Markdown
CollaboratorAuthor

Closing this draft because its scope now overlaps multiple focused efforts and combines thread loading, rendering, navigation, and title/layout stability changes. We should revisit the remaining performance work as smaller, independently measured PRs after the adjacent changes settle.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L100-499 changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@shivamhwp
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

perf(mobile): speed up large Android threads - #5393

Closed
shivamhwp wants to merge 7 commits into
pingdotgg:mainfrom
shivamhwp:perf/android-large-thread-loading
Closed

perf(mobile): speed up large Android threads#5393
shivamhwp wants to merge 7 commits into
pingdotgg:mainfrom
shivamhwp:perf/android-large-thread-loading

Conversation

@shivamhwp

@shivamhwpshivamhwp commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

Large Android threads can finish syncing while LegendList has no attached visible rows, leaving a blank feed until the user scrolls. Paginated prepends also changed the list-header height on the final page, which moved the title/feed anchor while Android restored visible content.

This draft stays mobile-only:

  • keep Android loading, unavailable, and hydrated thread headers on the same geometry;
  • recycle Android feed rows, reduce the Android draw window, and keep one row mounted at each list edge;
  • wake the Android native row-attachment path once after LegendList's initial end positioning;
  • keep a fixed-height history control through loading, additional pages, and “Beginning of thread” so final-page prepends do not change header height;
  • retain the existing feed-derivation and review-highlighter reductions already in this branch.

This does not replace server pagination from #5493. It also does not duplicate #5585: that PR seeds the composer inset before the initial scroll; this one handles positioned recycled rows that still fail to attach/paint. The final #5585 diff applies cleanly on top of this branch.

Verification on eeb9a52b2, rebased onto upstream main at 89c320df0:

  • signed-in preview development client on the API 36 Android emulator, using its existing T3 Connect account and three saved environments; no fixture or environment re-pairing;
  • fafo about t3code: cold current-head feed became visible without a gesture after roughly 40–45s; 24 alternating full-height swipes left 19 visible text nodes and six copy targets, with no blank recycled viewport;
  • dashboard thread: initial content became visible without a gesture after roughly 13s; its two older-page loads rendered in roughly 8–12s each; the final fixed control read “Beginning of thread”;
  • title bounds stayed exactly [129,136]–[696,197] across initial loading, both prepends, the final-page transition, and every stress pass;
  • the full-history dashboard stress pass rendered 201 frames with 45.27% modern jank, p50 32ms, p90 77ms, p95 93ms, p99 150ms, and 40 missed vsyncs;
  • preview-dev-client PSS rose from about 1.98 GB before opening the dashboard thread to about 2.39 GB after full history and stress scrolling; these absolute dev-client values are diagnostic, not release acceptance numbers;
  • 16 focused tests passed and mobile typecheck passed again after the rebase. Targeted lint, targeted formatting, and git diff --check passed on the implementation head before the rebase.

The native blank-until-gesture and title/header-shift failures are fixed in these runs, but the current emulator measurements are not merge-ready. Keep this draft until the final rebased head gets a physical-device release-profile A/B and the remaining thread-load latency and scroll-frame costs are profiled. An earlier same-device physical A/B on the broader mobile rendering scope improved p99 from about 150ms to 73ms and PSS growth from about 161 MB to 97 MB, but that is not a substitute for a final-head rerun.

Implemented with GPT-5.6 Sol in the T3 Code Codex harness.

@coderabbitai

coderabbitaiBot commented Aug 5, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 420b7305-60f5-4848-ac6f-01112731f5f9

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:L 100-499 changed lines (additions + deletions). labels Aug 5, 2026
Comment threadapps/mobile/src/features/threads/ThreadFeed.tsx
Comment threadapps/server/src/orchestration/ActivityPayloadProjection.ts Outdated
@shivamhwp
shivamhwpforce-pushed the perf/android-large-thread-loading branch from b3d6668 to 0ebe016CompareAugust 5, 2026 09:51
Comment threadapps/server/src/orchestration/ActivityPayloadProjection.ts Outdated
@shivamhwp
shivamhwpforce-pushed the perf/android-large-thread-loading branch 3 times, most recently from f897132 to 39bf858CompareAugust 8, 2026 11:17
Comment threadapps/mobile/src/features/threads/ThreadFeed.tsx Outdated
@shivamhwp
shivamhwpforce-pushed the perf/android-large-thread-loading branch from bba60e2 to eeb9a52CompareAugust 9, 2026 01:19
Comment threadapps/mobile/src/features/threads/ThreadRouteScreen.tsx Outdated
@shivamhwp
shivamhwpforce-pushed the perf/android-large-thread-loading branch from 6bf27aa to 3e07aabCompareAugust 10, 2026 05:34
Comment threadapps/mobile/src/features/threads/ThreadRouteScreen.tsx
@shivamhwp
shivamhwpforce-pushed the perf/android-large-thread-loading branch from 7533aeb to 17a7a67CompareAugust 10, 2026 12:16
@shivamhwp
shivamhwpforce-pushed the perf/android-large-thread-loading branch from 17a7a67 to bb6f6a8CompareAugust 11, 2026 03:20
);
}

function OpeningThreadRouteScreen(props: {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Mediumthreads/ThreadRouteScreen.tsx:207

OpeningThreadRouteScreen renders LoadingScreen below an in-flow AndroidScreenHeader, but LoadingScreen independently adds paddingTop: insets.top. On Android the header already reserves the top safe-area inset, so the loading state double-counts the status-bar inset and shifts the centered spinner/message downward relative to the hydrated thread screen. Consider using a loading body that omits the top inset when rendered under this header.

🤖 Copy this AI Prompt to have your agent fix this:
In file @apps/mobile/src/features/threads/ThreadRouteScreen.tsx around line 207:
`OpeningThreadRouteScreen` renders `LoadingScreen` below an in-flow `AndroidScreenHeader`, but `LoadingScreen` independently adds `paddingTop: insets.top`. On Android the header already reserves the top safe-area inset, so the loading state double-counts the status-bar inset and shifts the centered spinner/message downward relative to the hydrated thread screen. Consider using a loading body that omits the top inset when rendered under this header.

@shivamhwp

Copy link
Copy Markdown
CollaboratorAuthor

Closing this draft because its scope now overlaps multiple focused efforts and combines thread loading, rendering, navigation, and title/layout stability changes. We should revisit the remaining performance work as smaller, independently measured PRs after the adjacent changes settle.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L100-499 changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@shivamhwp