test(web): raise imageCompression ladder test timeout for slow runners - #5416

Closed
snowykr wants to merge 1 commit into
pingdotgg:mainfrom
snowykr:test-imagecompression-timeout
Closed

test(web): raise imageCompression ladder test timeout for slow runners#5416
snowykr wants to merge 1 commit into
pingdotgg:mainfrom
snowykr:test-imagecompression-timeout

Conversation

@snowykr

@snowykrsnowykr commented Aug 5, 2026

Copy link
Copy Markdown

What Changed

Speed up the imageCompression.test.ts case "reports too-large when even the smallest encoding overflows the budget" so it completes within the default 15s per-test timeout instead of relying on a raised timeout.

Previously the stub returned an 8 MB blob for every ladder step (3 fallback scales × [probe + 4 quality steps] = 15 encodes), materializing and base64-encoding ~120 MB per run — ~41s on 2-vCPU GitHub-hosted runners, failing with Test timed out in 15000ms. The 8-vCPU blacksmith runners used in this repo are fast enough that it stayed under 15s, so the failure only surfaced on slower machines.

Now the stub returns a 300 KB blob and the test passes an explicit small budget (150_000 chars) to compressImageForStash, so every encode still overflows the budget and the give-up path (too-large + bitmap release) runs exactly as before — but the base64 work drops to ~4.5 MB (15 × 300 KB) plus the one-time 9 MB source encode. The 60_000 timeout override is removed.

No production code, stubs, payloads, or assertions change — the test's semantics are untouched.

Why

Test-robustness only: keep the ladder's give-up behavior fully exercised on slow CI runners without paying for multi-megabyte base64 payloads on every quality step (AGENTS.md "Performance without compromise").

Validation

  • Local targeted run: changed test ~0.9s; 12/12 tests in the file pass.
  • vp lint, vp fmt --check, and tsgo --noEmit for apps/web are clean.
  • Fork CI (ubuntu-latest, 2-vCPU GitHub-hosted runners) was previously failing 3/3 with Test timed out in 15000ms on the old fixture.

Related work

Complements #5220 (perf(web): skip base64 for oversized image candidates), which fixes the underlying slowness in the source by skipping base64 for candidates that already exceed the budget.

UI Changes

N/A — test-only change, no UI.


Note

Low Risk
Test-only fixture change; no production or assertion semantics change.

Overview
The "reports too-large when even the smallest encoding overflows the budget" case in imageCompression.test.ts no longer simulates 8 MB encodes on every ladder step. The canvas stub now returns 300 KB blobs, and the test calls compressImageForStash with an explicit 150_000 character budget so every step still overflows and the same too-large + bitmap close behavior is asserted.

This cuts per-run base64 work from ~120 MB to a few MB so the test stays under the default 15s timeout on 2-vCPU GitHub runners without a raised timeout. Production code is unchanged; only the test fixture and optional budget argument differ.

Reviewed by Cursor Bugbot for commit 6849430. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Reduce encoded sizes in compressImageForStash ladder test to avoid timeout on slow runners

The stubbed encoder in the "reports too-large when even the smallest encoding overflows the budget" test previously returned 8,000,000 bytes, causing timeouts on slow CI runners. It now returns 300,000 bytes, and compressImageForStash is called with an explicit 150,000-byte budget, keeping the { ok: false, reason: "too-large" } assertion intact without generating large payloads.

Macroscope summarized 6849430.

@coderabbitai

coderabbitaiBot commented Aug 5, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 5e08a906-53c5-40bd-ae6d-2b460fcb0722

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actionsgithub-actionsBot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Aug 5, 2026
@macroscopeapp

macroscopeappBot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved 19f78dd

Test-only change that reduces stub payload sizes in imageCompression.test.ts to improve test performance on slow runners. No production code is affected.

No code changes detected at 6849430. Prior analysis still applies.

You can customize Macroscope's approvability policy. Learn more.

macroscopeapp[bot]
macroscopeappBot previously approved these changes Aug 5, 2026
@snowykr
snowykrforce-pushed the test-imagecompression-timeout branch from f956df9 to de5988aCompareAugust 6, 2026 10:17

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:de5988ab03

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadapps/web/src/lib/imageCompression.test.ts Outdated
@snowykr
snowykrforce-pushed the test-imagecompression-timeout branch from de5988a to 19f78ddCompareAugust 6, 2026 10:34
@macroscopeapp
macroscopeappBot dismissed their stale reviewAugust 6, 2026 10:34

Dismissing prior approval to re-evaluate 19f78dd

@snowykr
snowykrforce-pushed the test-imagecompression-timeout branch from 19f78dd to 177c50cCompareAugust 6, 2026 14:57
@snowykr
snowykrforce-pushed the test-imagecompression-timeout branch from 177c50c to 6849430CompareAugust 10, 2026 08:19
@t3dotgg

Copy link
Copy Markdown
Member

Note

🤖 GPT-5.6 Sol responding on behalf of Theo

We're closing this PR as we clean up the T3 Code backlog. Thank you for taking the time to put this together.

The current patch shrinks the image-compression fixture and its test budget so the test can use the default timeout. We are not keeping a separate PR open for this isolated test maintenance change.

If you believe we closed this in error, please reopen the PR and leave a comment explaining what we missed.

@t3dotggt3dotgg closed this Aug 28, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS0-9 changed lines (additions + deletions).vouch:unvouchedPR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@snowykr@t3dotgg
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

test(web): raise imageCompression ladder test timeout for slow runners - #5416

Closed
snowykr wants to merge 1 commit into
pingdotgg:mainfrom
snowykr:test-imagecompression-timeout
Closed

test(web): raise imageCompression ladder test timeout for slow runners#5416
snowykr wants to merge 1 commit into
pingdotgg:mainfrom
snowykr:test-imagecompression-timeout

Conversation

@snowykr

@snowykrsnowykr commented Aug 5, 2026

Copy link
Copy Markdown

What Changed

Speed up the imageCompression.test.ts case "reports too-large when even the smallest encoding overflows the budget" so it completes within the default 15s per-test timeout instead of relying on a raised timeout.

Previously the stub returned an 8 MB blob for every ladder step (3 fallback scales × [probe + 4 quality steps] = 15 encodes), materializing and base64-encoding ~120 MB per run — ~41s on 2-vCPU GitHub-hosted runners, failing with Test timed out in 15000ms. The 8-vCPU blacksmith runners used in this repo are fast enough that it stayed under 15s, so the failure only surfaced on slower machines.

Now the stub returns a 300 KB blob and the test passes an explicit small budget (150_000 chars) to compressImageForStash, so every encode still overflows the budget and the give-up path (too-large + bitmap release) runs exactly as before — but the base64 work drops to ~4.5 MB (15 × 300 KB) plus the one-time 9 MB source encode. The 60_000 timeout override is removed.

No production code, stubs, payloads, or assertions change — the test's semantics are untouched.

Why

Test-robustness only: keep the ladder's give-up behavior fully exercised on slow CI runners without paying for multi-megabyte base64 payloads on every quality step (AGENTS.md "Performance without compromise").

Validation

  • Local targeted run: changed test ~0.9s; 12/12 tests in the file pass.
  • vp lint, vp fmt --check, and tsgo --noEmit for apps/web are clean.
  • Fork CI (ubuntu-latest, 2-vCPU GitHub-hosted runners) was previously failing 3/3 with Test timed out in 15000ms on the old fixture.

Related work

Complements #5220 (perf(web): skip base64 for oversized image candidates), which fixes the underlying slowness in the source by skipping base64 for candidates that already exceed the budget.

UI Changes

N/A — test-only change, no UI.


Note

Low Risk
Test-only fixture change; no production or assertion semantics change.

Overview
The "reports too-large when even the smallest encoding overflows the budget" case in imageCompression.test.ts no longer simulates 8 MB encodes on every ladder step. The canvas stub now returns 300 KB blobs, and the test calls compressImageForStash with an explicit 150_000 character budget so every step still overflows and the same too-large + bitmap close behavior is asserted.

This cuts per-run base64 work from ~120 MB to a few MB so the test stays under the default 15s timeout on 2-vCPU GitHub runners without a raised timeout. Production code is unchanged; only the test fixture and optional budget argument differ.

Reviewed by Cursor Bugbot for commit 6849430. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Reduce encoded sizes in compressImageForStash ladder test to avoid timeout on slow runners

The stubbed encoder in the "reports too-large when even the smallest encoding overflows the budget" test previously returned 8,000,000 bytes, causing timeouts on slow CI runners. It now returns 300,000 bytes, and compressImageForStash is called with an explicit 150,000-byte budget, keeping the { ok: false, reason: "too-large" } assertion intact without generating large payloads.

Macroscope summarized 6849430.

@coderabbitai

coderabbitaiBot commented Aug 5, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 5e08a906-53c5-40bd-ae6d-2b460fcb0722

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actionsgithub-actionsBot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Aug 5, 2026
@macroscopeapp

macroscopeappBot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved 19f78dd

Test-only change that reduces stub payload sizes in imageCompression.test.ts to improve test performance on slow runners. No production code is affected.

No code changes detected at 6849430. Prior analysis still applies.

You can customize Macroscope's approvability policy. Learn more.

macroscopeapp[bot]
macroscopeappBot previously approved these changes Aug 5, 2026
@snowykr
snowykrforce-pushed the test-imagecompression-timeout branch from f956df9 to de5988aCompareAugust 6, 2026 10:17

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:de5988ab03

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadapps/web/src/lib/imageCompression.test.ts Outdated
@snowykr
snowykrforce-pushed the test-imagecompression-timeout branch from de5988a to 19f78ddCompareAugust 6, 2026 10:34
@macroscopeapp
macroscopeappBot dismissed their stale reviewAugust 6, 2026 10:34

Dismissing prior approval to re-evaluate 19f78dd

@snowykr
snowykrforce-pushed the test-imagecompression-timeout branch from 19f78dd to 177c50cCompareAugust 6, 2026 14:57
@snowykr
snowykrforce-pushed the test-imagecompression-timeout branch from 177c50c to 6849430CompareAugust 10, 2026 08:19
@t3dotgg

Copy link
Copy Markdown
Member

Note

🤖 GPT-5.6 Sol responding on behalf of Theo

We're closing this PR as we clean up the T3 Code backlog. Thank you for taking the time to put this together.

The current patch shrinks the image-compression fixture and its test budget so the test can use the default timeout. We are not keeping a separate PR open for this isolated test maintenance change.

If you believe we closed this in error, please reopen the PR and leave a comment explaining what we missed.

@t3dotggt3dotgg closed this Aug 28, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS0-9 changed lines (additions + deletions).vouch:unvouchedPR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@snowykr@t3dotgg
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

test(web): raise imageCompression ladder test timeout for slow runners - #5416

Closed
snowykr wants to merge 1 commit into
pingdotgg:mainfrom
snowykr:test-imagecompression-timeout
Closed

test(web): raise imageCompression ladder test timeout for slow runners#5416
snowykr wants to merge 1 commit into
pingdotgg:mainfrom
snowykr:test-imagecompression-timeout

Conversation

@snowykr

@snowykrsnowykr commented Aug 5, 2026

Copy link
Copy Markdown

What Changed

Speed up the imageCompression.test.ts case "reports too-large when even the smallest encoding overflows the budget" so it completes within the default 15s per-test timeout instead of relying on a raised timeout.

Previously the stub returned an 8 MB blob for every ladder step (3 fallback scales × [probe + 4 quality steps] = 15 encodes), materializing and base64-encoding ~120 MB per run — ~41s on 2-vCPU GitHub-hosted runners, failing with Test timed out in 15000ms. The 8-vCPU blacksmith runners used in this repo are fast enough that it stayed under 15s, so the failure only surfaced on slower machines.

Now the stub returns a 300 KB blob and the test passes an explicit small budget (150_000 chars) to compressImageForStash, so every encode still overflows the budget and the give-up path (too-large + bitmap release) runs exactly as before — but the base64 work drops to ~4.5 MB (15 × 300 KB) plus the one-time 9 MB source encode. The 60_000 timeout override is removed.

No production code, stubs, payloads, or assertions change — the test's semantics are untouched.

Why

Test-robustness only: keep the ladder's give-up behavior fully exercised on slow CI runners without paying for multi-megabyte base64 payloads on every quality step (AGENTS.md "Performance without compromise").

Validation

  • Local targeted run: changed test ~0.9s; 12/12 tests in the file pass.
  • vp lint, vp fmt --check, and tsgo --noEmit for apps/web are clean.
  • Fork CI (ubuntu-latest, 2-vCPU GitHub-hosted runners) was previously failing 3/3 with Test timed out in 15000ms on the old fixture.

Related work

Complements #5220 (perf(web): skip base64 for oversized image candidates), which fixes the underlying slowness in the source by skipping base64 for candidates that already exceed the budget.

UI Changes

N/A — test-only change, no UI.


Note

Low Risk
Test-only fixture change; no production or assertion semantics change.

Overview
The "reports too-large when even the smallest encoding overflows the budget" case in imageCompression.test.ts no longer simulates 8 MB encodes on every ladder step. The canvas stub now returns 300 KB blobs, and the test calls compressImageForStash with an explicit 150_000 character budget so every step still overflows and the same too-large + bitmap close behavior is asserted.

This cuts per-run base64 work from ~120 MB to a few MB so the test stays under the default 15s timeout on 2-vCPU GitHub runners without a raised timeout. Production code is unchanged; only the test fixture and optional budget argument differ.

Reviewed by Cursor Bugbot for commit 6849430. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Reduce encoded sizes in compressImageForStash ladder test to avoid timeout on slow runners

The stubbed encoder in the "reports too-large when even the smallest encoding overflows the budget" test previously returned 8,000,000 bytes, causing timeouts on slow CI runners. It now returns 300,000 bytes, and compressImageForStash is called with an explicit 150,000-byte budget, keeping the { ok: false, reason: "too-large" } assertion intact without generating large payloads.

Macroscope summarized 6849430.

@coderabbitai

coderabbitaiBot commented Aug 5, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 5e08a906-53c5-40bd-ae6d-2b460fcb0722

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actionsgithub-actionsBot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Aug 5, 2026
@macroscopeapp

macroscopeappBot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved 19f78dd

Test-only change that reduces stub payload sizes in imageCompression.test.ts to improve test performance on slow runners. No production code is affected.

No code changes detected at 6849430. Prior analysis still applies.

You can customize Macroscope's approvability policy. Learn more.

macroscopeapp[bot]
macroscopeappBot previously approved these changes Aug 5, 2026
@snowykr
snowykrforce-pushed the test-imagecompression-timeout branch from f956df9 to de5988aCompareAugust 6, 2026 10:17

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:de5988ab03

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadapps/web/src/lib/imageCompression.test.ts Outdated
@snowykr
snowykrforce-pushed the test-imagecompression-timeout branch from de5988a to 19f78ddCompareAugust 6, 2026 10:34
@macroscopeapp
macroscopeappBot dismissed their stale reviewAugust 6, 2026 10:34

Dismissing prior approval to re-evaluate 19f78dd

@snowykr
snowykrforce-pushed the test-imagecompression-timeout branch from 19f78dd to 177c50cCompareAugust 6, 2026 14:57
@snowykr
snowykrforce-pushed the test-imagecompression-timeout branch from 177c50c to 6849430CompareAugust 10, 2026 08:19
@t3dotgg

Copy link
Copy Markdown
Member

Note

🤖 GPT-5.6 Sol responding on behalf of Theo

We're closing this PR as we clean up the T3 Code backlog. Thank you for taking the time to put this together.

The current patch shrinks the image-compression fixture and its test budget so the test can use the default timeout. We are not keeping a separate PR open for this isolated test maintenance change.

If you believe we closed this in error, please reopen the PR and leave a comment explaining what we missed.

@t3dotggt3dotgg closed this Aug 28, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS0-9 changed lines (additions + deletions).vouch:unvouchedPR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@snowykr@t3dotgg
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

test(web): raise imageCompression ladder test timeout for slow runners - #5416

Closed
snowykr wants to merge 1 commit into
pingdotgg:mainfrom
snowykr:test-imagecompression-timeout
Closed

test(web): raise imageCompression ladder test timeout for slow runners#5416
snowykr wants to merge 1 commit into
pingdotgg:mainfrom
snowykr:test-imagecompression-timeout

Conversation

@snowykr

@snowykrsnowykr commented Aug 5, 2026

Copy link
Copy Markdown

What Changed

Speed up the imageCompression.test.ts case "reports too-large when even the smallest encoding overflows the budget" so it completes within the default 15s per-test timeout instead of relying on a raised timeout.

Previously the stub returned an 8 MB blob for every ladder step (3 fallback scales × [probe + 4 quality steps] = 15 encodes), materializing and base64-encoding ~120 MB per run — ~41s on 2-vCPU GitHub-hosted runners, failing with Test timed out in 15000ms. The 8-vCPU blacksmith runners used in this repo are fast enough that it stayed under 15s, so the failure only surfaced on slower machines.

Now the stub returns a 300 KB blob and the test passes an explicit small budget (150_000 chars) to compressImageForStash, so every encode still overflows the budget and the give-up path (too-large + bitmap release) runs exactly as before — but the base64 work drops to ~4.5 MB (15 × 300 KB) plus the one-time 9 MB source encode. The 60_000 timeout override is removed.

No production code, stubs, payloads, or assertions change — the test's semantics are untouched.

Why

Test-robustness only: keep the ladder's give-up behavior fully exercised on slow CI runners without paying for multi-megabyte base64 payloads on every quality step (AGENTS.md "Performance without compromise").

Validation

  • Local targeted run: changed test ~0.9s; 12/12 tests in the file pass.
  • vp lint, vp fmt --check, and tsgo --noEmit for apps/web are clean.
  • Fork CI (ubuntu-latest, 2-vCPU GitHub-hosted runners) was previously failing 3/3 with Test timed out in 15000ms on the old fixture.

Related work

Complements #5220 (perf(web): skip base64 for oversized image candidates), which fixes the underlying slowness in the source by skipping base64 for candidates that already exceed the budget.

UI Changes

N/A — test-only change, no UI.


Note

Low Risk
Test-only fixture change; no production or assertion semantics change.

Overview
The "reports too-large when even the smallest encoding overflows the budget" case in imageCompression.test.ts no longer simulates 8 MB encodes on every ladder step. The canvas stub now returns 300 KB blobs, and the test calls compressImageForStash with an explicit 150_000 character budget so every step still overflows and the same too-large + bitmap close behavior is asserted.

This cuts per-run base64 work from ~120 MB to a few MB so the test stays under the default 15s timeout on 2-vCPU GitHub runners without a raised timeout. Production code is unchanged; only the test fixture and optional budget argument differ.

Reviewed by Cursor Bugbot for commit 6849430. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Reduce encoded sizes in compressImageForStash ladder test to avoid timeout on slow runners

The stubbed encoder in the "reports too-large when even the smallest encoding overflows the budget" test previously returned 8,000,000 bytes, causing timeouts on slow CI runners. It now returns 300,000 bytes, and compressImageForStash is called with an explicit 150,000-byte budget, keeping the { ok: false, reason: "too-large" } assertion intact without generating large payloads.

Macroscope summarized 6849430.

@coderabbitai

coderabbitaiBot commented Aug 5, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 5e08a906-53c5-40bd-ae6d-2b460fcb0722

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actionsgithub-actionsBot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Aug 5, 2026
@macroscopeapp

macroscopeappBot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved 19f78dd

Test-only change that reduces stub payload sizes in imageCompression.test.ts to improve test performance on slow runners. No production code is affected.

No code changes detected at 6849430. Prior analysis still applies.

You can customize Macroscope's approvability policy. Learn more.

macroscopeapp[bot]
macroscopeappBot previously approved these changes Aug 5, 2026
@snowykr
snowykrforce-pushed the test-imagecompression-timeout branch from f956df9 to de5988aCompareAugust 6, 2026 10:17

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:de5988ab03

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadapps/web/src/lib/imageCompression.test.ts Outdated
@snowykr
snowykrforce-pushed the test-imagecompression-timeout branch from de5988a to 19f78ddCompareAugust 6, 2026 10:34
@macroscopeapp
macroscopeappBot dismissed their stale reviewAugust 6, 2026 10:34

Dismissing prior approval to re-evaluate 19f78dd

@snowykr
snowykrforce-pushed the test-imagecompression-timeout branch from 19f78dd to 177c50cCompareAugust 6, 2026 14:57
@snowykr
snowykrforce-pushed the test-imagecompression-timeout branch from 177c50c to 6849430CompareAugust 10, 2026 08:19
@t3dotgg

Copy link
Copy Markdown
Member

Note

🤖 GPT-5.6 Sol responding on behalf of Theo

We're closing this PR as we clean up the T3 Code backlog. Thank you for taking the time to put this together.

The current patch shrinks the image-compression fixture and its test budget so the test can use the default timeout. We are not keeping a separate PR open for this isolated test maintenance change.

If you believe we closed this in error, please reopen the PR and leave a comment explaining what we missed.

@t3dotggt3dotgg closed this Aug 28, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS0-9 changed lines (additions + deletions).vouch:unvouchedPR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@snowykr@t3dotgg
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

test(web): raise imageCompression ladder test timeout for slow runners - #5416

Closed
snowykr wants to merge 1 commit into
pingdotgg:mainfrom
snowykr:test-imagecompression-timeout
Closed

test(web): raise imageCompression ladder test timeout for slow runners#5416
snowykr wants to merge 1 commit into
pingdotgg:mainfrom
snowykr:test-imagecompression-timeout

Conversation

@snowykr

@snowykrsnowykr commented Aug 5, 2026

Copy link
Copy Markdown

What Changed

Speed up the imageCompression.test.ts case "reports too-large when even the smallest encoding overflows the budget" so it completes within the default 15s per-test timeout instead of relying on a raised timeout.

Previously the stub returned an 8 MB blob for every ladder step (3 fallback scales × [probe + 4 quality steps] = 15 encodes), materializing and base64-encoding ~120 MB per run — ~41s on 2-vCPU GitHub-hosted runners, failing with Test timed out in 15000ms. The 8-vCPU blacksmith runners used in this repo are fast enough that it stayed under 15s, so the failure only surfaced on slower machines.

Now the stub returns a 300 KB blob and the test passes an explicit small budget (150_000 chars) to compressImageForStash, so every encode still overflows the budget and the give-up path (too-large + bitmap release) runs exactly as before — but the base64 work drops to ~4.5 MB (15 × 300 KB) plus the one-time 9 MB source encode. The 60_000 timeout override is removed.

No production code, stubs, payloads, or assertions change — the test's semantics are untouched.

Why

Test-robustness only: keep the ladder's give-up behavior fully exercised on slow CI runners without paying for multi-megabyte base64 payloads on every quality step (AGENTS.md "Performance without compromise").

Validation

  • Local targeted run: changed test ~0.9s; 12/12 tests in the file pass.
  • vp lint, vp fmt --check, and tsgo --noEmit for apps/web are clean.
  • Fork CI (ubuntu-latest, 2-vCPU GitHub-hosted runners) was previously failing 3/3 with Test timed out in 15000ms on the old fixture.

Related work

Complements #5220 (perf(web): skip base64 for oversized image candidates), which fixes the underlying slowness in the source by skipping base64 for candidates that already exceed the budget.

UI Changes

N/A — test-only change, no UI.


Note

Low Risk
Test-only fixture change; no production or assertion semantics change.

Overview
The "reports too-large when even the smallest encoding overflows the budget" case in imageCompression.test.ts no longer simulates 8 MB encodes on every ladder step. The canvas stub now returns 300 KB blobs, and the test calls compressImageForStash with an explicit 150_000 character budget so every step still overflows and the same too-large + bitmap close behavior is asserted.

This cuts per-run base64 work from ~120 MB to a few MB so the test stays under the default 15s timeout on 2-vCPU GitHub runners without a raised timeout. Production code is unchanged; only the test fixture and optional budget argument differ.

Reviewed by Cursor Bugbot for commit 6849430. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Reduce encoded sizes in compressImageForStash ladder test to avoid timeout on slow runners

The stubbed encoder in the "reports too-large when even the smallest encoding overflows the budget" test previously returned 8,000,000 bytes, causing timeouts on slow CI runners. It now returns 300,000 bytes, and compressImageForStash is called with an explicit 150,000-byte budget, keeping the { ok: false, reason: "too-large" } assertion intact without generating large payloads.

Macroscope summarized 6849430.

@coderabbitai

coderabbitaiBot commented Aug 5, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 5e08a906-53c5-40bd-ae6d-2b460fcb0722

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actionsgithub-actionsBot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Aug 5, 2026
@macroscopeapp

macroscopeappBot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved 19f78dd

Test-only change that reduces stub payload sizes in imageCompression.test.ts to improve test performance on slow runners. No production code is affected.

No code changes detected at 6849430. Prior analysis still applies.

You can customize Macroscope's approvability policy. Learn more.

macroscopeapp[bot]
macroscopeappBot previously approved these changes Aug 5, 2026
@snowykr
snowykrforce-pushed the test-imagecompression-timeout branch from f956df9 to de5988aCompareAugust 6, 2026 10:17

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:de5988ab03

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadapps/web/src/lib/imageCompression.test.ts Outdated
@snowykr
snowykrforce-pushed the test-imagecompression-timeout branch from de5988a to 19f78ddCompareAugust 6, 2026 10:34
@macroscopeapp
macroscopeappBot dismissed their stale reviewAugust 6, 2026 10:34

Dismissing prior approval to re-evaluate 19f78dd

@snowykr
snowykrforce-pushed the test-imagecompression-timeout branch from 19f78dd to 177c50cCompareAugust 6, 2026 14:57
@snowykr
snowykrforce-pushed the test-imagecompression-timeout branch from 177c50c to 6849430CompareAugust 10, 2026 08:19
@t3dotgg

Copy link
Copy Markdown
Member

Note

🤖 GPT-5.6 Sol responding on behalf of Theo

We're closing this PR as we clean up the T3 Code backlog. Thank you for taking the time to put this together.

The current patch shrinks the image-compression fixture and its test budget so the test can use the default timeout. We are not keeping a separate PR open for this isolated test maintenance change.

If you believe we closed this in error, please reopen the PR and leave a comment explaining what we missed.

@t3dotggt3dotgg closed this Aug 28, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS0-9 changed lines (additions + deletions).vouch:unvouchedPR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@snowykr@t3dotgg
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

test(web): raise imageCompression ladder test timeout for slow runners - #5416

Closed
snowykr wants to merge 1 commit into
pingdotgg:mainfrom
snowykr:test-imagecompression-timeout
Closed

test(web): raise imageCompression ladder test timeout for slow runners#5416
snowykr wants to merge 1 commit into
pingdotgg:mainfrom
snowykr:test-imagecompression-timeout

Conversation

@snowykr

@snowykrsnowykr commented Aug 5, 2026

Copy link
Copy Markdown

What Changed

Speed up the imageCompression.test.ts case "reports too-large when even the smallest encoding overflows the budget" so it completes within the default 15s per-test timeout instead of relying on a raised timeout.

Previously the stub returned an 8 MB blob for every ladder step (3 fallback scales × [probe + 4 quality steps] = 15 encodes), materializing and base64-encoding ~120 MB per run — ~41s on 2-vCPU GitHub-hosted runners, failing with Test timed out in 15000ms. The 8-vCPU blacksmith runners used in this repo are fast enough that it stayed under 15s, so the failure only surfaced on slower machines.

Now the stub returns a 300 KB blob and the test passes an explicit small budget (150_000 chars) to compressImageForStash, so every encode still overflows the budget and the give-up path (too-large + bitmap release) runs exactly as before — but the base64 work drops to ~4.5 MB (15 × 300 KB) plus the one-time 9 MB source encode. The 60_000 timeout override is removed.

No production code, stubs, payloads, or assertions change — the test's semantics are untouched.

Why

Test-robustness only: keep the ladder's give-up behavior fully exercised on slow CI runners without paying for multi-megabyte base64 payloads on every quality step (AGENTS.md "Performance without compromise").

Validation

  • Local targeted run: changed test ~0.9s; 12/12 tests in the file pass.
  • vp lint, vp fmt --check, and tsgo --noEmit for apps/web are clean.
  • Fork CI (ubuntu-latest, 2-vCPU GitHub-hosted runners) was previously failing 3/3 with Test timed out in 15000ms on the old fixture.

Related work

Complements #5220 (perf(web): skip base64 for oversized image candidates), which fixes the underlying slowness in the source by skipping base64 for candidates that already exceed the budget.

UI Changes

N/A — test-only change, no UI.


Note

Low Risk
Test-only fixture change; no production or assertion semantics change.

Overview
The "reports too-large when even the smallest encoding overflows the budget" case in imageCompression.test.ts no longer simulates 8 MB encodes on every ladder step. The canvas stub now returns 300 KB blobs, and the test calls compressImageForStash with an explicit 150_000 character budget so every step still overflows and the same too-large + bitmap close behavior is asserted.

This cuts per-run base64 work from ~120 MB to a few MB so the test stays under the default 15s timeout on 2-vCPU GitHub runners without a raised timeout. Production code is unchanged; only the test fixture and optional budget argument differ.

Reviewed by Cursor Bugbot for commit 6849430. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Reduce encoded sizes in compressImageForStash ladder test to avoid timeout on slow runners

The stubbed encoder in the "reports too-large when even the smallest encoding overflows the budget" test previously returned 8,000,000 bytes, causing timeouts on slow CI runners. It now returns 300,000 bytes, and compressImageForStash is called with an explicit 150,000-byte budget, keeping the { ok: false, reason: "too-large" } assertion intact without generating large payloads.

Macroscope summarized 6849430.

@coderabbitai

coderabbitaiBot commented Aug 5, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 5e08a906-53c5-40bd-ae6d-2b460fcb0722

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actionsgithub-actionsBot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Aug 5, 2026
@macroscopeapp

macroscopeappBot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved 19f78dd

Test-only change that reduces stub payload sizes in imageCompression.test.ts to improve test performance on slow runners. No production code is affected.

No code changes detected at 6849430. Prior analysis still applies.

You can customize Macroscope's approvability policy. Learn more.

macroscopeapp[bot]
macroscopeappBot previously approved these changes Aug 5, 2026
@snowykr
snowykrforce-pushed the test-imagecompression-timeout branch from f956df9 to de5988aCompareAugust 6, 2026 10:17

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:de5988ab03

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadapps/web/src/lib/imageCompression.test.ts Outdated
@snowykr
snowykrforce-pushed the test-imagecompression-timeout branch from de5988a to 19f78ddCompareAugust 6, 2026 10:34
@macroscopeapp
macroscopeappBot dismissed their stale reviewAugust 6, 2026 10:34

Dismissing prior approval to re-evaluate 19f78dd

@snowykr
snowykrforce-pushed the test-imagecompression-timeout branch from 19f78dd to 177c50cCompareAugust 6, 2026 14:57
@snowykr
snowykrforce-pushed the test-imagecompression-timeout branch from 177c50c to 6849430CompareAugust 10, 2026 08:19
@t3dotgg

Copy link
Copy Markdown
Member

Note

🤖 GPT-5.6 Sol responding on behalf of Theo

We're closing this PR as we clean up the T3 Code backlog. Thank you for taking the time to put this together.

The current patch shrinks the image-compression fixture and its test budget so the test can use the default timeout. We are not keeping a separate PR open for this isolated test maintenance change.

If you believe we closed this in error, please reopen the PR and leave a comment explaining what we missed.

@t3dotggt3dotgg closed this Aug 28, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS0-9 changed lines (additions + deletions).vouch:unvouchedPR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@snowykr@t3dotgg
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

test(web): raise imageCompression ladder test timeout for slow runners - #5416

Closed
snowykr wants to merge 1 commit into
pingdotgg:mainfrom
snowykr:test-imagecompression-timeout
Closed

test(web): raise imageCompression ladder test timeout for slow runners#5416
snowykr wants to merge 1 commit into
pingdotgg:mainfrom
snowykr:test-imagecompression-timeout

Conversation

@snowykr

@snowykrsnowykr commented Aug 5, 2026

Copy link
Copy Markdown

What Changed

Speed up the imageCompression.test.ts case "reports too-large when even the smallest encoding overflows the budget" so it completes within the default 15s per-test timeout instead of relying on a raised timeout.

Previously the stub returned an 8 MB blob for every ladder step (3 fallback scales × [probe + 4 quality steps] = 15 encodes), materializing and base64-encoding ~120 MB per run — ~41s on 2-vCPU GitHub-hosted runners, failing with Test timed out in 15000ms. The 8-vCPU blacksmith runners used in this repo are fast enough that it stayed under 15s, so the failure only surfaced on slower machines.

Now the stub returns a 300 KB blob and the test passes an explicit small budget (150_000 chars) to compressImageForStash, so every encode still overflows the budget and the give-up path (too-large + bitmap release) runs exactly as before — but the base64 work drops to ~4.5 MB (15 × 300 KB) plus the one-time 9 MB source encode. The 60_000 timeout override is removed.

No production code, stubs, payloads, or assertions change — the test's semantics are untouched.

Why

Test-robustness only: keep the ladder's give-up behavior fully exercised on slow CI runners without paying for multi-megabyte base64 payloads on every quality step (AGENTS.md "Performance without compromise").

Validation

  • Local targeted run: changed test ~0.9s; 12/12 tests in the file pass.
  • vp lint, vp fmt --check, and tsgo --noEmit for apps/web are clean.
  • Fork CI (ubuntu-latest, 2-vCPU GitHub-hosted runners) was previously failing 3/3 with Test timed out in 15000ms on the old fixture.

Related work

Complements #5220 (perf(web): skip base64 for oversized image candidates), which fixes the underlying slowness in the source by skipping base64 for candidates that already exceed the budget.

UI Changes

N/A — test-only change, no UI.


Note

Low Risk
Test-only fixture change; no production or assertion semantics change.

Overview
The "reports too-large when even the smallest encoding overflows the budget" case in imageCompression.test.ts no longer simulates 8 MB encodes on every ladder step. The canvas stub now returns 300 KB blobs, and the test calls compressImageForStash with an explicit 150_000 character budget so every step still overflows and the same too-large + bitmap close behavior is asserted.

This cuts per-run base64 work from ~120 MB to a few MB so the test stays under the default 15s timeout on 2-vCPU GitHub runners without a raised timeout. Production code is unchanged; only the test fixture and optional budget argument differ.

Reviewed by Cursor Bugbot for commit 6849430. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Reduce encoded sizes in compressImageForStash ladder test to avoid timeout on slow runners

The stubbed encoder in the "reports too-large when even the smallest encoding overflows the budget" test previously returned 8,000,000 bytes, causing timeouts on slow CI runners. It now returns 300,000 bytes, and compressImageForStash is called with an explicit 150,000-byte budget, keeping the { ok: false, reason: "too-large" } assertion intact without generating large payloads.

Macroscope summarized 6849430.

@coderabbitai

coderabbitaiBot commented Aug 5, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 5e08a906-53c5-40bd-ae6d-2b460fcb0722

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actionsgithub-actionsBot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Aug 5, 2026
@macroscopeapp

macroscopeappBot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved 19f78dd

Test-only change that reduces stub payload sizes in imageCompression.test.ts to improve test performance on slow runners. No production code is affected.

No code changes detected at 6849430. Prior analysis still applies.

You can customize Macroscope's approvability policy. Learn more.

macroscopeapp[bot]
macroscopeappBot previously approved these changes Aug 5, 2026
@snowykr
snowykrforce-pushed the test-imagecompression-timeout branch from f956df9 to de5988aCompareAugust 6, 2026 10:17

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:de5988ab03

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadapps/web/src/lib/imageCompression.test.ts Outdated
@snowykr
snowykrforce-pushed the test-imagecompression-timeout branch from de5988a to 19f78ddCompareAugust 6, 2026 10:34
@macroscopeapp
macroscopeappBot dismissed their stale reviewAugust 6, 2026 10:34

Dismissing prior approval to re-evaluate 19f78dd

@snowykr
snowykrforce-pushed the test-imagecompression-timeout branch from 19f78dd to 177c50cCompareAugust 6, 2026 14:57
@snowykr
snowykrforce-pushed the test-imagecompression-timeout branch from 177c50c to 6849430CompareAugust 10, 2026 08:19
@t3dotgg

Copy link
Copy Markdown
Member

Note

🤖 GPT-5.6 Sol responding on behalf of Theo

We're closing this PR as we clean up the T3 Code backlog. Thank you for taking the time to put this together.

The current patch shrinks the image-compression fixture and its test budget so the test can use the default timeout. We are not keeping a separate PR open for this isolated test maintenance change.

If you believe we closed this in error, please reopen the PR and leave a comment explaining what we missed.

@t3dotggt3dotgg closed this Aug 28, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS0-9 changed lines (additions + deletions).vouch:unvouchedPR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@snowykr@t3dotgg
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

test(web): raise imageCompression ladder test timeout for slow runners - #5416

Closed
snowykr wants to merge 1 commit into
pingdotgg:mainfrom
snowykr:test-imagecompression-timeout
Closed

test(web): raise imageCompression ladder test timeout for slow runners#5416
snowykr wants to merge 1 commit into
pingdotgg:mainfrom
snowykr:test-imagecompression-timeout

Conversation

@snowykr

@snowykrsnowykr commented Aug 5, 2026

Copy link
Copy Markdown

What Changed

Speed up the imageCompression.test.ts case "reports too-large when even the smallest encoding overflows the budget" so it completes within the default 15s per-test timeout instead of relying on a raised timeout.

Previously the stub returned an 8 MB blob for every ladder step (3 fallback scales × [probe + 4 quality steps] = 15 encodes), materializing and base64-encoding ~120 MB per run — ~41s on 2-vCPU GitHub-hosted runners, failing with Test timed out in 15000ms. The 8-vCPU blacksmith runners used in this repo are fast enough that it stayed under 15s, so the failure only surfaced on slower machines.

Now the stub returns a 300 KB blob and the test passes an explicit small budget (150_000 chars) to compressImageForStash, so every encode still overflows the budget and the give-up path (too-large + bitmap release) runs exactly as before — but the base64 work drops to ~4.5 MB (15 × 300 KB) plus the one-time 9 MB source encode. The 60_000 timeout override is removed.

No production code, stubs, payloads, or assertions change — the test's semantics are untouched.

Why

Test-robustness only: keep the ladder's give-up behavior fully exercised on slow CI runners without paying for multi-megabyte base64 payloads on every quality step (AGENTS.md "Performance without compromise").

Validation

  • Local targeted run: changed test ~0.9s; 12/12 tests in the file pass.
  • vp lint, vp fmt --check, and tsgo --noEmit for apps/web are clean.
  • Fork CI (ubuntu-latest, 2-vCPU GitHub-hosted runners) was previously failing 3/3 with Test timed out in 15000ms on the old fixture.

Related work

Complements #5220 (perf(web): skip base64 for oversized image candidates), which fixes the underlying slowness in the source by skipping base64 for candidates that already exceed the budget.

UI Changes

N/A — test-only change, no UI.


Note

Low Risk
Test-only fixture change; no production or assertion semantics change.

Overview
The "reports too-large when even the smallest encoding overflows the budget" case in imageCompression.test.ts no longer simulates 8 MB encodes on every ladder step. The canvas stub now returns 300 KB blobs, and the test calls compressImageForStash with an explicit 150_000 character budget so every step still overflows and the same too-large + bitmap close behavior is asserted.

This cuts per-run base64 work from ~120 MB to a few MB so the test stays under the default 15s timeout on 2-vCPU GitHub runners without a raised timeout. Production code is unchanged; only the test fixture and optional budget argument differ.

Reviewed by Cursor Bugbot for commit 6849430. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Reduce encoded sizes in compressImageForStash ladder test to avoid timeout on slow runners

The stubbed encoder in the "reports too-large when even the smallest encoding overflows the budget" test previously returned 8,000,000 bytes, causing timeouts on slow CI runners. It now returns 300,000 bytes, and compressImageForStash is called with an explicit 150,000-byte budget, keeping the { ok: false, reason: "too-large" } assertion intact without generating large payloads.

Macroscope summarized 6849430.

@coderabbitai

coderabbitaiBot commented Aug 5, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 5e08a906-53c5-40bd-ae6d-2b460fcb0722

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actionsgithub-actionsBot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Aug 5, 2026
@macroscopeapp

macroscopeappBot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved 19f78dd

Test-only change that reduces stub payload sizes in imageCompression.test.ts to improve test performance on slow runners. No production code is affected.

No code changes detected at 6849430. Prior analysis still applies.

You can customize Macroscope's approvability policy. Learn more.

macroscopeapp[bot]
macroscopeappBot previously approved these changes Aug 5, 2026
@snowykr
snowykrforce-pushed the test-imagecompression-timeout branch from f956df9 to de5988aCompareAugust 6, 2026 10:17

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:de5988ab03

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadapps/web/src/lib/imageCompression.test.ts Outdated
@snowykr
snowykrforce-pushed the test-imagecompression-timeout branch from de5988a to 19f78ddCompareAugust 6, 2026 10:34
@macroscopeapp
macroscopeappBot dismissed their stale reviewAugust 6, 2026 10:34

Dismissing prior approval to re-evaluate 19f78dd

@snowykr
snowykrforce-pushed the test-imagecompression-timeout branch from 19f78dd to 177c50cCompareAugust 6, 2026 14:57
@snowykr
snowykrforce-pushed the test-imagecompression-timeout branch from 177c50c to 6849430CompareAugust 10, 2026 08:19
@t3dotgg

Copy link
Copy Markdown
Member

Note

🤖 GPT-5.6 Sol responding on behalf of Theo

We're closing this PR as we clean up the T3 Code backlog. Thank you for taking the time to put this together.

The current patch shrinks the image-compression fixture and its test budget so the test can use the default timeout. We are not keeping a separate PR open for this isolated test maintenance change.

If you believe we closed this in error, please reopen the PR and leave a comment explaining what we missed.

@t3dotggt3dotgg closed this Aug 28, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS0-9 changed lines (additions + deletions).vouch:unvouchedPR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@snowykr@t3dotgg