fix(server): preserve latest turn after session completion

[sungsoo-han]

Before:

Completed threads briefly lost their latest turn reference, causing Settle to incorrectly report that work was still pending.

After:

Completed threads preserve their latest turn reference when the session becomes ready, allowing them to settle immediately.

---

Note

Low Risk
Single-field fallback in one projection handler with a targeted regression test; no auth or broad API changes.

Overview
Fixes projection_threads.latest_turn_id being cleared when a thread’s session moves to a non-running state (e.g. ready) with no activeTurnId.

On thread.session-set, the threads projector no longer overwrites latestTurnId with a nullish activeTurnId; it keeps the existing value instead. That stops completed threads from briefly losing their last turn reference, which had caused Settle to treat work as still pending.

A projection test now asserts latest_turn_id stays set after the session leaves running and the turn is marked completed.

^{Reviewed by Cursor Bugbot for commit da525fb. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Fix projection_threads.latest_turn_id to preserve value on session completion

In the thread.session-set event handler in ProjectionPipeline.ts, latestTurnId was unconditionally set to event.payload.session.activeTurnId, which could overwrite the stored value with null or undefined when the session ended. It now falls back to existingRow.value.latestTurnId when activeTurnId is absent.

^{Macroscope summarized da525fb.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 1ba82661-7f26-4bea-8289-c356ab3c5fba

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[macroscopeapp]

Approvability

Verdict: Approved 9d15f0d

Straightforward bug fix that adds a nullish coalescing fallback to preserve latestTurnId when activeTurnId is null during session completion. Clear intent, limited scope, includes test coverage.

^{You can customize Macroscope's approvability policy. Learn more.}

[t3dotgg]

Note

🤖 GPT-5.6 Sol responding on behalf of Theo

I am closing this because #5553 has landed in main and preserves the latest turn after session completion. I checked the current implementation and did not find any remaining change from this PR that we still need to merge.

Thank you for putting this together. The closure is only because the work is now covered elsewhere, not because there was a problem with your contribution.

[sungsoo-han]

Before:

Completed threads briefly lost their latest turn reference, causing Settle to incorrectly report that work was still pending.

After:

Completed threads preserve their latest turn reference when the session becomes ready, allowing them to settle immediately.

---

Note

Low Risk
Single-field fallback in one projection handler with a targeted regression test; no auth or broad API changes.

Overview
Fixes projection_threads.latest_turn_id being cleared when a thread’s session moves to a non-running state (e.g. ready) with no activeTurnId.

On thread.session-set, the threads projector no longer overwrites latestTurnId with a nullish activeTurnId; it keeps the existing value instead. That stops completed threads from briefly losing their last turn reference, which had caused Settle to treat work as still pending.

A projection test now asserts latest_turn_id stays set after the session leaves running and the turn is marked completed.

^{Reviewed by Cursor Bugbot for commit da525fb. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Fix projection_threads.latest_turn_id to preserve value on session completion

In the thread.session-set event handler in ProjectionPipeline.ts, latestTurnId was unconditionally set to event.payload.session.activeTurnId, which could overwrite the stored value with null or undefined when the session ended. It now falls back to existingRow.value.latestTurnId when activeTurnId is absent.

^{Macroscope summarized da525fb.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 1ba82661-7f26-4bea-8289-c356ab3c5fba

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[macroscopeapp]

Approvability

Verdict: Approved 9d15f0d

Straightforward bug fix that adds a nullish coalescing fallback to preserve latestTurnId when activeTurnId is null during session completion. Clear intent, limited scope, includes test coverage.

^{You can customize Macroscope's approvability policy. Learn more.}

[t3dotgg]

Note

🤖 GPT-5.6 Sol responding on behalf of Theo

I am closing this because #5553 has landed in main and preserves the latest turn after session completion. I checked the current implementation and did not find any remaining change from this PR that we still need to merge.

Thank you for putting this together. The closure is only because the work is now covered elsewhere, not because there was a problem with your contribution.

[sungsoo-han]

Before:

Completed threads briefly lost their latest turn reference, causing Settle to incorrectly report that work was still pending.

After:

Completed threads preserve their latest turn reference when the session becomes ready, allowing them to settle immediately.

---

Note

Low Risk
Single-field fallback in one projection handler with a targeted regression test; no auth or broad API changes.

Overview
Fixes projection_threads.latest_turn_id being cleared when a thread’s session moves to a non-running state (e.g. ready) with no activeTurnId.

On thread.session-set, the threads projector no longer overwrites latestTurnId with a nullish activeTurnId; it keeps the existing value instead. That stops completed threads from briefly losing their last turn reference, which had caused Settle to treat work as still pending.

A projection test now asserts latest_turn_id stays set after the session leaves running and the turn is marked completed.

^{Reviewed by Cursor Bugbot for commit da525fb. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Fix projection_threads.latest_turn_id to preserve value on session completion

In the thread.session-set event handler in ProjectionPipeline.ts, latestTurnId was unconditionally set to event.payload.session.activeTurnId, which could overwrite the stored value with null or undefined when the session ended. It now falls back to existingRow.value.latestTurnId when activeTurnId is absent.

^{Macroscope summarized da525fb.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 1ba82661-7f26-4bea-8289-c356ab3c5fba

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[macroscopeapp]

Approvability

Verdict: Approved 9d15f0d

Straightforward bug fix that adds a nullish coalescing fallback to preserve latestTurnId when activeTurnId is null during session completion. Clear intent, limited scope, includes test coverage.

^{You can customize Macroscope's approvability policy. Learn more.}

[t3dotgg]

Note

🤖 GPT-5.6 Sol responding on behalf of Theo

I am closing this because #5553 has landed in main and preserves the latest turn after session completion. I checked the current implementation and did not find any remaining change from this PR that we still need to merge.

Thank you for putting this together. The closure is only because the work is now covered elsewhere, not because there was a problem with your contribution.

[sungsoo-han]

Before:

Completed threads briefly lost their latest turn reference, causing Settle to incorrectly report that work was still pending.

After:

Completed threads preserve their latest turn reference when the session becomes ready, allowing them to settle immediately.

---

Note

Low Risk
Single-field fallback in one projection handler with a targeted regression test; no auth or broad API changes.

Overview
Fixes projection_threads.latest_turn_id being cleared when a thread’s session moves to a non-running state (e.g. ready) with no activeTurnId.

On thread.session-set, the threads projector no longer overwrites latestTurnId with a nullish activeTurnId; it keeps the existing value instead. That stops completed threads from briefly losing their last turn reference, which had caused Settle to treat work as still pending.

A projection test now asserts latest_turn_id stays set after the session leaves running and the turn is marked completed.

^{Reviewed by Cursor Bugbot for commit da525fb. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Fix projection_threads.latest_turn_id to preserve value on session completion

In the thread.session-set event handler in ProjectionPipeline.ts, latestTurnId was unconditionally set to event.payload.session.activeTurnId, which could overwrite the stored value with null or undefined when the session ended. It now falls back to existingRow.value.latestTurnId when activeTurnId is absent.

^{Macroscope summarized da525fb.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 1ba82661-7f26-4bea-8289-c356ab3c5fba

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[macroscopeapp]

Approvability

Verdict: Approved 9d15f0d

Straightforward bug fix that adds a nullish coalescing fallback to preserve latestTurnId when activeTurnId is null during session completion. Clear intent, limited scope, includes test coverage.

^{You can customize Macroscope's approvability policy. Learn more.}

[t3dotgg]

Note

🤖 GPT-5.6 Sol responding on behalf of Theo

I am closing this because #5553 has landed in main and preserves the latest turn after session completion. I checked the current implementation and did not find any remaining change from this PR that we still need to merge.

Thank you for putting this together. The closure is only because the work is now covered elsewhere, not because there was a problem with your contribution.

[sungsoo-han]

Before:

Completed threads briefly lost their latest turn reference, causing Settle to incorrectly report that work was still pending.

After:

Completed threads preserve their latest turn reference when the session becomes ready, allowing them to settle immediately.

---

Note

Low Risk
Single-field fallback in one projection handler with a targeted regression test; no auth or broad API changes.

Overview
Fixes projection_threads.latest_turn_id being cleared when a thread’s session moves to a non-running state (e.g. ready) with no activeTurnId.

On thread.session-set, the threads projector no longer overwrites latestTurnId with a nullish activeTurnId; it keeps the existing value instead. That stops completed threads from briefly losing their last turn reference, which had caused Settle to treat work as still pending.

A projection test now asserts latest_turn_id stays set after the session leaves running and the turn is marked completed.

^{Reviewed by Cursor Bugbot for commit da525fb. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Fix projection_threads.latest_turn_id to preserve value on session completion

In the thread.session-set event handler in ProjectionPipeline.ts, latestTurnId was unconditionally set to event.payload.session.activeTurnId, which could overwrite the stored value with null or undefined when the session ended. It now falls back to existingRow.value.latestTurnId when activeTurnId is absent.

^{Macroscope summarized da525fb.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 1ba82661-7f26-4bea-8289-c356ab3c5fba

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[macroscopeapp]

Approvability

Verdict: Approved 9d15f0d

Straightforward bug fix that adds a nullish coalescing fallback to preserve latestTurnId when activeTurnId is null during session completion. Clear intent, limited scope, includes test coverage.

^{You can customize Macroscope's approvability policy. Learn more.}

[t3dotgg]

Note

🤖 GPT-5.6 Sol responding on behalf of Theo

I am closing this because #5553 has landed in main and preserves the latest turn after session completion. I checked the current implementation and did not find any remaining change from this PR that we still need to merge.

Thank you for putting this together. The closure is only because the work is now covered elsewhere, not because there was a problem with your contribution.

[sungsoo-han]

Before:

Completed threads briefly lost their latest turn reference, causing Settle to incorrectly report that work was still pending.

After:

Completed threads preserve their latest turn reference when the session becomes ready, allowing them to settle immediately.

---

Note

Low Risk
Single-field fallback in one projection handler with a targeted regression test; no auth or broad API changes.

Overview
Fixes projection_threads.latest_turn_id being cleared when a thread’s session moves to a non-running state (e.g. ready) with no activeTurnId.

On thread.session-set, the threads projector no longer overwrites latestTurnId with a nullish activeTurnId; it keeps the existing value instead. That stops completed threads from briefly losing their last turn reference, which had caused Settle to treat work as still pending.

A projection test now asserts latest_turn_id stays set after the session leaves running and the turn is marked completed.

^{Reviewed by Cursor Bugbot for commit da525fb. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Fix projection_threads.latest_turn_id to preserve value on session completion

In the thread.session-set event handler in ProjectionPipeline.ts, latestTurnId was unconditionally set to event.payload.session.activeTurnId, which could overwrite the stored value with null or undefined when the session ended. It now falls back to existingRow.value.latestTurnId when activeTurnId is absent.

^{Macroscope summarized da525fb.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 1ba82661-7f26-4bea-8289-c356ab3c5fba

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[macroscopeapp]

Approvability

Verdict: Approved 9d15f0d

Straightforward bug fix that adds a nullish coalescing fallback to preserve latestTurnId when activeTurnId is null during session completion. Clear intent, limited scope, includes test coverage.

^{You can customize Macroscope's approvability policy. Learn more.}

[t3dotgg]

Note

🤖 GPT-5.6 Sol responding on behalf of Theo

I am closing this because #5553 has landed in main and preserves the latest turn after session completion. I checked the current implementation and did not find any remaining change from this PR that we still need to merge.

Thank you for putting this together. The closure is only because the work is now covered elsewhere, not because there was a problem with your contribution.

[sungsoo-han]

Before:

Completed threads briefly lost their latest turn reference, causing Settle to incorrectly report that work was still pending.

After:

Completed threads preserve their latest turn reference when the session becomes ready, allowing them to settle immediately.

---

Note

Low Risk
Single-field fallback in one projection handler with a targeted regression test; no auth or broad API changes.

Overview
Fixes projection_threads.latest_turn_id being cleared when a thread’s session moves to a non-running state (e.g. ready) with no activeTurnId.

On thread.session-set, the threads projector no longer overwrites latestTurnId with a nullish activeTurnId; it keeps the existing value instead. That stops completed threads from briefly losing their last turn reference, which had caused Settle to treat work as still pending.

A projection test now asserts latest_turn_id stays set after the session leaves running and the turn is marked completed.

^{Reviewed by Cursor Bugbot for commit da525fb. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Fix projection_threads.latest_turn_id to preserve value on session completion

In the thread.session-set event handler in ProjectionPipeline.ts, latestTurnId was unconditionally set to event.payload.session.activeTurnId, which could overwrite the stored value with null or undefined when the session ended. It now falls back to existingRow.value.latestTurnId when activeTurnId is absent.

^{Macroscope summarized da525fb.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 1ba82661-7f26-4bea-8289-c356ab3c5fba

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[macroscopeapp]

Approvability

Verdict: Approved 9d15f0d

Straightforward bug fix that adds a nullish coalescing fallback to preserve latestTurnId when activeTurnId is null during session completion. Clear intent, limited scope, includes test coverage.

^{You can customize Macroscope's approvability policy. Learn more.}

[t3dotgg]

Note

🤖 GPT-5.6 Sol responding on behalf of Theo

I am closing this because #5553 has landed in main and preserves the latest turn after session completion. I checked the current implementation and did not find any remaining change from this PR that we still need to merge.

Thank you for putting this together. The closure is only because the work is now covered elsewhere, not because there was a problem with your contribution.

[sungsoo-han]

Before:

Completed threads briefly lost their latest turn reference, causing Settle to incorrectly report that work was still pending.

After:

Completed threads preserve their latest turn reference when the session becomes ready, allowing them to settle immediately.

---

Note

Low Risk
Single-field fallback in one projection handler with a targeted regression test; no auth or broad API changes.

Overview
Fixes projection_threads.latest_turn_id being cleared when a thread’s session moves to a non-running state (e.g. ready) with no activeTurnId.

On thread.session-set, the threads projector no longer overwrites latestTurnId with a nullish activeTurnId; it keeps the existing value instead. That stops completed threads from briefly losing their last turn reference, which had caused Settle to treat work as still pending.

A projection test now asserts latest_turn_id stays set after the session leaves running and the turn is marked completed.

^{Reviewed by Cursor Bugbot for commit da525fb. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Fix projection_threads.latest_turn_id to preserve value on session completion

In the thread.session-set event handler in ProjectionPipeline.ts, latestTurnId was unconditionally set to event.payload.session.activeTurnId, which could overwrite the stored value with null or undefined when the session ended. It now falls back to existingRow.value.latestTurnId when activeTurnId is absent.

^{Macroscope summarized da525fb.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 1ba82661-7f26-4bea-8289-c356ab3c5fba

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[macroscopeapp]

Approvability

Verdict: Approved 9d15f0d

Straightforward bug fix that adds a nullish coalescing fallback to preserve latestTurnId when activeTurnId is null during session completion. Clear intent, limited scope, includes test coverage.

^{You can customize Macroscope's approvability policy. Learn more.}

[t3dotgg]

Note

🤖 GPT-5.6 Sol responding on behalf of Theo

I am closing this because #5553 has landed in main and preserves the latest turn after session completion. I checked the current implementation and did not find any remaining change from this PR that we still need to merge.

Thank you for putting this together. The closure is only because the work is now covered elsewhere, not because there was a problem with your contribution.