fix(mobile): parse pasted pairing links

[DominicVonk]

Mobile treated the Host and Pairing Code fields independently, so pasting a complete pairing URL could leave the token embedded in the host field. Schemeless local URLs also behaved differently from desktop.

This change gives mobile the same paste behavior as desktop:

• parses full pairing URLs from the Host field;
• extracts tokens from URL fragments and query strings;
• supports hosted pairing links;
• accepts schemeless hostnames and local IPv4 addresses;
• defaults schemeless IP literals to HTTP and hostnames to HTTPS;
• preserves separately entered host/code values;
• keeps QR and deep-link payload handling on the same parser path.

Related independent PRs

These PRs all target main and can be merged in any order:

• fix(connection): refresh network status after app activation #5597 — network status recovery
• feat(connections): manage environment availability #5598 — environment availability and management
• fix(mobile): parse pasted pairing links #5596 — mobile pairing-link paste

Verification

• vp test run apps/mobile/src/features/connection/pairing.test.ts
  • 1 file passed
  • 11 tests passed
• vp run --filter @t3tools/mobile typecheck
  • passed
• targeted vp lint for the three changed files
  • passed
• fallow audit --base upstream/main
  • passed the new-change gate; inherited repository findings were excluded

No screenshot is included because this PR changes how pasted text is parsed without changing the rendered form.

Built and reviewed with GPT-5 Codex via Codex CLI.

Fork validation PR

• DominicVonk/t3code#9

---

Note

Low Risk
Connection-form parsing and URL normalization only; behavior is covered by unit tests with no auth or data-model changes.

Overview
Aligns mobile Add Environment pairing input with desktop by parsing full pairing URLs pasted into the Host field instead of treating host and code independently.

pairing.ts adds normalizePairingUrlInput (schemeless IPs → HTTP, hostnames → HTTPS, // → HTTPS) and parsePairingFields, which splits a pasted URL’s token from the host when present. buildPairingUrl and parsePairingUrl use that normalization for direct, schemeless, protocol-relative, and hosted pairing links.

ConnectionsNewRouteScreen runs field normalization on host blur and before connect so submit builds the URL from cleaned host/code values.

Tests in pairing.test.ts cover the new parsing and URL-building cases.

^{Reviewed by Cursor Bugbot for commit 9bdff53. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Fix pairing link parsing to extract embedded tokens from the host field on mobile

• Adds parsePairingFields in pairing.ts to detect when a full pairing URL is pasted into the host field and extract the token into the code field.
• Adds normalizePairingUrlInput to infer schemes for schemeless and protocol-relative inputs (HTTPS for hostnames, HTTP for IPs).
• Updates parsePairingUrl and buildPairingUrl to use the new normalization, so protocol-relative and schemeless hosts are handled correctly.
• In ConnectionsNewRouteScreen, calls parsePairingFields on blur and at submit so the host and code fields are normalized before the pairing URL is built.

^{Macroscope summarized 9bdff53.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: bd0515a6-0fce-4962-9757-a61b0ea1e69c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[macroscopeapp]

Effect service conventions review: one finding. The new ConnectionActivationStore implementations map their failures onto unrelated ConnectionPersistenceError operation labels (register-connection for activation writes, list-targets for listDisabled), so the structured operation context no longer identifies the failing operation. Everything else in the diff (namespace imports, Context.Service tag placement in platform/persistence.ts, the new setEnabled registry operation and atom command, and the test-only service instances in the harnesses) follows the conventions.

^{Posted via Macroscope — Effect Service Conventions}

[macroscopeapp]

One convention issue found: in apps/mobile/src/connection/storage.ts the new activation-specific ConnectionPersistenceError operation literals are swapped with the existing target/registration ones, so the structured operation attribute no longer identifies the operation that actually failed. The web store (apps/web/src/connection/storage.ts) maps these correctly and can be used as the reference.

^{Posted via Macroscope — Effect Service Conventions}

[macroscopeapp]

One convention finding on the new shared connectivity helper. Everything else (activation store definition, platform implementations, error operation literals, new registry command) follows the service conventions.

^{Posted via Macroscope — Effect Service Conventions}

[macroscopeapp]

Approvability

Verdict: Approved 055f151

Small, self-contained bug fix adding URL parsing for pasted pairing links on mobile. Changes include helper functions and comprehensive unit tests. The open review comments reference either unrelated files or scenarios covered by tests.

^{You can customize Macroscope's approvability policy. Learn more.}

[macroscopeapp]

One convention finding: the new failure handling in packages/client-runtime/src/connection/onboarding.ts uses Effect.catchTag instead of Effect.catchTags. Everything else in scope looks consistent with the Effect service conventions — notably followNetworkStatus now acquires Connectivity/ConnectionWakeups from the environment, and the activation operation literals added to ConnectionPersistenceError are used accurately in both the web and mobile stores.

^{Posted via Macroscope — Effect Service Conventions}

[cursor]

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

There are 4 total unresolved issues (including 3 from previous reviews).

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 59e70a4. Configure here.}

Dismissing prior approval to re-evaluate 055f151

[DominicVonk]

Mobile treated the Host and Pairing Code fields independently, so pasting a complete pairing URL could leave the token embedded in the host field. Schemeless local URLs also behaved differently from desktop.

This change gives mobile the same paste behavior as desktop:

• parses full pairing URLs from the Host field;
• extracts tokens from URL fragments and query strings;
• supports hosted pairing links;
• accepts schemeless hostnames and local IPv4 addresses;
• defaults schemeless IP literals to HTTP and hostnames to HTTPS;
• preserves separately entered host/code values;
• keeps QR and deep-link payload handling on the same parser path.

Related independent PRs

These PRs all target main and can be merged in any order:

• fix(connection): refresh network status after app activation #5597 — network status recovery
• feat(connections): manage environment availability #5598 — environment availability and management
• fix(mobile): parse pasted pairing links #5596 — mobile pairing-link paste

Verification

• vp test run apps/mobile/src/features/connection/pairing.test.ts
  • 1 file passed
  • 11 tests passed
• vp run --filter @t3tools/mobile typecheck
  • passed
• targeted vp lint for the three changed files
  • passed
• fallow audit --base upstream/main
  • passed the new-change gate; inherited repository findings were excluded

No screenshot is included because this PR changes how pasted text is parsed without changing the rendered form.

Built and reviewed with GPT-5 Codex via Codex CLI.

Fork validation PR

• DominicVonk/t3code#9

---

Note

Low Risk
Connection-form parsing and URL normalization only; behavior is covered by unit tests with no auth or data-model changes.

Overview
Aligns mobile Add Environment pairing input with desktop by parsing full pairing URLs pasted into the Host field instead of treating host and code independently.

pairing.ts adds normalizePairingUrlInput (schemeless IPs → HTTP, hostnames → HTTPS, // → HTTPS) and parsePairingFields, which splits a pasted URL’s token from the host when present. buildPairingUrl and parsePairingUrl use that normalization for direct, schemeless, protocol-relative, and hosted pairing links.

ConnectionsNewRouteScreen runs field normalization on host blur and before connect so submit builds the URL from cleaned host/code values.

Tests in pairing.test.ts cover the new parsing and URL-building cases.

^{Reviewed by Cursor Bugbot for commit 9bdff53. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Fix pairing link parsing to extract embedded tokens from the host field on mobile

• Adds parsePairingFields in pairing.ts to detect when a full pairing URL is pasted into the host field and extract the token into the code field.
• Adds normalizePairingUrlInput to infer schemes for schemeless and protocol-relative inputs (HTTPS for hostnames, HTTP for IPs).
• Updates parsePairingUrl and buildPairingUrl to use the new normalization, so protocol-relative and schemeless hosts are handled correctly.
• In ConnectionsNewRouteScreen, calls parsePairingFields on blur and at submit so the host and code fields are normalized before the pairing URL is built.

^{Macroscope summarized 9bdff53.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: bd0515a6-0fce-4962-9757-a61b0ea1e69c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[macroscopeapp]

Effect service conventions review: one finding. The new ConnectionActivationStore implementations map their failures onto unrelated ConnectionPersistenceError operation labels (register-connection for activation writes, list-targets for listDisabled), so the structured operation context no longer identifies the failing operation. Everything else in the diff (namespace imports, Context.Service tag placement in platform/persistence.ts, the new setEnabled registry operation and atom command, and the test-only service instances in the harnesses) follows the conventions.

^{Posted via Macroscope — Effect Service Conventions}

[macroscopeapp]

One convention issue found: in apps/mobile/src/connection/storage.ts the new activation-specific ConnectionPersistenceError operation literals are swapped with the existing target/registration ones, so the structured operation attribute no longer identifies the operation that actually failed. The web store (apps/web/src/connection/storage.ts) maps these correctly and can be used as the reference.

^{Posted via Macroscope — Effect Service Conventions}

[macroscopeapp]

One convention finding on the new shared connectivity helper. Everything else (activation store definition, platform implementations, error operation literals, new registry command) follows the service conventions.

^{Posted via Macroscope — Effect Service Conventions}

[macroscopeapp]

Approvability

Verdict: Approved 055f151

Small, self-contained bug fix adding URL parsing for pasted pairing links on mobile. Changes include helper functions and comprehensive unit tests. The open review comments reference either unrelated files or scenarios covered by tests.

^{You can customize Macroscope's approvability policy. Learn more.}

[macroscopeapp]

One convention finding: the new failure handling in packages/client-runtime/src/connection/onboarding.ts uses Effect.catchTag instead of Effect.catchTags. Everything else in scope looks consistent with the Effect service conventions — notably followNetworkStatus now acquires Connectivity/ConnectionWakeups from the environment, and the activation operation literals added to ConnectionPersistenceError are used accurately in both the web and mobile stores.

^{Posted via Macroscope — Effect Service Conventions}

[cursor]

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

There are 4 total unresolved issues (including 3 from previous reviews).

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 59e70a4. Configure here.}

Dismissing prior approval to re-evaluate 055f151

[DominicVonk]

Mobile treated the Host and Pairing Code fields independently, so pasting a complete pairing URL could leave the token embedded in the host field. Schemeless local URLs also behaved differently from desktop.

This change gives mobile the same paste behavior as desktop:

• parses full pairing URLs from the Host field;
• extracts tokens from URL fragments and query strings;
• supports hosted pairing links;
• accepts schemeless hostnames and local IPv4 addresses;
• defaults schemeless IP literals to HTTP and hostnames to HTTPS;
• preserves separately entered host/code values;
• keeps QR and deep-link payload handling on the same parser path.

Related independent PRs

These PRs all target main and can be merged in any order:

• fix(connection): refresh network status after app activation #5597 — network status recovery
• feat(connections): manage environment availability #5598 — environment availability and management
• fix(mobile): parse pasted pairing links #5596 — mobile pairing-link paste

Verification

• vp test run apps/mobile/src/features/connection/pairing.test.ts
  • 1 file passed
  • 11 tests passed
• vp run --filter @t3tools/mobile typecheck
  • passed
• targeted vp lint for the three changed files
  • passed
• fallow audit --base upstream/main
  • passed the new-change gate; inherited repository findings were excluded

No screenshot is included because this PR changes how pasted text is parsed without changing the rendered form.

Built and reviewed with GPT-5 Codex via Codex CLI.

Fork validation PR

• DominicVonk/t3code#9

---

Note

Low Risk
Connection-form parsing and URL normalization only; behavior is covered by unit tests with no auth or data-model changes.

Overview
Aligns mobile Add Environment pairing input with desktop by parsing full pairing URLs pasted into the Host field instead of treating host and code independently.

pairing.ts adds normalizePairingUrlInput (schemeless IPs → HTTP, hostnames → HTTPS, // → HTTPS) and parsePairingFields, which splits a pasted URL’s token from the host when present. buildPairingUrl and parsePairingUrl use that normalization for direct, schemeless, protocol-relative, and hosted pairing links.

ConnectionsNewRouteScreen runs field normalization on host blur and before connect so submit builds the URL from cleaned host/code values.

Tests in pairing.test.ts cover the new parsing and URL-building cases.

^{Reviewed by Cursor Bugbot for commit 9bdff53. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Fix pairing link parsing to extract embedded tokens from the host field on mobile

• Adds parsePairingFields in pairing.ts to detect when a full pairing URL is pasted into the host field and extract the token into the code field.
• Adds normalizePairingUrlInput to infer schemes for schemeless and protocol-relative inputs (HTTPS for hostnames, HTTP for IPs).
• Updates parsePairingUrl and buildPairingUrl to use the new normalization, so protocol-relative and schemeless hosts are handled correctly.
• In ConnectionsNewRouteScreen, calls parsePairingFields on blur and at submit so the host and code fields are normalized before the pairing URL is built.

^{Macroscope summarized 9bdff53.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: bd0515a6-0fce-4962-9757-a61b0ea1e69c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[macroscopeapp]

Effect service conventions review: one finding. The new ConnectionActivationStore implementations map their failures onto unrelated ConnectionPersistenceError operation labels (register-connection for activation writes, list-targets for listDisabled), so the structured operation context no longer identifies the failing operation. Everything else in the diff (namespace imports, Context.Service tag placement in platform/persistence.ts, the new setEnabled registry operation and atom command, and the test-only service instances in the harnesses) follows the conventions.

^{Posted via Macroscope — Effect Service Conventions}

[macroscopeapp]

One convention issue found: in apps/mobile/src/connection/storage.ts the new activation-specific ConnectionPersistenceError operation literals are swapped with the existing target/registration ones, so the structured operation attribute no longer identifies the operation that actually failed. The web store (apps/web/src/connection/storage.ts) maps these correctly and can be used as the reference.

^{Posted via Macroscope — Effect Service Conventions}

[macroscopeapp]

One convention finding on the new shared connectivity helper. Everything else (activation store definition, platform implementations, error operation literals, new registry command) follows the service conventions.

^{Posted via Macroscope — Effect Service Conventions}

[macroscopeapp]

Approvability

Verdict: Approved 055f151

Small, self-contained bug fix adding URL parsing for pasted pairing links on mobile. Changes include helper functions and comprehensive unit tests. The open review comments reference either unrelated files or scenarios covered by tests.

^{You can customize Macroscope's approvability policy. Learn more.}

[macroscopeapp]

One convention finding: the new failure handling in packages/client-runtime/src/connection/onboarding.ts uses Effect.catchTag instead of Effect.catchTags. Everything else in scope looks consistent with the Effect service conventions — notably followNetworkStatus now acquires Connectivity/ConnectionWakeups from the environment, and the activation operation literals added to ConnectionPersistenceError are used accurately in both the web and mobile stores.

^{Posted via Macroscope — Effect Service Conventions}

[cursor]

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

There are 4 total unresolved issues (including 3 from previous reviews).

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 59e70a4. Configure here.}

Dismissing prior approval to re-evaluate 055f151

[DominicVonk]

Mobile treated the Host and Pairing Code fields independently, so pasting a complete pairing URL could leave the token embedded in the host field. Schemeless local URLs also behaved differently from desktop.

This change gives mobile the same paste behavior as desktop:

• parses full pairing URLs from the Host field;
• extracts tokens from URL fragments and query strings;
• supports hosted pairing links;
• accepts schemeless hostnames and local IPv4 addresses;
• defaults schemeless IP literals to HTTP and hostnames to HTTPS;
• preserves separately entered host/code values;
• keeps QR and deep-link payload handling on the same parser path.

Related independent PRs

These PRs all target main and can be merged in any order:

• fix(connection): refresh network status after app activation #5597 — network status recovery
• feat(connections): manage environment availability #5598 — environment availability and management
• fix(mobile): parse pasted pairing links #5596 — mobile pairing-link paste

Verification

• vp test run apps/mobile/src/features/connection/pairing.test.ts
  • 1 file passed
  • 11 tests passed
• vp run --filter @t3tools/mobile typecheck
  • passed
• targeted vp lint for the three changed files
  • passed
• fallow audit --base upstream/main
  • passed the new-change gate; inherited repository findings were excluded

No screenshot is included because this PR changes how pasted text is parsed without changing the rendered form.

Built and reviewed with GPT-5 Codex via Codex CLI.

Fork validation PR

• DominicVonk/t3code#9

---

Note

Low Risk
Connection-form parsing and URL normalization only; behavior is covered by unit tests with no auth or data-model changes.

Overview
Aligns mobile Add Environment pairing input with desktop by parsing full pairing URLs pasted into the Host field instead of treating host and code independently.

pairing.ts adds normalizePairingUrlInput (schemeless IPs → HTTP, hostnames → HTTPS, // → HTTPS) and parsePairingFields, which splits a pasted URL’s token from the host when present. buildPairingUrl and parsePairingUrl use that normalization for direct, schemeless, protocol-relative, and hosted pairing links.

ConnectionsNewRouteScreen runs field normalization on host blur and before connect so submit builds the URL from cleaned host/code values.

Tests in pairing.test.ts cover the new parsing and URL-building cases.

^{Reviewed by Cursor Bugbot for commit 9bdff53. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Fix pairing link parsing to extract embedded tokens from the host field on mobile

• Adds parsePairingFields in pairing.ts to detect when a full pairing URL is pasted into the host field and extract the token into the code field.
• Adds normalizePairingUrlInput to infer schemes for schemeless and protocol-relative inputs (HTTPS for hostnames, HTTP for IPs).
• Updates parsePairingUrl and buildPairingUrl to use the new normalization, so protocol-relative and schemeless hosts are handled correctly.
• In ConnectionsNewRouteScreen, calls parsePairingFields on blur and at submit so the host and code fields are normalized before the pairing URL is built.

^{Macroscope summarized 9bdff53.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: bd0515a6-0fce-4962-9757-a61b0ea1e69c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[macroscopeapp]

Effect service conventions review: one finding. The new ConnectionActivationStore implementations map their failures onto unrelated ConnectionPersistenceError operation labels (register-connection for activation writes, list-targets for listDisabled), so the structured operation context no longer identifies the failing operation. Everything else in the diff (namespace imports, Context.Service tag placement in platform/persistence.ts, the new setEnabled registry operation and atom command, and the test-only service instances in the harnesses) follows the conventions.

^{Posted via Macroscope — Effect Service Conventions}

[macroscopeapp]

One convention issue found: in apps/mobile/src/connection/storage.ts the new activation-specific ConnectionPersistenceError operation literals are swapped with the existing target/registration ones, so the structured operation attribute no longer identifies the operation that actually failed. The web store (apps/web/src/connection/storage.ts) maps these correctly and can be used as the reference.

^{Posted via Macroscope — Effect Service Conventions}

[macroscopeapp]

One convention finding on the new shared connectivity helper. Everything else (activation store definition, platform implementations, error operation literals, new registry command) follows the service conventions.

^{Posted via Macroscope — Effect Service Conventions}

[macroscopeapp]

Approvability

Verdict: Approved 055f151

Small, self-contained bug fix adding URL parsing for pasted pairing links on mobile. Changes include helper functions and comprehensive unit tests. The open review comments reference either unrelated files or scenarios covered by tests.

^{You can customize Macroscope's approvability policy. Learn more.}

[macroscopeapp]

One convention finding: the new failure handling in packages/client-runtime/src/connection/onboarding.ts uses Effect.catchTag instead of Effect.catchTags. Everything else in scope looks consistent with the Effect service conventions — notably followNetworkStatus now acquires Connectivity/ConnectionWakeups from the environment, and the activation operation literals added to ConnectionPersistenceError are used accurately in both the web and mobile stores.

^{Posted via Macroscope — Effect Service Conventions}

[cursor]

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

There are 4 total unresolved issues (including 3 from previous reviews).

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 59e70a4. Configure here.}

Dismissing prior approval to re-evaluate 055f151

[DominicVonk]

Mobile treated the Host and Pairing Code fields independently, so pasting a complete pairing URL could leave the token embedded in the host field. Schemeless local URLs also behaved differently from desktop.

This change gives mobile the same paste behavior as desktop:

• parses full pairing URLs from the Host field;
• extracts tokens from URL fragments and query strings;
• supports hosted pairing links;
• accepts schemeless hostnames and local IPv4 addresses;
• defaults schemeless IP literals to HTTP and hostnames to HTTPS;
• preserves separately entered host/code values;
• keeps QR and deep-link payload handling on the same parser path.

Related independent PRs

These PRs all target main and can be merged in any order:

• fix(connection): refresh network status after app activation #5597 — network status recovery
• feat(connections): manage environment availability #5598 — environment availability and management
• fix(mobile): parse pasted pairing links #5596 — mobile pairing-link paste

Verification

• vp test run apps/mobile/src/features/connection/pairing.test.ts
  • 1 file passed
  • 11 tests passed
• vp run --filter @t3tools/mobile typecheck
  • passed
• targeted vp lint for the three changed files
  • passed
• fallow audit --base upstream/main
  • passed the new-change gate; inherited repository findings were excluded

No screenshot is included because this PR changes how pasted text is parsed without changing the rendered form.

Built and reviewed with GPT-5 Codex via Codex CLI.

Fork validation PR

• DominicVonk/t3code#9

---

Note

Low Risk
Connection-form parsing and URL normalization only; behavior is covered by unit tests with no auth or data-model changes.

Overview
Aligns mobile Add Environment pairing input with desktop by parsing full pairing URLs pasted into the Host field instead of treating host and code independently.

pairing.ts adds normalizePairingUrlInput (schemeless IPs → HTTP, hostnames → HTTPS, // → HTTPS) and parsePairingFields, which splits a pasted URL’s token from the host when present. buildPairingUrl and parsePairingUrl use that normalization for direct, schemeless, protocol-relative, and hosted pairing links.

ConnectionsNewRouteScreen runs field normalization on host blur and before connect so submit builds the URL from cleaned host/code values.

Tests in pairing.test.ts cover the new parsing and URL-building cases.

^{Reviewed by Cursor Bugbot for commit 9bdff53. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Fix pairing link parsing to extract embedded tokens from the host field on mobile

• Adds parsePairingFields in pairing.ts to detect when a full pairing URL is pasted into the host field and extract the token into the code field.
• Adds normalizePairingUrlInput to infer schemes for schemeless and protocol-relative inputs (HTTPS for hostnames, HTTP for IPs).
• Updates parsePairingUrl and buildPairingUrl to use the new normalization, so protocol-relative and schemeless hosts are handled correctly.
• In ConnectionsNewRouteScreen, calls parsePairingFields on blur and at submit so the host and code fields are normalized before the pairing URL is built.

^{Macroscope summarized 9bdff53.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: bd0515a6-0fce-4962-9757-a61b0ea1e69c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[macroscopeapp]

Effect service conventions review: one finding. The new ConnectionActivationStore implementations map their failures onto unrelated ConnectionPersistenceError operation labels (register-connection for activation writes, list-targets for listDisabled), so the structured operation context no longer identifies the failing operation. Everything else in the diff (namespace imports, Context.Service tag placement in platform/persistence.ts, the new setEnabled registry operation and atom command, and the test-only service instances in the harnesses) follows the conventions.

^{Posted via Macroscope — Effect Service Conventions}

[macroscopeapp]

One convention issue found: in apps/mobile/src/connection/storage.ts the new activation-specific ConnectionPersistenceError operation literals are swapped with the existing target/registration ones, so the structured operation attribute no longer identifies the operation that actually failed. The web store (apps/web/src/connection/storage.ts) maps these correctly and can be used as the reference.

^{Posted via Macroscope — Effect Service Conventions}

[macroscopeapp]

One convention finding on the new shared connectivity helper. Everything else (activation store definition, platform implementations, error operation literals, new registry command) follows the service conventions.

^{Posted via Macroscope — Effect Service Conventions}

[macroscopeapp]

Approvability

Verdict: Approved 055f151

Small, self-contained bug fix adding URL parsing for pasted pairing links on mobile. Changes include helper functions and comprehensive unit tests. The open review comments reference either unrelated files or scenarios covered by tests.

^{You can customize Macroscope's approvability policy. Learn more.}

[macroscopeapp]

One convention finding: the new failure handling in packages/client-runtime/src/connection/onboarding.ts uses Effect.catchTag instead of Effect.catchTags. Everything else in scope looks consistent with the Effect service conventions — notably followNetworkStatus now acquires Connectivity/ConnectionWakeups from the environment, and the activation operation literals added to ConnectionPersistenceError are used accurately in both the web and mobile stores.

^{Posted via Macroscope — Effect Service Conventions}

[cursor]

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

There are 4 total unresolved issues (including 3 from previous reviews).

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 59e70a4. Configure here.}

Dismissing prior approval to re-evaluate 055f151

[DominicVonk]

Mobile treated the Host and Pairing Code fields independently, so pasting a complete pairing URL could leave the token embedded in the host field. Schemeless local URLs also behaved differently from desktop.

This change gives mobile the same paste behavior as desktop:

• parses full pairing URLs from the Host field;
• extracts tokens from URL fragments and query strings;
• supports hosted pairing links;
• accepts schemeless hostnames and local IPv4 addresses;
• defaults schemeless IP literals to HTTP and hostnames to HTTPS;
• preserves separately entered host/code values;
• keeps QR and deep-link payload handling on the same parser path.

Related independent PRs

These PRs all target main and can be merged in any order:

• fix(connection): refresh network status after app activation #5597 — network status recovery
• feat(connections): manage environment availability #5598 — environment availability and management
• fix(mobile): parse pasted pairing links #5596 — mobile pairing-link paste

Verification

• vp test run apps/mobile/src/features/connection/pairing.test.ts
  • 1 file passed
  • 11 tests passed
• vp run --filter @t3tools/mobile typecheck
  • passed
• targeted vp lint for the three changed files
  • passed
• fallow audit --base upstream/main
  • passed the new-change gate; inherited repository findings were excluded

No screenshot is included because this PR changes how pasted text is parsed without changing the rendered form.

Built and reviewed with GPT-5 Codex via Codex CLI.

Fork validation PR

• DominicVonk/t3code#9

---

Note

Low Risk
Connection-form parsing and URL normalization only; behavior is covered by unit tests with no auth or data-model changes.

Overview
Aligns mobile Add Environment pairing input with desktop by parsing full pairing URLs pasted into the Host field instead of treating host and code independently.

pairing.ts adds normalizePairingUrlInput (schemeless IPs → HTTP, hostnames → HTTPS, // → HTTPS) and parsePairingFields, which splits a pasted URL’s token from the host when present. buildPairingUrl and parsePairingUrl use that normalization for direct, schemeless, protocol-relative, and hosted pairing links.

ConnectionsNewRouteScreen runs field normalization on host blur and before connect so submit builds the URL from cleaned host/code values.

Tests in pairing.test.ts cover the new parsing and URL-building cases.

^{Reviewed by Cursor Bugbot for commit 9bdff53. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Fix pairing link parsing to extract embedded tokens from the host field on mobile

• Adds parsePairingFields in pairing.ts to detect when a full pairing URL is pasted into the host field and extract the token into the code field.
• Adds normalizePairingUrlInput to infer schemes for schemeless and protocol-relative inputs (HTTPS for hostnames, HTTP for IPs).
• Updates parsePairingUrl and buildPairingUrl to use the new normalization, so protocol-relative and schemeless hosts are handled correctly.
• In ConnectionsNewRouteScreen, calls parsePairingFields on blur and at submit so the host and code fields are normalized before the pairing URL is built.

^{Macroscope summarized 9bdff53.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: bd0515a6-0fce-4962-9757-a61b0ea1e69c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[macroscopeapp]

Effect service conventions review: one finding. The new ConnectionActivationStore implementations map their failures onto unrelated ConnectionPersistenceError operation labels (register-connection for activation writes, list-targets for listDisabled), so the structured operation context no longer identifies the failing operation. Everything else in the diff (namespace imports, Context.Service tag placement in platform/persistence.ts, the new setEnabled registry operation and atom command, and the test-only service instances in the harnesses) follows the conventions.

^{Posted via Macroscope — Effect Service Conventions}

[macroscopeapp]

One convention issue found: in apps/mobile/src/connection/storage.ts the new activation-specific ConnectionPersistenceError operation literals are swapped with the existing target/registration ones, so the structured operation attribute no longer identifies the operation that actually failed. The web store (apps/web/src/connection/storage.ts) maps these correctly and can be used as the reference.

^{Posted via Macroscope — Effect Service Conventions}

[macroscopeapp]

One convention finding on the new shared connectivity helper. Everything else (activation store definition, platform implementations, error operation literals, new registry command) follows the service conventions.

^{Posted via Macroscope — Effect Service Conventions}

[macroscopeapp]

Approvability

Verdict: Approved 055f151

Small, self-contained bug fix adding URL parsing for pasted pairing links on mobile. Changes include helper functions and comprehensive unit tests. The open review comments reference either unrelated files or scenarios covered by tests.

^{You can customize Macroscope's approvability policy. Learn more.}

[macroscopeapp]

One convention finding: the new failure handling in packages/client-runtime/src/connection/onboarding.ts uses Effect.catchTag instead of Effect.catchTags. Everything else in scope looks consistent with the Effect service conventions — notably followNetworkStatus now acquires Connectivity/ConnectionWakeups from the environment, and the activation operation literals added to ConnectionPersistenceError are used accurately in both the web and mobile stores.

^{Posted via Macroscope — Effect Service Conventions}

[cursor]

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

There are 4 total unresolved issues (including 3 from previous reviews).

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 59e70a4. Configure here.}

Dismissing prior approval to re-evaluate 055f151

[DominicVonk]

Mobile treated the Host and Pairing Code fields independently, so pasting a complete pairing URL could leave the token embedded in the host field. Schemeless local URLs also behaved differently from desktop.

This change gives mobile the same paste behavior as desktop:

• parses full pairing URLs from the Host field;
• extracts tokens from URL fragments and query strings;
• supports hosted pairing links;
• accepts schemeless hostnames and local IPv4 addresses;
• defaults schemeless IP literals to HTTP and hostnames to HTTPS;
• preserves separately entered host/code values;
• keeps QR and deep-link payload handling on the same parser path.

Related independent PRs

These PRs all target main and can be merged in any order:

• fix(connection): refresh network status after app activation #5597 — network status recovery
• feat(connections): manage environment availability #5598 — environment availability and management
• fix(mobile): parse pasted pairing links #5596 — mobile pairing-link paste

Verification

• vp test run apps/mobile/src/features/connection/pairing.test.ts
  • 1 file passed
  • 11 tests passed
• vp run --filter @t3tools/mobile typecheck
  • passed
• targeted vp lint for the three changed files
  • passed
• fallow audit --base upstream/main
  • passed the new-change gate; inherited repository findings were excluded

No screenshot is included because this PR changes how pasted text is parsed without changing the rendered form.

Built and reviewed with GPT-5 Codex via Codex CLI.

Fork validation PR

• DominicVonk/t3code#9

---

Note

Low Risk
Connection-form parsing and URL normalization only; behavior is covered by unit tests with no auth or data-model changes.

Overview
Aligns mobile Add Environment pairing input with desktop by parsing full pairing URLs pasted into the Host field instead of treating host and code independently.

pairing.ts adds normalizePairingUrlInput (schemeless IPs → HTTP, hostnames → HTTPS, // → HTTPS) and parsePairingFields, which splits a pasted URL’s token from the host when present. buildPairingUrl and parsePairingUrl use that normalization for direct, schemeless, protocol-relative, and hosted pairing links.

ConnectionsNewRouteScreen runs field normalization on host blur and before connect so submit builds the URL from cleaned host/code values.

Tests in pairing.test.ts cover the new parsing and URL-building cases.

^{Reviewed by Cursor Bugbot for commit 9bdff53. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Fix pairing link parsing to extract embedded tokens from the host field on mobile

• Adds parsePairingFields in pairing.ts to detect when a full pairing URL is pasted into the host field and extract the token into the code field.
• Adds normalizePairingUrlInput to infer schemes for schemeless and protocol-relative inputs (HTTPS for hostnames, HTTP for IPs).
• Updates parsePairingUrl and buildPairingUrl to use the new normalization, so protocol-relative and schemeless hosts are handled correctly.
• In ConnectionsNewRouteScreen, calls parsePairingFields on blur and at submit so the host and code fields are normalized before the pairing URL is built.

^{Macroscope summarized 9bdff53.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: bd0515a6-0fce-4962-9757-a61b0ea1e69c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[macroscopeapp]

Effect service conventions review: one finding. The new ConnectionActivationStore implementations map their failures onto unrelated ConnectionPersistenceError operation labels (register-connection for activation writes, list-targets for listDisabled), so the structured operation context no longer identifies the failing operation. Everything else in the diff (namespace imports, Context.Service tag placement in platform/persistence.ts, the new setEnabled registry operation and atom command, and the test-only service instances in the harnesses) follows the conventions.

^{Posted via Macroscope — Effect Service Conventions}

[macroscopeapp]

One convention issue found: in apps/mobile/src/connection/storage.ts the new activation-specific ConnectionPersistenceError operation literals are swapped with the existing target/registration ones, so the structured operation attribute no longer identifies the operation that actually failed. The web store (apps/web/src/connection/storage.ts) maps these correctly and can be used as the reference.

^{Posted via Macroscope — Effect Service Conventions}

[macroscopeapp]

One convention finding on the new shared connectivity helper. Everything else (activation store definition, platform implementations, error operation literals, new registry command) follows the service conventions.

^{Posted via Macroscope — Effect Service Conventions}

[macroscopeapp]

Approvability

Verdict: Approved 055f151

Small, self-contained bug fix adding URL parsing for pasted pairing links on mobile. Changes include helper functions and comprehensive unit tests. The open review comments reference either unrelated files or scenarios covered by tests.

^{You can customize Macroscope's approvability policy. Learn more.}

[macroscopeapp]

One convention finding: the new failure handling in packages/client-runtime/src/connection/onboarding.ts uses Effect.catchTag instead of Effect.catchTags. Everything else in scope looks consistent with the Effect service conventions — notably followNetworkStatus now acquires Connectivity/ConnectionWakeups from the environment, and the activation operation literals added to ConnectionPersistenceError are used accurately in both the web and mobile stores.

^{Posted via Macroscope — Effect Service Conventions}

[cursor]

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

There are 4 total unresolved issues (including 3 from previous reviews).

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 59e70a4. Configure here.}

Dismissing prior approval to re-evaluate 055f151

[DominicVonk]

Mobile treated the Host and Pairing Code fields independently, so pasting a complete pairing URL could leave the token embedded in the host field. Schemeless local URLs also behaved differently from desktop.

This change gives mobile the same paste behavior as desktop:

• parses full pairing URLs from the Host field;
• extracts tokens from URL fragments and query strings;
• supports hosted pairing links;
• accepts schemeless hostnames and local IPv4 addresses;
• defaults schemeless IP literals to HTTP and hostnames to HTTPS;
• preserves separately entered host/code values;
• keeps QR and deep-link payload handling on the same parser path.

Related independent PRs

These PRs all target main and can be merged in any order:

• fix(connection): refresh network status after app activation #5597 — network status recovery
• feat(connections): manage environment availability #5598 — environment availability and management
• fix(mobile): parse pasted pairing links #5596 — mobile pairing-link paste

Verification

• vp test run apps/mobile/src/features/connection/pairing.test.ts
  • 1 file passed
  • 11 tests passed
• vp run --filter @t3tools/mobile typecheck
  • passed
• targeted vp lint for the three changed files
  • passed
• fallow audit --base upstream/main
  • passed the new-change gate; inherited repository findings were excluded

No screenshot is included because this PR changes how pasted text is parsed without changing the rendered form.

Built and reviewed with GPT-5 Codex via Codex CLI.

Fork validation PR

• DominicVonk/t3code#9

---

Note

Low Risk
Connection-form parsing and URL normalization only; behavior is covered by unit tests with no auth or data-model changes.

Overview
Aligns mobile Add Environment pairing input with desktop by parsing full pairing URLs pasted into the Host field instead of treating host and code independently.

pairing.ts adds normalizePairingUrlInput (schemeless IPs → HTTP, hostnames → HTTPS, // → HTTPS) and parsePairingFields, which splits a pasted URL’s token from the host when present. buildPairingUrl and parsePairingUrl use that normalization for direct, schemeless, protocol-relative, and hosted pairing links.

ConnectionsNewRouteScreen runs field normalization on host blur and before connect so submit builds the URL from cleaned host/code values.

Tests in pairing.test.ts cover the new parsing and URL-building cases.

^{Reviewed by Cursor Bugbot for commit 9bdff53. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Fix pairing link parsing to extract embedded tokens from the host field on mobile

• Adds parsePairingFields in pairing.ts to detect when a full pairing URL is pasted into the host field and extract the token into the code field.
• Adds normalizePairingUrlInput to infer schemes for schemeless and protocol-relative inputs (HTTPS for hostnames, HTTP for IPs).
• Updates parsePairingUrl and buildPairingUrl to use the new normalization, so protocol-relative and schemeless hosts are handled correctly.
• In ConnectionsNewRouteScreen, calls parsePairingFields on blur and at submit so the host and code fields are normalized before the pairing URL is built.

^{Macroscope summarized 9bdff53.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: bd0515a6-0fce-4962-9757-a61b0ea1e69c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[macroscopeapp]

Effect service conventions review: one finding. The new ConnectionActivationStore implementations map their failures onto unrelated ConnectionPersistenceError operation labels (register-connection for activation writes, list-targets for listDisabled), so the structured operation context no longer identifies the failing operation. Everything else in the diff (namespace imports, Context.Service tag placement in platform/persistence.ts, the new setEnabled registry operation and atom command, and the test-only service instances in the harnesses) follows the conventions.

^{Posted via Macroscope — Effect Service Conventions}

[macroscopeapp]

One convention issue found: in apps/mobile/src/connection/storage.ts the new activation-specific ConnectionPersistenceError operation literals are swapped with the existing target/registration ones, so the structured operation attribute no longer identifies the operation that actually failed. The web store (apps/web/src/connection/storage.ts) maps these correctly and can be used as the reference.

^{Posted via Macroscope — Effect Service Conventions}

[macroscopeapp]

One convention finding on the new shared connectivity helper. Everything else (activation store definition, platform implementations, error operation literals, new registry command) follows the service conventions.

^{Posted via Macroscope — Effect Service Conventions}

[macroscopeapp]

Approvability

Verdict: Approved 055f151

Small, self-contained bug fix adding URL parsing for pasted pairing links on mobile. Changes include helper functions and comprehensive unit tests. The open review comments reference either unrelated files or scenarios covered by tests.

^{You can customize Macroscope's approvability policy. Learn more.}

[macroscopeapp]

One convention finding: the new failure handling in packages/client-runtime/src/connection/onboarding.ts uses Effect.catchTag instead of Effect.catchTags. Everything else in scope looks consistent with the Effect service conventions — notably followNetworkStatus now acquires Connectivity/ConnectionWakeups from the environment, and the activation operation literals added to ConnectionPersistenceError are used accurately in both the web and mobile stores.

^{Posted via Macroscope — Effect Service Conventions}

[cursor]

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

There are 4 total unresolved issues (including 3 from previous reviews).

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 59e70a4. Configure here.}

Dismissing prior approval to re-evaluate 055f151