Uh oh!
There was an error while loading. Please reload this page.
fix(ios): preserve project picker scroll during refresh - #5660
Conversation
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThe new thread view now uses a shared project or branch picker. Project groups resolve to preferred current-environment projects, validate selections, and dismiss the picker after successful selection. Tests cover stale and removed group IDs. ChangesProject selection
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant User
participant NewThreadView
participant ProjectPicker
participant DailyUXProjectGrouping
User->>NewThreadView: Open project selector
NewThreadView->>ProjectPicker: Present project groups
User->>ProjectPicker: Select project group
ProjectPicker->>NewThreadView: Return selected group ID
NewThreadView->>DailyUXProjectGrouping: Resolve selectionTarget
DailyUXProjectGrouping-->>NewThreadView: Return preferred project
NewThreadView-->>User: Apply selection and dismiss picker
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ApprovabilityVerdict: Approved 827aae5 This is a self-contained iOS UI fix that changes the project picker from a Menu to a sheet-based presentation to preserve scroll position during refresh. The changes include defensive validation and corresponding tests, with no impact outside the picker UI. You can customize Macroscope's approvability policy. Learn more. |
38b865c to
ccf65fcCompareccf65fc to
0b43ed7CompareDismissing prior approval to re-evaluate 0b43ed7
0b43ed7 to
bb4ab33Comparet3dotgg
commented
Aug 9, 2026
Note 🤖 GPT-5.6 responding on behalf of Theo /recheck-vouch |
Dismissing prior approval to re-evaluate 827aae5
saphid
commented
Aug 9, 2026
@coderabbitai review |
✅ Action performedReview finished.
|
65e66ee
into
pingdotgg:t3code/rebuild-mobile-app-swiftUh oh!
There was an error while loading. Please reload this page.
What Changed
Menuwith a sheet-backed SwiftUIListwhose logical row identities survive live refreshes without resetting the picker viewport.Why
The SwiftUI client continuously receives project snapshots. Rebuilding the old
Menuwhile someone was browsing it reset the viewport to the top. AListupdates stable rows in place, so an incoming project can appear without interrupting the user's position.This is a focused follow-up to the experimental SwiftUI client in #5178 and targets
t3code/rebuild-mobile-app-swift, where that client currently lives.UI Changes
9-second interaction proof: project 23 arrives while the picker remains anchored (MP4)
Validation
T3CodeTests/DailyUXNewTaskTests: 14 passed, 0 failed, 0 skipped on the final reviewed head.git diff --check: passed.827aae58efixed it. A fresh post-fix review exited 0 with no actionable findings.65e66ee51; the three PR-owned files are byte-for-byte identical to827aae58e, andgit range-diffshows the hit-area follow-up folded into the squash while the CI repair remains a separate base commit.Scope
This is one SwiftUI-only bug fix: three files, 208 changed lines, no wire contract, server, web, desktop, or React Native mobile changes. The
size:Llabel reflects the extracted sheet view and focused regression test, not additional product scope.Checklist
Implementation and verification used GPT-5.6 Sol High in T3 Code with the Codex harness. Independent review used Claude Opus 5 High in Claude Code.
Note
Low Risk
Focused SwiftUI UX and selection-validation changes in the new-thread flow; no auth, networking, or data-model changes beyond grouping helper usage.
Overview
Replaces the New Task project
Menuwith a sheet-backedListso live project snapshot updates no longer jump scroll position to the top. Project and branch pickers now share a singleactivePickersheet route (NewTaskPicker).NewTaskProjectPickershows grouped projects with checkmarks, empty state, and accessibility on the hero control; the sheet dismisses only whenselectProject/selectProjectGroupsucceed (Boolreturn). Group picks resolve via newDailyUXProjectGrouping.selectionTargetagainst the current groups (handles stale IDs after refresh); tests cover that path.Reviewed by Cursor Bugbot for commit 827aae5. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Preserve project picker scroll position during refresh in iOS new thread view
Menufor project selection inNewThreadViewwith a dedicated sheet (NewTaskProjectPicker) driven by a newNewTaskPickerenum, fixing scroll position loss on refresh.DailyUXProjectGrouping.selectionTargetto resolve a project group against the current live groups, so stale or removed group IDs fail gracefully without mutating state.selectProjectnow validates that the provided project ID exists increationProjectsbefore applying changes, returning aBoolto indicate success.Macroscope summarized 827aae5.
Summary by CodeRabbit
New Features
Bug Fixes