fix(ci): repair SwiftUI fixture verification - #5674

Merged
t3dotgg merged 3 commits into
pingdotgg:t3code/rebuild-mobile-app-swiftfrom
saphid:agent/swiftui-ci-fixtures
Aug 9, 2026
Merged

fix(ci): repair SwiftUI fixture verification#5674
t3dotgg merged 3 commits into
pingdotgg:t3code/rebuild-mobile-app-swiftfrom
saphid:agent/swiftui-ci-fixtures

Conversation

@saphid

@saphidsaphid commented Aug 8, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

What changed

  • Install the @t3tools/scripts dependency closure in the SwiftUI fixture-verification job so the generator can resolve effect and @t3tools/contracts from a clean checkout.
  • Move the wire-fixture generator to the repository Effect FileSystem/Path/logging conventions and package-name contract import.
  • Run the SwiftUI workflow when scripts/package.json changes because that manifest owns the generator runtime dependencies.

Why

The shared SwiftUI branch failed before native feature code was evaluated. The workflow installed the contracts-only closure even though the generator belongs to @t3tools/scripts, producing ERR_MODULE_NOT_FOUND on a clean runner; the existing direct Node imports also failed the shared lint rules. This focused repair fixes only the fixture-verification path. It does not change app runtime or fixture content.

Validation

  • node scripts/generate-swift-wire-fixtures.ts --check: passed.
  • Full regeneration produced byte-identical SHA-256 values for all four committed fixtures.
  • CI=true pnpm --dir scripts typecheck: passed.
  • CI=true pnpm exec vp check scripts/generate-swift-wire-fixtures.ts .github/workflows/swift-ios.yml: passed.
  • Focused SwiftUI simulator tests: 4 passed, including all wire-fixture contract tests and the formerly hanging aggregate-refresh test.
  • Integrated SwiftUI Debug build/install/launch: passed on an iOS Simulator.
  • PR Contract fixtures and native tests: passed, including the complete 327-test native suite.
  • Rebased shared-stack Contract fixtures and native tests: passed after the base force-rebase; the rewritten base commit has the same stable patch ID as the merged PR.

UI evidence

No UI behavior, appearance, interaction, motion, or user-facing state changed. Screenshots and video are not applicable.

Review status

  • Cursor Bugbot passed on merged head ed6f278bcc9e9247398d1072f92fa7055e1df417.
  • Macroscope correctness passed and approvability approved that head.
  • CodeRabbit explicitly skipped review because automatic reviews are disabled; it is not counted as a review.
  • A direct read-only Claude Opus 5 high review exited 0. It found one low-severity diagnostic improvement: include stale fixture names in the aggregate error. The cleanup was reviewed to no actionable introduced findings, but maintainer merge completed before that optional follow-up reached this PR. Fork commit 15e078120 is therefore not part of the merge.

Merge status

Merged by the maintainer as cecc7efb43a15e6859e8682ecf135bfc7219fd83. The shared base was subsequently force-rebased and retains the identical repair as 6f28bca49.

Implementation used GPT-5.6 Sol in T3 Code. Independent review used Claude Opus 5 high.

@coderabbitai

coderabbitaiBot commented Aug 8, 2026•
edited
Loading

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: a20c8a65-4b78-4397-b175-3f8f0c118c7c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actionsgithub-actionsBot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:S 10-29 changed lines (additions + deletions). size:M 30-99 changed lines (additions + deletions). and removed size:S 10-29 changed lines (additions + deletions). labels Aug 8, 2026
@t3dotgg

t3dotgg commented Aug 9, 2026

Copy link
Copy Markdown
Member

Note

🤖 GPT-5.6 responding on behalf of Theo

/recheck-vouch

@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. and removed vouch:unvouched PR author is not yet trusted in the VOUCHED list. labels Aug 9, 2026
saphidand others added 3 commits August 9, 2026 11:26
@saphid
fix(ci): repair SwiftUI fixture verification
ea580e6
@saphid
fix(ci): watch scripts package metadata
7cd8e87
@saphid@claude
fix(ci): use Effect services in wire-fixture generator
ed6f278
The repository Effect language-service rules reject node:fs/promises,
node:path, console logging, JSON serialization inside Effect code, and
untagged errors, and the relative contracts import pulled foreign files
into the scripts composite project (TS6307). Import @t3tools/contracts
by package name and run the generator through FileSystem/Path services
with a tagged stale-fixtures error so the Typecheck job passes.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@saphid
saphidforce-pushed the agent/swiftui-ci-fixtures branch from 9184b30 to ed6f278CompareAugust 9, 2026 01:31
@saphidsaphid mentioned this pull request Aug 9, 2026
Merged
5 tasks
@t3dotgg
t3dotgg marked this pull request as ready for review August 9, 2026 02:04
@macroscopeapp

macroscopeappBot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved ed6f278

CI-only changes: workflow trigger adjustments and refactoring a test fixture script to use Effect library. No production runtime code is affected—purely development/CI tooling.

You can customize Macroscope's approvability policy. Learn more.

@t3dotgg
t3dotgg merged commit cecc7ef into pingdotgg:t3code/rebuild-mobile-app-swiftAug 9, 2026
21 of 22 checks passed
t3dotgg pushed a commit that referenced this pull request Aug 9, 2026
@saphid@claude
fix(ci): repair SwiftUI fixture verification (#5674)
6f28bca
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
t3dotgg pushed a commit that referenced this pull request Aug 10, 2026
@saphid@claude@t3dotgg
fix(ci): repair SwiftUI fixture verification (#5674)
a4462f7
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
t3dotgg pushed a commit that referenced this pull request Aug 18, 2026
@saphid@claude@t3dotgg
fix(ci): repair SwiftUI fixture verification (#5674)
a5ceb8d
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@macroscopeappmacroscopeapp[bot]macroscopeapp[bot] approved these changes

Assignees

No one assigned

Labels

size:M30-99 changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@saphid@t3dotgg
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
fix(ci): repair SwiftUI fixture verification - #5674
Merged
t3dotgg merged 3 commits into
pingdotgg:t3code/rebuild-mobile-app-swiftfrom 
saphid:agent/swiftui-ci-fixtures
Aug 9, 2026
Merged
fix(ci): repair SwiftUI fixture verification#5674
t3dotgg merged 3 commits into
pingdotgg:t3code/rebuild-mobile-app-swiftfrom 
saphid:agent/swiftui-ci-fixtures
Conversation
@saphid
@saphidsaphid
commented
Aug 8, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
What changed
  • Install the @t3tools/scripts dependency closure in the SwiftUI fixture-verification job so the generator can resolve effect and @t3tools/contracts from a clean checkout.
  • Move the wire-fixture generator to the repository Effect FileSystem/Path/logging conventions and package-name contract import.
  • Run the SwiftUI workflow when scripts/package.json changes because that manifest owns the generator runtime dependencies.
Why
The shared SwiftUI branch failed before native feature code was evaluated. The workflow installed the contracts-only closure even though the generator belongs to @t3tools/scripts, producing ERR_MODULE_NOT_FOUND on a clean runner; the existing direct Node imports also failed the shared lint rules. This focused repair fixes only the fixture-verification path. It does not change app runtime or fixture content.
Validation
  • node scripts/generate-swift-wire-fixtures.ts --check: passed.
  • Full regeneration produced byte-identical SHA-256 values for all four committed fixtures.
  • CI=true pnpm --dir scripts typecheck: passed.
  • CI=true pnpm exec vp check scripts/generate-swift-wire-fixtures.ts .github/workflows/swift-ios.yml: passed.
  • Focused SwiftUI simulator tests: 4 passed, including all wire-fixture contract tests and the formerly hanging aggregate-refresh test.
  • Integrated SwiftUI Debug build/install/launch: passed on an iOS Simulator.
  • PR Contract fixtures and native tests: passed, including the complete 327-test native suite.
  • Rebased shared-stack Contract fixtures and native tests: passed after the base force-rebase; the rewritten base commit has the same stable patch ID as the merged PR.
UI evidence
No UI behavior, appearance, interaction, motion, or user-facing state changed. Screenshots and video are not applicable.
Review status
  • Cursor Bugbot passed on merged head ed6f278bcc9e9247398d1072f92fa7055e1df417.
  • Macroscope correctness passed and approvability approved that head.
  • CodeRabbit explicitly skipped review because automatic reviews are disabled; it is not counted as a review.
  • A direct read-only Claude Opus 5 high review exited 0. It found one low-severity diagnostic improvement: include stale fixture names in the aggregate error. The cleanup was reviewed to no actionable introduced findings, but maintainer merge completed before that optional follow-up reached this PR. Fork commit 15e078120 is therefore not part of the merge.
Merge status
Merged by the maintainer as cecc7efb43a15e6859e8682ecf135bfc7219fd83. The shared base was subsequently force-rebased and retains the identical repair as 6f28bca49.
Implementation used GPT-5.6 Sol in T3 Code. Independent review used Claude Opus 5 high.
@coderabbitai
coderabbitaiBot
commented
Aug 8, 2026•

edited

Loading

Copy link


Copy Markdown

Important
Review skipped
Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro Plus
Run ID: a20c8a65-4b78-4397-b175-3f8f0c118c7c
You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.
Use the checkbox below for a quick retry:
  •  🔍 Trigger review
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands.
@github-actionsgithub-actionsBot
added

vouch:unvouched
PR author is not yet trusted in the VOUCHED list.
size:S
10-29 changed lines (additions + deletions).
size:M
30-99 changed lines (additions + deletions).
and removed

size:S
10-29 changed lines (additions + deletions).
labels
Aug 8, 2026
@t3dotgg
t3dotgg
commented
Aug 9, 2026

Copy link


Copy Markdown

Member
Note
🤖 GPT-5.6 responding on behalf of Theo
/recheck-vouch
@github-actionsgithub-actionsBot
added

vouch:trusted
PR author is trusted by repo permissions or the VOUCHED list.
and removed

vouch:unvouched
PR author is not yet trusted in the VOUCHED list.
labels
Aug 9, 2026
saphidand others
added 3 commits
August 9, 2026 11:26
@saphid
fix(ci): repair SwiftUI fixture verification
ea580e6
@saphid
fix(ci): watch scripts package metadata
7cd8e87
@saphid@claude
fix(ci): use Effect services in wire-fixture generator
ed6f278
The repository Effect language-service rules reject node:fs/promises,
node:path, console logging, JSON serialization inside Effect code, and
untagged errors, and the relative contracts import pulled foreign files
into the scripts composite project (TS6307). Import @t3tools/contracts
by package name and run the generator through FileSystem/Path services
with a tagged stale-fixtures error so the Typecheck job passes.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@saphid
saphidforce-pushed
the
agent/swiftui-ci-fixtures
branch
from
9184b30 to
ed6f278CompareAugust 9, 2026 01:31
@saphidsaphid
mentioned this pull request
Aug 9, 2026
 Merged

5 tasks
@t3dotgg
t3dotgg
marked this pull request as ready for review
August 9, 2026 02:04
@macroscopeapp
macroscopeappBot
commented
Aug 9, 2026

Copy link


Copy Markdown

Contributor
Approvability
Verdict: Approved ed6f278
CI-only changes: workflow trigger adjustments and refactoring a test fixture script to use Effect library. No production runtime code is affected—purely development/CI tooling.
You can customize Macroscope's approvability policy. Learn more.
@t3dotgg
t3dotgg
merged commit cecc7ef
into
pingdotgg:t3code/rebuild-mobile-app-swiftAug 9, 2026

21 of 22 checks passed

t3dotgg pushed a commit
that referenced
this pull request
Aug 9, 2026
@saphid@claude
fix(ci): repair SwiftUI fixture verification (#5674)
6f28bca
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
t3dotgg pushed a commit
that referenced
this pull request
Aug 10, 2026
@saphid@claude@t3dotgg
fix(ci): repair SwiftUI fixture verification (#5674)
a4462f7
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
t3dotgg pushed a commit
that referenced
this pull request
Aug 18, 2026
@saphid@claude@t3dotgg
fix(ci): repair SwiftUI fixture verification (#5674)
a5ceb8d
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@macroscopeappmacroscopeapp[bot]macroscopeapp[bot] approved these changes

Assignees


No one assigned


Labels

size:M30-99 changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@saphid@t3dotgg

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix(ci): repair SwiftUI fixture verification - #5674
Merged
t3dotgg merged 3 commits into
pingdotgg:t3code/rebuild-mobile-app-swiftfrom 
saphid:agent/swiftui-ci-fixtures
Aug 9, 2026
Merged
fix(ci): repair SwiftUI fixture verification#5674
t3dotgg merged 3 commits into
pingdotgg:t3code/rebuild-mobile-app-swiftfrom 
saphid:agent/swiftui-ci-fixtures
Conversation
@saphid
@saphidsaphid
commented
Aug 8, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
What changed
  • Install the @t3tools/scripts dependency closure in the SwiftUI fixture-verification job so the generator can resolve effect and @t3tools/contracts from a clean checkout.
  • Move the wire-fixture generator to the repository Effect FileSystem/Path/logging conventions and package-name contract import.
  • Run the SwiftUI workflow when scripts/package.json changes because that manifest owns the generator runtime dependencies.
Why
The shared SwiftUI branch failed before native feature code was evaluated. The workflow installed the contracts-only closure even though the generator belongs to @t3tools/scripts, producing ERR_MODULE_NOT_FOUND on a clean runner; the existing direct Node imports also failed the shared lint rules. This focused repair fixes only the fixture-verification path. It does not change app runtime or fixture content.
Validation
  • node scripts/generate-swift-wire-fixtures.ts --check: passed.
  • Full regeneration produced byte-identical SHA-256 values for all four committed fixtures.
  • CI=true pnpm --dir scripts typecheck: passed.
  • CI=true pnpm exec vp check scripts/generate-swift-wire-fixtures.ts .github/workflows/swift-ios.yml: passed.
  • Focused SwiftUI simulator tests: 4 passed, including all wire-fixture contract tests and the formerly hanging aggregate-refresh test.
  • Integrated SwiftUI Debug build/install/launch: passed on an iOS Simulator.
  • PR Contract fixtures and native tests: passed, including the complete 327-test native suite.
  • Rebased shared-stack Contract fixtures and native tests: passed after the base force-rebase; the rewritten base commit has the same stable patch ID as the merged PR.
UI evidence
No UI behavior, appearance, interaction, motion, or user-facing state changed. Screenshots and video are not applicable.
Review status
  • Cursor Bugbot passed on merged head ed6f278bcc9e9247398d1072f92fa7055e1df417.
  • Macroscope correctness passed and approvability approved that head.
  • CodeRabbit explicitly skipped review because automatic reviews are disabled; it is not counted as a review.
  • A direct read-only Claude Opus 5 high review exited 0. It found one low-severity diagnostic improvement: include stale fixture names in the aggregate error. The cleanup was reviewed to no actionable introduced findings, but maintainer merge completed before that optional follow-up reached this PR. Fork commit 15e078120 is therefore not part of the merge.
Merge status
Merged by the maintainer as cecc7efb43a15e6859e8682ecf135bfc7219fd83. The shared base was subsequently force-rebased and retains the identical repair as 6f28bca49.
Implementation used GPT-5.6 Sol in T3 Code. Independent review used Claude Opus 5 high.
@coderabbitai
coderabbitaiBot
commented
Aug 8, 2026•

edited

Loading

Copy link


Copy Markdown

Important
Review skipped
Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro Plus
Run ID: a20c8a65-4b78-4397-b175-3f8f0c118c7c
You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.
Use the checkbox below for a quick retry:
  •  🔍 Trigger review
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands.
@github-actionsgithub-actionsBot
added

vouch:unvouched
PR author is not yet trusted in the VOUCHED list.
size:S
10-29 changed lines (additions + deletions).
size:M
30-99 changed lines (additions + deletions).
and removed

size:S
10-29 changed lines (additions + deletions).
labels
Aug 8, 2026
@t3dotgg
t3dotgg
commented
Aug 9, 2026

Copy link


Copy Markdown

Member
Note
🤖 GPT-5.6 responding on behalf of Theo
/recheck-vouch
@github-actionsgithub-actionsBot
added

vouch:trusted
PR author is trusted by repo permissions or the VOUCHED list.
and removed

vouch:unvouched
PR author is not yet trusted in the VOUCHED list.
labels
Aug 9, 2026
saphidand others
added 3 commits
August 9, 2026 11:26
@saphid
fix(ci): repair SwiftUI fixture verification
ea580e6
@saphid
fix(ci): watch scripts package metadata
7cd8e87
@saphid@claude
fix(ci): use Effect services in wire-fixture generator
ed6f278
The repository Effect language-service rules reject node:fs/promises,
node:path, console logging, JSON serialization inside Effect code, and
untagged errors, and the relative contracts import pulled foreign files
into the scripts composite project (TS6307). Import @t3tools/contracts
by package name and run the generator through FileSystem/Path services
with a tagged stale-fixtures error so the Typecheck job passes.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@saphid
saphidforce-pushed
the
agent/swiftui-ci-fixtures
branch
from
9184b30 to
ed6f278CompareAugust 9, 2026 01:31
@saphidsaphid
mentioned this pull request
Aug 9, 2026
 Merged

5 tasks
@t3dotgg
t3dotgg
marked this pull request as ready for review
August 9, 2026 02:04
@macroscopeapp
macroscopeappBot
commented
Aug 9, 2026

Copy link


Copy Markdown

Contributor
Approvability
Verdict: Approved ed6f278
CI-only changes: workflow trigger adjustments and refactoring a test fixture script to use Effect library. No production runtime code is affected—purely development/CI tooling.
You can customize Macroscope's approvability policy. Learn more.
@t3dotgg
t3dotgg
merged commit cecc7ef
into
pingdotgg:t3code/rebuild-mobile-app-swiftAug 9, 2026

21 of 22 checks passed

t3dotgg pushed a commit
that referenced
this pull request
Aug 9, 2026
@saphid@claude
fix(ci): repair SwiftUI fixture verification (#5674)
6f28bca
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
t3dotgg pushed a commit
that referenced
this pull request
Aug 10, 2026
@saphid@claude@t3dotgg
fix(ci): repair SwiftUI fixture verification (#5674)
a4462f7
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
t3dotgg pushed a commit
that referenced
this pull request
Aug 18, 2026
@saphid@claude@t3dotgg
fix(ci): repair SwiftUI fixture verification (#5674)
a5ceb8d
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@macroscopeappmacroscopeapp[bot]macroscopeapp[bot] approved these changes

Assignees


No one assigned


Labels

size:M30-99 changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@saphid@t3dotgg

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix(ci): repair SwiftUI fixture verification - #5674
Merged
t3dotgg merged 3 commits into
pingdotgg:t3code/rebuild-mobile-app-swiftfrom 
saphid:agent/swiftui-ci-fixtures
Aug 9, 2026
Merged
fix(ci): repair SwiftUI fixture verification#5674
t3dotgg merged 3 commits into
pingdotgg:t3code/rebuild-mobile-app-swiftfrom 
saphid:agent/swiftui-ci-fixtures
Conversation
@saphid
@saphidsaphid
commented
Aug 8, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
What changed
  • Install the @t3tools/scripts dependency closure in the SwiftUI fixture-verification job so the generator can resolve effect and @t3tools/contracts from a clean checkout.
  • Move the wire-fixture generator to the repository Effect FileSystem/Path/logging conventions and package-name contract import.
  • Run the SwiftUI workflow when scripts/package.json changes because that manifest owns the generator runtime dependencies.
Why
The shared SwiftUI branch failed before native feature code was evaluated. The workflow installed the contracts-only closure even though the generator belongs to @t3tools/scripts, producing ERR_MODULE_NOT_FOUND on a clean runner; the existing direct Node imports also failed the shared lint rules. This focused repair fixes only the fixture-verification path. It does not change app runtime or fixture content.
Validation
  • node scripts/generate-swift-wire-fixtures.ts --check: passed.
  • Full regeneration produced byte-identical SHA-256 values for all four committed fixtures.
  • CI=true pnpm --dir scripts typecheck: passed.
  • CI=true pnpm exec vp check scripts/generate-swift-wire-fixtures.ts .github/workflows/swift-ios.yml: passed.
  • Focused SwiftUI simulator tests: 4 passed, including all wire-fixture contract tests and the formerly hanging aggregate-refresh test.
  • Integrated SwiftUI Debug build/install/launch: passed on an iOS Simulator.
  • PR Contract fixtures and native tests: passed, including the complete 327-test native suite.
  • Rebased shared-stack Contract fixtures and native tests: passed after the base force-rebase; the rewritten base commit has the same stable patch ID as the merged PR.
UI evidence
No UI behavior, appearance, interaction, motion, or user-facing state changed. Screenshots and video are not applicable.
Review status
  • Cursor Bugbot passed on merged head ed6f278bcc9e9247398d1072f92fa7055e1df417.
  • Macroscope correctness passed and approvability approved that head.
  • CodeRabbit explicitly skipped review because automatic reviews are disabled; it is not counted as a review.
  • A direct read-only Claude Opus 5 high review exited 0. It found one low-severity diagnostic improvement: include stale fixture names in the aggregate error. The cleanup was reviewed to no actionable introduced findings, but maintainer merge completed before that optional follow-up reached this PR. Fork commit 15e078120 is therefore not part of the merge.
Merge status
Merged by the maintainer as cecc7efb43a15e6859e8682ecf135bfc7219fd83. The shared base was subsequently force-rebased and retains the identical repair as 6f28bca49.
Implementation used GPT-5.6 Sol in T3 Code. Independent review used Claude Opus 5 high.
@coderabbitai
coderabbitaiBot
commented
Aug 8, 2026•

edited

Loading

Copy link


Copy Markdown

Important
Review skipped
Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro Plus
Run ID: a20c8a65-4b78-4397-b175-3f8f0c118c7c
You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.
Use the checkbox below for a quick retry:
  •  🔍 Trigger review
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands.
@github-actionsgithub-actionsBot
added

vouch:unvouched
PR author is not yet trusted in the VOUCHED list.
size:S
10-29 changed lines (additions + deletions).
size:M
30-99 changed lines (additions + deletions).
and removed

size:S
10-29 changed lines (additions + deletions).
labels
Aug 8, 2026
@t3dotgg
t3dotgg
commented
Aug 9, 2026

Copy link


Copy Markdown

Member
Note
🤖 GPT-5.6 responding on behalf of Theo
/recheck-vouch
@github-actionsgithub-actionsBot
added

vouch:trusted
PR author is trusted by repo permissions or the VOUCHED list.
and removed

vouch:unvouched
PR author is not yet trusted in the VOUCHED list.
labels
Aug 9, 2026
saphidand others
added 3 commits
August 9, 2026 11:26
@saphid
fix(ci): repair SwiftUI fixture verification
ea580e6
@saphid
fix(ci): watch scripts package metadata
7cd8e87
@saphid@claude
fix(ci): use Effect services in wire-fixture generator
ed6f278
The repository Effect language-service rules reject node:fs/promises,
node:path, console logging, JSON serialization inside Effect code, and
untagged errors, and the relative contracts import pulled foreign files
into the scripts composite project (TS6307). Import @t3tools/contracts
by package name and run the generator through FileSystem/Path services
with a tagged stale-fixtures error so the Typecheck job passes.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@saphid
saphidforce-pushed
the
agent/swiftui-ci-fixtures
branch
from
9184b30 to
ed6f278CompareAugust 9, 2026 01:31
@saphidsaphid
mentioned this pull request
Aug 9, 2026
 Merged

5 tasks
@t3dotgg
t3dotgg
marked this pull request as ready for review
August 9, 2026 02:04
@macroscopeapp
macroscopeappBot
commented
Aug 9, 2026

Copy link


Copy Markdown

Contributor
Approvability
Verdict: Approved ed6f278
CI-only changes: workflow trigger adjustments and refactoring a test fixture script to use Effect library. No production runtime code is affected—purely development/CI tooling.
You can customize Macroscope's approvability policy. Learn more.
@t3dotgg
t3dotgg
merged commit cecc7ef
into
pingdotgg:t3code/rebuild-mobile-app-swiftAug 9, 2026

21 of 22 checks passed

t3dotgg pushed a commit
that referenced
this pull request
Aug 9, 2026
@saphid@claude
fix(ci): repair SwiftUI fixture verification (#5674)
6f28bca
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
t3dotgg pushed a commit
that referenced
this pull request
Aug 10, 2026
@saphid@claude@t3dotgg
fix(ci): repair SwiftUI fixture verification (#5674)
a4462f7
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
t3dotgg pushed a commit
that referenced
this pull request
Aug 18, 2026
@saphid@claude@t3dotgg
fix(ci): repair SwiftUI fixture verification (#5674)
a5ceb8d
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@macroscopeappmacroscopeapp[bot]macroscopeapp[bot] approved these changes

Assignees


No one assigned


Labels

size:M30-99 changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@saphid@t3dotgg

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
fix(ci): repair SwiftUI fixture verification - #5674
Merged
t3dotgg merged 3 commits into
pingdotgg:t3code/rebuild-mobile-app-swiftfrom 
saphid:agent/swiftui-ci-fixtures
Aug 9, 2026
Merged
fix(ci): repair SwiftUI fixture verification#5674
t3dotgg merged 3 commits into
pingdotgg:t3code/rebuild-mobile-app-swiftfrom 
saphid:agent/swiftui-ci-fixtures
Conversation
@saphid
@saphidsaphid
commented
Aug 8, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
What changed
  • Install the @t3tools/scripts dependency closure in the SwiftUI fixture-verification job so the generator can resolve effect and @t3tools/contracts from a clean checkout.
  • Move the wire-fixture generator to the repository Effect FileSystem/Path/logging conventions and package-name contract import.
  • Run the SwiftUI workflow when scripts/package.json changes because that manifest owns the generator runtime dependencies.
Why
The shared SwiftUI branch failed before native feature code was evaluated. The workflow installed the contracts-only closure even though the generator belongs to @t3tools/scripts, producing ERR_MODULE_NOT_FOUND on a clean runner; the existing direct Node imports also failed the shared lint rules. This focused repair fixes only the fixture-verification path. It does not change app runtime or fixture content.
Validation
  • node scripts/generate-swift-wire-fixtures.ts --check: passed.
  • Full regeneration produced byte-identical SHA-256 values for all four committed fixtures.
  • CI=true pnpm --dir scripts typecheck: passed.
  • CI=true pnpm exec vp check scripts/generate-swift-wire-fixtures.ts .github/workflows/swift-ios.yml: passed.
  • Focused SwiftUI simulator tests: 4 passed, including all wire-fixture contract tests and the formerly hanging aggregate-refresh test.
  • Integrated SwiftUI Debug build/install/launch: passed on an iOS Simulator.
  • PR Contract fixtures and native tests: passed, including the complete 327-test native suite.
  • Rebased shared-stack Contract fixtures and native tests: passed after the base force-rebase; the rewritten base commit has the same stable patch ID as the merged PR.
UI evidence
No UI behavior, appearance, interaction, motion, or user-facing state changed. Screenshots and video are not applicable.
Review status
  • Cursor Bugbot passed on merged head ed6f278bcc9e9247398d1072f92fa7055e1df417.
  • Macroscope correctness passed and approvability approved that head.
  • CodeRabbit explicitly skipped review because automatic reviews are disabled; it is not counted as a review.
  • A direct read-only Claude Opus 5 high review exited 0. It found one low-severity diagnostic improvement: include stale fixture names in the aggregate error. The cleanup was reviewed to no actionable introduced findings, but maintainer merge completed before that optional follow-up reached this PR. Fork commit 15e078120 is therefore not part of the merge.
Merge status
Merged by the maintainer as cecc7efb43a15e6859e8682ecf135bfc7219fd83. The shared base was subsequently force-rebased and retains the identical repair as 6f28bca49.
Implementation used GPT-5.6 Sol in T3 Code. Independent review used Claude Opus 5 high.
@coderabbitai
coderabbitaiBot
commented
Aug 8, 2026•

edited

Loading

Copy link


Copy Markdown

Important
Review skipped
Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro Plus
Run ID: a20c8a65-4b78-4397-b175-3f8f0c118c7c
You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.
Use the checkbox below for a quick retry:
  •  🔍 Trigger review
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands.
@github-actionsgithub-actionsBot
added

vouch:unvouched
PR author is not yet trusted in the VOUCHED list.
size:S
10-29 changed lines (additions + deletions).
size:M
30-99 changed lines (additions + deletions).
and removed

size:S
10-29 changed lines (additions + deletions).
labels
Aug 8, 2026
@t3dotgg
t3dotgg
commented
Aug 9, 2026

Copy link


Copy Markdown

Member
Note
🤖 GPT-5.6 responding on behalf of Theo
/recheck-vouch
@github-actionsgithub-actionsBot
added

vouch:trusted
PR author is trusted by repo permissions or the VOUCHED list.
and removed

vouch:unvouched
PR author is not yet trusted in the VOUCHED list.
labels
Aug 9, 2026
saphidand others
added 3 commits
August 9, 2026 11:26
@saphid
fix(ci): repair SwiftUI fixture verification
ea580e6
@saphid
fix(ci): watch scripts package metadata
7cd8e87
@saphid@claude
fix(ci): use Effect services in wire-fixture generator
ed6f278
The repository Effect language-service rules reject node:fs/promises,
node:path, console logging, JSON serialization inside Effect code, and
untagged errors, and the relative contracts import pulled foreign files
into the scripts composite project (TS6307). Import @t3tools/contracts
by package name and run the generator through FileSystem/Path services
with a tagged stale-fixtures error so the Typecheck job passes.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@saphid
saphidforce-pushed
the
agent/swiftui-ci-fixtures
branch
from
9184b30 to
ed6f278CompareAugust 9, 2026 01:31
@saphidsaphid
mentioned this pull request
Aug 9, 2026
 Merged

5 tasks
@t3dotgg
t3dotgg
marked this pull request as ready for review
August 9, 2026 02:04
@macroscopeapp
macroscopeappBot
commented
Aug 9, 2026

Copy link


Copy Markdown

Contributor
Approvability
Verdict: Approved ed6f278
CI-only changes: workflow trigger adjustments and refactoring a test fixture script to use Effect library. No production runtime code is affected—purely development/CI tooling.
You can customize Macroscope's approvability policy. Learn more.
@t3dotgg
t3dotgg
merged commit cecc7ef
into
pingdotgg:t3code/rebuild-mobile-app-swiftAug 9, 2026

21 of 22 checks passed

t3dotgg pushed a commit
that referenced
this pull request
Aug 9, 2026
@saphid@claude
fix(ci): repair SwiftUI fixture verification (#5674)
6f28bca
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
t3dotgg pushed a commit
that referenced
this pull request
Aug 10, 2026
@saphid@claude@t3dotgg
fix(ci): repair SwiftUI fixture verification (#5674)
a4462f7
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
t3dotgg pushed a commit
that referenced
this pull request
Aug 18, 2026
@saphid@claude@t3dotgg
fix(ci): repair SwiftUI fixture verification (#5674)
a5ceb8d
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@macroscopeappmacroscopeapp[bot]macroscopeapp[bot] approved these changes

Assignees


No one assigned


Labels

size:M30-99 changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@saphid@t3dotgg

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix(ci): repair SwiftUI fixture verification - #5674
Merged
t3dotgg merged 3 commits into
pingdotgg:t3code/rebuild-mobile-app-swiftfrom 
saphid:agent/swiftui-ci-fixtures
Aug 9, 2026
Merged
fix(ci): repair SwiftUI fixture verification#5674
t3dotgg merged 3 commits into
pingdotgg:t3code/rebuild-mobile-app-swiftfrom 
saphid:agent/swiftui-ci-fixtures
Conversation
@saphid
@saphidsaphid
commented
Aug 8, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
What changed
  • Install the @t3tools/scripts dependency closure in the SwiftUI fixture-verification job so the generator can resolve effect and @t3tools/contracts from a clean checkout.
  • Move the wire-fixture generator to the repository Effect FileSystem/Path/logging conventions and package-name contract import.
  • Run the SwiftUI workflow when scripts/package.json changes because that manifest owns the generator runtime dependencies.
Why
The shared SwiftUI branch failed before native feature code was evaluated. The workflow installed the contracts-only closure even though the generator belongs to @t3tools/scripts, producing ERR_MODULE_NOT_FOUND on a clean runner; the existing direct Node imports also failed the shared lint rules. This focused repair fixes only the fixture-verification path. It does not change app runtime or fixture content.
Validation
  • node scripts/generate-swift-wire-fixtures.ts --check: passed.
  • Full regeneration produced byte-identical SHA-256 values for all four committed fixtures.
  • CI=true pnpm --dir scripts typecheck: passed.
  • CI=true pnpm exec vp check scripts/generate-swift-wire-fixtures.ts .github/workflows/swift-ios.yml: passed.
  • Focused SwiftUI simulator tests: 4 passed, including all wire-fixture contract tests and the formerly hanging aggregate-refresh test.
  • Integrated SwiftUI Debug build/install/launch: passed on an iOS Simulator.
  • PR Contract fixtures and native tests: passed, including the complete 327-test native suite.
  • Rebased shared-stack Contract fixtures and native tests: passed after the base force-rebase; the rewritten base commit has the same stable patch ID as the merged PR.
UI evidence
No UI behavior, appearance, interaction, motion, or user-facing state changed. Screenshots and video are not applicable.
Review status
  • Cursor Bugbot passed on merged head ed6f278bcc9e9247398d1072f92fa7055e1df417.
  • Macroscope correctness passed and approvability approved that head.
  • CodeRabbit explicitly skipped review because automatic reviews are disabled; it is not counted as a review.
  • A direct read-only Claude Opus 5 high review exited 0. It found one low-severity diagnostic improvement: include stale fixture names in the aggregate error. The cleanup was reviewed to no actionable introduced findings, but maintainer merge completed before that optional follow-up reached this PR. Fork commit 15e078120 is therefore not part of the merge.
Merge status
Merged by the maintainer as cecc7efb43a15e6859e8682ecf135bfc7219fd83. The shared base was subsequently force-rebased and retains the identical repair as 6f28bca49.
Implementation used GPT-5.6 Sol in T3 Code. Independent review used Claude Opus 5 high.
@coderabbitai
coderabbitaiBot
commented
Aug 8, 2026•

edited

Loading

Copy link


Copy Markdown

Important
Review skipped
Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro Plus
Run ID: a20c8a65-4b78-4397-b175-3f8f0c118c7c
You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.
Use the checkbox below for a quick retry:
  •  🔍 Trigger review
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands.
@github-actionsgithub-actionsBot
added

vouch:unvouched
PR author is not yet trusted in the VOUCHED list.
size:S
10-29 changed lines (additions + deletions).
size:M
30-99 changed lines (additions + deletions).
and removed

size:S
10-29 changed lines (additions + deletions).
labels
Aug 8, 2026
@t3dotgg
t3dotgg
commented
Aug 9, 2026

Copy link


Copy Markdown

Member
Note
🤖 GPT-5.6 responding on behalf of Theo
/recheck-vouch
@github-actionsgithub-actionsBot
added

vouch:trusted
PR author is trusted by repo permissions or the VOUCHED list.
and removed

vouch:unvouched
PR author is not yet trusted in the VOUCHED list.
labels
Aug 9, 2026
saphidand others
added 3 commits
August 9, 2026 11:26
@saphid
fix(ci): repair SwiftUI fixture verification
ea580e6
@saphid
fix(ci): watch scripts package metadata
7cd8e87
@saphid@claude
fix(ci): use Effect services in wire-fixture generator
ed6f278
The repository Effect language-service rules reject node:fs/promises,
node:path, console logging, JSON serialization inside Effect code, and
untagged errors, and the relative contracts import pulled foreign files
into the scripts composite project (TS6307). Import @t3tools/contracts
by package name and run the generator through FileSystem/Path services
with a tagged stale-fixtures error so the Typecheck job passes.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@saphid
saphidforce-pushed
the
agent/swiftui-ci-fixtures
branch
from
9184b30 to
ed6f278CompareAugust 9, 2026 01:31
@saphidsaphid
mentioned this pull request
Aug 9, 2026
 Merged

5 tasks
@t3dotgg
t3dotgg
marked this pull request as ready for review
August 9, 2026 02:04
@macroscopeapp
macroscopeappBot
commented
Aug 9, 2026

Copy link


Copy Markdown

Contributor
Approvability
Verdict: Approved ed6f278
CI-only changes: workflow trigger adjustments and refactoring a test fixture script to use Effect library. No production runtime code is affected—purely development/CI tooling.
You can customize Macroscope's approvability policy. Learn more.
@t3dotgg
t3dotgg
merged commit cecc7ef
into
pingdotgg:t3code/rebuild-mobile-app-swiftAug 9, 2026

21 of 22 checks passed

t3dotgg pushed a commit
that referenced
this pull request
Aug 9, 2026
@saphid@claude
fix(ci): repair SwiftUI fixture verification (#5674)
6f28bca
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
t3dotgg pushed a commit
that referenced
this pull request
Aug 10, 2026
@saphid@claude@t3dotgg
fix(ci): repair SwiftUI fixture verification (#5674)
a4462f7
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
t3dotgg pushed a commit
that referenced
this pull request
Aug 18, 2026
@saphid@claude@t3dotgg
fix(ci): repair SwiftUI fixture verification (#5674)
a5ceb8d
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@macroscopeappmacroscopeapp[bot]macroscopeapp[bot] approved these changes

Assignees


No one assigned


Labels

size:M30-99 changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@saphid@t3dotgg

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix(ci): repair SwiftUI fixture verification - #5674
Merged
t3dotgg merged 3 commits into
pingdotgg:t3code/rebuild-mobile-app-swiftfrom 
saphid:agent/swiftui-ci-fixtures
Aug 9, 2026
Merged
fix(ci): repair SwiftUI fixture verification#5674
t3dotgg merged 3 commits into
pingdotgg:t3code/rebuild-mobile-app-swiftfrom 
saphid:agent/swiftui-ci-fixtures
Conversation
@saphid
@saphidsaphid
commented
Aug 8, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
What changed
  • Install the @t3tools/scripts dependency closure in the SwiftUI fixture-verification job so the generator can resolve effect and @t3tools/contracts from a clean checkout.
  • Move the wire-fixture generator to the repository Effect FileSystem/Path/logging conventions and package-name contract import.
  • Run the SwiftUI workflow when scripts/package.json changes because that manifest owns the generator runtime dependencies.
Why
The shared SwiftUI branch failed before native feature code was evaluated. The workflow installed the contracts-only closure even though the generator belongs to @t3tools/scripts, producing ERR_MODULE_NOT_FOUND on a clean runner; the existing direct Node imports also failed the shared lint rules. This focused repair fixes only the fixture-verification path. It does not change app runtime or fixture content.
Validation
  • node scripts/generate-swift-wire-fixtures.ts --check: passed.
  • Full regeneration produced byte-identical SHA-256 values for all four committed fixtures.
  • CI=true pnpm --dir scripts typecheck: passed.
  • CI=true pnpm exec vp check scripts/generate-swift-wire-fixtures.ts .github/workflows/swift-ios.yml: passed.
  • Focused SwiftUI simulator tests: 4 passed, including all wire-fixture contract tests and the formerly hanging aggregate-refresh test.
  • Integrated SwiftUI Debug build/install/launch: passed on an iOS Simulator.
  • PR Contract fixtures and native tests: passed, including the complete 327-test native suite.
  • Rebased shared-stack Contract fixtures and native tests: passed after the base force-rebase; the rewritten base commit has the same stable patch ID as the merged PR.
UI evidence
No UI behavior, appearance, interaction, motion, or user-facing state changed. Screenshots and video are not applicable.
Review status
  • Cursor Bugbot passed on merged head ed6f278bcc9e9247398d1072f92fa7055e1df417.
  • Macroscope correctness passed and approvability approved that head.
  • CodeRabbit explicitly skipped review because automatic reviews are disabled; it is not counted as a review.
  • A direct read-only Claude Opus 5 high review exited 0. It found one low-severity diagnostic improvement: include stale fixture names in the aggregate error. The cleanup was reviewed to no actionable introduced findings, but maintainer merge completed before that optional follow-up reached this PR. Fork commit 15e078120 is therefore not part of the merge.
Merge status
Merged by the maintainer as cecc7efb43a15e6859e8682ecf135bfc7219fd83. The shared base was subsequently force-rebased and retains the identical repair as 6f28bca49.
Implementation used GPT-5.6 Sol in T3 Code. Independent review used Claude Opus 5 high.
@coderabbitai
coderabbitaiBot
commented
Aug 8, 2026•

edited

Loading

Copy link


Copy Markdown

Important
Review skipped
Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro Plus
Run ID: a20c8a65-4b78-4397-b175-3f8f0c118c7c
You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.
Use the checkbox below for a quick retry:
  •  🔍 Trigger review
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands.
@github-actionsgithub-actionsBot
added

vouch:unvouched
PR author is not yet trusted in the VOUCHED list.
size:S
10-29 changed lines (additions + deletions).
size:M
30-99 changed lines (additions + deletions).
and removed

size:S
10-29 changed lines (additions + deletions).
labels
Aug 8, 2026
@t3dotgg
t3dotgg
commented
Aug 9, 2026

Copy link


Copy Markdown

Member
Note
🤖 GPT-5.6 responding on behalf of Theo
/recheck-vouch
@github-actionsgithub-actionsBot
added

vouch:trusted
PR author is trusted by repo permissions or the VOUCHED list.
and removed

vouch:unvouched
PR author is not yet trusted in the VOUCHED list.
labels
Aug 9, 2026
saphidand others
added 3 commits
August 9, 2026 11:26
@saphid
fix(ci): repair SwiftUI fixture verification
ea580e6
@saphid
fix(ci): watch scripts package metadata
7cd8e87
@saphid@claude
fix(ci): use Effect services in wire-fixture generator
ed6f278
The repository Effect language-service rules reject node:fs/promises,
node:path, console logging, JSON serialization inside Effect code, and
untagged errors, and the relative contracts import pulled foreign files
into the scripts composite project (TS6307). Import @t3tools/contracts
by package name and run the generator through FileSystem/Path services
with a tagged stale-fixtures error so the Typecheck job passes.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@saphid
saphidforce-pushed
the
agent/swiftui-ci-fixtures
branch
from
9184b30 to
ed6f278CompareAugust 9, 2026 01:31
@saphidsaphid
mentioned this pull request
Aug 9, 2026
 Merged

5 tasks
@t3dotgg
t3dotgg
marked this pull request as ready for review
August 9, 2026 02:04
@macroscopeapp
macroscopeappBot
commented
Aug 9, 2026

Copy link


Copy Markdown

Contributor
Approvability
Verdict: Approved ed6f278
CI-only changes: workflow trigger adjustments and refactoring a test fixture script to use Effect library. No production runtime code is affected—purely development/CI tooling.
You can customize Macroscope's approvability policy. Learn more.
@t3dotgg
t3dotgg
merged commit cecc7ef
into
pingdotgg:t3code/rebuild-mobile-app-swiftAug 9, 2026

21 of 22 checks passed

t3dotgg pushed a commit
that referenced
this pull request
Aug 9, 2026
@saphid@claude
fix(ci): repair SwiftUI fixture verification (#5674)
6f28bca
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
t3dotgg pushed a commit
that referenced
this pull request
Aug 10, 2026
@saphid@claude@t3dotgg
fix(ci): repair SwiftUI fixture verification (#5674)
a4462f7
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
t3dotgg pushed a commit
that referenced
this pull request
Aug 18, 2026
@saphid@claude@t3dotgg
fix(ci): repair SwiftUI fixture verification (#5674)
a5ceb8d
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@macroscopeappmacroscopeapp[bot]macroscopeapp[bot] approved these changes

Assignees


No one assigned


Labels

size:M30-99 changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@saphid@t3dotgg

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
fix(ci): repair SwiftUI fixture verification - #5674
Merged
t3dotgg merged 3 commits into
pingdotgg:t3code/rebuild-mobile-app-swiftfrom 
saphid:agent/swiftui-ci-fixtures
Aug 9, 2026
Merged
fix(ci): repair SwiftUI fixture verification#5674
t3dotgg merged 3 commits into
pingdotgg:t3code/rebuild-mobile-app-swiftfrom 
saphid:agent/swiftui-ci-fixtures
Conversation
@saphid
@saphidsaphid
commented
Aug 8, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
What changed
  • Install the @t3tools/scripts dependency closure in the SwiftUI fixture-verification job so the generator can resolve effect and @t3tools/contracts from a clean checkout.
  • Move the wire-fixture generator to the repository Effect FileSystem/Path/logging conventions and package-name contract import.
  • Run the SwiftUI workflow when scripts/package.json changes because that manifest owns the generator runtime dependencies.
Why
The shared SwiftUI branch failed before native feature code was evaluated. The workflow installed the contracts-only closure even though the generator belongs to @t3tools/scripts, producing ERR_MODULE_NOT_FOUND on a clean runner; the existing direct Node imports also failed the shared lint rules. This focused repair fixes only the fixture-verification path. It does not change app runtime or fixture content.
Validation
  • node scripts/generate-swift-wire-fixtures.ts --check: passed.
  • Full regeneration produced byte-identical SHA-256 values for all four committed fixtures.
  • CI=true pnpm --dir scripts typecheck: passed.
  • CI=true pnpm exec vp check scripts/generate-swift-wire-fixtures.ts .github/workflows/swift-ios.yml: passed.
  • Focused SwiftUI simulator tests: 4 passed, including all wire-fixture contract tests and the formerly hanging aggregate-refresh test.
  • Integrated SwiftUI Debug build/install/launch: passed on an iOS Simulator.
  • PR Contract fixtures and native tests: passed, including the complete 327-test native suite.
  • Rebased shared-stack Contract fixtures and native tests: passed after the base force-rebase; the rewritten base commit has the same stable patch ID as the merged PR.
UI evidence
No UI behavior, appearance, interaction, motion, or user-facing state changed. Screenshots and video are not applicable.
Review status
  • Cursor Bugbot passed on merged head ed6f278bcc9e9247398d1072f92fa7055e1df417.
  • Macroscope correctness passed and approvability approved that head.
  • CodeRabbit explicitly skipped review because automatic reviews are disabled; it is not counted as a review.
  • A direct read-only Claude Opus 5 high review exited 0. It found one low-severity diagnostic improvement: include stale fixture names in the aggregate error. The cleanup was reviewed to no actionable introduced findings, but maintainer merge completed before that optional follow-up reached this PR. Fork commit 15e078120 is therefore not part of the merge.
Merge status
Merged by the maintainer as cecc7efb43a15e6859e8682ecf135bfc7219fd83. The shared base was subsequently force-rebased and retains the identical repair as 6f28bca49.
Implementation used GPT-5.6 Sol in T3 Code. Independent review used Claude Opus 5 high.
@coderabbitai
coderabbitaiBot
commented
Aug 8, 2026•

edited

Loading

Copy link


Copy Markdown

Important
Review skipped
Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro Plus
Run ID: a20c8a65-4b78-4397-b175-3f8f0c118c7c
You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.
Use the checkbox below for a quick retry:
  •  🔍 Trigger review
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands.
@github-actionsgithub-actionsBot
added

vouch:unvouched
PR author is not yet trusted in the VOUCHED list.
size:S
10-29 changed lines (additions + deletions).
size:M
30-99 changed lines (additions + deletions).
and removed

size:S
10-29 changed lines (additions + deletions).
labels
Aug 8, 2026
@t3dotgg
t3dotgg
commented
Aug 9, 2026

Copy link


Copy Markdown

Member
Note
🤖 GPT-5.6 responding on behalf of Theo
/recheck-vouch
@github-actionsgithub-actionsBot
added

vouch:trusted
PR author is trusted by repo permissions or the VOUCHED list.
and removed

vouch:unvouched
PR author is not yet trusted in the VOUCHED list.
labels
Aug 9, 2026
saphidand others
added 3 commits
August 9, 2026 11:26
@saphid
fix(ci): repair SwiftUI fixture verification
ea580e6
@saphid
fix(ci): watch scripts package metadata
7cd8e87
@saphid@claude
fix(ci): use Effect services in wire-fixture generator
ed6f278
The repository Effect language-service rules reject node:fs/promises,
node:path, console logging, JSON serialization inside Effect code, and
untagged errors, and the relative contracts import pulled foreign files
into the scripts composite project (TS6307). Import @t3tools/contracts
by package name and run the generator through FileSystem/Path services
with a tagged stale-fixtures error so the Typecheck job passes.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@saphid
saphidforce-pushed
the
agent/swiftui-ci-fixtures
branch
from
9184b30 to
ed6f278CompareAugust 9, 2026 01:31
@saphidsaphid
mentioned this pull request
Aug 9, 2026
 Merged

5 tasks
@t3dotgg
t3dotgg
marked this pull request as ready for review
August 9, 2026 02:04
@macroscopeapp
macroscopeappBot
commented
Aug 9, 2026

Copy link


Copy Markdown

Contributor
Approvability
Verdict: Approved ed6f278
CI-only changes: workflow trigger adjustments and refactoring a test fixture script to use Effect library. No production runtime code is affected—purely development/CI tooling.
You can customize Macroscope's approvability policy. Learn more.
@t3dotgg
t3dotgg
merged commit cecc7ef
into
pingdotgg:t3code/rebuild-mobile-app-swiftAug 9, 2026

21 of 22 checks passed

t3dotgg pushed a commit
that referenced
this pull request
Aug 9, 2026
@saphid@claude
fix(ci): repair SwiftUI fixture verification (#5674)
6f28bca
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
t3dotgg pushed a commit
that referenced
this pull request
Aug 10, 2026
@saphid@claude@t3dotgg
fix(ci): repair SwiftUI fixture verification (#5674)
a4462f7
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
t3dotgg pushed a commit
that referenced
this pull request
Aug 18, 2026
@saphid@claude@t3dotgg
fix(ci): repair SwiftUI fixture verification (#5674)
a5ceb8d
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@macroscopeappmacroscopeapp[bot]macroscopeapp[bot] approved these changes

Assignees


No one assigned


Labels

size:M30-99 changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@saphid@t3dotgg