Skip to content

fix(server): skip PR lookup for unknown providers - #5831

Closed
Lucenx9 wants to merge 5 commits into
pingdotgg:mainfrom
Lucenx9:fix/skip-pr-lookup-without-remote
Closed

fix(server): skip PR lookup for unknown providers#5831
Lucenx9 wants to merge 5 commits into
pingdotgg:mainfrom
Lucenx9:fix/skip-pr-lookup-without-remote

Conversation

@Lucenx9

@Lucenx9Lucenx9 commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

Problem

Repositories without a recognized source-control remote still attempted PR metadata lookups during status refreshes. The provider registry returned the unsupported unknown provider, so each lookup failed and emitted repeated findLatestPrForHeadContext and PR lookup failed trace entries.

Fix

Resolve the source-control provider once per PR lookup and return a tagged, non-definitive result before calling listChangeRequests when its kind is unknown. That result starts on the short 20-second cache cadence, then follows the existing exponential backoff while provider detection remains non-definitive, capped at the healthy two-minute PR lookup cadence, and falls back to the last known PR instead of overwriting it. A definitive result clears the streak; known providers keep the existing lookup behavior. Focused regression tests cover repositories without remotes, provider refinement after the first short TTL, preserving backoff across a detection hiccup, and preserving an existing PR badge.

Testing

  • node_modules/.bin/vp test run apps/server/src/git/GitManager.test.ts (78 passed)
  • node_modules/.bin/vp lint --report-unused-disable-directives apps/server/src/git/GitManager.ts apps/server/src/git/GitManager.test.ts
  • node_modules/.bin/vp fmt --check apps/server/src/git/GitManager.ts apps/server/src/git/GitManager.test.ts
  • node_modules/.bin/vp run --filter t3 typecheck

Model: GPT-5.6 Sol
Harness: Codex in T3 Code


Note

Low Risk
Scoped to git status PR metadata caching and lookup gating; behavior for known providers is unchanged aside from clearer outcome tagging.

Overview
Git status no longer calls hosting APIs when the source-control provider is unresolved, avoiding repeated failed listChangeRequests lookups for repos without a recognized remote.

GitManager now models PR lookup results with a PrLookupOutcome (Complete vs ProviderUnknown). When the resolved provider kind is unknown, findLatestPrForHeadContext returns ProviderUnknown immediately instead of hitting gh/similar. lookupStatusPr keeps showing the last known PR on that outcome rather than clearing the badge, and the PR lookup cache treats ProviderUnknown like a non-definitive attempt: short retry cadence with existing failure backoff, capped at the normal healthy lookup interval. Definitive Complete results still use the standard TTL and clear the failure streak.

Tests extend makeManager with a configurable provider kind and add coverage for no-remote repos, provider refinement after backoff, backoff preservation across detection hiccups, and sticky PR display while the provider is temporarily unknown.

Reviewed by Cursor Bugbot for commit c7bc695. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Skip PR lookup API calls for unknown providers in GitManager

  • Adds PrLookupOutcome discriminated union (Complete | ProviderUnknown) so the cache can distinguish a definitive PR result from an unresolved provider state
  • findLatestPrForHeadContext now returns ProviderUnknown early when provider.kind is "unknown", avoiding any listChangeRequests calls
  • Cache TTL for unknown-provider outcomes uses Duration.min(nextPrLookupFailureTtl, PR_LOOKUP_CACHE_TTL) and does not clear the failure streak; only definitive results reset the streak
  • lookupStatusPr returns the last known PR (via resolveLastKnownPr) when the provider is unknown, instead of attempting a provider call
  • Behavioral Change: the backoff streak in prLookupCache is no longer cleared on unknown-provider results, so repeated unknown states will continue to increase backoff up to the healthy TTL cap

Macroscope summarized c7bc695.

@coderabbitai

coderabbitaiBot commented Aug 9, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: ba460634-9444-469a-b4bb-002ccd50ffa9

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actionsgithub-actionsBot added size:XS 0-9 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list. labels Aug 9, 2026

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:bbb1467018

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadapps/server/src/git/GitManager.ts Outdated

@cursorcursorBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit bbb1467. Configure here.

Comment threadapps/server/src/git/GitManager.ts
@macroscopeapp

macroscopeappBot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at c7bc695

Macroscope's review found this PR approvable — This is a focused GitManager bug fix that suppresses guaranteed PR API failures for unknown providers while preserving known behavior and last-known status. The localized production change is supported by targeted regression tests and introduces no schema, security, billing, or deployment impact.

You can add or adjust custom eligibility rules. Learn more.

@github-actionsgithub-actionsBot added size:M 30-99 changed lines (additions + deletions). and removed size:XS 0-9 changed lines (additions + deletions). labels Aug 9, 2026
@Lucenx9

Copy link
Copy Markdown
ContributorAuthor

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Breezy!

Reviewed commit:54e8fc3b5c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@Lucenx9

Copy link
Copy Markdown
ContributorAuthor

@codex review

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:9e51853128

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadapps/server/src/git/GitManager.ts Outdated
@Lucenx9

Copy link
Copy Markdown
ContributorAuthor

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. You're on a roll.

Reviewed commit:7b1ad6e860

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

macroscopeapp[bot]
macroscopeappBot previously approved these changes Aug 9, 2026
@Lucenx9Lucenx9 closed this Aug 14, 2026
@ben-vargas

Copy link
Copy Markdown
Contributor

Would be great to see this fixed, it's annoying seeing these errors for projects without a git remote (i.e. when using t3 more as a cowork agent than on a coding project).

@Lucenx9Lucenx9 reopened this Aug 26, 2026
@Lucenx9Lucenx9 closed this Aug 26, 2026
@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. and removed vouch:unvouched PR author is not yet trusted in the VOUCHED list. labels Aug 26, 2026
@Lucenx9Lucenx9 reopened this Aug 27, 2026
@macroscopeapp
macroscopeappBot dismissed their stale reviewAugust 27, 2026 03:15

Dismissing prior approval to re-evaluate c7bc695

@github-actionsgithub-actionsBot added size:L 100-499 changed lines (additions + deletions). and removed size:M 30-99 changed lines (additions + deletions). labels Aug 27, 2026
@Lucenx9

Copy link
Copy Markdown
ContributorAuthor

Updated this PR onto the current main branch. The conflict resolution preserves the default-branch cache key and inherited-upstream guard added by #7317 while carrying the unknown-provider outcome through those paths.

Local verification:

  • vp test run apps/server/src/git/GitManager.test.ts (91 passed)
  • vp lint --report-unused-disable-directives apps/server/src/git/GitManager.ts apps/server/src/git/GitManager.test.ts
  • vp fmt --check apps/server/src/git/GitManager.ts apps/server/src/git/GitManager.test.ts
  • vp run --filter t3 typecheck

@Lucenx9Lucenx9 closed this Aug 27, 2026
@Lucenx9Lucenx9 reopened this Aug 27, 2026
@github-actionsgithub-actionsBot added size:M 30-99 changed lines (additions + deletions). and removed size:L 100-499 changed lines (additions + deletions). labels Aug 27, 2026
@Lucenx9Lucenx9 closed this Aug 29, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M30-99 changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@Lucenx9@ben-vargas
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
fix(server): skip PR lookup for unknown providers by Lucenx9 · Pull Request #5831 · pingdotgg/t3code · GitHub
Skip to content

fix(server): skip PR lookup for unknown providers - #5831

Closed
Lucenx9 wants to merge 5 commits into
pingdotgg:mainfrom
Lucenx9:fix/skip-pr-lookup-without-remote
Closed

fix(server): skip PR lookup for unknown providers#5831
Lucenx9 wants to merge 5 commits into
pingdotgg:mainfrom
Lucenx9:fix/skip-pr-lookup-without-remote

Conversation

@Lucenx9

@Lucenx9Lucenx9 commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

Problem

Repositories without a recognized source-control remote still attempted PR metadata lookups during status refreshes. The provider registry returned the unsupported unknown provider, so each lookup failed and emitted repeated findLatestPrForHeadContext and PR lookup failed trace entries.

Fix

Resolve the source-control provider once per PR lookup and return a tagged, non-definitive result before calling listChangeRequests when its kind is unknown. That result starts on the short 20-second cache cadence, then follows the existing exponential backoff while provider detection remains non-definitive, capped at the healthy two-minute PR lookup cadence, and falls back to the last known PR instead of overwriting it. A definitive result clears the streak; known providers keep the existing lookup behavior. Focused regression tests cover repositories without remotes, provider refinement after the first short TTL, preserving backoff across a detection hiccup, and preserving an existing PR badge.

Testing

  • node_modules/.bin/vp test run apps/server/src/git/GitManager.test.ts (78 passed)
  • node_modules/.bin/vp lint --report-unused-disable-directives apps/server/src/git/GitManager.ts apps/server/src/git/GitManager.test.ts
  • node_modules/.bin/vp fmt --check apps/server/src/git/GitManager.ts apps/server/src/git/GitManager.test.ts
  • node_modules/.bin/vp run --filter t3 typecheck

Model: GPT-5.6 Sol
Harness: Codex in T3 Code


Note

Low Risk
Scoped to git status PR metadata caching and lookup gating; behavior for known providers is unchanged aside from clearer outcome tagging.

Overview
Git status no longer calls hosting APIs when the source-control provider is unresolved, avoiding repeated failed listChangeRequests lookups for repos without a recognized remote.

GitManager now models PR lookup results with a PrLookupOutcome (Complete vs ProviderUnknown). When the resolved provider kind is unknown, findLatestPrForHeadContext returns ProviderUnknown immediately instead of hitting gh/similar. lookupStatusPr keeps showing the last known PR on that outcome rather than clearing the badge, and the PR lookup cache treats ProviderUnknown like a non-definitive attempt: short retry cadence with existing failure backoff, capped at the normal healthy lookup interval. Definitive Complete results still use the standard TTL and clear the failure streak.

Tests extend makeManager with a configurable provider kind and add coverage for no-remote repos, provider refinement after backoff, backoff preservation across detection hiccups, and sticky PR display while the provider is temporarily unknown.

Reviewed by Cursor Bugbot for commit c7bc695. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Skip PR lookup API calls for unknown providers in GitManager

  • Adds PrLookupOutcome discriminated union (Complete | ProviderUnknown) so the cache can distinguish a definitive PR result from an unresolved provider state
  • findLatestPrForHeadContext now returns ProviderUnknown early when provider.kind is "unknown", avoiding any listChangeRequests calls
  • Cache TTL for unknown-provider outcomes uses Duration.min(nextPrLookupFailureTtl, PR_LOOKUP_CACHE_TTL) and does not clear the failure streak; only definitive results reset the streak
  • lookupStatusPr returns the last known PR (via resolveLastKnownPr) when the provider is unknown, instead of attempting a provider call
  • Behavioral Change: the backoff streak in prLookupCache is no longer cleared on unknown-provider results, so repeated unknown states will continue to increase backoff up to the healthy TTL cap

Macroscope summarized c7bc695.

@coderabbitai

coderabbitaiBot commented Aug 9, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: ba460634-9444-469a-b4bb-002ccd50ffa9

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actionsgithub-actionsBot added size:XS 0-9 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list. labels Aug 9, 2026

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:bbb1467018

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadapps/server/src/git/GitManager.ts Outdated

@cursorcursorBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit bbb1467. Configure here.

Comment threadapps/server/src/git/GitManager.ts
@macroscopeapp

macroscopeappBot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at c7bc695

Macroscope's review found this PR approvable — This is a focused GitManager bug fix that suppresses guaranteed PR API failures for unknown providers while preserving known behavior and last-known status. The localized production change is supported by targeted regression tests and introduces no schema, security, billing, or deployment impact.

You can add or adjust custom eligibility rules. Learn more.

@github-actionsgithub-actionsBot added size:M 30-99 changed lines (additions + deletions). and removed size:XS 0-9 changed lines (additions + deletions). labels Aug 9, 2026
@Lucenx9

Copy link
Copy Markdown
ContributorAuthor

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Breezy!

Reviewed commit:54e8fc3b5c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@Lucenx9

Copy link
Copy Markdown
ContributorAuthor

@codex review

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:9e51853128

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadapps/server/src/git/GitManager.ts Outdated
@Lucenx9

Copy link
Copy Markdown
ContributorAuthor

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. You're on a roll.

Reviewed commit:7b1ad6e860

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

macroscopeapp[bot]
macroscopeappBot previously approved these changes Aug 9, 2026
@Lucenx9Lucenx9 closed this Aug 14, 2026
@ben-vargas

Copy link
Copy Markdown
Contributor

Would be great to see this fixed, it's annoying seeing these errors for projects without a git remote (i.e. when using t3 more as a cowork agent than on a coding project).

@Lucenx9Lucenx9 reopened this Aug 26, 2026
@Lucenx9Lucenx9 closed this Aug 26, 2026
@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. and removed vouch:unvouched PR author is not yet trusted in the VOUCHED list. labels Aug 26, 2026
@Lucenx9Lucenx9 reopened this Aug 27, 2026
@macroscopeapp
macroscopeappBot dismissed their stale reviewAugust 27, 2026 03:15

Dismissing prior approval to re-evaluate c7bc695

@github-actionsgithub-actionsBot added size:L 100-499 changed lines (additions + deletions). and removed size:M 30-99 changed lines (additions + deletions). labels Aug 27, 2026
@Lucenx9

Copy link
Copy Markdown
ContributorAuthor

Updated this PR onto the current main branch. The conflict resolution preserves the default-branch cache key and inherited-upstream guard added by #7317 while carrying the unknown-provider outcome through those paths.

Local verification:

  • vp test run apps/server/src/git/GitManager.test.ts (91 passed)
  • vp lint --report-unused-disable-directives apps/server/src/git/GitManager.ts apps/server/src/git/GitManager.test.ts
  • vp fmt --check apps/server/src/git/GitManager.ts apps/server/src/git/GitManager.test.ts
  • vp run --filter t3 typecheck

@Lucenx9Lucenx9 closed this Aug 27, 2026
@Lucenx9Lucenx9 reopened this Aug 27, 2026
@github-actionsgithub-actionsBot added size:M 30-99 changed lines (additions + deletions). and removed size:L 100-499 changed lines (additions + deletions). labels Aug 27, 2026
@Lucenx9Lucenx9 closed this Aug 29, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M30-99 changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@Lucenx9@ben-vargas
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' fix(server): skip PR lookup for unknown providers by Lucenx9 · Pull Request #5831 · pingdotgg/t3code · GitHub
Skip to content

fix(server): skip PR lookup for unknown providers - #5831

Closed
Lucenx9 wants to merge 5 commits into
pingdotgg:mainfrom
Lucenx9:fix/skip-pr-lookup-without-remote
Closed

fix(server): skip PR lookup for unknown providers#5831
Lucenx9 wants to merge 5 commits into
pingdotgg:mainfrom
Lucenx9:fix/skip-pr-lookup-without-remote

Conversation

@Lucenx9

@Lucenx9Lucenx9 commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

Problem

Repositories without a recognized source-control remote still attempted PR metadata lookups during status refreshes. The provider registry returned the unsupported unknown provider, so each lookup failed and emitted repeated findLatestPrForHeadContext and PR lookup failed trace entries.

Fix

Resolve the source-control provider once per PR lookup and return a tagged, non-definitive result before calling listChangeRequests when its kind is unknown. That result starts on the short 20-second cache cadence, then follows the existing exponential backoff while provider detection remains non-definitive, capped at the healthy two-minute PR lookup cadence, and falls back to the last known PR instead of overwriting it. A definitive result clears the streak; known providers keep the existing lookup behavior. Focused regression tests cover repositories without remotes, provider refinement after the first short TTL, preserving backoff across a detection hiccup, and preserving an existing PR badge.

Testing

  • node_modules/.bin/vp test run apps/server/src/git/GitManager.test.ts (78 passed)
  • node_modules/.bin/vp lint --report-unused-disable-directives apps/server/src/git/GitManager.ts apps/server/src/git/GitManager.test.ts
  • node_modules/.bin/vp fmt --check apps/server/src/git/GitManager.ts apps/server/src/git/GitManager.test.ts
  • node_modules/.bin/vp run --filter t3 typecheck

Model: GPT-5.6 Sol
Harness: Codex in T3 Code


Note

Low Risk
Scoped to git status PR metadata caching and lookup gating; behavior for known providers is unchanged aside from clearer outcome tagging.

Overview
Git status no longer calls hosting APIs when the source-control provider is unresolved, avoiding repeated failed listChangeRequests lookups for repos without a recognized remote.

GitManager now models PR lookup results with a PrLookupOutcome (Complete vs ProviderUnknown). When the resolved provider kind is unknown, findLatestPrForHeadContext returns ProviderUnknown immediately instead of hitting gh/similar. lookupStatusPr keeps showing the last known PR on that outcome rather than clearing the badge, and the PR lookup cache treats ProviderUnknown like a non-definitive attempt: short retry cadence with existing failure backoff, capped at the normal healthy lookup interval. Definitive Complete results still use the standard TTL and clear the failure streak.

Tests extend makeManager with a configurable provider kind and add coverage for no-remote repos, provider refinement after backoff, backoff preservation across detection hiccups, and sticky PR display while the provider is temporarily unknown.

Reviewed by Cursor Bugbot for commit c7bc695. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Skip PR lookup API calls for unknown providers in GitManager

  • Adds PrLookupOutcome discriminated union (Complete | ProviderUnknown) so the cache can distinguish a definitive PR result from an unresolved provider state
  • findLatestPrForHeadContext now returns ProviderUnknown early when provider.kind is "unknown", avoiding any listChangeRequests calls
  • Cache TTL for unknown-provider outcomes uses Duration.min(nextPrLookupFailureTtl, PR_LOOKUP_CACHE_TTL) and does not clear the failure streak; only definitive results reset the streak
  • lookupStatusPr returns the last known PR (via resolveLastKnownPr) when the provider is unknown, instead of attempting a provider call
  • Behavioral Change: the backoff streak in prLookupCache is no longer cleared on unknown-provider results, so repeated unknown states will continue to increase backoff up to the healthy TTL cap

Macroscope summarized c7bc695.

@coderabbitai

coderabbitaiBot commented Aug 9, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: ba460634-9444-469a-b4bb-002ccd50ffa9

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actionsgithub-actionsBot added size:XS 0-9 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list. labels Aug 9, 2026

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:bbb1467018

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadapps/server/src/git/GitManager.ts Outdated

@cursorcursorBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit bbb1467. Configure here.

Comment threadapps/server/src/git/GitManager.ts
@macroscopeapp

macroscopeappBot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at c7bc695

Macroscope's review found this PR approvable — This is a focused GitManager bug fix that suppresses guaranteed PR API failures for unknown providers while preserving known behavior and last-known status. The localized production change is supported by targeted regression tests and introduces no schema, security, billing, or deployment impact.

You can add or adjust custom eligibility rules. Learn more.

@github-actionsgithub-actionsBot added size:M 30-99 changed lines (additions + deletions). and removed size:XS 0-9 changed lines (additions + deletions). labels Aug 9, 2026
@Lucenx9

Copy link
Copy Markdown
ContributorAuthor

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Breezy!

Reviewed commit:54e8fc3b5c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@Lucenx9

Copy link
Copy Markdown
ContributorAuthor

@codex review

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:9e51853128

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadapps/server/src/git/GitManager.ts Outdated
@Lucenx9

Copy link
Copy Markdown
ContributorAuthor

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. You're on a roll.

Reviewed commit:7b1ad6e860

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

macroscopeapp[bot]
macroscopeappBot previously approved these changes Aug 9, 2026
@Lucenx9Lucenx9 closed this Aug 14, 2026
@ben-vargas

Copy link
Copy Markdown
Contributor

Would be great to see this fixed, it's annoying seeing these errors for projects without a git remote (i.e. when using t3 more as a cowork agent than on a coding project).

@Lucenx9Lucenx9 reopened this Aug 26, 2026
@Lucenx9Lucenx9 closed this Aug 26, 2026
@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. and removed vouch:unvouched PR author is not yet trusted in the VOUCHED list. labels Aug 26, 2026
@Lucenx9Lucenx9 reopened this Aug 27, 2026
@macroscopeapp
macroscopeappBot dismissed their stale reviewAugust 27, 2026 03:15

Dismissing prior approval to re-evaluate c7bc695

@github-actionsgithub-actionsBot added size:L 100-499 changed lines (additions + deletions). and removed size:M 30-99 changed lines (additions + deletions). labels Aug 27, 2026
@Lucenx9

Copy link
Copy Markdown
ContributorAuthor

Updated this PR onto the current main branch. The conflict resolution preserves the default-branch cache key and inherited-upstream guard added by #7317 while carrying the unknown-provider outcome through those paths.

Local verification:

  • vp test run apps/server/src/git/GitManager.test.ts (91 passed)
  • vp lint --report-unused-disable-directives apps/server/src/git/GitManager.ts apps/server/src/git/GitManager.test.ts
  • vp fmt --check apps/server/src/git/GitManager.ts apps/server/src/git/GitManager.test.ts
  • vp run --filter t3 typecheck

@Lucenx9Lucenx9 closed this Aug 27, 2026
@Lucenx9Lucenx9 reopened this Aug 27, 2026
@github-actionsgithub-actionsBot added size:M 30-99 changed lines (additions + deletions). and removed size:L 100-499 changed lines (additions + deletions). labels Aug 27, 2026
@Lucenx9Lucenx9 closed this Aug 29, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M30-99 changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@Lucenx9@ben-vargas
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' fix(server): skip PR lookup for unknown providers by Lucenx9 · Pull Request #5831 · pingdotgg/t3code · GitHub
Skip to content

fix(server): skip PR lookup for unknown providers - #5831

Closed
Lucenx9 wants to merge 5 commits into
pingdotgg:mainfrom
Lucenx9:fix/skip-pr-lookup-without-remote
Closed

fix(server): skip PR lookup for unknown providers#5831
Lucenx9 wants to merge 5 commits into
pingdotgg:mainfrom
Lucenx9:fix/skip-pr-lookup-without-remote

Conversation

@Lucenx9

@Lucenx9Lucenx9 commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

Problem

Repositories without a recognized source-control remote still attempted PR metadata lookups during status refreshes. The provider registry returned the unsupported unknown provider, so each lookup failed and emitted repeated findLatestPrForHeadContext and PR lookup failed trace entries.

Fix

Resolve the source-control provider once per PR lookup and return a tagged, non-definitive result before calling listChangeRequests when its kind is unknown. That result starts on the short 20-second cache cadence, then follows the existing exponential backoff while provider detection remains non-definitive, capped at the healthy two-minute PR lookup cadence, and falls back to the last known PR instead of overwriting it. A definitive result clears the streak; known providers keep the existing lookup behavior. Focused regression tests cover repositories without remotes, provider refinement after the first short TTL, preserving backoff across a detection hiccup, and preserving an existing PR badge.

Testing

  • node_modules/.bin/vp test run apps/server/src/git/GitManager.test.ts (78 passed)
  • node_modules/.bin/vp lint --report-unused-disable-directives apps/server/src/git/GitManager.ts apps/server/src/git/GitManager.test.ts
  • node_modules/.bin/vp fmt --check apps/server/src/git/GitManager.ts apps/server/src/git/GitManager.test.ts
  • node_modules/.bin/vp run --filter t3 typecheck

Model: GPT-5.6 Sol
Harness: Codex in T3 Code


Note

Low Risk
Scoped to git status PR metadata caching and lookup gating; behavior for known providers is unchanged aside from clearer outcome tagging.

Overview
Git status no longer calls hosting APIs when the source-control provider is unresolved, avoiding repeated failed listChangeRequests lookups for repos without a recognized remote.

GitManager now models PR lookup results with a PrLookupOutcome (Complete vs ProviderUnknown). When the resolved provider kind is unknown, findLatestPrForHeadContext returns ProviderUnknown immediately instead of hitting gh/similar. lookupStatusPr keeps showing the last known PR on that outcome rather than clearing the badge, and the PR lookup cache treats ProviderUnknown like a non-definitive attempt: short retry cadence with existing failure backoff, capped at the normal healthy lookup interval. Definitive Complete results still use the standard TTL and clear the failure streak.

Tests extend makeManager with a configurable provider kind and add coverage for no-remote repos, provider refinement after backoff, backoff preservation across detection hiccups, and sticky PR display while the provider is temporarily unknown.

Reviewed by Cursor Bugbot for commit c7bc695. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Skip PR lookup API calls for unknown providers in GitManager

  • Adds PrLookupOutcome discriminated union (Complete | ProviderUnknown) so the cache can distinguish a definitive PR result from an unresolved provider state
  • findLatestPrForHeadContext now returns ProviderUnknown early when provider.kind is "unknown", avoiding any listChangeRequests calls
  • Cache TTL for unknown-provider outcomes uses Duration.min(nextPrLookupFailureTtl, PR_LOOKUP_CACHE_TTL) and does not clear the failure streak; only definitive results reset the streak
  • lookupStatusPr returns the last known PR (via resolveLastKnownPr) when the provider is unknown, instead of attempting a provider call
  • Behavioral Change: the backoff streak in prLookupCache is no longer cleared on unknown-provider results, so repeated unknown states will continue to increase backoff up to the healthy TTL cap

Macroscope summarized c7bc695.

@coderabbitai

coderabbitaiBot commented Aug 9, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: ba460634-9444-469a-b4bb-002ccd50ffa9

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actionsgithub-actionsBot added size:XS 0-9 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list. labels Aug 9, 2026

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:bbb1467018

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadapps/server/src/git/GitManager.ts Outdated

@cursorcursorBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit bbb1467. Configure here.

Comment threadapps/server/src/git/GitManager.ts
@macroscopeapp

macroscopeappBot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at c7bc695

Macroscope's review found this PR approvable — This is a focused GitManager bug fix that suppresses guaranteed PR API failures for unknown providers while preserving known behavior and last-known status. The localized production change is supported by targeted regression tests and introduces no schema, security, billing, or deployment impact.

You can add or adjust custom eligibility rules. Learn more.

@github-actionsgithub-actionsBot added size:M 30-99 changed lines (additions + deletions). and removed size:XS 0-9 changed lines (additions + deletions). labels Aug 9, 2026
@Lucenx9

Copy link
Copy Markdown
ContributorAuthor

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Breezy!

Reviewed commit:54e8fc3b5c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@Lucenx9

Copy link
Copy Markdown
ContributorAuthor

@codex review

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:9e51853128

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadapps/server/src/git/GitManager.ts Outdated
@Lucenx9

Copy link
Copy Markdown
ContributorAuthor

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. You're on a roll.

Reviewed commit:7b1ad6e860

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

macroscopeapp[bot]
macroscopeappBot previously approved these changes Aug 9, 2026
@Lucenx9Lucenx9 closed this Aug 14, 2026
@ben-vargas

Copy link
Copy Markdown
Contributor

Would be great to see this fixed, it's annoying seeing these errors for projects without a git remote (i.e. when using t3 more as a cowork agent than on a coding project).

@Lucenx9Lucenx9 reopened this Aug 26, 2026
@Lucenx9Lucenx9 closed this Aug 26, 2026
@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. and removed vouch:unvouched PR author is not yet trusted in the VOUCHED list. labels Aug 26, 2026
@Lucenx9Lucenx9 reopened this Aug 27, 2026
@macroscopeapp
macroscopeappBot dismissed their stale reviewAugust 27, 2026 03:15

Dismissing prior approval to re-evaluate c7bc695

@github-actionsgithub-actionsBot added size:L 100-499 changed lines (additions + deletions). and removed size:M 30-99 changed lines (additions + deletions). labels Aug 27, 2026
@Lucenx9

Copy link
Copy Markdown
ContributorAuthor

Updated this PR onto the current main branch. The conflict resolution preserves the default-branch cache key and inherited-upstream guard added by #7317 while carrying the unknown-provider outcome through those paths.

Local verification:

  • vp test run apps/server/src/git/GitManager.test.ts (91 passed)
  • vp lint --report-unused-disable-directives apps/server/src/git/GitManager.ts apps/server/src/git/GitManager.test.ts
  • vp fmt --check apps/server/src/git/GitManager.ts apps/server/src/git/GitManager.test.ts
  • vp run --filter t3 typecheck

@Lucenx9Lucenx9 closed this Aug 27, 2026
@Lucenx9Lucenx9 reopened this Aug 27, 2026
@github-actionsgithub-actionsBot added size:M 30-99 changed lines (additions + deletions). and removed size:L 100-499 changed lines (additions + deletions). labels Aug 27, 2026
@Lucenx9Lucenx9 closed this Aug 29, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M30-99 changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@Lucenx9@ben-vargas
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ' fix(server): skip PR lookup for unknown providers by Lucenx9 · Pull Request #5831 · pingdotgg/t3code · GitHub
Skip to content

fix(server): skip PR lookup for unknown providers - #5831

Closed
Lucenx9 wants to merge 5 commits into
pingdotgg:mainfrom
Lucenx9:fix/skip-pr-lookup-without-remote
Closed

fix(server): skip PR lookup for unknown providers#5831
Lucenx9 wants to merge 5 commits into
pingdotgg:mainfrom
Lucenx9:fix/skip-pr-lookup-without-remote

Conversation

@Lucenx9

@Lucenx9Lucenx9 commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

Problem

Repositories without a recognized source-control remote still attempted PR metadata lookups during status refreshes. The provider registry returned the unsupported unknown provider, so each lookup failed and emitted repeated findLatestPrForHeadContext and PR lookup failed trace entries.

Fix

Resolve the source-control provider once per PR lookup and return a tagged, non-definitive result before calling listChangeRequests when its kind is unknown. That result starts on the short 20-second cache cadence, then follows the existing exponential backoff while provider detection remains non-definitive, capped at the healthy two-minute PR lookup cadence, and falls back to the last known PR instead of overwriting it. A definitive result clears the streak; known providers keep the existing lookup behavior. Focused regression tests cover repositories without remotes, provider refinement after the first short TTL, preserving backoff across a detection hiccup, and preserving an existing PR badge.

Testing

  • node_modules/.bin/vp test run apps/server/src/git/GitManager.test.ts (78 passed)
  • node_modules/.bin/vp lint --report-unused-disable-directives apps/server/src/git/GitManager.ts apps/server/src/git/GitManager.test.ts
  • node_modules/.bin/vp fmt --check apps/server/src/git/GitManager.ts apps/server/src/git/GitManager.test.ts
  • node_modules/.bin/vp run --filter t3 typecheck

Model: GPT-5.6 Sol
Harness: Codex in T3 Code


Note

Low Risk
Scoped to git status PR metadata caching and lookup gating; behavior for known providers is unchanged aside from clearer outcome tagging.

Overview
Git status no longer calls hosting APIs when the source-control provider is unresolved, avoiding repeated failed listChangeRequests lookups for repos without a recognized remote.

GitManager now models PR lookup results with a PrLookupOutcome (Complete vs ProviderUnknown). When the resolved provider kind is unknown, findLatestPrForHeadContext returns ProviderUnknown immediately instead of hitting gh/similar. lookupStatusPr keeps showing the last known PR on that outcome rather than clearing the badge, and the PR lookup cache treats ProviderUnknown like a non-definitive attempt: short retry cadence with existing failure backoff, capped at the normal healthy lookup interval. Definitive Complete results still use the standard TTL and clear the failure streak.

Tests extend makeManager with a configurable provider kind and add coverage for no-remote repos, provider refinement after backoff, backoff preservation across detection hiccups, and sticky PR display while the provider is temporarily unknown.

Reviewed by Cursor Bugbot for commit c7bc695. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Skip PR lookup API calls for unknown providers in GitManager

  • Adds PrLookupOutcome discriminated union (Complete | ProviderUnknown) so the cache can distinguish a definitive PR result from an unresolved provider state
  • findLatestPrForHeadContext now returns ProviderUnknown early when provider.kind is "unknown", avoiding any listChangeRequests calls
  • Cache TTL for unknown-provider outcomes uses Duration.min(nextPrLookupFailureTtl, PR_LOOKUP_CACHE_TTL) and does not clear the failure streak; only definitive results reset the streak
  • lookupStatusPr returns the last known PR (via resolveLastKnownPr) when the provider is unknown, instead of attempting a provider call
  • Behavioral Change: the backoff streak in prLookupCache is no longer cleared on unknown-provider results, so repeated unknown states will continue to increase backoff up to the healthy TTL cap

Macroscope summarized c7bc695.

@coderabbitai

coderabbitaiBot commented Aug 9, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: ba460634-9444-469a-b4bb-002ccd50ffa9

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actionsgithub-actionsBot added size:XS 0-9 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list. labels Aug 9, 2026

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:bbb1467018

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadapps/server/src/git/GitManager.ts Outdated

@cursorcursorBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit bbb1467. Configure here.

Comment threadapps/server/src/git/GitManager.ts
@macroscopeapp

macroscopeappBot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at c7bc695

Macroscope's review found this PR approvable — This is a focused GitManager bug fix that suppresses guaranteed PR API failures for unknown providers while preserving known behavior and last-known status. The localized production change is supported by targeted regression tests and introduces no schema, security, billing, or deployment impact.

You can add or adjust custom eligibility rules. Learn more.

@github-actionsgithub-actionsBot added size:M 30-99 changed lines (additions + deletions). and removed size:XS 0-9 changed lines (additions + deletions). labels Aug 9, 2026
@Lucenx9

Copy link
Copy Markdown
ContributorAuthor

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Breezy!

Reviewed commit:54e8fc3b5c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@Lucenx9

Copy link
Copy Markdown
ContributorAuthor

@codex review

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:9e51853128

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadapps/server/src/git/GitManager.ts Outdated
@Lucenx9

Copy link
Copy Markdown
ContributorAuthor

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. You're on a roll.

Reviewed commit:7b1ad6e860

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

macroscopeapp[bot]
macroscopeappBot previously approved these changes Aug 9, 2026
@Lucenx9Lucenx9 closed this Aug 14, 2026
@ben-vargas

Copy link
Copy Markdown
Contributor

Would be great to see this fixed, it's annoying seeing these errors for projects without a git remote (i.e. when using t3 more as a cowork agent than on a coding project).

@Lucenx9Lucenx9 reopened this Aug 26, 2026
@Lucenx9Lucenx9 closed this Aug 26, 2026
@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. and removed vouch:unvouched PR author is not yet trusted in the VOUCHED list. labels Aug 26, 2026
@Lucenx9Lucenx9 reopened this Aug 27, 2026
@macroscopeapp
macroscopeappBot dismissed their stale reviewAugust 27, 2026 03:15

Dismissing prior approval to re-evaluate c7bc695

@github-actionsgithub-actionsBot added size:L 100-499 changed lines (additions + deletions). and removed size:M 30-99 changed lines (additions + deletions). labels Aug 27, 2026
@Lucenx9

Copy link
Copy Markdown
ContributorAuthor

Updated this PR onto the current main branch. The conflict resolution preserves the default-branch cache key and inherited-upstream guard added by #7317 while carrying the unknown-provider outcome through those paths.

Local verification:

  • vp test run apps/server/src/git/GitManager.test.ts (91 passed)
  • vp lint --report-unused-disable-directives apps/server/src/git/GitManager.ts apps/server/src/git/GitManager.test.ts
  • vp fmt --check apps/server/src/git/GitManager.ts apps/server/src/git/GitManager.test.ts
  • vp run --filter t3 typecheck

@Lucenx9Lucenx9 closed this Aug 27, 2026
@Lucenx9Lucenx9 reopened this Aug 27, 2026
@github-actionsgithub-actionsBot added size:M 30-99 changed lines (additions + deletions). and removed size:L 100-499 changed lines (additions + deletions). labels Aug 27, 2026
@Lucenx9Lucenx9 closed this Aug 29, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M30-99 changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@Lucenx9@ben-vargas
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' fix(server): skip PR lookup for unknown providers by Lucenx9 · Pull Request #5831 · pingdotgg/t3code · GitHub
Skip to content

fix(server): skip PR lookup for unknown providers - #5831

Closed
Lucenx9 wants to merge 5 commits into
pingdotgg:mainfrom
Lucenx9:fix/skip-pr-lookup-without-remote
Closed

fix(server): skip PR lookup for unknown providers#5831
Lucenx9 wants to merge 5 commits into
pingdotgg:mainfrom
Lucenx9:fix/skip-pr-lookup-without-remote

Conversation

@Lucenx9

@Lucenx9Lucenx9 commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

Problem

Repositories without a recognized source-control remote still attempted PR metadata lookups during status refreshes. The provider registry returned the unsupported unknown provider, so each lookup failed and emitted repeated findLatestPrForHeadContext and PR lookup failed trace entries.

Fix

Resolve the source-control provider once per PR lookup and return a tagged, non-definitive result before calling listChangeRequests when its kind is unknown. That result starts on the short 20-second cache cadence, then follows the existing exponential backoff while provider detection remains non-definitive, capped at the healthy two-minute PR lookup cadence, and falls back to the last known PR instead of overwriting it. A definitive result clears the streak; known providers keep the existing lookup behavior. Focused regression tests cover repositories without remotes, provider refinement after the first short TTL, preserving backoff across a detection hiccup, and preserving an existing PR badge.

Testing

  • node_modules/.bin/vp test run apps/server/src/git/GitManager.test.ts (78 passed)
  • node_modules/.bin/vp lint --report-unused-disable-directives apps/server/src/git/GitManager.ts apps/server/src/git/GitManager.test.ts
  • node_modules/.bin/vp fmt --check apps/server/src/git/GitManager.ts apps/server/src/git/GitManager.test.ts
  • node_modules/.bin/vp run --filter t3 typecheck

Model: GPT-5.6 Sol
Harness: Codex in T3 Code


Note

Low Risk
Scoped to git status PR metadata caching and lookup gating; behavior for known providers is unchanged aside from clearer outcome tagging.

Overview
Git status no longer calls hosting APIs when the source-control provider is unresolved, avoiding repeated failed listChangeRequests lookups for repos without a recognized remote.

GitManager now models PR lookup results with a PrLookupOutcome (Complete vs ProviderUnknown). When the resolved provider kind is unknown, findLatestPrForHeadContext returns ProviderUnknown immediately instead of hitting gh/similar. lookupStatusPr keeps showing the last known PR on that outcome rather than clearing the badge, and the PR lookup cache treats ProviderUnknown like a non-definitive attempt: short retry cadence with existing failure backoff, capped at the normal healthy lookup interval. Definitive Complete results still use the standard TTL and clear the failure streak.

Tests extend makeManager with a configurable provider kind and add coverage for no-remote repos, provider refinement after backoff, backoff preservation across detection hiccups, and sticky PR display while the provider is temporarily unknown.

Reviewed by Cursor Bugbot for commit c7bc695. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Skip PR lookup API calls for unknown providers in GitManager

  • Adds PrLookupOutcome discriminated union (Complete | ProviderUnknown) so the cache can distinguish a definitive PR result from an unresolved provider state
  • findLatestPrForHeadContext now returns ProviderUnknown early when provider.kind is "unknown", avoiding any listChangeRequests calls
  • Cache TTL for unknown-provider outcomes uses Duration.min(nextPrLookupFailureTtl, PR_LOOKUP_CACHE_TTL) and does not clear the failure streak; only definitive results reset the streak
  • lookupStatusPr returns the last known PR (via resolveLastKnownPr) when the provider is unknown, instead of attempting a provider call
  • Behavioral Change: the backoff streak in prLookupCache is no longer cleared on unknown-provider results, so repeated unknown states will continue to increase backoff up to the healthy TTL cap

Macroscope summarized c7bc695.

@coderabbitai

coderabbitaiBot commented Aug 9, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: ba460634-9444-469a-b4bb-002ccd50ffa9

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actionsgithub-actionsBot added size:XS 0-9 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list. labels Aug 9, 2026

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:bbb1467018

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadapps/server/src/git/GitManager.ts Outdated

@cursorcursorBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit bbb1467. Configure here.

Comment threadapps/server/src/git/GitManager.ts
@macroscopeapp

macroscopeappBot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at c7bc695

Macroscope's review found this PR approvable — This is a focused GitManager bug fix that suppresses guaranteed PR API failures for unknown providers while preserving known behavior and last-known status. The localized production change is supported by targeted regression tests and introduces no schema, security, billing, or deployment impact.

You can add or adjust custom eligibility rules. Learn more.

@github-actionsgithub-actionsBot added size:M 30-99 changed lines (additions + deletions). and removed size:XS 0-9 changed lines (additions + deletions). labels Aug 9, 2026
@Lucenx9

Copy link
Copy Markdown
ContributorAuthor

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Breezy!

Reviewed commit:54e8fc3b5c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@Lucenx9

Copy link
Copy Markdown
ContributorAuthor

@codex review

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:9e51853128

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadapps/server/src/git/GitManager.ts Outdated
@Lucenx9

Copy link
Copy Markdown
ContributorAuthor

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. You're on a roll.

Reviewed commit:7b1ad6e860

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

macroscopeapp[bot]
macroscopeappBot previously approved these changes Aug 9, 2026
@Lucenx9Lucenx9 closed this Aug 14, 2026
@ben-vargas

Copy link
Copy Markdown
Contributor

Would be great to see this fixed, it's annoying seeing these errors for projects without a git remote (i.e. when using t3 more as a cowork agent than on a coding project).

@Lucenx9Lucenx9 reopened this Aug 26, 2026
@Lucenx9Lucenx9 closed this Aug 26, 2026
@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. and removed vouch:unvouched PR author is not yet trusted in the VOUCHED list. labels Aug 26, 2026
@Lucenx9Lucenx9 reopened this Aug 27, 2026
@macroscopeapp
macroscopeappBot dismissed their stale reviewAugust 27, 2026 03:15

Dismissing prior approval to re-evaluate c7bc695

@github-actionsgithub-actionsBot added size:L 100-499 changed lines (additions + deletions). and removed size:M 30-99 changed lines (additions + deletions). labels Aug 27, 2026
@Lucenx9

Copy link
Copy Markdown
ContributorAuthor

Updated this PR onto the current main branch. The conflict resolution preserves the default-branch cache key and inherited-upstream guard added by #7317 while carrying the unknown-provider outcome through those paths.

Local verification:

  • vp test run apps/server/src/git/GitManager.test.ts (91 passed)
  • vp lint --report-unused-disable-directives apps/server/src/git/GitManager.ts apps/server/src/git/GitManager.test.ts
  • vp fmt --check apps/server/src/git/GitManager.ts apps/server/src/git/GitManager.test.ts
  • vp run --filter t3 typecheck

@Lucenx9Lucenx9 closed this Aug 27, 2026
@Lucenx9Lucenx9 reopened this Aug 27, 2026
@github-actionsgithub-actionsBot added size:M 30-99 changed lines (additions + deletions). and removed size:L 100-499 changed lines (additions + deletions). labels Aug 27, 2026
@Lucenx9Lucenx9 closed this Aug 29, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M30-99 changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@Lucenx9@ben-vargas
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' fix(server): skip PR lookup for unknown providers by Lucenx9 · Pull Request #5831 · pingdotgg/t3code · GitHub
Skip to content

fix(server): skip PR lookup for unknown providers - #5831

Closed
Lucenx9 wants to merge 5 commits into
pingdotgg:mainfrom
Lucenx9:fix/skip-pr-lookup-without-remote
Closed

fix(server): skip PR lookup for unknown providers#5831
Lucenx9 wants to merge 5 commits into
pingdotgg:mainfrom
Lucenx9:fix/skip-pr-lookup-without-remote

Conversation

@Lucenx9

@Lucenx9Lucenx9 commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

Problem

Repositories without a recognized source-control remote still attempted PR metadata lookups during status refreshes. The provider registry returned the unsupported unknown provider, so each lookup failed and emitted repeated findLatestPrForHeadContext and PR lookup failed trace entries.

Fix

Resolve the source-control provider once per PR lookup and return a tagged, non-definitive result before calling listChangeRequests when its kind is unknown. That result starts on the short 20-second cache cadence, then follows the existing exponential backoff while provider detection remains non-definitive, capped at the healthy two-minute PR lookup cadence, and falls back to the last known PR instead of overwriting it. A definitive result clears the streak; known providers keep the existing lookup behavior. Focused regression tests cover repositories without remotes, provider refinement after the first short TTL, preserving backoff across a detection hiccup, and preserving an existing PR badge.

Testing

  • node_modules/.bin/vp test run apps/server/src/git/GitManager.test.ts (78 passed)
  • node_modules/.bin/vp lint --report-unused-disable-directives apps/server/src/git/GitManager.ts apps/server/src/git/GitManager.test.ts
  • node_modules/.bin/vp fmt --check apps/server/src/git/GitManager.ts apps/server/src/git/GitManager.test.ts
  • node_modules/.bin/vp run --filter t3 typecheck

Model: GPT-5.6 Sol
Harness: Codex in T3 Code


Note

Low Risk
Scoped to git status PR metadata caching and lookup gating; behavior for known providers is unchanged aside from clearer outcome tagging.

Overview
Git status no longer calls hosting APIs when the source-control provider is unresolved, avoiding repeated failed listChangeRequests lookups for repos without a recognized remote.

GitManager now models PR lookup results with a PrLookupOutcome (Complete vs ProviderUnknown). When the resolved provider kind is unknown, findLatestPrForHeadContext returns ProviderUnknown immediately instead of hitting gh/similar. lookupStatusPr keeps showing the last known PR on that outcome rather than clearing the badge, and the PR lookup cache treats ProviderUnknown like a non-definitive attempt: short retry cadence with existing failure backoff, capped at the normal healthy lookup interval. Definitive Complete results still use the standard TTL and clear the failure streak.

Tests extend makeManager with a configurable provider kind and add coverage for no-remote repos, provider refinement after backoff, backoff preservation across detection hiccups, and sticky PR display while the provider is temporarily unknown.

Reviewed by Cursor Bugbot for commit c7bc695. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Skip PR lookup API calls for unknown providers in GitManager

  • Adds PrLookupOutcome discriminated union (Complete | ProviderUnknown) so the cache can distinguish a definitive PR result from an unresolved provider state
  • findLatestPrForHeadContext now returns ProviderUnknown early when provider.kind is "unknown", avoiding any listChangeRequests calls
  • Cache TTL for unknown-provider outcomes uses Duration.min(nextPrLookupFailureTtl, PR_LOOKUP_CACHE_TTL) and does not clear the failure streak; only definitive results reset the streak
  • lookupStatusPr returns the last known PR (via resolveLastKnownPr) when the provider is unknown, instead of attempting a provider call
  • Behavioral Change: the backoff streak in prLookupCache is no longer cleared on unknown-provider results, so repeated unknown states will continue to increase backoff up to the healthy TTL cap

Macroscope summarized c7bc695.

@coderabbitai

coderabbitaiBot commented Aug 9, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: ba460634-9444-469a-b4bb-002ccd50ffa9

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actionsgithub-actionsBot added size:XS 0-9 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list. labels Aug 9, 2026

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:bbb1467018

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadapps/server/src/git/GitManager.ts Outdated

@cursorcursorBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit bbb1467. Configure here.

Comment threadapps/server/src/git/GitManager.ts
@macroscopeapp

macroscopeappBot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at c7bc695

Macroscope's review found this PR approvable — This is a focused GitManager bug fix that suppresses guaranteed PR API failures for unknown providers while preserving known behavior and last-known status. The localized production change is supported by targeted regression tests and introduces no schema, security, billing, or deployment impact.

You can add or adjust custom eligibility rules. Learn more.

@github-actionsgithub-actionsBot added size:M 30-99 changed lines (additions + deletions). and removed size:XS 0-9 changed lines (additions + deletions). labels Aug 9, 2026
@Lucenx9

Copy link
Copy Markdown
ContributorAuthor

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Breezy!

Reviewed commit:54e8fc3b5c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@Lucenx9

Copy link
Copy Markdown
ContributorAuthor

@codex review

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:9e51853128

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadapps/server/src/git/GitManager.ts Outdated
@Lucenx9

Copy link
Copy Markdown
ContributorAuthor

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. You're on a roll.

Reviewed commit:7b1ad6e860

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

macroscopeapp[bot]
macroscopeappBot previously approved these changes Aug 9, 2026
@Lucenx9Lucenx9 closed this Aug 14, 2026
@ben-vargas

Copy link
Copy Markdown
Contributor

Would be great to see this fixed, it's annoying seeing these errors for projects without a git remote (i.e. when using t3 more as a cowork agent than on a coding project).

@Lucenx9Lucenx9 reopened this Aug 26, 2026
@Lucenx9Lucenx9 closed this Aug 26, 2026
@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. and removed vouch:unvouched PR author is not yet trusted in the VOUCHED list. labels Aug 26, 2026
@Lucenx9Lucenx9 reopened this Aug 27, 2026
@macroscopeapp
macroscopeappBot dismissed their stale reviewAugust 27, 2026 03:15

Dismissing prior approval to re-evaluate c7bc695

@github-actionsgithub-actionsBot added size:L 100-499 changed lines (additions + deletions). and removed size:M 30-99 changed lines (additions + deletions). labels Aug 27, 2026
@Lucenx9

Copy link
Copy Markdown
ContributorAuthor

Updated this PR onto the current main branch. The conflict resolution preserves the default-branch cache key and inherited-upstream guard added by #7317 while carrying the unknown-provider outcome through those paths.

Local verification:

  • vp test run apps/server/src/git/GitManager.test.ts (91 passed)
  • vp lint --report-unused-disable-directives apps/server/src/git/GitManager.ts apps/server/src/git/GitManager.test.ts
  • vp fmt --check apps/server/src/git/GitManager.ts apps/server/src/git/GitManager.test.ts
  • vp run --filter t3 typecheck

@Lucenx9Lucenx9 closed this Aug 27, 2026
@Lucenx9Lucenx9 reopened this Aug 27, 2026
@github-actionsgithub-actionsBot added size:M 30-99 changed lines (additions + deletions). and removed size:L 100-499 changed lines (additions + deletions). labels Aug 27, 2026
@Lucenx9Lucenx9 closed this Aug 29, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M30-99 changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@Lucenx9@ben-vargas
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })(); fix(server): skip PR lookup for unknown providers by Lucenx9 · Pull Request #5831 · pingdotgg/t3code · GitHub
Skip to content

fix(server): skip PR lookup for unknown providers - #5831

Closed
Lucenx9 wants to merge 5 commits into
pingdotgg:mainfrom
Lucenx9:fix/skip-pr-lookup-without-remote
Closed

fix(server): skip PR lookup for unknown providers#5831
Lucenx9 wants to merge 5 commits into
pingdotgg:mainfrom
Lucenx9:fix/skip-pr-lookup-without-remote

Conversation

@Lucenx9

@Lucenx9Lucenx9 commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

Problem

Repositories without a recognized source-control remote still attempted PR metadata lookups during status refreshes. The provider registry returned the unsupported unknown provider, so each lookup failed and emitted repeated findLatestPrForHeadContext and PR lookup failed trace entries.

Fix

Resolve the source-control provider once per PR lookup and return a tagged, non-definitive result before calling listChangeRequests when its kind is unknown. That result starts on the short 20-second cache cadence, then follows the existing exponential backoff while provider detection remains non-definitive, capped at the healthy two-minute PR lookup cadence, and falls back to the last known PR instead of overwriting it. A definitive result clears the streak; known providers keep the existing lookup behavior. Focused regression tests cover repositories without remotes, provider refinement after the first short TTL, preserving backoff across a detection hiccup, and preserving an existing PR badge.

Testing

  • node_modules/.bin/vp test run apps/server/src/git/GitManager.test.ts (78 passed)
  • node_modules/.bin/vp lint --report-unused-disable-directives apps/server/src/git/GitManager.ts apps/server/src/git/GitManager.test.ts
  • node_modules/.bin/vp fmt --check apps/server/src/git/GitManager.ts apps/server/src/git/GitManager.test.ts
  • node_modules/.bin/vp run --filter t3 typecheck

Model: GPT-5.6 Sol
Harness: Codex in T3 Code


Note

Low Risk
Scoped to git status PR metadata caching and lookup gating; behavior for known providers is unchanged aside from clearer outcome tagging.

Overview
Git status no longer calls hosting APIs when the source-control provider is unresolved, avoiding repeated failed listChangeRequests lookups for repos without a recognized remote.

GitManager now models PR lookup results with a PrLookupOutcome (Complete vs ProviderUnknown). When the resolved provider kind is unknown, findLatestPrForHeadContext returns ProviderUnknown immediately instead of hitting gh/similar. lookupStatusPr keeps showing the last known PR on that outcome rather than clearing the badge, and the PR lookup cache treats ProviderUnknown like a non-definitive attempt: short retry cadence with existing failure backoff, capped at the normal healthy lookup interval. Definitive Complete results still use the standard TTL and clear the failure streak.

Tests extend makeManager with a configurable provider kind and add coverage for no-remote repos, provider refinement after backoff, backoff preservation across detection hiccups, and sticky PR display while the provider is temporarily unknown.

Reviewed by Cursor Bugbot for commit c7bc695. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Skip PR lookup API calls for unknown providers in GitManager

  • Adds PrLookupOutcome discriminated union (Complete | ProviderUnknown) so the cache can distinguish a definitive PR result from an unresolved provider state
  • findLatestPrForHeadContext now returns ProviderUnknown early when provider.kind is "unknown", avoiding any listChangeRequests calls
  • Cache TTL for unknown-provider outcomes uses Duration.min(nextPrLookupFailureTtl, PR_LOOKUP_CACHE_TTL) and does not clear the failure streak; only definitive results reset the streak
  • lookupStatusPr returns the last known PR (via resolveLastKnownPr) when the provider is unknown, instead of attempting a provider call
  • Behavioral Change: the backoff streak in prLookupCache is no longer cleared on unknown-provider results, so repeated unknown states will continue to increase backoff up to the healthy TTL cap

Macroscope summarized c7bc695.

@coderabbitai

coderabbitaiBot commented Aug 9, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: ba460634-9444-469a-b4bb-002ccd50ffa9

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actionsgithub-actionsBot added size:XS 0-9 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list. labels Aug 9, 2026

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:bbb1467018

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadapps/server/src/git/GitManager.ts Outdated

@cursorcursorBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit bbb1467. Configure here.

Comment threadapps/server/src/git/GitManager.ts
@macroscopeapp

macroscopeappBot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at c7bc695

Macroscope's review found this PR approvable — This is a focused GitManager bug fix that suppresses guaranteed PR API failures for unknown providers while preserving known behavior and last-known status. The localized production change is supported by targeted regression tests and introduces no schema, security, billing, or deployment impact.

You can add or adjust custom eligibility rules. Learn more.

@github-actionsgithub-actionsBot added size:M 30-99 changed lines (additions + deletions). and removed size:XS 0-9 changed lines (additions + deletions). labels Aug 9, 2026
@Lucenx9

Copy link
Copy Markdown
ContributorAuthor

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Breezy!

Reviewed commit:54e8fc3b5c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@Lucenx9

Copy link
Copy Markdown
ContributorAuthor

@codex review

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:9e51853128

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadapps/server/src/git/GitManager.ts Outdated
@Lucenx9

Copy link
Copy Markdown
ContributorAuthor

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. You're on a roll.

Reviewed commit:7b1ad6e860

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

macroscopeapp[bot]
macroscopeappBot previously approved these changes Aug 9, 2026
@Lucenx9Lucenx9 closed this Aug 14, 2026
@ben-vargas

Copy link
Copy Markdown
Contributor

Would be great to see this fixed, it's annoying seeing these errors for projects without a git remote (i.e. when using t3 more as a cowork agent than on a coding project).

@Lucenx9Lucenx9 reopened this Aug 26, 2026
@Lucenx9Lucenx9 closed this Aug 26, 2026
@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. and removed vouch:unvouched PR author is not yet trusted in the VOUCHED list. labels Aug 26, 2026
@Lucenx9Lucenx9 reopened this Aug 27, 2026
@macroscopeapp
macroscopeappBot dismissed their stale reviewAugust 27, 2026 03:15

Dismissing prior approval to re-evaluate c7bc695

@github-actionsgithub-actionsBot added size:L 100-499 changed lines (additions + deletions). and removed size:M 30-99 changed lines (additions + deletions). labels Aug 27, 2026
@Lucenx9

Copy link
Copy Markdown
ContributorAuthor

Updated this PR onto the current main branch. The conflict resolution preserves the default-branch cache key and inherited-upstream guard added by #7317 while carrying the unknown-provider outcome through those paths.

Local verification:

  • vp test run apps/server/src/git/GitManager.test.ts (91 passed)
  • vp lint --report-unused-disable-directives apps/server/src/git/GitManager.ts apps/server/src/git/GitManager.test.ts
  • vp fmt --check apps/server/src/git/GitManager.ts apps/server/src/git/GitManager.test.ts
  • vp run --filter t3 typecheck

@Lucenx9Lucenx9 closed this Aug 27, 2026
@Lucenx9Lucenx9 reopened this Aug 27, 2026
@github-actionsgithub-actionsBot added size:M 30-99 changed lines (additions + deletions). and removed size:L 100-499 changed lines (additions + deletions). labels Aug 27, 2026
@Lucenx9Lucenx9 closed this Aug 29, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M30-99 changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@Lucenx9@ben-vargas