Uh oh!
There was an error while loading. Please reload this page.
fix(desktop): select the WSL route source address - #5889
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
393fd11 to
6fd70acCompareCDVolvik
commented
Aug 10, 2026
Verified on Windows 11, Node 24: 38/38 pass on this branch. Reverting only This is unit-level only. I did not run the packaged app against a real WSL distro, so I can't confirm the end-to-end Docker-bridge case from #5211. |
CDVolvik
left a comment
There was a problem hiding this comment.
Re-verified on Ubuntu WSL (this machine, 2026-08-15).
DesktopWslEnvironment.test.ts: 38/38 on the PR. Replacing the source with origin/main fails 10/38 — all is not a function, because getDistroIpImpl / parseWslRouteSource / parseSingleWslHostnameAddress do not exist on main. That proves the tests are new. It does not prove they catch a wrong-address pick in the old hostname -I path.
Live on this distro the two answers agree:
ip -4 route get 1.1.1.1 → src 172.25.119.119
hostname -I → 172.25.119.119
Only one address, so the Docker-bridge ordering bug does not reproduce here (Docker Desktop is a separate distro). The parser tests still look right: exact src token, reject prefsrc, reject a multi-address fallback.
The fallback-to-none when hostname -I is ambiguous is the part I would keep even if the route lookup stays.
Previous unit pass on 8/10 still holds.
What Changed
ip -4 route get 1.1.1.1instead of assuming the firsthostname -Iaddress is reachable.srctoken with strict IPv4 octet validation.hostname -Ionly when it yields exactly one valid IPv4 address; ambiguous Docker-bridge output now returns no address rather than guessing.ip, invalid octets, ambiguous fallback, and timeout behavior.Why
hostname -Ienumerates addresses from every interface without a stable reachability order. With Docker running inside a mirrored WSL distro, bridge addresses can precede the route-selected host address, causing the desktop to poll an unreachable bridge indefinitely.Asking the kernel for its preferred route source avoids interface-order assumptions without hardcoding Docker or RFC1918 ranges.
Closes#5211.
Validation
vp test run apps/desktop/src/wsl/DesktopWslEnvironment.test.ts— 38 passedvp test run apps/desktop/src/backend/DesktopBackendConfiguration.test.ts -t "resolveWsl preserves existing WSLENV entries when forwarding backend secrets"— 1 passedvp run --filter @t3tools/desktop typecheckvp lint apps/desktop/src/wsl/DesktopWslEnvironment.ts apps/desktop/src/wsl/DesktopWslEnvironment.test.ts --report-unused-disable-directivesvp fmt --check apps/desktop/src/wsl/DesktopWslEnvironment.ts apps/desktop/src/wsl/DesktopWslEnvironment.test.tsgit diff --check origin/main...HEADsrc 172.20.42.37, matching the parser contract.The local manual check used default WSL NAT. The reporter's exact mirrored-networking-plus-in-distro-Docker topology remains the external acceptance boundary.
Checklist
Note
Fix
getDistroIpImplto select the WSL route source address instead of hostnamegetDistroIpImplnow runsip -4 route get 1.1.1.1first and extracts thesrcfield via the newparseWslRouteSourcehelper, falling back tohostname -Ionly when the route command fails or returns a non-zero exit code.parseSingleWslHostnameAddressreplaces the previous loose regex, accepting the fallback only whenhostname -Ireturns exactly one valid IPv4 address.isIpv4Address(checks each octet ≤255) instead of a regex pattern.USER_HOME_TIMEOUTtoDISTRO_IP_TIMEOUT(5 seconds).hostname -Iwas accepted; now multiple addresses fromhostname -Iyieldnone, and non-zero exit codes or spawn errors also yieldnone.Macroscope summarized 34a6876.