feat(swift-ios): mark debug threads with warning chrome - #5972

Closed
saphid wants to merge 10 commits into
pingdotgg:t3code/rebuild-mobile-app-swiftfrom
saphid:saphid/swiftui-debug-title-v2
Closed

feat(swift-ios): mark debug threads with warning chrome#5972
saphid wants to merge 10 commits into
pingdotgg:t3code/rebuild-mobile-app-swiftfrom
saphid:saphid/swiftui-debug-title-v2

Conversation

@saphid

@saphidsaphid commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Summary

Uses the adaptive warning color for the navigation title bar of thread screens in DEBUG builds only, making development threads visually unmistakable without changing release builds.

Verification

  • apps/swift-ios/Scripts/ci-test.sh — 218 tests passed
  • Fresh independent Claude Opus 5 high review completed; all actionable findings were addressed and the final repair review found no blockers.
  • Simulator visual evidence will be attached before marking this PR ready for review.

Scope

Targets the active native SwiftUI owner branch (#5178).

Note

Mark debug build navigation bars with warning-themed chrome on Home, New Task, and Thread screens

  • Adds a T3BuildChrome utility in T3Theme.swift that selects warning background/foreground colors, toolbar color scheme, content opacity, and accessibility values based on whether the current build is a debug build.
  • Applies the new chrome to the Home (WorkspaceView), New Task (NewThreadView), and Thread (ThreadDetailView) surfaces via new view modifiers t3BuildNavigationChrome, t3BuildChromeBackground, and t3BuildChromeMarker.
  • Adds a warning(for:) helper that resolves the adaptive UIColor warning color for a specific ColorScheme, backing the toolbar background in dark/light mode.
  • Adds DebugBuildChromeTests covering presentation, accessibility values, toolbar color scheme, and foreground/background selection for all three surfaces.
  • Release builds retain their existing appearance with no code-path changes at runtime.

Macroscope summarized a488a3d.


Note

Low Risk
UI-only Debug presentation changes gated by compile-time flags; Release chrome and behavior are unaffected.

Overview
Debug builds now show adaptive warning chrome on Home, New Task, and Thread bars so development builds are visually unmistakable. Release builds are unchanged.

Adds T3BuildChrome with per-surface helpers for warning backgrounds, foregrounds, toolbar color scheme, opacity, and accessibility markers. Wires those helpers into WorkspaceView, NewThreadView, and ThreadDetailView.

Includes contrast-checked warning colors plus unit tests covering debug vs release presentation.

Reviewed by Cursor Bugbot for commit a488a3d. Bugbot is set up for automated code reviews on this repo. Configure here.

Delivery: direct
Validated against Theo commit: f98cab5
Depends on: none
Merge order: this PR only
Validation status: Green at a488a3d against Theo f98cab5: contract fixture generation, 8 focused native tests, exact-head Simulator build/launch, Contract fixtures and native tests, CI Test/Check, Mobile Native Static Analysis, and Release Smoke passed. APPROVED and MERGEABLE. Independent Claude Opus 5 high review launcher exited 1 because session quota was exhausted, so no cross-provider review occurred. Unrelated Vercel marketing authorization remains maintainer-side.

@coderabbitai

coderabbitaiBot commented Aug 10, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 9df61fc9-3cee-4326-9808-f3362fc72c64

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Aug 10, 2026
@saphid

Copy link
Copy Markdown
ContributorAuthor

Simulator evidence from the integrated approved Debug build:

Orange Debug title bar on home

Orange Debug title bar in a live thread

Verified on iOS 26.5 across home, new-thread, and live-thread routes.

@saphid
saphid marked this pull request as ready for review August 10, 2026 09:27
Comment threadapps/swift-ios/Features/Chat/ThreadDetailView.swift Outdated
macroscopeapp[bot]
macroscopeappBot previously approved these changes Aug 10, 2026
@macroscopeapp

macroscopeappBot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Needs human review

This PR introduces a new debug-build visual indicator system with new abstractions (T3BuildChrome enum, view modifiers) applied across multiple UI surfaces. While well-scoped to DEBUG builds with comprehensive tests, the new feature introduces user-facing visual behavior and cross-cutting changes that warrant human review.

You can customize Macroscope's approvability policy. Learn more.

@macroscopeapp
macroscopeappBot dismissed their stale reviewAugust 10, 2026 10:20

Dismissing prior approval to re-evaluate 826af68

@github-actionsgithub-actionsBot added size:M 30-99 changed lines (additions + deletions). and removed size:XS 0-9 changed lines (additions + deletions). labels Aug 10, 2026
Comment threadapps/swift-ios/Features/Chat/ThreadDetailView.swift Outdated
macroscopeapp[bot]
macroscopeappBot previously approved these changes Aug 10, 2026
@saphid

Copy link
Copy Markdown
ContributorAuthor

Dark-mode simulator verification

Debug thread title bar in dark appearance

Built and launched the integrated personal/swiftui-approved Debug app on iOS Simulator 3565B63B-6AEE-4D1F-8EE8-F7697B4F9C46, paired it to a disposable backend, created a real Codex thread, and received OK. In dark appearance the orange bar keeps the back/menu/title controls black and the metadata/status readable. XcodeBuildMCP build-and-run succeeded.

@macroscopeapp
macroscopeappBot dismissed their stale reviewAugust 10, 2026 10:47

Dismissing prior approval to re-evaluate 29e4bcd

@cursorcursorBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 29e4bcdb2e706593dd51416e11cf876be1f04a9d. Configure here.

Comment threadapps/swift-ios/Features/Chat/ThreadDetailView.swift Outdated
macroscopeapp[bot]
macroscopeappBot previously approved these changes Aug 10, 2026
@saphid

Copy link
Copy Markdown
ContributorAuthor

Rebuilt on the exact current Theo SwiftUI head (5b7ee58f6) before final handoff; the unrelated historical CI-retry commit was removed.

Final verification on exact PR result:

  • 226/226 native tests across 29 suites
  • explicit arm64 Release simulator build: BUILD SUCCEEDED
  • Debug integrated Home, New Task, and Thread proof in light/dark
  • semantic non-color Debug markers scoped to the intended title controls
  • git diff --check clean
  • fresh direct Claude Opus 5 high review of the rebased frozen diff: exit 0, MERGE-READY, no actionable findings

The reviewer also confirmed no path overlap with Theo's newer usage work and no build/release overlap. The shared Debug policy is adaptive; Release uses normal chrome.

@saphid
saphidforce-pushed the saphid/swiftui-debug-title-v2 branch from 29e4bcd to ef66325CompareAugust 10, 2026 12:06
@macroscopeapp
macroscopeappBot dismissed their stale reviewAugust 10, 2026 12:06

Dismissing prior approval to re-evaluate ef66325

@github-actionsgithub-actionsBot added size:L 100-499 changed lines (additions + deletions). and removed size:M 30-99 changed lines (additions + deletions). labels Aug 10, 2026
@saphid

Copy link
Copy Markdown
ContributorAuthor

Final connected simulator verification on exact head ef663259d (iPhone simulator, dark appearance):

  • Full native XCTest suite: passed.
  • Paired to a disposable backend built from the same PR worktree.
  • Created and settled a real thread, then reopened it.
  • Verified the orange debug chrome on home and thread; black system back/title/menu controls remain legible, while the composer and working-state accent remain cyan.

Connected home:

Connected dark home debug chrome

Thread detail:

Dark thread debug chrome with composer

@saphid
saphidforce-pushed the saphid/swiftui-debug-title-v2 branch from ef66325 to 47bebfdCompareAugust 11, 2026 10:26
macroscopeapp[bot]
macroscopeappBot previously approved these changes Aug 11, 2026
@saphid

saphid commented Aug 11, 2026

Copy link
Copy Markdown
ContributorAuthor

Exact final-head simulator proof (47bebfd): warning chrome and the system back chevron remain clearly legible after removing the overly broad tint scope.

HomeThread
Home chromeThread chrome

Focused DebugBuildChromeTests passed (3/3). The current native-CI red is the base-branch provider-catalog fixture failure fixed separately in #6130.

t3-code[bot]
t3-codeBot approved these changes Aug 12, 2026

@t3-codet3-codeBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed the debug warning chrome, scoped navigation color treatment, accessibility behavior, and regression coverage. no blocking code issues found. the current native-test red is the shared provider-catalog fixture failure addressed separately by #6130.

@macroscopeapp
macroscopeappBot dismissed their stale reviewAugust 12, 2026 12:24

Dismissing prior approval to re-evaluate a488a3d

@t3dotgg

Copy link
Copy Markdown
Member

Can you make it slightly less hideous? Like a fainter yellow

@saphid

Copy link
Copy Markdown
ContributorAuthor

Can you make it slightly less hideous? Like a fainter yellow

I've replaced it with
image

image

@saphid

Copy link
Copy Markdown
ContributorAuthor

Closing this version while I rebuild the upstream contribution set from the latest base. Clean versions are coming soon.

@saphidsaphid closed this Aug 15, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L100-499 changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@saphid@t3dotgg
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all \u003cpre\u003e\u003ccode\u003e blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks"); } } catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); } })(); (function(){ try { var __m = "github.com"; var __re = new RegExp('^' + "github\\.com" + '
Skip to content

feat(swift-ios): mark debug threads with warning chrome - #5972

Closed
saphid wants to merge 10 commits into
pingdotgg:t3code/rebuild-mobile-app-swiftfrom
saphid:saphid/swiftui-debug-title-v2
Closed

feat(swift-ios): mark debug threads with warning chrome#5972
saphid wants to merge 10 commits into
pingdotgg:t3code/rebuild-mobile-app-swiftfrom
saphid:saphid/swiftui-debug-title-v2

Conversation

@saphid

@saphidsaphid commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Summary

Uses the adaptive warning color for the navigation title bar of thread screens in DEBUG builds only, making development threads visually unmistakable without changing release builds.

Verification

  • apps/swift-ios/Scripts/ci-test.sh — 218 tests passed
  • Fresh independent Claude Opus 5 high review completed; all actionable findings were addressed and the final repair review found no blockers.
  • Simulator visual evidence will be attached before marking this PR ready for review.

Scope

Targets the active native SwiftUI owner branch (#5178).

Note

Mark debug build navigation bars with warning-themed chrome on Home, New Task, and Thread screens

  • Adds a T3BuildChrome utility in T3Theme.swift that selects warning background/foreground colors, toolbar color scheme, content opacity, and accessibility values based on whether the current build is a debug build.
  • Applies the new chrome to the Home (WorkspaceView), New Task (NewThreadView), and Thread (ThreadDetailView) surfaces via new view modifiers t3BuildNavigationChrome, t3BuildChromeBackground, and t3BuildChromeMarker.
  • Adds a warning(for:) helper that resolves the adaptive UIColor warning color for a specific ColorScheme, backing the toolbar background in dark/light mode.
  • Adds DebugBuildChromeTests covering presentation, accessibility values, toolbar color scheme, and foreground/background selection for all three surfaces.
  • Release builds retain their existing appearance with no code-path changes at runtime.

Macroscope summarized a488a3d.


Note

Low Risk
UI-only Debug presentation changes gated by compile-time flags; Release chrome and behavior are unaffected.

Overview
Debug builds now show adaptive warning chrome on Home, New Task, and Thread bars so development builds are visually unmistakable. Release builds are unchanged.

Adds T3BuildChrome with per-surface helpers for warning backgrounds, foregrounds, toolbar color scheme, opacity, and accessibility markers. Wires those helpers into WorkspaceView, NewThreadView, and ThreadDetailView.

Includes contrast-checked warning colors plus unit tests covering debug vs release presentation.

Reviewed by Cursor Bugbot for commit a488a3d. Bugbot is set up for automated code reviews on this repo. Configure here.

Delivery: direct
Validated against Theo commit: f98cab5
Depends on: none
Merge order: this PR only
Validation status: Green at a488a3d against Theo f98cab5: contract fixture generation, 8 focused native tests, exact-head Simulator build/launch, Contract fixtures and native tests, CI Test/Check, Mobile Native Static Analysis, and Release Smoke passed. APPROVED and MERGEABLE. Independent Claude Opus 5 high review launcher exited 1 because session quota was exhausted, so no cross-provider review occurred. Unrelated Vercel marketing authorization remains maintainer-side.

@coderabbitai

coderabbitaiBot commented Aug 10, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 9df61fc9-3cee-4326-9808-f3362fc72c64

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Aug 10, 2026
@saphid

Copy link
Copy Markdown
ContributorAuthor

Simulator evidence from the integrated approved Debug build:

Orange Debug title bar on home

Orange Debug title bar in a live thread

Verified on iOS 26.5 across home, new-thread, and live-thread routes.

@saphid
saphid marked this pull request as ready for review August 10, 2026 09:27
Comment threadapps/swift-ios/Features/Chat/ThreadDetailView.swift Outdated
macroscopeapp[bot]
macroscopeappBot previously approved these changes Aug 10, 2026
@macroscopeapp

macroscopeappBot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Needs human review

This PR introduces a new debug-build visual indicator system with new abstractions (T3BuildChrome enum, view modifiers) applied across multiple UI surfaces. While well-scoped to DEBUG builds with comprehensive tests, the new feature introduces user-facing visual behavior and cross-cutting changes that warrant human review.

You can customize Macroscope's approvability policy. Learn more.

@macroscopeapp
macroscopeappBot dismissed their stale reviewAugust 10, 2026 10:20

Dismissing prior approval to re-evaluate 826af68

@github-actionsgithub-actionsBot added size:M 30-99 changed lines (additions + deletions). and removed size:XS 0-9 changed lines (additions + deletions). labels Aug 10, 2026
Comment threadapps/swift-ios/Features/Chat/ThreadDetailView.swift Outdated
macroscopeapp[bot]
macroscopeappBot previously approved these changes Aug 10, 2026
@saphid

Copy link
Copy Markdown
ContributorAuthor

Dark-mode simulator verification

Debug thread title bar in dark appearance

Built and launched the integrated personal/swiftui-approved Debug app on iOS Simulator 3565B63B-6AEE-4D1F-8EE8-F7697B4F9C46, paired it to a disposable backend, created a real Codex thread, and received OK. In dark appearance the orange bar keeps the back/menu/title controls black and the metadata/status readable. XcodeBuildMCP build-and-run succeeded.

@macroscopeapp
macroscopeappBot dismissed their stale reviewAugust 10, 2026 10:47

Dismissing prior approval to re-evaluate 29e4bcd

@cursorcursorBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 29e4bcdb2e706593dd51416e11cf876be1f04a9d. Configure here.

Comment threadapps/swift-ios/Features/Chat/ThreadDetailView.swift Outdated
macroscopeapp[bot]
macroscopeappBot previously approved these changes Aug 10, 2026
@saphid

Copy link
Copy Markdown
ContributorAuthor

Rebuilt on the exact current Theo SwiftUI head (5b7ee58f6) before final handoff; the unrelated historical CI-retry commit was removed.

Final verification on exact PR result:

  • 226/226 native tests across 29 suites
  • explicit arm64 Release simulator build: BUILD SUCCEEDED
  • Debug integrated Home, New Task, and Thread proof in light/dark
  • semantic non-color Debug markers scoped to the intended title controls
  • git diff --check clean
  • fresh direct Claude Opus 5 high review of the rebased frozen diff: exit 0, MERGE-READY, no actionable findings

The reviewer also confirmed no path overlap with Theo's newer usage work and no build/release overlap. The shared Debug policy is adaptive; Release uses normal chrome.

@saphid
saphidforce-pushed the saphid/swiftui-debug-title-v2 branch from 29e4bcd to ef66325CompareAugust 10, 2026 12:06
@macroscopeapp
macroscopeappBot dismissed their stale reviewAugust 10, 2026 12:06

Dismissing prior approval to re-evaluate ef66325

@github-actionsgithub-actionsBot added size:L 100-499 changed lines (additions + deletions). and removed size:M 30-99 changed lines (additions + deletions). labels Aug 10, 2026
@saphid

Copy link
Copy Markdown
ContributorAuthor

Final connected simulator verification on exact head ef663259d (iPhone simulator, dark appearance):

  • Full native XCTest suite: passed.
  • Paired to a disposable backend built from the same PR worktree.
  • Created and settled a real thread, then reopened it.
  • Verified the orange debug chrome on home and thread; black system back/title/menu controls remain legible, while the composer and working-state accent remain cyan.

Connected home:

Connected dark home debug chrome

Thread detail:

Dark thread debug chrome with composer

@saphid
saphidforce-pushed the saphid/swiftui-debug-title-v2 branch from ef66325 to 47bebfdCompareAugust 11, 2026 10:26
macroscopeapp[bot]
macroscopeappBot previously approved these changes Aug 11, 2026
@saphid

saphid commented Aug 11, 2026

Copy link
Copy Markdown
ContributorAuthor

Exact final-head simulator proof (47bebfd): warning chrome and the system back chevron remain clearly legible after removing the overly broad tint scope.

HomeThread
Home chromeThread chrome

Focused DebugBuildChromeTests passed (3/3). The current native-CI red is the base-branch provider-catalog fixture failure fixed separately in #6130.

t3-code[bot]
t3-codeBot approved these changes Aug 12, 2026

@t3-codet3-codeBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed the debug warning chrome, scoped navigation color treatment, accessibility behavior, and regression coverage. no blocking code issues found. the current native-test red is the shared provider-catalog fixture failure addressed separately by #6130.

@macroscopeapp
macroscopeappBot dismissed their stale reviewAugust 12, 2026 12:24

Dismissing prior approval to re-evaluate a488a3d

@t3dotgg

Copy link
Copy Markdown
Member

Can you make it slightly less hideous? Like a fainter yellow

@saphid

Copy link
Copy Markdown
ContributorAuthor

Can you make it slightly less hideous? Like a fainter yellow

I've replaced it with
image

image

@saphid

Copy link
Copy Markdown
ContributorAuthor

Closing this version while I rebuild the upstream contribution set from the latest base. Clean versions are coming soon.

@saphidsaphid closed this Aug 15, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L100-499 changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@saphid@t3dotgg
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

feat(swift-ios): mark debug threads with warning chrome - #5972

Closed
saphid wants to merge 10 commits into
pingdotgg:t3code/rebuild-mobile-app-swiftfrom
saphid:saphid/swiftui-debug-title-v2
Closed

feat(swift-ios): mark debug threads with warning chrome#5972
saphid wants to merge 10 commits into
pingdotgg:t3code/rebuild-mobile-app-swiftfrom
saphid:saphid/swiftui-debug-title-v2

Conversation

@saphid

@saphidsaphid commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Summary

Uses the adaptive warning color for the navigation title bar of thread screens in DEBUG builds only, making development threads visually unmistakable without changing release builds.

Verification

  • apps/swift-ios/Scripts/ci-test.sh — 218 tests passed
  • Fresh independent Claude Opus 5 high review completed; all actionable findings were addressed and the final repair review found no blockers.
  • Simulator visual evidence will be attached before marking this PR ready for review.

Scope

Targets the active native SwiftUI owner branch (#5178).

Note

Mark debug build navigation bars with warning-themed chrome on Home, New Task, and Thread screens

  • Adds a T3BuildChrome utility in T3Theme.swift that selects warning background/foreground colors, toolbar color scheme, content opacity, and accessibility values based on whether the current build is a debug build.
  • Applies the new chrome to the Home (WorkspaceView), New Task (NewThreadView), and Thread (ThreadDetailView) surfaces via new view modifiers t3BuildNavigationChrome, t3BuildChromeBackground, and t3BuildChromeMarker.
  • Adds a warning(for:) helper that resolves the adaptive UIColor warning color for a specific ColorScheme, backing the toolbar background in dark/light mode.
  • Adds DebugBuildChromeTests covering presentation, accessibility values, toolbar color scheme, and foreground/background selection for all three surfaces.
  • Release builds retain their existing appearance with no code-path changes at runtime.

Macroscope summarized a488a3d.


Note

Low Risk
UI-only Debug presentation changes gated by compile-time flags; Release chrome and behavior are unaffected.

Overview
Debug builds now show adaptive warning chrome on Home, New Task, and Thread bars so development builds are visually unmistakable. Release builds are unchanged.

Adds T3BuildChrome with per-surface helpers for warning backgrounds, foregrounds, toolbar color scheme, opacity, and accessibility markers. Wires those helpers into WorkspaceView, NewThreadView, and ThreadDetailView.

Includes contrast-checked warning colors plus unit tests covering debug vs release presentation.

Reviewed by Cursor Bugbot for commit a488a3d. Bugbot is set up for automated code reviews on this repo. Configure here.

Delivery: direct
Validated against Theo commit: f98cab5
Depends on: none
Merge order: this PR only
Validation status: Green at a488a3d against Theo f98cab5: contract fixture generation, 8 focused native tests, exact-head Simulator build/launch, Contract fixtures and native tests, CI Test/Check, Mobile Native Static Analysis, and Release Smoke passed. APPROVED and MERGEABLE. Independent Claude Opus 5 high review launcher exited 1 because session quota was exhausted, so no cross-provider review occurred. Unrelated Vercel marketing authorization remains maintainer-side.

@coderabbitai

coderabbitaiBot commented Aug 10, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 9df61fc9-3cee-4326-9808-f3362fc72c64

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Aug 10, 2026
@saphid

Copy link
Copy Markdown
ContributorAuthor

Simulator evidence from the integrated approved Debug build:

Orange Debug title bar on home

Orange Debug title bar in a live thread

Verified on iOS 26.5 across home, new-thread, and live-thread routes.

@saphid
saphid marked this pull request as ready for review August 10, 2026 09:27
Comment threadapps/swift-ios/Features/Chat/ThreadDetailView.swift Outdated
macroscopeapp[bot]
macroscopeappBot previously approved these changes Aug 10, 2026
@macroscopeapp

macroscopeappBot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Needs human review

This PR introduces a new debug-build visual indicator system with new abstractions (T3BuildChrome enum, view modifiers) applied across multiple UI surfaces. While well-scoped to DEBUG builds with comprehensive tests, the new feature introduces user-facing visual behavior and cross-cutting changes that warrant human review.

You can customize Macroscope's approvability policy. Learn more.

@macroscopeapp
macroscopeappBot dismissed their stale reviewAugust 10, 2026 10:20

Dismissing prior approval to re-evaluate 826af68

@github-actionsgithub-actionsBot added size:M 30-99 changed lines (additions + deletions). and removed size:XS 0-9 changed lines (additions + deletions). labels Aug 10, 2026
Comment threadapps/swift-ios/Features/Chat/ThreadDetailView.swift Outdated
macroscopeapp[bot]
macroscopeappBot previously approved these changes Aug 10, 2026
@saphid

Copy link
Copy Markdown
ContributorAuthor

Dark-mode simulator verification

Debug thread title bar in dark appearance

Built and launched the integrated personal/swiftui-approved Debug app on iOS Simulator 3565B63B-6AEE-4D1F-8EE8-F7697B4F9C46, paired it to a disposable backend, created a real Codex thread, and received OK. In dark appearance the orange bar keeps the back/menu/title controls black and the metadata/status readable. XcodeBuildMCP build-and-run succeeded.

@macroscopeapp
macroscopeappBot dismissed their stale reviewAugust 10, 2026 10:47

Dismissing prior approval to re-evaluate 29e4bcd

@cursorcursorBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 29e4bcdb2e706593dd51416e11cf876be1f04a9d. Configure here.

Comment threadapps/swift-ios/Features/Chat/ThreadDetailView.swift Outdated
macroscopeapp[bot]
macroscopeappBot previously approved these changes Aug 10, 2026
@saphid

Copy link
Copy Markdown
ContributorAuthor

Rebuilt on the exact current Theo SwiftUI head (5b7ee58f6) before final handoff; the unrelated historical CI-retry commit was removed.

Final verification on exact PR result:

  • 226/226 native tests across 29 suites
  • explicit arm64 Release simulator build: BUILD SUCCEEDED
  • Debug integrated Home, New Task, and Thread proof in light/dark
  • semantic non-color Debug markers scoped to the intended title controls
  • git diff --check clean
  • fresh direct Claude Opus 5 high review of the rebased frozen diff: exit 0, MERGE-READY, no actionable findings

The reviewer also confirmed no path overlap with Theo's newer usage work and no build/release overlap. The shared Debug policy is adaptive; Release uses normal chrome.

@saphid
saphidforce-pushed the saphid/swiftui-debug-title-v2 branch from 29e4bcd to ef66325CompareAugust 10, 2026 12:06
@macroscopeapp
macroscopeappBot dismissed their stale reviewAugust 10, 2026 12:06

Dismissing prior approval to re-evaluate ef66325

@github-actionsgithub-actionsBot added size:L 100-499 changed lines (additions + deletions). and removed size:M 30-99 changed lines (additions + deletions). labels Aug 10, 2026
@saphid

Copy link
Copy Markdown
ContributorAuthor

Final connected simulator verification on exact head ef663259d (iPhone simulator, dark appearance):

  • Full native XCTest suite: passed.
  • Paired to a disposable backend built from the same PR worktree.
  • Created and settled a real thread, then reopened it.
  • Verified the orange debug chrome on home and thread; black system back/title/menu controls remain legible, while the composer and working-state accent remain cyan.

Connected home:

Connected dark home debug chrome

Thread detail:

Dark thread debug chrome with composer

@saphid
saphidforce-pushed the saphid/swiftui-debug-title-v2 branch from ef66325 to 47bebfdCompareAugust 11, 2026 10:26
macroscopeapp[bot]
macroscopeappBot previously approved these changes Aug 11, 2026
@saphid

saphid commented Aug 11, 2026

Copy link
Copy Markdown
ContributorAuthor

Exact final-head simulator proof (47bebfd): warning chrome and the system back chevron remain clearly legible after removing the overly broad tint scope.

HomeThread
Home chromeThread chrome

Focused DebugBuildChromeTests passed (3/3). The current native-CI red is the base-branch provider-catalog fixture failure fixed separately in #6130.

t3-code[bot]
t3-codeBot approved these changes Aug 12, 2026

@t3-codet3-codeBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed the debug warning chrome, scoped navigation color treatment, accessibility behavior, and regression coverage. no blocking code issues found. the current native-test red is the shared provider-catalog fixture failure addressed separately by #6130.

@macroscopeapp
macroscopeappBot dismissed their stale reviewAugust 12, 2026 12:24

Dismissing prior approval to re-evaluate a488a3d

@t3dotgg

Copy link
Copy Markdown
Member

Can you make it slightly less hideous? Like a fainter yellow

@saphid

Copy link
Copy Markdown
ContributorAuthor

Can you make it slightly less hideous? Like a fainter yellow

I've replaced it with
image

image

@saphid

Copy link
Copy Markdown
ContributorAuthor

Closing this version while I rebuild the upstream contribution set from the latest base. Clean versions are coming soon.

@saphidsaphid closed this Aug 15, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L100-499 changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@saphid@t3dotgg
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length \u003e 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

feat(swift-ios): mark debug threads with warning chrome - #5972

Closed
saphid wants to merge 10 commits into
pingdotgg:t3code/rebuild-mobile-app-swiftfrom
saphid:saphid/swiftui-debug-title-v2
Closed

feat(swift-ios): mark debug threads with warning chrome#5972
saphid wants to merge 10 commits into
pingdotgg:t3code/rebuild-mobile-app-swiftfrom
saphid:saphid/swiftui-debug-title-v2

Conversation

@saphid

@saphidsaphid commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Summary

Uses the adaptive warning color for the navigation title bar of thread screens in DEBUG builds only, making development threads visually unmistakable without changing release builds.

Verification

  • apps/swift-ios/Scripts/ci-test.sh — 218 tests passed
  • Fresh independent Claude Opus 5 high review completed; all actionable findings were addressed and the final repair review found no blockers.
  • Simulator visual evidence will be attached before marking this PR ready for review.

Scope

Targets the active native SwiftUI owner branch (#5178).

Note

Mark debug build navigation bars with warning-themed chrome on Home, New Task, and Thread screens

  • Adds a T3BuildChrome utility in T3Theme.swift that selects warning background/foreground colors, toolbar color scheme, content opacity, and accessibility values based on whether the current build is a debug build.
  • Applies the new chrome to the Home (WorkspaceView), New Task (NewThreadView), and Thread (ThreadDetailView) surfaces via new view modifiers t3BuildNavigationChrome, t3BuildChromeBackground, and t3BuildChromeMarker.
  • Adds a warning(for:) helper that resolves the adaptive UIColor warning color for a specific ColorScheme, backing the toolbar background in dark/light mode.
  • Adds DebugBuildChromeTests covering presentation, accessibility values, toolbar color scheme, and foreground/background selection for all three surfaces.
  • Release builds retain their existing appearance with no code-path changes at runtime.

Macroscope summarized a488a3d.


Note

Low Risk
UI-only Debug presentation changes gated by compile-time flags; Release chrome and behavior are unaffected.

Overview
Debug builds now show adaptive warning chrome on Home, New Task, and Thread bars so development builds are visually unmistakable. Release builds are unchanged.

Adds T3BuildChrome with per-surface helpers for warning backgrounds, foregrounds, toolbar color scheme, opacity, and accessibility markers. Wires those helpers into WorkspaceView, NewThreadView, and ThreadDetailView.

Includes contrast-checked warning colors plus unit tests covering debug vs release presentation.

Reviewed by Cursor Bugbot for commit a488a3d. Bugbot is set up for automated code reviews on this repo. Configure here.

Delivery: direct
Validated against Theo commit: f98cab5
Depends on: none
Merge order: this PR only
Validation status: Green at a488a3d against Theo f98cab5: contract fixture generation, 8 focused native tests, exact-head Simulator build/launch, Contract fixtures and native tests, CI Test/Check, Mobile Native Static Analysis, and Release Smoke passed. APPROVED and MERGEABLE. Independent Claude Opus 5 high review launcher exited 1 because session quota was exhausted, so no cross-provider review occurred. Unrelated Vercel marketing authorization remains maintainer-side.

@coderabbitai

coderabbitaiBot commented Aug 10, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 9df61fc9-3cee-4326-9808-f3362fc72c64

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Aug 10, 2026
@saphid

Copy link
Copy Markdown
ContributorAuthor

Simulator evidence from the integrated approved Debug build:

Orange Debug title bar on home

Orange Debug title bar in a live thread

Verified on iOS 26.5 across home, new-thread, and live-thread routes.

@saphid
saphid marked this pull request as ready for review August 10, 2026 09:27
Comment threadapps/swift-ios/Features/Chat/ThreadDetailView.swift Outdated
macroscopeapp[bot]
macroscopeappBot previously approved these changes Aug 10, 2026
@macroscopeapp

macroscopeappBot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Needs human review

This PR introduces a new debug-build visual indicator system with new abstractions (T3BuildChrome enum, view modifiers) applied across multiple UI surfaces. While well-scoped to DEBUG builds with comprehensive tests, the new feature introduces user-facing visual behavior and cross-cutting changes that warrant human review.

You can customize Macroscope's approvability policy. Learn more.

@macroscopeapp
macroscopeappBot dismissed their stale reviewAugust 10, 2026 10:20

Dismissing prior approval to re-evaluate 826af68

@github-actionsgithub-actionsBot added size:M 30-99 changed lines (additions + deletions). and removed size:XS 0-9 changed lines (additions + deletions). labels Aug 10, 2026
Comment threadapps/swift-ios/Features/Chat/ThreadDetailView.swift Outdated
macroscopeapp[bot]
macroscopeappBot previously approved these changes Aug 10, 2026
@saphid

Copy link
Copy Markdown
ContributorAuthor

Dark-mode simulator verification

Debug thread title bar in dark appearance

Built and launched the integrated personal/swiftui-approved Debug app on iOS Simulator 3565B63B-6AEE-4D1F-8EE8-F7697B4F9C46, paired it to a disposable backend, created a real Codex thread, and received OK. In dark appearance the orange bar keeps the back/menu/title controls black and the metadata/status readable. XcodeBuildMCP build-and-run succeeded.

@macroscopeapp
macroscopeappBot dismissed their stale reviewAugust 10, 2026 10:47

Dismissing prior approval to re-evaluate 29e4bcd

@cursorcursorBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 29e4bcdb2e706593dd51416e11cf876be1f04a9d. Configure here.

Comment threadapps/swift-ios/Features/Chat/ThreadDetailView.swift Outdated
macroscopeapp[bot]
macroscopeappBot previously approved these changes Aug 10, 2026
@saphid

Copy link
Copy Markdown
ContributorAuthor

Rebuilt on the exact current Theo SwiftUI head (5b7ee58f6) before final handoff; the unrelated historical CI-retry commit was removed.

Final verification on exact PR result:

  • 226/226 native tests across 29 suites
  • explicit arm64 Release simulator build: BUILD SUCCEEDED
  • Debug integrated Home, New Task, and Thread proof in light/dark
  • semantic non-color Debug markers scoped to the intended title controls
  • git diff --check clean
  • fresh direct Claude Opus 5 high review of the rebased frozen diff: exit 0, MERGE-READY, no actionable findings

The reviewer also confirmed no path overlap with Theo's newer usage work and no build/release overlap. The shared Debug policy is adaptive; Release uses normal chrome.

@saphid
saphidforce-pushed the saphid/swiftui-debug-title-v2 branch from 29e4bcd to ef66325CompareAugust 10, 2026 12:06
@macroscopeapp
macroscopeappBot dismissed their stale reviewAugust 10, 2026 12:06

Dismissing prior approval to re-evaluate ef66325

@github-actionsgithub-actionsBot added size:L 100-499 changed lines (additions + deletions). and removed size:M 30-99 changed lines (additions + deletions). labels Aug 10, 2026
@saphid

Copy link
Copy Markdown
ContributorAuthor

Final connected simulator verification on exact head ef663259d (iPhone simulator, dark appearance):

  • Full native XCTest suite: passed.
  • Paired to a disposable backend built from the same PR worktree.
  • Created and settled a real thread, then reopened it.
  • Verified the orange debug chrome on home and thread; black system back/title/menu controls remain legible, while the composer and working-state accent remain cyan.

Connected home:

Connected dark home debug chrome

Thread detail:

Dark thread debug chrome with composer

@saphid
saphidforce-pushed the saphid/swiftui-debug-title-v2 branch from ef66325 to 47bebfdCompareAugust 11, 2026 10:26
macroscopeapp[bot]
macroscopeappBot previously approved these changes Aug 11, 2026
@saphid

saphid commented Aug 11, 2026

Copy link
Copy Markdown
ContributorAuthor

Exact final-head simulator proof (47bebfd): warning chrome and the system back chevron remain clearly legible after removing the overly broad tint scope.

HomeThread
Home chromeThread chrome

Focused DebugBuildChromeTests passed (3/3). The current native-CI red is the base-branch provider-catalog fixture failure fixed separately in #6130.

t3-code[bot]
t3-codeBot approved these changes Aug 12, 2026

@t3-codet3-codeBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed the debug warning chrome, scoped navigation color treatment, accessibility behavior, and regression coverage. no blocking code issues found. the current native-test red is the shared provider-catalog fixture failure addressed separately by #6130.

@macroscopeapp
macroscopeappBot dismissed their stale reviewAugust 12, 2026 12:24

Dismissing prior approval to re-evaluate a488a3d

@t3dotgg

Copy link
Copy Markdown
Member

Can you make it slightly less hideous? Like a fainter yellow

@saphid

Copy link
Copy Markdown
ContributorAuthor

Can you make it slightly less hideous? Like a fainter yellow

I've replaced it with
image

image

@saphid

Copy link
Copy Markdown
ContributorAuthor

Closing this version while I rebuild the upstream contribution set from the latest base. Clean versions are coming soon.

@saphidsaphid closed this Aug 15, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L100-499 changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@saphid@t3dotgg
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

feat(swift-ios): mark debug threads with warning chrome - #5972

Closed
saphid wants to merge 10 commits into
pingdotgg:t3code/rebuild-mobile-app-swiftfrom
saphid:saphid/swiftui-debug-title-v2
Closed

feat(swift-ios): mark debug threads with warning chrome#5972
saphid wants to merge 10 commits into
pingdotgg:t3code/rebuild-mobile-app-swiftfrom
saphid:saphid/swiftui-debug-title-v2

Conversation

@saphid

@saphidsaphid commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Summary

Uses the adaptive warning color for the navigation title bar of thread screens in DEBUG builds only, making development threads visually unmistakable without changing release builds.

Verification

  • apps/swift-ios/Scripts/ci-test.sh — 218 tests passed
  • Fresh independent Claude Opus 5 high review completed; all actionable findings were addressed and the final repair review found no blockers.
  • Simulator visual evidence will be attached before marking this PR ready for review.

Scope

Targets the active native SwiftUI owner branch (#5178).

Note

Mark debug build navigation bars with warning-themed chrome on Home, New Task, and Thread screens

  • Adds a T3BuildChrome utility in T3Theme.swift that selects warning background/foreground colors, toolbar color scheme, content opacity, and accessibility values based on whether the current build is a debug build.
  • Applies the new chrome to the Home (WorkspaceView), New Task (NewThreadView), and Thread (ThreadDetailView) surfaces via new view modifiers t3BuildNavigationChrome, t3BuildChromeBackground, and t3BuildChromeMarker.
  • Adds a warning(for:) helper that resolves the adaptive UIColor warning color for a specific ColorScheme, backing the toolbar background in dark/light mode.
  • Adds DebugBuildChromeTests covering presentation, accessibility values, toolbar color scheme, and foreground/background selection for all three surfaces.
  • Release builds retain their existing appearance with no code-path changes at runtime.

Macroscope summarized a488a3d.


Note

Low Risk
UI-only Debug presentation changes gated by compile-time flags; Release chrome and behavior are unaffected.

Overview
Debug builds now show adaptive warning chrome on Home, New Task, and Thread bars so development builds are visually unmistakable. Release builds are unchanged.

Adds T3BuildChrome with per-surface helpers for warning backgrounds, foregrounds, toolbar color scheme, opacity, and accessibility markers. Wires those helpers into WorkspaceView, NewThreadView, and ThreadDetailView.

Includes contrast-checked warning colors plus unit tests covering debug vs release presentation.

Reviewed by Cursor Bugbot for commit a488a3d. Bugbot is set up for automated code reviews on this repo. Configure here.

Delivery: direct
Validated against Theo commit: f98cab5
Depends on: none
Merge order: this PR only
Validation status: Green at a488a3d against Theo f98cab5: contract fixture generation, 8 focused native tests, exact-head Simulator build/launch, Contract fixtures and native tests, CI Test/Check, Mobile Native Static Analysis, and Release Smoke passed. APPROVED and MERGEABLE. Independent Claude Opus 5 high review launcher exited 1 because session quota was exhausted, so no cross-provider review occurred. Unrelated Vercel marketing authorization remains maintainer-side.

@coderabbitai

coderabbitaiBot commented Aug 10, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 9df61fc9-3cee-4326-9808-f3362fc72c64

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Aug 10, 2026
@saphid

Copy link
Copy Markdown
ContributorAuthor

Simulator evidence from the integrated approved Debug build:

Orange Debug title bar on home

Orange Debug title bar in a live thread

Verified on iOS 26.5 across home, new-thread, and live-thread routes.

@saphid
saphid marked this pull request as ready for review August 10, 2026 09:27
Comment threadapps/swift-ios/Features/Chat/ThreadDetailView.swift Outdated
macroscopeapp[bot]
macroscopeappBot previously approved these changes Aug 10, 2026
@macroscopeapp

macroscopeappBot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Needs human review

This PR introduces a new debug-build visual indicator system with new abstractions (T3BuildChrome enum, view modifiers) applied across multiple UI surfaces. While well-scoped to DEBUG builds with comprehensive tests, the new feature introduces user-facing visual behavior and cross-cutting changes that warrant human review.

You can customize Macroscope's approvability policy. Learn more.

@macroscopeapp
macroscopeappBot dismissed their stale reviewAugust 10, 2026 10:20

Dismissing prior approval to re-evaluate 826af68

@github-actionsgithub-actionsBot added size:M 30-99 changed lines (additions + deletions). and removed size:XS 0-9 changed lines (additions + deletions). labels Aug 10, 2026
Comment threadapps/swift-ios/Features/Chat/ThreadDetailView.swift Outdated
macroscopeapp[bot]
macroscopeappBot previously approved these changes Aug 10, 2026
@saphid

Copy link
Copy Markdown
ContributorAuthor

Dark-mode simulator verification

Debug thread title bar in dark appearance

Built and launched the integrated personal/swiftui-approved Debug app on iOS Simulator 3565B63B-6AEE-4D1F-8EE8-F7697B4F9C46, paired it to a disposable backend, created a real Codex thread, and received OK. In dark appearance the orange bar keeps the back/menu/title controls black and the metadata/status readable. XcodeBuildMCP build-and-run succeeded.

@macroscopeapp
macroscopeappBot dismissed their stale reviewAugust 10, 2026 10:47

Dismissing prior approval to re-evaluate 29e4bcd

@cursorcursorBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 29e4bcdb2e706593dd51416e11cf876be1f04a9d. Configure here.

Comment threadapps/swift-ios/Features/Chat/ThreadDetailView.swift Outdated
macroscopeapp[bot]
macroscopeappBot previously approved these changes Aug 10, 2026
@saphid

Copy link
Copy Markdown
ContributorAuthor

Rebuilt on the exact current Theo SwiftUI head (5b7ee58f6) before final handoff; the unrelated historical CI-retry commit was removed.

Final verification on exact PR result:

  • 226/226 native tests across 29 suites
  • explicit arm64 Release simulator build: BUILD SUCCEEDED
  • Debug integrated Home, New Task, and Thread proof in light/dark
  • semantic non-color Debug markers scoped to the intended title controls
  • git diff --check clean
  • fresh direct Claude Opus 5 high review of the rebased frozen diff: exit 0, MERGE-READY, no actionable findings

The reviewer also confirmed no path overlap with Theo's newer usage work and no build/release overlap. The shared Debug policy is adaptive; Release uses normal chrome.

@saphid
saphidforce-pushed the saphid/swiftui-debug-title-v2 branch from 29e4bcd to ef66325CompareAugust 10, 2026 12:06
@macroscopeapp
macroscopeappBot dismissed their stale reviewAugust 10, 2026 12:06

Dismissing prior approval to re-evaluate ef66325

@github-actionsgithub-actionsBot added size:L 100-499 changed lines (additions + deletions). and removed size:M 30-99 changed lines (additions + deletions). labels Aug 10, 2026
@saphid

Copy link
Copy Markdown
ContributorAuthor

Final connected simulator verification on exact head ef663259d (iPhone simulator, dark appearance):

  • Full native XCTest suite: passed.
  • Paired to a disposable backend built from the same PR worktree.
  • Created and settled a real thread, then reopened it.
  • Verified the orange debug chrome on home and thread; black system back/title/menu controls remain legible, while the composer and working-state accent remain cyan.

Connected home:

Connected dark home debug chrome

Thread detail:

Dark thread debug chrome with composer

@saphid
saphidforce-pushed the saphid/swiftui-debug-title-v2 branch from ef66325 to 47bebfdCompareAugust 11, 2026 10:26
macroscopeapp[bot]
macroscopeappBot previously approved these changes Aug 11, 2026
@saphid

saphid commented Aug 11, 2026

Copy link
Copy Markdown
ContributorAuthor

Exact final-head simulator proof (47bebfd): warning chrome and the system back chevron remain clearly legible after removing the overly broad tint scope.

HomeThread
Home chromeThread chrome

Focused DebugBuildChromeTests passed (3/3). The current native-CI red is the base-branch provider-catalog fixture failure fixed separately in #6130.

t3-code[bot]
t3-codeBot approved these changes Aug 12, 2026

@t3-codet3-codeBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed the debug warning chrome, scoped navigation color treatment, accessibility behavior, and regression coverage. no blocking code issues found. the current native-test red is the shared provider-catalog fixture failure addressed separately by #6130.

@macroscopeapp
macroscopeappBot dismissed their stale reviewAugust 12, 2026 12:24

Dismissing prior approval to re-evaluate a488a3d

@t3dotgg

Copy link
Copy Markdown
Member

Can you make it slightly less hideous? Like a fainter yellow

@saphid

Copy link
Copy Markdown
ContributorAuthor

Can you make it slightly less hideous? Like a fainter yellow

I've replaced it with
image

image

@saphid

Copy link
Copy Markdown
ContributorAuthor

Closing this version while I rebuild the upstream contribution set from the latest base. Clean versions are coming soon.

@saphidsaphid closed this Aug 15, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L100-499 changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@saphid@t3dotgg
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

feat(swift-ios): mark debug threads with warning chrome - #5972

Closed
saphid wants to merge 10 commits into
pingdotgg:t3code/rebuild-mobile-app-swiftfrom
saphid:saphid/swiftui-debug-title-v2
Closed

feat(swift-ios): mark debug threads with warning chrome#5972
saphid wants to merge 10 commits into
pingdotgg:t3code/rebuild-mobile-app-swiftfrom
saphid:saphid/swiftui-debug-title-v2

Conversation

@saphid

@saphidsaphid commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Summary

Uses the adaptive warning color for the navigation title bar of thread screens in DEBUG builds only, making development threads visually unmistakable without changing release builds.

Verification

  • apps/swift-ios/Scripts/ci-test.sh — 218 tests passed
  • Fresh independent Claude Opus 5 high review completed; all actionable findings were addressed and the final repair review found no blockers.
  • Simulator visual evidence will be attached before marking this PR ready for review.

Scope

Targets the active native SwiftUI owner branch (#5178).

Note

Mark debug build navigation bars with warning-themed chrome on Home, New Task, and Thread screens

  • Adds a T3BuildChrome utility in T3Theme.swift that selects warning background/foreground colors, toolbar color scheme, content opacity, and accessibility values based on whether the current build is a debug build.
  • Applies the new chrome to the Home (WorkspaceView), New Task (NewThreadView), and Thread (ThreadDetailView) surfaces via new view modifiers t3BuildNavigationChrome, t3BuildChromeBackground, and t3BuildChromeMarker.
  • Adds a warning(for:) helper that resolves the adaptive UIColor warning color for a specific ColorScheme, backing the toolbar background in dark/light mode.
  • Adds DebugBuildChromeTests covering presentation, accessibility values, toolbar color scheme, and foreground/background selection for all three surfaces.
  • Release builds retain their existing appearance with no code-path changes at runtime.

Macroscope summarized a488a3d.


Note

Low Risk
UI-only Debug presentation changes gated by compile-time flags; Release chrome and behavior are unaffected.

Overview
Debug builds now show adaptive warning chrome on Home, New Task, and Thread bars so development builds are visually unmistakable. Release builds are unchanged.

Adds T3BuildChrome with per-surface helpers for warning backgrounds, foregrounds, toolbar color scheme, opacity, and accessibility markers. Wires those helpers into WorkspaceView, NewThreadView, and ThreadDetailView.

Includes contrast-checked warning colors plus unit tests covering debug vs release presentation.

Reviewed by Cursor Bugbot for commit a488a3d. Bugbot is set up for automated code reviews on this repo. Configure here.

Delivery: direct
Validated against Theo commit: f98cab5
Depends on: none
Merge order: this PR only
Validation status: Green at a488a3d against Theo f98cab5: contract fixture generation, 8 focused native tests, exact-head Simulator build/launch, Contract fixtures and native tests, CI Test/Check, Mobile Native Static Analysis, and Release Smoke passed. APPROVED and MERGEABLE. Independent Claude Opus 5 high review launcher exited 1 because session quota was exhausted, so no cross-provider review occurred. Unrelated Vercel marketing authorization remains maintainer-side.

@coderabbitai

coderabbitaiBot commented Aug 10, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 9df61fc9-3cee-4326-9808-f3362fc72c64

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Aug 10, 2026
@saphid

Copy link
Copy Markdown
ContributorAuthor

Simulator evidence from the integrated approved Debug build:

Orange Debug title bar on home

Orange Debug title bar in a live thread

Verified on iOS 26.5 across home, new-thread, and live-thread routes.

@saphid
saphid marked this pull request as ready for review August 10, 2026 09:27
Comment threadapps/swift-ios/Features/Chat/ThreadDetailView.swift Outdated
macroscopeapp[bot]
macroscopeappBot previously approved these changes Aug 10, 2026
@macroscopeapp

macroscopeappBot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Needs human review

This PR introduces a new debug-build visual indicator system with new abstractions (T3BuildChrome enum, view modifiers) applied across multiple UI surfaces. While well-scoped to DEBUG builds with comprehensive tests, the new feature introduces user-facing visual behavior and cross-cutting changes that warrant human review.

You can customize Macroscope's approvability policy. Learn more.

@macroscopeapp
macroscopeappBot dismissed their stale reviewAugust 10, 2026 10:20

Dismissing prior approval to re-evaluate 826af68

@github-actionsgithub-actionsBot added size:M 30-99 changed lines (additions + deletions). and removed size:XS 0-9 changed lines (additions + deletions). labels Aug 10, 2026
Comment threadapps/swift-ios/Features/Chat/ThreadDetailView.swift Outdated
macroscopeapp[bot]
macroscopeappBot previously approved these changes Aug 10, 2026
@saphid

Copy link
Copy Markdown
ContributorAuthor

Dark-mode simulator verification

Debug thread title bar in dark appearance

Built and launched the integrated personal/swiftui-approved Debug app on iOS Simulator 3565B63B-6AEE-4D1F-8EE8-F7697B4F9C46, paired it to a disposable backend, created a real Codex thread, and received OK. In dark appearance the orange bar keeps the back/menu/title controls black and the metadata/status readable. XcodeBuildMCP build-and-run succeeded.

@macroscopeapp
macroscopeappBot dismissed their stale reviewAugust 10, 2026 10:47

Dismissing prior approval to re-evaluate 29e4bcd

@cursorcursorBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 29e4bcdb2e706593dd51416e11cf876be1f04a9d. Configure here.

Comment threadapps/swift-ios/Features/Chat/ThreadDetailView.swift Outdated
macroscopeapp[bot]
macroscopeappBot previously approved these changes Aug 10, 2026
@saphid

Copy link
Copy Markdown
ContributorAuthor

Rebuilt on the exact current Theo SwiftUI head (5b7ee58f6) before final handoff; the unrelated historical CI-retry commit was removed.

Final verification on exact PR result:

  • 226/226 native tests across 29 suites
  • explicit arm64 Release simulator build: BUILD SUCCEEDED
  • Debug integrated Home, New Task, and Thread proof in light/dark
  • semantic non-color Debug markers scoped to the intended title controls
  • git diff --check clean
  • fresh direct Claude Opus 5 high review of the rebased frozen diff: exit 0, MERGE-READY, no actionable findings

The reviewer also confirmed no path overlap with Theo's newer usage work and no build/release overlap. The shared Debug policy is adaptive; Release uses normal chrome.

@saphid
saphidforce-pushed the saphid/swiftui-debug-title-v2 branch from 29e4bcd to ef66325CompareAugust 10, 2026 12:06
@macroscopeapp
macroscopeappBot dismissed their stale reviewAugust 10, 2026 12:06

Dismissing prior approval to re-evaluate ef66325

@github-actionsgithub-actionsBot added size:L 100-499 changed lines (additions + deletions). and removed size:M 30-99 changed lines (additions + deletions). labels Aug 10, 2026
@saphid

Copy link
Copy Markdown
ContributorAuthor

Final connected simulator verification on exact head ef663259d (iPhone simulator, dark appearance):

  • Full native XCTest suite: passed.
  • Paired to a disposable backend built from the same PR worktree.
  • Created and settled a real thread, then reopened it.
  • Verified the orange debug chrome on home and thread; black system back/title/menu controls remain legible, while the composer and working-state accent remain cyan.

Connected home:

Connected dark home debug chrome

Thread detail:

Dark thread debug chrome with composer

@saphid
saphidforce-pushed the saphid/swiftui-debug-title-v2 branch from ef66325 to 47bebfdCompareAugust 11, 2026 10:26
macroscopeapp[bot]
macroscopeappBot previously approved these changes Aug 11, 2026
@saphid

saphid commented Aug 11, 2026

Copy link
Copy Markdown
ContributorAuthor

Exact final-head simulator proof (47bebfd): warning chrome and the system back chevron remain clearly legible after removing the overly broad tint scope.

HomeThread
Home chromeThread chrome

Focused DebugBuildChromeTests passed (3/3). The current native-CI red is the base-branch provider-catalog fixture failure fixed separately in #6130.

t3-code[bot]
t3-codeBot approved these changes Aug 12, 2026

@t3-codet3-codeBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed the debug warning chrome, scoped navigation color treatment, accessibility behavior, and regression coverage. no blocking code issues found. the current native-test red is the shared provider-catalog fixture failure addressed separately by #6130.

@macroscopeapp
macroscopeappBot dismissed their stale reviewAugust 12, 2026 12:24

Dismissing prior approval to re-evaluate a488a3d

@t3dotgg

Copy link
Copy Markdown
Member

Can you make it slightly less hideous? Like a fainter yellow

@saphid

Copy link
Copy Markdown
ContributorAuthor

Can you make it slightly less hideous? Like a fainter yellow

I've replaced it with
image

image

@saphid

Copy link
Copy Markdown
ContributorAuthor

Closing this version while I rebuild the upstream contribution set from the latest base. Clean versions are coming soon.

@saphidsaphid closed this Aug 15, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L100-499 changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@saphid@t3dotgg
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

feat(swift-ios): mark debug threads with warning chrome - #5972

Closed
saphid wants to merge 10 commits into
pingdotgg:t3code/rebuild-mobile-app-swiftfrom
saphid:saphid/swiftui-debug-title-v2
Closed

feat(swift-ios): mark debug threads with warning chrome#5972
saphid wants to merge 10 commits into
pingdotgg:t3code/rebuild-mobile-app-swiftfrom
saphid:saphid/swiftui-debug-title-v2

Conversation

@saphid

@saphidsaphid commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Summary

Uses the adaptive warning color for the navigation title bar of thread screens in DEBUG builds only, making development threads visually unmistakable without changing release builds.

Verification

  • apps/swift-ios/Scripts/ci-test.sh — 218 tests passed
  • Fresh independent Claude Opus 5 high review completed; all actionable findings were addressed and the final repair review found no blockers.
  • Simulator visual evidence will be attached before marking this PR ready for review.

Scope

Targets the active native SwiftUI owner branch (#5178).

Note

Mark debug build navigation bars with warning-themed chrome on Home, New Task, and Thread screens

  • Adds a T3BuildChrome utility in T3Theme.swift that selects warning background/foreground colors, toolbar color scheme, content opacity, and accessibility values based on whether the current build is a debug build.
  • Applies the new chrome to the Home (WorkspaceView), New Task (NewThreadView), and Thread (ThreadDetailView) surfaces via new view modifiers t3BuildNavigationChrome, t3BuildChromeBackground, and t3BuildChromeMarker.
  • Adds a warning(for:) helper that resolves the adaptive UIColor warning color for a specific ColorScheme, backing the toolbar background in dark/light mode.
  • Adds DebugBuildChromeTests covering presentation, accessibility values, toolbar color scheme, and foreground/background selection for all three surfaces.
  • Release builds retain their existing appearance with no code-path changes at runtime.

Macroscope summarized a488a3d.


Note

Low Risk
UI-only Debug presentation changes gated by compile-time flags; Release chrome and behavior are unaffected.

Overview
Debug builds now show adaptive warning chrome on Home, New Task, and Thread bars so development builds are visually unmistakable. Release builds are unchanged.

Adds T3BuildChrome with per-surface helpers for warning backgrounds, foregrounds, toolbar color scheme, opacity, and accessibility markers. Wires those helpers into WorkspaceView, NewThreadView, and ThreadDetailView.

Includes contrast-checked warning colors plus unit tests covering debug vs release presentation.

Reviewed by Cursor Bugbot for commit a488a3d. Bugbot is set up for automated code reviews on this repo. Configure here.

Delivery: direct
Validated against Theo commit: f98cab5
Depends on: none
Merge order: this PR only
Validation status: Green at a488a3d against Theo f98cab5: contract fixture generation, 8 focused native tests, exact-head Simulator build/launch, Contract fixtures and native tests, CI Test/Check, Mobile Native Static Analysis, and Release Smoke passed. APPROVED and MERGEABLE. Independent Claude Opus 5 high review launcher exited 1 because session quota was exhausted, so no cross-provider review occurred. Unrelated Vercel marketing authorization remains maintainer-side.

@coderabbitai

coderabbitaiBot commented Aug 10, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 9df61fc9-3cee-4326-9808-f3362fc72c64

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Aug 10, 2026
@saphid

Copy link
Copy Markdown
ContributorAuthor

Simulator evidence from the integrated approved Debug build:

Orange Debug title bar on home

Orange Debug title bar in a live thread

Verified on iOS 26.5 across home, new-thread, and live-thread routes.

@saphid
saphid marked this pull request as ready for review August 10, 2026 09:27
Comment threadapps/swift-ios/Features/Chat/ThreadDetailView.swift Outdated
macroscopeapp[bot]
macroscopeappBot previously approved these changes Aug 10, 2026
@macroscopeapp

macroscopeappBot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Needs human review

This PR introduces a new debug-build visual indicator system with new abstractions (T3BuildChrome enum, view modifiers) applied across multiple UI surfaces. While well-scoped to DEBUG builds with comprehensive tests, the new feature introduces user-facing visual behavior and cross-cutting changes that warrant human review.

You can customize Macroscope's approvability policy. Learn more.

@macroscopeapp
macroscopeappBot dismissed their stale reviewAugust 10, 2026 10:20

Dismissing prior approval to re-evaluate 826af68

@github-actionsgithub-actionsBot added size:M 30-99 changed lines (additions + deletions). and removed size:XS 0-9 changed lines (additions + deletions). labels Aug 10, 2026
Comment threadapps/swift-ios/Features/Chat/ThreadDetailView.swift Outdated
macroscopeapp[bot]
macroscopeappBot previously approved these changes Aug 10, 2026
@saphid

Copy link
Copy Markdown
ContributorAuthor

Dark-mode simulator verification

Debug thread title bar in dark appearance

Built and launched the integrated personal/swiftui-approved Debug app on iOS Simulator 3565B63B-6AEE-4D1F-8EE8-F7697B4F9C46, paired it to a disposable backend, created a real Codex thread, and received OK. In dark appearance the orange bar keeps the back/menu/title controls black and the metadata/status readable. XcodeBuildMCP build-and-run succeeded.

@macroscopeapp
macroscopeappBot dismissed their stale reviewAugust 10, 2026 10:47

Dismissing prior approval to re-evaluate 29e4bcd

@cursorcursorBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 29e4bcdb2e706593dd51416e11cf876be1f04a9d. Configure here.

Comment threadapps/swift-ios/Features/Chat/ThreadDetailView.swift Outdated
macroscopeapp[bot]
macroscopeappBot previously approved these changes Aug 10, 2026
@saphid

Copy link
Copy Markdown
ContributorAuthor

Rebuilt on the exact current Theo SwiftUI head (5b7ee58f6) before final handoff; the unrelated historical CI-retry commit was removed.

Final verification on exact PR result:

  • 226/226 native tests across 29 suites
  • explicit arm64 Release simulator build: BUILD SUCCEEDED
  • Debug integrated Home, New Task, and Thread proof in light/dark
  • semantic non-color Debug markers scoped to the intended title controls
  • git diff --check clean
  • fresh direct Claude Opus 5 high review of the rebased frozen diff: exit 0, MERGE-READY, no actionable findings

The reviewer also confirmed no path overlap with Theo's newer usage work and no build/release overlap. The shared Debug policy is adaptive; Release uses normal chrome.

@saphid
saphidforce-pushed the saphid/swiftui-debug-title-v2 branch from 29e4bcd to ef66325CompareAugust 10, 2026 12:06
@macroscopeapp
macroscopeappBot dismissed their stale reviewAugust 10, 2026 12:06

Dismissing prior approval to re-evaluate ef66325

@github-actionsgithub-actionsBot added size:L 100-499 changed lines (additions + deletions). and removed size:M 30-99 changed lines (additions + deletions). labels Aug 10, 2026
@saphid

Copy link
Copy Markdown
ContributorAuthor

Final connected simulator verification on exact head ef663259d (iPhone simulator, dark appearance):

  • Full native XCTest suite: passed.
  • Paired to a disposable backend built from the same PR worktree.
  • Created and settled a real thread, then reopened it.
  • Verified the orange debug chrome on home and thread; black system back/title/menu controls remain legible, while the composer and working-state accent remain cyan.

Connected home:

Connected dark home debug chrome

Thread detail:

Dark thread debug chrome with composer

@saphid
saphidforce-pushed the saphid/swiftui-debug-title-v2 branch from ef66325 to 47bebfdCompareAugust 11, 2026 10:26
macroscopeapp[bot]
macroscopeappBot previously approved these changes Aug 11, 2026
@saphid

saphid commented Aug 11, 2026

Copy link
Copy Markdown
ContributorAuthor

Exact final-head simulator proof (47bebfd): warning chrome and the system back chevron remain clearly legible after removing the overly broad tint scope.

HomeThread
Home chromeThread chrome

Focused DebugBuildChromeTests passed (3/3). The current native-CI red is the base-branch provider-catalog fixture failure fixed separately in #6130.

t3-code[bot]
t3-codeBot approved these changes Aug 12, 2026

@t3-codet3-codeBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed the debug warning chrome, scoped navigation color treatment, accessibility behavior, and regression coverage. no blocking code issues found. the current native-test red is the shared provider-catalog fixture failure addressed separately by #6130.

@macroscopeapp
macroscopeappBot dismissed their stale reviewAugust 12, 2026 12:24

Dismissing prior approval to re-evaluate a488a3d

@t3dotgg

Copy link
Copy Markdown
Member

Can you make it slightly less hideous? Like a fainter yellow

@saphid

Copy link
Copy Markdown
ContributorAuthor

Can you make it slightly less hideous? Like a fainter yellow

I've replaced it with
image

image

@saphid

Copy link
Copy Markdown
ContributorAuthor

Closing this version while I rebuild the upstream contribution set from the latest base. Clean versions are coming soon.

@saphidsaphid closed this Aug 15, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L100-499 changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@saphid@t3dotgg
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

feat(swift-ios): mark debug threads with warning chrome - #5972

Closed
saphid wants to merge 10 commits into
pingdotgg:t3code/rebuild-mobile-app-swiftfrom
saphid:saphid/swiftui-debug-title-v2
Closed

feat(swift-ios): mark debug threads with warning chrome#5972
saphid wants to merge 10 commits into
pingdotgg:t3code/rebuild-mobile-app-swiftfrom
saphid:saphid/swiftui-debug-title-v2

Conversation

@saphid

@saphidsaphid commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Summary

Uses the adaptive warning color for the navigation title bar of thread screens in DEBUG builds only, making development threads visually unmistakable without changing release builds.

Verification

  • apps/swift-ios/Scripts/ci-test.sh — 218 tests passed
  • Fresh independent Claude Opus 5 high review completed; all actionable findings were addressed and the final repair review found no blockers.
  • Simulator visual evidence will be attached before marking this PR ready for review.

Scope

Targets the active native SwiftUI owner branch (#5178).

Note

Mark debug build navigation bars with warning-themed chrome on Home, New Task, and Thread screens

  • Adds a T3BuildChrome utility in T3Theme.swift that selects warning background/foreground colors, toolbar color scheme, content opacity, and accessibility values based on whether the current build is a debug build.
  • Applies the new chrome to the Home (WorkspaceView), New Task (NewThreadView), and Thread (ThreadDetailView) surfaces via new view modifiers t3BuildNavigationChrome, t3BuildChromeBackground, and t3BuildChromeMarker.
  • Adds a warning(for:) helper that resolves the adaptive UIColor warning color for a specific ColorScheme, backing the toolbar background in dark/light mode.
  • Adds DebugBuildChromeTests covering presentation, accessibility values, toolbar color scheme, and foreground/background selection for all three surfaces.
  • Release builds retain their existing appearance with no code-path changes at runtime.

Macroscope summarized a488a3d.


Note

Low Risk
UI-only Debug presentation changes gated by compile-time flags; Release chrome and behavior are unaffected.

Overview
Debug builds now show adaptive warning chrome on Home, New Task, and Thread bars so development builds are visually unmistakable. Release builds are unchanged.

Adds T3BuildChrome with per-surface helpers for warning backgrounds, foregrounds, toolbar color scheme, opacity, and accessibility markers. Wires those helpers into WorkspaceView, NewThreadView, and ThreadDetailView.

Includes contrast-checked warning colors plus unit tests covering debug vs release presentation.

Reviewed by Cursor Bugbot for commit a488a3d. Bugbot is set up for automated code reviews on this repo. Configure here.

Delivery: direct
Validated against Theo commit: f98cab5
Depends on: none
Merge order: this PR only
Validation status: Green at a488a3d against Theo f98cab5: contract fixture generation, 8 focused native tests, exact-head Simulator build/launch, Contract fixtures and native tests, CI Test/Check, Mobile Native Static Analysis, and Release Smoke passed. APPROVED and MERGEABLE. Independent Claude Opus 5 high review launcher exited 1 because session quota was exhausted, so no cross-provider review occurred. Unrelated Vercel marketing authorization remains maintainer-side.

@coderabbitai

coderabbitaiBot commented Aug 10, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 9df61fc9-3cee-4326-9808-f3362fc72c64

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Aug 10, 2026
@saphid

Copy link
Copy Markdown
ContributorAuthor

Simulator evidence from the integrated approved Debug build:

Orange Debug title bar on home

Orange Debug title bar in a live thread

Verified on iOS 26.5 across home, new-thread, and live-thread routes.

@saphid
saphid marked this pull request as ready for review August 10, 2026 09:27
Comment threadapps/swift-ios/Features/Chat/ThreadDetailView.swift Outdated
macroscopeapp[bot]
macroscopeappBot previously approved these changes Aug 10, 2026
@macroscopeapp

macroscopeappBot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Needs human review

This PR introduces a new debug-build visual indicator system with new abstractions (T3BuildChrome enum, view modifiers) applied across multiple UI surfaces. While well-scoped to DEBUG builds with comprehensive tests, the new feature introduces user-facing visual behavior and cross-cutting changes that warrant human review.

You can customize Macroscope's approvability policy. Learn more.

@macroscopeapp
macroscopeappBot dismissed their stale reviewAugust 10, 2026 10:20

Dismissing prior approval to re-evaluate 826af68

@github-actionsgithub-actionsBot added size:M 30-99 changed lines (additions + deletions). and removed size:XS 0-9 changed lines (additions + deletions). labels Aug 10, 2026
Comment threadapps/swift-ios/Features/Chat/ThreadDetailView.swift Outdated
macroscopeapp[bot]
macroscopeappBot previously approved these changes Aug 10, 2026
@saphid

Copy link
Copy Markdown
ContributorAuthor

Dark-mode simulator verification

Debug thread title bar in dark appearance

Built and launched the integrated personal/swiftui-approved Debug app on iOS Simulator 3565B63B-6AEE-4D1F-8EE8-F7697B4F9C46, paired it to a disposable backend, created a real Codex thread, and received OK. In dark appearance the orange bar keeps the back/menu/title controls black and the metadata/status readable. XcodeBuildMCP build-and-run succeeded.

@macroscopeapp
macroscopeappBot dismissed their stale reviewAugust 10, 2026 10:47

Dismissing prior approval to re-evaluate 29e4bcd

@cursorcursorBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 29e4bcdb2e706593dd51416e11cf876be1f04a9d. Configure here.

Comment threadapps/swift-ios/Features/Chat/ThreadDetailView.swift Outdated
macroscopeapp[bot]
macroscopeappBot previously approved these changes Aug 10, 2026
@saphid

Copy link
Copy Markdown
ContributorAuthor

Rebuilt on the exact current Theo SwiftUI head (5b7ee58f6) before final handoff; the unrelated historical CI-retry commit was removed.

Final verification on exact PR result:

  • 226/226 native tests across 29 suites
  • explicit arm64 Release simulator build: BUILD SUCCEEDED
  • Debug integrated Home, New Task, and Thread proof in light/dark
  • semantic non-color Debug markers scoped to the intended title controls
  • git diff --check clean
  • fresh direct Claude Opus 5 high review of the rebased frozen diff: exit 0, MERGE-READY, no actionable findings

The reviewer also confirmed no path overlap with Theo's newer usage work and no build/release overlap. The shared Debug policy is adaptive; Release uses normal chrome.

@saphid
saphidforce-pushed the saphid/swiftui-debug-title-v2 branch from 29e4bcd to ef66325CompareAugust 10, 2026 12:06
@macroscopeapp
macroscopeappBot dismissed their stale reviewAugust 10, 2026 12:06

Dismissing prior approval to re-evaluate ef66325

@github-actionsgithub-actionsBot added size:L 100-499 changed lines (additions + deletions). and removed size:M 30-99 changed lines (additions + deletions). labels Aug 10, 2026
@saphid

Copy link
Copy Markdown
ContributorAuthor

Final connected simulator verification on exact head ef663259d (iPhone simulator, dark appearance):

  • Full native XCTest suite: passed.
  • Paired to a disposable backend built from the same PR worktree.
  • Created and settled a real thread, then reopened it.
  • Verified the orange debug chrome on home and thread; black system back/title/menu controls remain legible, while the composer and working-state accent remain cyan.

Connected home:

Connected dark home debug chrome

Thread detail:

Dark thread debug chrome with composer

@saphid
saphidforce-pushed the saphid/swiftui-debug-title-v2 branch from ef66325 to 47bebfdCompareAugust 11, 2026 10:26
macroscopeapp[bot]
macroscopeappBot previously approved these changes Aug 11, 2026
@saphid

saphid commented Aug 11, 2026

Copy link
Copy Markdown
ContributorAuthor

Exact final-head simulator proof (47bebfd): warning chrome and the system back chevron remain clearly legible after removing the overly broad tint scope.

HomeThread
Home chromeThread chrome

Focused DebugBuildChromeTests passed (3/3). The current native-CI red is the base-branch provider-catalog fixture failure fixed separately in #6130.

t3-code[bot]
t3-codeBot approved these changes Aug 12, 2026

@t3-codet3-codeBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed the debug warning chrome, scoped navigation color treatment, accessibility behavior, and regression coverage. no blocking code issues found. the current native-test red is the shared provider-catalog fixture failure addressed separately by #6130.

@macroscopeapp
macroscopeappBot dismissed their stale reviewAugust 12, 2026 12:24

Dismissing prior approval to re-evaluate a488a3d

@t3dotgg

Copy link
Copy Markdown
Member

Can you make it slightly less hideous? Like a fainter yellow

@saphid

Copy link
Copy Markdown
ContributorAuthor

Can you make it slightly less hideous? Like a fainter yellow

I've replaced it with
image

image

@saphid

Copy link
Copy Markdown
ContributorAuthor

Closing this version while I rebuild the upstream contribution set from the latest base. Clean versions are coming soon.

@saphidsaphid closed this Aug 15, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L100-499 changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@saphid@t3dotgg