fix(server): coalesce Codex child progress before ingestion by cheruvian · Pull Request #6004 · pingdotgg/t3code

cheruvian · 2026-08-10T13:10:17Z

What Changed

Coalesce Codex child item and token-usage progress independently per session and child before provider runtime ingestion.
Keep separate latest-value lanes and flush them before child completion, close, failure, idle, and interruption events.
Cancel scoped best-effort progress work during session shutdown so it cannot emit after close.
Add focused race, isolation, lifecycle-ordering, shutdown, and durable-ingestion coverage.

Why

Codex can emit child item and cumulative token-usage notifications at high frequency. Each notification previously became its own task.progress, durable thread.activity-appended event, and serial projection input, delaying unrelated threads even though the final projection retained only the newest values.

For the representative 32-item and 32-usage burst, durable child progress events fall from 64 to 2 while preserving latest-query-31, totalTokens: 10031, and ordering both before child completion.

Closes#5681.

Checklist

This PR is small and focused
I explained what changed and why
No UI changes

Implemented and verified with GPT-5.6-sol in the Codex harness.

Note

Medium Risk
Changes Codex multi-agent event ordering and volume at the provider boundary; mitigated by explicit flush rules, scoped close, and ingestion tests, but could affect UI timing of child task progress.

Overview
Adds makeCodexProgressCoalescer, which batches Codex child-agent task.progress per child thread into separate item and tokenUsage lanes (250ms windows, latest value per lane) before they hit the runtime event queue.

CodexAdapter wires this in per session: collabAgent/item and collabAgent/tokenUsage go through the coalescer; pending lanes are flushed before terminal collab events (turn completed, closed, idle, system error, interruption). Session stop and failed start close the coalescer so nothing emits after shutdown.

Tests cover coalescer timing/races/isolation, adapter flush ordering and post-close behavior, and an end-to-end ingestion case where a 32× burst of child updates yields two durable task.progress activities (latest query + token totals) still ordered before child completion.

^{Reviewed by Cursor Bugbot for commit 8d27611. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Coalesce Codex child agent progress events before durable activity ingestion

Introduces makeCodexProgressCoalescer, a scoped utility that batches task.progress events per child agent thread into two lanes (item and tokenUsage) within a 250ms fixed window, emitting only the newest value per lane.
Integrates the coalescer into makeCodexAdapter: child progress events are routed through the coalescer and flushed before terminal collabAgent lifecycle events (turn completed, closed, interrupted, idle, or system error).
Ensures the coalescer is closed on session stop and on start failure to cancel any pending emissions.
Behavioral Change: child task.progress events are no longer emitted individually — only the latest value per lane within each window is forwarded to ingestion.

^{Macroscope summarized 8d27611.}

coderabbitai · 2026-08-10T13:10:28Z

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: d1d811d6-4797-4b4d-ac70-ac90e796e62f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

macroscopeapp

One convention finding: the new coalescer's public interface is re-declared locally in CodexAdapter.ts instead of being imported from its owning module. Everything else in the changed scope (namespace subpath imports, scoped make construction, callback-based emit rather than service injection, test-only service instance passing) follows the conventions.

^{Posted via Macroscope — Effect Service Conventions}

macroscopeapp · 2026-08-10T13:18:58Z

Approvability

Verdict: Needs human review

This PR introduces a new CodexProgressCoalescer utility that changes how child progress events are processed - adding 250ms windowed batching before durable ingestion. This is substantial new runtime behavior affecting event timing and coalescing, not a simple fix.

^{You can customize Macroscope's approvability policy. Learn more.}

Coalesce Codex child item and token-usage notifications independently per session and child before provider runtime ingestion. Flush pending progress before terminal lifecycle events and cancel pending work when the runtime closes. Add focused adapter and ingestion coverage for bounded durable event volume, latest-value preservation, terminal ordering, isolation, and shutdown.

Semantically ports pingdotgg#6004 onto current main and flushes buffered progress before identity refinements as well as terminal lifecycle events.

cheruvian · 2026-08-10T13:10:17Z

What Changed

Coalesce Codex child item and token-usage progress independently per session and child before provider runtime ingestion.
Keep separate latest-value lanes and flush them before child completion, close, failure, idle, and interruption events.
Cancel scoped best-effort progress work during session shutdown so it cannot emit after close.
Add focused race, isolation, lifecycle-ordering, shutdown, and durable-ingestion coverage.

Why

Codex can emit child item and cumulative token-usage notifications at high frequency. Each notification previously became its own task.progress, durable thread.activity-appended event, and serial projection input, delaying unrelated threads even though the final projection retained only the newest values.

For the representative 32-item and 32-usage burst, durable child progress events fall from 64 to 2 while preserving latest-query-31, totalTokens: 10031, and ordering both before child completion.

Closes#5681.

Checklist

This PR is small and focused
I explained what changed and why
No UI changes

Implemented and verified with GPT-5.6-sol in the Codex harness.

Note

Medium Risk
Changes Codex multi-agent event ordering and volume at the provider boundary; mitigated by explicit flush rules, scoped close, and ingestion tests, but could affect UI timing of child task progress.

Overview
Adds makeCodexProgressCoalescer, which batches Codex child-agent task.progress per child thread into separate item and tokenUsage lanes (250ms windows, latest value per lane) before they hit the runtime event queue.

CodexAdapter wires this in per session: collabAgent/item and collabAgent/tokenUsage go through the coalescer; pending lanes are flushed before terminal collab events (turn completed, closed, idle, system error, interruption). Session stop and failed start close the coalescer so nothing emits after shutdown.

Tests cover coalescer timing/races/isolation, adapter flush ordering and post-close behavior, and an end-to-end ingestion case where a 32× burst of child updates yields two durable task.progress activities (latest query + token totals) still ordered before child completion.

^{Reviewed by Cursor Bugbot for commit 8d27611. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Coalesce Codex child agent progress events before durable activity ingestion

Introduces makeCodexProgressCoalescer, a scoped utility that batches task.progress events per child agent thread into two lanes (item and tokenUsage) within a 250ms fixed window, emitting only the newest value per lane.
Integrates the coalescer into makeCodexAdapter: child progress events are routed through the coalescer and flushed before terminal collabAgent lifecycle events (turn completed, closed, interrupted, idle, or system error).
Ensures the coalescer is closed on session stop and on start failure to cancel any pending emissions.
Behavioral Change: child task.progress events are no longer emitted individually — only the latest value per lane within each window is forwarded to ingestion.

^{Macroscope summarized 8d27611.}

coderabbitai · 2026-08-10T13:10:28Z

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: d1d811d6-4797-4b4d-ac70-ac90e796e62f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

macroscopeapp

One convention finding: the new coalescer's public interface is re-declared locally in CodexAdapter.ts instead of being imported from its owning module. Everything else in the changed scope (namespace subpath imports, scoped make construction, callback-based emit rather than service injection, test-only service instance passing) follows the conventions.

^{Posted via Macroscope — Effect Service Conventions}

macroscopeapp · 2026-08-10T13:18:58Z

Approvability

Verdict: Needs human review

This PR introduces a new CodexProgressCoalescer utility that changes how child progress events are processed - adding 250ms windowed batching before durable ingestion. This is substantial new runtime behavior affecting event timing and coalescing, not a simple fix.

^{You can customize Macroscope's approvability policy. Learn more.}

Coalesce Codex child item and token-usage notifications independently per session and child before provider runtime ingestion. Flush pending progress before terminal lifecycle events and cancel pending work when the runtime closes. Add focused adapter and ingestion coverage for bounded durable event volume, latest-value preservation, terminal ordering, isolation, and shutdown.

Semantically ports pingdotgg#6004 onto current main and flushes buffered progress before identity refinements as well as terminal lifecycle events.

cheruvian · 2026-08-10T13:10:17Z

What Changed

Coalesce Codex child item and token-usage progress independently per session and child before provider runtime ingestion.
Keep separate latest-value lanes and flush them before child completion, close, failure, idle, and interruption events.
Cancel scoped best-effort progress work during session shutdown so it cannot emit after close.
Add focused race, isolation, lifecycle-ordering, shutdown, and durable-ingestion coverage.

Why

Codex can emit child item and cumulative token-usage notifications at high frequency. Each notification previously became its own task.progress, durable thread.activity-appended event, and serial projection input, delaying unrelated threads even though the final projection retained only the newest values.

For the representative 32-item and 32-usage burst, durable child progress events fall from 64 to 2 while preserving latest-query-31, totalTokens: 10031, and ordering both before child completion.

Closes#5681.

Checklist

This PR is small and focused
I explained what changed and why
No UI changes

Implemented and verified with GPT-5.6-sol in the Codex harness.

Note

Medium Risk
Changes Codex multi-agent event ordering and volume at the provider boundary; mitigated by explicit flush rules, scoped close, and ingestion tests, but could affect UI timing of child task progress.

Overview
Adds makeCodexProgressCoalescer, which batches Codex child-agent task.progress per child thread into separate item and tokenUsage lanes (250ms windows, latest value per lane) before they hit the runtime event queue.

CodexAdapter wires this in per session: collabAgent/item and collabAgent/tokenUsage go through the coalescer; pending lanes are flushed before terminal collab events (turn completed, closed, idle, system error, interruption). Session stop and failed start close the coalescer so nothing emits after shutdown.

Tests cover coalescer timing/races/isolation, adapter flush ordering and post-close behavior, and an end-to-end ingestion case where a 32× burst of child updates yields two durable task.progress activities (latest query + token totals) still ordered before child completion.

^{Reviewed by Cursor Bugbot for commit 8d27611. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Coalesce Codex child agent progress events before durable activity ingestion

Introduces makeCodexProgressCoalescer, a scoped utility that batches task.progress events per child agent thread into two lanes (item and tokenUsage) within a 250ms fixed window, emitting only the newest value per lane.
Integrates the coalescer into makeCodexAdapter: child progress events are routed through the coalescer and flushed before terminal collabAgent lifecycle events (turn completed, closed, interrupted, idle, or system error).
Ensures the coalescer is closed on session stop and on start failure to cancel any pending emissions.
Behavioral Change: child task.progress events are no longer emitted individually — only the latest value per lane within each window is forwarded to ingestion.

^{Macroscope summarized 8d27611.}

coderabbitai · 2026-08-10T13:10:28Z

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: d1d811d6-4797-4b4d-ac70-ac90e796e62f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

macroscopeapp

One convention finding: the new coalescer's public interface is re-declared locally in CodexAdapter.ts instead of being imported from its owning module. Everything else in the changed scope (namespace subpath imports, scoped make construction, callback-based emit rather than service injection, test-only service instance passing) follows the conventions.

^{Posted via Macroscope — Effect Service Conventions}

macroscopeapp · 2026-08-10T13:18:58Z

Approvability

Verdict: Needs human review

This PR introduces a new CodexProgressCoalescer utility that changes how child progress events are processed - adding 250ms windowed batching before durable ingestion. This is substantial new runtime behavior affecting event timing and coalescing, not a simple fix.

^{You can customize Macroscope's approvability policy. Learn more.}

Coalesce Codex child item and token-usage notifications independently per session and child before provider runtime ingestion. Flush pending progress before terminal lifecycle events and cancel pending work when the runtime closes. Add focused adapter and ingestion coverage for bounded durable event volume, latest-value preservation, terminal ordering, isolation, and shutdown.

Semantically ports pingdotgg#6004 onto current main and flushes buffered progress before identity refinements as well as terminal lifecycle events.

cheruvian · 2026-08-10T13:10:17Z

What Changed

Coalesce Codex child item and token-usage progress independently per session and child before provider runtime ingestion.
Keep separate latest-value lanes and flush them before child completion, close, failure, idle, and interruption events.
Cancel scoped best-effort progress work during session shutdown so it cannot emit after close.
Add focused race, isolation, lifecycle-ordering, shutdown, and durable-ingestion coverage.

Why

Codex can emit child item and cumulative token-usage notifications at high frequency. Each notification previously became its own task.progress, durable thread.activity-appended event, and serial projection input, delaying unrelated threads even though the final projection retained only the newest values.

For the representative 32-item and 32-usage burst, durable child progress events fall from 64 to 2 while preserving latest-query-31, totalTokens: 10031, and ordering both before child completion.

Closes#5681.

Checklist

This PR is small and focused
I explained what changed and why
No UI changes

Implemented and verified with GPT-5.6-sol in the Codex harness.

Note

Medium Risk
Changes Codex multi-agent event ordering and volume at the provider boundary; mitigated by explicit flush rules, scoped close, and ingestion tests, but could affect UI timing of child task progress.

Overview
Adds makeCodexProgressCoalescer, which batches Codex child-agent task.progress per child thread into separate item and tokenUsage lanes (250ms windows, latest value per lane) before they hit the runtime event queue.

CodexAdapter wires this in per session: collabAgent/item and collabAgent/tokenUsage go through the coalescer; pending lanes are flushed before terminal collab events (turn completed, closed, idle, system error, interruption). Session stop and failed start close the coalescer so nothing emits after shutdown.

Tests cover coalescer timing/races/isolation, adapter flush ordering and post-close behavior, and an end-to-end ingestion case where a 32× burst of child updates yields two durable task.progress activities (latest query + token totals) still ordered before child completion.

^{Reviewed by Cursor Bugbot for commit 8d27611. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Coalesce Codex child agent progress events before durable activity ingestion

Introduces makeCodexProgressCoalescer, a scoped utility that batches task.progress events per child agent thread into two lanes (item and tokenUsage) within a 250ms fixed window, emitting only the newest value per lane.
Integrates the coalescer into makeCodexAdapter: child progress events are routed through the coalescer and flushed before terminal collabAgent lifecycle events (turn completed, closed, interrupted, idle, or system error).
Ensures the coalescer is closed on session stop and on start failure to cancel any pending emissions.
Behavioral Change: child task.progress events are no longer emitted individually — only the latest value per lane within each window is forwarded to ingestion.

^{Macroscope summarized 8d27611.}

coderabbitai · 2026-08-10T13:10:28Z

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: d1d811d6-4797-4b4d-ac70-ac90e796e62f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

macroscopeapp

One convention finding: the new coalescer's public interface is re-declared locally in CodexAdapter.ts instead of being imported from its owning module. Everything else in the changed scope (namespace subpath imports, scoped make construction, callback-based emit rather than service injection, test-only service instance passing) follows the conventions.

^{Posted via Macroscope — Effect Service Conventions}

macroscopeapp · 2026-08-10T13:18:58Z

Approvability

Verdict: Needs human review

This PR introduces a new CodexProgressCoalescer utility that changes how child progress events are processed - adding 250ms windowed batching before durable ingestion. This is substantial new runtime behavior affecting event timing and coalescing, not a simple fix.

^{You can customize Macroscope's approvability policy. Learn more.}

Coalesce Codex child item and token-usage notifications independently per session and child before provider runtime ingestion. Flush pending progress before terminal lifecycle events and cancel pending work when the runtime closes. Add focused adapter and ingestion coverage for bounded durable event volume, latest-value preservation, terminal ordering, isolation, and shutdown.

Semantically ports pingdotgg#6004 onto current main and flushes buffered progress before identity refinements as well as terminal lifecycle events.

cheruvian · 2026-08-10T13:10:17Z

What Changed

Coalesce Codex child item and token-usage progress independently per session and child before provider runtime ingestion.
Keep separate latest-value lanes and flush them before child completion, close, failure, idle, and interruption events.
Cancel scoped best-effort progress work during session shutdown so it cannot emit after close.
Add focused race, isolation, lifecycle-ordering, shutdown, and durable-ingestion coverage.

Why

Codex can emit child item and cumulative token-usage notifications at high frequency. Each notification previously became its own task.progress, durable thread.activity-appended event, and serial projection input, delaying unrelated threads even though the final projection retained only the newest values.

For the representative 32-item and 32-usage burst, durable child progress events fall from 64 to 2 while preserving latest-query-31, totalTokens: 10031, and ordering both before child completion.

Closes#5681.

Checklist

This PR is small and focused
I explained what changed and why
No UI changes

Implemented and verified with GPT-5.6-sol in the Codex harness.

Note

Medium Risk
Changes Codex multi-agent event ordering and volume at the provider boundary; mitigated by explicit flush rules, scoped close, and ingestion tests, but could affect UI timing of child task progress.

Overview
Adds makeCodexProgressCoalescer, which batches Codex child-agent task.progress per child thread into separate item and tokenUsage lanes (250ms windows, latest value per lane) before they hit the runtime event queue.

CodexAdapter wires this in per session: collabAgent/item and collabAgent/tokenUsage go through the coalescer; pending lanes are flushed before terminal collab events (turn completed, closed, idle, system error, interruption). Session stop and failed start close the coalescer so nothing emits after shutdown.

Tests cover coalescer timing/races/isolation, adapter flush ordering and post-close behavior, and an end-to-end ingestion case where a 32× burst of child updates yields two durable task.progress activities (latest query + token totals) still ordered before child completion.

^{Reviewed by Cursor Bugbot for commit 8d27611. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Coalesce Codex child agent progress events before durable activity ingestion

Introduces makeCodexProgressCoalescer, a scoped utility that batches task.progress events per child agent thread into two lanes (item and tokenUsage) within a 250ms fixed window, emitting only the newest value per lane.
Integrates the coalescer into makeCodexAdapter: child progress events are routed through the coalescer and flushed before terminal collabAgent lifecycle events (turn completed, closed, interrupted, idle, or system error).
Ensures the coalescer is closed on session stop and on start failure to cancel any pending emissions.
Behavioral Change: child task.progress events are no longer emitted individually — only the latest value per lane within each window is forwarded to ingestion.

^{Macroscope summarized 8d27611.}

coderabbitai · 2026-08-10T13:10:28Z

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: d1d811d6-4797-4b4d-ac70-ac90e796e62f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

macroscopeapp

One convention finding: the new coalescer's public interface is re-declared locally in CodexAdapter.ts instead of being imported from its owning module. Everything else in the changed scope (namespace subpath imports, scoped make construction, callback-based emit rather than service injection, test-only service instance passing) follows the conventions.

^{Posted via Macroscope — Effect Service Conventions}

macroscopeapp · 2026-08-10T13:18:58Z

Approvability

Verdict: Needs human review

This PR introduces a new CodexProgressCoalescer utility that changes how child progress events are processed - adding 250ms windowed batching before durable ingestion. This is substantial new runtime behavior affecting event timing and coalescing, not a simple fix.

^{You can customize Macroscope's approvability policy. Learn more.}

Coalesce Codex child item and token-usage notifications independently per session and child before provider runtime ingestion. Flush pending progress before terminal lifecycle events and cancel pending work when the runtime closes. Add focused adapter and ingestion coverage for bounded durable event volume, latest-value preservation, terminal ordering, isolation, and shutdown.

Semantically ports pingdotgg#6004 onto current main and flushes buffered progress before identity refinements as well as terminal lifecycle events.

cheruvian · 2026-08-10T13:10:17Z

What Changed

Coalesce Codex child item and token-usage progress independently per session and child before provider runtime ingestion.
Keep separate latest-value lanes and flush them before child completion, close, failure, idle, and interruption events.
Cancel scoped best-effort progress work during session shutdown so it cannot emit after close.
Add focused race, isolation, lifecycle-ordering, shutdown, and durable-ingestion coverage.

Why

Codex can emit child item and cumulative token-usage notifications at high frequency. Each notification previously became its own task.progress, durable thread.activity-appended event, and serial projection input, delaying unrelated threads even though the final projection retained only the newest values.

For the representative 32-item and 32-usage burst, durable child progress events fall from 64 to 2 while preserving latest-query-31, totalTokens: 10031, and ordering both before child completion.

Closes#5681.

Checklist

This PR is small and focused
I explained what changed and why
No UI changes

Implemented and verified with GPT-5.6-sol in the Codex harness.

Note

Medium Risk
Changes Codex multi-agent event ordering and volume at the provider boundary; mitigated by explicit flush rules, scoped close, and ingestion tests, but could affect UI timing of child task progress.

Overview
Adds makeCodexProgressCoalescer, which batches Codex child-agent task.progress per child thread into separate item and tokenUsage lanes (250ms windows, latest value per lane) before they hit the runtime event queue.

CodexAdapter wires this in per session: collabAgent/item and collabAgent/tokenUsage go through the coalescer; pending lanes are flushed before terminal collab events (turn completed, closed, idle, system error, interruption). Session stop and failed start close the coalescer so nothing emits after shutdown.

Tests cover coalescer timing/races/isolation, adapter flush ordering and post-close behavior, and an end-to-end ingestion case where a 32× burst of child updates yields two durable task.progress activities (latest query + token totals) still ordered before child completion.

^{Reviewed by Cursor Bugbot for commit 8d27611. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Coalesce Codex child agent progress events before durable activity ingestion

Introduces makeCodexProgressCoalescer, a scoped utility that batches task.progress events per child agent thread into two lanes (item and tokenUsage) within a 250ms fixed window, emitting only the newest value per lane.
Integrates the coalescer into makeCodexAdapter: child progress events are routed through the coalescer and flushed before terminal collabAgent lifecycle events (turn completed, closed, interrupted, idle, or system error).
Ensures the coalescer is closed on session stop and on start failure to cancel any pending emissions.
Behavioral Change: child task.progress events are no longer emitted individually — only the latest value per lane within each window is forwarded to ingestion.

^{Macroscope summarized 8d27611.}

coderabbitai · 2026-08-10T13:10:28Z

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: d1d811d6-4797-4b4d-ac70-ac90e796e62f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

macroscopeapp

One convention finding: the new coalescer's public interface is re-declared locally in CodexAdapter.ts instead of being imported from its owning module. Everything else in the changed scope (namespace subpath imports, scoped make construction, callback-based emit rather than service injection, test-only service instance passing) follows the conventions.

^{Posted via Macroscope — Effect Service Conventions}

macroscopeapp · 2026-08-10T13:18:58Z

Approvability

Verdict: Needs human review

This PR introduces a new CodexProgressCoalescer utility that changes how child progress events are processed - adding 250ms windowed batching before durable ingestion. This is substantial new runtime behavior affecting event timing and coalescing, not a simple fix.

^{You can customize Macroscope's approvability policy. Learn more.}

Coalesce Codex child item and token-usage notifications independently per session and child before provider runtime ingestion. Flush pending progress before terminal lifecycle events and cancel pending work when the runtime closes. Add focused adapter and ingestion coverage for bounded durable event volume, latest-value preservation, terminal ordering, isolation, and shutdown.

Semantically ports pingdotgg#6004 onto current main and flushes buffered progress before identity refinements as well as terminal lifecycle events.

cheruvian · 2026-08-10T13:10:17Z

What Changed

Coalesce Codex child item and token-usage progress independently per session and child before provider runtime ingestion.
Keep separate latest-value lanes and flush them before child completion, close, failure, idle, and interruption events.
Cancel scoped best-effort progress work during session shutdown so it cannot emit after close.
Add focused race, isolation, lifecycle-ordering, shutdown, and durable-ingestion coverage.

Why

Codex can emit child item and cumulative token-usage notifications at high frequency. Each notification previously became its own task.progress, durable thread.activity-appended event, and serial projection input, delaying unrelated threads even though the final projection retained only the newest values.

For the representative 32-item and 32-usage burst, durable child progress events fall from 64 to 2 while preserving latest-query-31, totalTokens: 10031, and ordering both before child completion.

Closes#5681.

Checklist

This PR is small and focused
I explained what changed and why
No UI changes

Implemented and verified with GPT-5.6-sol in the Codex harness.

Note

Medium Risk
Changes Codex multi-agent event ordering and volume at the provider boundary; mitigated by explicit flush rules, scoped close, and ingestion tests, but could affect UI timing of child task progress.

Overview
Adds makeCodexProgressCoalescer, which batches Codex child-agent task.progress per child thread into separate item and tokenUsage lanes (250ms windows, latest value per lane) before they hit the runtime event queue.

CodexAdapter wires this in per session: collabAgent/item and collabAgent/tokenUsage go through the coalescer; pending lanes are flushed before terminal collab events (turn completed, closed, idle, system error, interruption). Session stop and failed start close the coalescer so nothing emits after shutdown.

Tests cover coalescer timing/races/isolation, adapter flush ordering and post-close behavior, and an end-to-end ingestion case where a 32× burst of child updates yields two durable task.progress activities (latest query + token totals) still ordered before child completion.

^{Reviewed by Cursor Bugbot for commit 8d27611. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Coalesce Codex child agent progress events before durable activity ingestion

Introduces makeCodexProgressCoalescer, a scoped utility that batches task.progress events per child agent thread into two lanes (item and tokenUsage) within a 250ms fixed window, emitting only the newest value per lane.
Integrates the coalescer into makeCodexAdapter: child progress events are routed through the coalescer and flushed before terminal collabAgent lifecycle events (turn completed, closed, interrupted, idle, or system error).
Ensures the coalescer is closed on session stop and on start failure to cancel any pending emissions.
Behavioral Change: child task.progress events are no longer emitted individually — only the latest value per lane within each window is forwarded to ingestion.

^{Macroscope summarized 8d27611.}

coderabbitai · 2026-08-10T13:10:28Z

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: d1d811d6-4797-4b4d-ac70-ac90e796e62f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

macroscopeapp

One convention finding: the new coalescer's public interface is re-declared locally in CodexAdapter.ts instead of being imported from its owning module. Everything else in the changed scope (namespace subpath imports, scoped make construction, callback-based emit rather than service injection, test-only service instance passing) follows the conventions.

^{Posted via Macroscope — Effect Service Conventions}

macroscopeapp · 2026-08-10T13:18:58Z

Approvability

Verdict: Needs human review

This PR introduces a new CodexProgressCoalescer utility that changes how child progress events are processed - adding 250ms windowed batching before durable ingestion. This is substantial new runtime behavior affecting event timing and coalescing, not a simple fix.

^{You can customize Macroscope's approvability policy. Learn more.}

Coalesce Codex child item and token-usage notifications independently per session and child before provider runtime ingestion. Flush pending progress before terminal lifecycle events and cancel pending work when the runtime closes. Add focused adapter and ingestion coverage for bounded durable event volume, latest-value preservation, terminal ordering, isolation, and shutdown.

Semantically ports pingdotgg#6004 onto current main and flushes buffered progress before identity refinements as well as terminal lifecycle events.

cheruvian · 2026-08-10T13:10:17Z

What Changed

Coalesce Codex child item and token-usage progress independently per session and child before provider runtime ingestion.
Keep separate latest-value lanes and flush them before child completion, close, failure, idle, and interruption events.
Cancel scoped best-effort progress work during session shutdown so it cannot emit after close.
Add focused race, isolation, lifecycle-ordering, shutdown, and durable-ingestion coverage.

Why

Codex can emit child item and cumulative token-usage notifications at high frequency. Each notification previously became its own task.progress, durable thread.activity-appended event, and serial projection input, delaying unrelated threads even though the final projection retained only the newest values.

For the representative 32-item and 32-usage burst, durable child progress events fall from 64 to 2 while preserving latest-query-31, totalTokens: 10031, and ordering both before child completion.

Closes#5681.

Checklist

This PR is small and focused
I explained what changed and why
No UI changes

Implemented and verified with GPT-5.6-sol in the Codex harness.

Note

Medium Risk
Changes Codex multi-agent event ordering and volume at the provider boundary; mitigated by explicit flush rules, scoped close, and ingestion tests, but could affect UI timing of child task progress.

Overview
Adds makeCodexProgressCoalescer, which batches Codex child-agent task.progress per child thread into separate item and tokenUsage lanes (250ms windows, latest value per lane) before they hit the runtime event queue.

CodexAdapter wires this in per session: collabAgent/item and collabAgent/tokenUsage go through the coalescer; pending lanes are flushed before terminal collab events (turn completed, closed, idle, system error, interruption). Session stop and failed start close the coalescer so nothing emits after shutdown.

Tests cover coalescer timing/races/isolation, adapter flush ordering and post-close behavior, and an end-to-end ingestion case where a 32× burst of child updates yields two durable task.progress activities (latest query + token totals) still ordered before child completion.

^{Reviewed by Cursor Bugbot for commit 8d27611. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Coalesce Codex child agent progress events before durable activity ingestion

Introduces makeCodexProgressCoalescer, a scoped utility that batches task.progress events per child agent thread into two lanes (item and tokenUsage) within a 250ms fixed window, emitting only the newest value per lane.
Integrates the coalescer into makeCodexAdapter: child progress events are routed through the coalescer and flushed before terminal collabAgent lifecycle events (turn completed, closed, interrupted, idle, or system error).
Ensures the coalescer is closed on session stop and on start failure to cancel any pending emissions.
Behavioral Change: child task.progress events are no longer emitted individually — only the latest value per lane within each window is forwarded to ingestion.

^{Macroscope summarized 8d27611.}

coderabbitai · 2026-08-10T13:10:28Z

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: d1d811d6-4797-4b4d-ac70-ac90e796e62f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

macroscopeapp

One convention finding: the new coalescer's public interface is re-declared locally in CodexAdapter.ts instead of being imported from its owning module. Everything else in the changed scope (namespace subpath imports, scoped make construction, callback-based emit rather than service injection, test-only service instance passing) follows the conventions.

^{Posted via Macroscope — Effect Service Conventions}

macroscopeapp · 2026-08-10T13:18:58Z

Approvability

Verdict: Needs human review

This PR introduces a new CodexProgressCoalescer utility that changes how child progress events are processed - adding 250ms windowed batching before durable ingestion. This is substantial new runtime behavior affecting event timing and coalescing, not a simple fix.

^{You can customize Macroscope's approvability policy. Learn more.}

Coalesce Codex child item and token-usage notifications independently per session and child before provider runtime ingestion. Flush pending progress before terminal lifecycle events and cancel pending work when the runtime closes. Add focused adapter and ingestion coverage for bounded durable event volume, latest-value preservation, terminal ordering, isolation, and shutdown.

Semantically ports pingdotgg#6004 onto current main and flushes buffered progress before identity refinements as well as terminal lifecycle events.

github-actionsBot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:L 100-499 changed lines (additions + deletions). labels Aug 10, 2026

macroscopeappBot reviewed Aug 10, 2026
View reviewed changes

Comment threadapps/server/src/provider/Layers/CodexAdapter.ts Outdated

cheruvian force-pushed the release/coalesce-codex-progress-ingestion branch from a0e69c6 to 8d27611Compare August 10, 2026 14:34

joshfcc mentioned this pull request Aug 17, 2026
[Bug]: Codex subagent progress floods orchestration ingestion and delays unrelated threads #5681
Open
2 tasks

This was referenced Aug 28, 2026
fix(server): bound Codex subagent progress events #5682
Closed
fix(server): dedupe codex subagent item events #5634
Closed

t3dotgg mentioned this pull request Sep 1, 2026
perf(server): skip full-message reads while streaming #9032
Merged