Uh oh!
There was an error while loading. Please reload this page.
fix(swift-ios): enable granular text selection - #6110
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
saphid
commented
Aug 11, 2026
Phone acceptance update: Alex confirmed that text selection is working on the physical phone. This PR is ready for maintainer review. The stale provider-catalog native test fixture is fixed in #6130, and this branch carries the same focused test repair; the current SwiftUI native check is green. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 2ae671d. Configure here.
| block: blocks[index], | ||
| selectionContext: selectionContext, | ||
| textColor: textColor | ||
| ) |
There was a problem hiding this comment.
Dynamic Type updates get skipped
Medium Severity
MarkdownInlineText now bakes fonts from @Environment(\.dynamicTypeSize), but its parent MarkdownBlockView still uses .equatable() and only compares block, selectionContext, and textColor. When Dynamic Type changes alone, equality stays true, so body is skipped and selectable text keeps the old size. This is a regression from the previous Text + text-style Font path, which scaled without an environment read. File previews have no cell reconfigure workaround.
Additional Locations (2)
Reviewed by Cursor Bugbot for commit 2ae671d. Configure here.
ApprovabilityVerdict: Needs human review This PR introduces a new granular text selection feature with significant new UIKit bridging code and selection state management (~700 lines). An unresolved review comment also identifies a potential Dynamic Type accessibility regression. Human review is recommended for this new capability. You can customize Macroscope's approvability policy. Learn more. |
| selectionContext: selectionContext, | ||
| textColor: textColor | ||
| ) | ||
| .equatable() |
There was a problem hiding this comment.
MarkdownInlineText now derives UIKit fonts from dynamicTypeSize, but this equatable boundary does not include that environment value. a Dynamic Type-only change can skip rebuilding unchanged blocks, leaving selectable text at the old size. include the size/category in the equatable inputs or remove this equality optimization for these blocks.
There was a problem hiding this comment.
correction after independent review: the prior Dynamic Type concern is not blocking. the UIKit representable directly reads dynamicTypeSize, includes it in its attributed-text cache key, and has focused scaling coverage. selection remains block-scoped and the many-UITextView layout cost is worth monitoring, but neither is a correctness blocker for this PR. approved.
50bd5cb
into
pingdotgg:t3code/rebuild-mobile-app-swiftUh oh!
There was an error while loading. Please reload this page.
What Changed
Why
The native SwiftUI thread view only offered whole-message copying. People could not select a word, sentence, or code fragment with standard iOS selection handles.
This adds granular native selection while keeping message-level copy actions, streaming updates, accessibility actions, safe link routing, and the existing Markdown layout behavior.
Closes#6089.
UI Changes
Long-pressing rendered assistant prose or code now shows the native iOS selection handles and edit menu (Copy, Look Up, Translate). The appearance of messages is otherwise unchanged.
Verified in the iOS Simulator inside a live thread: native selection appeared on prose and the existing code-block controls remained available. A physical-phone acceptance pass will be attached after the approved-based combined build is installed.
Verification
MarkdownDocumentTests: 15 passed, 0 failed on iOS Simulatorgit diff --check: passedChecklist
Implemented with GPT-5.6 Sol in T3 Code/Codex. Independently reviewed by Claude Opus 5 high.
Note
Enable granular text selection in markdown messages using UITextView
Text-based inline rendering with aUIViewRepresentablewrappingUITextView(MarkdownInlineText), enabling native per-word/character text selection without a toggle.MarkdownSelectableTextAttributesto centrally buildNSAttributedStringfrom inline markdown runs, applying dynamic type, link handling, inline code monospacing, and strikethrough.MarkdownSelectionRestorationto preserve the user's selection range across streaming updates when the new text safely extends the previous text.selectionContextandtextColorthroughMarkdownBlocksView,MarkdownBlockView,MarkdownTableView,MarkdownListView, andMarkdownCodeBlockViewso all message content is selectable.copyActionTitletoMarkdownMessageView, used in both the accessibility action and the UITextView edit menu; file previews use "Copy file contents".MarkdownTextSelectionModifiertoggle is removed; text selection is always active via UIKit.Macroscope summarized 2ae671d.
Note
Medium Risk
Large UIKit bridge in the hot-path transcript with streaming selection and layout sizing; behavior changes for table cell accessibility and keyboard dismissal on scroll.
Overview
Chat markdown now renders inline content through
UITextView-backed views instead of SwiftUIText, so users get native selection handles and the system edit menu across paragraphs, headings, lists, tables, and code bodies.A
MarkdownSelectionContextcarries the full message (or file) text and a configurable copy title into each text view; the delegate adds Copy message / Copy file contents to the selection menu and keeps message-level copy via accessibility actions.MarkdownSelectionRestorationpreserves the selected range while streaming only when new text extends the previous string.Rendering moves inline styling to
MarkdownSelectableTextAttributesandMarkdownInlineStyle.uiFont(Dynamic Type), adds shared UIKit theme colors for text views, and pre-renders code blocks as literal.codeinline runs (reused from cache). The old context-menu “Select text” toggle is removed.Transcript scrolling no longer calls
endEditingon drag; keyboard dismissal goes through the existingonDismissKeyboardpath. Tests cover formatting, Dynamic Type, code reuse, and selection restoration; home metadata tests switch toprovidersByEnvironmentfixtures.Reviewed by Cursor Bugbot for commit 2ae671d. Bugbot is set up for automated code reviews on this repo. Configure here.
Delivery: direct
Validated against Theo commit: f98cab5
Depends on: none
Merge order: this PR only
Validation status: Mergeable; native/repository checks and current review are green. The unrelated Vercel authorization failure is a maintainer-side gate.