Uh oh!
There was an error while loading. Please reload this page.
feat(swift-ios): start a new thread on the same branch - #6136
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
91798e9 to
1d42279CompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
1d42279 to
ea3164cCompareUh oh!
There was an error while loading. Please reload this page.
ea3164c to
bea7ff2Comparebea7ff2 to
0567c56CompareUh oh!
There was an error while loading. Please reload this page.
0567c56 to
2735404CompareUh oh!
There was an error while loading. Please reload this page.
saphid
commented
Aug 15, 2026
Closing this version while I rebuild the upstream contribution set from the latest base. Clean versions are coming soon. |
What changed
Adds a thread-row action that opens a fresh task composer on the source thread's exact project, environment, branch, and checkout. The seed is revalidated before presentation and again against the composer's branch data; stale rows, missing projects, ordinary deleted branches, and missing recorded worktrees produce explicit disabled/error states instead of silently choosing another checkout.
This is the same-branch seeding slice after #6135. It does not add Mark unread.
Why
Starting follow-up work on the same checkout should be one deliberate action, but only when the original checkout identity can still be proven.
Verification
27354049691798e9abeaa46cd546bf76db883f8a72f315641through repaired feat(swift-ios): add thread snooze presets #6135; the isolated commit also incorporates reviewed correctness fixesThreadNewTaskSeedTests: 8 passed, 0 failed; cumulative final focused run: 59 tests in 5 suites passedapps/swift-ios/Scripts/ci-test.sh: 268 tests in 33 suites passed; fixture check andgit diff --check: passedUI evidence
Short interaction video · evidence release and provenance
The exact-final Simulator build preserved the full row action and the prior exact seeded-composer pass remains the accepted interaction proof. The client deliberately refuses a missing recorded worktree rather than silently re-seeding it; that stricter native behavior is covered and explicit.
Review state
Keep this draft until #6117, #6134, and #6135 land. The cumulative PR is XL and needs maintainer alignment; the intended review unit is the isolated commit above. Revalidate and simplify after each parent lands.
Delivery: chain
Validated against Theo commit: f98cab5
Depends on: #6117, #6134, #6135
Merge order: #6117 → #6134 → #6135 → #6136
Validation status: Exact-head relevant CI is green on
273540496, including Contract fixtures and native tests. Macroscope's only current-head comment is valid butgit blameconfirms it is inherited unchanged from #6117; it was routed back to that dependency and resolved in this child's scope. Revalidate after each parent lands. Vercel marketing is a fork-authorization failure, and CodeRabbit skipped automatic review.Implemented and verified by GPT-5.6 Sol in T3 Code using the Codex harness.